Context Navigation

Make sure empty tables honor CSS-specified heights when they have no rows or sections. This is done only
in strict mode, since it is not compatible with WinIE.

khtml/rendering/render_table.cpp: (RenderTable::layout):

2:45 PM Changeset in webkit [9021] by hyatt

20 edits in trunk/LayoutTests

Update layout tests for Tiger.

1:36 PM Changeset in webkit [9020] by hyatt

2 edits in trunk/WebCore

Fix for row 13 of the Acid2 test. Change HTML comment parsing in strict mode to do proper SGML parsing,
checking for pairs of -- and only being willing to close the comment if every -- is paired up.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):

9:45 AM Changeset in webkit [9019] by mjs

4 edits in trunk/WebCore

Reviewed by Richard.

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

khtml/ecma/kjs_binding.cpp: (UString::UString):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):

3:53 AM Changeset in webkit [9018] by hyatt

2 edits in trunk/WebCore

Fix the six pixel gap between rows nine and ten of the Acid2 test. Make sure that percentage heights that
resolve to auto are properly treated as though they have auto height by the self-collapsing block check (as per
section 8.3.1, paragraph 7 of the CSS2.1 spec).

khtml/rendering/render_block.cpp: (khtml::RenderBlock::isSelfCollapsingBlock):

3:51 AM Changeset in webkit [9017] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Fix a mistake in render_box.cpp.

3:05 AM Changeset in webkit [9016] by hyatt

1 edit in trunk/WebCore/khtml/khtmlview.cpp

Add bulletproof null check to previous check-in

2:52 AM Changeset in webkit [9015] by hyatt

4 edits in trunk/WebCore

The Acid2 test and the reference rendering both make use of overflow:hidden on the <html> element. Turns out
the CSS2.1 wording for this behavior has been revised (based off WinIE/Mozilla behavior). Change our behavior
to match and make <html> overflow apply to the viewport.

khtml/khtmlview.cpp: (KHTMLView::applyOverflowToViewport): (KHTMLView::layout):
khtml/khtmlview.h:
khtml/rendering/render_box.cpp: (RenderBox::setStyle):

Apr 14, 2005:

6:30 PM Changeset in webkit [9014] by mjs

2 edits in trunk/JavaScriptCore

make fast_malloc.h a private header, not project

JavaScriptCore.pbproj/project.pbxproj:

6:26 PM Changeset in webkit [9013]

5 copies in branches/gcc-4-0-branch

This commit was manufactured by cvs2svn to create branch
'gcc-4-0-branch'.

6:26 PM Changeset in webkit [9012]

5 copies in tags/gcc-4-0-anchor

This commit was manufactured by cvs2svn to create tag
'gcc-4-0-anchor'.

6:26 PM Changeset in webkit [9011]

5 copies in branches/Pan-2005-007-branch

This commit was manufactured by cvs2svn to create branch
'Pan-2005-007-branch'.

6:26 PM Changeset in webkit [9010]

5 copies in tags/Pan-2005-007-anchor

This commit was manufactured by cvs2svn to create tag
'Pan-2005-007-anchor'.

6:26 PM Changeset in webkit [9009] by mjs

9 edits
2 adds in trunk/JavaScriptCore

Reviewed by Richard.

<rdar://problem/4089734> JavaScript iBench can be sped up ~10% with custom allocator

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

JavaScriptCore.pbproj/project.pbxproj:
kjs/collector.cpp: (KJS::Collector::allocate): Use dlmalloc to allocate the collector blocks. (KJS::Collector::collect): And dlfree to free it.
kjs/fast_malloc.cpp: Added, just the standard dlmalloc here.
kjs/fast_malloc.h: Added. Declarations for the functions. Also added a handy macro to give a class custom operator new/delete
kjs/identifier.cpp: (KJS::Identifier::add): Use dlmalloc/dlfree.
kjs/nodes.h: make nodes KJS_FAST_ALLOCATED.
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Use dlmalloc/dlfree. (KJS::PropertyMap::rehash): ditto
kjs/scope_chain.h:
kjs/ustring.cpp: (KJS::UString::Rep::createCopying): New named constructor that copies a passed-in buffer, to hide allocation details from webcore. (KJS::UString::UString): use createCopying when appropriate. (KJS::UString::Rep::destroy): Use dlmalloc/dlfree. (KJS::UString::expandedSize): likewise (KJS::UString::expandCapacity): likewise (KJS::UString::expandPreCapacity): likewise (KJS::UString::spliceSubstringsWithSeparators): likewise (KJS::UString::append): likewise (KJS::UString::operator=): likewise (KJS::UString::detach): likewise
kjs/ustring.h: make UString and UString::Rep KJS_FAST_ALLOCATED.

11:33 AM Changeset in webkit [9008]

1 copy in branches/experimental-db

This commit was manufactured by cvs2svn to create branch
'experimental-db'.

11:33 AM Changeset in webkit [9007] by hyatt

3 edits in trunk/WebCore

3258403 and 3258402 can now be fixed. min/max-width/height support is now complete. This patch makes them
work for positioned elements and enables us to pass row one of the Acid2 test.

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
khtml/rendering/render_box.h:

10:19 AM Changeset in webkit [9006] by sullivan

3 edits in trunk/WebKit

Reviewed by Chris.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Beefed up assertion that's been bugging me and Chris to include the two troublemaking values.

Apr 12, 2005:

3:49 PM Changeset in webkit [9005] by hyatt

6 edits in trunk/WebCore

Working on the Acid2 test, Row 1.

Improve checkChild for the DTD so that it knows what mode a document is in. This allows it to adhere more
strictly to the actual DTD in strict mode and almost strict mode.

Change the <table>-inside-<p> check so that <table> is disallowed inside <p> in
strict mode and almost strict mode. This matches Firefox behavior, which allows <table>
inside <p> only in quirks mode.

khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/dtd.h:
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
khtml/xml/dom_elementimpl.cpp: (ElementImpl::childAllowed):

3:37 PM Changeset in webkit [9004] by vicki

8 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function

khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
khtml/dom/dom_doc.h:
khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
khtml/ecma/kjs_dom.lut.h: (KJS::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
khtml/xml/dom_docimpl.h:

3:18 PM Changeset in webkit [9003] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by John.

<rdar://problem/4086819> Avoid using protect count hash table so much for 5.6% JS iBench speedup

Avoid using protected values hash for the two most common cases
Bump up ListImp high water mark, new testing shows 508 ListImps are created during JS iBench.

Net result is a 5.6% speedup on JavaScript iBench

kjs/collector.cpp: (KJS::Collector::collect): mark protected lists as appropriate.
kjs/context.h:
kjs/list.cpp: (KJS::ListImp::markValues): Moved implementation from List::markValues (KJS::List::markProtectedLists): Implemented - scan pool and overflow list. (KJS::allocateListImp): link lists outside the pool into a separate doubly linked list to be able to mark protected lists (KJS::deallocateListImp): do the corresponding delinking (KJS::List::derefValues): do nothing in conservative GC mode (KJS::List::refValues): do nothing in conservative GC mode (KJS::List::markValues): call ListImp version (KJS::List::append):
kjs/list.h:

3:11 PM Changeset in webkit [9002] by hyatt

3 edits in trunk/WebCore

Beginning of work to support the Acid2 CSS test put forward by the Web Standards Project. Fix
our handling of the rel attribute on <link> elements to do a proper tokenization so that stylesheets
can be recognized even when other keywords are present in the rel attribute.

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseHTMLAttribute): (HTMLLinkElementImpl::tokenizeRelAttribute): (HTMLLinkElementImpl::process):
khtml/html/html_headimpl.h:

8:56 AM Changeset in webkit [9001] by sullivan

1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

Left out an #import in previous checkin.

8:53 AM Changeset in webkit [9000] by sullivan

2 edits in trunk/WebCore

fixed these two bugs (I also fixed these on the experimental-ui-branch) <rdar://problem/3154293> Find Next should not scroll page if the next target is already visible <rdar://problem/3121828> scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Reviewed by Chris.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Trey had written code to address these issues, but left it commented out due to other problems. The other problems no longer occur, so I uncommented Trey's code, and then discovered that I could make it behave more like TextEdit with many fewer lines of code.

8:43 AM Changeset in webkit [8999] by sullivan

2 edits in branches/experimental-ui-branch/WebCore

fixed these two bugs (this is on the branch; I need to roll these into TOT also): <rdar://problem/3154293> Find Next should not scroll page if the next target is already visible <rdar://problem/3121828> scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Reviewed by Chris.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Trey had written code to address these issues, but left it commented out due to other problems. The other problems no longer occur, so I uncommented Trey's code, and then discovered that I could make it behave more like TextEdit with many fewer lines of code.

Apr 11, 2005:

9:07 AM Changeset in webkit [8998] by sullivan

2 edits in branches/experimental-ui-branch/WebKit

Fixed inability to wrap around in Find in Page

WebView.subproj/WebView.m: (-[WebView _searchFor:direction:caseSensitive:wrap:findInSelection:]): changed wrapFlag from NO to YES on two lines (copy/paste error)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed