Timeline
Apr 25, 2005:
- 4:35 PM Changeset in webkit [9049] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Harrison.
- fixed <rdar://problem/4098731> [DOMHTMLTextAreaElement cols] returns wrong value (usually zero)
- kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): use ATTR_COLS instead of ATTR_ACCESSKEY (D'oh!) (-[DOMHTMLTextAreaElement setCols:]): fixed whitespace
- 11:37 AM Changeset in webkit [9048]
-
- 3 copies3 deletes in tags/JavaScriptCore-412~1
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~1'.
- 11:37 AM Changeset in webkit [9047] by
-
- 2 edits in trunk/JavaScriptCore
JavaScriptCore-412.1
- 8:55 AM Changeset in webkit [9046] by
-
- 6 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work
- khtml/xml/dom_docimpl.h: Add virtual functions HTMLElementNamespace and isHTMLNamespace.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Rearranged this function and fixed the following problems: 1) made sure to ref node while attributes are being set on it so it doesn't get destroyed; 2) fixed code to get namespace from the element we are importing to use the IDs from the source document, not the destination document; 3) removed unneeded getDocument() call which just returns this; 4) fixed error handling for cases where an exception happens while processing the children. (DocumentImpl::HTMLElementNamespace): Added. Returns XHTML_NAMESPACE. (DocumentImpl::isHTMLNamespace): Added. Returns true for any namespace that matches XHTML_NAMESPACE (case insensitive). (DocumentImpl::createElementNS): Changed to call isHTMLNamespace, which will cause it to accept the null namespace in an HTML document. This is the change that fixes the bug. Also fixed the code path to do a little less wasteful work in the non-XHTML case. (DocumentImpl::createHTMLElement): Pass in HTMLElementNamespace() rather than 0 to tagId. (DocumentImpl::attrId): Use isHTMLNamespace instead of allowing the null namespace explicitly. (DocumentImpl::tagId): Ditto.
- khtml/html/html_documentimpl.h: Add overrides for HTMLElementNamespace and isHTMLNamespace.
- khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLElementNamespace): Added. Returns 0 so we use the null string for HTML elements inside HTML documents (as before). (HTMLDocumentImpl::isHTMLNamespace): Added. Allows 0, and then calls base class to check for the actual XHTML namespace. Thus, we allow both no namespace at all and the XHTML namespace inside HTML documents.
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::namespaceURI): Changed to call HTMLElementNamespace rather than checking isHTMLDocument. Same result as before, but better division of responsibilities.
- 8:43 AM Changeset in webkit [9045] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item
- kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.
Apr 22, 2005:
- 5:42 PM Changeset in webkit [9044] by
-
- 2 edits4 adds in trunk
Fix for 4096878, drop shadow effect not displayed correctly on tbray.org/ongoing/. Block minmaxwidth was
broken when negative margins were used and did not properly decrease the max width.
Reviewed by Maciej
- khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcBlockMinMaxWidth):
- layout-tests/fast/block/float/034-expected.txt: Added.
- layout-tests/fast/block/float/034.html: Added.
- layout-tests/fast/block/float/035-expected.txt: Added.
- layout-tests/fast/block/float/035.html: Added.
- 5:08 PM Changeset in webkit [9043] by
-
- 3 edits in trunk/WebCore
Remove some dead code from css_valueimpl. It wasn't used at all.
- khtml/css/css_valueimpl.cpp:
- khtml/css/css_valueimpl.h:
- 2:53 PM Changeset in webkit [9042] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.
- 2:19 PM Changeset in webkit [9041] by
-
- 2 edits in trunk/WebCore
- khtml/ecma/kjs_html.h: Removed unnecessary bogus class name qualifiers.
- 11:12 AM Changeset in webkit [9040] by
-
- 2 edits3 adds in trunk
Fix for 4096681, fix regression in how the list-style property is parsed. It no longer parses when it hits
a url in the property value list now, because the list pointer did not get advanced. This fixes alistapart.com.
Reviewed by john
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- layout-tests/fast/lists/009-expected.txt: Added.
- layout-tests/fast/lists/009.html: Added.
- layout-tests/fast/lists/resources/listmark.gif: Added.
- 9:48 AM Changeset in webkit [9039] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by John.
- fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present
- kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.
- kjs/grammar.cpp: Regenerated.
- 9:30 AM Changeset in webkit [9038] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"
- khtml/ecma/kjs_window.h: Added FrameElement.
- khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
- khtml/ecma/kjs_window.lut.h: Regenerated.
- 9:29 AM Changeset in webkit [9037] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- a small editing-related code cleanup
- khtml/rendering/render_text.h: Added positionForOffset and made offsetForPosition const.
- khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Made const. (InlineTextBox::positionForOffset): Added. Moved code here from caretRect. (RenderText::caretRect): Call positionForOffset instead of doing the work here.
Apr 21, 2005:
- 1:55 PM Changeset in webkit [9036] by
-
- 6 edits in trunk/WebCore
Fix for 4095839, wrong background image used on flechtwerk.de. Make sure that the global mapped
attribute cache hashed background attributes into per-document buckets.
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::mapToEntry):
- khtml/html/html_elementimpl.h: (DOM::):
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::mapToEntry): (HTMLTablePartElementImpl::mapToEntry):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
- khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::docID):
- 9:07 AM Changeset in webkit [9035] by
-
- 1 edit2 adds in trunk
- layout test for 4065447, outerHTML on images
- layout-tests/fast/dynamic/outerHTML-img-expected.txt: Added.
- layout-tests/fast/dynamic/outerHTML-img.html: Added.
- 9:02 AM Changeset in webkit [9034] by
-
- 2 edits in trunk/WebCore
Reviewed by hyatt.
- fixed <rdar://problem/4065447> support outerHTML on IMG elements
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
Note:
See TracTimeline
for information about the timeline view.
