Timeline



Apr 26, 2005:

10:52 PM Changeset in webkit [9062] by adele
  • 8 edits in trunk

Fixed by Darin, reviewed by me.

Fix for <rdar://problem/4084029> designMode doesn't allow editing when iframe src = "" or = about:blank

This change will add an HTML element for empty documents. Now that there will be an HTMLDocument in this case,
a body will also be created (see rdar://problem/3758785). This was preventing frames with empty documents from
being editable.

  • khtml/html/htmlparser.cpp: (KHTMLParser::finished):

Updated these tests to expect the HTML and BODY elements

  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/frames/002-expected.txt:
  • layout-tests/fast/frames/contentWindow_Frame-expected.txt:
  • layout-tests/fast/frames/contentWindow_iFrame-expected.txt:
  • layout-tests/fast/frames/empty-frame-src-expected.txt:
6:03 PM Changeset in webkit [9061] by rjw
  • 8 edits in trunk

JavaScriptCore:

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:

Their NPN_SetException has the following signature:

void NPN_SetException(NPObject *npobj, const NPUTF8 *message);

ours has:

void NPN_SetException (NPObject * npobj, const NPString *message);

Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.

I changed both behaviors to match Mozilla.

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (_NPN_SetException):
  • bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:

WebKit:

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

Reviewed by Chris.

  • Plugins.subproj/npfunctions.h:
  • Plugins.subproj/npruntime.h:
5:58 PM Changeset in webkit [9060] by cpetersen
  • 25 edits in branches/Safari-2-0-branch/WebCore

Merged for 3655817 from TOT

Reviewed by Adele.

2005-04-26 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler

Loose ends:

  • need to test behavior of Windows IE with horizontal scroll wheeling; we currently send a distinct event for that relatively obscure case, which means the event handlers won't fire at all; might be incorrect
  • overflow scrolling is done after all DOM event handling, but ideally should be done in the overflowing element's default event handler; not important in practice
  • frame scrolling is done after all DOM event handling, but probably should be done in a default event handler; not sure about this, but it's probably not important in practice and definitely not required
  • JavaScript
  • khtml/ecma/kjs_events.h: Added DOMWheelEvent.
  • khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added a case for wheel event. To be forward looking, I use the event's impl pointer instead of a C++ DOM wrapper. Eventually it will all work this way. (offsetFromTarget): Added. Factored out code to compute offsetX/Y for an event. (DOMMouseEvent::getValueProperty): Changed to call offsetFromTarget for offsetX/Y. (DOMWheelEvent::DOMWheelEvent): Added. (DOMWheelEvent::tryGet): Added. (DOMWheelEvent::getValueProperty): Added. (DOMWheelEventProtoFunc::tryCall): Added. Nothing at the moment, but might get contents later.
  • khtml/ecma/kjs_dom.h: Added OnMouseWheel to the enum with the list of properties.
  • khtml/ecma/kjs_dom.cpp: Added onmousewheel as a property of DOM nodes. (DOMNode::getValueProperty): Return the mouse wheel event handler. (DOMNode::putValue): Set the mouse wheel event handler.
  • khtml/ecma/kjs_window.cpp: Added onmousewheel as a property of the window. (Window::get): Return the mouse wheel event handler. (Window::put): Set the mouse wheel event handler.
  • khtml/ecma/kjs_window.h: Added OnWindowMouseWheel to the enum with the list of properties. (Other properties distinguish the window handler by lower-casing the initial letter, way too subtle, so I did this one a good way.)
  • khtml/dom/dom2_events.h: Made the constructors for Event and UIEvent public. There's no good reason for them to be private, and I had to use the UIEvent one in the JavaScript implementation.
  • DOM
  • khtml/xml/dom2_eventsimpl.h: Added events for mouse wheel and horizontal mouse wheel. Added isWheelEvent function to EventImpl. (DOM::UIEventWithKeyStateImpl): Added. Base class shared by mouse, wheel, and keyboard events. (DOM::MouseRelatedEventImpl): Added. Base class shared by mouse and wheel events. (DOM::WheelEventImpl): Added.
  • khtml/xml/dom2_eventsimpl.cpp: Added "mousewheel" to list of event names and a placeholder for the horizontal mouse wheel. (EventImpl::isWheelEvent): Added. Returns false. (MouseRelatedEventImpl::MouseRelatedEventImpl): Added. Factored out what's shared between mouse events and wheel events to avoid duplicated code. (MouseRelatedEventImpl::computeLayerPos): Moved to MouseRelatedWheelEventImpl. (MouseEventImpl::MouseEventImpl): Changed since MouseRelatedWheelEventImpl is now the base class so we can share more code with wheel events. (KeyboardEventImpl::KeyboardEventImpl): Changed since UIEventWithKeyStateImpl is now the base class so we can share more code with mouse and wheel events. (WheelEventImpl::WheelEventImpl): Added. (WheelEventImpl::isWheelEvent): Added. Returns true.
  • khtml/misc/htmlattrs.in: Added "onmousewheel" attribute name.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Added parsing of the "onmousewheel" atribute, consistent with other event handler attributes.
  • event handling
  • kwq/WebCoreBridge.h: Renamed scrollOverflowWithScrollWheelEvent to sendScrollWheelEvent.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollWheelEvent:]): Renamed.
  • kwq/KWQEvent.h: Added Wheel as an event type value. (QWheelEvent::QWheelEvent): Added.
  • kwq/KWQEvent.mm: (positionForEvent): Updated to know that wheel events have valid positions in them. (orientationForEvent): Added. (deltaForEvent): Added. (QWheelEvent::QWheelEvent): Added.
  • kwq/KWQKHTMLPart.h: Renamed scrollOverflowWithScrollWheelEvent to wheelEvent.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): Renamed and added code to construct a QWheelEvent and send it along to KHTMLView::viewportWheelEvent, consistent with how mouse events work.
  • khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): Do a hit test to figure out which node to send the event to, and then call dispatchWheelEvent.
  • khtml/xml/dom_nodeimpl.h: Added dispatchWheelEvent.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWheelEvent): Added.
  • generated files
  • khtml/ecma/kjs_dom.lut.h: Regenerated.
  • khtml/ecma/kjs_events.lut.h: Regenerated.
  • khtml/ecma/kjs_window.lut.h: Regenerated.
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.
5:18 PM Changeset in webkit [9059] by mjs
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Chris.

<rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com

  • kjs/string_object.cpp: (StringObjectFuncImp::call): Allocate adopted ustring buffer properly.

WebCore:

New test case for <rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com

  • layout-tests/fast/js/string-from-char-code-expected.txt: Added.
  • layout-tests/fast/js/string-from-char-code.html: Added.
5:11 PM Changeset in webkit [9058] by cpetersen
  • 5 edits in branches/Safari-2-0-branch

Merging fix for <rdar://problem/4075576> from TOT

Reviewed by Adele.

2005-04-26 David Harrison <​harrison@apple.com>

Reviewed by Darin, Maciej.

<rdar://problem/4075576> Deleting text in new message borks content

Fixed by removing the methods that attempted to preserve the position. The idea
of preserving position is a very recent one, and turned out to not actually address
the problem it was intended to fix (see below). Further, is unclear how the position
could be preserved in a form that could be properly used later on. Therefore,
removing the code to work like before is the preferred alternative for this software
update. I've written <rdar://problem/4099839> to cover the bug that position
preservation was supposed to fix (but did not). Added layout tests for
both this bug and 4099839. Also, updated existing tests with correct expected results
(delete-at-paragraph-boundaries-003 and 004).

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeFullySelectedNode): (khtml::CompositeEditCommand::removeChildrenInRange): (khtml::DeleteSelectionCommand::handleGeneralDelete):
  • khtml/editing/htmlediting.h:
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
4:36 PM Changeset in webkit [9057] by darin
  • 28 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler

Loose ends:

  • need to test behavior of Windows IE with horizontal scroll wheeling; we currently send a distinct event for that relatively obscure case, which means the event handlers won't fire at all; might be incorrect
  • overflow scrolling is done after all DOM event handling, but ideally should be done in the overflowing element's default event handler; not important in practice
  • frame scrolling is done after all DOM event handling, but probably should be done in a default event handler; not sure about this, but it's probably not important in practice and definitely not required
  • JavaScript
  • khtml/ecma/kjs_events.h: Added DOMWheelEvent.
  • khtml/ecma/kjs_events.cpp: (KJS::getDOMEvent): Added a case for wheel event. To be forward looking, I use the event's impl pointer instead of a C++ DOM wrapper. Eventually it will all work this way. (offsetFromTarget): Added. Factored out code to compute offsetX/Y for an event. (DOMMouseEvent::getValueProperty): Changed to call offsetFromTarget for offsetX/Y. (DOMWheelEvent::DOMWheelEvent): Added. (DOMWheelEvent::tryGet): Added. (DOMWheelEvent::getValueProperty): Added. (DOMWheelEventProtoFunc::tryCall): Added. Nothing at the moment, but might get contents later.
  • khtml/ecma/kjs_dom.h: Added OnMouseWheel to the enum with the list of properties.
  • khtml/ecma/kjs_dom.cpp: Added onmousewheel as a property of DOM nodes. (DOMNode::getValueProperty): Return the mouse wheel event handler. (DOMNode::putValue): Set the mouse wheel event handler.
  • khtml/ecma/kjs_window.cpp: Added onmousewheel as a property of the window. (Window::get): Return the mouse wheel event handler. (Window::put): Set the mouse wheel event handler.
  • khtml/ecma/kjs_window.h: Added OnWindowMouseWheel to the enum with the list of properties. (Other properties distinguish the window handler by lower-casing the initial letter, way too subtle, so I did this one a good way.)
  • khtml/dom/dom2_events.h: Made the constructors for Event and UIEvent public. There's no good reason for them to be private, and I had to use the UIEvent one in the JavaScript implementation.
  • DOM
  • khtml/xml/dom2_eventsimpl.h: Added events for mouse wheel and horizontal mouse wheel. Added isWheelEvent function to EventImpl. (DOM::UIEventWithKeyStateImpl): Added. Base class shared by mouse, wheel, and keyboard events. (DOM::MouseRelatedEventImpl): Added. Base class shared by mouse and wheel events. (DOM::WheelEventImpl): Added.
  • khtml/xml/dom2_eventsimpl.cpp: Added "mousewheel" to list of event names and a placeholder for the horizontal mouse wheel. (EventImpl::isWheelEvent): Added. Returns false. (MouseRelatedEventImpl::MouseRelatedEventImpl): Added. Factored out what's shared between mouse events and wheel events to avoid duplicated code. (MouseRelatedEventImpl::computeLayerPos): Moved to MouseRelatedWheelEventImpl. (MouseEventImpl::MouseEventImpl): Changed since MouseRelatedWheelEventImpl is now the base class so we can share more code with wheel events. (KeyboardEventImpl::KeyboardEventImpl): Changed since UIEventWithKeyStateImpl is now the base class so we can share more code with mouse and wheel events. (WheelEventImpl::WheelEventImpl): Added. (WheelEventImpl::isWheelEvent): Added. Returns true.
  • khtml/misc/htmlattrs.in: Added "onmousewheel" attribute name.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Added parsing of the "onmousewheel" atribute, consistent with other event handler attributes.
  • event handling
  • kwq/WebCoreBridge.h: Renamed scrollOverflowWithScrollWheelEvent to sendScrollWheelEvent.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendScrollWheelEvent:]): Renamed.
  • kwq/KWQEvent.h: Added Wheel as an event type value. (QWheelEvent::QWheelEvent): Added.
  • kwq/KWQEvent.mm: (positionForEvent): Updated to know that wheel events have valid positions in them. (orientationForEvent): Added. (deltaForEvent): Added. (QWheelEvent::QWheelEvent): Added.
  • kwq/KWQKHTMLPart.h: Renamed scrollOverflowWithScrollWheelEvent to wheelEvent.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::wheelEvent): Renamed and added code to construct a QWheelEvent and send it along to KHTMLView::viewportWheelEvent, consistent with how mouse events work.
  • khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): Do a hit test to figure out which node to send the event to, and then call dispatchWheelEvent.
  • khtml/xml/dom_nodeimpl.h: Added dispatchWheelEvent.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWheelEvent): Added.
  • generated files
  • khtml/ecma/kjs_dom.lut.h: Regenerated.
  • khtml/ecma/kjs_events.lut.h: Regenerated.
  • khtml/ecma/kjs_window.lut.h: Regenerated.
  • khtml/misc/htmlattrs.c: Regenerated.
  • khtml/misc/htmlattrs.h: Regenerated.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3655817> please add support for mouse wheel events and the onmousewheel handler
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView scrollWheel:]): Call sendScrollWheelEvent: method instead of the old scrollOverflowWithScrollWheelEvent: (just a name change).
3:50 PM Changeset in webkit [9056] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

2005-04-26 chris petersen <​cpetersen@apple.com>

Merging fix for <rdar://problem/4069161> from TOT

Reviewed by Adele.

2005-03-28 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4069161> REGRESSION (8A416-8A419): Safari crash bringing up context menu for non-HTML content in a frame

  • kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]): Nil-check node variable instead of rechecking document variable.
3:50 PM Changeset in webkit [9055]
  • 6 copies in branches/Safari-2-0-branch

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

3:39 PM Changeset in webkit [9054] by harrison
  • 5 edits
    8 adds in trunk

Reviewed by Darin, Maciej.

<rdar://problem/4075576> Deleting text in new message borks content

Fixed by removing the methods that attempted to preserve the position. The idea
of preserving position is a very recent one, and turned out to not actually address
the problem it was intended to fix (see below). Further, is unclear how the position
could be preserved in a form that could be properly used later on. Therefore,
removing the code to work like before is the preferred alternative for this software
update. I've written <rdar://problem/4099839> to cover the bug that position
preservation was supposed to fix (but did not). Added layout tests for
both this bug and 4099839. Also, updated existing tests with correct expected results
(delete-at-paragraph-boundaries-003 and 004).

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeFullySelectedNode): (khtml::CompositeEditCommand::removeChildrenInRange): (khtml::DeleteSelectionCommand::handleGeneralDelete):
  • khtml/editing/htmlediting.h:
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-007.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-008.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-009.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-010.html: Added.
2:20 PM Changeset in webkit [9053] by darin
  • 2 edits in trunk/WebCore
  • fixed development builds
  • khtml/misc/main_thread_malloc.h: Use inlines instead of macros for allocation functions.
2:12 PM Changeset in webkit [9052] by hyatt
  • 2 edits in trunk/WebCore

Fix for 4097842, changing 1st line of a url that wraps doesn't update the second line. Make sure to
update line break info for the last dirty line so that when a clean line tries to figure out where it
started, it will get an accurate position taking into account the updated string. By doing this, the code
will be able to properly distinguish between the old and new positions and not accidentally assume they are
the same.

Reviewed by darin

  • khtml/rendering/render_text.cpp: (RenderText::setTextWithOffset):
2:02 PM Changeset in webkit [9051] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/4098826> Bezier curves broken in new Safari canvas object (last two parameters parsed incorrectly)
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Fixed incorrect argument indices. Thanks to Brian Campbell who figured out what was wrong.
11:46 AM Changeset in webkit [9050] by mjs
  • 21 edits
    3 adds in trunk/WebCore

Reviewed by Darin.

  • use single-threaded malloc in places where malloc is hot for an 8% speed improvement on cvs-base
  • ForwardingHeaders/misc/fast_malloc.h: Added.
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssstyleselector.h:
  • khtml/misc/arena.cpp: (ArenaAllocate): (FreeArenaList): (ArenaFinish):
  • khtml/misc/main_thread_malloc.cpp: Added.
  • khtml/misc/main_thread_malloc.h: Added.
  • khtml/rendering/render_style.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::NamedAttrMapImpl): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.h:
  • kwq/KWQFontFamily.h:
  • kwq/KWQListImpl.mm:
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (ALLOC_CHAR): (ALLOC_QCHAR): (QString::setBufferFromCFString): (allocatePageNode):

Apr 25, 2005:

4:35 PM Changeset in webkit [9049] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4098731> [DOMHTMLTextAreaElement cols] returns wrong value (usually zero)
  • kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): use ATTR_COLS instead of ATTR_ACCESSKEY (D'oh!) (-[DOMHTMLTextAreaElement setCols:]): fixed whitespace
11:37 AM Changeset in webkit [9048]
  • 3 copies
    3 deletes in tags/JavaScriptCore-412~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~1'.

11:37 AM Changeset in webkit [9047] by vicki
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore-412.1

8:55 AM Changeset in webkit [9046] by darin
  • 6 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work
  • khtml/xml/dom_docimpl.h: Add virtual functions HTMLElementNamespace and isHTMLNamespace.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Rearranged this function and fixed the following problems: 1) made sure to ref node while attributes are being set on it so it doesn't get destroyed; 2) fixed code to get namespace from the element we are importing to use the IDs from the source document, not the destination document; 3) removed unneeded getDocument() call which just returns this; 4) fixed error handling for cases where an exception happens while processing the children. (DocumentImpl::HTMLElementNamespace): Added. Returns XHTML_NAMESPACE. (DocumentImpl::isHTMLNamespace): Added. Returns true for any namespace that matches XHTML_NAMESPACE (case insensitive). (DocumentImpl::createElementNS): Changed to call isHTMLNamespace, which will cause it to accept the null namespace in an HTML document. This is the change that fixes the bug. Also fixed the code path to do a little less wasteful work in the non-XHTML case. (DocumentImpl::createHTMLElement): Pass in HTMLElementNamespace() rather than 0 to tagId. (DocumentImpl::attrId): Use isHTMLNamespace instead of allowing the null namespace explicitly. (DocumentImpl::tagId): Ditto.
  • khtml/html/html_documentimpl.h: Add overrides for HTMLElementNamespace and isHTMLNamespace.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLElementNamespace): Added. Returns 0 so we use the null string for HTML elements inside HTML documents (as before). (HTMLDocumentImpl::isHTMLNamespace): Added. Allows 0, and then calls base class to check for the actual XHTML namespace. Thus, we allow both no namespace at all and the XHTML namespace inside HTML documents.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::namespaceURI): Changed to call HTMLElementNamespace rather than checking isHTMLDocument. Same result as before, but better division of responsibilities.
8:43 AM Changeset in webkit [9045] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item
  • kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.

Apr 22, 2005:

5:42 PM Changeset in webkit [9044] by hyatt
  • 2 edits
    4 adds in trunk

Fix for 4096878, drop shadow effect not displayed correctly on tbray.org/ongoing/. Block minmaxwidth was
broken when negative margins were used and did not properly decrease the max width.

Reviewed by Maciej

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcBlockMinMaxWidth):
  • layout-tests/fast/block/float/034-expected.txt: Added.
  • layout-tests/fast/block/float/034.html: Added.
  • layout-tests/fast/block/float/035-expected.txt: Added.
  • layout-tests/fast/block/float/035.html: Added.
5:08 PM Changeset in webkit [9043] by hyatt
  • 3 edits in trunk/WebCore

Remove some dead code from css_valueimpl. It wasn't used at all.

  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
2:53 PM Changeset in webkit [9042] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.
2:19 PM Changeset in webkit [9041] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_html.h: Removed unnecessary bogus class name qualifiers.
11:12 AM Changeset in webkit [9040] by hyatt
  • 2 edits
    3 adds in trunk

Fix for 4096681, fix regression in how the list-style property is parsed. It no longer parses when it hits
a url in the property value list now, because the list pointer did not get advanced. This fixes alistapart.com.

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • layout-tests/fast/lists/009-expected.txt: Added.
  • layout-tests/fast/lists/009.html: Added.
  • layout-tests/fast/lists/resources/listmark.gif: Added.
9:48 AM Changeset in webkit [9039] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by John.

  • fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present
  • kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.
  • kjs/grammar.cpp: Regenerated.
9:30 AM Changeset in webkit [9038] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"
  • khtml/ecma/kjs_window.h: Added FrameElement.
  • khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
  • khtml/ecma/kjs_window.lut.h: Regenerated.
9:29 AM Changeset in webkit [9037] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • a small editing-related code cleanup
  • khtml/rendering/render_text.h: Added positionForOffset and made offsetForPosition const.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Made const. (InlineTextBox::positionForOffset): Added. Moved code here from caretRect. (RenderText::caretRect): Call positionForOffset instead of doing the work here.
Note: See TracTimeline for information about the timeline view.