Timeline



May 10, 2005:

11:04 PM Changeset in webkit [9160] by mjs
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Kevin.

  • start on splitting htmlediting.cpp into smaller files - pull EditCommand and EditCommandPtr out.
  • WebCore.pbproj/project.pbxproj:
  • khtml/editing/edit_command.cpp: Added.
  • khtml/editing/edit_command.h: Added.
  • khtml/editing/htmlediting.cpp: Took EditCommand and EditCommandPtr out.
  • khtml/editing/htmlediting.h: Ditto.
10:56 PM Changeset in webkit [9159] by hyatt
  • 2 edits in trunk/WebCore/khtml/misc

Back out unintentional additions to HTML attrs and tags.

10:49 PM Changeset in webkit [9158] by hyatt
  • 33 edits in trunk/WebCore

Refactor the DOM so that the concept of class/style/id is no longer unique to HTML elements. This paves the way
for SVG and MathML elements to also support these capabilities. In addition the concept of presentational
attributes has also been factored out.

Reviewed by mjs

  • khtml/css/css_ruleimpl.cpp: (CSSStyleRuleImpl::setDeclaration):
  • khtml/css/cssstyleselector.cpp: (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::initElementAndPseudoState): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::locateSharedStyle): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/cssstyleselector.h:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute): (HTMLIFrameElementImpl::parseMappedAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseMappedAttribute): (HTMLHRElementImpl::parseMappedAttribute): (HTMLParagraphElementImpl::parseMappedAttribute): (HTMLMarqueeElementImpl::parseMappedAttribute):
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_canvasimpl.cpp: (HTMLCanvasElementImpl::parseMappedAttribute):
  • khtml/html/html_canvasimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::mapToEntry): (HTMLElementImpl::parseMappedAttribute): (HTMLElementImpl::addHTMLAlignment): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::toString):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): (DOM::HTMLGenericFormElementImpl::parseMappedAttribute): (DOM::HTMLButtonElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::setType): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLLabelElementImpl::parseMappedAttribute): (DOM::HTMLSelectElementImpl::parseMappedAttribute): (DOM::HTMLKeygenElementImpl::parseMappedAttribute): (DOM::HTMLOptGroupElementImpl::parseMappedAttribute): (DOM::HTMLOptionElementImpl::parseMappedAttribute): (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): (DOM::HTMLIsIndexElementImpl::parseMappedAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::parseMappedAttribute): (HTMLLinkElementImpl::parseMappedAttribute): (HTMLMetaElementImpl::parseMappedAttribute): (HTMLStyleElementImpl::parseMappedAttribute):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseMappedAttribute): (HTMLMapElementImpl::parseMappedAttribute): (HTMLAreaElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::parseMappedAttribute): (DOM::HTMLBRElementImpl::parseMappedAttribute): (DOM::HTMLFontElementImpl::parseMappedAttribute):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.cpp: (DOM::HTMLUListElementImpl::parseMappedAttribute): (DOM::HTMLOListElementImpl::parseMappedAttribute): (DOM::HTMLLIElementImpl::parseMappedAttribute):
  • khtml/html/html_listimpl.h:
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): (DOM::HTMLEmbedElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::parseMappedAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTableElementImpl::additionalAttributeStyleDecl): (DOM::HTMLTableElementImpl::getSharedCellDecl): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableCellElementImpl::parseMappedAttribute): (DOM::HTMLTableColElementImpl::parseMappedAttribute): (DOM::HTMLTableCaptionElementImpl::parseMappedAttribute):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmltokenizer.h: (khtml::Token::addAttribute):
  • khtml/misc/htmlattrs.in:
  • khtml/misc/htmltags.in:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createAttribute): (DocumentImpl::createElementNS): (DocumentImpl::createHTMLElement):
  • khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::cloneNode): (NamedAttrMapImpl::isMappedAttributeMap): (CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (StyledElementImpl::getMappedAttributeDecl): (StyledElementImpl::setMappedAttributeDecl): (StyledElementImpl::removeMappedAttributeDecl): (StyledElementImpl::invalidateStyleAttribute): (StyledElementImpl::updateStyleAttributeIfNeeded): (MappedAttributeImpl::~MappedAttributeImpl): (MappedAttributeImpl::clone): (m_mappedAttributeCount): (NamedMappedAttrMapImpl::clearAttributes): (NamedMappedAttrMapImpl::isMappedAttributeMap): (NamedMappedAttrMapImpl::declCount): (NamedMappedAttrMapImpl::mapsEquivalent): (NamedMappedAttrMapImpl::parseClassAttribute): (StyledElementImpl::StyledElementImpl): (StyledElementImpl::~StyledElementImpl): (StyledElementImpl::createAttribute): (StyledElementImpl::createInlineStyleDecl): (StyledElementImpl::destroyInlineStyleDecl): (StyledElementImpl::attributeChanged): (StyledElementImpl::mapToEntry): (StyledElementImpl::parseMappedAttribute): (StyledElementImpl::createAttributeMap): (StyledElementImpl::getInlineStyleDecl): (StyledElementImpl::style): (StyledElementImpl::additionalAttributeStyleDecl): (StyledElementImpl::getClassList): (isHexDigit): (toHex): (StyledElementImpl::addCSSProperty): (StyledElementImpl::addCSSStringProperty): (StyledElementImpl::addCSSImageProperty): (StyledElementImpl::addCSSLength): (StyledElementImpl::addCSSColor): (StyledElementImpl::createMappedDecl):
  • khtml/xml/dom_elementimpl.h: (DOM::): (DOM::CSSMappedAttributeDeclarationImpl::CSSMappedAttributeDeclarationImpl): (DOM::CSSMappedAttributeDeclarationImpl::setMappedState): (DOM::MappedAttributeImpl::MappedAttributeImpl): (DOM::MappedAttributeImpl::decl): (DOM::MappedAttributeImpl::setDecl): (DOM::NamedMappedAttrMapImpl::getClassList): (DOM::NamedMappedAttrMapImpl::hasMappedAttributes): (DOM::NamedMappedAttrMapImpl::declRemoved): (DOM::NamedMappedAttrMapImpl::declAdded): (DOM::NamedMappedAttrMapImpl::attributeItem): (DOM::StyledElementImpl::isStyledElement): (DOM::StyledElementImpl::hasMappedAttributes): (DOM::StyledElementImpl::mappedAttributes): (DOM::StyledElementImpl::isMappedAttribute): (DOM::StyledElementImpl::inlineStyleDecl):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isStyledElement):
7:10 PM Changeset in webkit [9157] by darin
  • 14 edits in trunk/WebCore

Reviewed by Dave Hyatt.
No new layout tests needed.

  • remove all remaining uses of QMIN/QMAX and KMIN/KMAX.
  • kwq/KWQDef.h: Remove the macros.

Remove all use of the macros (and fix a few compile errors by changing the types of
some integer and floating point constants).

  • khtml/css/cssparser.cpp: (CSSParser::parseColorFromValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLColor):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::parseHTMLAttribute):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::nearestFloatBottom): (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintOutlineForLine):
  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderFieldset::layoutLegend): (RenderFileButton::calcMinMaxWidth): (RenderSelect::layout): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget):
  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): (AutoTableLayout::calcEffectiveWidth):
5:58 PM Changeset in webkit [9156] by darin
  • 60 edits in trunk/WebCore

Reviewed by Chris Blumenberg.

  • next pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step adds still more member functions missing from the DOM impl. and

changes some of the C++ and Objective-C DOM to call the new ones; also
changes various places that use the C++ DOM to use the DOM impl. instead)

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • khtml/css/css_computedstyle.h:
  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::cssRules):
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyCSSValue): (DOM::CSSStyleDeclarationImpl::getPropertyValue): (DOM::CSSStyleDeclarationImpl::getPropertyPriority): (DOM::CSSStyleDeclarationImpl::setProperty): (DOM::CSSStyleDeclarationImpl::removeProperty): (DOM::CSSMutableStyleDeclarationImpl::getPropertyValue): (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::operator==): (DOM::CSSStyleDeclarationImpl::propertyID):
  • khtml/css/css_valueimpl.h: (DOM::CSSValueImpl::setCssText): (DOM::CSSPrimitiveValueImpl::getDashboardRegionValue):
  • khtml/dom/css_rule.cpp:
  • khtml/dom/css_rule.h:
  • khtml/dom/css_stylesheet.h: (DOM::CSSException::):
  • khtml/dom/css_value.cpp: (DOM::CSSStyleDeclaration::getPropertyValue): (DOM::CSSStyleDeclaration::getPropertyCSSValue): (DOM::CSSStyleDeclaration::removeProperty): (DOM::CSSStyleDeclaration::getPropertyPriority): (DOM::CSSStyleDeclaration::setProperty):
  • khtml/dom/css_value.h:
  • khtml/dom/dom2_events.cpp: (EventListener::handleEvent):
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/dom/dom_doc.cpp: (DOM::DOMImplementation::createHTMLDocument): (DOM::DOMImplementation::createCSSStyleSheet): (DOM::Document::doctype): (DOM::Document::createAttribute): (DOM::Document::createAttributeNS): (DOM::Document::queryCommandValue): (DOM::Document::handle):
  • khtml/dom/dom_doc.h:
  • khtml/dom/dom_element.cpp: (Attr::name): (Attr::value): (Element::getAttribute): (Element::setAttribute): (Element::removeAttribute): (Element::getAttributeNode): (Element::setAttributeNode): (Element::removeAttributeNode): (Element::getElementsByTagName): (Element::getElementsByTagNameNS): (Element::getAttributeNS): (Element::setAttributeNS): (Element::removeAttributeNS): (Element::getAttributeNodeNS): (Element::setAttributeNodeNS): (Element::hasAttribute): (Element::hasAttributeNS): (Element::style):
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_misc.cpp: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_node.cpp: (NamedNodeMap::getNamedItemNS): (NamedNodeMap::setNamedItemNS): (NamedNodeMap::removeNamedItemNS): (Node::ownerDocument): (Node::hasAttributes): (Node::isSupported): (Node::addEventListener): (Node::removeEventListener):
  • khtml/dom/dom_node.h:
  • khtml/dom/html_document.cpp: (HTMLDocument::setTitle): (HTMLDocument::completeURL): (HTMLDocument::getElementsByName):
  • khtml/dom/html_element.cpp: (HTMLElement::setInnerHTML): (HTMLElement::setInnerText): (HTMLElement::setOuterHTML): (HTMLElement::setOuterText):
  • khtml/dom/html_form.cpp: (HTMLLabelElement::form): (HTMLSelectElement::setValue): (HTMLSelectElement::options): (HTMLOptionElement::setValue):
  • khtml/dom/html_inline.cpp: (HTMLAnchorElement::accessKey): (HTMLAnchorElement::setAccessKey): (HTMLAnchorElement::charset): (HTMLAnchorElement::setCharset): (HTMLAnchorElement::coords): (HTMLAnchorElement::setCoords): (HTMLAnchorElement::href): (HTMLAnchorElement::setHref): (HTMLAnchorElement::hreflang): (HTMLAnchorElement::setHreflang): (HTMLAnchorElement::name): (HTMLAnchorElement::setName): (HTMLAnchorElement::rel): (HTMLAnchorElement::setRel): (HTMLAnchorElement::rev): (HTMLAnchorElement::setRev): (HTMLAnchorElement::shape): (HTMLAnchorElement::setShape): (HTMLAnchorElement::tabIndex): (HTMLAnchorElement::setTabIndex): (HTMLAnchorElement::target): (HTMLAnchorElement::setTarget): (HTMLAnchorElement::type): (HTMLAnchorElement::setType): (HTMLAnchorElement::blur): (HTMLAnchorElement::focus): (HTMLBRElement::clear): (HTMLBRElement::setClear): (HTMLFontElement::color): (HTMLFontElement::setColor): (HTMLFontElement::face): (HTMLFontElement::setFace): (HTMLFontElement::size): (HTMLFontElement::setSize): (HTMLModElement::cite): (HTMLModElement::setCite): (HTMLModElement::dateTime): (HTMLModElement::setDateTime): (HTMLQuoteElement::cite): (HTMLQuoteElement::setCite):
  • khtml/dom/html_misc.cpp: (HTMLCollection::HTMLCollection): (HTMLCollection::base): (HTMLCollection::namedItems):
  • khtml/dom/html_misc.h:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/selection.cpp:
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::determineParseMode): (DOM::HTMLDocumentImpl::doctype):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setInnerHTML): (HTMLElementImpl::setOuterHTML): (HTMLElementImpl::setInnerText): (HTMLElementImpl::setOuterText): (HTMLElementImpl::style): (HTMLElementImpl::idDOM): (HTMLElementImpl::setId): (HTMLElementImpl::title): (HTMLElementImpl::setTitle): (HTMLElementImpl::lang): (HTMLElementImpl::setLang): (HTMLElementImpl::dir): (HTMLElementImpl::setDir): (HTMLElementImpl::className): (HTMLElementImpl::setClassName): (HTMLElementImpl::children): (HTMLGenericElementImpl::HTMLGenericElementImpl): (HTMLGenericElementImpl::id):
  • khtml/html/html_elementimpl.h: (DOM::HTMLElementImpl::isGenericFormElement):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseEnctype): (DOM::HTMLFormElementImpl::parseHTMLAttribute): (DOM::HTMLFormElementImpl::elements): (DOM::HTMLFormElementImpl::name): (DOM::HTMLFormElementImpl::setName): (DOM::HTMLFormElementImpl::acceptCharset): (DOM::HTMLFormElementImpl::setAcceptCharset): (DOM::HTMLFormElementImpl::action): (DOM::HTMLFormElementImpl::setAction): (DOM::HTMLFormElementImpl::setEnctype): (DOM::HTMLFormElementImpl::method): (DOM::HTMLFormElementImpl::setMethod): (DOM::HTMLFormElementImpl::target): (DOM::HTMLFormElementImpl::setTarget): (DOM::HTMLGenericFormElementImpl::HTMLGenericFormElementImpl): (DOM::HTMLGenericFormElementImpl::~HTMLGenericFormElementImpl): (DOM::HTMLGenericFormElementImpl::parseHTMLAttribute): (DOM::HTMLGenericFormElementImpl::name): (DOM::HTMLGenericFormElementImpl::setName): (DOM::HTMLGenericFormElementImpl::setOverrideName): (DOM::HTMLGenericFormElementImpl::setDisabled): (DOM::HTMLGenericFormElementImpl::setReadOnly): (DOM::HTMLGenericFormElementImpl::tabIndex): (DOM::HTMLGenericFormElementImpl::setTabIndex): (DOM::HTMLButtonElementImpl::accessKey): (DOM::HTMLButtonElementImpl::setAccessKey): (DOM::HTMLButtonElementImpl::value): (DOM::HTMLButtonElementImpl::setValue): (DOM::HTMLInputElementImpl::HTMLInputElementImpl): (DOM::HTMLInputElementImpl::parseHTMLAttribute): (DOM::HTMLInputElementImpl::defaultValue): (DOM::HTMLInputElementImpl::setDefaultValue): (DOM::HTMLInputElementImpl::defaultChecked): (DOM::HTMLInputElementImpl::setDefaultChecked): (DOM::HTMLInputElementImpl::accept): (DOM::HTMLInputElementImpl::setAccept): (DOM::HTMLInputElementImpl::accessKey): (DOM::HTMLInputElementImpl::setAccessKey): (DOM::HTMLInputElementImpl::align): (DOM::HTMLInputElementImpl::setAlign): (DOM::HTMLInputElementImpl::alt): (DOM::HTMLInputElementImpl::setAlt): (DOM::HTMLInputElementImpl::setMaxLength): (DOM::HTMLInputElementImpl::sizeDOM): (DOM::HTMLInputElementImpl::setSize): (DOM::HTMLInputElementImpl::src): (DOM::HTMLInputElementImpl::setSrc): (DOM::HTMLInputElementImpl::useMap): (DOM::HTMLInputElementImpl::setUseMap): (DOM::HTMLLabelElementImpl::form): (DOM::HTMLLabelElementImpl::accessKey): (DOM::HTMLLabelElementImpl::setAccessKey): (DOM::HTMLLabelElementImpl::htmlFor): (DOM::HTMLLabelElementImpl::setHtmlFor): (DOM::HTMLLegendElementImpl::accessKey): (DOM::HTMLLegendElementImpl::setAccessKey): (DOM::HTMLLegendElementImpl::align): (DOM::HTMLLegendElementImpl::setAlign): (DOM::HTMLSelectElementImpl::setValue): (DOM::HTMLSelectElementImpl::optionsHTMLCollection): (DOM::HTMLSelectElementImpl::setMultiple): (DOM::HTMLSelectElementImpl::setSize): (DOM::HTMLOptGroupElementImpl::label): (DOM::HTMLOptGroupElementImpl::setLabel): (DOM::HTMLOptionElementImpl::setText): (DOM::HTMLOptionElementImpl::setIndex): (DOM::HTMLOptionElementImpl::setValue): (DOM::HTMLOptionElementImpl::defaultSelected): (DOM::HTMLOptionElementImpl::setDefaultSelected): (DOM::HTMLOptionElementImpl::label): (DOM::HTMLOptionElementImpl::setLabel): (DOM::HTMLTextAreaElementImpl::accessKey): (DOM::HTMLTextAreaElementImpl::setAccessKey): (DOM::HTMLTextAreaElementImpl::setCols): (DOM::HTMLTextAreaElementImpl::setRows): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl): (DOM::HTMLIsIndexElementImpl::parseHTMLAttribute): (DOM::HTMLIsIndexElementImpl::prompt): (DOM::HTMLIsIndexElementImpl::setPrompt):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::setHref): (HTMLBaseElementImpl::setTarget): (HTMLLinkElementImpl::disabled): (HTMLLinkElementImpl::setDisabled): (HTMLLinkElementImpl::charset): (HTMLLinkElementImpl::setCharset): (HTMLLinkElementImpl::href): (HTMLLinkElementImpl::setHref): (HTMLLinkElementImpl::hreflang): (HTMLLinkElementImpl::setHreflang): (HTMLLinkElementImpl::media): (HTMLLinkElementImpl::setMedia): (HTMLLinkElementImpl::rel): (HTMLLinkElementImpl::setRel): (HTMLLinkElementImpl::rev): (HTMLLinkElementImpl::setRev): (HTMLLinkElementImpl::target): (HTMLLinkElementImpl::setTarget): (HTMLLinkElementImpl::type): (HTMLLinkElementImpl::setType): (HTMLMetaElementImpl::content): (HTMLMetaElementImpl::setContent): (HTMLMetaElementImpl::httpEquiv): (HTMLMetaElementImpl::setHttpEquiv): (HTMLMetaElementImpl::name): (HTMLMetaElementImpl::setName): (HTMLMetaElementImpl::scheme): (HTMLMetaElementImpl::setScheme): (HTMLScriptElementImpl::id): (HTMLScriptElementImpl::isURLAttribute): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::notifyFinished): (HTMLScriptElementImpl::text): (HTMLScriptElementImpl::setText): (HTMLScriptElementImpl::htmlFor): (HTMLScriptElementImpl::setHtmlFor): (HTMLScriptElementImpl::event): (HTMLScriptElementImpl::setEvent): (HTMLScriptElementImpl::charset): (HTMLScriptElementImpl::setCharset): (HTMLScriptElementImpl::defer): (HTMLScriptElementImpl::setDefer): (HTMLScriptElementImpl::src): (HTMLScriptElementImpl::setSrc): (HTMLScriptElementImpl::type): (HTMLScriptElementImpl::setType): (HTMLStyleElementImpl::disabled): (HTMLStyleElementImpl::setDisabled): (HTMLStyleElementImpl::media): (HTMLStyleElementImpl::setMedia): (HTMLStyleElementImpl::type): (HTMLStyleElementImpl::setType): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged): (HTMLTitleElementImpl::text): (HTMLTitleElementImpl::setText):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLBaseFontElementImpl::id): (DOM::HTMLBaseFontElementImpl::color): (DOM::HTMLBaseFontElementImpl::setColor): (DOM::HTMLBaseFontElementImpl::face): (DOM::HTMLBaseFontElementImpl::setFace): (DOM::HTMLBaseFontElementImpl::size): (DOM::HTMLBaseFontElementImpl::setSize): (DOM::HTMLCollectionImpl::HTMLCollectionImpl): (DOM::HTMLCollectionImpl::~HTMLCollectionImpl): (DOM::HTMLCollectionImpl::resetCollectionInfo): (DOM::HTMLCollectionImpl::traverseNextItem): (DOM::HTMLCollectionImpl::calcLength): (DOM::HTMLCollectionImpl::item): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLCollectionImpl::updateNameCache): (DOM::HTMLCollectionImpl::namedItems): (DOM::HTMLCollectionImpl::nextNamedItem): (DOM::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (DOM::HTMLFormCollectionImpl::calcLength): (DOM::HTMLFormCollectionImpl::item): (DOM::HTMLFormCollectionImpl::getNamedFormItem): (DOM::HTMLFormCollectionImpl::nextNamedItemInternal): (DOM::HTMLFormCollectionImpl::namedItem): (DOM::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::base):
  • khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): (KHTMLParser::insertNode):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution):
  • khtml/khtml_events.cpp: (khtml::MouseEvent::MouseEvent): (khtml::MouseEvent::offset):
  • khtml/khtml_events.h: (khtml::MouseEvent::innerNode): (khtml::MousePressEvent::MousePressEvent): (khtml::MouseDoubleClickEvent::MouseDoubleClickEvent): (khtml::MouseMoveEvent::MouseMoveEvent): (khtml::MouseReleaseEvent::MouseReleaseEvent):
  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): (KHTMLPart::executeScript): (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::handleMouseMoveEventDrag): (KHTMLPart::handleMouseMoveEventOver): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::contentsContextMenuEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop): (KHTMLView::focusNextPrevNode):
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleSheet cssRules]): (-[DOMCSSStyleDeclaration getPropertyValue:]): (-[DOMCSSStyleDeclaration getPropertyCSSValue:]): (-[DOMCSSStyleDeclaration removeProperty:]): (-[DOMCSSStyleDeclaration getPropertyPriority:]): (-[DOMCSSStyleDeclaration setProperty:::]): (-[DOMCSSValue setCssText:]):
  • kwq/DOMCSS.h:
  • kwq/DOMHTML.mm: (-[DOMHTMLElement setInnerHTML:]): (-[DOMHTMLElement setOuterHTML:]): (-[DOMHTMLElement setInnerText:]): (-[DOMHTMLElement setOuterText:]): (-[DOMHTMLSelectElement setLength:]): (-[DOMHTMLTableSectionElement insertRow:]):
  • kwq/DOMInternal.h:
  • kwq/DOMInternal.mm: (raiseDOMException): (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::scrollOverflow): (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::dispatchDragSrcEvent): (KWQKHTMLPart::eventMayStartDrag): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::sendContextMenuEvent): (listParent): (isTextFirstInListItem): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::mousePressNode):
  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (-[WebCoreBridge _documentTypeString]):
3:25 PM Changeset in webkit [9155] by mjs
  • 12 edits in trunk/WebCore

Reviewed by John.

  • rename hasAnchor method to isLink
  • khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState): (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/editing/htmlediting.cpp: (khtml::isSpecialElement):
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseHTMLAttribute):
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isFocusable): (DOM::HTMLAnchorElementImpl::defaultEventHandler): (DOM::HTMLAnchorElementImpl::parseHTMLAttribute):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_layer.cpp: (RenderLayer::hitTest):
  • khtml/rendering/render_object.cpp: (RenderObject::information):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isLink):
  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject role]): (-[KWQAccObject title]): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):
3:24 PM Changeset in webkit [9154] by mjs
  • 7 edits in trunk/WebCore

Reviewed by John.

  • remove init hint argument from VisiblePosition
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::init):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]):
2:59 PM Changeset in webkit [9153] by darin
  • 29 edits in trunk/WebCore

Reviewed by David Harrison.

  • next pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step adds more member functions missing from the DOM impl. and

changes some of the Objective-C DOM to call the new ones; also changes some
parameter types in the DOM impl.)

  • khtml/dom/dom2_events.cpp: (UIEvent::initUIEvent): (MouseEvent::initMouseEvent): (MutationEvent::initMutationEvent): (KeyboardEvent::initKeyboardEvent):
  • khtml/dom/dom_doc.cpp: (DOM::DOMImplementation::createDocument): (DOM::Document::getElementsByTagName): (DOM::Document::getElementsByTagNameNS):
  • khtml/dom/dom_element.cpp: (Element::removeAttributeNode): (Element::getElementsByTagName): (Element::getElementsByTagNameNS): (Element::setAttributeNodeNS):
  • khtml/dom/dom_node.cpp: (NamedNodeMap::setNamedItemNS): (NamedNodeMap::removeNamedItemNS):
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_events.cpp: (ClipboardProtoFunc::tryCall):
  • khtml/editing/jsediting.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h: (khtml::SharedPtr::reset): (khtml::::operator): (khtml::static_pointer_cast): (khtml::const_pointer_cast):
  • khtml/xml/dom2_eventsimpl.cpp: (UIEventImpl::initUIEvent): (UIEventImpl::keyCode): (UIEventImpl::charCode): (UIEventImpl::layerX): (UIEventImpl::layerY): (UIEventImpl::pageX): (UIEventImpl::pageY): (UIEventImpl::which): (MouseRelatedEventImpl::pageX): (MouseRelatedEventImpl::pageY): (MouseEventImpl::initMouseEvent): (MouseEventImpl::which): (KeyboardEventImpl::initKeyboardEvent): (KeyboardEventImpl::which): (MutationEventImpl::MutationEventImpl): (MutationEventImpl::initMutationEvent):
  • khtml/xml/dom2_eventsimpl.h: (DOM::MutationEventImpl::relatedNode):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeFilterImpl::acceptNode):
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DOMImplementationImpl::createCSSStyleSheet): (DOMImplementationImpl::createHTMLDocument): (DocumentImpl::createAttribute): (DocumentImpl::createHTMLElement): (DocumentImpl::getOverrideStyle): (DocumentImpl::defaultEventHandler): (DocumentImpl::completeURL): (DocumentImpl::topDocument): (DocumentImpl::createAttributeNS): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::nameableItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::realDocType): (DOM::DocumentImpl::createAttribute):
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeName): (AttrImpl::nodeValue): (AttrImpl::name): (AttrImpl::value): (ElementImpl::attributes): (ElementImpl::isURLAttribute): (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (ElementImpl::setAttributeNS): (ElementImpl::removeAttributeNS): (ElementImpl::getAttributeNodeNS): (ElementImpl::hasAttributeNS): (ElementImpl::style): (XMLElementImpl::cloneNode): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::hasAttribute): (DOM::ElementImpl::getAttribute): (DOM::ElementImpl::setAttribute): (DOM::ElementImpl::removeAttribute): (DOM::ElementImpl::getAttributeNode): (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): (NodeImpl::isAncestor): (NodeImpl::addEventListener): (NodeImpl::removeEventListener): (NodeImpl::getElementsByTagNameNS): (NodeImpl::isSupported): (NodeImpl::ownerDocument): (NodeImpl::hasAttributes): (NodeImpl::attributes): (ContainerNodeImpl::removeChildren): (NamedNodeMapImpl::~NamedNodeMapImpl): (NamedNodeMapImpl::getNamedItemNS): (NamedNodeMapImpl::removeNamedItemNS):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::getNamedItem): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS): (DOM::NamedNodeMapImpl::isReadOnly):
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.h:
  • kwq/DOM.mm: (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode hasAttributes]): (-[DOMNamedNodeMap getNamedItem:]): (-[DOMNamedNodeMap setNamedItem:]): (-[DOMNamedNodeMap removeNamedItem:]): (-[DOMNamedNodeMap getNamedItemNS::]): (-[DOMNamedNodeMap setNamedItemNS:]): (-[DOMNamedNodeMap removeNamedItemNS::]): (-[DOMImplementation createDocument:::]): (-[DOMImplementation createCSSStyleSheet::]): (-[DOMDocument createAttribute:]): (-[DOMDocument getElementsByTagName:]): (-[DOMDocument createAttributeNS::]): (-[DOMDocument getElementsByTagNameNS::]): (-[DOMElement setAttribute::]): (-[DOMElement removeAttribute:]): (-[DOMElement getAttributeNode:]): (-[DOMElement setAttributeNode:]): (-[DOMElement removeAttributeNode:]): (-[DOMElement getElementsByTagName:]): (-[DOMElement getAttributeNS::]): (-[DOMElement setAttributeNS:::]): (-[DOMElement removeAttributeNS::]): (-[DOMElement getAttributeNodeNS::]): (-[DOMElement setAttributeNodeNS:]): (-[DOMElement getElementsByTagNameNS::]): (-[DOMElement hasAttribute:]): (-[DOMElement hasAttributeNS::]): (-[DOMElement style]): (-[DOMDocumentType _documentTypeImpl]): (ObjCNodeFilterCondition::acceptNode):
  • kwq/DOMEvents.mm: (-[DOMMutationEvent relatedNode]):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): (KWQClipboard::setDragImage): (KWQClipboard::dragImageElement): (KWQClipboard::setDragImageElement): (KWQClipboard::dragNSImage):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::passSubframeEventToSubframe): (KWQKHTMLPart::sendContextMenuEvent):
1:27 PM Changeset in webkit [9152] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Kevin.

  • WebKit support for <rdar://problem/3795701> Menu item/keyboard shortcut to restore text zoom to normal
  • WebView.subproj/WebView.m: (-[WebView validateUserInterfaceItem:]): validate makeTextStandardSize by calling canMakeTextStandardSize (-[WebView canMakeTextStandardSize]): new method, returns YES unless text size multiplier is currently 1 (-[WebView makeTextStandardSize:]): new method, sets text size multiplier to 1
  • WebView.subproj/WebViewPrivate.h: add makeTextStandardSize: and canMakeTextStandardSize to pending public category

WebBrowser:

Reviewed by Chris.

  • fixed <rdar://problem/3795701> Menu item/keyboard shortcut to restore text zoom to normal
  • BrowserDocument.h: added -makeTextStandardSize:
  • BrowserDocument.m: (-[BrowserDocument makeTextStandardSize:]): call through to webview (-[BrowserDocument validateUserInterfaceItem:]): call through to webview
  • BrowserWebController.m: (-[BrowserWebView canMakeTextStandardSize]): new method, special case bookmarks view, as with other text size methods (-[BrowserWebView makeTextStandardSize:]): new method, bail out if canMakeTextStandardSize fails, as with other text size methods
  • BrowserWindowController.h: added -makeTextStandardSize:
  • BrowserWindowController.m: (-[BrowserWindowController validateUserInterfaceItem:]): call through to webview (-[BrowserWindowController makeTextStandardSize:]): ditto
  • English.lproj/MainMenu.nib: Added Make Text Normal Size menu item with keyboard equivalent of command-0, in between Make Text Bigger and Make Text Smaller
  • HTMLSourceDocument.m: (-[HTMLSourceDocument canMakeTextStandardSize]): new method, imitates WebView code (-[HTMLSourceDocument makeTextStandardSize:]): ditto (-[HTMLSourceDocument validateUserInterfaceItem:]): validate new method
11:42 AM Changeset in webkit [9151] by darin
  • 22 edits in trunk/WebCore

Reviewed by David Harrison.

  • first pass of moving code from C++ DOM wrappers into the DOM impl. classes (this step mostly adds member functions missing from the DOM impl.; later steps

will change the C++, JavaScript, and ObjC wrappers to call these functions)

  • khtml/css/parser.y:
  • khtml/css/css_ruleimpl.cpp: (CSSRuleListImpl::CSSRuleListImpl):
  • khtml/css/css_ruleimpl.h: (DOM::CSSRuleListImpl::CSSRuleListImpl):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::aLink): (HTMLBodyElementImpl::setALink): (HTMLBodyElementImpl::background): (HTMLBodyElementImpl::setBackground): (HTMLBodyElementImpl::bgColor): (HTMLBodyElementImpl::setBgColor): (HTMLBodyElementImpl::link): (HTMLBodyElementImpl::setLink): (HTMLBodyElementImpl::text): (HTMLBodyElementImpl::setText): (HTMLBodyElementImpl::vLink): (HTMLBodyElementImpl::setVLink): (HTMLFrameElementImpl::HTMLFrameElementImpl): (HTMLFrameElementImpl::updateForNewURL): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseHTMLAttribute): (HTMLFrameElementImpl::rendererIsNeeded): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLFrameElementImpl::setLocation): (HTMLFrameElementImpl::contentPart): (HTMLFrameElementImpl::frameBorder): (HTMLFrameElementImpl::setFrameBorder): (HTMLFrameElementImpl::longDesc): (HTMLFrameElementImpl::setLongDesc): (HTMLFrameElementImpl::marginHeight): (HTMLFrameElementImpl::setMarginHeight): (HTMLFrameElementImpl::marginWidth): (HTMLFrameElementImpl::setMarginWidth): (HTMLFrameElementImpl::name): (HTMLFrameElementImpl::setName): (HTMLFrameElementImpl::setNoResize): (HTMLFrameElementImpl::scrolling): (HTMLFrameElementImpl::setScrolling): (HTMLFrameElementImpl::src): (HTMLFrameElementImpl::setSrc): (HTMLFrameSetElementImpl::parseHTMLAttribute): (HTMLFrameSetElementImpl::cols): (HTMLFrameSetElementImpl::setCols): (HTMLFrameSetElementImpl::rows): (HTMLFrameSetElementImpl::setRows): (HTMLHeadElementImpl::profile): (HTMLHeadElementImpl::setProfile): (HTMLHtmlElementImpl::version): (HTMLHtmlElementImpl::setVersion): (HTMLIFrameElementImpl::HTMLIFrameElementImpl): (HTMLIFrameElementImpl::rendererIsNeeded): (HTMLIFrameElementImpl::attach): (HTMLIFrameElementImpl::isURLAttribute): (HTMLIFrameElementImpl::align): (HTMLIFrameElementImpl::setAlign): (HTMLIFrameElementImpl::height): (HTMLIFrameElementImpl::setHeight): (HTMLIFrameElementImpl::src): (HTMLIFrameElementImpl::width): (HTMLIFrameElementImpl::setWidth):
  • khtml/html/html_baseimpl.h: (DOM::HTMLFrameElementImpl::noResize): (DOM::HTMLFrameElementImpl::scrollingMode): (DOM::HTMLFrameElementImpl::getMarginWidth): (DOM::HTMLFrameElementImpl::getMarginHeight):
  • khtml/html/html_blockimpl.cpp: (HTMLBlockquoteElementImpl::cite): (HTMLBlockquoteElementImpl::setCite): (HTMLDivElementImpl::align): (HTMLDivElementImpl::setAlign): (HTMLHRElementImpl::align): (HTMLHRElementImpl::setAlign): (HTMLHRElementImpl::noShade): (HTMLHRElementImpl::setNoShade): (HTMLHRElementImpl::size): (HTMLHRElementImpl::setSize): (HTMLHRElementImpl::width): (HTMLHRElementImpl::setWidth): (HTMLHeadingElementImpl::align): (HTMLHeadingElementImpl::setAlign): (HTMLParagraphElementImpl::align): (HTMLParagraphElementImpl::setAlign): (HTMLPreElementImpl::width): (HTMLPreElementImpl::setWidth):
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::name): (HTMLImageElementImpl::setName): (HTMLImageElementImpl::align): (HTMLImageElementImpl::setAlign): (HTMLImageElementImpl::alt): (HTMLImageElementImpl::setAlt): (HTMLImageElementImpl::border): (HTMLImageElementImpl::setBorder): (HTMLImageElementImpl::setHeight): (HTMLImageElementImpl::hspace): (HTMLImageElementImpl::setHspace): (HTMLImageElementImpl::isMap): (HTMLImageElementImpl::setIsMap): (HTMLImageElementImpl::longDesc): (HTMLImageElementImpl::setLongDesc): (HTMLImageElementImpl::src): (HTMLImageElementImpl::setSrc): (HTMLImageElementImpl::useMap): (HTMLImageElementImpl::setUseMap): (HTMLImageElementImpl::vspace): (HTMLImageElementImpl::setVspace): (HTMLImageElementImpl::setWidth): (HTMLImageElementImpl::x): (HTMLImageElementImpl::y): (HTMLMapElementImpl::parseHTMLAttribute): (HTMLMapElementImpl::areas): (HTMLMapElementImpl::name): (HTMLMapElementImpl::setName): (HTMLAreaElementImpl::HTMLAreaElementImpl): (HTMLAreaElementImpl::parseHTMLAttribute): (HTMLAreaElementImpl::getRegion): (HTMLAreaElementImpl::accessKey): (HTMLAreaElementImpl::setAccessKey): (HTMLAreaElementImpl::alt): (HTMLAreaElementImpl::setAlt): (HTMLAreaElementImpl::coords): (HTMLAreaElementImpl::setCoords): (HTMLAreaElementImpl::href): (HTMLAreaElementImpl::setHref): (HTMLAreaElementImpl::noHref): (HTMLAreaElementImpl::setNoHref): (HTMLAreaElementImpl::shape): (HTMLAreaElementImpl::setShape): (HTMLAreaElementImpl::tabIndex): (HTMLAreaElementImpl::setTabIndex): (HTMLAreaElementImpl::target): (HTMLAreaElementImpl::setTarget):
  • khtml/html/html_imageimpl.h: (DOM::HTMLImageElementImpl::pixmap): (DOM::HTMLAreaElementImpl::isDefault): (DOM::HTMLMapElementImpl::getName):
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::accessKey): (DOM::HTMLAnchorElementImpl::setAccessKey): (DOM::HTMLAnchorElementImpl::charset): (DOM::HTMLAnchorElementImpl::setCharset): (DOM::HTMLAnchorElementImpl::coords): (DOM::HTMLAnchorElementImpl::setCoords): (DOM::HTMLAnchorElementImpl::href): (DOM::HTMLAnchorElementImpl::setHref): (DOM::HTMLAnchorElementImpl::hreflang): (DOM::HTMLAnchorElementImpl::setHreflang): (DOM::HTMLAnchorElementImpl::name): (DOM::HTMLAnchorElementImpl::setName): (DOM::HTMLAnchorElementImpl::rel): (DOM::HTMLAnchorElementImpl::setRel): (DOM::HTMLAnchorElementImpl::rev): (DOM::HTMLAnchorElementImpl::setRev): (DOM::HTMLAnchorElementImpl::shape): (DOM::HTMLAnchorElementImpl::setShape): (DOM::HTMLAnchorElementImpl::tabIndex): (DOM::HTMLAnchorElementImpl::setTabIndex): (DOM::HTMLAnchorElementImpl::target): (DOM::HTMLAnchorElementImpl::setTarget): (DOM::HTMLAnchorElementImpl::type): (DOM::HTMLAnchorElementImpl::setType): (DOM::HTMLAnchorElementImpl::blur): (DOM::HTMLAnchorElementImpl::focus): (DOM::HTMLBRElementImpl::clear): (DOM::HTMLBRElementImpl::setClear): (DOM::HTMLFontElementImpl::parseHTMLAttribute): (DOM::HTMLFontElementImpl::color): (DOM::HTMLFontElementImpl::setColor): (DOM::HTMLFontElementImpl::face): (DOM::HTMLFontElementImpl::setFace): (DOM::HTMLFontElementImpl::size): (DOM::HTMLFontElementImpl::setSize): (DOM::HTMLModElementImpl::HTMLModElementImpl): (DOM::HTMLModElementImpl::cite): (DOM::HTMLModElementImpl::setCite): (DOM::HTMLModElementImpl::dateTime): (DOM::HTMLModElementImpl::setDateTime): (DOM::HTMLQuoteElementImpl::HTMLQuoteElementImpl): (DOM::HTMLQuoteElementImpl::id): (DOM::HTMLQuoteElementImpl::cite): (DOM::HTMLQuoteElementImpl::setCite):
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.cpp: (DOM::HTMLUListElementImpl::compact): (DOM::HTMLUListElementImpl::setCompact): (DOM::HTMLUListElementImpl::type): (DOM::HTMLUListElementImpl::setType): (DOM::HTMLDirectoryElementImpl::compact): (DOM::HTMLDirectoryElementImpl::setCompact): (DOM::HTMLMenuElementImpl::compact): (DOM::HTMLMenuElementImpl::setCompact): (DOM::HTMLOListElementImpl::compact): (DOM::HTMLOListElementImpl::setCompact): (DOM::HTMLOListElementImpl::setStart): (DOM::HTMLOListElementImpl::type): (DOM::HTMLOListElementImpl::setType): (DOM::HTMLLIElementImpl::type): (DOM::HTMLLIElementImpl::setType): (DOM::HTMLLIElementImpl::value): (DOM::HTMLLIElementImpl::setValue): (DOM::HTMLDListElementImpl::compact): (DOM::HTMLDListElementImpl::setCompact):
  • khtml/html/html_listimpl.h: (DOM::HTMLUListElementImpl::start): (DOM::HTMLDirectoryElementImpl::HTMLDirectoryElementImpl): (DOM::HTMLMenuElementImpl::HTMLMenuElementImpl): (DOM::HTMLOListElementImpl::HTMLOListElementImpl): (DOM::HTMLOListElementImpl::start):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::align): (DOM::HTMLAppletElementImpl::setAlign): (DOM::HTMLAppletElementImpl::alt): (DOM::HTMLAppletElementImpl::setAlt): (DOM::HTMLAppletElementImpl::archive): (DOM::HTMLAppletElementImpl::setArchive): (DOM::HTMLAppletElementImpl::code): (DOM::HTMLAppletElementImpl::setCode): (DOM::HTMLAppletElementImpl::codeBase): (DOM::HTMLAppletElementImpl::setCodeBase): (DOM::HTMLAppletElementImpl::height): (DOM::HTMLAppletElementImpl::setHeight): (DOM::HTMLAppletElementImpl::hspace): (DOM::HTMLAppletElementImpl::setHspace): (DOM::HTMLAppletElementImpl::name): (DOM::HTMLAppletElementImpl::setName): (DOM::HTMLAppletElementImpl::object): (DOM::HTMLAppletElementImpl::setObject): (DOM::HTMLAppletElementImpl::vspace): (DOM::HTMLAppletElementImpl::setVspace): (DOM::HTMLAppletElementImpl::width): (DOM::HTMLAppletElementImpl::setWidth): (DOM::HTMLObjectElementImpl::code): (DOM::HTMLObjectElementImpl::setCode): (DOM::HTMLObjectElementImpl::align): (DOM::HTMLObjectElementImpl::setAlign): (DOM::HTMLObjectElementImpl::archive): (DOM::HTMLObjectElementImpl::setArchive): (DOM::HTMLObjectElementImpl::border): (DOM::HTMLObjectElementImpl::setBorder): (DOM::HTMLObjectElementImpl::codeBase): (DOM::HTMLObjectElementImpl::setCodeBase): (DOM::HTMLObjectElementImpl::codeType): (DOM::HTMLObjectElementImpl::setCodeType): (DOM::HTMLObjectElementImpl::data): (DOM::HTMLObjectElementImpl::setData): (DOM::HTMLObjectElementImpl::declare): (DOM::HTMLObjectElementImpl::setDeclare): (DOM::HTMLObjectElementImpl::height): (DOM::HTMLObjectElementImpl::setHeight): (DOM::HTMLObjectElementImpl::hspace): (DOM::HTMLObjectElementImpl::setHspace): (DOM::HTMLObjectElementImpl::name): (DOM::HTMLObjectElementImpl::setName): (DOM::HTMLObjectElementImpl::standby): (DOM::HTMLObjectElementImpl::setStandby): (DOM::HTMLObjectElementImpl::tabIndex): (DOM::HTMLObjectElementImpl::setTabIndex): (DOM::HTMLObjectElementImpl::type): (DOM::HTMLObjectElementImpl::setType): (DOM::HTMLObjectElementImpl::useMap): (DOM::HTMLObjectElementImpl::setUseMap): (DOM::HTMLObjectElementImpl::vspace): (DOM::HTMLObjectElementImpl::setVspace): (DOM::HTMLObjectElementImpl::width): (DOM::HTMLObjectElementImpl::setWidth): (DOM::HTMLParamElementImpl::isURLAttribute): (DOM::HTMLParamElementImpl::setName): (DOM::HTMLParamElementImpl::type): (DOM::HTMLParamElementImpl::setType): (DOM::HTMLParamElementImpl::setValue): (DOM::HTMLParamElementImpl::valueType): (DOM::HTMLParamElementImpl::setValueType):
  • khtml/html/html_objectimpl.h: (DOM::HTMLParamElementImpl::name): (DOM::HTMLParamElementImpl::value):
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableElementImpl::align): (DOM::HTMLTableElementImpl::setAlign): (DOM::HTMLTableElementImpl::bgColor): (DOM::HTMLTableElementImpl::setBgColor): (DOM::HTMLTableElementImpl::border): (DOM::HTMLTableElementImpl::setBorder): (DOM::HTMLTableElementImpl::cellPadding): (DOM::HTMLTableElementImpl::setCellPadding): (DOM::HTMLTableElementImpl::cellSpacing): (DOM::HTMLTableElementImpl::setCellSpacing): (DOM::HTMLTableElementImpl::frame): (DOM::HTMLTableElementImpl::setFrame): (DOM::HTMLTableElementImpl::rules): (DOM::HTMLTableElementImpl::setRules): (DOM::HTMLTableElementImpl::summary): (DOM::HTMLTableElementImpl::setSummary): (DOM::HTMLTableElementImpl::width): (DOM::HTMLTableElementImpl::setWidth): (DOM::HTMLTableSectionElementImpl::align): (DOM::HTMLTableSectionElementImpl::setAlign): (DOM::HTMLTableSectionElementImpl::ch): (DOM::HTMLTableSectionElementImpl::setCh): (DOM::HTMLTableSectionElementImpl::chOff): (DOM::HTMLTableSectionElementImpl::setChOff): (DOM::HTMLTableSectionElementImpl::vAlign): (DOM::HTMLTableSectionElementImpl::setVAlign): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::cells): (DOM::HTMLTableRowElementImpl::setCells): (DOM::HTMLTableRowElementImpl::align): (DOM::HTMLTableRowElementImpl::setAlign): (DOM::HTMLTableRowElementImpl::bgColor): (DOM::HTMLTableRowElementImpl::setBgColor): (DOM::HTMLTableRowElementImpl::ch): (DOM::HTMLTableRowElementImpl::setCh): (DOM::HTMLTableRowElementImpl::chOff): (DOM::HTMLTableRowElementImpl::setChOff): (DOM::HTMLTableRowElementImpl::vAlign): (DOM::HTMLTableRowElementImpl::setVAlign): (DOM::HTMLTableCellElementImpl::abbr): (DOM::HTMLTableCellElementImpl::setAbbr): (DOM::HTMLTableCellElementImpl::align): (DOM::HTMLTableCellElementImpl::setAlign): (DOM::HTMLTableCellElementImpl::axis): (DOM::HTMLTableCellElementImpl::setAxis): (DOM::HTMLTableCellElementImpl::bgColor): (DOM::HTMLTableCellElementImpl::setBgColor): (DOM::HTMLTableCellElementImpl::ch): (DOM::HTMLTableCellElementImpl::setCh): (DOM::HTMLTableCellElementImpl::chOff): (DOM::HTMLTableCellElementImpl::setChOff): (DOM::HTMLTableCellElementImpl::setColSpan): (DOM::HTMLTableCellElementImpl::headers): (DOM::HTMLTableCellElementImpl::setHeaders): (DOM::HTMLTableCellElementImpl::height): (DOM::HTMLTableCellElementImpl::setHeight): (DOM::HTMLTableCellElementImpl::noWrap): (DOM::HTMLTableCellElementImpl::setNoWrap): (DOM::HTMLTableCellElementImpl::setRowSpan): (DOM::HTMLTableCellElementImpl::scope): (DOM::HTMLTableCellElementImpl::setScope): (DOM::HTMLTableCellElementImpl::vAlign): (DOM::HTMLTableCellElementImpl::setVAlign): (DOM::HTMLTableCellElementImpl::width): (DOM::HTMLTableCellElementImpl::setWidth): (DOM::HTMLTableColElementImpl::align): (DOM::HTMLTableColElementImpl::setAlign): (DOM::HTMLTableColElementImpl::ch): (DOM::HTMLTableColElementImpl::setCh): (DOM::HTMLTableColElementImpl::chOff): (DOM::HTMLTableColElementImpl::setChOff): (DOM::HTMLTableColElementImpl::setSpan): (DOM::HTMLTableColElementImpl::vAlign): (DOM::HTMLTableColElementImpl::setVAlign): (DOM::HTMLTableColElementImpl::width): (DOM::HTMLTableColElementImpl::setWidth): (DOM::HTMLTableCaptionElementImpl::parseHTMLAttribute): (DOM::HTMLTableCaptionElementImpl::align): (DOM::HTMLTableCaptionElementImpl::setAlign):
  • khtml/html/html_tableimpl.h: (DOM::HTMLTableColElementImpl::span):
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_frames.cpp: (RenderFrame::slotViewCleared): (RenderPartObject::updateWidget): (RenderPartObject::slotViewCleared):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::completeURL):
  • khtml/xml/dom_docimpl.h:
11:01 AM Changeset in webkit [9150] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed <rdar://problem/4067981> Mail places RTF flavor before RTFD flavor when dragging mixed image/text content.
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): put RTFD type before RTF type in array of types to declare

May 9, 2005:

9:40 PM Changeset in webkit [9149] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Kevin.

  • remove more isFirst/isLast functions and use isStart/isEnd verions instead
  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::setAffinityUsingLinePosition): (khtml::isFirstVisiblePositionInNode):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::endOfLine): (khtml::previousLinePosition):
  • khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]):
9:03 PM Changeset in webkit [9148] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Kevin.

  • remove isFirstVisiblePositionInBlock and isLastVisiblePositionInBlock, in favor of isStartOfBlock and isEndOfBlock

It turned out that both isEndOfBlock and isLastVisiblePositionInBlock had (different) bugs,
and there was code relying on the bugs of each. So in addition I fixed isEndOfBlock and fixed
the parts of the code relying on buggy behavior.

I also removed the includeEndOfLine parameter to endOfBlock since no one used it and it's not
clear if it would ever be useful.

  • khtml/editing/htmlediting.cpp: (khtml::InsertLineBreakCommand::doApply): Use new calls. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Don't gratuitously make an UPSTREAM VisiblePosition, as this will cause trouble comparing it to end of block. (khtml::InsertParagraphSeparatorCommand::doApply): Use new calls. (khtml::ReplaceSelectionCommand::doApply): Use new calls. Also, don't make a position <BR,0> and test if it is the end of a block, that can never be true, although the buggy code in isLastVisiblePositionInBlock would say it is. Make <BR,1> instead.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Instead of checking isEndOfBlock on the start position, check if the start's next is in a different block, to avoid relying on the buggy old isEndOfBlock behavior.
  • khtml/editing/visible_position.cpp: (khtml::isFirstVisiblePositionInParagraph): Use isStartOfBlock. (khtml::isLastVisiblePositionInParagraph): Use isEndOfBlock.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::endOfBlock): Greatly simplify, and no longer consider the start of a descendant block to be the end of the block. That's inconsistent with how startOfBlock works. Also remove include end of line parameter. (khtml::isEndOfBlock): Don't pass unneeded parameter.
  • khtml/editing/visible_units.h:
6:15 PM Changeset in webkit [9147] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4110775> from TOT.

2005-05-09 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
6:04 PM Changeset in webkit [9146] by adele
  • 3 edits
    8 adds in trunk

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.
  • layout-tests/fast/dom/outerText-no-element.html: Added. Tests case where you try to set outerText on an element no longer in the DOM tree.
  • layout-tests/fast/dom/outerText-no-element-expected.txt: Added.
  • layout-tests/fast/dynamic/outerHTML-doc.html: Added. Tests case where someone tries to set outerHTML on the document.
  • layout-tests/fast/dynamic/outerHTML-doc-expected.txt: Added..
  • layout-tests/fast/dynamic/outerHTML-no-element.html: Added. Tests case where you try to set outerHTML on an element no longer in the DOM tree.
  • layout-tests/fast/dynamic/outerHTML-no-element-expected.txt: Added.
  • layout-tests/fast/dynamic/outerHTML-img.html: moved images to resources directory
  • layout-tests/fast/dynamic/resources/apple.gif: Added.
  • layout-tests/fast/dynamic/resources/mozilla.gif: Added.
4:57 PM Changeset in webkit [9145] by darin
  • 14 edits in trunk/JavaScriptCore

Reviewed by John.

  • turn on conservative GC unconditionally and start on SPI changes to eliminate the now-unneeded smart pointers since we don't ref count any more
  • kjs/value.h: Removed macros to turn conservative GC on and off. Removed ref and deref functions. (KJS::ValueImp::ValueImp): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefined): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isNull): Ditto. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::Value::Value): Removed non-conservative-GC code path and made constructor no longer explicit so we can quietly create Value wrappers from ValueImp *; inexpensive with conservative GC and eases the transition. (KJS::Value::operator ValueImp *): Added. Quietly creates ValueImp * from Value. (KJS::ValueImp::marked): Removed non-conservative-GC code path.
  • kjs/value.cpp: (KJS::ValueImp::mark): Removed non-conservative-GC code path. (KJS::ValueImp::isUndefinedOrNull): Added. New SPI to make it easier to deal with ValueImp directly. (KJS::ValueImp::isBoolean): Ditto. (KJS::ValueImp::isNumber): Ditto. (KJS::ValueImp::isString): Ditto. (KJS::ValueImp::asString): Ditto. (KJS::ValueImp::isObject): Ditto. (KJS::undefined): Ditto. (KJS::null): Ditto. (KJS::boolean): Ditto. (KJS::string): Ditto. (KJS::zero): Ditto. (KJS::one): Ditto. (KJS::two): Ditto. (KJS::number): Ditto.
  • kjs/object.h: Made constructor no longer explicit so we can quietly create Object wrappers from ObjectImp *; inexpensive with conservative GC and eases the transition. (KJS::Object::operator ObjectImp *): Added. Quietly creates ObjectImp * from Object. (KJS::ValueImp::isObject): Added. Implementation of new object-related ValueImp function. (KJS::ValueImp::asObject): Ditto.
  • kjs/object.cpp: (KJS::ObjectImp::setInternalValue): Remove non-conservative-GC code path. (KJS::ObjectImp::putDirect): Ditto. (KJS::error): Added. Function in the new SPI style to create an error object.
  • kjs/internal.h: Added the new number-constructing functions as friends of NumberImp. There may be a more elegant way to do this later; what's important now is the new SPI.
  • kjs/collector.h: Remove non-conservative-GC code path and also take out some unneeded APPLE_CHANGES.
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): Remove non-conservative-GC code path. (KJS::Bindings::removeNativeReference): Ditto. (RootObject::removeAllNativeReferences): Ditto.
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): Ditto. (KJS::Bindings::RootObject::setRootObjectImp): Ditto.
  • kjs/collector.cpp: (KJS::Collector::allocate): Ditto. (KJS::Collector::collect): Ditto. (KJS::Collector::numGCNotAllowedObjects): Ditto. (KJS::Collector::numReferencedObjects): Ditto. (KJS::Collector::rootObjectClasses): Ditto.
  • kjs/internal.cpp: (NumberImp::create): Ditto. (InterpreterImp::globalInit): Ditto. (InterpreterImp::globalClear): Ditto.
  • kjs/list.cpp: (KJS::List::markProtectedLists): Ditto. (KJS::List::clear): Ditto. (KJS::List::append): Ditto.
  • kjs/list.h: (KJS::List::List): Ditto. (KJS::List::deref): Ditto. (KJS::List::operator=): Ditto.
  • kjs/protect.h: (KJS::gcProtect): Ditto. (KJS::gcUnprotect): Ditto.
2:03 PM Changeset in webkit [9144] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Kevin.

  • remove code for DoNotStayInBlock variant of upstream/downstream and make the methods take no parameters
  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::fixupWhitespace): (khtml::InsertLineBreakCommand::insertNodeAfterPosition): (khtml::InsertLineBreakCommand::insertNodeBeforePosition): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/selection.cpp: (khtml::Selection::toRange): (khtml::Selection::validate):
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): (khtml::isFirstVisiblePositionInParagraph): (khtml::isFirstVisiblePositionInBlock): (khtml::isLastVisiblePositionInParagraph):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition):
  • khtml/xml/dom_position.cpp: (DOM::isStreamer): (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
  • khtml/xml/dom_position.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge smartDeleteRangeForProposedRange:]):
1:31 PM Changeset in webkit [9143] by cblu
  • 5 edits in trunk/WebKit

Turned assertion into error message to prevent crash when encountering this bug:
<rdar://problem/4067625> connection:willCacheResponse: is called inside of [NSURLConnection initWithRequest:delegate:]

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): set flag to track when we're initializing the connection (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): log error
12:04 PM Changeset in webkit [9142] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • remove remaining uses of upstream/downstream DoNotStayInBlock
  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_position.cpp: (khtml::enclosingBlockFlowElement): New helper function.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::inSameBlock): Check enclosing block flows instead of comparing visible block starts. Two nested blocks may have the same visible start but different visible ends, so the old check would give false positives.
12:01 PM Changeset in webkit [9141] by harrison
  • 1 edit
    2 adds in trunk

Add layout test for <rdar://problem/4110366>.

  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-011.html: Added.
11:46 AM Changeset in webkit [9140] by cblu
  • 2 edits in trunk/JavaScriptCore

Workaround gcc 3.3 internal compiler errors.

Reviewed by darin.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]): call [NSString stringWithCString:encoding] rather than using @""
9:23 AM Changeset in webkit [9139] by darin
  • 1 edit
    1 add in trunk
  • checked in a result for the Flash replacement test that Dave added
  • layout-tests/fast/dynamic/flash-replacement-test-expected.txt: Added. Hope it's right! If not, Dave can update it.
9:10 AM Changeset in webkit [9138] by darin
  • 7 edits in trunk

top level:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • configure.in: Ditto.

Tools:

  • CommitLogEditor/Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • HotSpotFinder/Makefile.am: Ditto.
  • jst/Makefile.am: Ditto.

JavaScriptCore:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

Tests:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • TestBindingsPlugin/Makefile.am: Ditto.

WebCore:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.
  • WebCore.pbproj/project.pbxproj: Remove unneeded $(DSTROOT) in framework paths.

WebKit:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

WebBrowser:

  • Makefile.am: Don't set up PBXIntermediatesDirectory explicitly; Not needed to make builds work, spews undesirable error messages too.

May 8, 2005:

2:02 PM Changeset in webkit [9137] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Kevin.

  • remove some of the uses of upstream/downstream DoNotStayInBlock
  • khtml/editing/markup.cpp: (khtml::createMarkup): Instead of using upstream to decide if a line break should be added at the end, use inSameParagraph.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Remove the code to print upstream and downstream, the selection endpoints themselves are adequate for debugging and are what we use for layout tests.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition): Skip a possible paragraph break at the start of the selection in a more explicit way to avoid DoNotStayInBlock.

May 7, 2005:

10:53 AM Changeset in webkit [9136]
  • 34 copies
    2 deletes in tags/WebCore-415~5

This commit was manufactured by cvs2svn to create tag
'WebCore-415~5'.

10:53 AM Changeset in webkit [9135] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiAtlanta - WebCore-415.5 (skipping the .4)

10:46 AM Changeset in webkit [9134] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4110366> from TOT for SUTiAtlanta

2005-05-07 David Harrison <​harrison@apple.com>

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
10:37 AM Changeset in webkit [9133] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
5:24 AM Changeset in webkit [9132] by harrison
  • 2 edits in trunk/WebCore

Remove workaround for <rdar://problem/4103339>.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):
12:02 AM Changeset in webkit [9131] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • make StayInBlock vs DoNotStayInBlock explicit in all calls to upstream/downstream, in preparation for phasing out the DoNotStayInBlock variant.
  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/markup.cpp: (khtml::createMarkup):
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition):
  • khtml/xml/dom_position.h:

May 6, 2005:

5:45 PM Changeset in webkit [9130] by harrison
  • 11 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej, Darin.

<rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order

  • WebCore.pbproj/project.pbxproj: Removed dom_positioniterator.h and dom_positioniterator.cpp.
  • khtml/editing/htmlediting.cpp: Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
  • khtml/editing/selection.cpp: Removed unused include of dom_positioniterator.h.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::maxDeepOffset): Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atStart): (DOM::Position::atEnd): Moved here, replacing VisiblePosition's duplicate and PositionIterator. Fixed to return positions in order and not skip positions.

(DOM::Position::previousCharacterPosition):
(DOM::Position::nextCharacterPosition):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

(DOM::isStreamer):
(DOM::Position::upstream):
(DOM::Position::downstream):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

  • khtml/xml/dom_positioniterator.cpp: Removed.
  • khtml/xml/dom_positioniterator.h: Removed. Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
1:40 PM Changeset in webkit [9129] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively

Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.

  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
  • khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
  • khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
  • khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
  • khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
  • khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
12:39 PM Changeset in webkit [9128] by darin
  • 6 edits in trunk

top level:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • configure.in: Update code to set up Xcode build directory instead of setting the Project Builder build directory.
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tools:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • CommitLogEditor/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • HotSpotFinder/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • jst/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

JavaScriptCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tests:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • TestBindingsPlugin/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebKit:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebBrowser:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.
Note: See TracTimeline for information about the timeline view.