⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 23, 2005:

6:38 PM Changeset in webkit [9195] by cpetersen
  • 5 edits in branches/Safari-2-0-branch

WebCore:

Merged fix for 4077106 from TOT to SUTiCambridge

2005-04-05 David Hyatt <​hyatt@apple.com>

Fix for 4077106, make sure that mouse wheeling in overflow sections uses 40 rather than 10 as the base line
step.

Reviewed by darin

  • khtml/rendering/render_layer.cpp: (RenderLayer::positionScrollbars):
  • kwq/KWQScrollBar.mm: (QScrollBar::scroll):

WebKit:

Merged fix for 4077106 from TOT to SUTiCambridge

2005-04-05 David Hyatt <​hyatt@apple.com>

Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.

Reviewed by darin

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):
6:22 PM Changeset in webkit [9194] by cpetersen
  • 6 edits in branches/Safari-2-0-branch/WebKit

Merged changes for <rdar://problem/4072280> from TOT to SUTiCambridge

2005-05-04 Chris Blumenberg <​cblu@apple.com>

Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value

Reviewed by john.

Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
  • WebView.subproj/WebResourcePrivate.h:
6:10 PM Changeset in webkit [9193] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Adele.

  • khtml/ecma/kjs_window.cpp: (Window::get): Merged final change for frameElement from TOT.
5:52 PM Changeset in webkit [9192] by cpetersen
  • 10 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merging fix for <rdar://problem/4098713> from TOT to SUTiCambridge

2005-04-26 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:

Their NPN_SetException has the following signature:

void NPN_SetException(NPObject *npobj, const NPUTF8 *message);

ours has:

void NPN_SetException (NPObject * npobj, const NPString *message);

Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.

I changed both behaviors to match Mozilla.

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (_NPN_SetException):
  • bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:

WebCore:

Merged fix for <rdar://problem/4091956> from TOT to SUTiCambridge

2005-04-25 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item
  • kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.

WebKit:

Merged changes for <rdar://problem/4098713> from TOT to SUTiCambridge

2005-04-26 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

Reviewed by Chris.

  • Plugins.subproj/npfunctions.h:
  • Plugins.subproj/npruntime.h:
5:34 PM Changeset in webkit [9191] by darin
  • 2 edits in trunk/WebCore
  • WebCore.exp: Sorted file for more readable diffs.
5:17 PM Changeset in webkit [9190] by cpetersen
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4091082> from TOT for SUTiCambridge

2005-04-22 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"
  • khtml/ecma/kjs_window.h: Added FrameElement.
  • khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
  • khtml/ecma/kjs_window.lut.h: Regenerated.
2:09 PM Changeset in webkit [9189] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

fix for <rdar://problem/4122661> Regression: 10.3.8-10.3.9: Next lesson doesn't work on Dale Carnegie Action Systems page

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::tryCall): added checks for NaN, in case it is passed into window.open for screenx, screeny, left, top, height, or width.
2:03 PM Changeset in webkit [9188] by cblu
  • 4 edits in trunk/WebKit

Changed type for identifier parameter in WebResourceLoadDelegate-related calls to id from NSString.

Reviewed by kevin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _requestFromDelegateForRequest:identifier:error:]): (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]):
  • WebView.subproj/WebFrameInternal.h:
1:39 PM Changeset in webkit [9187] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Prevent crash when going from no selection to selection with mispelling checks enabled.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellings): Repair check for null searchRange. Was inadvertently broken in recent checkin.
1:30 PM Changeset in webkit [9186] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4123592> Can't resize textareas that have a width specified by a style
  • kwq/KWQTextArea.mm: (-[KWQTextArea getNumColumns:andNumRows:forSize:]): removed this method, which I had added earlier to set cols and rows correctly (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): set width and height instead of cols and rows; handle the intrinsic margin that sometimes appears on form elements

May 22, 2005:

5:57 PM Changeset in webkit [9185] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

fix for <rdar://problem/4127101> REGRESSION(412-TOT) crash when creating Option element

  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct): Changed ElementImpl pointer to a SharedPtr because it was getting destroyed before we were done with it.

May 20, 2005:

2:03 PM Changeset in webkit [9184] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Chris.

  • fixed <rdar://problem/4126160> Crash sending mouse-exited event after reloading page with resizable textarea
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView resetCursorRects]): This was some side effect of tracking rect code used for resizable textareas. I discovered that I didn't need the tracking rect code at all (at least to achieve the level of only-somewhat-working cursor behavior that I already had). Removing it caused the bug to vanish.
1:50 PM Changeset in webkit [9183] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/4098786> sync. XMLHttpRequest works w/o AllowNetworkAccess key because load delegate is not consulted

Synchronous loads did not cause the willSendRequest method on the resource load delegate to be called. This is the method that Dashboard uses to enforce AllowNetworkAccess and this must be called to avoid exploits.

Reviewed by sullivan.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] so synthetic resource load delegate methods are called and the data is saved as a WebResource for resources in the WebCore cache.

(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:],
respect its result, do the load and then call [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]
for synchronous loads

  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:] so synthetic resource load delegate methods are called for subresrources in the page cache

(-[WebFrame _requestFromDelegateForRequest:identifier:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls identifierForInitialRequest and willSendRequest.

(-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls the remaining resource load delegate messages.

(-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]): new, saves the resource and calls
[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]

  • WebView.subproj/WebFrameInternal.h:

May 19, 2005:

2:57 PM Changeset in webkit [9182] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • turned off exceptions and RTTI; seems to cut JavaScriptCore code size by about 22%
  • JavaScriptCore.pbproj/project.pbxproj: Turn off exceptions and RTTI for both the framework and testkjs tool.

WebCore:

Reviewed by Maciej.

  • turned off exceptions and RTTI; seems to cut WebCore code size by about 35%
  • WebCore.pbproj/project.pbxproj: Turn off exceptions and RTTI for the framework.
11:32 AM Changeset in webkit [9181] by darin
  • 2 edits in trunk/WebCore

Reviewed by Chris Petersen.

  • fixed a mistake I introduced in my previous check-in that caused a Deployment build failure
  • kwq/DOM.mm: (-[DOMDocument createTreeWalker::::]): Initialize cppFilter to 0, which fixes both the build failure and a potential bug!
Note: See TracTimeline for information about the timeline view.