Timeline
Jun 4, 2005:
- 5:44 PM Changeset in webkit [9273] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix silly ChangeLog typo.
- 5:42 PM Changeset in webkit [9272] by
-
- 2 edits22 adds in trunk/WebCore
Reviewed by Maciej.
- first fix on the road to can compile without Apple Internal headers installed
- WebCore.pbproj/project.pbxproj: Added icu directory to header search path.
- icu/README: Added.
- icu/unicode/parseerr.h: Added.
- icu/unicode/platform.h: Added.
- icu/unicode/putil.h: Added.
- icu/unicode/ubrk.h: Added.
- icu/unicode/uchar.h: Added.
- icu/unicode/uconfig.h: Added.
- icu/unicode/uenum.h: Added.
- icu/unicode/uidna.h: Added.
- icu/unicode/uiter.h: Added.
- icu/unicode/uloc.h: Added.
- icu/unicode/umachine.h: Added.
- icu/unicode/urename.h: Added.
- icu/unicode/ustring.h: Added.
- icu/unicode/utf.h: Added.
- icu/unicode/utf16.h: Added.
- icu/unicode/utf8.h: Added.
- icu/unicode/utf_old.h: Added.
- icu/unicode/utypes.h: Added.
- icu/unicode/uversion.h: Added.
- 5:41 PM Changeset in webkit [9271] by
-
- 2 edits14 adds in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed so we can compile without Apple Internal headers installed
- JavaScriptCore.pbproj/project.pbxproj: Added icu directory to header search path.
- icu/README: Added.
- icu/unicode/platform.h: Added.
- icu/unicode/uchar.h: Added.
- icu/unicode/uconfig.h: Added.
- icu/unicode/umachine.h: Added.
- icu/unicode/urename.h: Added.
- icu/unicode/utf.h: Added.
- icu/unicode/utf16.h: Added.
- icu/unicode/utf8.h: Added.
- icu/unicode/utf_old.h: Added.
- icu/unicode/utypes.h: Added.
- icu/unicode/uversion.h: Added.
- 3:46 PM Changeset in webkit [9270] by
-
- 3 edits in trunk/WebKit
Reviewed by Vicki.
- replace more use of CGCompositeOperation that I missed.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage _PDFDrawFromRect:toRect:operation:alpha:flipped:]):
Jun 3, 2005:
- 4:25 PM Changeset in webkit [9269] by
-
- 5 edits in trunk/WebKit
Reviewed by NOBODY (OOPS!).
- replace use of CGCompositeOperation SPI with NSCompositingOperation API
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory CGCompositeOperationInContext:]): (-[WebImageRendererFactory setCGCompositeOperation:inContext:]): (-[WebImageRendererFactory setCGCompositeOperationFromString:inContext:]):
- 2:34 PM Changeset in webkit [9268]
-
- 53 copies2 deletes in tags/WebCore-415~9
This commit was manufactured by cvs2svn to create tag
'WebCore-415~9'.
- 2:34 PM Changeset in webkit [9267] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiCambridge - WebCore-415.9
- 2:11 PM Changeset in webkit [9266] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4109667> from TOT for SUTiCambridge.
Our fix for the Cingular bug (<rdar://problem/4121747>)relies on this.
2005-05-05 David Hyatt <hyatt@apple.com>
Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.
The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.
Reviewed by John Sullivan
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
- khtml/xml/dom_docimpl.h:
Jun 2, 2005:
- 10:56 PM Changeset in webkit [9265] by
-
- 11 edits in trunk/WebKit
Reviewed by Kevin.
- removed dependencies on NSError SPI
- Misc.subproj/WebKitErrors.m: (-[NSError _webkit_initWithDomain:code:URL:]): (+[NSError _webkit_errorWithDomain:code:URL:]): (+[NSError _webKitErrorWithDomain:code:URL:]): (+[NSError _webKitErrorWithCode:failingURL:]): (+[NSError _webkit_addErrorsWithCodesAndDescriptions:inDomain:]): (registerErrors):
- Plugins.subproj/WebNetscapePluginRepresentation.m:
- Plugins.subproj/WebNetscapePluginStream.m:
- WebCoreSupport.subproj/WebSubresourceClient.m:
- WebView.subproj/WebBaseResourceHandleDelegate.m:
- WebView.subproj/WebDefaultResourceLoadDelegate.m:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didFailWithError:]):
- 9:46 PM Changeset in webkit [9264] by
-
- 5 edits in trunk/WebKit
Reviewed by Vicki.
- remove use of _cfBundle SPI
- Plugins.subproj/WebBasePluginPackage.h:
- Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
- Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- 9:16 PM Changeset in webkit [9263] by
-
- 17 edits4 adds in trunk/WebKit
Reviewed by Adele.
- remove use of NSURLRequest and NSUserDefaults SPI
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
- Misc.subproj/WebNSURLRequestExtras.h: Added.
- Misc.subproj/WebNSURLRequestExtras.m: Added. (-[NSURLRequest _web_HTTPReferrer]): (-[NSURLRequest _web_HTTPContentType]): (-[NSMutableURLRequest _web_setHTTPContentType:]): (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
- Misc.subproj/WebNSUserDefaultsExtras.h: Added.
- Misc.subproj/WebNSUserDefaultsExtras.m: Added. (-[NSString _webkit_HTTPStyleLanguageCode]): (makeLock): (+[NSUserDefaults _ensureAndLockPreferredLanguageLock]): (+[NSUserDefaults _webkit_defaultsDidChange]): (addDefaultsChangeObserver): (+[NSUserDefaults _webkit_addDefaultsChangeObserver]): (+[NSUserDefaults _webkit_preferredLanguageCode]):
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]):
- Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge incomingReferrer]): (-[WebBridge createModalDialogWithURL:]):
- WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- WebView.subproj/WebMainResourceClient.m:
- WebView.subproj/WebView.m: (-[WebView _cachedResponseForURL:]): (-[WebView userAgentForURL:]):
- 8:36 PM Changeset in webkit [9262] by
-
- 3 edits in trunk/WebKit
Reviewed by Don.
- move private gunk from header to implementation file.
- WebCoreSupport.subproj/WebNewKeyGeneration.c:
- WebCoreSupport.subproj/WebNewKeyGeneration.h:
- 8:12 PM Changeset in webkit [9261] by
-
- 10 edits4 adds in trunk/WebKit
Reviewed by Kevin.
- remove dependency on NSFileManager and NSCalendarDate private extras from WebFou
- History.subproj/WebHistory.m: (-[WebHistoryPrivate findIndex:forDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
- Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]):
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_fixedCarbonPOSIXPath]):
- Misc.subproj/WebNSCalendarDateExtras.h: Added.
- Misc.subproj/WebNSCalendarDateExtras.m: Added. (-[NSCalendarDate _webkit_compareDay:]):
- Misc.subproj/WebNSDataExtras.h:
- Misc.subproj/WebNSDictionaryExtras.h:
- Misc.subproj/WebNSFileManagerExtras.h: Added.
- Misc.subproj/WebNSFileManagerExtras.m: Added. (-[NSFileManager _webkit_fileExistsAtPath:isDirectory:traverseLink:]): (-[NSFileManager _webkit_createIntermediateDirectoriesForPath:attributes:]): (-[NSFileManager _webkit_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _webkit_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]): (-[NSFileManager _webkit_removeFileOnlyAtPath:]): (-[NSFileManager _webkit_backgroundRemoveFileAtPath:]): (-[NSFileManager _webkit_backgroundRemoveLeftoverFiles:]): (-[NSFileManager _webkit_carbonPathForPath:]): (-[NSFileManager _webkit_startupVolumeName]): (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
- Plugins.subproj/WebBaseNetscapePluginStream.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
- WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
- 4:54 PM Changeset in webkit [9260] by
-
- 21 edits2 adds in trunk/WebKit
Reviewed by Adele.
- remove dependencies on NSDictionary and NSURL extras
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]):
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
- Misc.subproj/WebNSDictionaryExtras.h: Added.
- Misc.subproj/WebNSDictionaryExtras.m: Added. (-[NSDictionary _webkit_numberForKey:]): (-[NSDictionary _webkit_intForKey:]): (-[NSDictionary _webkit_stringForKey:]): (-[NSDictionary _webkit_objectForMIMEType:]): (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[NSMutableDictionary _webkit_setInt:forKey:]): (-[NSMutableDictionary _webkit_setBool:forKey:]):
- Misc.subproj/WebNSPasteboardExtras.m:
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFileURL]): (-[NSURL _web_hostString]): (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
- Misc.subproj/WebNSViewExtras.m:
- Panels.subproj/WebPanelAuthenticationHandler.m:
- Plugins.subproj/WebBaseNetscapePluginStream.m:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins.subproj/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
- WebCoreSupport.subproj/WebBridge.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebDataSource.m:
- WebView.subproj/WebFrame.m:
- WebView.subproj/WebFrameView.m:
- WebView.subproj/WebHTMLView.m:
- WebView.subproj/WebPreferences.m: (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _setBoolValue:forKey:]):
- WebView.subproj/WebResource.m: (-[WebResource _initWithPropertyList:]): (-[WebResource _fileWrapperRepresentation]):
- WebView.subproj/WebView.m:
- 3:09 PM Changeset in webkit [9259] by
-
- 16 edits in trunk/WebKit
Reviewed by Vicki.
- remove dependencies on NSString and NSData extras from Foundation
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_isCaseInsensitiveEqualToString:]): (-[NSString _webkit_hasCaseInsensitivePrefix:]): (-[NSString _webkit_stringByTrimmingWhitespace]): (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): (-[NSString _webkit_fixedCarbonPOSIXPath]):
- Misc.subproj/WebNSDataExtras.h:
- Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): (-[NSData _web_isCaseInsensitiveEqualToCString:]): (_findEOL): (-[NSData _web_parseRFC822HeaderFields]): (-[NSData _webkit_guessedMIMETypeForXML]): (-[NSData _webkit_guessedMIMEType]):
- Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToURLString): (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (-[NSURL _webkit_shouldLoadAsEmptyDocument]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]): (-[NSString _webkit_isFTPDirectoryURL]): (-[NSString _web_encodeHostName]): (-[NSString _webkit_rangeOfURLScheme]): (-[NSString _webkit_looksLikeAbsoluteURL]): (-[NSString _webkit_URLFragment]):
- Misc.subproj/WebNSViewExtras.m:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
- Plugins.subproj/WebPluginDatabase.m:
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]):
- WebView.subproj/WebDataSource.m: (-[WebDataSource _setTitle:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]):
- WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]):
- WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
- 2:19 PM Changeset in webkit [9258] by
-
- 33 edits in trunk/WebKit
Reviewed by John.
- first stage of cleaning up SPI usage in WebKit
- Carbon.subproj/CarbonUtils.m:
- DOM.subproj/WebDOMOperations.m: (-[DOMHTMLLinkElement _subresourceURLs]): (-[DOMHTMLParamElement _subresourceURLs]):
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
- Misc.subproj/WebDatabase.m: (-[WebDatabase setObject:forKey:]): (-[WebDatabase removeObjectForKey:]): (-[WebDatabase removeAllObjects]): (-[WebDatabase objectForKey:]): (-[WebDatabase open]): (-[WebDatabase close]): (-[WebDatabase sync]): (-[WebDatabase count]): (-[WebDatabase setSizeLimit:]):
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase _iconForFileURL:withSize:]):
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): (-[NSString _webkit_isCaseInsensitiveEqualToString:]):
- Misc.subproj/WebNSEventExtras.h:
- Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isTabKeyEvent]):
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]):
- Panels.subproj/WebPanelAuthenticationHandler.m: (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]): (-[WebPanelAuthenticationHandler startAuthentication:window:]):
- Plugins.subproj/WebBaseNetscapePluginView.m:
- Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]):
- Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): (-[WebBridge valueForKey:keys:values:]):
- WebCoreSupport.subproj/WebGlyphBuffer.m:
- WebCoreSupport.subproj/WebImageDecodeItem.h:
- WebCoreSupport.subproj/WebImageDecodeItem.m:
- WebCoreSupport.subproj/WebImageDecoder.h:
- WebCoreSupport.subproj/WebImageDecoder.m:
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebKitPrefix.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]):
- WebView.subproj/WebDataProtocol.m: (+[WebDataProtocol _webIsDataProtocolURL:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame reload]):
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation _isDisplayingWebArchive]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient didReceiveResponse:]):
- WebView.subproj/WebPDFView.m:
- WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
- 12:26 PM Changeset in webkit [9257]
-
- 11 copies3 deletes in tags/WebKit-312~2
This commit was manufactured by cvs2svn to create tag 'WebKit-312~2'.
- 12:26 PM Changeset in webkit [9256] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
change by Darin, reviewed by me.
- WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer]
(-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
- 9:35 AM Changeset in webkit [9255]
-
- 27 copies2 deletes in tags/WebCore-315~5
This commit was manufactured by cvs2svn to create tag
'WebCore-315~5'.
- 9:35 AM Changeset in webkit [9254] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning for Safari-1-3-branch - WebCore-315.5 (skipped .4)
- 9:33 AM Changeset in webkit [9253] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
Versioning for Safari-1-3-branch - WebKit-312.2
- 8:49 AM Changeset in webkit [9252] by
-
- 13 edits in branches/Safari-1-3-branch/WebCore
Merge for WebCore part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch.
2005-06-01 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.
- WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
- khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
- khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
- khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
- khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
- kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
- kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
- kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
- kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
- kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.
- 8:44 AM Changeset in webkit [9251] by
-
- 9 edits in branches/Safari-1-3-branch/WebKit
Merged WebKit part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch
2005-06-01 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
- WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
- WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.
Jun 1, 2005:
- 4:49 PM Changeset in webkit [9250] by
-
- 21 edits in trunk
WebCore:
Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.
- WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
- khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
- khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
- khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
- khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
- kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
- kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
- kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
- kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
- kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.
WebKit:
Reviewed by John Sullivan.
- WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
- WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
- WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.
WebBrowser:
Reviewed by John.
- WebBrowser part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- AppController.m: (-[AppController validateUserInterfaceItem:]): Disable the find panel when there's a modal panel up.
- BrowserApplication.m: (-[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:]): Force the event loop to use the default run loop mode instead of the modal panel mode for modal BrowserWindows. This is required to work around the WebFoundation issue where it will only give us data in the default run loop mode.
- BrowserDocument.m: (-[BrowserDocument canAddBookmark]): Return NO when a modal window is up. (-[BrowserDocument canViewSource]): Ditto. (-[BrowserDocument canMailPage]): Ditto. (-[BrowserDocument canMailPageAddress]): Ditto. (-[BrowserDocument canOpenInDashboard]): Ditto. (-[BrowserDocument canSave]): Ditto. (-[BrowserDocument validateUserInterfaceItem:]): Disable save commands when modal window is up. Also implement validation for all three of the save commands that we implement.
- BrowserDocumentController.m: (-[BrowserDocumentController validateUserInterfaceItem:]): Disable newTab: when modal window is up.
- BrowserWebView.m: (-[BrowserWebView webView:createWebViewModalDialogWithRequest:]): Added. Creates a window that has no toolbar, which is an efficient way to disable all the toolbar-related commands for that window, even ones built into AppKit which otherwise would be difficult to disable. (-[BrowserWebView webViewRunModal:]): Added. Currently just calls -[NSApplication runModalForWindow:] but could do more in the future. More importantly, having this implemented is how the Web Kit can tell that this application supports modal web dialogs. (-[BrowserWebView validateUserInterfaceItem:]): Disable setPageForSnapBackToCurrentPage: for modal windows.
- BrowserWindow.m: (-[BrowserWindow close]): Abort the modal session if the window being closed is the modal window. This is the only way we return from webViewRunModal:.
- BrowserWindowController.m: (-[BrowserWindowController canShowInputFields]): Return no when this window is modal. (-[BrowserWindowController validateUserInterfaceItem:]): Disable newTab: and newBookmarkFolder: when modal window is up. (-[BrowserWindowController validateMenuItem:]): Disable Show/Hide of address bar, bookmarks bar, bookmarks collection, and toggleFullScreen: when modal window is up. (-[BrowserWindowController showWindow:]): Change code so that a new window always comes up behind a modal window. Also rearranged things so that setWindowFocusDisabled:YES will be called in any case where the window does not start out as key.
- 4:03 PM Changeset in webkit [9249]
-
- 52 copies2 deletes in tags/WebCore-415~8
This commit was manufactured by cvs2svn to create tag
'WebCore-415~8'.
- 4:03 PM Changeset in webkit [9248] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiCambridge - WebCore-415.8
- 4:01 PM Changeset in webkit [9247]
-
- 12 copies3 deletes in tags/WebKit-412~3
This commit was manufactured by cvs2svn to create tag 'WebKit-412~3'.
- 4:01 PM Changeset in webkit [9246] by
-
- 2 edits in branches/Safari-2-0-branch/WebKit
Versioning for SUTiCambridge - WebKit-412.3
- 3:47 PM Changeset in webkit [9245] by
-
- 2 edits in branches/Safari-2-0-branch/WebKit
Merged fix for 4097289 from TOT for SUTiCambridge.
2005-05-24 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/4097289> -[WebView elementAtPoint:] failing when WebView is nested and offset
Code to determine the correct frame under the window point was
converting the point incorrectly.
Reviewed by Chris.
- WebView.subproj/WebView.m: (-[WebView _frameViewAtWindowPoint:]):
- 3:34 PM Changeset in webkit [9244] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Re-adding fix for <rdar://problem/4067761>, including fix for <rdar://problem/4135705>
2005-06-01 Adele Peterson <adele@apple.com>
fix for <rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()
Reviewed by Darin.
Synchronous loads don't get added to our requestsByDocument dictionary, so we should try to remove the request in this case.
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::removeFromRequestsByDocument): added checks to make sure request exists before trying to remove it.
- 3:23 PM Changeset in webkit [9243] by
-
- 2 edits in trunk/WebCore
fix for <rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()
Reviewed by Darin.
Synchronous loads don't get added to our requestsByDocument dictionary, so we should try to remove the request in this case.
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::removeFromRequestsByDocument): added checks to make sure request exists before trying to remove it.
- 10:00 AM Changeset in webkit [9242]
-
- 52 copies2 deletes in tags/WebCore-415~7
This commit was manufactured by cvs2svn to create tag
'WebCore-415~7'.
- 10:00 AM Changeset in webkit [9241] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Backing out fix for <rdar://problem/4067761> because it caused
<rdar://problem/4135705> REGRESSION (412-TOT) crash in TV Tracker widget - KJS::XMLHttpRequest::removeFromRequestsByDocument()
May 31, 2005:
- 4:48 PM Changeset in webkit [9240] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Change by Adele, Reviewed by Maciej.
- khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::mark): added nil check.
- khtml/ecma/kjs_dom.cpp: (DOMNode::mark): added nil check.
- 3:45 PM Changeset in webkit [9239] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Change by Adele, Reviewed by Maciej.
- khtml/ecma/kjs_dom.cpp: (DOMNode::~DOMNode): Added nil check. On the branch, its possible to create a node with no impl.
- 12:48 PM Changeset in webkit [9238] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiCambridge - WebCore-415.7
- 12:43 PM Changeset in webkit [9237]
-
- 10 copies3 deletes in tags/JavaScriptCore-412~3
This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~3'.
- 12:43 PM Changeset in webkit [9236] by
-
- 2 edits in branches/Safari-2-0-branch/JavaScriptCore
Version for SUTiCambridge - JavaScriptCore-412.3
- 12:37 PM Changeset in webkit [9235] by
-
- 7 edits in branches/Safari-2-0-branch/WebCore
Merged fix for 4125222 from TOT for SUTiCambridge
2005-05-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- fixed <rdar://problem/4125222> Dashboard heap size grows over time (leak caused by JavaScript DOM node wrappers?)
- changed per-document DOMObject caching to work with DOMNodes, since that is all it was used for anyway.
- khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObjectForDocument): New function - allows nodes that get removed from the document to go away from the cache if not referenced. (KJS::ScriptInterpreter::mark): Don't mark nodes that aren't in the document, they can stay in the cache but only if they have another source of life. (KJS::ScriptInterpreter::domNodesPerDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::getDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::putDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::updateDOMNodeDocument): Renamed and changed parameter types.
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): call forgetDOMObjectForDocument. (KJS::DOMNode::mark): If the node is not in the document, make sure to mark all wrappers in its detached piece of the tree. (KJS::getDOMNode): Updated for renames
- khtml/ecma/kjs_dom.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Updated for renames.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Updated for renames.
- 10:10 AM Changeset in webkit [9234] by
-
- 4 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4067761> from TOT to SUTiCambridge.
2005-05-27 Adele Peterson <adele@apple.com>
Change by Darin, reviewed by me.
fix for <rdar://problem/4067761> 8A425: reload stock widget over and over and crash in XMLHttpRequest::changeState
- khtml/khtml_part.cpp: (KHTMLPart::closeURL): now cancels XMLHttpRequests
- khtml/ecma/xmlhttprequest.h: Added cancelRequests, addToRequestsByDocument, and RemoveFromRequestsByDocument methods. Added requestsByDocument dictionary.
- khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): calls addToRequestsByDocument (KJS::XMLHttpRequest::abort): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::slotFinished): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::requestsByDocument): creates dictionary to manage requests. (KJS::XMLHttpRequest::addToRequestsByDocument): adds this request to dict. (KJS::XMLHttpRequest::removeFromRequestsByDocument): removes this request from dict. (KJS::XMLHttpRequest::cancelRequests): goes and cancels requests in the doc
- 9:57 AM Changeset in webkit [9233] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4121747> from TOT for SUTiCambridge.
2005-05-27 Adele Peterson <adele@apple.com>
Reviewed by Darin.
fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)
- khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
- khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.