Timeline
Jun 6, 2005:
- 10:25 PM Changeset in webkit [9320] by
-
- 2 edits in trunk/JavaScriptCore
- tests/mozilla/run-mozilla-tests: Wrote a perl version of this so we don't require the "jst" tool to run the tests.
- 10:21 PM Changeset in webkit [9319] by
-
- 2 edits in trunk
purify the ChangeLog's essence
- 9:07 PM Changeset in webkit [9318] by
-
- 2 edits in trunk/WebKit
- Info.plist: Bumped version to 412+. For some reason it was set to 312.1!
- 8:07 PM Changeset in webkit [9317] by
-
- 2 edits in trunk/WebKitTools
- Scripts/build-webkit: run ranlib on libWebKitSystemInterface.a
- 7:54 PM Changeset in webkit [9316] by
-
- 2 edits in trunk/WebKitTools
- Scripts/build-webkit: Chop newline off of $productDir to avoid problems with logic to copy files ther.
- 7:26 PM Changeset in webkit [9315] by
-
- 2 edits in trunk/WebKitTools
- Scripts/build-webkit: Install WebKitSystemInterface stuff into build products dir.
- 6:48 PM Changeset in webkit [9314] by
-
- 1 edit in trunk/WebKit/ChangeLog
Remove mention of SPI removal work from ChangeLog per request.
- 5:54 PM Changeset in webkit [9313] by
-
- 2 edits in trunk/WebKit
- fix crashing problem in last change
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
- 5:51 PM Changeset in webkit [9312] by
-
- 2 edits in trunk/WebKitLibraries
- updated for crashing bugfix
- libWebKitSystemInterface.a:
- 5:37 PM Changeset in webkit [9311] by
-
- 3 edits in trunk/WebKit
- removed carbon and text SPI
- Carbon.subproj/HIWebView.m: (-[MenuItemProxy initWithAction:]): (-[MenuItemProxy action]): (-[MenuItemProxy tag]): (GetWindowRef): (Click): (MouseUp): (MouseMoved): (MouseDragged): (MouseWheelMoved): (WindowHandler): (HIWebViewEventHandler): (UpdateObserver):
- WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (-[WebTextRenderer initWithFont:usingPrinterFont:]): (-[WebTextRenderer dealloc]): (-[WebTextRenderer finalize]): (-[WebTextRenderer _substituteFontForString:families:]): (-[WebTextRenderer _convertCharacters:length:toGlyphs:]): (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _setupFont]): (_drawGlyphs): (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _initializeATSUStyle]): (fillStyleWithAttributes):
- 5:35 PM Changeset in webkit [9310] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 7:53 AM Changeset in webkit [9309] by
-
- 2 edits in trunk/WebKit
- remove plugin-related SPI calls
- Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
- 7:51 AM Changeset in webkit [9308] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 6:47 AM Changeset in webkit [9307] by
-
- 2 edits in trunk/WebKit
- remove graphics SPI use
- WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge setFocusRingStyle:radius:color:]): (-[WebGraphicsBridge setDraggingImage:at:]):
- 6:45 AM Changeset in webkit [9306] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 6:26 AM Changeset in webkit [9305] by
-
- 3 edits in trunk/WebKit
- more SPI removal, for font cache and CFStream
- WebCoreSupport.subproj/WebTextRendererFactory.m: (getLCDScaleParameters): (+[WebTextRendererFactory createSharedFactory]):
- WebView.subproj/WebFormDataStream.m: (formCanRead): (formEventCallback): (webSetHTTPBody):
- 6:24 AM Changeset in webkit [9304] by
-
- 3 edits in trunk/WebKitLibraries
Reviewed by NOBODY (OOPS!).
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 5:48 AM Changeset in webkit [9303] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 5:48 AM Changeset in webkit [9302] by
-
- 2 edits in trunk/WebKit
- remove use of AX SPI
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): (-[WebViewFactory objectIsTextMarkerRange:]): (-[WebViewFactory textMarkerWithBytes:length:]): (-[WebViewFactory getBytes:fromTextMarker:length:]): (-[WebViewFactory textMarkerRangeWithStart:end:]): (-[WebViewFactory startOfTextMarkerRange:]): (-[WebViewFactory endOfTextMarkerRange:]): (-[WebViewFactory accessibilityHandleFocusChanged]): (-[WebViewFactory AXUIElementForElement:]): (-[WebViewFactory unregisterUniqueIdForUIElement:]):
- 5:16 AM Changeset in webkit [9301] by
-
- 3 edits in trunk/WebKit
- removed more SPI
- Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
- WebView.subproj/WebHTMLView.m: (+[WebHTMLView _postFlagsChangedEvent:]): (-[WebHTMLView _autoscroll]): (-[WebHTMLView addMouseMovedObserver]): (-[WebHTMLView removeMouseMovedObserver]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView _interceptEditingKeyEvent:]):
- 5:14 AM Changeset in webkit [9300] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 4:43 AM Changeset in webkit [9299] by
-
- 8 edits in trunk/WebKit
- more SPI use removal
- Misc.subproj/WebDownload.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]):
- WebView.subproj/WebMainResourceClient.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]):
- WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
- 4:42 AM Changeset in webkit [9298] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 4:16 AM Changeset in webkit [9297] by
-
- 2 edits in trunk/WebKit
- remove unneeded header include
- WebCoreSupport.subproj/WebImageRenderer.m:
- 4:12 AM Changeset in webkit [9296] by
-
- 8 edits in trunk/WebKit
- removed even more SPI use
- Misc.subproj/WebDownload.m:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]):
- WebCoreSupport.subproj/WebImageRenderer.m: (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray):
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didReceiveResponse:]): (-[WebMainResourceClient didReceiveData:lengthReceived:]): (-[WebMainResourceClient didFinishLoading]): (-[WebMainResourceClient didFailWithError:]):
- 4:11 AM Changeset in webkit [9295] by
-
- 3 edits in trunk/WebKitLibraries
- updated
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
Jun 5, 2005:
- 11:05 PM Changeset in webkit [9294] by
-
- 4 edits1 add in trunk/WebKitTools
- DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Tweak, simplify.
- Scripts/build-dumprendertree: Added.
- Scripts/build-webkit: Build All in the JavaScriptCore directory.
- Scripts/run-webkit-tests: Build DumpRenderTree before running.
- 10:46 PM Changeset in webkit [9293] by
-
- 2 edits2 adds in trunk/LayoutTests/fast/css-generated-content
Change layout test #10 to use a smaller bullet image.
- 10:15 PM Changeset in webkit [9292] by
-
- 3 edits in trunk/WebKit
Reviewed by Hyatt.
- fixed hang we were seeing in Safari and layout tests
- Misc.subproj/WebNSUserDefaultsExtras.m: (+[NSUserDefaults _webkit_ensureAndLockPreferredLanguageLock]): Change name to avoid conflict with Foundation function. This was causing the hang. (+[NSUserDefaults _webkit_defaultsDidChange]): Update caller. (+[NSUserDefaults _webkit_preferredLanguageCode]): Ditto.
- WebCoreSupport.subproj/WebGraphicsBridge.m: Remove some unneeded includes.
- 8:44 PM Changeset in webkit [9291] by
-
- 2 edits in trunk/WebKit
Reviewed by Hyatt.
- fixed crash in Acid2 layout test
- Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Added nil check for CFBundleRef.
- 8:25 PM Changeset in webkit [9290] by
-
- 2 edits in trunk/WebKit
Reviewed by Hyatt.
- remove more SPI usage
- Carbon.subproj/CarbonWindowAdapter.m: Remove a bunch of stuff. (+[CarbonWindowAdapter frameViewClassForStyleMask:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): (-[CarbonWindowAdapter _oldPlaceWindow:]): (-[CarbonWindowAdapter _termWindowIfOwner]): (-[CarbonWindowAdapter _windowMovedToRect:]): (-[CarbonWindowAdapter makeKeyWindow]):
- 7:39 PM Changeset in webkit [9289] by
-
- 2 edits in trunk/WebKit
- remove another forgotten include
- Plugins.subproj/WebPluginDatabase.m:
- 7:27 PM Changeset in webkit [9288] by
-
- 2 edits in trunk/WebKit
- remove include that I forgot in last checkin
- Misc.subproj/WebNSPasteboardExtras.m:
- 7:21 PM Changeset in webkit [9287] by
-
- 3 edits in trunk/WebKitLibraries
- added a few more bits of SPI
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 7:21 PM Changeset in webkit [9286] by
-
- 6 edits in trunk/WebKit
Reviewed by Don.
- remove more SPI usage
- fix <rdar://problem/3446192> CoreTranslation SPI is going away
- History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releasePageCache:]):
- Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]):
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _setupFont]):
- WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]):
- 7:00 PM Changeset in webkit [9285] by
-
- 1 delete in trunk/WebKit/WebKitSecurityDummy.c
* empty log message *
- 5:34 PM Changeset in webkit [9284] by
-
- 2 edits in trunk/WebKitTools
- Scripts/run-safari: Fix path to Safari executable. Add check for frameworks.
- 5:15 PM Changeset in webkit [9283] by
-
- 16 edits in trunk/WebKit
Reviewed by Darin.
- use WebKitSystemInterface wrappers for NSURLFileTypeMappings and NSURLResponse SPI
- Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]):
- Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate didReceiveResponse:]):
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForExtension:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge expiresTimeForResponse:]): (-[WebBridge determineObjectFromMIMEType:URL:]): (-[WebBridge MIMETypeForPath:]):
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]):
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]):
- WebView.subproj/WebDataSource.m: (-[WebDataSource _commitIfReady:]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView resourceForData:preferredFilename:]):
- WebView.subproj/WebMainResourceClient.m:
- WebView.subproj/WebView.m: (+[WebView _supportedFileExtensions]): (+[WebView suggestedFileExtensionForMIMEType:]): (+[WebView _MIMETypeForFile:]):
- 5:12 PM Changeset in webkit [9282] by
-
- 3 edits in trunk/WebKitLibraries
- added file type and NSURLResponse caching SPI
- WebKitSystemInterface.h:
- libWebKitSystemInterface.a:
- 4:34 PM Changeset in webkit [9281] by
-
- 1 edit7 adds in trunk/WebKitTools
- add run-webkit-tests script; not working yet but the pieces are there
- Scripts/run-webkit-tests: Added.
- DumpRenderTree/DumpRenderTree.m: Added.
- DumpRenderTree/DumpRenderTree.xcode/.cvsignore: Added.
- DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added.
- DumpRenderTree/DumpRenderTreePrefix.h: Added.
- 4:14 PM Changeset in webkit [9280] by
-
- 7 adds in trunk/WebKitTools
- created module, first cut at Web Kit Open Source Project scripts
- ChangeLog: Added.
- Scripts/build-webkit: Added.
- Scripts/run-safari: Added.
- Scripts/update-webkit: Added.
- checkout: Added.
- 2:17 PM Changeset in webkit [9279] by
-
- 4 adds in trunk/WebKitLibraries
- initial checkin of WebKitSystemInterface binary
- WebKitSystemInterface.h: Added.
- libWebKitSystemInterface.a: Added.
- 1:57 PM Changeset in webkit [9278] by
-
- 7 edits in trunk/WebKit
Reviewed by Hyatt.
- fixed build that I broke with the license change (some includes of WebException were still around)
- WebKit.pbproj/project.pbxproj: Removed references to WebException.h/m.
- WebView.subproj/WebDataSource.m: Removed include of WebException.h.
- WebView.subproj/WebHTMLView.m: Ditto.
- WebView.subproj/WebView.m: Ditto.
- fixed build under gcc 4.0 (some code moved here from Foundation had warnings)
- Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use char instead of UInt8. (-[NSData _webkit_guessedMIMEType]): Use char instead of UInt8, and take out now- unneeded type casts.
- 1:42 PM Changeset in webkit [9277] by
-
- 3 edits2 deletes in trunk/WebKit
Reviewed by Don.
- remove security code and use the stuff from WebKitSystemInterface instead
- WebCoreSupport.subproj/WebKeyGenerator.m: (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
- WebCoreSupport.subproj/WebNewKeyGeneration.c: Removed.
- WebCoreSupport.subproj/WebNewKeyGeneration.h: Removed.
- WebKit.pbproj/project.pbxproj:
- 10:54 AM Changeset in webkit [9276] by
-
- 268 edits1 add4 deletes in trunk/WebKit
- added appropriate license headers to most files and updated copyright to reflect publication dates
- LICENSE: Added.
- <lots of files>: Added license header.
- WebKit.pbproj/project.pbxproj: Removed references to NP_objc.h.
- API-Issues.rtf: Removed.
- Misc.subproj/WebException.h: Removed.
- Misc.subproj/WebException.m: Removed.
- Plugins.subproj/NP_objc.h: Removed.
- 2:22 AM Changeset in webkit [9275] by
-
- 4 edits in trunk/WebKit
Reviewed by Hyatt.
- link against libWebKitSystemInterface and use the first function in it.
- Misc.subproj/WebNSUserDefaultsExtras.m: (-[NSString _webkit_HTTPStyleLanguageCode]): use WKCopyCFLocalizationPreferredName
- Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): ditto
- WebKit.pbproj/project.pbxproj: link in libWebKitSystemInterface.a and find headers.
- 12:06 AM Changeset in webkit [9274] by
-
- 9 edits19 adds in trunk
WebCore:
Reviewed by Don.
- got rid of the rest of the dependencies on Apple Internal headers
- kwq/WebCoreBridge.mm: Remove include of unused SPI header.
- kwq/KWQAccObjectCache.h: Remove include of SPI header. Change use of AXTextMarkerRef to use WebCoreTextMarker instead. Also ifdef less.
- kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::textMarkerForVisiblePosition): Change types, call new WebCoreViewFactory methods. (KWQAccObjectCache::visiblePositionForTextMarker): Ditto. (KWQAccObjectCache::handleFocusedUIElementChanged): Ditto.
- kwq/WebCoreViewFactory.h: Add new methods we can use instead of Accessibility SPI.
- kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Call new WebCoreViewFactory method instead of SPI. (-[KWQAccObject accessibilityAttributeNames]): Use strings instead of constants only in SPI header. (-[KWQAccObject textMarkerRangeFromMarkers:andEndMarker:]): Change parameter types from SPI type to a new type defined by WebCoreViewFactory, use WebCoreViewFactory method. (-[KWQAccObject textMarkerForVisiblePosition:]): Ditto. (-[KWQAccObject visiblePositionForTextMarker:]): Ditto. (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): Ditto. (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): Ditto. (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): Just change type. (-[KWQAccObject textMarkerRange]): Ditto. (-[KWQAccObject accessibilityAttributeValue:]): String instead of constant. (-[KWQAccObject accessibilityParameterizedAttributeNames]): Ditto. (-[KWQAccObject doAXUIElementForTextMarker:]): Just change type. (-[KWQAccObject doAXLineForTextMarker:]): Ditto. (-[KWQAccObject doAXStringForTextMarkerRange:]): Ditto. (-[KWQAccObject doAXBoundsForTextMarkerRange:]): Ditto. (AXAttributeStringSetElement): Call new method. (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]): Just change type. (-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]): Ditto. (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXSentenceTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXParagraphTextMarkerRangeForTextMarker:]): Ditto. (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Ditto. (-[KWQAccObject doAXLengthForTextMarkerRange:]): Ditto. (-[KWQAccObject accessibilityAttributeValue:forParameter:]): Change types, use new methods, use strings instead of constants. (-[KWQAccObject accessibilityIsAttributeSettable:]): String instead of constant. (-[KWQAccObject doSetAXSelectedTextMarkerRange:]): New type. (-[KWQAccObject accessibilitySetValue:forAttribute:]): New types, methods.
WebKit:
Reviewed by Don.
- did some work to move SPI use from WebCore here (to be moved from here into WebKitSystemInterface)
- fixed so we can compile ICU includes without Apple Internal headers installed
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory objectIsTextMarker:]): Added. (-[WebViewFactory objectIsTextMarkerRange:]): Added. (-[WebViewFactory textMarkerWithBytes:length:]): Added. (-[WebViewFactory getBytes:fromTextMarker:length:]): Added. (-[WebViewFactory textMarkerRangeWithStart:end:]): Added. (-[WebViewFactory startOfTextMarkerRange:]): Added. (-[WebViewFactory endOfTextMarkerRange:]): Added. (-[WebViewFactory accessibilityHandleFocusChanged]): Added. (-[WebViewFactory AXUIElementForElement:]): Added. (-[WebViewFactory unregisterUniqueIdForUIElement:]): Added.
- WebKit.pbproj/project.pbxproj: Added icu to the header search files. Removed bogus DSTROOT thing from the framework paths (I meant to remove that a while back).
- icu/README: Added.
- icu/unicode/parseerr.h: Added.
- icu/unicode/platform.h: Added.
- icu/unicode/uchar.h: Added.
- icu/unicode/uconfig.h: Added.
- icu/unicode/uidna.h: Added.
- icu/unicode/uiter.h: Added.
- icu/unicode/umachine.h: Added.
- icu/unicode/unorm.h: Added.
- icu/unicode/urename.h: Added.
- icu/unicode/uscript.h: Added.
- icu/unicode/utf.h: Added.
- icu/unicode/utf16.h: Added.
- icu/unicode/utf8.h: Added.
- icu/unicode/utf_old.h: Added.
- icu/unicode/utypes.h: Added.
- icu/unicode/uversion.h: Added.
Jun 4, 2005:
- 5:44 PM Changeset in webkit [9273] by
-
- 1 edit in trunk/WebCore/ChangeLog-2005-08-23
Fix silly ChangeLog typo.
- 5:42 PM Changeset in webkit [9272] by
-
- 2 edits22 adds in trunk/WebCore
Reviewed by Maciej.
- first fix on the road to can compile without Apple Internal headers installed
- WebCore.pbproj/project.pbxproj: Added icu directory to header search path.
- icu/README: Added.
- icu/unicode/parseerr.h: Added.
- icu/unicode/platform.h: Added.
- icu/unicode/putil.h: Added.
- icu/unicode/ubrk.h: Added.
- icu/unicode/uchar.h: Added.
- icu/unicode/uconfig.h: Added.
- icu/unicode/uenum.h: Added.
- icu/unicode/uidna.h: Added.
- icu/unicode/uiter.h: Added.
- icu/unicode/uloc.h: Added.
- icu/unicode/umachine.h: Added.
- icu/unicode/urename.h: Added.
- icu/unicode/ustring.h: Added.
- icu/unicode/utf.h: Added.
- icu/unicode/utf16.h: Added.
- icu/unicode/utf8.h: Added.
- icu/unicode/utf_old.h: Added.
- icu/unicode/utypes.h: Added.
- icu/unicode/uversion.h: Added.
- 5:41 PM Changeset in webkit [9271] by
-
- 2 edits14 adds in trunk/JavaScriptCore
Reviewed by Maciej.
- fixed so we can compile without Apple Internal headers installed
- JavaScriptCore.pbproj/project.pbxproj: Added icu directory to header search path.
- icu/README: Added.
- icu/unicode/platform.h: Added.
- icu/unicode/uchar.h: Added.
- icu/unicode/uconfig.h: Added.
- icu/unicode/umachine.h: Added.
- icu/unicode/urename.h: Added.
- icu/unicode/utf.h: Added.
- icu/unicode/utf16.h: Added.
- icu/unicode/utf8.h: Added.
- icu/unicode/utf_old.h: Added.
- icu/unicode/utypes.h: Added.
- icu/unicode/uversion.h: Added.
- 3:46 PM Changeset in webkit [9270] by
-
- 3 edits in trunk/WebKit
Reviewed by Vicki.
- replace more use of CGCompositeOperation that I missed.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage _PDFDrawFromRect:toRect:operation:alpha:flipped:]):
Jun 3, 2005:
- 4:25 PM Changeset in webkit [9269] by
-
- 5 edits in trunk/WebKit
Reviewed by NOBODY (OOPS!).
- replace use of CGCompositeOperation SPI with NSCompositingOperation API
- WebCoreSupport.subproj/WebImageData.h:
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]):
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory CGCompositeOperationInContext:]): (-[WebImageRendererFactory setCGCompositeOperation:inContext:]): (-[WebImageRendererFactory setCGCompositeOperationFromString:inContext:]):
- 2:34 PM Changeset in webkit [9268]
-
- 53 copies2 deletes in tags/WebCore-415~9
This commit was manufactured by cvs2svn to create tag
'WebCore-415~9'.
- 2:34 PM Changeset in webkit [9267] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Versioning for SUTiCambridge - WebCore-415.9
- 2:11 PM Changeset in webkit [9266] by
-
- 3 edits in branches/Safari-2-0-branch/WebCore
Merged fix for <rdar://problem/4109667> from TOT for SUTiCambridge.
Our fix for the Cingular bug (<rdar://problem/4121747>)relies on this.
2005-05-05 David Hyatt <hyatt@apple.com>
Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.
The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.
Reviewed by John Sullivan
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
- khtml/xml/dom_docimpl.h:
Jun 2, 2005:
- 10:56 PM Changeset in webkit [9265] by
-
- 11 edits in trunk/WebKit
Reviewed by Kevin.
- removed dependencies on NSError SPI
- Misc.subproj/WebKitErrors.m: (-[NSError _webkit_initWithDomain:code:URL:]): (+[NSError _webkit_errorWithDomain:code:URL:]): (+[NSError _webKitErrorWithDomain:code:URL:]): (+[NSError _webKitErrorWithCode:failingURL:]): (+[NSError _webkit_addErrorsWithCodesAndDescriptions:inDomain:]): (registerErrors):
- Plugins.subproj/WebNetscapePluginRepresentation.m:
- Plugins.subproj/WebNetscapePluginStream.m:
- WebCoreSupport.subproj/WebSubresourceClient.m:
- WebView.subproj/WebBaseResourceHandleDelegate.m:
- WebView.subproj/WebDefaultResourceLoadDelegate.m:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didFailWithError:]):
- 9:46 PM Changeset in webkit [9264] by
-
- 5 edits in trunk/WebKit
Reviewed by Vicki.
- remove use of _cfBundle SPI
- Plugins.subproj/WebBasePluginPackage.h:
- Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
- Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- 9:16 PM Changeset in webkit [9263] by
-
- 17 edits4 adds in trunk/WebKit
Reviewed by Adele.
- remove use of NSURLRequest and NSUserDefaults SPI
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
- Misc.subproj/WebNSURLRequestExtras.h: Added.
- Misc.subproj/WebNSURLRequestExtras.m: Added. (-[NSURLRequest _web_HTTPReferrer]): (-[NSURLRequest _web_HTTPContentType]): (-[NSMutableURLRequest _web_setHTTPContentType:]): (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
- Misc.subproj/WebNSUserDefaultsExtras.h: Added.
- Misc.subproj/WebNSUserDefaultsExtras.m: Added. (-[NSString _webkit_HTTPStyleLanguageCode]): (makeLock): (+[NSUserDefaults _ensureAndLockPreferredLanguageLock]): (+[NSUserDefaults _webkit_defaultsDidChange]): (addDefaultsChangeObserver): (+[NSUserDefaults _webkit_addDefaultsChangeObserver]): (+[NSUserDefaults _webkit_preferredLanguageCode]):
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]):
- Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge incomingReferrer]): (-[WebBridge createModalDialogWithURL:]):
- WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
- WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory defaultLanguageCode]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- WebView.subproj/WebMainResourceClient.m:
- WebView.subproj/WebView.m: (-[WebView _cachedResponseForURL:]): (-[WebView userAgentForURL:]):
- 8:36 PM Changeset in webkit [9262] by
-
- 3 edits in trunk/WebKit
Reviewed by Don.
- move private gunk from header to implementation file.
- WebCoreSupport.subproj/WebNewKeyGeneration.c:
- WebCoreSupport.subproj/WebNewKeyGeneration.h:
- 8:12 PM Changeset in webkit [9261] by
-
- 10 edits4 adds in trunk/WebKit
Reviewed by Kevin.
- remove dependency on NSFileManager and NSCalendarDate private extras from WebFou
- History.subproj/WebHistory.m: (-[WebHistoryPrivate findIndex:forDay:]): (-[WebHistoryPrivate arrayRepresentation]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
- Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]):
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_fixedCarbonPOSIXPath]):
- Misc.subproj/WebNSCalendarDateExtras.h: Added.
- Misc.subproj/WebNSCalendarDateExtras.m: Added. (-[NSCalendarDate _webkit_compareDay:]):
- Misc.subproj/WebNSDataExtras.h:
- Misc.subproj/WebNSDictionaryExtras.h:
- Misc.subproj/WebNSFileManagerExtras.h: Added.
- Misc.subproj/WebNSFileManagerExtras.m: Added. (-[NSFileManager _webkit_fileExistsAtPath:isDirectory:traverseLink:]): (-[NSFileManager _webkit_createIntermediateDirectoriesForPath:attributes:]): (-[NSFileManager _webkit_createDirectoryAtPathWithIntermediateDirectories:attributes:]): (-[NSFileManager _webkit_createFileAtPathWithIntermediateDirectories:contents:attributes:directoryAttributes:]): (-[NSFileManager _webkit_removeFileOnlyAtPath:]): (-[NSFileManager _webkit_backgroundRemoveFileAtPath:]): (-[NSFileManager _webkit_backgroundRemoveLeftoverFiles:]): (-[NSFileManager _webkit_carbonPathForPath:]): (-[NSFileManager _webkit_startupVolumeName]): (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
- Plugins.subproj/WebBaseNetscapePluginStream.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
- WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
- 4:54 PM Changeset in webkit [9260] by
-
- 21 edits2 adds in trunk/WebKit
Reviewed by Adele.
- remove dependencies on NSDictionary and NSURL extras
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]):
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
- Misc.subproj/WebNSDictionaryExtras.h: Added.
- Misc.subproj/WebNSDictionaryExtras.m: Added. (-[NSDictionary _webkit_numberForKey:]): (-[NSDictionary _webkit_intForKey:]): (-[NSDictionary _webkit_stringForKey:]): (-[NSDictionary _webkit_objectForMIMEType:]): (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[NSMutableDictionary _webkit_setInt:forKey:]): (-[NSMutableDictionary _webkit_setBool:forKey:]):
- Misc.subproj/WebNSPasteboardExtras.m:
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_scriptIfJavaScriptURL]): (-[NSURL _webkit_isFileURL]): (-[NSURL _web_hostString]): (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
- Misc.subproj/WebNSViewExtras.m:
- Panels.subproj/WebPanelAuthenticationHandler.m:
- Plugins.subproj/WebBaseNetscapePluginStream.m:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins.subproj/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
- WebCoreSupport.subproj/WebBridge.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebDataSource.m:
- WebView.subproj/WebFrame.m:
- WebView.subproj/WebFrameView.m:
- WebView.subproj/WebHTMLView.m:
- WebView.subproj/WebPreferences.m: (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _setBoolValue:forKey:]):
- WebView.subproj/WebResource.m: (-[WebResource _initWithPropertyList:]): (-[WebResource _fileWrapperRepresentation]):
- WebView.subproj/WebView.m:
- 3:09 PM Changeset in webkit [9259] by
-
- 16 edits in trunk/WebKit
Reviewed by Vicki.
- remove dependencies on NSString and NSData extras from Foundation
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_isCaseInsensitiveEqualToString:]): (-[NSString _webkit_hasCaseInsensitivePrefix:]): (-[NSString _webkit_stringByTrimmingWhitespace]): (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): (-[NSString _webkit_fixedCarbonPOSIXPath]):
- Misc.subproj/WebNSDataExtras.h:
- Misc.subproj/WebNSDataExtras.m: (-[NSString _web_capitalizeRFC822HeaderFieldName]): (-[NSData _web_isCaseInsensitiveEqualToCString:]): (_findEOL): (-[NSData _web_parseRFC822HeaderFields]): (-[NSData _webkit_guessedMIMETypeForXML]): (-[NSData _webkit_guessedMIMEType]):
- Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (applyHostNameFunctionToURLString): (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): (+[NSURL _web_URLWithDataAsString:relativeToURL:]): (-[NSURL _webkit_shouldLoadAsEmptyDocument]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]): (-[NSString _webkit_isFTPDirectoryURL]): (-[NSString _web_encodeHostName]): (-[NSString _webkit_rangeOfURLScheme]): (-[NSString _webkit_looksLikeAbsoluteURL]): (-[NSString _webkit_URLFragment]):
- Misc.subproj/WebNSViewExtras.m:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
- Plugins.subproj/WebPluginDatabase.m:
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]):
- WebView.subproj/WebDataSource.m: (-[WebDataSource _setTitle:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]):
- WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]):
- WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
- 2:19 PM Changeset in webkit [9258] by
-
- 33 edits in trunk/WebKit
Reviewed by John.
- first stage of cleaning up SPI usage in WebKit
- Carbon.subproj/CarbonUtils.m:
- DOM.subproj/WebDOMOperations.m: (-[DOMHTMLLinkElement _subresourceURLs]): (-[DOMHTMLParamElement _subresourceURLs]):
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]):
- Misc.subproj/WebDatabase.m: (-[WebDatabase setObject:forKey:]): (-[WebDatabase removeObjectForKey:]): (-[WebDatabase removeAllObjects]): (-[WebDatabase objectForKey:]): (-[WebDatabase open]): (-[WebDatabase close]): (-[WebDatabase sync]): (-[WebDatabase count]): (-[WebDatabase setSizeLimit:]):
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase _iconForFileURL:withSize:]):
- Misc.subproj/WebKitNSStringExtras.h:
- Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): (-[NSString _webkit_isCaseInsensitiveEqualToString:]):
- Misc.subproj/WebNSEventExtras.h:
- Misc.subproj/WebNSEventExtras.m: (-[NSEvent _web_isTabKeyEvent]):
- Misc.subproj/WebNSURLExtras.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isJavaScriptURL]): (-[NSString _webkit_isFileURL]):
- Panels.subproj/WebPanelAuthenticationHandler.m: (-[NSMutableDictionary _webkit_setObject:forUncopiedKey:]): (-[WebPanelAuthenticationHandler enqueueChallenge:forWindow:]): (-[WebPanelAuthenticationHandler startAuthentication:window:]):
- Plugins.subproj/WebBaseNetscapePluginView.m:
- Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]):
- Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): (-[WebBridge valueForKey:keys:values:]):
- WebCoreSupport.subproj/WebGlyphBuffer.m:
- WebCoreSupport.subproj/WebImageDecodeItem.h:
- WebCoreSupport.subproj/WebImageDecodeItem.m:
- WebCoreSupport.subproj/WebImageDecoder.h:
- WebCoreSupport.subproj/WebImageDecoder.m:
- WebCoreSupport.subproj/WebTextRenderer.h:
- WebKitPrefix.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceForRequest:]):
- WebView.subproj/WebDataProtocol.m: (+[WebDataProtocol _webIsDataProtocolURL:]):
- WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame reload]):
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation _isDisplayingWebArchive]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient didReceiveResponse:]):
- WebView.subproj/WebPDFView.m:
- WebView.subproj/WebView.m: (+[WebView _MIMETypeForFile:]):
- 12:26 PM Changeset in webkit [9257]
-
- 11 copies3 deletes in tags/WebKit-312~2
This commit was manufactured by cvs2svn to create tag 'WebKit-312~2'.
- 12:26 PM Changeset in webkit [9256] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
change by Darin, reviewed by me.
- WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer]
(-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
- 9:35 AM Changeset in webkit [9255]
-
- 27 copies2 deletes in tags/WebCore-315~5
This commit was manufactured by cvs2svn to create tag
'WebCore-315~5'.
- 9:35 AM Changeset in webkit [9254] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Versioning for Safari-1-3-branch - WebCore-315.5 (skipped .4)
- 9:33 AM Changeset in webkit [9253] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
Versioning for Safari-1-3-branch - WebKit-312.2
- 8:49 AM Changeset in webkit [9252] by
-
- 13 edits in branches/Safari-1-3-branch/WebCore
Merge for WebCore part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch.
2005-06-01 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.
- WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
- khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
- khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
- khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
- khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
- kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
- kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
- kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
- kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
- kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.
- 8:44 AM Changeset in webkit [9251] by
-
- 9 edits in branches/Safari-1-3-branch/WebKit
Merged WebKit part of fix for <rdar://problem/3166090> from TOT to Safari-1-3-branch
2005-06-01 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
- WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
- WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.