Timeline



Jun 11, 2005:

10:56 PM Changeset in webkit [9363] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/cvs-create-patch: Improve handling of directories with mixed CVS roots by going into each directory to execute the cvs diff commands.
10:41 PM Changeset in webkit [9362] by darin
  • 1 edit
    4 adds in trunk/WebKitTools
  • added first cuts at some cvs scripts

cvs-abandon is for throwing away changes; discards any local changes, reverting to the state in CVS
cvs-create-patch is for making patches; runs cvs diff with all the right options and handles added/deleted files
cvs-apply is for applying patches; runs patch and cvs add and cvs rm
cvs-unapply is for unapplying patches; does the opposite of cvs-apply

An argument against these is "waste of time if we switch to Subversion", but they should be good for a while.

  • Scripts/cvs-abandon: Added.
  • Scripts/cvs-apply: Added.
  • Scripts/cvs-create-patch: Added.
  • Scripts/cvs-unapply: Added.
9:07 PM Changeset in webkit [9361] by mjs
  • 5 edits
    3 adds in trunk

Patch from Nicholas Shanks <​contact@nickshanks.com>, by me.

Merge of svn log -v -r 399829 ​svn://anonsvn.kde.org/home/kde

Test cases added: Added the following from CSS selector test suite,
unfortunately 159 and 117a do not show any difference with and without the
patch since layout tests do not dump selection style (yet).

  • layout-tests/fast/selectors/159.html: Added.
  • layout-tests/fast/selectors/177a.html: Added.
  • layout-tests/fast/selectors/177b.html: Added.
  • khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::): (DOM::CSSSelector::pseudoType):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/css/parser.y:
2:51 AM Changeset in webkit [9360] by mjs
  • 2 edits
    2 adds in trunk

Patch from Timothy Hatcher <​timothy@colloquy.info>, reviewed by me.

Test cases added:

  • layout-tests/fast/dom/children-nodes-expected.txt: Added.
  • layout-tests/fast/dom/children-nodes.html: Added.
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::traverseNextItem): For "children" collection, use nextSibling() instead of traverseNextNext() to avoid doing deep traversal.
2:41 AM Changeset in webkit [9359] by mjs
  • 1 edit
    1 add in trunk

Added missing expected results from the background image patch.

  • layout-tests/fast/backgrounds/001-expected.txt: Added.

Jun 10, 2005:

10:31 PM Changeset in webkit [9358] by hyatt
  • 5 edits
    2 adds in trunk

Fix for bugzilla bug 3335, add support for the CSS3 indirect adjacent sibling selector. Patch merge
from KHTML tree by Nick Shanks.

Reviewed by hyatt

Test cases added: fast/selectors/046.html

  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSSelector::):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector):
  • khtml/css/parser.y:
  • layout-tests/fast/selectors/046-expected.txt: Added.
  • layout-tests/fast/selectors/046.html: Added.
10:01 PM Changeset in webkit [9357] by hyatt
  • 2 edits
    2 adds in trunk

Fix for 3237, background image repeats when it shouldn't. The Radar bug is 4005553. Patch from
Nate Cook.

Reviewed by darin and hyatt

Test cases added: fast/backgrounds/001.html

  • khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended):
  • layout-tests/fast/backgrounds/001.html: Added.
6:58 PM Changeset in webkit [9356] by hyatt
  • 3 edits in trunk/WebCore

Merge Allan Jensen's fix for 3236.

Reviewed by hyatt

Test cases added: None, test case already added for the bug.

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent):
5:42 PM Changeset in webkit [9355] by sullivan
  • 2 edits in trunk/WebKit

reviewed by Dave Harrison (first & second drafts) and Darin Adler (third draft)

  • WebKit part of fix for <rdar://problem/4145214> REGRESSION (412+): Can't drag URLs from the location bar
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): Reinstate variation of old code that uses CreatePasteboardFlavorTypeName to set up our new pasteboard types. The newfangled way didn't work.
5:40 PM Changeset in webkit [9354] by sullivan
  • 2 edits in trunk/WebKitLibraries

Updated copies of WebKitSystemInterface.h and libWebKitSystemInterface.a that include the new functions needed to fix 3446192.

11:02 AM Changeset in webkit [9353] by darin
  • 1 edit
    2 adds in trunk

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Refined and reviewed by me.

  • layout-tests/fast/js/exception-linenums-expected.txt: Added.
  • layout-tests/fast/js/exception-linenums.html: Added.
11:02 AM Changeset in webkit [9352] by darin
  • 3 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • further improvements to exception file/line number fix
  • kjs/nodes.h: Added setExceptionDetailsIfNeeded function.
  • kjs/nodes.cpp: Updated macros to call the new setExceptionDetailsIfNeeded function. (Node::setExceptionDetailsIfNeeded): Added.

Jun 9, 2005:

11:47 PM Changeset in webkit [9351] by hyatt
  • 2 edits
    2 adds in trunk

Fix from Carston Guenther for bugzilla bug 3236.

attr(x) should work even if x is not present on the element.

This is Radar bug #3584466

Reviewed by hyatt

Test cases added: fast/css-generated-content/013.html

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • layout-tests/fast/css-generated-content/013-expected.txt: Added.
  • layout-tests/fast/css-generated-content/013.html: Added.
9:27 PM Changeset in webkit [9350] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Tested by Mark Rowe.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
9:23 PM Changeset in webkit [9349] by darin
  • 2 edits in trunk

Tested by Brian Dash.

  • layout-tests/fast/js/date-parse-test.html: Updated this test to use a time zone offset for one of the test cases that's time zone dependent; was working in CA, US, failing in NZ.
4:17 PM Changeset in webkit [9348] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Change type from "folder" to "wrapper.framework" for Foundation.framework. How was it ever wrong?
  • finally, I tested making the default build directory work; it works now
  • Scripts/webkitdirs.pm: Changed structure of the code a little bit, added symrootXcodeOptions function that sets SYMROOT on the command line in case there's no product directory set in Xcode preferences.
  • Scripts/build-webkit: Pass symrootXcodeOptions when invoking Xcode.
  • Scripts/build-dumprendertree: Ditto.
6:03 AM Changeset in webkit [9347] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Get rid of unneeded this->.
6:03 AM Changeset in webkit [9346] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Another try at making the default build directory of ~/WebKitBuild work. Someone should try building without setting the Xcode build product directory now, and let me know if it works.

Jun 8, 2005:

11:14 PM Changeset in webkit [9345] by darin
  • 6 edits in trunk/WebKitTools
  • quick fix to try to get build scripts working again
  • Scripts/build-dumprendertree: Add FindBin.
  • Scripts/build-webkit: Ditto.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
10:43 PM Changeset in webkit [9344] by darin
  • 6 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.

  • some build script enhancements
  • Scripts/build-dumprendertree: Changed to use webkitdirs.
  • Scripts/build-webkit: Changed to use webkitdirs, also only copy files from WebKitLibraries if they are newer.
  • Scripts/run-safari: Reduce number of log messages, change to respect "-d" flag and get Development before Deplyment in that case.
  • Scripts/run-webkit-tests: Changed to use webkitdirs.
  • Scripts/update-webkit: Changed to use webkitdirs.
  • Scripts/webkitdirs.pm: Added.
2:55 AM Changeset in webkit [9343] by mjs
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Oops, i missed the project file changes too.

2:16 AM Changeset in webkit [9342]
  • 7 copies in tags/Safari-1-3-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-1-3-anchor'.

2:16 AM Changeset in webkit [9341] by mjs
  • 2 adds in trunk/WebCore/khtml/ecma

Add new files that I forgot to check in with the last change.

2:00 AM Changeset in webkit [9340] by mjs
  • 2 edits in trunk/WebKitTools

Code change by Toby Peterson <​toby@opendarwin.org>
Reviewed by me.

  • Scripts/run-safari: Fix to work with Xcode 2.0 again. The script would get confused because build-webkit now makes even 2.0 build directories look like 2.1.
1:39 AM Changeset in webkit [9339] by mjs
  • 3 edits
    4 adds in trunk

Reviewed and committed by Maciej.

<rdar://problem/3533735> implement Mozilla "DOMParser" extension for use with XMLHTTPRequest

Test cases added:

  • layout-tests/fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize-display.html: Added.
  • layout-tests/fast/dom/dom-parse-serialize-expected.txt: Added.
  • layout-tests/fast/dom/dom-parse-serialize.html: Added.
  • khtml/ecma/domparser.h:
  • khtml/ecma/domparser.cpp: Add files implementing the DOMParser object.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: Expose DOMParser object.
12:09 AM Changeset in webkit [9338] by mjs
  • 2 edits in trunk/JavaScriptCore

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>
Reviewed by me.

  • kjs/nodes.cpp: Include source file and line number when making exception in KJS_CHECKEXCEPTIONVALUE.

Jun 7, 2005:

5:41 PM Changeset in webkit [9337] by hyatt
  • 2 edits in trunk/WebCore

Patch from Brian Campbell. Make sure the min and max values of slider properly update.
Fixes bugilla bug 3323, internal Radar # is 4098892.

Reviewed by hyatt

Test cases added: (Not testable with a layout test)

  • kwq/KWQSlider.mm: (QSlider::setMinValue): (QSlider::setMaxValue):
5:27 PM Changeset in webkit [9336] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Adele Peterson.

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Added Deployment build style.
  • Scripts/build-dumprendertree: For now, always use Deployment build style. This may fix things so we can run tests with Xcode 2.1.
3:51 PM Changeset in webkit [9335]
  • 53 copies
    2 deletes in tags/WebCore-415~10

This commit was manufactured by cvs2svn to create tag
'WebCore-415~10'.

3:51 PM Changeset in webkit [9334] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.10

3:46 PM Changeset in webkit [9333] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, forgot to use Adele's married name.

3:45 PM Changeset in webkit [9332] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Adele Amchan.

  • Scripts/run-webkit-tests: Pass -L to find command to follow symlinks. This allows symlinks in the layout-tests directory to include additional sets of tests.
3:42 PM Changeset in webkit [9331] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4139800> from TOT to Safari-2-0-branch

2005-06-07 Adele Peterson <​adele@apple.com>

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:12 PM Changeset in webkit [9330] by adele
  • 2 edits in trunk/WebCore

Change by Darin, reviewed by Maciej and me.

  • fixed <rdar://problem/4139800> REGRESSION: Safari crashes at bebe.com

There were cases where the DOMNode mark function would end up not even
marking the node that it was called on. The old code tried to skip any
subtrees that were already marked, but that code was wrong.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): Changed three things: 1) Instead of a boolean, keep a set of trees that we are marking, that

prevents problems if we mark things that have references between
separate trees of DOM nodes.

2) Don't do the "outermost node with a wrapper" check, just start marking

at the root of the entire tree, because there's no way to have an
unreachable node pointing to a reachable node.

3) Handle the unusual case where the document's wrapper dictionary is

gone by marking just this node explicitly.

This passes the layout tests, still fixes the Dashboard memory leak from
bug 4125222, and makes bebe.com work again.

3:02 PM Changeset in webkit [9329] by darin
  • 5 edits in trunk/WebKitTools
  • checkout: Added license.
  • Scripts/build-dumprendertree: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
2:58 PM Changeset in webkit [9328] by darin
  • 3 edits in trunk/WebKitTools

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • Scripts/build-webkit: Changes so you can build with Xcode 2.1. (I also added a license to this file.)
  • Scripts/run-safari: Ditto.
2:48 PM Changeset in webkit [9327] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
11:34 AM Changeset in webkit [9326] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • JavaScriptCore.pbproj/project.pbxproj: Allow bison 2.0, which generates the file with a different name.
9:07 AM Changeset in webkit [9325] by darin
  • 2 edits in trunk/WebKit

Change by Mark Rowe <​opendarwin.org@bdash.net.nz>.
Reviewed by me.

  • WebKit.pbproj/project.pbxproj: Quote DERIVED_FILE_DIR when it is substituted into FRAMEWORK_SEARCH_PATHS, and SYMROOT when into HEADER_SEARCH_PATHS.
9:05 AM Changeset in webkit [9324] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fixed name in ChangeLog.

9:00 AM Changeset in webkit [9323] by darin
  • 2 edits in trunk/WebCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • WebCore.pbproj/project.pbxproj: Add quotes to make LIBRARY_SEARCH_PATHS work even when the path has a space in it.
8:55 AM Changeset in webkit [9322] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Toby Peterson <​toby@opendarwin.org>.
Reviewed by me.

  • kjs/grammar.y: Remove bogus extra line from grammar.y. Toby got this change from KDE KJS.
8:34 AM Changeset in webkit [9321] by hyatt
  • 2 edits in trunk/WebCore

Patch from Mark Rowe to fix a minor memory leak in WebCoreSettings.

Reviewed by hyatt

  • kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]):
Note: See TracTimeline for information about the timeline view.