Timeline



Jun 16, 2005:

7:13 PM Changeset in webkit [9405] by justing
  • 9 edits in trunk/WebCore

Added a few debugging methods to highlight Selections, VisiblePositions and Nodes in the DOM tree.

Reviewed by Dave Harrison

Test cases added: None, changes are only to aid debugging

  • khtml/editing/selection.cpp:

(khtml::Selection::showTree):

  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp:

(khtml::VisiblePosition::showTree):

  • khtml/editing/visible_position.h:
  • khtml/xml/dom_nodeimpl.cpp:

(NodeImpl::showNode):
(NodeImpl::showTree):
(NodeImpl::showTreeAndMark):

  • khtml/xml/dom_nodeimpl.h:
5:57 PM Changeset in webkit [9404] by ggaren
  • 5 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4151759> 'delete' fails on variables declared inside 'eval' statements.

Reviewed by cblu.

  • kjs/context.h: (KJS::ContextImp::codeType): Added code type accessor for execution context objects.
  • kjs/internal.cpp: (ContextImp::ContextImp): Reflects change to ContextImp::codeType.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Added separate code path for variable declarations inside 'eval' statements.
  • tests/mozilla/expected.html: Updated expected test results to reflect fix.
2:06 PM Changeset in webkit [9403] by hyatt
  • 2 edits in trunk/WebCore/khtml/xml

Fix build bustage

1:33 PM Changeset in webkit [9402] by hyatt
  • 2 edits in trunk/WebCore/khtml/html

Fix build bustage

12:42 PM Changeset in webkit [9401] by hyatt
  • 2 edits
    4 adds
    1 delete in trunk/WebCore

Add an initial implementation of QualifiedName and HTMLNames. These classes are not used by anyone yet.
Progress being recorded in bugzilla bug 3405.

Reviewed by mjs

Test cases added: (None, does not affect build yet)

  • WebCore.pbproj/project.pbxproj:
  • khtml/xml/dom_qname.h,.cpp
  • khtml/html/htmlnames.h,.cpp
9:45 AM Changeset in webkit [9400] by darin
  • 3 edits in trunk/WebKitTools
  • recent changes to XcodeOptions made it depend on the current directory The intent was to have the WebKitBuild directory be next to WebKitTools, not inside the various build directories. Workaround for now is to call XcodeOptions when the directory is set to the WebKit directory.
  • Scripts/build-dumprendertree: Use a local variable for XcodeOptions and get it at the start of the script.
  • Scripts/build-webkit: Ditto.

Jun 15, 2005:

8:41 PM Changeset in webkit [9399] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Recognize all 1.X versions of Xcode as old too, not just 2.0.

Jun 14, 2005:

3:50 PM Changeset in webkit [9398]
  • 27 copies
    2 deletes in tags/WebCore-315~6

This commit was manufactured by cvs2svn to create tag
'WebCore-315~6'.

3:50 PM Changeset in webkit [9397] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • versioning for WebCore-315.6
3:37 PM Changeset in webkit [9396] by hyatt
  • 288 edits
    2 adds in trunk

The behavior of <pre> is broken so that the newline
is not always properly being eaten after the open of the tag. In addition we were eating the first newline
after all other tags. This patch stops eating newlines after other tags and refines the behavior for pre
to catch all cases.

Reviewed by sullivan

Test cases added: fast/text/whitespace/030.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write):
11:45 AM Changeset in webkit [9395] by darin
  • 1 edit
    1 add in trunk/WebKitTools

Changes by Anders Carlsson.
Reviewed by me.

  • Scripts/gdb-safari: Added.
11:06 AM Changeset in webkit [9394] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • merged this fix from HEAD

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
11:06 AM Changeset in webkit [9393] by sullivan
  • 3 edits in trunk/WebKit

Changes by Devin Lane.
Reviewed by me.

  • fixed <rdar://problem/3766909> PDF viewing could use a zoom control other than the one in the context menu
  • WebView.subproj/WebPDFView.h: now implements protocol _web_WebDocumentTextSizing
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _updateScalingToReflectTextSize]): new method, sets the PDF scaling from the text size multiplier (-[WebPDFView setDataSource:]): call _updateScalingToReflectTextSize (-[WebPDFView _web_textSizeMultiplierChanged]): implementation of protocol _web_WebDocumentTextSizing, calls _updateScalingToReflectTextSize
10:59 AM Changeset in webkit [9392] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated expected.html to reflect fix to <rdar://problem/4147745>.

Reviewed by cblu.

  • tests/mozilla/expected.html:
10:36 AM Changeset in webkit [9391] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _delayedEndPrintMode:]): After discussing this with Dave, I made this method both more debugger-friendly with asserts for the cases we don't think could ever happen, and more paranoid by handling these cases in deployment builds.
9:36 AM Changeset in webkit [9390] by ggaren
  • 3 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4147745> JavaScript discards locally defined "arguments" property

No layout tests added because this change fixes existing tests:
ecma/ExecutionContexts/10.1.6.js
ecma_3/Function/regress-94506.js
js1_4/Functions/function-001.js

Reviewed by cblu.

  • kjs/function.cpp: (KJS::ActivationImp::get): get now checks for an "arguments" property defined in the local variable object before trying to return the built-in arguments array.
  • kjs/function.h: ActivationImp::put no longer overrides ObjectImp::put
9:19 AM Changeset in webkit [9389] by darin
  • 2 edits in trunk/WebKit
  • fixed build for Xcode 2.1
  • WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT to search for the WebKitSystemInterface.h file. We could re-jigger this again later, but for now this is consistent with both the .a file's location and where build-webkit puts the file.

Jun 13, 2005:

7:12 PM Changeset in webkit [9388] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison and Maciej.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _endPrintMode]): new method, extracted from identical code in beginDocument and endDocument. This method must be called once to counterbalance the code called from knowsPageRange that turns on "printing mode". (-[WebHTMLView _delayedEndPrintMode:]): new method, called from "perform after delay". Checks whether the same print operation is still underway and, if so, delays further. Otherwise calls _endPrintMode directly. (-[WebHTMLView knowsPageRange:]): after turning on "printing mode", queue up a delayed call to _delayedEndPrintMode:. If there's an early error in the print mechanism such that beginDocument is never called, this will cleanly end "printing mode" and make the webview usable again. (-[WebHTMLView beginDocument]): cancel any delayed call to _delayedEndPrintMode:. If we get this far along in printing, then we don't need the failsafe call to _delayedEndPrintMode: that was set up in knowsPageRange:. Also, call extracted method. (-[WebHTMLView endDocument]): call extracted method
6:31 PM Changeset in webkit [9387]
  • 55 copies
    2 deletes in tags/WebCore-415~11

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11'.

6:31 PM Changeset in webkit [9386]
  • 77 copies in branches/Safari-Cam-branch

This commit was manufactured by cvs2svn to create branch
'Safari-Cam-branch'.

6:31 PM Changeset in webkit [9385]
  • 77 copies in tags/Safari-Cam-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-Cam-anchor'.

6:31 PM Changeset in webkit [9384] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11

6:28 PM Changeset in webkit [9383]
  • 14 copies
    3 deletes in tags/WebKit-412~6

This commit was manufactured by cvs2svn to create tag 'WebKit-412~6'.

6:28 PM Changeset in webkit [9382] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6

6:27 PM Changeset in webkit [9381] by adele
  • 8 edits in branches/Safari-2-0-branch

WebCore:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).

WebKit:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:29 PM Changeset in webkit [9380] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
5:25 PM Changeset in webkit [9379] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:23 PM Changeset in webkit [9378] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).
5:08 PM Changeset in webkit [9377] by cpeterse
  • 3 edits in trunk/WebKit

Changes by Darin.
Reviewed by me.

  • fixed problems building deployment due to recent init change
  • WebView.subproj/WebArchive.m: (-[WebArchive initWithCoder:]): Put the [super init] call and check for nil outside the exception handler.
  • WebView.subproj/WebResource.m: (-[WebResource initWithCoder:]): Ditto.
8:33 AM Changeset in webkit [9376] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebImageData.m: Got rid of use of tabs instead of spaces throughout the file. (-[WebImageData _checkSolidColor:]): Wrap use of NSGraphicsContext with an autorelease pool. (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): Ditto. (-[WebImageData tileInRect:fromPoint:context:]): Ditto. (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]): Ditto.
12:27 AM Changeset in webkit [9375] by mjs
  • 2 edits in trunk/WebCore

Patch from Andrew Wellington <​proton@wiretapped.net>
Reviewed by me.

No test cases addded since the repro steps require use of tabbed browsing.

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): check for nil

Jun 12, 2005:

8:28 PM Changeset in webkit [9374] by darin
  • 13 edits in trunk/WebKit

Changes by Nick Zitzmann.
Reviewed by me.

  • fixed init methods that don't handle return values from the init methods they call
  • WebView.subproj/WebArchive.m: (-[WebArchive init]): Use value returned by init, check it for nil too. (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Ditto. (-[WebArchive _initWithPropertyList:]): Ditto. (-[WebArchive initWithCoder:]): Ditto.
  • WebView.subproj/WebClipView.m: (-[WebClipView initWithFrame:]): Ditto.
  • WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithName:value:source:children:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFormState initWithForm:values:sourceFrame:]): Ditto. (-[WebFrame initWithName:webFrameView:webView:]): Ditto.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): Ditto.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Ditto.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Ditto. (-[WebTextCompleteController initWithHTMLView:]): Ditto.
  • WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): Ditto.
  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Ditto.
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): Ditto.
  • WebView.subproj/WebResource.m: (-[WebResource init]): Ditto. (-[WebResource initWithCoder:]): Ditto.
  • WebView.subproj/WebView.m: (-[WebViewPrivate init]): Call super init. (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): Use value returned by init, check it for nil too. (-[WebView initWithFrame:]): Ditto.
8:26 PM Changeset in webkit [9373] by darin
  • 7 edits in trunk/WebKitTools

Changes by Stuart Morgan.
Reviewed by me.

  • Scripts/cvs-abandon: Use cwd instead of pwd.
  • Scripts/cvs-apply: Ditto.
  • Scripts/cvs-create-patch: Ditto.
  • Scripts/cvs-unapply: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/webkitdirs.pm: Ditto. Also improve handling when there's no "Configuration" file.
8:12 PM Changeset in webkit [9372] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Handle case of an empty patch better.
  • Scripts/cvs-unapply: Ditto.
7:45 PM Changeset in webkit [9371] by darin
  • 2 edits in trunk/WebKitTools

Changes by Michael Gaiman.
Reviewed by me.

  • Scripts/webkitdirs.pm: Chomp off the result of pwd, and don't die when no Configuration file.
5:55 PM Changeset in webkit [9370] by darin
  • 1 edit
    3 adds in trunk
  • added expected test results for new tests
  • layout-tests/fast/selectors/159-expected.txt: Added.
  • layout-tests/fast/selectors/177a-expected.txt: Added.
  • layout-tests/fast/selectors/177b-expected.txt: Added.
5:40 PM Changeset in webkit [9369]
  • 13 copies
    3 deletes in tags/WebKit-412~5

This commit was manufactured by cvs2svn to create tag 'WebKit-412~5'.

5:40 PM Changeset in webkit [9368] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.5

5:10 PM Changeset in webkit [9367] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/update-webkit: Make this script work when called from any directory.
3:48 PM Changeset in webkit [9366] by darin
  • 7 edits
    1 add in trunk/WebKitTools

Reviewed by Maciej.
Includes changes by Stuart Morgan as well as my own.

  • Scripts/build-dumprendertree: Call the new setConfiguration function, and use XcodeOptions instead of symrootXcodeOptions to set the -buildstyle option.
  • Scripts/build-webkit: Ditto. Also remove the old way of supporting Xcode 2.1 and the old --debug option. The new --development option does the same thing.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/update-webkit: Ditto.
  • Scripts/set-webkit-configuration: Added. Sets the default configuration to Development or Deployment.
  • Scripts/webkitdirs.pm: use FindBin to find the WebKit directory; works no matter what the current directory is when invoking a script. Add code to determine the Xcode version so we can do the right thing for 2.0 and 2.1. Change the productDir function to return the appropriate per-configuration product directory. Read the default configuration from a file, overridable by a passed-in command-line option.
2:06 PM Changeset in webkit [9365] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.
1:27 PM Changeset in webkit [9364] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.
Note: See TracTimeline for information about the timeline view.