Timeline



Jun 17, 2005:

4:02 PM Changeset in webkit [9421] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test cases added: None, since this test requires manual interaction.

  • fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements do not resize when options are added via javascript
  • khtml/rendering/render_form.cpp: (RenderSelect::layout): remove call setting setNeedsLayout to true. setNeedsLayout is already true at this point, and this addtional call has the negative effect of marking m_normalChildNeedsLayout on the element's parent, which keeps layout from propagating all the way up to the root later on.
2:55 PM Changeset in webkit [9420] by justing
  • 3 edits
    2 adds in trunk

Bug #:
Submitted by:
Reviewed by:

2:51 PM Changeset in webkit [9419]
  • 53 copies in tags/Safari-412~0~1

This commit was manufactured by cvs2svn to create tag
'Safari-412~0~1'.

2:51 PM Changeset in webkit [9418] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/JavaScriptCore

Versioning for GCC 4 - Safari-412.0.1

2:41 PM Changeset in webkit [9417] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebKit

Versioning for GCC 4 - Safari-412.0.1

2:29 PM Changeset in webkit [9416] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebCore

Versioning for GCC 4 - Safari-412.0.1

2:20 PM Changeset in webkit [9415] by cpeterse
  • 2 edits in branches/gcc-4-0-branch/WebCore

Rolled in changes to compile with gcc 4.0 from TOT.

2005-05-16 Darin Adler <Darin Adler>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
  • khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
  • khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
  • khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
  • khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
  • khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
  • khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
  • khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
  • khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
  • kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

2005-04-28 Darin Adler <Darin Adler>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
  • khtml/css/parser.cpp: Regenerated.
  • khtml/css/parser.h: Regenerated.
  • khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
  • kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
  • kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
  • kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
  • kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • WebCore-combined.exp: Regenerated.
  • WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.
1:00 PM Changeset in webkit [9414] by adele
  • 2 edits
    7 adds in trunk

Reviewed by Maciej.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): set 'script' flag when parsing <script src="foo" /> case. In this case, parseTag calls the scriptHandler function which expects that flag to be set, and sets it back to false at the appropriate time.

Test cases added: These still don't test the cached script cases, but they're good regression
tests for the tokenizer. We'll have to come up with a good way to test the cached cases later.

  • layout-tests/fast/tokenizer/external-script-document-write_2-expected.txt: Added.
  • layout-tests/fast/tokenizer/external-script-document-write_2.html: Added.
  • layout-tests/fast/tokenizer/resources/empty_script.js: Added.
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt: Added.
  • layout-tests/fast/tokenizer/script_extra_close.html: Added.
  • layout-tests/fast/tokenizer/script_quirk-expected.txt: Added.
  • layout-tests/fast/tokenizer/script_quirk.html: Added.
11:50 AM Changeset in webkit [9413] by justing
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:42 AM Changeset in webkit [9412] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Patch contributed by Anders Carlsson<​andersca@mac.com>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

  • khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
  • khtml/html/html_formimpl.h: Ditto.
11:14 AM Changeset in webkit [9411]
  • 1 copy
    1 delete in tags/Safari-2-0-anchor-1P

This commit was manufactured by cvs2svn to create tag
'Safari-2-0-anchor-1P'.

11:14 AM Changeset in webkit [9410] by ggaren
  • 3 edits in trunk/WebCore

Patch contributed by Joos de Valk <​webkit@joostdevalk.nl>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

  • khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
  • khtml/html/html_formimpl.h: Ditto.
10:09 AM Changeset in webkit [9409] by rjw
  • 2 edits in trunk/WebKit

Bug #:
Submitted by:
Reviewed by:

Changes by Mitz Pettel
Reviewed by Richard Williamson.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3545

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
9:41 AM Changeset in webkit [9408] by darin
  • 2 edits
    2 adds in trunk

Reviewed by John.

Test cases added:

  • layout-tests/fast/encoding/invalid-UTF-8-expected.txt: Added.
  • layout-tests/fast/encoding/invalid-UTF-8.html: Added.
  • kwq/KWQTextCodec.mm: (unwanted): Added. Returns true for BOM, replacement, and null characters. (KWQTextDecoder::appendOmittingUnwanted): Renamed from appendOmittingNullsAndBOMs and changed to use the new "unwanted" function, which causes it to omit replacement characters. (KWQTextDecoder::convertUsingTEC): Call append function by its new name.
8:06 AM Changeset in webkit [9407] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed <rdar://problem/4151001> Reloading javascript-spawned window with no URL erases its contents
  • WebView.subproj/WebFrame.m: (-[WebFrame reload]): do nothing if URL is zero-length
12:49 AM Changeset in webkit [9406] by mjs
  • 1 edit
    1 add in trunk/WebKitTools
  • added prepare-ChangeLog script which we use internally to make ChangeLogs, for benefit of all WebKit hackerdom
  • Scripts/prepare-ChangeLog: Added.

Jun 16, 2005:

7:13 PM Changeset in webkit [9405] by justing
  • 9 edits in trunk/WebCore

Added a few debugging methods to highlight Selections, VisiblePositions and Nodes in the DOM tree.

Reviewed by Dave Harrison

Test cases added: None, changes are only to aid debugging

  • khtml/editing/selection.cpp:

(khtml::Selection::showTree):

  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp:

(khtml::VisiblePosition::showTree):

  • khtml/editing/visible_position.h:
  • khtml/xml/dom_nodeimpl.cpp:

(NodeImpl::showNode):
(NodeImpl::showTree):
(NodeImpl::showTreeAndMark):

  • khtml/xml/dom_nodeimpl.h:
5:57 PM Changeset in webkit [9404] by ggaren
  • 5 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4151759> 'delete' fails on variables declared inside 'eval' statements.

Reviewed by cblu.

  • kjs/context.h: (KJS::ContextImp::codeType): Added code type accessor for execution context objects.
  • kjs/internal.cpp: (ContextImp::ContextImp): Reflects change to ContextImp::codeType.
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Added separate code path for variable declarations inside 'eval' statements.
  • tests/mozilla/expected.html: Updated expected test results to reflect fix.
2:06 PM Changeset in webkit [9403] by hyatt
  • 2 edits in trunk/WebCore/khtml/xml

Fix build bustage

1:33 PM Changeset in webkit [9402] by hyatt
  • 2 edits in trunk/WebCore/khtml/html

Fix build bustage

12:42 PM Changeset in webkit [9401] by hyatt
  • 2 edits
    4 adds
    1 delete in trunk/WebCore

Add an initial implementation of QualifiedName and HTMLNames. These classes are not used by anyone yet.
Progress being recorded in bugzilla bug 3405.

Reviewed by mjs

Test cases added: (None, does not affect build yet)

  • WebCore.pbproj/project.pbxproj:
  • khtml/xml/dom_qname.h,.cpp
  • khtml/html/htmlnames.h,.cpp
9:45 AM Changeset in webkit [9400] by darin
  • 3 edits in trunk/WebKitTools
  • recent changes to XcodeOptions made it depend on the current directory The intent was to have the WebKitBuild directory be next to WebKitTools, not inside the various build directories. Workaround for now is to call XcodeOptions when the directory is set to the WebKit directory.
  • Scripts/build-dumprendertree: Use a local variable for XcodeOptions and get it at the start of the script.
  • Scripts/build-webkit: Ditto.

Jun 15, 2005:

8:41 PM Changeset in webkit [9399] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Recognize all 1.X versions of Xcode as old too, not just 2.0.

Jun 14, 2005:

3:50 PM Changeset in webkit [9398]
  • 27 copies
    2 deletes in tags/WebCore-315~6

This commit was manufactured by cvs2svn to create tag
'WebCore-315~6'.

3:50 PM Changeset in webkit [9397] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • versioning for WebCore-315.6
3:37 PM Changeset in webkit [9396] by hyatt
  • 288 edits
    2 adds in trunk

The behavior of <pre> is broken so that the newline
is not always properly being eaten after the open of the tag. In addition we were eating the first newline
after all other tags. This patch stops eating newlines after other tags and refines the behavior for pre
to catch all cases.

Reviewed by sullivan

Test cases added: fast/text/whitespace/030.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write):
11:45 AM Changeset in webkit [9395] by darin
  • 1 edit
    1 add in trunk/WebKitTools

Changes by Anders Carlsson.
Reviewed by me.

  • Scripts/gdb-safari: Added.
11:06 AM Changeset in webkit [9394] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore
  • merged this fix from HEAD

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
11:06 AM Changeset in webkit [9393] by sullivan
  • 3 edits in trunk/WebKit

Changes by Devin Lane.
Reviewed by me.

  • fixed <rdar://problem/3766909> PDF viewing could use a zoom control other than the one in the context menu
  • WebView.subproj/WebPDFView.h: now implements protocol _web_WebDocumentTextSizing
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _updateScalingToReflectTextSize]): new method, sets the PDF scaling from the text size multiplier (-[WebPDFView setDataSource:]): call _updateScalingToReflectTextSize (-[WebPDFView _web_textSizeMultiplierChanged]): implementation of protocol _web_WebDocumentTextSizing, calls _updateScalingToReflectTextSize
10:59 AM Changeset in webkit [9392] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated expected.html to reflect fix to <rdar://problem/4147745>.

Reviewed by cblu.

  • tests/mozilla/expected.html:
10:36 AM Changeset in webkit [9391] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _delayedEndPrintMode:]): After discussing this with Dave, I made this method both more debugger-friendly with asserts for the cases we don't think could ever happen, and more paranoid by handling these cases in deployment builds.
9:36 AM Changeset in webkit [9390] by ggaren
  • 3 edits in trunk/JavaScriptCore

Fixed: <rdar://problem/4147745> JavaScript discards locally defined "arguments" property

No layout tests added because this change fixes existing tests:
ecma/ExecutionContexts/10.1.6.js
ecma_3/Function/regress-94506.js
js1_4/Functions/function-001.js

Reviewed by cblu.

  • kjs/function.cpp: (KJS::ActivationImp::get): get now checks for an "arguments" property defined in the local variable object before trying to return the built-in arguments array.
  • kjs/function.h: ActivationImp::put no longer overrides ObjectImp::put
9:19 AM Changeset in webkit [9389] by darin
  • 2 edits in trunk/WebKit
  • fixed build for Xcode 2.1
  • WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT to search for the WebKitSystemInterface.h file. We could re-jigger this again later, but for now this is consistent with both the .a file's location and where build-webkit puts the file.

Jun 13, 2005:

7:12 PM Changeset in webkit [9388] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison and Maciej.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _endPrintMode]): new method, extracted from identical code in beginDocument and endDocument. This method must be called once to counterbalance the code called from knowsPageRange that turns on "printing mode". (-[WebHTMLView _delayedEndPrintMode:]): new method, called from "perform after delay". Checks whether the same print operation is still underway and, if so, delays further. Otherwise calls _endPrintMode directly. (-[WebHTMLView knowsPageRange:]): after turning on "printing mode", queue up a delayed call to _delayedEndPrintMode:. If there's an early error in the print mechanism such that beginDocument is never called, this will cleanly end "printing mode" and make the webview usable again. (-[WebHTMLView beginDocument]): cancel any delayed call to _delayedEndPrintMode:. If we get this far along in printing, then we don't need the failsafe call to _delayedEndPrintMode: that was set up in knowsPageRange:. Also, call extracted method. (-[WebHTMLView endDocument]): call extracted method
6:31 PM Changeset in webkit [9387]
  • 55 copies
    2 deletes in tags/WebCore-415~11

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11'.

6:31 PM Changeset in webkit [9386]
  • 77 copies in branches/Safari-Cam-branch

This commit was manufactured by cvs2svn to create branch
'Safari-Cam-branch'.

6:31 PM Changeset in webkit [9385]
  • 77 copies in tags/Safari-Cam-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-Cam-anchor'.

6:31 PM Changeset in webkit [9384] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11

6:28 PM Changeset in webkit [9383]
  • 14 copies
    3 deletes in tags/WebKit-412~6

This commit was manufactured by cvs2svn to create tag 'WebKit-412~6'.

6:28 PM Changeset in webkit [9382] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6

6:27 PM Changeset in webkit [9381] by adele
  • 8 edits in branches/Safari-2-0-branch

WebCore:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).

WebKit:

Merged new fix for <rdar://problem/4142247> from TOT to Safari-2-0-branch.

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:29 PM Changeset in webkit [9380] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
5:25 PM Changeset in webkit [9379] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto
5:23 PM Changeset in webkit [9378] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Chris Blumenberg and Adele.

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).
5:08 PM Changeset in webkit [9377] by cpeterse
  • 3 edits in trunk/WebKit

Changes by Darin.
Reviewed by me.

  • fixed problems building deployment due to recent init change
  • WebView.subproj/WebArchive.m: (-[WebArchive initWithCoder:]): Put the [super init] call and check for nil outside the exception handler.
  • WebView.subproj/WebResource.m: (-[WebResource initWithCoder:]): Ditto.
8:33 AM Changeset in webkit [9376] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebImageData.m: Got rid of use of tabs instead of spaces throughout the file. (-[WebImageData _checkSolidColor:]): Wrap use of NSGraphicsContext with an autorelease pool. (-[WebImageData _fillSolidColorInRect:compositeOperation:context:]): Ditto. (-[WebImageData tileInRect:fromPoint:context:]): Ditto. (-[WebImageData _PDFDrawFromRect:toRect:operation:alpha:flipped:context:]): Ditto.
12:27 AM Changeset in webkit [9375] by mjs
  • 2 edits in trunk/WebCore

Patch from Andrew Wellington <​proton@wiretapped.net>
Reviewed by me.

No test cases addded since the repro steps require use of tabbed browsing.

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): check for nil
Note: See TracTimeline for information about the timeline view.