Timeline



Jun 22, 2005:

8:15 PM Changeset in webkit [9472] by darin
  • 2 edits
    4 adds in trunk/WebCore
  • ForwardingHeaders/kjs/value.h: Added.
  • ForwardingHeaders/qintdict.h: Added an include.
  • ForwardingHeaders/qptrcollection.h: Added.
  • ForwardingHeaders/qsize.h: Added.
  • kwq/KWQIntDict.h: Added. Empty file.
2:32 PM Changeset in webkit [9471] by sullivan
  • 9 edits
    1 add in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/3764645> please add a way to allow WebKit clients to override the WebPDFView context menu
  • PublicHeaderChangesFromTiger.txt: Added. New file to keep track of changes made to public headers that haven't been through API review yet. Initially lists the WebMenuItem enum tags added to WebUIDelegate.h as part of this change.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate appendDefaultItems:toArray:]): new method, handles initial separator (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): now has defaultMenuItems: parameter. Any menu items in this array are appended at the end of the standard set. (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): This had a defaultMenuItems parameter before but it was always nil. Now it passes the defaultMenuItems parameter on to the two methods that construct lists (one for editing, the other for viewing). Also tweaked variable name and type for clarity.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): passes nil for new defaultItems parameter of _menuForElement:
  • WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): ditto
  • WebView.subproj/WebPDFView.m: (-[WebPDFView elementAtPoint:]): new method to create the element dictionary needed for _menuForElement:defaultItems:. Only supplies the webFrame at this point. (-[WebPDFView _menuItemsFromPDFKitForEvent:]): new method to return copies of the menu items that PDFKit would include in the context menu, with WebKit tags applied (-[WebPDFView menuForEvent:]): now calls standard WebKit context menu mechanism, so clients' delegates can modify the context menu as desired. The initial set of items are the ones WebKit was already displaying for PDF context menus.
  • WebView.subproj/WebUIDelegate.h: added enum values for the menu items in the PDF context menu
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]): Added the defaultItems: parameter to this method, which is then passed along to WebDefaultUIDelegate. All callers pass nil except for WebPDFView, at least for now.
2:05 PM Changeset in webkit [9470] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Vicki.

Test cases added:

  • layout-tests/fast/css/apple-prefix-expected.txt: Added.
  • layout-tests/fast/css/apple-prefix.html: Added.
  • fixed <rdar://problem/4141650> REGRESSION: Safari RSS slider broken with TOT WebCore
  • khtml/css/parser.y: (getPropertyID): Fix lifetime problem on the QString. Also construct the QString using length, since the passed-in char * is not necessarily null-terminated. Also do the mapping only if it's a "-apple-" prefix -- the old code would do it for, e.g., "-applex-" too. The old code would not successfully map the "apple" in "appleLineClamp" to "khtml", and Dave changed things so that the internal name of all CSS attributes is "khtml" back in his 2005-05-03 check-in, breaking the use of appleLineClamp in RSS. (getValueID): Ditto.
11:37 AM Changeset in webkit [9469]
  • 35 copies
    2 deletes in tags/WebCore-413~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~1'.

11:37 AM Changeset in webkit [9468] by adele
  • 2 edits in branches/gcc-4-0-branch/WebCore

Fix versioning for gcc-4-0-branch - WebCore-413.0.1

11:23 AM Changeset in webkit [9467] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added more bug numbers to the change log.

11:22 AM Changeset in webkit [9466] by darin
  • 5 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/dom/title-text-property-expected.txt: Added
  • layout-tests/fast/dom/title-text-property.html: Added
  • layout-tests/fast/dom/title-text-property-expected-2.txt: Added
  • layout-tests/fast/dom/title-text-property-2.html: Added

Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3586>
Setting and getting title's text attribute does not work

  • khtml/dom/html_head.cpp: (HTMLTitleElement::text): (HTMLTitleElement::setText): Call HTMLTitleElementImpl::text() and ::setText().
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::HTMLTitleElementImpl): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::removedFromDocument): (HTMLTitleElementImpl::childrenChanged): Pass the current title node to DocumentImpl::setTitle and ::removeTitle.

(HTMLTitleElementImpl::text):
Return the title.

(HTMLTitleElementImpl::setText):
Set the new title.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::setTitle): (DocumentImpl::removeTitle):
  • khtml/xml/dom_docimpl.h: Only update the title if it's done by setting document.title or by changing the child nodes of the title element.
11:01 AM Changeset in webkit [9465] by darin
  • 2 edits in trunk/WebKitTools

Change by Anders Carlsson.

  • added support for dumping title changes
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didReceiveTitle:forFrame:]): Added. Dump title change if requested by JavaScript. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added dumpTitleChanges. (-[LayoutTestController dumpTitleChanges]): Added, sets flag. (dumpRenderTree): Start flag as NO.
10:39 AM Changeset in webkit [9464] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-L2-run-reordering-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-L2-run-reordering.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Fixed mistake where we'd advance too far after reversing a run.
10:29 AM Changeset in webkit [9463] by darin
  • 1 edit
    2 adds in trunk
  • layout-tests/fast/js/string-replace-2-expected.txt: Added.
  • layout-tests/fast/js/string-replace-2.html: Added.
10:26 AM Changeset in webkit [9462] by darin
  • 4 edits in trunk/JavaScriptCore

Change by Anders Carlsson.
Reviewed by me.

  • kjs/string_object.cpp: (replace): Added code to handle functions.
  • tests/mozilla/expected.html: Updated since ecma_3/RegExp/regress-209067.js is fixed now.
  • tests/mozilla/run-mozilla-tests: Fix a minor coding style issue that leads to a warning each time we run the tests.
9:44 AM Changeset in webkit [9461] by darin
  • 2 edits in trunk/WebKit

Change by Mitz Pettel.
Reviewed by me.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]): Fix off-by-one mistake in order-swapping loops.
9:38 AM Changeset in webkit [9460] by darin
  • 3 edits
    2 adds in trunk

Reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/dom/css-set-property-exception-expected.txt: Added.
  • layout-tests/fast/dom/css-set-property-exception.html: Added.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::tryPut): Ignore exceptions when setting properties.
  • layout-tests/fast/js/exception-linenums.html: Changed test case that involved setting style to one that involved setting another property that raises an exception when you try to set it (setting prefix on a text node).
9:20 AM Changeset in webkit [9459] by darin
  • 3 edits in trunk/WebKit

Change by Michael Gaiman.
Reviewed by me.

  • Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _webkit_parseRFC822HeaderFields]): Fixed method name.
8:31 AM Changeset in webkit [9458] by darin
  • 2 edits in trunk/WebCore

Change proposed by Eric Seidel.

  • WebCore.pbproj/project.pbxproj: Fix build rule to match the one in JavaScriptCore. The one here accidentally had hard-coded paths in it and also had the $() vs. ${} issue that broke building on Xcode 2.1 for no good reason (it didn't need $() or ${}).

Jun 21, 2005:

9:38 PM Changeset in webkit [9457] by mjs
  • 2 edits in trunk/WebCore

Patch from KevinBallard <Lily Ballard>, reviewed by me.

  • fix build for Xcode 2.1, use ${} for INPUT_FILE_BASE to fix build with Xcode 2.1
  • WebCore.pbproj/project.pbxproj:
6:15 PM Changeset in webkit [9456] by justing
  • 2 edits in trunk/WebCore
  • Fixes <rdar://problem/4114192>.
  • Fixes a crash in TOT Mail/Blot if you Edit -> Add Hyperlink on a Selection

that ends at the end of the document

  • Fixes a problem in TOT Mail/Blot where Edit -> Add Hyperlink creates

a link one character beyond what is expected.

In replacement, during insertion, some special case code was being called inappropriately.

Reviewed by Harrison

Test cases added: None, requires manual interaction

  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): In "step 2" of a replacement, we should only next() the insertion point if the special pre-insertion-merge actually occured. mergeStart used to be the correct check for the occurence of a pre-insertion-merge, but a bug fix made this not the case. A non-null m_lastNodeInserted correctly signals that some pre-insertion merging occured.
5:48 PM Changeset in webkit [9455] by adele
  • 28 edits
    4 deletes in trunk

JavaScriptCore:

rolling out fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress

  • ChangeLog:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasProperty): (KJS::ActivationImp::hasProperty):
  • kjs/function.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty):
  • kjs/object.h:
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasProperty):
  • kjs/string_object.h:
  • tests/mozilla/expected.html:

WebCore:

rolling out fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress

  • ChangeLog:
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasProperty): (KJS::DOMNamedNodeMap::hasProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLCollection::hasProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasProperty): (KJS::Konqueror::hasProperty):
  • khtml/ecma/kjs_window.h:
  • layout-tests/fast/js/eval-var-decl-expected.txt: Removed. This test used hasOwnProperty
  • layout-tests/fast/js/eval-var-decl.html: Removed. This test used hasOwnProperty
  • layout-tests/fast/js/hasOwnProperty-expected.txt: Removed.
  • layout-tests/fast/js/hasOwnProperty.html: Removed.
5:23 PM Changeset in webkit [9454] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • WebCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for the .y files -- this gets rid of the problem where modifying the .y file would not cause sufficient compilation.
  • khtml/css/parser_wrapper.cpp: Removed.
5:22 PM Changeset in webkit [9453] by darin
  • 2 edits
    1 delete in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for .y files -- this gets rid of the problem where modifying the .y file would not cause sufficient compilation.
  • kjs/grammar_wrapper.cpp: Removed.
4:02 PM Changeset in webkit [9452] by adele
  • 2 edits in trunk/JavaScriptCore

Patch from Anders Carlsson <​andersca@mac.com>, reviewed by Darin.

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

  • pcre/pcre.c: (pcre_compile): Remember the last char length so it can be subtracted correctly if needed.
4:02 PM Changeset in webkit [9451] by adele
  • 1 edit
    2 adds in trunk

Test cases for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

  • layout-tests/fast/js/string_replace-expected.txt: Added.
  • layout-tests/fast/js/string_replace.html: Added.
3:27 PM Changeset in webkit [9450] by ggaren
  • 7 edits
    4 adds in trunk

Patch contributed by Niels Leenheer <​niels.leenheer@gmail.com>

Reviewed by Darin.

  • khtml/dom/dom_string.cpp: (DOM::DOMString::toCoordsArray):
  • khtml/dom/dom_string.h:
  • khtml/html/html_imageimpl.cpp: (HTMLAreaElementImpl::parseMappedAttribute):
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::toCoordsArray):
  • khtml/xml/dom_stringimpl.cpp: (DOM::parseLength): (DOM::DOMStringImpl::toCoordsArray): (DOM::DOMStringImpl::toLengthArray):
  • khtml/xml/dom_stringimpl.h:

Test cases added:

  • layout-tests/fast/frames/invalid-expected.txt: Added.
  • layout-tests/fast/frames/invalid.html: Added.
  • layout-tests/fast/frames/valid-expected.txt: Added.
  • layout-tests/fast/frames/valid.html: Added.
11:44 AM Changeset in webkit [9449] by ggaren
  • 1 edit
    2 adds in trunk
  • fixed <rdar://problem/4155049> javascript function named as "opener" doesn't get called because of window.opener property

Test cases only, fix is in JavaScriptCore

Reviewed by cblu.

Test cases added:

  • layout-tests/fast/js/global-opener-function-expected.txt: Added.
  • layout-tests/fast/js/global-opener-function.html: Added.
11:42 AM Changeset in webkit [9448] by ggaren
  • 3 edits in trunk/JavaScriptCore
  • fixed <rdar://problem/4155532> 'delete' succeeds on functions
  • fixed <rdar://problem/4155049> javascript function named as "opener" doesn't get called because of window.opener property

Reviewed by cblu.

  • kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Functions now have DontDelete and Internal attributes set when appropriate.

Test cases:

  • tests/mozilla/expected.html: Updated for one new success.
  • see also test case added in WebCore.
11:11 AM Changeset in webkit [9447] by harrison
  • 7 edits in trunk/WebCore

Reviewed by Justin.

  • show class and style attributes for element nodes
  • nil check the node being showTree'd
  • add Position::showTree()

Test cases added: None needed for this debug-only utility code.

  • khtml/editing/selection.cpp: (khtml::Selection::showTree):
  • nil check the node
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition):
  • comments (khtml::VisiblePosition::showTree):
  • nil check the node
  • khtml/xml/dom_nodeimpl.cpp: (appendAttributeDesc): (NodeImpl::showNode):
  • show class and style attributes for element nodes
  • khtml/xml/dom_position.cpp: (DOM::Position::showTree):
  • khtml/xml/dom_position.h:
  • add Position::showTree()
11:05 AM Changeset in webkit [9446] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley

  • fixed assertion failure Vicki ran into
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _forgetIconForIconURLString:]): Handle the case where there are no associated page URLs for the icon URL
1:25 AM Changeset in webkit [9445] by mjs
  • 8 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin(first pass) and Hyatt.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3576 (roll in support for "const" keyword from KDE tree)
  • make processVarDecls handle deletability of variables declared in an eval block the same as evaluate would
  • make eval() call processVarDecls - needed to match mozilla and to make the second change testable

I started with the KDE implementation of const but I ended up changing it a bit
to avoid the use of a global variable. Now instead of the global variable it distinguishes
const and var at the grammar level so the appropriate node can know the right kind of
declaration.

Test cases:

  • tests/mozilla/expected.html: Updated for one new test that is failing - we used to bail on it entirely because it checks for const support before starting.
  • see also test cases added in WebCore
  • kjs/grammar.y: Add rules for const declarations.
  • kjs/keywords.table: Add const keyword.
  • kjs/nodes.cpp: (VarDeclNode::VarDeclNode): Add parameter. (VarDeclNode::evaluate): Add const support. (VarDeclNode::processVarDecls): Add const support. (VarStatementNode::execute): Irrelevant change. (ForInNode::ForInNode): Tell our variable node that it's a variable.
  • kjs/nodes.h: (KJS::VarDeclNode::): Add declaration of type enum, extra constructor parameter. (KJS::VarStatementNode::VarStatementNode): Irrelevant change.
  • kjs/function.cpp: (KJS::GlobalFuncImp::call): Process var decls before evaluating.

WebCore:

Reviewed by Darin(first pass) and Hyatt.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3576 (roll in support for "const" keyword from KDE tree)
  • make processVarDecls handle deletability of variables declared in an eval block the same as evaluate would
  • make eval() call processVarDecls - needed to match mozilla and to make the second change testable

Test cases only, fix is in JavaScriptCore

Test cases added:

  • layout-tests/fast/js/const-expected.txt: Added.
  • layout-tests/fast/js/const.html: Added.
  • layout-tests/fast/js/eval-var-decl-expected.txt: Added.
  • layout-tests/fast/js/eval-var-decl.html: Added.

Jun 20, 2005:

5:08 PM Changeset in webkit [9444] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4155182> icon database retain counts can be incorrect after removing all icons

Replaced the concept of "future retain count per page URL" with a simpler concept of "retain count per
page URL", which is maintained even after the icon is actually loaded (unlike the future retain count).
The total retain count for an icon is now the sum of the retain counts per page URL along with any retain
count not associated with a page URL -- this is still needed for some internal housekeeping purposes.

  • Misc.subproj/WebIconDatabasePrivate.h: renamed iconURLToURLs -> iconURLToPageURLs for clarity renamed URLToIconURL -> pageURLToIconURL for clarity renamed futureURLToRetainCount -> pageURLToRetainCount (there's no more "future" aspect) renamed iconURLToRetainCount -> iconURLToExtraRetainCount (it now maintains only some of the retain count)
  • Misc.subproj/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): updated for name changes only (-[WebIconDatabase init]): ditto (-[WebIconDatabase iconForURL:withSize:cache:]): ditto (-[WebIconDatabase iconURLForURL:]): ditto (-[WebIconDatabase retainIconForURL:]): just bump the retain count in pageURLToRetainCount, instead of behaving differently based on whether an icon had been loaded for this URL; this let me delete the internal method _retainFutureIconForURL: (-[WebIconDatabase releaseIconForURL:]): decrement the retain count in pageURLToRetainCount, then handle the case where the retain count for this page has gone to zero. I deleted the internal method _releaseFutureIconForURL: formerly called here. (-[WebIconDatabase removeAllIcons]): remove all the code that dealt with retain counts; this operation no longer affects retain counts (-[WebIconDatabase _setIconURL:forURL:]): remove the code that consolidated multiple retain counts for different page URLs into a single retain count; the multiple retain counts are now maintained even after the icon is loaded (-[WebIconDatabase _clearDictionaries]): updated for name changes only (-[WebIconDatabase _loadIconDictionaries]): ditto (-[WebIconDatabase _updateFileDatabase]): ditto (-[WebIconDatabase _totalRetainCountForIconURLString:]): new method, sums the retain counts associated with specific page URLs and the extra retain count not associated with specific page URLs (-[WebIconDatabase _retainIconForIconURLString:]): updated for name changes (-[WebIconDatabase _forgetIconForIconURLString:]): no longer affects retain counts at all; this is up to callers (-[WebIconDatabase _releaseIconForIconURLString:]): this now distinguishes the case where the retain count not associated with any page URLs hits zero from the case where the total retain count hits zero, and handles both
3:40 PM Changeset in webkit [9443] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Justin Garcia.

  • Scripts/run-webkit-tests: Report number of tests when they succeed.
3:00 PM Changeset in webkit [9442] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • added support for emptying the icon database
  • Misc.subproj/WebIconDatabase.h: just fixed a typo
  • Misc.subproj/WebIconDatabasePrivate.h: added WebPendingPublic category with method removeAllIcons, and declared WebIconDatabaseDidRemoveAllIconsNotification string.
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): new method, removes all known icons from memory and disk. There's one loose end, covered by radar bug 4155182, where it's possible for the icon database's retain counts to get off after this operation. I plan to fix this next. (-[WebIconDatabase _setIconURL:forURL:]): just fixed some extra whitespace (-[WebIconDatabase _forgetIconForIconURLString:]): new method, extracted from _releaseIconForIconURLString (-[WebIconDatabase _releaseIconForIconURLString:]): now calls extracted method
  • WebKit.exp: added _WebIconDatabaseDidRemoveAllIconsNotification
2:59 PM Changeset in webkit [9441] by mjs
  • 28 edits
    2 adds in trunk

JavaScriptCore:

Patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.

Test cases added:

  • tests/mozilla/expected.html: Updated for two fixed tests.
  • also added a layout test
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasOwnProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasOwnProperty): (KJS::ActivationImp::hasOwnProperty):
  • kjs/function.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty): (KJS::ObjectImp::hasOwnProperty):
  • kjs/object.h: (KJS::Object::hasOwnProperty):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasOwnProperty):
  • kjs/string_object.h:

WebCore:

Patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.

Test cases added:

  • layout-tests/fast/js/hasOwnProperty-expected.txt: Added.
  • layout-tests/fast/js/hasOwnProperty.html: Added.
  • also fixed two mozilla JS tests
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMNamedNodeMap::hasOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
  • khtml/ecma/kjs_window.h:
11:20 AM Changeset in webkit [9440] by ggaren
  • 2 edits
    2 adds in trunk

Changes by Darin. Layout tests by me. Reviewed by me.

Fixed <rdar://problem/4152454> crash in KJS::ExprStatementNode::execute(KJS::ExecState*) in World Clock widget with TOT.

Test cases added:

  • layout-tests/fast/dom/gc-4-expected.txt: Added.
  • layout-tests/fast/dom/gc-4.html: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2D::mark): mark now (1) checks for NULL pointers and (2) calls mark on its parent class (DOMObject::mark).

Jun 19, 2005:

10:52 PM Changeset in webkit [9439] by darin
  • 3 edits
    2 adds in trunk

Changes by both Anders Carlsson and me.
Reviewed by Maciej and me.

Test cases added:

  • layout-tests/fast/forms/element-order-expected.txt: Added.
  • layout-tests/fast/forms/element-order.html: Added.
  • khtml/html/html_formimpl.h: Added formElementIndex.
  • khtml/html/html_formimpl.cpp: (DOM::insertIntoVector): Added. (DOM::HTMLFormElementImpl::formElementIndex): Added. Computes an appropriate index for a form element, given the document position relative to the other elements. (DOM::HTMLFormElementImpl::registerFormElement): Use formElementIndex to determine where to insert the element in the formElements array.
10:24 PM Changeset in webkit [9438] by darin
  • 13 edits in trunk/WebCore

Changes by Anders Carlsson and me.
Reviewed by Maciej and me.

Test cases added: None. Could not figure out how to automate a test without
making enhancements to DumpRenderTree.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::select): Remove unneeded explicit call to onSelect() here -- now handled by the renderer.
  • khtml/rendering/render_form.h: Added declarations as needed below.
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotSelectionChanged): Add base class implementation that does nothing. (RenderLineEdit::RenderLineEdit): Connect the selection changed signal to our slot. (RenderLineEdit::slotSelectionChanged): Call onSelect when selection changes to something that's a selection (not a caret). (RenderTextArea::RenderTextArea): Connect as above. (RenderTextArea::slotSelectionChanged): Call as above.
  • kwq/KWQLineEdit.h: Added declarations as needed below.
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Added selectionChanged signal. (QLineEdit::hasSelectedText): Added.
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Make selectionChanged work on any form element. (KWQSlot::call): ditto.
  • kwq/KWQTextArea.h: Added hasSelection method.
  • kwq/KWQTextArea.mm: (-[KWQTextArea textViewDidChangeSelection:]): Added. Sends selectionChanged signal, except if we're in the middle of gaining or losing first responder. (-[KWQTextArea hasSelection]): Added. (-[KWQTextAreaTextView becomeFirstResponder]): Added. Sets flag to tell us we're in a responder change (using a count to avoid trouble if we reenter). (-[KWQTextAreaTextView resignFirstResponder]): Ditto. (-[KWQTextAreaTextView inResponderChange]): Added.
  • kwq/KWQTextEdit.h: Added declarations as needed below.
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Added selectionChanged signal. (QTextEdit::hasSelectedText): Added.
  • kwq/KWQTextField.h: Added declarations as needed below.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Fixed up to do the right thing with the result of the init function we call. (-[KWQTextFieldController controlTextDidEndEditing:]): Removed call to setHasFocus:NO since it's a little too late by the time the control is called; now handled by the text view delegate methods below. (-[KWQTextFieldController hasSelection]): Added. (-[KWQTextFieldController setHasFocus:]): Sets the new hasFocusAndSelectionSet after new focus and selection are both set up. (-[KWQTextFieldController textViewDidChangeSelection:]): Added. Sends the selection changed signal. (-[KWQTextField initWithQLineEdit:]): Fixed up to do the right thing with the result of the init function we call. (-[KWQTextField textViewDidChangeSelection:]): Added. Calls super and then calls the controller. (-[KWQTextField textDidEndEditing:]): Added. Calls setHasFocus:NO and then calls super. (-[KWQSecureTextField initWithQLineEdit:]): Same as above, but for secure text fields. (-[KWQSecureTextField textViewDidChangeSelection:]): Ditto. (-[KWQSecureTextField textDidEndEditing:]): Ditto. (-[KWQSearchField initWithQLineEdit:]): Same as above, but for search fields. (-[KWQSearchField textViewDidChangeSelection:]): Ditto. (-[KWQSearchField textDidEndEditing:]): Ditto. (-[KWQTextFieldFormatter init]): Fixed up to do the right thing with the result of the init function we call.
6:20 PM Changeset in webkit [9437] by darin
  • 2 edits in trunk/WebKit

Changes by Mitz Pettel
Reviewed by me.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Translate the matrix of the CGContext instead of passing the appropriate coordinates to ATSU.

Jun 18, 2005:

11:42 PM Changeset in webkit [9436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Add more auto-release pools in the hope of making the tool use less memory and run faster.
11:38 PM Changeset in webkit [9435] by darin
  • 2 edits
    2 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/dom/css-dom-read-expected.txt: Added.
  • layout-tests/fast/dom/css-dom-read.html: Added.
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::item): Get the style from the m_values list.
11:21 PM Changeset in webkit [9434] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

  • pcre/get.c: (pcre_get_substring): Fix some computations so this works for UTF-16. This is unused in the current JavaScriptCore, but still good to fix.
11:03 PM Changeset in webkit [9433] by darin
  • 2 edits in trunk/WebCore
  • undid a last minute change I made that broke a patch I landed (layout tests caught the mistake, all should work again now)
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Don't include this when iterating. (DOM::HTMLLegendElementImpl::formElement): Ditto.
10:50 PM Changeset in webkit [9432] by darin
  • 1 edit
    6 deletes in trunk
  • disabling the applet tests, since they are causing other tests to fail
  • layout-tests/fast/replaced/applet-hspace-expected.txt: Removed.
  • layout-tests/fast/replaced/applet-hspace.html: Removed.
  • layout-tests/fast/replaced/applet-vspace-expected.txt: Removed.
  • layout-tests/fast/replaced/applet-vspace.html: Removed.
  • layout-tests/fast/replaced/resources/applet.class: Removed.
  • layout-tests/fast/replaced/resources/applet.java: Removed.
10:44 PM Changeset in webkit [9431] by darin
  • 4 edits
    5 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/dom/resources/script3.js: Added.
  • layout-tests/fast/dom/resources/script4.js: Added.
  • layout-tests/fast/dom/resources/script5.js: Added.
  • layout-tests/fast/dom/script-add-expected.txt: Added.
  • layout-tests/fast/dom/script-add.html: Added.
  • khtml/html/html_headimpl.h: Added override of childrenChanged, new evaluateScript function, and m_evaluated boolean.
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): Init m_evaluated to false. (HTMLScriptElementImpl::childrenChanged): Added code to evaluate the script the first time a child is added (except for nodes created by parsing). (HTMLScriptElementImpl::insertedIntoDocument): Refactored to use the new text and evaluateScript functions. Also changed to not try to evaluate the script if the element is entirely empty. This allows you to declare an empty <script> element and fill the content in later using DHTML. (HTMLScriptElementImpl::notifyFinished): Refactored to use the new evaluateScript function. (HTMLScriptElementImpl::evaluateScript): Added. Checks and sets a new m_evaluated boolean to implement the "evaluate each script only once" rule. (HTMLScriptElementImpl::text): Replaced bogus implementation with one that works. (HTMLScriptElementImpl::setText): Ditto.
  • khtml/dom/html_head.cpp: (HTMLScriptElement::text): Replaced bogus implementation with one that calls through to the implementation class. This change doesn't really matter since we don't compile this file. (HTMLScriptElement::setText): Ditto.
10:31 PM Changeset in webkit [9430] by darin
  • 2 edits in trunk/WebCore
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Oops, checked in a version that didn't even compile! Fixed now.
10:00 PM Changeset in webkit [9429] by darin
  • 6 edits
    4 adds in trunk

Changes by Anders Carlsson.
Reviewed by me.

Test cases added:

  • layout-tests/fast/forms/focus-expected.txt: Added.
  • layout-tests/fast/forms/focus.html: Added.
  • layout-tests/fast/forms/legend-access-key-expected.txt: Added.
  • layout-tests/fast/forms/legend-access-key.html: Added.
  • fixed <rdar://problem/3481846> HTML4: accesskey not supported by HTML legend elements also <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3407>
  • added focus methods for <label> and <legend> elements
  • fixed crash when using JavaScript-created events that prevented tests from running
  • khtml/ecma/kjs_html.h: Added focus methods.
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElementFunction::tryCall): Added bindings for focus for <label> and <legend>. (Sorry about the merging, Dave.)
  • khtml/html/html_formimpl.h: Added new functions.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::focus): Added. (DOM::HTMLLegendElementImpl::formElement): Added. (DOM::HTMLLegendElementImpl::focus): Added. (DOM::HTMLLegendElementImpl::accessKeyAction): Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): If there's no QKeyEvent, then get the key name from keyIdentifier() instead of the QKeyEvent's unmodifiedText(). The old code would just do a nil-deref.
8:39 PM Changeset in webkit [9428] by darin
  • 2 edits
    3 adds in trunk

Change by Niels Leenheer (also done by Dave Hyatt on stage at WWDC).
Reviewed by me.

Test cases added:

  • layout-tests/fast/replaced/object-align-hspace-vspace-expected.txt: Added.
  • layout-tests/fast/replaced/object-align-hspace-vspace.html: Added.
  • layout-tests/fast/replaced/resources/webkit-background.png: Added.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::mapToEntry): Add cases for ATTR_ALIGN, ATTR_VSPACE and ATTR_HSPACE. (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
7:57 PM Changeset in webkit [9427] by darin
  • 2 edits in trunk/JavaScriptCore

Change by Finlay Dobbie.
Reviewed by me.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject stringRepresentation]): Undo change we did a while back to work around the gcc 3.3 compiler error. It no longer seems to happen, and the workaround code was 10.4-specific.
7:28 PM Changeset in webkit [9426] by darin
  • 2 adds in trunk/LayoutTests/fast/replaced

Oops, forgot these files.

7:27 PM Changeset in webkit [9425] by darin
  • 2 edits
    4 adds in trunk

Change by Niels Leenheer (also done by Dave Hyatt on stage at WWDC).
Reviewed by me.

Test cases added:

  • layout-tests/fast/replaced/applet-hspace-expected.txt: Added.
  • layout-tests/fast/replaced/applet-hspace.html: Added.
  • layout-tests/fast/replaced/applet-vspace-expected.txt: Added.
  • layout-tests/fast/replaced/applet-vspace.html: Added.
  • layout-tests/fast/replaced/resources/applet.class: Added.
  • layout-tests/fast/replaced/resources/applet.java: Added.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::mapToEntry): Add cases for ATTR_VSPACE and ATTR_HSPACE. (DOM::HTMLAppletElementImpl::parseMappedAttribute): Ditto.
7:08 PM Changeset in webkit [9424] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/cvs-apply: Improve handling of patches with CR characters in them.
  • Scripts/cvs-unapply: Ditto.
6:58 PM Changeset in webkit [9423] by darin
  • 2 edits
    2 adds in trunk
  • removed some unused code from one of the KWQ headers
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • added a layout test for a bug that's already fixed
  • layout-tests/fast/forms/element-by-name-expected.txt: Added.
  • layout-tests/fast/forms/element-by-name.html: Added.
6:49 PM Changeset in webkit [9422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Tiny formatting tweak.

Note: See TracTimeline for information about the timeline view.