Timeline



Jun 26, 2005:

10:33 PM Changeset in webkit [9488] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/build-dumprendertree: Pass -project option so that having a second copy of the project (like the one Xcode 2.1 offers to make for you) that's out of date won't screw you up.
  • Scripts/build-webkit: Ditto.

Jun 25, 2005:

10:21 AM Changeset in webkit [9487] by darin
  • 2 edits
    2 adds in trunk
  • updated a layout test so that it doesn't depend on a remote resource via http
  • layout-tests/fast/backgrounds/001.html: Change image URL to be relative.
  • layout-tests/fast/backgrounds/resources/bg_position_larger.gif: Added.

Jun 24, 2005:

10:17 PM Changeset in webkit [9486] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-explicit-embedding.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::embed): Set up the new run correctly following an embed/pop. (khtml::RenderBlock::bidiReorderLine): Close the "dangling" run when we see an explicit embedding character (or PDF).
9:47 PM Changeset in webkit [9485] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-CS-after-AN.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Rolled in the patch from the KDE tree.
2:05 PM Changeset in webkit [9484] by justing
  • 3 edits in trunk/WebCore

Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer, and adds a QBuffer(QByteArray) constructor.

Reviewed by Darin

Test cases added: Non required

  • kwq/KWQBuffer.h: (QBuffer::QBuffer):
  • kwq/KWQBuffer.mm: (QBuffer::setBuffer):
1:48 PM Changeset in webkit [9483] by justing
  • 2 edits in trunk/WebKit

Patch contributed by Duncan Wilcox <​duncan@mclink.it>

Reviewed by Darin

Spelling suggestions in the context menu don't call the should* delegate methods

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _changeSpellingFromMenu:]): give delegate's webView:shouldInsertText:replacingDOMRange:givenAction: a chance to prevent replacing of selected text
11:57 AM Changeset in webkit [9482] by justing
  • 4 edits in trunk/WebCore

Reviewed by Darin

Test cases added: None required

  • kwq/KWQRect.h: (QRect::contains):
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::topRight): (QRect::bottomLeft): (QRect::normalize): (QRect::operator CGRect):
  • kwq/KWQString.h: (QChar::): (QString::remove):
9:48 AM Changeset in webkit [9481] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Justin Garcia.

  • fixed <rdar://problem/4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"

Test cases added:

  • layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
  • layout-tests/fast/dom/anchor-backslash.html: Added.
  • kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore "?" and "#" characters if they were the first character in the string.

Jun 23, 2005:

10:59 PM Changeset in webkit [9480] by darin
  • 2 edits in trunk/WebCore
  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue): Took out an unneeded type cast (meant to do that before committing).
10:53 PM Changeset in webkit [9479] by darin
  • 15 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/forms/selection-functions-expected.txt: Added.
  • layout-tests/fast/forms/selection-functions.html: Added.
  • layout-tests/fast/forms/textarea-crlf-expected.txt: Added.
  • layout-tests/fast/forms/textarea-crlf.html: Added.
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.cpp: (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::KJS::HTMLElement::getValueProperty): (KJS::KJS::HTMLElement::hasProperty): (KJS::KJS::HTMLElementFunction::tryCall): (KJS::HTMLElement::putValue):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::canHaveSelection): (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::setValue): (DOM::HTMLTextAreaElementImpl::selectionStart): (DOM::HTMLTextAreaElementImpl::selectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionStart): (DOM::HTMLTextAreaElementImpl::setSelectionEnd): (DOM::HTMLTextAreaElementImpl::setSelectionRange): (DOM::HTMLTextAreaElementImpl::setValue):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::setSelectionRange): (RenderTextArea::selectionStart): (RenderTextArea::selectionEnd): (RenderTextArea::setSelectionStart): (RenderTextArea::setSelectionEnd): (RenderTextArea::select): (RenderTextArea::setSelectionRange):
  • khtml/rendering/render_form.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setCursorPosition): (QLineEdit::cursorPosition): (QLineEdit::selectAll): (QLineEdit::selectionStart): (QLineEdit::selectedText): (QLineEdit::setSelection):
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextArea setSelectedRange:]): (-[KWQTextArea selectedRange]): (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::getCursorPosition): (QTextEdit::selectionStart): (QTextEdit::selectionEnd): (QTextEdit::setSelectionStart): (QTextEdit::setSelectionEnd): (QTextEdit::selectAll): (QTextEdit::setSelectionRange):
  • kwq/KWQTextField.h:
  • kwq/KWQTextField.mm: (-[KWQTextFieldController selectedRange]): (-[KWQTextFieldController setSelectedRange:]):
2:52 PM Changeset in webkit [9478] by justing
  • 2 edits in trunk/WebCore

Patch by Eric Seidel <​macdome@opendarwin.org>

Adds QTextIStream, QTextOStream to KWQ

Reviewed by Darin

Test cases added: None required

  • kwq/KWQTextStream.h: (QTextIStream::QTextIStream): (QTextOStream::QTextOStream):
2:25 PM Changeset in webkit [9477] by justing
  • 6 edits in trunk/WebCore

Patch by Eric Seidel <​macdome@opendarwin.org>

This patch contains several small additions to KWQ

Reviewed by Darin

Test cases added: None required

  • kwq/KWQApplication.h: (QApplication::palette):
  • kwq/KWQDateTime.h: (QDateTime::time):
  • kwq/KWQDict.h: (QDict::operator[]): (QDictIterator::operator*):
  • kwq/KWQKDebug.h: (kdbgstream::operator<<):
  • kwq/KWQMemArray.h: (QMemArray::duplicate):
12:47 PM Changeset in webkit [9476] by harrison
  • 13 edits in trunk/WebCore

Test cases added: None needed for this debug-only utility code.

  • Make showTree() const.
  • Add showTree() for InlineBox.
  • Add showTree() for RenderObject.
  • khtml/editing/selection.cpp: (khtml::Selection::showTree):
  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::showTree):
  • khtml/editing/visible_position.h: Make showTree() const.
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::showTree):
  • khtml/rendering/render_line.h: Add showTree() for InlineBox.
  • khtml/rendering/render_object.cpp: (RenderObject::showTree):
  • khtml/rendering/render_object.h: Add showTree() for RenderObject.
  • khtml/xml/dom_nodeimpl.cpp: (appendAttributeDesc): (NodeImpl::showNode): (NodeImpl::showTree): (NodeImpl::showTreeAndMark):
  • khtml/xml/dom_nodeimpl.h: Make showTree() const.
12:13 PM Changeset in webkit [9475] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • added template to be used when writing manual tests
  • manual-tests/template.html: Added.
8:00 AM Changeset in webkit [9474] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Fixed a regular expression in the code I just landed.
7:53 AM Changeset in webkit [9473] by darin
  • 3 edits in trunk/WebKitTools

Changes based on input from Michael Kahl.

  • Scripts/cvs-create-patch: Added code to handle getting changes in the top-level directory passed in.
  • Scripts/webkitdirs.pm: Eliminate use of changing the current directory and using getcwd() in the code to find the base product dir. Added code to handle unusual base product directory values that use SRCROOT.

Jun 22, 2005:

8:15 PM Changeset in webkit [9472] by darin
  • 2 edits
    4 adds in trunk/WebCore
  • ForwardingHeaders/kjs/value.h: Added.
  • ForwardingHeaders/qintdict.h: Added an include.
  • ForwardingHeaders/qptrcollection.h: Added.
  • ForwardingHeaders/qsize.h: Added.
  • kwq/KWQIntDict.h: Added. Empty file.
2:32 PM Changeset in webkit [9471] by sullivan
  • 9 edits
    1 add in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/3764645> please add a way to allow WebKit clients to override the WebPDFView context menu
  • PublicHeaderChangesFromTiger.txt: Added. New file to keep track of changes made to public headers that haven't been through API review yet. Initially lists the WebMenuItem enum tags added to WebUIDelegate.h as part of this change.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate appendDefaultItems:toArray:]): new method, handles initial separator (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): now has defaultMenuItems: parameter. Any menu items in this array are appended at the end of the standard set. (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): This had a defaultMenuItems parameter before but it was always nil. Now it passes the defaultMenuItems parameter on to the two methods that construct lists (one for editing, the other for viewing). Also tweaked variable name and type for clarity.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): passes nil for new defaultItems parameter of _menuForElement:
  • WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]): ditto
  • WebView.subproj/WebPDFView.m: (-[WebPDFView elementAtPoint:]): new method to create the element dictionary needed for _menuForElement:defaultItems:. Only supplies the webFrame at this point. (-[WebPDFView _menuItemsFromPDFKitForEvent:]): new method to return copies of the menu items that PDFKit would include in the context menu, with WebKit tags applied (-[WebPDFView menuForEvent:]): now calls standard WebKit context menu mechanism, so clients' delegates can modify the context menu as desired. The initial set of items are the ones WebKit was already displaying for PDF context menus.
  • WebView.subproj/WebUIDelegate.h: added enum values for the menu items in the PDF context menu
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]): Added the defaultItems: parameter to this method, which is then passed along to WebDefaultUIDelegate. All callers pass nil except for WebPDFView, at least for now.
2:05 PM Changeset in webkit [9470] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Vicki.

Test cases added:

  • layout-tests/fast/css/apple-prefix-expected.txt: Added.
  • layout-tests/fast/css/apple-prefix.html: Added.
  • fixed <rdar://problem/4141650> REGRESSION: Safari RSS slider broken with TOT WebCore
  • khtml/css/parser.y: (getPropertyID): Fix lifetime problem on the QString. Also construct the QString using length, since the passed-in char * is not necessarily null-terminated. Also do the mapping only if it's a "-apple-" prefix -- the old code would do it for, e.g., "-applex-" too. The old code would not successfully map the "apple" in "appleLineClamp" to "khtml", and Dave changed things so that the internal name of all CSS attributes is "khtml" back in his 2005-05-03 check-in, breaking the use of appleLineClamp in RSS. (getValueID): Ditto.
11:37 AM Changeset in webkit [9469]
  • 35 copies
    2 deletes in tags/WebCore-413~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~1'.

11:37 AM Changeset in webkit [9468] by adele
  • 2 edits in branches/gcc-4-0-branch/WebCore

Fix versioning for gcc-4-0-branch - WebCore-413.0.1

11:23 AM Changeset in webkit [9467] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added more bug numbers to the change log.

11:22 AM Changeset in webkit [9466] by darin
  • 5 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/dom/title-text-property-expected.txt: Added
  • layout-tests/fast/dom/title-text-property.html: Added
  • layout-tests/fast/dom/title-text-property-expected-2.txt: Added
  • layout-tests/fast/dom/title-text-property-2.html: Added

Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3586>
Setting and getting title's text attribute does not work

  • khtml/dom/html_head.cpp: (HTMLTitleElement::text): (HTMLTitleElement::setText): Call HTMLTitleElementImpl::text() and ::setText().
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::HTMLTitleElementImpl): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::removedFromDocument): (HTMLTitleElementImpl::childrenChanged): Pass the current title node to DocumentImpl::setTitle and ::removeTitle.

(HTMLTitleElementImpl::text):
Return the title.

(HTMLTitleElementImpl::setText):
Set the new title.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::setTitle): (DocumentImpl::removeTitle):
  • khtml/xml/dom_docimpl.h: Only update the title if it's done by setting document.title or by changing the child nodes of the title element.
11:01 AM Changeset in webkit [9465] by darin
  • 2 edits in trunk/WebKitTools

Change by Anders Carlsson.

  • added support for dumping title changes
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didReceiveTitle:forFrame:]): Added. Dump title change if requested by JavaScript. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added dumpTitleChanges. (-[LayoutTestController dumpTitleChanges]): Added, sets flag. (dumpRenderTree): Start flag as NO.
10:39 AM Changeset in webkit [9464] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-L2-run-reordering-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-L2-run-reordering.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Fixed mistake where we'd advance too far after reversing a run.
10:29 AM Changeset in webkit [9463] by darin
  • 1 edit
    2 adds in trunk
  • layout-tests/fast/js/string-replace-2-expected.txt: Added.
  • layout-tests/fast/js/string-replace-2.html: Added.
10:26 AM Changeset in webkit [9462] by darin
  • 4 edits in trunk/JavaScriptCore

Change by Anders Carlsson.
Reviewed by me.

  • kjs/string_object.cpp: (replace): Added code to handle functions.
  • tests/mozilla/expected.html: Updated since ecma_3/RegExp/regress-209067.js is fixed now.
  • tests/mozilla/run-mozilla-tests: Fix a minor coding style issue that leads to a warning each time we run the tests.
9:44 AM Changeset in webkit [9461] by darin
  • 2 edits in trunk/WebKit

Change by Mitz Pettel.
Reviewed by me.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]): Fix off-by-one mistake in order-swapping loops.
9:38 AM Changeset in webkit [9460] by darin
  • 3 edits
    2 adds in trunk

Reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/dom/css-set-property-exception-expected.txt: Added.
  • layout-tests/fast/dom/css-set-property-exception.html: Added.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::tryPut): Ignore exceptions when setting properties.
  • layout-tests/fast/js/exception-linenums.html: Changed test case that involved setting style to one that involved setting another property that raises an exception when you try to set it (setting prefix on a text node).
9:20 AM Changeset in webkit [9459] by darin
  • 3 edits in trunk/WebKit

Change by Michael Gaiman.
Reviewed by me.

  • Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _webkit_parseRFC822HeaderFields]): Fixed method name.
8:31 AM Changeset in webkit [9458] by darin
  • 2 edits in trunk/WebCore

Change proposed by Eric Seidel.

  • WebCore.pbproj/project.pbxproj: Fix build rule to match the one in JavaScriptCore. The one here accidentally had hard-coded paths in it and also had the $() vs. ${} issue that broke building on Xcode 2.1 for no good reason (it didn't need $() or ${}).
Note: See TracTimeline for information about the timeline view.