Timeline



Jun 28, 2005:

4:22 PM Changeset in webkit [9517] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
3:25 PM Changeset in webkit [9516] by ggaren
  • 4 edits in trunk/JavaScriptCore

Patch contributed by Carsten Guenther <​cguenther@gmail.com>.

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

Reviewed by darin.

  • kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
  • kjs/date_object.h:
  • tests/mozilla/expected.html: updated expected test results to reflect fix
3:18 PM Changeset in webkit [9515] by justing
  • 2 edits
    2 adds in trunk

Patch by Kevin Ballard <Lily Ballard>

Reviewed by Darin

Test cases added:

  • layout-tests/fast/forms/cursor-position-expected.txt: Added.
  • layout-tests/fast/forms/cursor-position.html: Added.
  • kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextArea setCursorPositionToIndex:inParagraph:]):
2:18 PM Changeset in webkit [9514] by mjs
  • 2 edits
    3 adds in trunk/WebCore

* empty log message *

11:47 AM Changeset in webkit [9513] by justing
  • 2 edits in trunk/WebCore

Patch by Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Darin

Test cases added: None required

  • khtml/misc/decoder.cpp: (Decoder::setEncoding):
9:22 AM Changeset in webkit [9512] by harrison
  • 3 edits in trunk

Reviewed by Chris Blumenberg.

Test cases added: (NONE)

(continued) <rdar://problem/4140688> assertion failure double-clicking text to select
Fixed my checkin from yesterday.

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::positionForOffset): Changed tabs to spaces.

(RenderText::positionForCoordinates):
Make sure affinity is downstream when in mid-line.
Changed tabs to spaces.

(RenderText::caretRect):
(RenderText::cacheWidths):
(RenderText::trimmedMinMaxWidth):
(RenderText::minXPos):
(RenderText::width):
(RenderText::caretMaxOffset):
Changed tabs to spaces.

  • layout-tests/editing/style/create-block-for-style-004-expected.txt: Expected ending selection affinity is downstream.

Jun 27, 2005:

10:47 PM Changeset in webkit [9511] by mjs
  • 2 edits in trunk/WebCore

Remove accidentally committed code that breaks the build. Oops!

  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::expand): (DOM::AtomicString::shrink):
6:57 PM Changeset in webkit [9510] by mjs
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Removed accidental change from last checkin.

6:54 PM Changeset in webkit [9509] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Darin.

  • replaced all our hash functions with the state of the art in hashing
  • ~1% speedup on cvs-base

No test cases added, perf effects only.

  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): Improved stats gathering to track collisions in more detail and count reinserts on remove. (DOM::addToCollisionCount): ditto (DOM::AtomicString::add): ditto (DOM::AtomicString::insert): ditto (DOM::AtomicString::remove): ditto
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::computeHash): Replace with SuperFastHash algorithm.
  • kwq/KWQCharsets.mm: (encodingNameHash): Clean up mistaken shift in the wrong direction.
  • kwq/KWQString.h: Removed unused hashing code.
  • kwq/KWQString.mm: ditto
  • kwq/KWQTextCodec.mm: (QTextCodec::hash): Use a variant of the SuperFastHash algorithm.
5:26 PM Changeset in webkit [9508]
  • 56 copies
    2 deletes in tags/WebCore-415~11~1

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11~1'.

5:26 PM Changeset in webkit [9507]
  • 83 copies in branches/Ti-2005-007-branch

This commit was manufactured by cvs2svn to create branch
'Ti-2005-007-branch'.

5:26 PM Changeset in webkit [9506]
  • 83 copies in tags/Ti-2005-007-anchor

This commit was manufactured by cvs2svn to create tag
'Ti-2005-007-anchor'.

5:26 PM Changeset in webkit [9505] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11.1

5:24 PM Changeset in webkit [9504]
  • 19 copies
    3 deletes in tags/WebKit-412~6~1

This commit was manufactured by cvs2svn to create tag
'WebKit-412~6~1'.

5:24 PM Changeset in webkit [9503] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6.1

5:20 PM Changeset in webkit [9502] by adele
  • 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155738> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error
5:02 PM Changeset in webkit [9501] by mjs
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.

  • replace hash functions with better ones
  • JavaScriptCore.pbproj/project.pbxproj: Add new file to build.
  • kjs/interpreter_map.cpp: (KJS::InterpreterMap::computeHash): Use shared pointer hash.
  • kjs/pointer_hash.h: Added. (KJS::pointerHash): Pointer hash based on 32-bit mix and 64-bit mix hashes.
  • kjs/protected_values.cpp: (KJS::ProtectedValues::computeHash): Use shared pointer hash.
  • kjs/ustring.cpp: (KJS::UString::Rep::computeHash): Use SuperFastHash algorithm.
4:54 PM Changeset in webkit [9500] by adele
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155736> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
4:51 PM Changeset in webkit [9499] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4162816> from TOT to Safari-2-0-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.
4:40 PM Changeset in webkit [9498] by adele
  • 2 edits in branches/Safari-1-3-branch/WebKit

2005-06-27 Adele Peterson <​adele@apple.com>

Merged fix for 4119282 from TOT to Safari-1-3-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
4:32 PM Changeset in webkit [9497] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Safari-1-3-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.
1:23 PM Changeset in webkit [9496] by justing
  • 2 edits in trunk/WebKit

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebView.subproj/WebView.m: (-[WebView setSelectedDOMRange:affinity:]): If range is nil, call deselectText.
1:10 PM Changeset in webkit [9495]
  • 4 copies
    2 deletes in tags/WebCore-315~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~0~1'.

1:10 PM Changeset in webkit [9494] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebCore

Versioning for Pan-2005-007-branch - WebCore-315.0.1

12:55 PM Changeset in webkit [9493]
  • 5 copies
    3 deletes in tags/WebKit-312~1~1

This commit was manufactured by cvs2svn to create tag
'WebKit-312~1~1'.

12:55 PM Changeset in webkit [9492] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebKit

Versioning for Pan-2005-007 - WebKit-312.1.1

12:53 PM Changeset in webkit [9491] by adele
  • 3 edits in branches/Pan-2005-007-branch/WebKit

Merged fix for 4119282 from TOT to Pan-2005-007-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
12:12 PM Changeset in webkit [9490] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken.

Test cases added: None because this relies on mouse clicking.

<rdar://problem/4140688> assertion failure double-clicking text to select

  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):

Use setAffinityUsingLinePosition.

11:48 AM Changeset in webkit [9489] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Pan-2005-007 branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

Jun 26, 2005:

10:33 PM Changeset in webkit [9488] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/build-dumprendertree: Pass -project option so that having a second copy of the project (like the one Xcode 2.1 offers to make for you) that's out of date won't screw you up.
  • Scripts/build-webkit: Ditto.

Jun 25, 2005:

10:21 AM Changeset in webkit [9487] by darin
  • 2 edits
    2 adds in trunk
  • updated a layout test so that it doesn't depend on a remote resource via http
  • layout-tests/fast/backgrounds/001.html: Change image URL to be relative.
  • layout-tests/fast/backgrounds/resources/bg_position_larger.gif: Added.

Jun 24, 2005:

10:17 PM Changeset in webkit [9486] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-explicit-embedding.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::embed): Set up the new run correctly following an embed/pop. (khtml::RenderBlock::bidiReorderLine): Close the "dangling" run when we see an explicit embedding character (or PDF).
9:47 PM Changeset in webkit [9485] by darin
  • 2 edits
    2 adds in trunk

Changes by Mitz Pettel.
Reviewed by me.

Test cases added:

  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-CS-after-AN.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Rolled in the patch from the KDE tree.
2:05 PM Changeset in webkit [9484] by justing
  • 3 edits in trunk/WebCore

Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer, and adds a QBuffer(QByteArray) constructor.

Reviewed by Darin

Test cases added: Non required

  • kwq/KWQBuffer.h: (QBuffer::QBuffer):
  • kwq/KWQBuffer.mm: (QBuffer::setBuffer):
1:48 PM Changeset in webkit [9483] by justing
  • 2 edits in trunk/WebKit

Patch contributed by Duncan Wilcox <​duncan@mclink.it>

Reviewed by Darin

Spelling suggestions in the context menu don't call the should* delegate methods

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _changeSpellingFromMenu:]): give delegate's webView:shouldInsertText:replacingDOMRange:givenAction: a chance to prevent replacing of selected text
11:57 AM Changeset in webkit [9482] by justing
  • 4 edits in trunk/WebCore

Reviewed by Darin

Test cases added: None required

  • kwq/KWQRect.h: (QRect::contains):
  • kwq/KWQRect.mm: (QRect::QRect): (QRect::topRight): (QRect::bottomLeft): (QRect::normalize): (QRect::operator CGRect):
  • kwq/KWQString.h: (QChar::): (QString::remove):
9:48 AM Changeset in webkit [9481] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Justin Garcia.

  • fixed <rdar://problem/4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"

Test cases added:

  • layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
  • layout-tests/fast/dom/anchor-backslash.html: Added.
  • kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore "?" and "#" characters if they were the first character in the string.
Note: See TracTimeline for information about the timeline view.