Timeline



Jun 29, 2005:

10:57 PM Changeset in webkit [9547] by darin
  • 2 adds in trunk/LayoutTests/fast/xsl/resources

Forgot one file.

10:57 PM Changeset in webkit [9546] by darin
  • 3 edits
    4 adds in trunk

Reviewed and landed by Darin Adler.

Test cases added:

  • layout-tests/fast/xsl/document-function-expected.txt: Added.
  • layout-tests/fast/xsl/document-function.xml: Added.
  • layout-tests/fast/xsl/document-function.xsl: Added.
  • layout-tests/fast/xsl/resources/document-function-source.xml: Added.
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc): Stub to prevent errors from getting written to the console.

(DOM::stylesheetLoadFunc):
Fetch and parse documents.

(DOM::XSLTProcessorImpl::transformDocument):
Use the processor as the global variable instead of the
style sheet.

  • khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::stylesheet): (DOM::XSLTProcessorImpl::sourceDocument): Add accessors for source document and stylesheet.
10:41 PM Changeset in webkit [9545] by darin
  • 2 edits in trunk/WebKitTools
  • fixed bug which would result in multiple unwanted dumps in a single layout test
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): Set new "readyToDump" flag. (-[LayoutTestController waitUntilDone]): Update for name change. (-[LayoutTestController notifyDone]): Dump only if ready. (dumpRenderTree): Set up new boolean and update for name change.
9:33 PM Changeset in webkit [9544] by darin
  • 3 edits
    1 add in trunk/WebKitTools

Changes by Timothy Hatcher.
Reviewed by me.

  • Scripts/run-webkit-app: Added script to open an arbritrary application with a CVS built WebKit. Example: ./run-webkit-app Colloquy
  • Scripts/gdb-safari: Added support for WEBKIT_SAFARI environment variable to specify a custom location to the Safari.app bundle. This is optional, script defaults to the stock location.
  • Scripts/run-safari: Ditto.
8:19 PM Changeset in webkit [9543] by mjs
  • 2 edits in trunk/WebCore

Unreviewed - fixing build breakage with gcc 4.

  • khtml/misc/hashtable.h: Don't use a typedef when declaring a class friend.
6:56 PM Changeset in webkit [9542] by harrison
  • 3 edits in trunk/WebCore

Temporarily enable tab coalescing ahead of white-space:pre-wrap
change because of problems with keeping the tabs separate. Will
revert when problems are fixed or remove if I do pre-wrap
first.

  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::insertTab):
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString):
6:28 PM Changeset in webkit [9541] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Dave Hyatt (rendering) and Maciej (editing).

Test cases added: Coming soon. Will include with next round of changes for this bug.

This is the first checkin for...

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.

  • WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]): (initializeCharacterWidthIterator): (widthForNextCharacter):
6:27 PM Changeset in webkit [9540] by harrison
  • 53 edits in trunk

Reviewed by Dave Hyatt (rendering) and Maciej (editing).

Test cases added: Coming soon. Will include with next round of changes for this bug.

This is the first checkin for...

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.

  • khtml/editing/apply_style_command.cpp: (khtml::createStyleSpanElement): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState):
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::styleAtPosition):
  • khtml/editing/html_interchange.h:
  • khtml/editing/htmlediting.cpp: (khtml::isSpecialElement): (khtml::isTabSpanNode): (khtml::isTabSpanTextNode): (khtml::positionBeforeTabSpan): (khtml::createTabSpanElement):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertTab):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::removeStyleNodes):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::addPending): (khtml::HTMLTokenizer::write):
  • khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::):
  • khtml/rendering/bidi.cpp: (khtml::addRun): (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::checkSelectionPoint): (Font::width):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_br.h: (khtml::RenderBR::width):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_line.h: (khtml::InlineBox::width): (khtml::InlineBox::xPos): (khtml::InlineBox::yPos): (khtml::InlineBox::height): (khtml::InlineBox::baseline):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • khtml/rendering/render_object.cpp: (RenderObject::tabWidth): (RenderObject::recalcMinMaxWidths):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): (InlineTextBox::paint): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::textPos): (InlineTextBox::offsetForPosition): (InlineTextBox::positionForOffset): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace): (RenderText::width):
  • khtml/rendering/render_text.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::charWidth): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint): (QFontMetrics::boundingRect): (QFontMetrics::size):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle):
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001.html:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002.html:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003.html:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004.html:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:
6:19 PM Changeset in webkit [9539] by ggaren
  • 4 edits
    6 adds in trunk

JavaScriptCore:

Patch by Francisco Tolmasky <​tolmasky@gmail.com>

See WebCore Changelog for layout tests added.

Reviewed by darin.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::call):
  • kjs/array_object.h: (KJS::ArrayProtoFuncImp::):

WebCore:

Contributed by Francisco Tolmasky <​tolmasky@gmail.com>

-test cases for fix to ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
Core JavaScript 1.5 Reference:Objects:Array:forEach

See JavaScriptCore Changelog for details on the patch.

Reviewed by darin.

Test cases added:

  • layout-tests/fast/js/array-every-expected.txt: Added.
  • layout-tests/fast/js/array-every.html: Added.
  • layout-tests/fast/js/array-foreach-expected.txt: Added.
  • layout-tests/fast/js/array-foreach.html: Added.
  • layout-tests/fast/js/array-some-expected.txt: Added.
  • layout-tests/fast/js/array-some.html: Added.
5:41 PM Changeset in webkit [9538] by bdibello
  • 1 edit
    1 add in trunk

Reviewed by Geoff Garen

Test cases added: added expected results for previous check in

  • layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Added.
5:22 PM Changeset in webkit [9537] by ggaren
  • 1 edit
    5 adds in trunk

DOM compatibility tests for HTMLDocument::writeln

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln/call.html: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Added.
5:19 PM Changeset in webkit [9536] by ggaren
  • 2 edits
    2 adds in trunk

Reviewed by Geoff Garen.

Test cases added: added DOM test for document.URL

  • layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
5:13 PM Changeset in webkit [9535] by bdibello
  • 1 edit
    2 adds in trunk

Reviewed by Geoff Garen.

Test cases added: added DOM test for document.URL

  • layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
4:24 PM Changeset in webkit [9534] by ggaren
  • 1 edit
    3 adds in trunk

DOM compatibility test for HTMLDocument::write

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/write/call.html: Added.
4:12 PM Changeset in webkit [9533] by ggaren
  • 3 edits
    2 adds in trunk

DOM compatibility tests for HTMLDocument::title

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
4:01 PM Changeset in webkit [9532] by ggaren
  • 1 edit
    4 adds in trunk

DOM compatibility tests for HTMLDocument::title

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
3:53 PM Changeset in webkit [9531] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Kevin.

  • deleted some never-used stub code
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewInternal.h:
  • WebView.subproj/WebViewPrivate.h:
2:37 PM Changeset in webkit [9530] by justing
  • 3 adds
    1 delete in trunk/LayoutTests/fast/dom/HTMLObjectElement

* empty log message *

2:29 PM Changeset in webkit [9529] by justing
  • 4 adds in trunk/LayoutTests/fast/dom/HTMLLabelElement

* empty log message *

2:22 PM Changeset in webkit [9528] by justing
  • 1 delete in trunk/LayoutTests/fast/dom/HTMLLabelElement

* empty log message *

2:04 PM Changeset in webkit [9527] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Added iterator support to new hashtable class, the HashSet API is
now essentially complete.

Added support for consistency check mode.

  • khtml/misc/hashset.h: (khtml::HashSet::capacity): Added (khtml::HashSet::begin): Added (both const and non-const) (khtml::HashSet::end): Added (both const and non-const) (khtml::HashSet::insert): Made both versions return an iterator (khtml::HashSet::find): Added (both const and on-const, returning appropriate iterator) (khtml::HashSet::contains): Added (khtml::HashSet::remove): Added version that takes an iterator argument (khtml::HashSet::clear): Added
  • khtml/misc/hashtable.h: (khtml::HashTableIterator): New class with all the obvious iterator stuff. (khtml::HashTableConstIterator::HashTableConstIterator): New class with all the obvious const iterator stuff. (khtml::HashTable::begin): Added (both const and non-consts) (khtml::HashTable::end): Added (both const and non-consts) (khtml::HashTable::capacity): Added (khtml::HashTable::insert): Implement non-template method in terms of template method. (khtml::HashTable::contains): Added (implemented in terms of find) (khtml::HashTable::remove): Implemented key remove in terms of find and iterator remove. (khtml::HashTable::hash): Made static (khtml::HashTable::equal): Made static (khtml::HashTable::identityConvert): Added - no-op convert method so template insert method can be implemented in terms of non-template (khtml::HashTable::insert): Changed to return iterator (khtml::HashTable::reinsert): Recoded to be more like the other functions (khtml::HashTable::find): Added (khtml::HashTable::remove): Added iterator version (khtml::HashTable::clear): Added
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): Updated to deal with the fact that insert returns an iterator (khtml::HashTable::shouldExpand): New helper. (khtml::HashTable::shouldShrink): ditto (khtml::HashTable::makeIterator): ditto (khtml::HashTable::makeConstIterator): ditto (khtml::HashTable::checkConsistency): consistency check method (khtml::HashTable::checkConsistencyExceptSize): consistency check method
1:59 PM Changeset in webkit [9526] by ggaren
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Patch contributed by Oliver Hunt <​ojh16@student.canterbury.ac.nz>

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls

See WebCore Changelog for layout test added.

Reviewed by mjs.

  • kjs/object.cpp: (KJS::ObjectImp::defaultValue):

WebCore:

-added test case for fix to ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls

See JavaScriptCore Changelog for details about the patch.

Reviewed by me.

Test cases added:

  • layout-tests/fast/js/toString-stack-overflow-expected.txt: Added.
  • layout-tests/fast/js/toString-stack-overflow.html: Added.
1:15 PM Changeset in webkit [9525] by ggaren
  • 4 edits in trunk/JavaScriptCore

Rolling out date patch from 6-28-05 because it breaks
fast/js/date-parse-test

Reviewed by NOBODY.

  • kjs/date_object.cpp: (formatLocaleDate): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (isSpaceOrTab): (KJS::KRFCDate_parseDate):
  • kjs/date_object.h:
  • tests/mozilla/expected.html:
1:14 PM Changeset in webkit [9524] by justing
  • 2 edits
    8 adds in trunk

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin

Test cases added:

  • layout-tests/fast/dom/HTMLLabelElement/properties/form-expected.txt: Added.
  • layout-tests/fast/dom/HTMLLabelElement/properties/form.html: Added.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::form): Traverse upwards looking for a form element.
11:49 AM Changeset in webkit [9523] by justing
  • 2 deletes in trunk/LayoutTests/fast/dom

Bug #:
Submitted by:
Reviewed by:

10:52 AM Changeset in webkit [9522] by ggaren
  • 1 edit
    2 adds in trunk

Patch by Joost de Valk <​webkit@joostdevalk.nl>

Reviewed by Darin.

Test cases added:

  • layout-tests/fast/forms/access-key-expected.txt: Added.
  • layout-tests/fast/forms/access-key.html: Added.
10:50 AM Changeset in webkit [9521] by justing
  • 2 edits
    2 adds in trunk

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin

Test cases added:

  • layout-tests/fast/dom/htmlobject-form-expected.txt: Added.
  • layout-tests/fast/dom/htmlobject-form.html: Added.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::form): Implement this function by traversing the parent nodes looking for a form element.
10:41 AM Changeset in webkit [9520] by ggaren
  • 2 edits
    2 adds in trunk

Patch by Antoine Quint <​ml@graougraou.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3648
quadraticCurveTo() method in <canvas> APIs JS bindings does not exist

Reviewed by Darin.

Test cases added:

  • layout-tests/fast/dom/quadraticCurveTo-expected.txt: Added.
  • layout-tests/fast/dom/quadraticCurveTo.xml: Added.
  • khtml/ecma/kjs_html.cpp:
10:18 AM Changeset in webkit [9519] by ggaren
  • 2 edits
    2 adds in trunk

Patch by Hanspeter Schaub <​Hanspeterschaub@mac.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3317
REGRESSION: CSS2: outline is applied to both <li> element
and its enclosing text with context dependent selector

Reviewed by Hyatt.

Test cases added:

  • layout-tests/fast/css/list-outline-expected.txt: Added.
  • layout-tests/fast/css/list-outline.html: Added.
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint):
9:32 AM Changeset in webkit [9518] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3750
build fails with KJS_VERBOSE set

  • kjs/nodes.cpp: changed debug print statement to use UString (VarDeclNode::evaluate):
  • kjs/reference.cpp: ditto (KJS::Reference::putValue):

Jun 28, 2005:

4:22 PM Changeset in webkit [9517] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
3:25 PM Changeset in webkit [9516] by ggaren
  • 4 edits in trunk/JavaScriptCore

Patch contributed by Carsten Guenther <​cguenther@gmail.com>.

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

Reviewed by darin.

  • kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
  • kjs/date_object.h:
  • tests/mozilla/expected.html: updated expected test results to reflect fix
3:18 PM Changeset in webkit [9515] by justing
  • 2 edits
    2 adds in trunk

Patch by Kevin Ballard <Lily Ballard>

Reviewed by Darin

Test cases added:

  • layout-tests/fast/forms/cursor-position-expected.txt: Added.
  • layout-tests/fast/forms/cursor-position.html: Added.
  • kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextArea setCursorPositionToIndex:inParagraph:]):
2:18 PM Changeset in webkit [9514] by mjs
  • 2 edits
    3 adds in trunk/WebCore

* empty log message *

11:47 AM Changeset in webkit [9513] by justing
  • 2 edits in trunk/WebCore

Patch by Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Darin

Test cases added: None required

  • khtml/misc/decoder.cpp: (Decoder::setEncoding):
9:22 AM Changeset in webkit [9512] by harrison
  • 3 edits in trunk

Reviewed by Chris Blumenberg.

Test cases added: (NONE)

(continued) <rdar://problem/4140688> assertion failure double-clicking text to select
Fixed my checkin from yesterday.

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::positionForOffset): Changed tabs to spaces.

(RenderText::positionForCoordinates):
Make sure affinity is downstream when in mid-line.
Changed tabs to spaces.

(RenderText::caretRect):
(RenderText::cacheWidths):
(RenderText::trimmedMinMaxWidth):
(RenderText::minXPos):
(RenderText::width):
(RenderText::caretMaxOffset):
Changed tabs to spaces.

  • layout-tests/editing/style/create-block-for-style-004-expected.txt: Expected ending selection affinity is downstream.

Jun 27, 2005:

10:47 PM Changeset in webkit [9511] by mjs
  • 2 edits in trunk/WebCore

Remove accidentally committed code that breaks the build. Oops!

  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::expand): (DOM::AtomicString::shrink):
6:57 PM Changeset in webkit [9510] by mjs
  • 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Removed accidental change from last checkin.

6:54 PM Changeset in webkit [9509] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Darin.

  • replaced all our hash functions with the state of the art in hashing
  • ~1% speedup on cvs-base

No test cases added, perf effects only.

  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): Improved stats gathering to track collisions in more detail and count reinserts on remove. (DOM::addToCollisionCount): ditto (DOM::AtomicString::add): ditto (DOM::AtomicString::insert): ditto (DOM::AtomicString::remove): ditto
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::computeHash): Replace with SuperFastHash algorithm.
  • kwq/KWQCharsets.mm: (encodingNameHash): Clean up mistaken shift in the wrong direction.
  • kwq/KWQString.h: Removed unused hashing code.
  • kwq/KWQString.mm: ditto
  • kwq/KWQTextCodec.mm: (QTextCodec::hash): Use a variant of the SuperFastHash algorithm.
5:26 PM Changeset in webkit [9508]
  • 56 copies
    2 deletes in tags/WebCore-415~11~1

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11~1'.

5:26 PM Changeset in webkit [9507]
  • 83 copies in branches/Ti-2005-007-branch

This commit was manufactured by cvs2svn to create branch
'Ti-2005-007-branch'.

5:26 PM Changeset in webkit [9506]
  • 83 copies in tags/Ti-2005-007-anchor

This commit was manufactured by cvs2svn to create tag
'Ti-2005-007-anchor'.

5:26 PM Changeset in webkit [9505] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11.1

5:24 PM Changeset in webkit [9504]
  • 19 copies
    3 deletes in tags/WebKit-412~6~1

This commit was manufactured by cvs2svn to create tag
'WebKit-412~6~1'.

5:24 PM Changeset in webkit [9503] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6.1

5:20 PM Changeset in webkit [9502] by adele
  • 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155738> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error
5:02 PM Changeset in webkit [9501] by mjs
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.

  • replace hash functions with better ones
  • JavaScriptCore.pbproj/project.pbxproj: Add new file to build.
  • kjs/interpreter_map.cpp: (KJS::InterpreterMap::computeHash): Use shared pointer hash.
  • kjs/pointer_hash.h: Added. (KJS::pointerHash): Pointer hash based on 32-bit mix and 64-bit mix hashes.
  • kjs/protected_values.cpp: (KJS::ProtectedValues::computeHash): Use shared pointer hash.
  • kjs/ustring.cpp: (KJS::UString::Rep::computeHash): Use SuperFastHash algorithm.
4:54 PM Changeset in webkit [9500] by adele
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155736> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
4:51 PM Changeset in webkit [9499] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4162816> from TOT to Safari-2-0-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.
4:40 PM Changeset in webkit [9498] by adele
  • 2 edits in branches/Safari-1-3-branch/WebKit

2005-06-27 Adele Peterson <​adele@apple.com>

Merged fix for 4119282 from TOT to Safari-1-3-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
4:32 PM Changeset in webkit [9497] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Safari-1-3-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.
1:23 PM Changeset in webkit [9496] by justing
  • 2 edits in trunk/WebKit

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebView.subproj/WebView.m: (-[WebView setSelectedDOMRange:affinity:]): If range is nil, call deselectText.
1:10 PM Changeset in webkit [9495]
  • 4 copies
    2 deletes in tags/WebCore-315~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~0~1'.

1:10 PM Changeset in webkit [9494] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebCore

Versioning for Pan-2005-007-branch - WebCore-315.0.1

12:55 PM Changeset in webkit [9493]
  • 5 copies
    3 deletes in tags/WebKit-312~1~1

This commit was manufactured by cvs2svn to create tag
'WebKit-312~1~1'.

12:55 PM Changeset in webkit [9492] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebKit

Versioning for Pan-2005-007 - WebKit-312.1.1

12:53 PM Changeset in webkit [9491] by adele
  • 3 edits in branches/Pan-2005-007-branch/WebKit

Merged fix for 4119282 from TOT to Pan-2005-007-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
  • WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.
12:12 PM Changeset in webkit [9490] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken.

Test cases added: None because this relies on mouse clicking.

<rdar://problem/4140688> assertion failure double-clicking text to select

  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):

Use setAffinityUsingLinePosition.

11:48 AM Changeset in webkit [9489] by adele
  • 2 edits in branches/Pan-2005-007-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Pan-2005-007 branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

Jun 26, 2005:

10:33 PM Changeset in webkit [9488] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/build-dumprendertree: Pass -project option so that having a second copy of the project (like the one Xcode 2.1 offers to make for you) that's out of date won't screw you up.
  • Scripts/build-webkit: Ditto.

Jun 25, 2005:

10:21 AM Changeset in webkit [9487] by darin
  • 2 edits
    2 adds in trunk
  • updated a layout test so that it doesn't depend on a remote resource via http
  • layout-tests/fast/backgrounds/001.html: Change image URL to be relative.
  • layout-tests/fast/backgrounds/resources/bg_position_larger.gif: Added.
Note: See TracTimeline for information about the timeline view.