Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 1, 2005:

6:42 PM Changeset in webkit [9573] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164972> extra HTTP GET when iframe requests file already fetched by parent that should have been cached

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

• fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.

• khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag

6:39 PM Changeset in webkit [9572] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164976> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

• fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)

• khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string

6:32 PM Changeset in webkit [9571] by adele

• 22 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.

• WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog

• khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.

• khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.

• khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.

• khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.

• khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.

• kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
• kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.

• kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.

• kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.

• kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.

WebKit:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

• WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.

• WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.

• WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.

4:02 PM Changeset in webkit [9570] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164966> Crash will occur when double-clicking outerHTML link on W3 DOM test
<rdar://problem/4164988> support outerHTML on IMG elements

2005-05-09 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.

2005-04-20 Vicki Murley <​vicki@apple.com>

Reviewed by hyatt.

• fixed <rdar://problem/4065447> support outerHTML on IMG elements

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):

3:46 PM Changeset in webkit [9569] by adele

• 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164985> Not able to load additional script blocks dynamically

2005-05-04 Vicki Murley <​vicki@apple.com>

Reviewed by darin.

• fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

• khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
• khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):

3:36 PM Changeset in webkit [9568] by adele

• 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch.
<rdar://problem/4164922> Request for including an implementation of the elementFromPoint function

2005-04-12 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

• fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function

• khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
• khtml/dom/dom_doc.h:
• khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
• khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
• khtml/ecma/kjs_dom.lut.h: (KJS::):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
• khtml/xml/dom_docimpl.h:

3:12 PM Changeset in webkit [9567] by bdakin

• 1 edit
  3 adds in trunk

Adding createCaption test for HTMLTableElement.

Reviewed by Adele (sort of).

Test cases added:

• layout-tests/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
• layout-tests/fast/dom/HTMLTableElement/createCaption.html: Added.

2:30 PM Changeset in webkit [9566] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin Adler.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3711: Displayed PDF have limited options in contextual menu

This was a problem with using Tiger's version of Safari with tip of tree WebKit.

• WebView.subproj/WebPDFView.m: (-[WebPDFView _anyPDFTagsFoundInMenu:]): new method, returns YES if the menu contains any items with any of the new PDF-related tags. (-[WebPDFView menuForEvent:]): If the executable was linked on Tiger or older (but it will never be older, since this code is new to Tiger), force all of the PDF-related items into the menu if none of them were there after processing by the delegate.

2:14 PM Changeset in webkit [9565]

• 28 copies
  2 deletes in tags/WebCore-315~7

This commit was manufactured by cvs2svn to create tag
'WebCore-315~7'.

2:14 PM Changeset in webkit [9564] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.7

2:12 PM Changeset in webkit [9563] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4122332> from TOT to Safari-1-3-branch

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

• fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.

• khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag

2:07 PM Changeset in webkit [9562] by ggaren

• 1 edit
  14 adds
  4 deletes in trunk

Moving dom tests around to conform to new directory structure
specified in today's meeting.

Reviewed by justing.

Test cases added:

• layout-tests/fast/dom/HTMLDocument/title-get-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/title-get.html: Added.
• layout-tests/fast/dom/HTMLDocument/title-set-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/title-set.html: Added.
• layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/title/get.html: Removed.
• layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/title/set.html: Removed.
• layout-tests/fast/dom/HTMLDocument/url-getset-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/url-getset.html: Added.
• layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/url/getset.html: Removed.
• layout-tests/fast/dom/HTMLDocument/write-call-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/write-call.html: Added.
• layout-tests/fast/dom/HTMLDocument/write-multiple-calls-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/write-multiple-calls.html: Added.
• layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/write/call.html: Removed.
• layout-tests/fast/dom/HTMLDocument/write/multiple-calls-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/write/multiple-calls.html: Removed.
• layout-tests/fast/dom/HTMLDocument/writeln-call-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/writeln-call.html: Added.
• layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls.html: Added.
• layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/writeln/call.html: Removed.
• layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Removed.
• layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Removed.

1:07 PM Changeset in webkit [9561] by sullivan

• 3 edits in trunk/WebKitLibraries

• added WKExecutableLinkedInTigerOrEarlier

• WebKitSystemInterface.h:
• libWebKitSystemInterface.a:

11:56 AM Changeset in webkit [9560] by ggaren

• 5 edits in trunk

JavaScriptCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

• no layout test necessary yet - only groundwork

Reviewed by darin.

• kjs/lookup.h: (KJS::cacheGlobalObject):

WebCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

• no layout test necessary yet - only groundwork

Reviewed by darin.

• ForwardingHeaders/qintdict.h:
• khtml/ecma/kjs_binding.h:

11:45 AM Changeset in webkit [9559] by ggaren

• 6 edits in trunk

JavaScriptCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

-relevant tests:

mozilla/ecma_3/Date/15.9.5.5.js
layout-tests/fast/js/date-parse-test.html

Reviewed by darin.

• kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
• kjs/date_object.h:
• tests/mozilla/expected.html: updated expected results to reflect fix

WebCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477

-corrects errors in date layout test

Reviewed by darin.

Test cases modified:

• layout-tests/fast/js/date-parse-test.html:

10:47 AM Changeset in webkit [9558] by ggaren

• 3 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168186> JavaScript fails to throw exceptions
for invalid return statements

relevant tests:

ecma/Statements/12.9-1-n.js
ecma_2/Exceptions/lexical-052.js
ecma_2/Exceptions/statement-009.js

Reviewed by sullivan.

• kjs/nodes.cpp: (ReturnNode::execute): now throws exception if return is not inside a function.

• tests/mozilla/expected.html: updated to reflect fix

10:37 AM Changeset in webkit [9557] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by sullivan.

• tests/mozilla/expected.html: Updated test results for last fix.

10:19 AM Changeset in webkit [9556] by ggaren

• 2 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168161> JavaScript fails to throw an exception
for invalid function calls

Reviewed by sullivan.

Relevant mozilla test: ecma_3/Exceptions/regress-95101.js

• kjs/nodes.cpp: (FunctionCallNode::evaluate): evaluate now checks for an exception after resolving a function name (in case the function is undefined)

3:03 AM Changeset in webkit [9555] by eseidel

• 3 edits in trunk/WebCore

Bug #: 3669
Submitted by: eseidel
Reviewed by: darin

• kwq/KWQSize.h:
• kwq/KWQSize.mm: (QSize::operator CGSize): adding CGSize conversion support

2:55 AM Changeset in webkit [9554] by eseidel

• 3 edits in trunk/JavaScriptCore

Bug #: 3687
Submitted by: eseidel
Reviewed by: darin

• kjs/interpreter.h: (KJS::Context::curStmtFirstLine): stub for compatibility with KDE
• kjs/value.h: (KJS::Value::isValid): compatibility with KDE ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3687

2:48 AM Changeset in webkit [9553] by eseidel

• 2 edits in trunk/JavaScriptCore

Bug #: 3771
Submitted by: eseidel
Reviewed by: darin

• kjs/create_hash_table: rolled in changes from KDE, including -n <namespace> support from KDOM and support for newer comments ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3771

Jun 30, 2005:

10:20 PM Changeset in webkit [9552] by darin

• 14 edits
  6 deletes in trunk/WebKit

Reviewed by John Sullivan.

• fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3774> do renaming so that loaders are called "loader", not "client" or "delegate"

• Misc.subproj/WebIconLoader.h:
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:]): (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebBridge canRunModalNow]):
• WebCoreSupport.subproj/WebSubresourceClient.h: Removed.
• WebCoreSupport.subproj/WebSubresourceClient.m: Removed.
• WebCoreSupport.subproj/WebSubresourceLoader.h:
• WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader initWithLoader:dataSource:]): (-[WebSubresourceLoader dealloc]): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]): (-[WebSubresourceLoader didReceiveData:lengthReceived:]): (-[WebSubresourceLoader didFinishLoading]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.h: Removed.
• WebView.subproj/WebBaseResourceHandleDelegate.m: Removed.
• WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setLoading:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebLoader.h:
• WebView.subproj/WebLoader.m:
• WebView.subproj/WebMainResourceClient.h: Removed.
• WebView.subproj/WebMainResourceClient.m: Removed.
• WebView.subproj/WebMainResourceLoader.h:
• WebView.subproj/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveResponse:]):

5:45 PM Changeset in webkit [9551] by ggaren

• 4 edits in trunk/JavaScriptCore

-rolled in KDE fix to <rdar://problem/4167660> JavaScript fails to
throw exceptions for invalid break/continue statements

No layout tests because it's already covered by the Mozilla suite

Reviewed by mjs.

• kjs/internal.h: LabelStack now tracks where you are relative to switch and iteration (loop) statements

(KJS::LabelStack::LabelStack):
(KJS::LabelStack::pushIteration):
(KJS::LabelStack::popIteration):
(KJS::LabelStack::inIteration):
(KJS::LabelStack::pushSwitch):
(KJS::LabelStack::popSwitch):
(KJS::LabelStack::inSwitch):

• kjs/nodes.cpp: These files were updated to use the new LabelStack: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (SwitchNode::execute):

These files were updated to throw exceptions for invalid
break/continue statements:
(BreakNode::execute):
(ContinueNode::execute):

• tests/mozilla/expected.html: Updated expected results to reflect fix

4:18 PM Changeset in webkit [9550] by darin

• 3 edits in trunk/WebKitTools

Changes based on input from Michael Kahl.

• Scripts/cvs-create-patch: Use "-f" so we are compatible with .cvsrc files that specify different style of "diff".
• Scripts/webkitdirs.pm: Add missing call to determineBaseProductDir, so that determineConfigurationProductDir works in all cases.

11:19 AM Changeset in webkit [9549] by kdecker

• 2 edits in trunk/JavaScriptCore

Reviewed by rjw.

fixed: <rdar://problem/4166838> failed assertion in`Interpreter::lockCount() > 0

no layout test added; this is in the bindings code.

• bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): make sure to lock and unlock the interpreter around allocations.

10:50 AM Changeset in webkit [9548] by bdibello

• 1 edit
  4 adds in trunk

Reviewed by Geoff Garen.

Test cases added: getting and setting div.align

• layout-tests/fast/dom/HTMLDivElement/align/getset-expected.txt: Added.
• layout-tests/fast/dom/HTMLDivElement/align/getset.html: Added.

Jun 29, 2005:

10:57 PM Changeset in webkit [9547] by darin

• 2 adds in trunk/LayoutTests/fast/xsl/resources

Forgot one file.

10:57 PM Changeset in webkit [9546] by darin

• 3 edits
  4 adds in trunk

Reviewed and landed by Darin Adler.

• Fix <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3274> document() not supported

Test cases added:

• layout-tests/fast/xsl/document-function-expected.txt: Added.
• layout-tests/fast/xsl/document-function.xml: Added.
• layout-tests/fast/xsl/document-function.xsl: Added.
• layout-tests/fast/xsl/resources/document-function-source.xml: Added.

• khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc): Stub to prevent errors from getting written to the console.

(DOM::stylesheetLoadFunc):
Fetch and parse documents.

(DOM::XSLTProcessorImpl::transformDocument):
Use the processor as the global variable instead of the
style sheet.

• khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::stylesheet): (DOM::XSLTProcessorImpl::sourceDocument): Add accessors for source document and stylesheet.

10:41 PM Changeset in webkit [9545] by darin

• 2 edits in trunk/WebKitTools

• fixed bug which would result in multiple unwanted dumps in a single layout test

• DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): Set new "readyToDump" flag. (-[LayoutTestController waitUntilDone]): Update for name change. (-[LayoutTestController notifyDone]): Dump only if ready. (dumpRenderTree): Set up new boolean and update for name change.

9:33 PM Changeset in webkit [9544] by darin

• 3 edits
  1 add in trunk/WebKitTools

Changes by Timothy Hatcher.
Reviewed by me.

• Scripts/run-webkit-app: Added script to open an arbritrary application with a CVS built WebKit. Example: ./run-webkit-app Colloquy

• Scripts/gdb-safari: Added support for WEBKIT_SAFARI environment variable to specify a custom location to the Safari.app bundle. This is optional, script defaults to the stock location.
• Scripts/run-safari: Ditto.

8:19 PM Changeset in webkit [9543] by mjs

• 2 edits in trunk/WebCore

Unreviewed - fixing build breakage with gcc 4.

• khtml/misc/hashtable.h: Don't use a typedef when declaring a class friend.

6:56 PM Changeset in webkit [9542] by harrison

• 3 edits in trunk/WebCore

Temporarily enable tab coalescing ahead of white-space:pre-wrap
change because of problems with keeping the tabs separate. Will
revert when problems are fixed or remove if I do pre-wrap
first.

• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::insertTab):
• khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString):

6:28 PM Changeset in webkit [9541] by harrison

• 2 edits in trunk/WebKit

Reviewed by Dave Hyatt (rendering) and Maciej (editing).

Test cases added: Coming soon. Will include with next round of changes for this bug.

This is the first checkin for...

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.

• WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]): (initializeCharacterWidthIterator): (widthForNextCharacter):

6:27 PM Changeset in webkit [9540] by harrison

• 53 edits in trunk

Reviewed by Dave Hyatt (rendering) and Maciej (editing).

Test cases added: Coming soon. Will include with next round of changes for this bug.

This is the first checkin for...

<rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)

Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.

What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.

• khtml/editing/apply_style_command.cpp: (khtml::createStyleSpanElement): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
• khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState):
• khtml/editing/edit_command.cpp: (khtml::EditCommand::styleAtPosition):
• khtml/editing/html_interchange.h:
• khtml/editing/htmlediting.cpp: (khtml::isSpecialElement): (khtml::isTabSpanNode): (khtml::isTabSpanTextNode): (khtml::positionBeforeTabSpan): (khtml::createTabSpanElement):
• khtml/editing/htmlediting.h:
• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input): (khtml::InsertTextCommand::insertTab):
• khtml/editing/insert_text_command.h:
• khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
• khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::removeStyleNodes):
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::addPending): (khtml::HTMLTokenizer::write):
• khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::):
• khtml/rendering/bidi.cpp: (khtml::addRun): (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForTextOverflow):
• khtml/rendering/break_lines.cpp: (khtml::isBreakable):
• khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::checkSelectionPoint): (Font::width):
• khtml/rendering/font.h:
• khtml/rendering/render_block.cpp: (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth):
• khtml/rendering/render_block.h:
• khtml/rendering/render_br.h: (khtml::RenderBR::width):
• khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
• khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
• khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
• khtml/rendering/render_line.h: (khtml::InlineBox::width): (khtml::InlineBox::xPos): (khtml::InlineBox::yPos): (khtml::InlineBox::height): (khtml::InlineBox::baseline):
• khtml/rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
• khtml/rendering/render_object.cpp: (RenderObject::tabWidth): (RenderObject::recalcMinMaxWidths):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp:
• khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): (InlineTextBox::paint): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::textPos): (InlineTextBox::offsetForPosition): (InlineTextBox::positionForOffset): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace): (RenderText::width):
• khtml/rendering/render_text.h:
• kwq/KWQFontMetrics.h:
• kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::charWidth): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint): (QFontMetrics::boundingRect): (QFontMetrics::size):
• kwq/KWQPainter.h:
• kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
• kwq/WebCoreTextRenderer.h:
• kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle):
• layout-tests/editing/deleting/delete-tab-001-expected.txt:
• layout-tests/editing/deleting/delete-tab-001.html:
• layout-tests/editing/deleting/delete-tab-002-expected.txt:
• layout-tests/editing/deleting/delete-tab-002.html:
• layout-tests/editing/deleting/delete-tab-003-expected.txt:
• layout-tests/editing/deleting/delete-tab-003.html:
• layout-tests/editing/deleting/delete-tab-004-expected.txt:
• layout-tests/editing/deleting/delete-tab-004.html:
• layout-tests/editing/inserting/insert-tab-001-expected.txt:
• layout-tests/editing/inserting/insert-tab-002-expected.txt:
• layout-tests/editing/inserting/insert-tab-003-expected.txt:
• layout-tests/editing/inserting/insert-tab-004-expected.txt:
• layout-tests/fast/dom/quadraticCurveTo-expected.txt:
• layout-tests/fast/js/string-replace-2-expected.txt:
• layout-tests/fast/table/039-expected.txt:
• layout-tests/fast/table/border-collapsing/004-expected.txt:
• layout-tests/fast/tokenizer/script_extra_close-expected.txt:

6:19 PM Changeset in webkit [9539] by ggaren

• 4 edits
  6 adds in trunk

JavaScriptCore:

Patch by Francisco Tolmasky <​tolmasky@gmail.com>

• fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3667 Core JavaScript 1.5 Reference:Objects:Array:forEach

See WebCore Changelog for layout tests added.

Reviewed by darin.

• kjs/array_object.cpp: (ArrayProtoFuncImp::call):
• kjs/array_object.h: (KJS::ArrayProtoFuncImp::):

WebCore:

Contributed by Francisco Tolmasky <​tolmasky@gmail.com>

-test cases for fix to ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
Core JavaScript 1.5 Reference:Objects:Array:forEach

See JavaScriptCore Changelog for details on the patch.

Reviewed by darin.

Test cases added:

• layout-tests/fast/js/array-every-expected.txt: Added.
• layout-tests/fast/js/array-every.html: Added.
• layout-tests/fast/js/array-foreach-expected.txt: Added.
• layout-tests/fast/js/array-foreach.html: Added.
• layout-tests/fast/js/array-some-expected.txt: Added.
• layout-tests/fast/js/array-some.html: Added.

5:41 PM Changeset in webkit [9538] by bdibello

• 1 edit
  1 add in trunk

Reviewed by Geoff Garen

Test cases added: added expected results for previous check in

• layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Added.

5:22 PM Changeset in webkit [9537] by ggaren

• 1 edit
  5 adds in trunk

DOM compatibility tests for HTMLDocument::writeln

Reviewed by justing.

Test cases added:

• layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/writeln/call.html: Added.
• layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Added.

5:19 PM Changeset in webkit [9536] by ggaren

• 2 edits
  2 adds in trunk

Reviewed by Geoff Garen.

Test cases added: added DOM test for document.URL

• layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.

5:13 PM Changeset in webkit [9535] by bdibello

• 1 edit
  2 adds in trunk

Reviewed by Geoff Garen.

Test cases added: added DOM test for document.URL

• layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.

4:24 PM Changeset in webkit [9534] by ggaren

• 1 edit
  3 adds in trunk

DOM compatibility test for HTMLDocument::write

Reviewed by justing.

Test cases added:

• layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/write/call.html: Added.

4:12 PM Changeset in webkit [9533] by ggaren

• 3 edits
  2 adds in trunk

DOM compatibility tests for HTMLDocument::title

Reviewed by justing.

Test cases added:

• layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
• layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Added.
• layout-tests/fast/dom/HTMLDocument/title/set.html: Added.

4:01 PM Changeset in webkit [9532] by ggaren

• 1 edit
  4 adds in trunk

DOM compatibility tests for HTMLDocument::title

Reviewed by justing.

Test cases added:

• layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
• layout-tests/fast/dom/HTMLDocument/title/set.html: Added.

3:53 PM Changeset in webkit [9531] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Kevin.

• deleted some never-used stub code

• WebView.subproj/WebView.m:
• WebView.subproj/WebViewInternal.h:
• WebView.subproj/WebViewPrivate.h:

2:37 PM Changeset in webkit [9530] by justing

• 3 adds
  1 delete in trunk/LayoutTests/fast/dom/HTMLObjectElement

* empty log message *

2:29 PM Changeset in webkit [9529] by justing

• 4 adds in trunk/LayoutTests/fast/dom/HTMLLabelElement

* empty log message *

2:22 PM Changeset in webkit [9528] by justing

• 1 delete in trunk/LayoutTests/fast/dom/HTMLLabelElement

* empty log message *

2:04 PM Changeset in webkit [9527] by mjs

• 4 edits in trunk/WebCore

Reviewed by Darin.

Added iterator support to new hashtable class, the HashSet API is
now essentially complete.

Added support for consistency check mode.

• khtml/misc/hashset.h: (khtml::HashSet::capacity): Added (khtml::HashSet::begin): Added (both const and non-const) (khtml::HashSet::end): Added (both const and non-const) (khtml::HashSet::insert): Made both versions return an iterator (khtml::HashSet::find): Added (both const and on-const, returning appropriate iterator) (khtml::HashSet::contains): Added (khtml::HashSet::remove): Added version that takes an iterator argument (khtml::HashSet::clear): Added
• khtml/misc/hashtable.h: (khtml::HashTableIterator): New class with all the obvious iterator stuff. (khtml::HashTableConstIterator::HashTableConstIterator): New class with all the obvious const iterator stuff. (khtml::HashTable::begin): Added (both const and non-consts) (khtml::HashTable::end): Added (both const and non-consts) (khtml::HashTable::capacity): Added (khtml::HashTable::insert): Implement non-template method in terms of template method. (khtml::HashTable::contains): Added (implemented in terms of find) (khtml::HashTable::remove): Implemented key remove in terms of find and iterator remove. (khtml::HashTable::hash): Made static (khtml::HashTable::equal): Made static (khtml::HashTable::identityConvert): Added - no-op convert method so template insert method can be implemented in terms of non-template (khtml::HashTable::insert): Changed to return iterator (khtml::HashTable::reinsert): Recoded to be more like the other functions (khtml::HashTable::find): Added (khtml::HashTable::remove): Added iterator version (khtml::HashTable::clear): Added
• khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): Updated to deal with the fact that insert returns an iterator (khtml::HashTable::shouldExpand): New helper. (khtml::HashTable::shouldShrink): ditto (khtml::HashTable::makeIterator): ditto (khtml::HashTable::makeConstIterator): ditto (khtml::HashTable::checkConsistency): consistency check method (khtml::HashTable::checkConsistencyExceptSize): consistency check method

1:59 PM Changeset in webkit [9526] by ggaren

• 3 edits
  2 adds in trunk

JavaScriptCore:

Patch contributed by Oliver Hunt <​ojh16@student.canterbury.ac.nz>

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls

See WebCore Changelog for layout test added.

Reviewed by mjs.

• kjs/object.cpp: (KJS::ObjectImp::defaultValue):

WebCore:

-added test case for fix to ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls

See JavaScriptCore Changelog for details about the patch.

Reviewed by me.

Test cases added:

• layout-tests/fast/js/toString-stack-overflow-expected.txt: Added.
• layout-tests/fast/js/toString-stack-overflow.html: Added.

1:15 PM Changeset in webkit [9525] by ggaren

• 4 edits in trunk/JavaScriptCore

Rolling out date patch from 6-28-05 because it breaks
fast/js/date-parse-test

Reviewed by NOBODY.

• kjs/date_object.cpp: (formatLocaleDate): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (isSpaceOrTab): (KJS::KRFCDate_parseDate):
• kjs/date_object.h:
• tests/mozilla/expected.html:

1:14 PM Changeset in webkit [9524] by justing

• 2 edits
  8 adds in trunk

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3714> HTMLLabelElement's form property isn't implemented

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin

Test cases added:

• layout-tests/fast/dom/HTMLLabelElement/properties/form-expected.txt: Added.
• layout-tests/fast/dom/HTMLLabelElement/properties/form.html: Added.

• khtml/html/html_formimpl.cpp: (DOM::HTMLLabelElementImpl::form): Traverse upwards looking for a form element.

11:49 AM Changeset in webkit [9523] by justing

• 2 deletes in trunk/LayoutTests/fast/dom

Bug #:
Submitted by:
Reviewed by:

10:52 AM Changeset in webkit [9522] by ggaren

• 1 edit
  2 adds in trunk

Patch by Joost de Valk <​webkit@joostdevalk.nl>

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3732 Testcase for accesskeys that will run with run-webkit-tests.

Reviewed by Darin.

Test cases added:

• layout-tests/fast/forms/access-key-expected.txt: Added.
• layout-tests/fast/forms/access-key.html: Added.

10:50 AM Changeset in webkit [9521] by justing

• 2 edits
  2 adds in trunk

Patch by Anders Carlsson <​andersca@mac.com>

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3715> An HTMLObjectElement's form property was always null.

Reviewed by Darin

Test cases added:

• layout-tests/fast/dom/htmlobject-form-expected.txt: Added.
• layout-tests/fast/dom/htmlobject-form.html: Added.

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::form): Implement this function by traversing the parent nodes looking for a form element.

10:41 AM Changeset in webkit [9520] by ggaren

• 2 edits
  2 adds in trunk

Patch by Antoine Quint <​ml@graougraou.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3648
quadraticCurveTo() method in <canvas> APIs JS bindings does not exist

Reviewed by Darin.

Test cases added:

• layout-tests/fast/dom/quadraticCurveTo-expected.txt: Added.
• layout-tests/fast/dom/quadraticCurveTo.xml: Added.

• khtml/ecma/kjs_html.cpp:

10:18 AM Changeset in webkit [9519] by ggaren

• 2 edits
  2 adds in trunk

Patch by Hanspeter Schaub <​Hanspeterschaub@mac.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3317
REGRESSION: CSS2: outline is applied to both <li> element
and its enclosing text with context dependent selector

Reviewed by Hyatt.

Test cases added:

• layout-tests/fast/css/list-outline-expected.txt: Added.
• layout-tests/fast/css/list-outline.html: Added.

• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint):

9:32 AM Changeset in webkit [9518] by ggaren

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3750
build fails with KJS_VERBOSE set

• kjs/nodes.cpp: changed debug print statement to use UString (VarDeclNode::evaluate):
• kjs/reference.cpp: ditto (KJS::Reference::putValue):

Jun 28, 2005:

4:22 PM Changeset in webkit [9517] by vicki

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.

• khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag

3:25 PM Changeset in webkit [9516] by ggaren

• 4 edits in trunk/JavaScriptCore

Patch contributed by Carsten Guenther <​cguenther@gmail.com>.

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

Reviewed by darin.

• kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
• kjs/date_object.h:
• tests/mozilla/expected.html: updated expected test results to reflect fix

3:18 PM Changeset in webkit [9515] by justing

• 2 edits
  2 adds in trunk

Patch by Kevin Ballard <Lily Ballard>

Reviewed by Darin

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3654> Updating the value of a textarea wasn't saving the cursor position in a line ending-agnostic fashion.

Test cases added:

• layout-tests/fast/forms/cursor-position-expected.txt: Added.
• layout-tests/fast/forms/cursor-position.html: Added.

• kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextArea setCursorPositionToIndex:inParagraph:]):

2:18 PM Changeset in webkit [9514] by mjs

• 2 edits
  3 adds in trunk/WebCore

* empty log message *

11:47 AM Changeset in webkit [9513] by justing

• 2 edits in trunk/WebCore

Patch by Alexey Proskuryakov <​ap@nypop.com>

• <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3727> When a DECODE_DEBUG preprocessor symbol is defined in khtml/misc/decoder.cpp, compilation fails because a non-existent variable "force" is used.

Reviewed by Darin

Test cases added: None required

• khtml/misc/decoder.cpp: (Decoder::setEncoding):

9:22 AM Changeset in webkit [9512] by harrison

• 3 edits in trunk

Reviewed by Chris Blumenberg.

Test cases added: (NONE)

(continued) <rdar://problem/4140688> assertion failure double-clicking text to select
Fixed my checkin from yesterday.

• khtml/rendering/render_text.cpp: (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::positionForOffset): Changed tabs to spaces.

(RenderText::positionForCoordinates):
Make sure affinity is downstream when in mid-line.
Changed tabs to spaces.

(RenderText::caretRect):
(RenderText::cacheWidths):
(RenderText::trimmedMinMaxWidth):
(RenderText::minXPos):
(RenderText::width):
(RenderText::caretMaxOffset):
Changed tabs to spaces.

• layout-tests/editing/style/create-block-for-style-004-expected.txt: Expected ending selection affinity is downstream.

Jun 27, 2005:

10:47 PM Changeset in webkit [9511] by mjs

• 2 edits in trunk/WebCore

Remove accidentally committed code that breaks the build. Oops!

• khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::expand): (DOM::AtomicString::shrink):

6:57 PM Changeset in webkit [9510] by mjs

• 1 edit in trunk/WebCore/WebCore.pbproj/project.pbxproj

Removed accidental change from last checkin.

6:54 PM Changeset in webkit [9509] by mjs

• 9 edits in trunk/WebCore

Reviewed by Darin.

• replaced all our hash functions with the state of the art in hashing
• ~1% speedup on cvs-base

No test cases added, perf effects only.

• khtml/xml/dom_atomicstring.cpp: (DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger): Improved stats gathering to track collisions in more detail and count reinserts on remove. (DOM::addToCollisionCount): ditto (DOM::AtomicString::add): ditto (DOM::AtomicString::insert): ditto (DOM::AtomicString::remove): ditto
• khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::computeHash): Replace with SuperFastHash algorithm.
• kwq/KWQCharsets.mm: (encodingNameHash): Clean up mistaken shift in the wrong direction.
• kwq/KWQString.h: Removed unused hashing code.
• kwq/KWQString.mm: ditto
• kwq/KWQTextCodec.mm: (QTextCodec::hash): Use a variant of the SuperFastHash algorithm.

5:26 PM Changeset in webkit [9508]

• 56 copies
  2 deletes in tags/WebCore-415~11~1

This commit was manufactured by cvs2svn to create tag
'WebCore-415~11~1'.

5:26 PM Changeset in webkit [9507]

• 83 copies in branches/Ti-2005-007-branch

This commit was manufactured by cvs2svn to create branch
'Ti-2005-007-branch'.

5:26 PM Changeset in webkit [9506]

• 83 copies in tags/Ti-2005-007-anchor

This commit was manufactured by cvs2svn to create tag
'Ti-2005-007-anchor'.

5:26 PM Changeset in webkit [9505] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.11.1

5:24 PM Changeset in webkit [9504]

• 19 copies
  3 deletes in tags/WebKit-412~6~1

This commit was manufactured by cvs2svn to create tag
'WebKit-412~6~1'.

5:24 PM Changeset in webkit [9503] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.6.1

5:20 PM Changeset in webkit [9502] by adele

• 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155738> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error

5:02 PM Changeset in webkit [9501] by mjs

• 4 edits
  1 add in trunk/JavaScriptCore

Reviewed by Darin.

• replace hash functions with better ones

• JavaScriptCore.pbproj/project.pbxproj: Add new file to build.
• kjs/interpreter_map.cpp: (KJS::InterpreterMap::computeHash): Use shared pointer hash.
• kjs/pointer_hash.h: Added. (KJS::pointerHash): Pointer hash based on 32-bit mix and 64-bit mix hashes.
• kjs/protected_values.cpp: (KJS::ProtectedValues::computeHash): Use shared pointer hash.
• kjs/ustring.cpp: (KJS::UString::Rep::computeHash): Use SuperFastHash algorithm.

4:54 PM Changeset in webkit [9500] by adele

• 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4155736> from TOT to Safari-2-0-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.

4:51 PM Changeset in webkit [9499] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4162816> from TOT to Safari-2-0-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

• fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)

• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

4:40 PM Changeset in webkit [9498] by adele

• 2 edits in branches/Safari-1-3-branch/WebKit

2005-06-27 Adele Peterson <​adele@apple.com>

Merged fix for 4119282 from TOT to Safari-1-3-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.

4:32 PM Changeset in webkit [9497] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Safari-1-3-branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

• fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)

• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

1:23 PM Changeset in webkit [9496] by justing

• 2 edits in trunk/WebKit

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3489> WebView's setSelectedDOMRange doesn't not implement clearing the selection as described in the WebView documentation: <​http://developer.apple.com/documentation/Cocoa/Reference/WebKit/ObjC_classic/Classes/WebView.html>

• WebView.subproj/WebView.m: (-[WebView setSelectedDOMRange:affinity:]): If range is nil, call deselectText.

1:10 PM Changeset in webkit [9495]

• 4 copies
  2 deletes in tags/WebCore-315~0~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~0~1'.

1:10 PM Changeset in webkit [9494] by adele

• 2 edits in branches/Pan-2005-007-branch/WebCore

Versioning for Pan-2005-007-branch - WebCore-315.0.1

12:55 PM Changeset in webkit [9493]

• 5 copies
  3 deletes in tags/WebKit-312~1~1

This commit was manufactured by cvs2svn to create tag
'WebKit-312~1~1'.

12:55 PM Changeset in webkit [9492] by adele

• 2 edits in branches/Pan-2005-007-branch/WebKit

Versioning for Pan-2005-007 - WebKit-312.1.1

12:53 PM Changeset in webkit [9491] by adele

• 3 edits in branches/Pan-2005-007-branch/WebKit

Merged fix for 4119282 from TOT to Pan-2005-007-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.

12:12 PM Changeset in webkit [9490] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken.

Test cases added: None because this relies on mouse clicking.

<rdar://problem/4140688> assertion failure double-clicking text to select

• khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):

Use setAffinityUsingLinePosition.

11:48 AM Changeset in webkit [9489] by adele

• 2 edits in branches/Pan-2005-007-branch/WebCore

Merged fix for <rdar://problem/4125212> from TOT to Pan-2005-007 branch

2005-05-27 Darin Adler <Darin Adler>

Reviewed by Vicki.

• fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)

• khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.