Timeline



Jul 4, 2005:

6:11 AM Changeset in webkit [9583] by mjs
  • 1 edit
    2 adds in trunk

Expected results for layout tests from last patch.

  • layout-tests/fast/js/eval-var-decl-expected.txt: Added.
  • layout-tests/fast/js/has-own-property-expected.txt: Added.

Jul 3, 2005:

3:47 AM Changeset in webkit [9582] by mjs
  • 28 edits
    2 adds in trunk

JavaScriptCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • tests/mozilla/expected.html: Two tests newly pass.
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasOwnProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasOwnProperty): (KJS::ActivationImp::hasOwnProperty):
  • kjs/function.h:
  • kjs/lookup.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty): (KJS::ObjectImp::hasOwnProperty):
  • kjs/object.h: (KJS::Object::hasOwnProperty):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasOwnProperty):
  • kjs/string_object.h:

WebCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/js/has-own-property.html: Added - tests this change.
  • layout-tests/fast/js/eval-var-decl.html: Added - test depends on this change.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMElement::tryGet): (KJS::DOMNamedNodeMap::hasOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
  • khtml/ecma/kjs_window.h:
3:13 AM Changeset in webkit [9581] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3825
Submitted by: eseidel
Reviewed by: mjs

3:05 AM Changeset in webkit [9580] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3823
Submitted by: eseidel
Reviewed by: mjs

2:58 AM Changeset in webkit [9579] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 3832
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQValueList.h: (QValueList::find): KDOM support (QValueList::constBegin): KDE compatibility (QValueList::constEnd): KDE compatibility
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::findEqualNode): KDOM support ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3832
2:51 AM Changeset in webkit [9578] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3827
Submitted by: eseidel
Reviewed by: mjs

2:45 AM Changeset in webkit [9577] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3831
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::findRef): Added to support KDOM::NodeImpl::compareDocumentPosition(NodeImpl *other)
2:38 AM Changeset in webkit [9576] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3830
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/qintdict.h: maps to KWQIntDict.h
  • kwq/KWQIntDict.h: copy of KWQPtrDict.h replacing T * with int.
12:08 AM Changeset in webkit [9575] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPair.h: added newline, per mjs's request.
12:03 AM Changeset in webkit [9574] by eseidel
  • 1 edit
    2 adds in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

Jul 1, 2005:

6:42 PM Changeset in webkit [9573] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164972> extra HTTP GET when iframe requests file already fetched by parent that should have been cached

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
6:39 PM Changeset in webkit [9572] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164976> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
6:32 PM Changeset in webkit [9571] by adele
  • 22 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.

  • WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
  • khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
  • khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
  • khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
  • kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
  • kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
  • kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
  • kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.

WebKit:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
  • WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.
4:02 PM Changeset in webkit [9570] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164966> Crash will occur when double-clicking outerHTML link on W3 DOM test
<rdar://problem/4164988> support outerHTML on IMG elements

2005-05-09 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.

2005-04-20 Vicki Murley <​vicki@apple.com>

Reviewed by hyatt.

  • fixed <rdar://problem/4065447> support outerHTML on IMG elements
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
3:46 PM Changeset in webkit [9569] by adele
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164985> Not able to load additional script blocks dynamically

2005-05-04 Vicki Murley <​vicki@apple.com>

Reviewed by darin.

  • fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
  • khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
3:36 PM Changeset in webkit [9568] by adele
  • 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch.
<rdar://problem/4164922> Request for including an implementation of the elementFromPoint function

2005-04-12 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function
  • khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
  • khtml/xml/dom_docimpl.h:
3:12 PM Changeset in webkit [9567] by bdakin
  • 1 edit
    3 adds in trunk

Adding createCaption test for HTMLTableElement.

Reviewed by Adele (sort of).

Test cases added:

  • layout-tests/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • layout-tests/fast/dom/HTMLTableElement/createCaption.html: Added.
2:30 PM Changeset in webkit [9566] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

This was a problem with using Tiger's version of Safari with tip of tree WebKit.

  • WebView.subproj/WebPDFView.m: (-[WebPDFView _anyPDFTagsFoundInMenu:]): new method, returns YES if the menu contains any items with any of the new PDF-related tags. (-[WebPDFView menuForEvent:]): If the executable was linked on Tiger or older (but it will never be older, since this code is new to Tiger), force all of the PDF-related items into the menu if none of them were there after processing by the delegate.
2:14 PM Changeset in webkit [9565]
  • 28 copies
    2 deletes in tags/WebCore-315~7

This commit was manufactured by cvs2svn to create tag
'WebCore-315~7'.

2:14 PM Changeset in webkit [9564] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.7

2:12 PM Changeset in webkit [9563] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4122332> from TOT to Safari-1-3-branch

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
2:07 PM Changeset in webkit [9562] by ggaren
  • 1 edit
    14 adds
    4 deletes in trunk

Moving dom tests around to conform to new directory structure
specified in today's meeting.

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/title-get-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title-get.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title-set-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title-set.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/get.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/set.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/url-getset-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/url-getset.html: Added.
  • layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/url/getset.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/write-call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/write-call.html: Added.
  • layout-tests/fast/dom/HTMLDocument/write-multiple-calls-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/write-multiple-calls.html: Added.
  • layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/call.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/multiple-calls-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/multiple-calls.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln-call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-call.html: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls.html: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/call.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Removed.
1:07 PM Changeset in webkit [9561] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • added WKExecutableLinkedInTigerOrEarlier
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
11:56 AM Changeset in webkit [9560] by ggaren
  • 5 edits in trunk

JavaScriptCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

  • no layout test necessary yet - only groundwork

Reviewed by darin.

  • kjs/lookup.h: (KJS::cacheGlobalObject):

WebCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

  • no layout test necessary yet - only groundwork

Reviewed by darin.

  • ForwardingHeaders/qintdict.h:
  • khtml/ecma/kjs_binding.h:
11:45 AM Changeset in webkit [9559] by ggaren
  • 6 edits in trunk

JavaScriptCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

-relevant tests:

mozilla/ecma_3/Date/15.9.5.5.js
layout-tests/fast/js/date-parse-test.html

Reviewed by darin.

  • kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
  • kjs/date_object.h:
  • tests/mozilla/expected.html: updated expected results to reflect fix

WebCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477

-corrects errors in date layout test

Reviewed by darin.

Test cases modified:

  • layout-tests/fast/js/date-parse-test.html:
10:47 AM Changeset in webkit [9558] by ggaren
  • 3 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168186> JavaScript fails to throw exceptions
for invalid return statements

relevant tests:

ecma/Statements/12.9-1-n.js
ecma_2/Exceptions/lexical-052.js
ecma_2/Exceptions/statement-009.js

Reviewed by sullivan.

  • kjs/nodes.cpp: (ReturnNode::execute): now throws exception if return is not inside a function.
  • tests/mozilla/expected.html: updated to reflect fix
10:37 AM Changeset in webkit [9557] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by sullivan.

  • tests/mozilla/expected.html: Updated test results for last fix.
10:19 AM Changeset in webkit [9556] by ggaren
  • 2 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168161> JavaScript fails to throw an exception
for invalid function calls

Reviewed by sullivan.

Relevant mozilla test: ecma_3/Exceptions/regress-95101.js

  • kjs/nodes.cpp: (FunctionCallNode::evaluate): evaluate now checks for an exception after resolving a function name (in case the function is undefined)
3:03 AM Changeset in webkit [9555] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3669
Submitted by: eseidel
Reviewed by: darin

  • kwq/KWQSize.h:
  • kwq/KWQSize.mm: (QSize::operator CGSize): adding CGSize conversion support
2:55 AM Changeset in webkit [9554] by eseidel
  • 3 edits in trunk/JavaScriptCore

Bug #: 3687
Submitted by: eseidel
Reviewed by: darin

2:48 AM Changeset in webkit [9553] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 3771
Submitted by: eseidel
Reviewed by: darin

Jun 30, 2005:

10:20 PM Changeset in webkit [9552] by darin
  • 14 edits
    6 deletes in trunk/WebKit

Reviewed by John Sullivan.

  • Misc.subproj/WebIconLoader.h:
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:]): (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebBridge canRunModalNow]):
  • WebCoreSupport.subproj/WebSubresourceClient.h: Removed.
  • WebCoreSupport.subproj/WebSubresourceClient.m: Removed.
  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader initWithLoader:dataSource:]): (-[WebSubresourceLoader dealloc]): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]): (-[WebSubresourceLoader didReceiveData:lengthReceived:]): (-[WebSubresourceLoader didFinishLoading]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Removed.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: Removed.
  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setLoading:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m:
  • WebView.subproj/WebMainResourceClient.h: Removed.
  • WebView.subproj/WebMainResourceClient.m: Removed.
  • WebView.subproj/WebMainResourceLoader.h:
  • WebView.subproj/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveResponse:]):
5:45 PM Changeset in webkit [9551] by ggaren
  • 4 edits in trunk/JavaScriptCore

-rolled in KDE fix to <rdar://problem/4167660> JavaScript fails to
throw exceptions for invalid break/continue statements

No layout tests because it's already covered by the Mozilla suite

Reviewed by mjs.

  • kjs/internal.h: LabelStack now tracks where you are relative to switch and iteration (loop) statements

(KJS::LabelStack::LabelStack):
(KJS::LabelStack::pushIteration):
(KJS::LabelStack::popIteration):
(KJS::LabelStack::inIteration):
(KJS::LabelStack::pushSwitch):
(KJS::LabelStack::popSwitch):
(KJS::LabelStack::inSwitch):

  • kjs/nodes.cpp: These files were updated to use the new LabelStack: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): (ForInNode::execute): (SwitchNode::execute):

These files were updated to throw exceptions for invalid
break/continue statements:
(BreakNode::execute):
(ContinueNode::execute):

  • tests/mozilla/expected.html: Updated expected results to reflect fix
4:18 PM Changeset in webkit [9550] by darin
  • 3 edits in trunk/WebKitTools

Changes based on input from Michael Kahl.

  • Scripts/cvs-create-patch: Use "-f" so we are compatible with .cvsrc files that specify different style of "diff".
  • Scripts/webkitdirs.pm: Add missing call to determineBaseProductDir, so that determineConfigurationProductDir works in all cases.
11:19 AM Changeset in webkit [9549] by kdecker
  • 2 edits in trunk/JavaScriptCore

Reviewed by rjw.

fixed: <rdar://problem/4166838> failed assertion in`Interpreter::lockCount() > 0

no layout test added; this is in the bindings code.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): make sure to lock and unlock the interpreter around allocations.
10:50 AM Changeset in webkit [9548] by bdibello
  • 1 edit
    4 adds in trunk

Reviewed by Geoff Garen.

Test cases added: getting and setting div.align

  • layout-tests/fast/dom/HTMLDivElement/align/getset-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDivElement/align/getset.html: Added.
Note: See TracTimeline for information about the timeline view.