Timeline



Jul 5, 2005:

11:23 PM Changeset in webkit [9599] by mjs
  • 1 edit
    1 add in trunk/WebCore

Forgot to commit a file. Fix for build breakage.

  • ForwardingHeaders/misc/pointerhash.h: Added.
8:30 PM Changeset in webkit [9598] by mjs
  • 2 edits in trunk/WebCore
  • remove stat dumping (accidentally left enabled in last patch)

Unreviewed since this was a mistake in the last checkin.

  • khtml/misc/hashtable.h:
6:28 PM Changeset in webkit [9597] by mjs
  • 9 edits
    6 adds in trunk/WebCore

Reviewed by hyatt.

Numerous hash code improvements:

  • added HashMap and the required support for it in HashTable
  • convert to using deleted sentinels and double hashing instead of linear probing and reinsert on delete
  • add support for traits so that empty and deleted values can be customized per type
  • make insert return a pair of an iterator and a bool even at the API level
  • converted some code to use HashMap
  • added standard hash and equal functions for some types, plus case insensitive ones
  • lots of assorted code cleanup
  • pass hash functions as classes with two static functions instead of as functions
  • khtml/css/cssstyleselector.cpp: (khtml::CSSRuleSet::CSSRuleSet): Use HashMap instead of QPtrDict. (khtml::CSSRuleSet::~CSSRuleSet): ditto (khtml::CSSRuleSet::addToRuleSet): ditto (khtml::CSSRuleSet::addRule): ditto
  • khtml/css/cssstyleselector.h: (khtml::CSSRuleSet::getIDRules): ditto (khtml::CSSRuleSet::getClassRules): ditto (khtml::CSSRuleSet::getTagRules): ditto
  • khtml/editing/jsediting.cpp: (DOM::DocumentImpl::commandImp): ditto
  • khtml/misc/hashfunctions.h: Added. Standard hash functions. (khtml::defaultEqual): (khtml::pointerHash<4>): (khtml::pointerHash<8>): (khtml::defaultHash<void *>): (khtml::defaultHash<DOM::DOMStringImpl *>): (khtml::caseInsensitiveHash): (khtml::caseInsensitiveEqual):
  • WebCore.pbproj/project.pbxproj:
  • khtml/misc/hashmap.h: Added. (khtml::HashMap::HashMap): (khtml::HashMap::size): (khtml::HashMap::capacity): (khtml::HashMap::isEmpty): (khtml::HashMap::begin): (khtml::HashMap::end): (khtml::HashMap::find): (khtml::HashMap::contains): (khtml::HashMap::insert): (khtml::HashMap::get): (khtml::HashMap::remove): (khtml::HashMap::clear): (khtml::HashMap::extractKey):
  • khtml/misc/hashset.h: (khtml::identityExtract): (khtml::::size): (khtml::::capacity): (khtml::::isEmpty): (khtml::::begin): (khtml::::end): (khtml::::find): (khtml::::contains): (khtml::::insert): (khtml::::remove): (khtml::::clear): (khtml::::convertAdapter):
  • khtml/misc/hashtable.cpp: (khtml::HashTableStats::~HashTableStats):
  • khtml/misc/hashtable.h: (khtml::HashTableIterator::HashTableIterator): (khtml::HashTableIterator::skipEmptyBuckets): (khtml::HashTableConstIterator::HashTableConstIterator): (khtml::HashTableConstIterator::skipEmptyBuckets): (khtml::HashTable::HashTable): (khtml::HashTable::insert): (khtml::HashTable::isEmptyBucket): (khtml::HashTable::isDeletedBucket): (khtml::HashTable::isEmptyOrDeletedBucket): (khtml::HashTable::identityConvert): (khtml::HashTable::extractKey): (khtml::HashTable::lookup): (khtml::HashTable::shouldExpand): (khtml::HashTable::mustRehashInPlace): (khtml::HashTable::clearBucket): (khtml::HashTable::deleteBucket): (khtml::HashTable::makeLookupResult): (khtml::HashTable::makeIterator): (khtml::HashTable::makeConstIterator): (khtml::::lookup): (khtml::::insert): (khtml::::reinsert): (khtml::::find): (khtml::::contains): (khtml::::remove): (khtml::::allocateTable): (khtml::::expand): (khtml::::rehash): (khtml::::clear): (khtml::::HashTable): (khtml::::swap): (khtml::::operator): (khtml::::checkConsistency): (khtml::::checkConsistencyExceptSize):
  • khtml/misc/hashtraits.h: Added. (khtml::HashTraits::emptyValue): (khtml::): (khtml::PairHashTraits::emptyValue): (khtml::PairHashTraits::deletedValue):
  • ForwardingHeaders/misc/hashmap.h: Added.
  • ForwardingHeaders/misc/hashset.h: Added.
  • WebCore.pbproj/project.pbxproj: Added new files.
  • khtml/misc/pointerhash.h: Added. (khtml::PointerHashIteratorAdapter::PointerHashIteratorAdapter): (khtml::PointerHashIteratorAdapter::operator*): (khtml::PointerHashIteratorAdapter::operator->): (khtml::PointerHashIteratorAdapter::operator++): (khtml::PointerHashIteratorAdapter::operator==): (khtml::PointerHashIteratorAdapter::operator!=): (khtml::PointerHashConstIteratorAdapter::PointerHashConstIteratorAdapter): (khtml::PointerHashConstIteratorAdapter::operator*): (khtml::PointerHashConstIteratorAdapter::operator->): (khtml::PointerHashConstIteratorAdapter::operator++): (khtml::PointerHashConstIteratorAdapter::operator==): (khtml::PointerHashConstIteratorAdapter::operator!=): (khtml::):
5:21 PM Changeset in webkit [9596] by ggaren
  • 27 edits in trunk

Rolled in patch by ​opendarwin.org@mitzpettel.com

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3733
Incorrect bidi layout of ETs, ANs, and ENs in some contexts

Reviewed by hyatt.

  • khtml/rendering/bidi.cpp: (khtml::appendRun): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):

Modified test results to account for run splitting.
This is a known bug that we need to fix separately:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3838

  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt:
  • layout-tests/fast/block/basic/018-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/invalid/nestedh3s-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/lists/003-expected.txt:
  • layout-tests/fast/selectors/166-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/text/basic/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:
4:21 PM Changeset in webkit [9595] by adele
  • 55 edits in trunk

WebCore:

Rolling out changes for <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
since it caused a 2% performance regression.

  • khtml/editing/apply_style_command.cpp: (khtml::createStyleSpanElement): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState):
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::styleAtPosition):
  • khtml/editing/html_interchange.h:
  • khtml/editing/htmlediting.cpp: (khtml::isSpecialElement):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createFragmentFromText):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::removeStyleNodes):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::addPending): (khtml::HTMLTokenizer::write):
  • khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::):
  • khtml/rendering/bidi.cpp: (khtml::addRun): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::checkSelectionPoint): (Font::width):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_br.h: (khtml::RenderBR::width):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_line.h: (khtml::InlineBox::width): (khtml::InlineBox::xPos): (khtml::InlineBox::yPos): (khtml::InlineBox::height): (khtml::InlineBox::baseline):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • khtml/rendering/render_object.cpp: (RenderObject::recalcMinMaxWidths):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): (InlineTextBox::paint): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::offsetForPosition): (InlineTextBox::positionForOffset): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace): (RenderText::width):
  • khtml/rendering/render_text.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::charWidth): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint): (QFontMetrics::boundingRect): (QFontMetrics::size):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle):
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001.html:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002.html:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003.html:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004.html:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:

WebKit:

Rolling out changes for <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
since it caused a 2% performance regression.

  • WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]): (initializeCharacterWidthIterator): (widthForNextCharacter):
2:28 PM Changeset in webkit [9594] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Bug #: 3851
Submitted by: eseidel
Reviewed by: mjs
Fixed Bogus ChangeLog entry.

  • kwq/KWQPalette.h: (QColorGroup::): Enum values added for KDOM. (QPalette::): Enum values added for KDOM.
  • kwq/KWQPalette.mm: Added. (QPalette::setColor): Added (only supports "active"). Many of these enum values (particularly ColorGroup) may be removed as KDOM gets better integrated with our tree. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3851
2:10 PM Changeset in webkit [9593] by bdakin
  • 1 edit
    5 adds in trunk

Adding colspan test for HTMLTableElement and bdo test for HTMLElement.

Reviewed by NOBODY Adele.

Test cases added: (NONE)

  • ChangeLog:
  • layout-tests/fast/dom/HTMLElement/bdo-expected.txt: Added.
  • layout-tests/fast/dom/HTMLElement/bdo.html: Added.
  • layout-tests/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • layout-tests/fast/dom/HTMLTableElement/colSpan.html: Added.
11:37 AM Changeset in webkit [9592] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4158230> Zoom In/Zoom Out in PDF context menu don't update window's notion of text size
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Redirect Actual Size, Zoom In, and Zoom Out context menu items so that they behave exactly like Make Text Standard Size, Make Text Larger, and Make Text Smaller.
11:37 AM Changeset in webkit [9591] by ggaren
  • 2 edits in trunk/WebCore

-rolled out patch for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3826
because it fails to build w/gcc3.3 (previous fix didn't completely work)

  • kwq/KWQDef.h:
11:09 AM Changeset in webkit [9590] by ggaren
  • 2 edits in trunk/WebCore

-fixed failed build introduced by fix to
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3826

Reviewed by sullivan.

  • kwq/KWQDef.h: changed 64 bit typedef to match def in sys/types.h
1:22 AM Changeset in webkit [9589] by eseidel
  • 2 edits
    1 add in trunk/WebCore

Bug #: 3851
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPalette.h: (QColorGroup::): Enum values added for KDOM. (QPalette::): Enum values added for KDOM.
  • kwq/KWQPalette.mm: Added. (QPalette::setColor): Added (only supports "active"). Many of these enum values (particularly ColorGroup) may be removed as KDOM gets better integrated with our tree. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3851
1:17 AM Changeset in webkit [9588] by eseidel
  • 1 edit
    5 adds in trunk/WebCore

Bug #: 3822
Submitted by: eseidel
Reviewed by: mjs

1:09 AM Changeset in webkit [9587] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3826
Submitted by: eseidel
Reviewed by: mjs

1:04 AM Changeset in webkit [9586] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3828
Submitted by: eseidel
Reviewed by: mjs

12:57 AM Changeset in webkit [9585] by eseidel
  • 4 edits
    3 adds in trunk/WebCore

Bug #: 3821
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/qwmatrix.h: Added.
  • WebCore.pbproj/project.pbxproj: Added KWQMatrix.*
  • khtml/rendering/render_image.cpp: Now includes qwmatrix.h
  • kwq/KWQPixmap.h: Removed QWMatrix stub.
  • kwq/KWQWMatrix.h: Added. (QWMatrix::m11): simple accessors. (QWMatrix::m12): (QWMatrix::m21): (QWMatrix::m22): (QWMatrix::dx): (QWMatrix::dy):
  • kwq/KWQWMatrix.mm: Added. (QWMatrix::QWMatrix): All are standard Qt functions. (QWMatrix::setMatrix): (QWMatrix::map): (QWMatrix::isIdentity): (QWMatrix::reset): (QWMatrix::scale): (QWMatrix::rotate): (QWMatrix::translate): (QWMatrix::shear): (QWMatrix::det): (QWMatrix::isInvertible): (QWMatrix::invert): (QWMatrix::operator CGAffineTransform): (QWMatrix::operator== ): (QWMatrix::operator*= ): Simple white-room QWMatrix implementation entirely based on CGAffineTransform. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3821
12:13 AM Changeset in webkit [9584] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3850
Submitted by: eseidel
Reviewed by: mjs

Jul 4, 2005:

6:11 AM Changeset in webkit [9583] by mjs
  • 1 edit
    2 adds in trunk

Expected results for layout tests from last patch.

  • layout-tests/fast/js/eval-var-decl-expected.txt: Added.
  • layout-tests/fast/js/has-own-property-expected.txt: Added.

Jul 3, 2005:

3:47 AM Changeset in webkit [9582] by mjs
  • 28 edits
    2 adds in trunk

JavaScriptCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • tests/mozilla/expected.html: Two tests newly pass.
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasOwnProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasOwnProperty): (KJS::ActivationImp::hasOwnProperty):
  • kjs/function.h:
  • kjs/lookup.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty): (KJS::ObjectImp::hasOwnProperty):
  • kjs/object.h: (KJS::Object::hasOwnProperty):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasOwnProperty):
  • kjs/string_object.h:

WebCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/js/has-own-property.html: Added - tests this change.
  • layout-tests/fast/js/eval-var-decl.html: Added - test depends on this change.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMElement::tryGet): (KJS::DOMNamedNodeMap::hasOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
  • khtml/ecma/kjs_window.h:
3:13 AM Changeset in webkit [9581] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3825
Submitted by: eseidel
Reviewed by: mjs

3:05 AM Changeset in webkit [9580] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3823
Submitted by: eseidel
Reviewed by: mjs

2:58 AM Changeset in webkit [9579] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 3832
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQValueList.h: (QValueList::find): KDOM support (QValueList::constBegin): KDE compatibility (QValueList::constEnd): KDE compatibility
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::findEqualNode): KDOM support ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3832
2:51 AM Changeset in webkit [9578] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3827
Submitted by: eseidel
Reviewed by: mjs

2:45 AM Changeset in webkit [9577] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3831
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::findRef): Added to support KDOM::NodeImpl::compareDocumentPosition(NodeImpl *other)
2:38 AM Changeset in webkit [9576] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3830
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/qintdict.h: maps to KWQIntDict.h
  • kwq/KWQIntDict.h: copy of KWQPtrDict.h replacing T * with int.
12:08 AM Changeset in webkit [9575] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPair.h: added newline, per mjs's request.
12:03 AM Changeset in webkit [9574] by eseidel
  • 1 edit
    2 adds in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

Jul 1, 2005:

6:42 PM Changeset in webkit [9573] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164972> extra HTTP GET when iframe requests file already fetched by parent that should have been cached

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
6:39 PM Changeset in webkit [9572] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164976> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)

2005-06-13 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

No test cases added since the steps to reproduce require use of showModalDialog.

  • fix for <rdar://problem/4145910> parameters not working in showModalDialog test page (dialogWidth, dialogHeight, etc.)
  • khtml/ecma/kjs_window.cpp: (KJS::parseFeatures): add a check for colon character in the feature string
6:32 PM Changeset in webkit [9571] by adele
  • 22 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.
No layout tests added because showModalDialog won't work in DumpRenderTree at the moment.

  • WebCore part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • khtml/ecma/kjs_window.cpp: (KJS::allowPopUp): Added. Used by showModalDialog now and should be used by window.open later. (KJS::parseFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::canShowModalDialog): Added. (KJS::canShowModalDialogNow): Added. (KJS::showModalDialog): Added. (KJS::Window::get): Return the showModalDialog function object if the extension can run modal. (KJS::Window::clear): Add code to store the return value for the case where the window is a modal dialog. (KJS::WindowFunc::tryCall): Add the call to the showModalDialog function.
  • khtml/ecma/kjs_window.h: Add setReturnValueSlot function so showModalDialog can get the return value from the dialog it creates. Also add a data member to keep track of the pointer and a constant for the ShowModalDialog method.
  • khtml/khtml_part.h: Added new changeLocation member function. Made setOpener, openedByJS, and setOpenedByJS public.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): Broke out the part of slotRedirect that actually does the location change into a separate function so it can be called when needed. The case using it now is to load the content of a new window in KJS::createNewWindow. (KHTMLPart::slotRedirect): Call changeLocation to do most of the work. (KHTMLPart::urlSelected): Fixed a broken case where the "lack of referrer" in a new window would cause the referrer passed in by JavaScript to be ignored when opening a new window -- match logic elsewhere that leaves the referrer in the args alone if one is not set in the window.
  • khtml/khtmlpart_p.h: Initialize m_bCleared to true to avoid an unnecessary clear before loading the first URL in a new window. This change is needed to avoid blowing away the "dialogArguments" value in a modal dialog window, but it also avoid unnecessary work for each new window.
  • kwq/KWQApplication.h: Add availableGeometry function for QDesktopWidget. Used by the showModalDialog function inside kjs_window.cpp (and should be used elsewhere eventually too). Matches a Qt function that we just didn't have implemented before.
  • kwq/KWQApplication.mm: (QDesktopWidget::availableGeometry): Added.
  • kwq/KWQKHTMLPartBrowserExtension.h: Added new canRunModal, canRunModalNow, and runModal functions.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Call createModalDialogWithURL on the bridge if the new window is a dialog. Also fixed the early return case for when the bridge returns nil. (KHTMLPartBrowserExtension::canRunModal): Added. Calls bridge. (KHTMLPartBrowserExtension::canRunModalNow): Ditto. (KHTMLPartBrowserExtension::runModal): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: (KParts::URLArgs::URLArgs): Initialize m_lockHistory to false. (KParts::WindowArgs::WindowArgs): Add a dialog boolean.
  • kwq/WebCoreBridge.h: Declared canRunModal, canRunModalNow, createModalDialogWithURL, and runModal methods.

WebKit:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164982> add IE JavaScript extension window.showModalDialog

2005-06-01 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

  • WebKit part of fix for <rdar://problem/3166090> add IE JavaScript extension window.showModalDialog
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createModalDialogWithURL:]): Added. Calls the UI delegate, falling back to the generic "create WebView" method. (-[WebBridge canRunModal]): Added. Checks the UI delegate to see if it implements runModal. (-[WebBridge canRunModalNow]): Added. Checks the "inConnectionCallback" field so we can prevent deadlock since we can't do any I/O while inside a connection callback until this aspect of NSURLConnection is changed. (-[WebBridge runModal]): Added. Sets "defersCallbacks" on all other web views in the group, then calls runModal on the UI delegate.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Added inConnectionCallback class method.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Bump count and then decrement count so we can tell if we are in a callback. (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willStopBufferingData:]): Ditto. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Ditto. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): Ditto. (-[WebBaseResourceHandleDelegate connection:willCacheResponse:]): Ditto. (+[WebBaseResourceHandleDelegate inConnectionCallback]): Added. Return YES if count is not 0.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): Changed to use the method without the connection: parameter in the base class, since we no longer are overriding the connection: version. (-[WebMainResourceClient willSendRequest:redirectResponse:]): Change to override the version without the connection prefix/parameter; now only the base class overrides the actual connection delegate methods. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient didReceiveResponse:]): Ditto. (-[WebMainResourceClient didReceiveData:lengthReceived:]): Ditto. (-[WebMainResourceClient didFinishLoading]): Ditto. (-[WebMainResourceClient didFailWithError:]): Ditto. (-[WebMainResourceClient loadWithRequestNow:]): Call the method without the connection parameter.
  • WebView.subproj/WebUIDelegatePrivate.h: Added new SPI here that WebBrowser implements.
4:02 PM Changeset in webkit [9570] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164966> Crash will occur when double-clicking outerHTML link on W3 DOM test
<rdar://problem/4164988> support outerHTML on IMG elements

2005-05-09 Adele Peterson <​adele@apple.com>

fix for <rdar://problem/4110775> Crash will occur when double-clicking outerHTML link on W3 DOM test

Reviewed by Darin.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): added nil check. This was causing a crash when you tried to set the outerHTML on an element that was no longer in the DOM tree.

2005-04-20 Vicki Murley <​vicki@apple.com>

Reviewed by hyatt.

  • fixed <rdar://problem/4065447> support outerHTML on IMG elements
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
3:46 PM Changeset in webkit [9569] by adele
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164985> Not able to load additional script blocks dynamically

2005-05-04 Vicki Murley <​vicki@apple.com>

Reviewed by darin.

  • fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
  • khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
3:36 PM Changeset in webkit [9568] by adele
  • 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch.
<rdar://problem/4164922> Request for including an implementation of the elementFromPoint function

2005-04-12 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fixed <rdar://problem/3760895> Request for including an implementation of the elementFromPoint function
  • khtml/dom/dom_doc.cpp: (DOM::Document::elementFromPoint):
  • khtml/dom/dom_doc.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
  • khtml/ecma/kjs_dom.lut.h: (KJS::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::elementFromPoint):
  • khtml/xml/dom_docimpl.h:
3:12 PM Changeset in webkit [9567] by bdakin
  • 1 edit
    3 adds in trunk

Adding createCaption test for HTMLTableElement.

Reviewed by Adele (sort of).

Test cases added:

  • layout-tests/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • layout-tests/fast/dom/HTMLTableElement/createCaption.html: Added.
2:30 PM Changeset in webkit [9566] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

This was a problem with using Tiger's version of Safari with tip of tree WebKit.

  • WebView.subproj/WebPDFView.m: (-[WebPDFView _anyPDFTagsFoundInMenu:]): new method, returns YES if the menu contains any items with any of the new PDF-related tags. (-[WebPDFView menuForEvent:]): If the executable was linked on Tiger or older (but it will never be older, since this code is new to Tiger), force all of the PDF-related items into the menu if none of them were there after processing by the delegate.
2:14 PM Changeset in webkit [9565]
  • 28 copies
    2 deletes in tags/WebCore-315~7

This commit was manufactured by cvs2svn to create tag
'WebCore-315~7'.

2:14 PM Changeset in webkit [9564] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.7

2:12 PM Changeset in webkit [9563] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/4122332> from TOT to Safari-1-3-branch

2005-06-28 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

  • fix our part of <rdar://problem/4122332> extra HTTP GET when iframe requests file already fetched by parent that should have been cached. Setting location via javascript should not signal a full reload of the destination page and all its subresources.
  • khtml/khtml_part.cpp: (KHTMLPart::changeLocation): remove code that sets the reload flag
2:07 PM Changeset in webkit [9562] by ggaren
  • 1 edit
    14 adds
    4 deletes in trunk

Moving dom tests around to conform to new directory structure
specified in today's meeting.

Reviewed by justing.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/title-get-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title-get.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title-set-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/title-set.html: Added.
  • layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/get.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/title/set.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/url-getset-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/url-getset.html: Added.
  • layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/url/getset.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/write-call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/write-call.html: Added.
  • layout-tests/fast/dom/HTMLDocument/write-multiple-calls-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/write-multiple-calls.html: Added.
  • layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/call.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/multiple-calls-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/write/multiple-calls.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln-call-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-call.html: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls-expected.txt: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls.html: Added.
  • layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/call.html: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Removed.
  • layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Removed.
1:07 PM Changeset in webkit [9561] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • added WKExecutableLinkedInTigerOrEarlier
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
11:56 AM Changeset in webkit [9560] by ggaren
  • 5 edits in trunk

JavaScriptCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

  • no layout test necessary yet - only groundwork

Reviewed by darin.

  • kjs/lookup.h: (KJS::cacheGlobalObject):

WebCore:

-landed patch by Eric Seidel <​macdome@opendarwin.org>

-for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT

  • no layout test necessary yet - only groundwork

Reviewed by darin.

  • ForwardingHeaders/qintdict.h:
  • khtml/ecma/kjs_binding.h:
11:45 AM Changeset in webkit [9559] by ggaren
  • 6 edits in trunk

JavaScriptCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)

-relevant tests:

mozilla/ecma_3/Date/15.9.5.5.js
layout-tests/fast/js/date-parse-test.html

Reviewed by darin.

  • kjs/date_object.cpp: (formatLocaleDate): (day): (dayFromYear): (daysInYear): (timeFromYear): (yearFromTime): (weekDay): (timeZoneOffset): (DateProtoFuncImp::call): (DateObjectImp::construct): (KJS::parseDate): (ymdhms_to_seconds): (KJS::makeTime): (findMonth): (KJS::KRFCDate_parseDate):
  • kjs/date_object.h:
  • tests/mozilla/expected.html: updated expected results to reflect fix

WebCore:

-landed patch by Carsten Guenther <​cguenther@gmail.com>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3477

-corrects errors in date layout test

Reviewed by darin.

Test cases modified:

  • layout-tests/fast/js/date-parse-test.html:
10:47 AM Changeset in webkit [9558] by ggaren
  • 3 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168186> JavaScript fails to throw exceptions
for invalid return statements

relevant tests:

ecma/Statements/12.9-1-n.js
ecma_2/Exceptions/lexical-052.js
ecma_2/Exceptions/statement-009.js

Reviewed by sullivan.

  • kjs/nodes.cpp: (ReturnNode::execute): now throws exception if return is not inside a function.
  • tests/mozilla/expected.html: updated to reflect fix
10:37 AM Changeset in webkit [9557] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by sullivan.

  • tests/mozilla/expected.html: Updated test results for last fix.
10:19 AM Changeset in webkit [9556] by ggaren
  • 2 edits in trunk/JavaScriptCore

-fixed <rdar://problem/4168161> JavaScript fails to throw an exception
for invalid function calls

Reviewed by sullivan.

Relevant mozilla test: ecma_3/Exceptions/regress-95101.js

  • kjs/nodes.cpp: (FunctionCallNode::evaluate): evaluate now checks for an exception after resolving a function name (in case the function is undefined)
3:03 AM Changeset in webkit [9555] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3669
Submitted by: eseidel
Reviewed by: darin

  • kwq/KWQSize.h:
  • kwq/KWQSize.mm: (QSize::operator CGSize): adding CGSize conversion support
2:55 AM Changeset in webkit [9554] by eseidel
  • 3 edits in trunk/JavaScriptCore

Bug #: 3687
Submitted by: eseidel
Reviewed by: darin

2:48 AM Changeset in webkit [9553] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 3771
Submitted by: eseidel
Reviewed by: darin

Note: See TracTimeline for information about the timeline view.