Timeline



Jul 7, 2005:

10:51 PM Changeset in webkit [9617] by mjs
  • 2 edits in trunk/WebCore
  • oops, accidentally committed stat dumping enabled
  • khtml/misc/hashtable.h:
10:19 PM Changeset in webkit [9616] by mjs
  • 4 edits in trunk/WebCore

Reviewed by hyatt.

  • sped up DOMStringImpl * equality comparisons.
  • khtml/misc/hashfunctions.h: (khtml::):
  • khtml/misc/hashtable.h:
  • khtml/xml/dom_atomicstring.cpp: (DOM::equal):
5:50 PM Changeset in webkit [9615] by adele
  • 2 edits in branches/Safari-Cam-branch/WebCore

Versioning for Safari-Cam-branch - WebCore-415.12

5:48 PM Changeset in webkit [9614] by adele
  • 2 edits in branches/Safari-Cam-branch/WebCore

merged fix for <rdar://problem/4168001> from TOT to Safari-Cam-branch

2005-07-07 Adele Peterson <​adele@apple.com>

change by Maciej, reviewed by me.

fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)

No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
called twice for the same document, and this can cause some nodes to unnecessarily remain in the
m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
list after removing all event listeners for the disconnected nodes.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
5:20 PM Changeset in webkit [9613] by adele
  • 2 edits in trunk/WebCore

change by Maciej, reviewed by me.

fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)

No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
called twice for the same document, and this can cause some nodes to unnecessarily remain in the
m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
list after removing all event listeners for the disconnected nodes.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
10:06 AM Changeset in webkit [9612] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by sullivan.

Test cases added: (NONE)

  • kwq/KWQDef.h: added #include <cmath> to fix build failure introduced by last checkin
1:03 AM Changeset in webkit [9611] by eseidel
  • 10 edits in trunk/WebCore

Bug #: 3829
Submitted by: eseidel
Reviewed by: mjs

  • kwq/DOM-CSS.mm: (-[DOMRGBColor _color]): changed to nsColor()
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle): changed to nsColor()
  • kwq/KWQColor.h: Added defs for KDOM.
  • kwq/KWQColor.mm: (qRed): like qAlpha, kcanvas required. (qGreen): like qAlpha, kcanvas required. (qBlue): like qAlpha, kcanvas required. (parseHexColor): copied from khtml/css/cssparser.h (QColor::QColor): QColor(QString), will lookup by hex code. (nsColor): now plain function, instead of member function. (mjs) (CGColorFromNSColor): stolen from QPalette.mm (cgColor): added to support CGColor, like nsColor() (QColor::getRgbaF): new, for KCanvas, from Qt 4.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): changed to nsColor() (KWQKHTMLPart::fontAttributesForSelectionStart): nsColor() (KWQKHTMLPart::bodyBackgroundColor): changed to nsColor()
  • kwq/KWQLineEdit.mm: (QLineEdit::setPalette): changed to nsColor()
  • kwq/KWQPainter.mm: (QPainter::_setColorFromBrush): changed to nsColor() (QPainter::_setColorFromPen): changed to nsColor() (QPainter::drawText): changed to nsColor() (QPainter::drawHighlightForText): changed to nsColor() (QPainter::drawLineForText): changed to nsColor() (QPainter::_fillRect): changed to nsColor() (QPainter::setShadow): changed to cgColor() (QPainter::drawFocusRing): changed to nsColor()
  • kwq/KWQTextEdit.mm: (QTextEdit::setPalette): changed to nsColor()
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionColor]): changed to nsColor() This patch ended up larger than intended after discussing with mjs about adding getCGColor() and getCIColor() We decided that having separate nsColor(), cgColor() and ciColor() defined elsewhere, was cleanest. The rest of the patch is QColor additions for kdom/ksvg/kcanvas. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3829
12:38 AM Changeset in webkit [9610] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3849
Submitted by: eseidel
Reviewed by: mjs

12:33 AM Changeset in webkit [9609] by eseidel
  • 4 edits in trunk

Bug: 3882
Submitter: eseidel
Reviewer: mjs

12:17 AM Changeset in webkit [9608] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 3826
Submitted by: eseidel
Reviewed by: mjs

  • khtml/rendering/render_canvasimage.cpp: <cmath.h>
  • khtml/rendering/render_image.cpp: <cmath.h> instead of <math.h>
  • kwq/KWQDef.h: 64bit support for KDOM (qRound): inline mapping to lround. Newer patch, now gcc 3.3 compatible. Thanks to ggaren for the 3.3 fix. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3826

Jul 6, 2005:

11:31 PM Changeset in webkit [9607] by eseidel
  • 1 edit
    2 adds in trunk/WebCore

Bug #: 3860
Submitted by: eseidel
Reviewed by: mjs

11:25 PM Changeset in webkit [9606] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 3674
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPoint.mm: (QPoint::operator CGPoint): Added. (operator*): Added. (operator<<): Added.
  • kwq/KWQPointArray.h: Added. (QPoint::setX): Added. (QPoint::setY): Added. (QPoint::isNull): Added. (QPoint::operator -=): Added.
  • kwq/KWQPointArray.mm: Added. (QPointArray::QPointArray): Added. (QPointArray::copy): Added. (QPointArray::boundingRect): Added. (QPointArray::point): Added. Necessary additions for KDOM/KSVG/KCanvas ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3674
10:42 PM Changeset in webkit [9605] by mjs
  • 3 edits in trunk/WebCore

Reviewed by hyatt.

  • fixed size() and contains() methods on HashSet (they would not compile before)
  • khtml/misc/hashset.h: (khtml::::size):
  • khtml/misc/hashtable.h: (khtml::::contains):
8:07 PM Changeset in webkit [9604] by eseidel
  • 1 edit
    1 add in trunk/WebCore

Bug #: 3859
Submitted by: eseidel
Reviewed by: mjs

11:49 AM Changeset in webkit [9603] by ggaren
  • 14 edits in trunk

Reviewed by adele.

Modified layout tests to match rollout of changes for <rdar://problem/3792529>
REGRESSION (Mail): Tabs do not work the way they did in Panther

Tests modified:

  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:
1:38 AM Changeset in webkit [9602] by mjs
  • 2 edits in trunk/WebCore

Even yet still more gcc4 build fixes.

  • khtml/misc/hashset.h: (khtml::convertAdapter): (khtml::::insert):
12:35 AM Changeset in webkit [9601] by mjs
  • 2 edits in trunk/WebCore

More ggc-4-only build fixage.

  • khtml/misc/hashtraits.h:
12:11 AM Changeset in webkit [9600] by mjs
  • 2 edits in trunk/WebCore

Fix additional gcc-4-only build breakage.

  • khtml/misc/pointerhash.h: (khtml::PointerHashConstIteratorAdapter::operator*):

Jul 5, 2005:

11:23 PM Changeset in webkit [9599] by mjs
  • 1 edit
    1 add in trunk/WebCore

Forgot to commit a file. Fix for build breakage.

  • ForwardingHeaders/misc/pointerhash.h: Added.
8:30 PM Changeset in webkit [9598] by mjs
  • 2 edits in trunk/WebCore
  • remove stat dumping (accidentally left enabled in last patch)

Unreviewed since this was a mistake in the last checkin.

  • khtml/misc/hashtable.h:
6:28 PM Changeset in webkit [9597] by mjs
  • 9 edits
    6 adds in trunk/WebCore

Reviewed by hyatt.

Numerous hash code improvements:

  • added HashMap and the required support for it in HashTable
  • convert to using deleted sentinels and double hashing instead of linear probing and reinsert on delete
  • add support for traits so that empty and deleted values can be customized per type
  • make insert return a pair of an iterator and a bool even at the API level
  • converted some code to use HashMap
  • added standard hash and equal functions for some types, plus case insensitive ones
  • lots of assorted code cleanup
  • pass hash functions as classes with two static functions instead of as functions
  • khtml/css/cssstyleselector.cpp: (khtml::CSSRuleSet::CSSRuleSet): Use HashMap instead of QPtrDict. (khtml::CSSRuleSet::~CSSRuleSet): ditto (khtml::CSSRuleSet::addToRuleSet): ditto (khtml::CSSRuleSet::addRule): ditto
  • khtml/css/cssstyleselector.h: (khtml::CSSRuleSet::getIDRules): ditto (khtml::CSSRuleSet::getClassRules): ditto (khtml::CSSRuleSet::getTagRules): ditto
  • khtml/editing/jsediting.cpp: (DOM::DocumentImpl::commandImp): ditto
  • khtml/misc/hashfunctions.h: Added. Standard hash functions. (khtml::defaultEqual): (khtml::pointerHash<4>): (khtml::pointerHash<8>): (khtml::defaultHash<void *>): (khtml::defaultHash<DOM::DOMStringImpl *>): (khtml::caseInsensitiveHash): (khtml::caseInsensitiveEqual):
  • WebCore.pbproj/project.pbxproj:
  • khtml/misc/hashmap.h: Added. (khtml::HashMap::HashMap): (khtml::HashMap::size): (khtml::HashMap::capacity): (khtml::HashMap::isEmpty): (khtml::HashMap::begin): (khtml::HashMap::end): (khtml::HashMap::find): (khtml::HashMap::contains): (khtml::HashMap::insert): (khtml::HashMap::get): (khtml::HashMap::remove): (khtml::HashMap::clear): (khtml::HashMap::extractKey):
  • khtml/misc/hashset.h: (khtml::identityExtract): (khtml::::size): (khtml::::capacity): (khtml::::isEmpty): (khtml::::begin): (khtml::::end): (khtml::::find): (khtml::::contains): (khtml::::insert): (khtml::::remove): (khtml::::clear): (khtml::::convertAdapter):
  • khtml/misc/hashtable.cpp: (khtml::HashTableStats::~HashTableStats):
  • khtml/misc/hashtable.h: (khtml::HashTableIterator::HashTableIterator): (khtml::HashTableIterator::skipEmptyBuckets): (khtml::HashTableConstIterator::HashTableConstIterator): (khtml::HashTableConstIterator::skipEmptyBuckets): (khtml::HashTable::HashTable): (khtml::HashTable::insert): (khtml::HashTable::isEmptyBucket): (khtml::HashTable::isDeletedBucket): (khtml::HashTable::isEmptyOrDeletedBucket): (khtml::HashTable::identityConvert): (khtml::HashTable::extractKey): (khtml::HashTable::lookup): (khtml::HashTable::shouldExpand): (khtml::HashTable::mustRehashInPlace): (khtml::HashTable::clearBucket): (khtml::HashTable::deleteBucket): (khtml::HashTable::makeLookupResult): (khtml::HashTable::makeIterator): (khtml::HashTable::makeConstIterator): (khtml::::lookup): (khtml::::insert): (khtml::::reinsert): (khtml::::find): (khtml::::contains): (khtml::::remove): (khtml::::allocateTable): (khtml::::expand): (khtml::::rehash): (khtml::::clear): (khtml::::HashTable): (khtml::::swap): (khtml::::operator): (khtml::::checkConsistency): (khtml::::checkConsistencyExceptSize):
  • khtml/misc/hashtraits.h: Added. (khtml::HashTraits::emptyValue): (khtml::): (khtml::PairHashTraits::emptyValue): (khtml::PairHashTraits::deletedValue):
  • ForwardingHeaders/misc/hashmap.h: Added.
  • ForwardingHeaders/misc/hashset.h: Added.
  • WebCore.pbproj/project.pbxproj: Added new files.
  • khtml/misc/pointerhash.h: Added. (khtml::PointerHashIteratorAdapter::PointerHashIteratorAdapter): (khtml::PointerHashIteratorAdapter::operator*): (khtml::PointerHashIteratorAdapter::operator->): (khtml::PointerHashIteratorAdapter::operator++): (khtml::PointerHashIteratorAdapter::operator==): (khtml::PointerHashIteratorAdapter::operator!=): (khtml::PointerHashConstIteratorAdapter::PointerHashConstIteratorAdapter): (khtml::PointerHashConstIteratorAdapter::operator*): (khtml::PointerHashConstIteratorAdapter::operator->): (khtml::PointerHashConstIteratorAdapter::operator++): (khtml::PointerHashConstIteratorAdapter::operator==): (khtml::PointerHashConstIteratorAdapter::operator!=): (khtml::):
5:21 PM Changeset in webkit [9596] by ggaren
  • 27 edits in trunk

Rolled in patch by ​opendarwin.org@mitzpettel.com

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3733
Incorrect bidi layout of ETs, ANs, and ENs in some contexts

Reviewed by hyatt.

  • khtml/rendering/bidi.cpp: (khtml::appendRun): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):

Modified test results to account for run splitting.
This is a known bug that we need to fix separately:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3838

  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt:
  • layout-tests/fast/block/basic/018-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/invalid/nestedh3s-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/lists/003-expected.txt:
  • layout-tests/fast/selectors/166-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/text/basic/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:
4:21 PM Changeset in webkit [9595] by adele
  • 55 edits in trunk

WebCore:

Rolling out changes for <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
since it caused a 2% performance regression.

  • khtml/editing/apply_style_command.cpp: (khtml::createStyleSpanElement): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState):
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::styleAtPosition):
  • khtml/editing/html_interchange.h:
  • khtml/editing/htmlediting.cpp: (khtml::isSpecialElement):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createFragmentFromText):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::removeStyleNodes):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::addPending): (khtml::HTMLTokenizer::write):
  • khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::):
  • khtml/rendering/bidi.cpp: (khtml::addRun): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::checkSelectionPoint): (Font::width):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::stripTrailingSpace): (khtml::RenderBlock::calcInlineMinMaxWidth):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_br.h: (khtml::RenderBR::width):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::paint):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_line.h: (khtml::InlineBox::width): (khtml::InlineBox::xPos): (khtml::InlineBox::yPos): (khtml::InlineBox::height): (khtml::InlineBox::baseline):
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • khtml/rendering/render_object.cpp: (RenderObject::recalcMinMaxWidths):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): (InlineTextBox::paint): (InlineTextBox::paintSelection): (InlineTextBox::paintMarkedTextBackground): (InlineTextBox::offsetForPosition): (InlineTextBox::positionForOffset): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace): (RenderText::width):
  • khtml/rendering/render_text.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::charWidth): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths): (QFontMetrics::checkSelectionPoint): (QFontMetrics::boundingRect): (QFontMetrics::size):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle):
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001.html:
  • layout-tests/editing/deleting/delete-tab-002-expected.txt:
  • layout-tests/editing/deleting/delete-tab-002.html:
  • layout-tests/editing/deleting/delete-tab-003-expected.txt:
  • layout-tests/editing/deleting/delete-tab-003.html:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004.html:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-003-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/js/string-replace-2-expected.txt:
  • layout-tests/fast/table/039-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/tokenizer/script_extra_close-expected.txt:

WebKit:

Rolling out changes for <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
since it caused a 2% performance regression.

  • WebCoreSupport.subproj/WebTextRenderer.m: (isSpace): (-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]): (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]): (initializeCharacterWidthIterator): (widthForNextCharacter):
2:28 PM Changeset in webkit [9594] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Bug #: 3851
Submitted by: eseidel
Reviewed by: mjs
Fixed Bogus ChangeLog entry.

  • kwq/KWQPalette.h: (QColorGroup::): Enum values added for KDOM. (QPalette::): Enum values added for KDOM.
  • kwq/KWQPalette.mm: Added. (QPalette::setColor): Added (only supports "active"). Many of these enum values (particularly ColorGroup) may be removed as KDOM gets better integrated with our tree. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3851
2:10 PM Changeset in webkit [9593] by bdakin
  • 1 edit
    5 adds in trunk

Adding colspan test for HTMLTableElement and bdo test for HTMLElement.

Reviewed by NOBODY Adele.

Test cases added: (NONE)

  • ChangeLog:
  • layout-tests/fast/dom/HTMLElement/bdo-expected.txt: Added.
  • layout-tests/fast/dom/HTMLElement/bdo.html: Added.
  • layout-tests/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • layout-tests/fast/dom/HTMLTableElement/colSpan.html: Added.
11:37 AM Changeset in webkit [9592] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4158230> Zoom In/Zoom Out in PDF context menu don't update window's notion of text size
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Redirect Actual Size, Zoom In, and Zoom Out context menu items so that they behave exactly like Make Text Standard Size, Make Text Larger, and Make Text Smaller.
11:37 AM Changeset in webkit [9591] by ggaren
  • 2 edits in trunk/WebCore

-rolled out patch for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3826
because it fails to build w/gcc3.3 (previous fix didn't completely work)

  • kwq/KWQDef.h:
11:09 AM Changeset in webkit [9590] by ggaren
  • 2 edits in trunk/WebCore

-fixed failed build introduced by fix to
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3826

Reviewed by sullivan.

  • kwq/KWQDef.h: changed 64 bit typedef to match def in sys/types.h
1:22 AM Changeset in webkit [9589] by eseidel
  • 2 edits
    1 add in trunk/WebCore

Bug #: 3851
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPalette.h: (QColorGroup::): Enum values added for KDOM. (QPalette::): Enum values added for KDOM.
  • kwq/KWQPalette.mm: Added. (QPalette::setColor): Added (only supports "active"). Many of these enum values (particularly ColorGroup) may be removed as KDOM gets better integrated with our tree. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3851
1:17 AM Changeset in webkit [9588] by eseidel
  • 1 edit
    5 adds in trunk/WebCore

Bug #: 3822
Submitted by: eseidel
Reviewed by: mjs

1:09 AM Changeset in webkit [9587] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3826
Submitted by: eseidel
Reviewed by: mjs

1:04 AM Changeset in webkit [9586] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3828
Submitted by: eseidel
Reviewed by: mjs

12:57 AM Changeset in webkit [9585] by eseidel
  • 4 edits
    3 adds in trunk/WebCore

Bug #: 3821
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/qwmatrix.h: Added.
  • WebCore.pbproj/project.pbxproj: Added KWQMatrix.*
  • khtml/rendering/render_image.cpp: Now includes qwmatrix.h
  • kwq/KWQPixmap.h: Removed QWMatrix stub.
  • kwq/KWQWMatrix.h: Added. (QWMatrix::m11): simple accessors. (QWMatrix::m12): (QWMatrix::m21): (QWMatrix::m22): (QWMatrix::dx): (QWMatrix::dy):
  • kwq/KWQWMatrix.mm: Added. (QWMatrix::QWMatrix): All are standard Qt functions. (QWMatrix::setMatrix): (QWMatrix::map): (QWMatrix::isIdentity): (QWMatrix::reset): (QWMatrix::scale): (QWMatrix::rotate): (QWMatrix::translate): (QWMatrix::shear): (QWMatrix::det): (QWMatrix::isInvertible): (QWMatrix::invert): (QWMatrix::operator CGAffineTransform): (QWMatrix::operator== ): (QWMatrix::operator*= ): Simple white-room QWMatrix implementation entirely based on CGAffineTransform. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3821
12:13 AM Changeset in webkit [9584] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3850
Submitted by: eseidel
Reviewed by: mjs

Jul 4, 2005:

6:11 AM Changeset in webkit [9583] by mjs
  • 1 edit
    2 adds in trunk

Expected results for layout tests from last patch.

  • layout-tests/fast/js/eval-var-decl-expected.txt: Added.
  • layout-tests/fast/js/has-own-property-expected.txt: Added.

Jul 3, 2005:

3:47 AM Changeset in webkit [9582] by mjs
  • 28 edits
    2 adds in trunk

JavaScriptCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • tests/mozilla/expected.html: Two tests newly pass.
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::hasOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::hasOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::hasOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::hasOwnProperty):
  • kjs/function.cpp: (KJS::FunctionImp::hasOwnProperty): (KJS::ActivationImp::hasOwnProperty):
  • kjs/function.h:
  • kjs/lookup.h:
  • kjs/object.cpp: (KJS::ObjectImp::hasProperty): (KJS::ObjectImp::hasOwnProperty):
  • kjs/object.h: (KJS::Object::hasOwnProperty):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::):
  • kjs/string_object.cpp: (StringInstanceImp::hasOwnProperty):
  • kjs/string_object.h:

WebCore:

Original patch from Mark Rowe <​opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/js/has-own-property.html: Added - tests this change.
  • layout-tests/fast/js/eval-var-decl.html: Added - test depends on this change.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMElement::tryGet): (KJS::DOMNamedNodeMap::hasOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
  • khtml/ecma/kjs_window.h:
3:13 AM Changeset in webkit [9581] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3825
Submitted by: eseidel
Reviewed by: mjs

3:05 AM Changeset in webkit [9580] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3823
Submitted by: eseidel
Reviewed by: mjs

2:58 AM Changeset in webkit [9579] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 3832
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQValueList.h: (QValueList::find): KDOM support (QValueList::constBegin): KDE compatibility (QValueList::constEnd): KDE compatibility
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::findEqualNode): KDOM support ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3832
2:51 AM Changeset in webkit [9578] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3827
Submitted by: eseidel
Reviewed by: mjs

2:45 AM Changeset in webkit [9577] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3831
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::findRef): Added to support KDOM::NodeImpl::compareDocumentPosition(NodeImpl *other)
2:38 AM Changeset in webkit [9576] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 3830
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/qintdict.h: maps to KWQIntDict.h
  • kwq/KWQIntDict.h: copy of KWQPtrDict.h replacing T * with int.
12:08 AM Changeset in webkit [9575] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

  • kwq/KWQPair.h: added newline, per mjs's request.
12:03 AM Changeset in webkit [9574] by eseidel
  • 1 edit
    2 adds in trunk/WebCore

Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs

Note: See TracTimeline for information about the timeline view.