Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 15, 2005:

11:45 PM Changeset in webkit [9818] by adele

• 4 edits
  2 adds in trunk

Written by Anders Carlsson <​andersca@mac.com>
Reviewed by Dave Hyatt.

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3653>

Test cases added:
layout-tests/fast/dom/createDocumentType.html: Added
layout-tests/fast/dom/createDocumentType-expected.txt: Added

• khtml/xml/dom_nodeimpl.cpp: (DocumentPtr::nullDocumentPtr):
• khtml/xml/dom_nodeimpl.h: Add nullDocumentPtr() function which returns a shared DocumentPtr object whose document always is 0.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocumentType): Pass nullDocumentPtr as the document type's document.

11:17 PM Changeset in webkit [9817] by adele

• 3 edits
  3 adds in trunk

Written by Anders Carlsson <​andersca@mac.com>
Reviewed by Maciej.

• Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3808>

Test cases added:

• layout-tests/fast/js/location-assign.html: Added.
• layout-tests/fast/js/location-assign-expected.txt: Added.
• layout-tests/fast/js/resources/new-location.html: Added.

• khtml/ecma/kjs_window.cpp: (KJS::Location::get): (KJS::LocationFunc::tryCall):
• khtml/ecma/kjs_window.h: (KJS::Location::): Implement location.assign.

10:53 PM Changeset in webkit [9816] by adele

• 2 edits in trunk/WebKit

Written by Trey Matteson <​trey@usa.net>
Reviewed by John Sullivan.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3910 - REGRESSION: Replying "Cancel" to the form repost nag leaves wrong b/f cursor

• WebView.subproj/WebFrame.m: (-[WebFrame _resetBackForwardList]): new helper method (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): If the delegate bailed on the navigation, tell the main frame to reset the b/f cursor back to where it was before we started.

10:39 PM Changeset in webkit [9815] by adele

• 7 edits in trunk

Updated layout tests for formatting changes from change for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3601

• layout-tests/fast/dom/outerText-no-element-expected.txt:
• layout-tests/fast/dynamic/outerHTML-no-element-expected.txt:
• layout-tests/fast/js/array-every-expected.txt:
• layout-tests/fast/js/array-foreach-expected.txt:
• layout-tests/fast/js/array-some-expected.txt:
• layout-tests/fast/js/toString-stack-overflow-expected.txt:

3:59 PM Changeset in webkit [9814] by sullivan

• 3 edits in trunk/WebKit

Written by Trey Matteson
Reviewed by me.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4013

text find doesn't wrap in PDF files

This just works once WebPDFView implements the WebDocumentText protocol, which is
mostly just a matter of forwarding the methods to PDFKit appropriately.

• WebView.subproj/WebPDFView.h:
• WebView.subproj/WebPDFView.m: (-[WebPDFView supportsTextEncoding]): (-[WebPDFView string]): (-[WebPDFView attributedString]): (-[WebPDFView selectedString]): (-[WebPDFView selectedAttributedString]): (-[WebPDFView selectAll]): (-[WebPDFView deselectAll]):

3:16 PM Changeset in webkit [9813] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

• fixed <rdar://problem/4181884> Searching for text that overlaps selection works differently in PDFView than in HTMLView

• WebView.subproj/WebPDFView.m: (PDFSelectionsAreEqual): new function, stand-in for nonexistent -[PDFSelection isEqual:] since calling isEqual: on two identical PDFSelections returns NO (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): Make search algorithm match that in WebCore: initially search inside selection, then check for the case where the found text exactly matches the previous selection, and search from past the selection if so. The implementation is slightly more complicated than it should be due to PDFKit API limitations (about which I added FIXMEs and filed bugs)

1:35 PM Changeset in webkit [9812] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

• fixed these bugs: <rdar://problem/4181875> Searching for text that overlaps selection works differently in WebTextView than in HTMLView <rdar://problem/3393678> Find not finding text in plain (non-HTML) if all text is selected

• Misc.subproj/WebSearchableTextView.m: (-[NSString findString:selectedRange:options:wrap:]): Make search algorithm match that in WebCore: initially search inside selection, then check for the case where the found text exactly matches the previous selection, and search from past the selection if so.

11:06 AM Changeset in webkit [9811]

• 68 copies
  2 deletes in tags/WebCore-315~9

This commit was manufactured by cvs2svn to create tag
'WebCore-315~9'.

11:06 AM Changeset in webkit [9810] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.9

11:05 AM Changeset in webkit [9809] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-15 Kevin Decker <​kdecker@apple.com>

Reviewed by Adele

Fixed: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

11:02 AM Changeset in webkit [9808]

• 88 copies
  2 deletes in tags/WebCore-415~13

This commit was manufactured by cvs2svn to create tag
'WebCore-415~13'.

11:02 AM Changeset in webkit [9807]

• 122 copies in branches/Safari-OC-branch

This commit was manufactured by cvs2svn to create branch
'Safari-OC-branch'.

11:02 AM Changeset in webkit [9806]

• 122 copies in tags/Safari-OC-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-OC-anchor'.

11:02 AM Changeset in webkit [9805] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

fix versioning for Safari-2-0-branch - WebCore-415.13

10:58 AM Changeset in webkit [9804] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.12

10:56 AM Changeset in webkit [9803] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-15 Kevin Decker <​kdecker@apple.com>

Reviewed by Adele

Fixed: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

10:50 AM Changeset in webkit [9802] by kdecker

• 2 edits in trunk/WebCore

Reviewed by Adele

Fixed: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

10:32 AM Changeset in webkit [9801]

• 11 copies
  3 deletes in tags/JavaScriptCore-412~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~5'.

10:32 AM Changeset in webkit [9800] by adele

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning for Safari-2-0-branch - JavaScriptCore-412.5

10:28 AM Changeset in webkit [9799]

• 25 copies
  3 deletes in tags/WebKit-412~7

This commit was manufactured by cvs2svn to create tag 'WebKit-412~7'.

10:28 AM Changeset in webkit [9798] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.7

10:23 AM Changeset in webkit [9797]

• 21 copies
  3 deletes in tags/WebKit-312~5

This commit was manufactured by cvs2svn to create tag 'WebKit-312~5'.

10:23 AM Changeset in webkit [9796] by adele

• 2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.5

9:58 AM Changeset in webkit [9795] by ggaren

• 5 edits in trunk/JavaScriptCore

-rolled in KDE fixes for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3601
Error instance type info

Reviewed by mjs.

• kjs/error_object.cpp:
• Created ErrorInstanceImp class for Error() objects.
• Changed parent object for Native Errors to "Function" (matches ECMA spec). (ErrorInstanceImp::ErrorInstanceImp): (ErrorProtoFuncImp::call): (ErrorObjectImp::construct): (NativeErrorImp::construct):

• kjs/error_object.h: (KJS::ErrorInstanceImp::classInfo):
• kjs/object.h: made comment more informative about ClassInfo

• tests/mozilla/expected.html:

9:55 AM Changeset in webkit [9794] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

added missing line from last fix.

• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]):

Jul 14, 2005:

5:56 PM Changeset in webkit [9793]

• 21 copies
  3 deletes in tags/WebKit-412~6~2

This commit was manufactured by cvs2svn to create tag
'WebKit-412~6~2'.

5:56 PM Changeset in webkit [9792] by adele

• 3 edits in branches/Ti-2005-007-branch/WebKit

• WebView.subproj/WebPDFView.m: added #import of WebFrame.h and WebFrameView.h
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): added missing semicolon and fixed typo.

5:55 PM Changeset in webkit [9791] by kdecker

• 1 edit in branches/Safari-2-0-branch/WebKit/WebView.subproj/WebPDFView.m

corrected headers..

5:47 PM Changeset in webkit [9790] by ggaren

• 3 edits in trunk/JavaScriptCore

• fixed: JS test suite expects an out of memory error that our memory efficiency avoids

Reviewed by mjs.

• tests/mozilla/js1_5/Array/regress-157652.js: test now expects normal execution

• tests/mozilla/expected.html:

5:36 PM Changeset in webkit [9789] by kdecker

• 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

5:01 PM Changeset in webkit [9788] by adele

• 2 edits in branches/Ti-2005-007-branch/WebKit

Versioning to Ti-2005-007-branch - WebKit-412.6.2

5:00 PM Changeset in webkit [9787] by adele

• 2 edits in branches/Ti-2005-007-branch/WebCore

Rolling out last fix since this was not picked up for Cambridge.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):

4:53 PM Changeset in webkit [9786] by sullivan

• 9 edits in trunk/WebCore

Reviewed by Ken Kocienda (setFocusNode) and Dave Hyatt (everything).

• WebCore part of fix for: <rdar://problem/4181227> webpages incorrectly use standard instead of secondary highlighting in certain cases

Test cases added: none, doesn't affect layout

There were two different problems leading to the same symptom, both of which needed to be fixed.
The first problem was that ancient and unneeded code in setFocusNode(0) was setting the focus
to the enclosing WebHTMLView. The second problem was that the WebHTMLView didn't learn about
form controls resigning first-responder-hood, and so didn't update the displayed focus state.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Removed a line of code that was setting the focus on the WebHTMLView whenever a form control lost focus. This doesn't make sense in a world where the focus might be moving to something outside of the web page entirely. This line of code was added ages ago to fix Radar 3037974, which is not reproducible anymore with this line of code removed.

• kwq/WebCoreBridge.h: New bridge method -formControlIsResigningFirstResponder:, used to inform WebKit that a form control is losing first-responder-hood.

• kwq/KWQButton.mm: (-[KWQButton resignFirstResponder]): call formControlIsResigningFirstResponder:

• kwq/KWQComboBox.mm: (-[KWQPopUpButton resignFirstResponder]): ditto

• kwq/KWQListBox.mm: (-[KWQTableView resignFirstResponder]): ditto

• kwq/KWQSlider.mm: (-[KWQSlider resignFirstResponder]): ditto

• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView resignFirstResponder]): ditto

• kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): ditto

4:52 PM Changeset in webkit [9785] by sullivan

• 4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

• WebKit part of fix for: <rdar://problem/4181227> webpages incorrectly use standard instead of secondary highlighting in certain cases

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge formControlIsResigningFirstResponder:]): Implementation of new method defined in WebCore, passes call along to WebHTMLView

• WebView.subproj/WebHTMLViewInternal.h: declare _formControlIsResigningFirstResponder: so bridge can call it

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusState]): just moved in file so it could be called from a different category (-[WebHTMLView _formControlIsResigningFirstResponder:]): new method, updates focus state

4:51 PM Changeset in webkit [9784] by sullivan

• 2 edits in trunk/WebKit

added missing #import to fix build

• WebView.subproj/WebPDFView.m

4:40 PM Changeset in webkit [9783] by kdecker

• 5 edits in branches/Ti-2005-007-branch/WebKit

Merged fix for <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

4:06 PM Changeset in webkit [9782] by kdecker

• 5 edits in trunk/WebKit

Reviewed by cblu

Fixed: <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

• WebView.subproj/WebFrame.m: (-[WebFrame _safeLoadURL:]): added
• WebView.subproj/WebFrameInternal.h:
• WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]): (-[WebPDFView PDFViewWillClickOnLink:withURL:]): prevents evilness with a call to _safeLoadURL
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): factored calling out to the bridge, and instead call _safeLoadURL

3:32 PM Changeset in webkit [9781] by ggaren

• 4 edits in trunk/JavaScriptCore

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4006 testkjs doesn't implement gc()

• test failure: ecma_3/Function/regress-104584.js

Reviewed by mjs.

• kjs/interpreter.cpp: (Interpreter::finalCheck): removed misleading while && comment

• kjs/testkjs.cpp: added "gc" function to global object (TestFunctionImp::): (TestFunctionImp::call): (main):

• tests/mozilla/expected.html:

2:48 PM Changeset in webkit [9780] by adele

• 5 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4180841> [GENENTECH] window.opener not available when child opened via target="_new"

2005-07-14 Vicki Murley <​vicki@apple.com>

Reviewed by Kocienda.

• WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4180841> [GENENTECH] window.opener not available when child opened via target="_new"

2005-07-14 Vicki Murley <​vicki@apple.com>

Reviewed by Kocienda.

• WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

1:58 PM Changeset in webkit [9779]

• 32 copies
  3 deletes in tags/JavaScriptCore-412~1~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~1~1'.

1:58 PM Changeset in webkit [9778] by adele

• 2 edits in branches/gcc-4-0-branch/JavaScriptCore

Versioning for gcc-4-0-branch - JavaScriptCore-412.1.1

1:55 PM Changeset in webkit [9777]

• 54 copies
  2 deletes in tags/WebCore-413~0~7

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~7'.

1:55 PM Changeset in webkit [9776] by adele

• 2 edits in branches/gcc-4-0-branch/WebCore

Merged changes from TOT.

2005-03-11 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

1:54 PM Changeset in webkit [9775] by justing

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by mjs

• Fixes <rdar://problem/4124326> [RTL] Lines in messages with Hebrew text and numbers are truncated by Tiger Mail

Mail sends plaintext when a message doesn't have any formatting, plaintext depends on
innertext, which depends on TextIterators. A TextIterator iterates over text boxes
in render order, but assumes logical order, which was causing the problems.

Test cases added:

• layout-tests/fast/text/international/bidi-innertext-expected.txt: Added.
• layout-tests/fast/text/international/bidi-innertext.html: Added.

• khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

If the text node contains reversed text, sort the text boxes (m_sortedTextBoxes).
Not all reversed text will be out of logical order, but this simple check is less expensive
than doing an exhaustive one. Most text is LTR and an exhaustive check might hurt performance.

(khtml::TextIterator::handleTextBox):

Iterates over sorted text boxes when necessary

• khtml/editing/visible_text.h:
• khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::position):

If asked to position a text box with reversed text, modify m_containsReversedText

• khtml/rendering/render_text.h: (khtml::InlineTextBox::operator ==): Added to facilitate sorting (khtml::InlineTextBox::operator <): Ditto (khtml::RenderText::containsReversedText):

1:53 PM Changeset in webkit [9774]

• 16 copies
  3 deletes in tags/WebKit-412~0~3

This commit was manufactured by cvs2svn to create tag
'WebKit-412~0~3'.

1:53 PM Changeset in webkit [9773] by adele

• 3 edits in branches/gcc-4-0-branch/WebKit

Versioning for gcc-4-0-branch - WebKit-412.0.3

1:51 PM Changeset in webkit [9772] by justing

• 5 edits
  2 adds in trunk

Reviewed by mjs

• Fixes <rdar://problem/4124326> [RTL] Lines in messages with Hebrew text and numbers are truncated by Tiger Mail Mail sends plaintext when a message doesn't have any formatting, plaintext depends on innertext, which depends on TextIterators. A TextIterator iterates over text boxes in render order, but assumes logical order, which was causing the problems.

Test cases added:

• layout-tests/fast/text/international/bidi-innertext-expected.txt: Added.
• layout-tests/fast/text/international/bidi-innertext.html: Added.

• khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

If the text node contains reversed text, sort the text boxes (m_sortedTextBoxes).
Not all reversed text will be out of logical order, but this simple check is less expensive
than doing an exhaustive one. Most text is LTR and an exhaustive check might hurt performance.

(khtml::TextIterator::handleTextBox):

Iterates over sorted text boxes when necessary

• khtml/editing/visible_text.h:
• khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::position):

If asked to position a text box with reversed text, modify m_containsReversedText

• khtml/rendering/render_text.h: (khtml::InlineTextBox::operator ==): Added to facilitate sorting (khtml::InlineTextBox::operator <): Ditto (khtml::RenderText::containsReversedText):

1:23 PM Changeset in webkit [9771] by justing

• 3 edits
  2 adds in trunk

Patch by Anders Carlsson and justin

Reviewed by mjs

Fixes the following related bugs:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3298> insertRow generates DOM Exception if TABLE does not possess a TBODY
<rdar://problem/4045213> insertRow fails on a <table> that has no <tbody> but does have other children in the DOM
<rdar://problem/3609576> insertRow() on table object containing any characters but no TR & TD elements fails (3476)

Does a better job of maintaining the firstBody variable so that it's not invalidated on .innerHTML = ""
Better check for when to add an implicit tbody to hold the inserted row.

Test cases added: (NONE)

• layout-tests/fast/dom/HTMLTableElement/insert-row-expected.txt: Added.
• layout-tests/fast/dom/HTMLTableElement/insert-row.html: Added.

• khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::~HTMLTableElementImpl): (DOM::HTMLTableElementImpl::setTBody): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::childrenChanged):
• khtml/html/html_tableimpl.h:

12:51 PM Changeset in webkit [9770] by vicki

• 5 edits in branches/Safari-1-3-branch

WebCore:

• merge this fix from HEAD

2005-07-14 Vicki Murley <​vicki@apple.com>

Reviewed by Kocienda.

• WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

• merge this fix from HEAD

2005-07-14 Vicki Murley <​vicki@apple.com>

Reviewed by Kocienda.

• WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

12:06 PM Changeset in webkit [9769] by vicki

• 2 edits
  1 add in trunk/WebCore

Reviewed by hyatt, patch from Carsten Guenther.

• fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3855

Test cases added:

• manual-tests/bugzilla-3855.html: Added.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): check for the existence of the cell renderer

11:27 AM Changeset in webkit [9768] by ggaren

• 70 edits in trunk/JavaScriptCore

-rolled in patches for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3945
[PATCH] Safe merges of comments and other trivialities from KDE's kjs

-patch by Martijn Klingens <​klingens@kde.org>

• kjs/array_instance.h:
• kjs/array_object.cpp:
• kjs/array_object.h:
• kjs/bool_object.cpp:
• kjs/bool_object.h:
• kjs/collector.cpp:
• kjs/collector.h:
• kjs/completion.h:
• kjs/context.h:
• kjs/date_object.cpp:
• kjs/date_object.h:
• kjs/debugger.cpp:
• kjs/debugger.h:
• kjs/dtoa.h:
• kjs/error_object.cpp:
• kjs/error_object.h:
• kjs/function.cpp:
• kjs/function.h:
• kjs/function_object.cpp:
• kjs/function_object.h:
• kjs/grammar.y:
• kjs/identifier.cpp:
• kjs/identifier.h:
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/interpreter.cpp:
• kjs/interpreter.h:
• kjs/interpreter_map.cpp:
• kjs/interpreter_map.h:
• kjs/lexer.cpp:
• kjs/lexer.h:
• kjs/list.cpp:
• kjs/list.h:
• kjs/lookup.cpp:
• kjs/lookup.h:
• kjs/math_object.cpp:
• kjs/math_object.h:
• kjs/nodes.cpp:
• kjs/nodes.h:
• kjs/nodes2string.cpp:
• kjs/number_object.cpp:
• kjs/number_object.h:
• kjs/object.cpp:
• kjs/object.h:
• kjs/object_object.cpp:
• kjs/object_object.h:
• kjs/operations.cpp:
• kjs/operations.h:
• kjs/property_map.cpp:
• kjs/property_map.h:
• kjs/reference.cpp:
• kjs/reference.h:
• kjs/reference_list.cpp:
• kjs/reference_list.h:
• kjs/regexp.cpp:
• kjs/regexp.h:
• kjs/regexp_object.cpp:
• kjs/regexp_object.h:
• kjs/scope_chain.cpp:
• kjs/scope_chain.h:
• kjs/simple_number.h:
• kjs/string_object.cpp:
• kjs/string_object.h:
• kjs/testkjs.cpp:
• kjs/types.h:
• kjs/ustring.cpp:
• kjs/ustring.h:
• kjs/value.cpp:
• kjs/value.h:

11:13 AM Changeset in webkit [9767] by ggaren

• 4 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3970
throw statements fail inside eval statements

Reviewed by mjs.

• kjs/function.cpp: (KJS::GlobalFuncImp::call): Big change since I fixed the tabbing. The important part is: if (c.complType() == Throw) exec->setException(c.value());

• kjs/nodes.cpp: (ThrowNode::execute): removed duplicate KJS_CHECKEXCEPTION (TryNode::execute): try now clears the exception state before the finally block executes, and checks the state after the block executes, so that exceptions in finally code get caught.

• tests/mozilla/expected.html:

11:08 AM Changeset in webkit [9766] by vicki

• 1 edit
  2 adds in trunk/WebCore

• added manual tests for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Test cases added:

• manual-tests/target_new-1.html: Added.
• manual-tests/target_new.html: Added.

11:05 AM Changeset in webkit [9765] by adele

• 2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for:
<rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):

10:58 AM Changeset in webkit [9764] by ggaren

• 3 edits
  2 adds in trunk

• landed fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3677> Safari fail to access a second time an element whose content was dynamically modified.

• patch by Anders Carlsson <​andersca@mac.com>.

Reviewed by mjs + darin.

Test cases added:

• layout-tests/fast/dom/ids/duplicate-ids-expected.txt: Added.
• layout-tests/fast/dom/ids/duplicate-ids.html: Added.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): If no element in the id dict can be found and we know that there's at least one other element with the same id around, then traverse the document and insert the new element in the id table.

(DocumentImpl::addElementById):
(DocumentImpl::removeElementById):
Increment and decrement the id count accordingly.

• khtml/xml/dom_docimpl.h: Add QDict for id counts. Make element QDict mutable.

10:55 AM Changeset in webkit [9763] by adele

• 2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for:
<rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):

10:52 AM Changeset in webkit [9762] by adele

• 2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for :
<rdar://problem/4118278> mail divide by zero navigating messages

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):

10:44 AM Changeset in webkit [9761] by adele

• 2 edits in branches/gcc-4-0-branch/WebCore

Merged changes from TOT.

2005-03-11 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

10:38 AM Changeset in webkit [9760] by adele

• 2 edits in branches/gcc-4-0-branch/JavaScriptCore

Merged changes from TOT

2005-04-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris.

<rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com

• kjs/string_object.cpp: (StringObjectFuncImp::call): Allocate adopted ustring buffer properly.

10:33 AM Changeset in webkit [9759] by adele

• 30 edits in branches/gcc-4-0-branch

JavaScriptCore:

Merged changes from TOT.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by Maciej.

• kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present

• kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.

• kjs/grammar.cpp: Regenerated.

2005-04-20 Darin Adler <Darin Adler>

Reviewed by Maciej.

• speedups, total 12% on JavaScript iBench

I ran the benchmark under Shark and followed its advice a lot, mainly.

• kjs/collector.cpp: (KJS::Collector::allocate): Take out special case for 0; costing speed but unexercised. Use numLiveObjectsAtLastCollect instead of numAllocationsSinceLastCollect so we don't have to bump it each time we call allocate. Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset rather than a pointer so we don't need a special case for NULL. Allow freeList to point to some bogus item when the entire block is full rather than going out of our way to make it point to NULL. (KJS::Collector::markProtectedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::collect): Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset as above. Put numLiveObjects into a local variable to cut down on global variable accesses. Set numLiveObjectsAtLastCollect rather than numAllocationsSinceLastCollect. (KJS::Collector::numReferencedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::rootObjectClasses): Ditto.

• kjs/internal.h: Make Value be a friend of NumberImp so it can construct number objects directly, avoiding the conversion from Number to Value.

• kjs/internal.cpp: (StringImp::toObject): Don't use Object::dynamicCast, because we know the thing is an object and we don't want to do all the extra work; just cast directly.

• kjs/list.cpp: (KJS::List::List): Construct valueRefCount in a way that avoids the need for a branch -- in the hot case this just meant avoiding checking a variable we just set to false.

• kjs/lookup.cpp: (keysMatch): Marked this inline.

• kjs/nodes.cpp: Disabled KJS_BREAKPOINT, to avoid calling hitStatement all the time. (BooleanNode::evaluate): Make a Value directly, rather than making a Boolean which is converted into a Value. (NumberNode::evaluate): Ditto. (StringNode::evaluate): Ditto. (ArrayNode::evaluate): Ditto. (FunctionCallNode::evaluate): Use new inline baseIfMutable to avoid unnecessary getBase function. Also just use a pointer for func, rather than an Object. (PostfixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (DeleteNode::evaluate): Make a Value directly. (TypeOfNode::evaluate): Use new inline baseIfMutable and make Value directly. (PrefixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (UnaryPlusNode::evaluate): Make a Value directly. (NegateNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (BitwiseNotNode::evaluate): Make a Value directly. (LogicalNotNode::evaluate): Ditto. (ShiftNode::evaluate): Don't convert to a double before making a Value. (RelationalNode::evaluate): Make a Value directly. (EqualNode::evaluate): Ditto. (BitOperNode::evaluate): Ditto. (AssignNode::evaluate): Make a Value directly. Change code so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (VarDeclNode::evaluate): Make a Value directly. (ForNode::execute): Remove unused local variable.

• kjs/operations.h: (KJS::isNaN): Inlined. (KJS::isInf): Ditto. (KJS::isPosInf): Ditto. (KJS::isNegInf): Ditto.

• kjs/operations.cpp: Change isNaN, isInf, isPosInf, and isNegInf to be inlines. (KJS::equal): Rewrite to avoid creating values and recursing back into the function. (KJS::relation): Rearranged code so that we don't need explicit isNaN checks. (KJS::add): Changed code to make Value directly, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (KJS::mult): Ditto.

• kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::clear): Ditto. Clear value pointer in addition to key, so we can just look at the value pointer in the mark function. (KJS::PropertyMap::get): Get sizeMask and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::put): Ditto. (KJS::PropertyMap::insert): Ditto. (KJS::PropertyMap::remove): Ditto. (KJS::PropertyMap::mark): Get size and entries pointer outside loop to avoid re-getting them inside the loop. Don't bother checking key for 0, since we already have to check value for 0. (Also had to change clear() to set value to 0.) (KJS::PropertyMap::addEnumerablesToReferenceList): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Ditto. (KJS::PropertyMap::save): Ditto.

• other changes

• kjs/protected_values.h: Remove unneeded class name qualifiers.

• kjs/reference.h: (KJS::Reference::baseIfMutable): New inline function: replaces isMutable(). (KJS::Reference::Reference): Inlined.
• kjs/reference.cpp: (KJS::Reference::getValue): Rewrite to not use getBase. (KJS::Reference::putValue): Ditto. (KJS::Reference::deleteValue): Dittol

• kjs/simple_number.h: (KJS::SimpleNumber::integerFits): Added. For use when the parameter is known to be integral.

• kjs/string_object.cpp: (StringProtoFuncImp::call): Create the number without first converting to double in various cases that involve integers.

• kjs/ustring.h: (KJS::UString::attach): Inlined. (KJS::UString::release): Inlined.
• kjs/ustring.cpp: (KJS::UString::find): Get first character outside the loop instead of re-fetching it each time.

• kjs/value.cpp: (Value::Value): Added overloads for all the various specific types of values, so you don't have to convert from, say, Number to Value, just to create one. (Number::Number): Added an overload that takes a boolean to indicate the number is already known to be an integer.

• kjs/value.h: Added more Value constructors, added a version of toNumber that returns a boolean to indicate if the number is known to be an integer (because it was a "simple number"). (KJS::ValueImp::marked): Inlined. (KJS::ValueImp::dispatchType): Inlined. (KJS::ValueImp::dispatchToPrimitive): Inlined. (KJS::ValueImp::dispatchToBoolean): Inlined. (KJS::ValueImp::dispatchToNumber): Inlined. (KJS::ValueImp::dispatchToString): Inlined. (KJS::ValueImp::dispatchToUInt32): Inlined.

2005-04-14 Maciej Stachowiak <​mjs@apple.com>

• make fast_malloc.h a private header, not project

• JavaScriptCore.pbproj/project.pbxproj:

2005-04-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Richard.

<rdar://problem/4089734> JavaScript iBench can be sped up ~10% with custom allocator

• use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

• JavaScriptCore.pbproj/project.pbxproj:
• kjs/collector.cpp: (KJS::Collector::allocate): Use dlmalloc to allocate the collector blocks. (KJS::Collector::collect): And dlfree to free it.
• kjs/fast_malloc.cpp: Added, just the standard dlmalloc here.
• kjs/fast_malloc.h: Added. Declarations for the functions. Also added a handy macro to give a class custom operator new/delete
• kjs/identifier.cpp: (KJS::Identifier::add): Use dlmalloc/dlfree.
• kjs/nodes.h: make nodes KJS_FAST_ALLOCATED.
• kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Use dlmalloc/dlfree. (KJS::PropertyMap::rehash): ditto
• kjs/scope_chain.h:
• kjs/ustring.cpp: (KJS::UString::Rep::createCopying): New named constructor that copies a passed-in buffer, to hide allocation details from webcore. (KJS::UString::UString): use createCopying when appropriate. (KJS::UString::Rep::destroy): Use dlmalloc/dlfree. (KJS::UString::expandedSize): likewise (KJS::UString::expandCapacity): likewise (KJS::UString::expandPreCapacity): likewise (KJS::UString::spliceSubstringsWithSeparators): likewise (KJS::UString::append): likewise (KJS::UString::operator=): likewise (KJS::UString::detach): likewise
• kjs/ustring.h: make UString and UString::Rep KJS_FAST_ALLOCATED.

2005-04-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

<rdar://problem/4086819> Avoid using protect count hash table so much for 5.6% JS iBench speedup

• Avoid using protected values hash for the two most common cases
• Bump up ListImp high water mark, new testing shows 508 ListImps are created during JS iBench.

Net result is a 5.6% speedup on JavaScript iBench

• kjs/collector.cpp: (KJS::Collector::collect): mark protected lists as appropriate.
• kjs/context.h:
• kjs/list.cpp: (KJS::ListImp::markValues): Moved implementation from List::markValues (KJS::List::markProtectedLists): Implemented - scan pool and overflow list. (KJS::allocateListImp): link lists outside the pool into a separate doubly linked list to be able to mark protected lists (KJS::deallocateListImp): do the corresponding delinking (KJS::List::derefValues): do nothing in conservative GC mode (KJS::List::refValues): do nothing in conservative GC mode (KJS::List::markValues): call ListImp version (KJS::List::append):
• kjs/list.h:

WebCore:

Merged change from TOT.

2005-04-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Richard.

• use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

• khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
• khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent):
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):

10:24 AM Changeset in webkit [9758] by ggaren

• 4 edits
  2 adds in trunk

JavaScriptCore:

-landed fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3412
Object.prototype is missing toLocaleString

• patch by Mark Rowe (bdash) <​opendarwin.org@bdash.net.nz>

-layout test info in webcore changelog

Reviewed by mjs.

• kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
• kjs/object_object.h: (KJS::ObjectProtoFuncImp::):

WebCore:

-landed layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3412
Object.prototype is missing toLocaleString

Reviewed by mjs.

Test cases added:

• layout-tests/fast/js/object-prototype-toLocaleString-expected.txt: Added.
• layout-tests/fast/js/object-prototype-toLocaleString.html: Added.

9:29 AM Changeset in webkit [9757] by vicki

• 5 edits in trunk

WebCore:

Reviewed by Kocienda.

• WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

Reviewed by Kocienda.

• WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

• WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

Jul 13, 2005:

9:48 PM Changeset in webkit [9756] by mjs

• 6 edits
  2 adds in trunk

Reviewed by Kevin.

• convert some more things to use the new hashtable

• khtml/ecma/kjs_binding.cpp: (KJS::domObjects): (KJS::domNodesPerDocument): (KJS::ScriptInterpreter::getDOMObject): (KJS::ScriptInterpreter::putDOMObject): (KJS::ScriptInterpreter::deleteDOMObject): (KJS::ScriptInterpreter::forgetDOMObject): (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): (KJS::ScriptInterpreter::mark): (KJS::ScriptInterpreter::updateDOMNodeDocument):
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_window.h: Include QPtrDict header
• khtml/ecma/xmlhttprequest.h: ditto

• fix a bug with remove of a nonexistent key - it used to trash the table

• khtml/misc/hashtable.h: (khtml::::remove):

7:43 PM Changeset in webkit [9755] by justing

• 10 edits in trunk/WebKit

Reviewed by John

Rolling in changes necessary to build with newer versions of gcc 4.0

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]):
• Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
• Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithLowercasedScheme]): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
• WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]):
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
• WebView.subproj/WebFrame.m: (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]):
• WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): (-[WebView mainFrameTitle]):

7:32 PM Changeset in webkit [9754] by justing

• 10 edits in trunk/WebCore

Reviewed by mjs

Rolled in workarounds necessary to build with a gcc 4.0 regression introduced in build 5208:
<rdar://problem/4175534> Regression in gcc-5208 "comparison of distinct Objective-C types lacks a cast" warning
Problems overloading methods that take Objective-C typed arguments

• kwq/KWQCursor.h:
• kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):
• kwq/KWQKCursor.mm: (KCursor::crossCursor): (KCursor::handCursor): (KCursor::sizeAllCursor): (KCursor::ibeamCursor): (KCursor::waitCursor): (KCursor::whatsThisCursor): (KCursor::eastResizeCursor): (KCursor::northResizeCursor): (KCursor::northEastResizeCursor): (KCursor::northWestResizeCursor): (KCursor::southResizeCursor): (KCursor::southEastResizeCursor): (KCursor::southWestResizeCursor): (KCursor::westResizeCursor):
• kwq/KWQKJobClasses.mm: (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
• kwq/KWQSignal.h:
• kwq/KWQSignal.mm: (KWQSignal::callWithData): (KWQSignal::callWithResponse):
• kwq/KWQSlot.h:
• kwq/KWQSlot.mm: (KWQSlot::callWithData): (KWQSlot::callWithResponse):
• kwq/KWQWidget.mm: (QWidget::cursor):

7:22 PM Changeset in webkit [9753] by justing

• 15 edits in trunk/WebCore

Reviewed by mjs

Rolling in changes necessary to build with newer versions of gcc 4.0

• kwq/DOM-CSS.mm: (+[DOMCSSPrimitiveValue _valueWithImpl:]):
• kwq/DOMEvents.h:
• kwq/DOMInternal.h: (addDOMWrapper):
• kwq/KWQButton.mm: (QButton::setWritingDirection):
• kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage):
• kwq/KWQComboBox.mm: (QComboBox::setWritingDirection): (QComboBox::populateMenu):
• kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::fileWrapperForElement):
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit):
• kwq/KWQListBox.mm: (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::doneAppendingItems): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::setWritingDirection):
• kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
• kwq/KWQTextArea.mm: (-[KWQTextArea _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView _enclosingTextArea]): (-[KWQTextAreaTextView _resizeCornerRect]):
• kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): (QTextEdit::setWritingDirection): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setPalette):
• kwq/KWQWidget.mm: (QWidget::hasFocus):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:30 PM Changeset in webkit [9752] by adele

• 1 edit in branches/Safari-1-3-branch/WebCore/WebCore.pbproj/project.pbxproj

Rolling out accidental checkin of bad version string.

5:26 PM Changeset in webkit [9751] by sullivan

• 3 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

• cleaned up Find-related experimental code that I checked in a while back

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): remove variant of this method that had findInSelection flag; this method is now the same as it was on Tiger.

• WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

5:26 PM Changeset in webkit [9750] by sullivan

• 5 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

• cleaned up Find-related experimental code that I checked in a while back

• kwq/KWQKHTMLPart.h: remove findInSelection flag from findString()
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): remove findInSelection flag. Always search the selection first, but if the found range is the same as the selection range, then search again from beyond the selection.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): remove findInSelection flag

5:16 PM Changeset in webkit [9749] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-13 Adele Peterson <​adele@apple.com>

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.

Test cases added: None. This test case involves tabbing to form controls and scrolling.

• kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]):

5:14 PM Changeset in webkit [9748] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-13 Adele Peterson <​adele@apple.com>

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.

Test cases added: None. This test case involves tabbing to form controls and scrolling.

• kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]):

5:10 PM Changeset in webkit [9747] by adele

• 2 edits in trunk/WebCore

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.

Test cases added: None. This test case involves tabbing to form controls and scrolling.

• kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]):

4:46 PM Changeset in webkit [9746]

• 67 copies
  2 deletes in tags/WebCore-315~8

This commit was manufactured by cvs2svn to create tag
'WebCore-315~8'.

4:46 PM Changeset in webkit [9745] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Maciej.

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): removed isnan calls and used IS_NAN macro instead to get this to build on Panther.

3:50 PM Changeset in webkit [9744]

• 8 copies
  3 deletes in tags/JavaScriptCore-312~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~1'.

3:50 PM Changeset in webkit [9743] by adele

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning for Safari-1-3-branch - JavaScriptCore-312.1

3:45 PM Changeset in webkit [9742] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.8

3:42 PM Changeset in webkit [9741]

• 21 copies
  3 deletes in tags/WebKit-312~3

This commit was manufactured by cvs2svn to create tag 'WebKit-312~3'.

3:42 PM Changeset in webkit [9740] by adele

• 2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.3

Jul 12, 2005:

10:26 PM Changeset in webkit [9739] by adele

• 6 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164992>

2005-05-04 Chris Blumenberg <​cblu@apple.com>

Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value

Reviewed by john.

Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
• WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
• WebView.subproj/WebResourcePrivate.h:

10:18 PM Changeset in webkit [9738] by adele

• 12 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164991>

2005-05-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively

Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.

• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
• khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
• khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
• khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
• khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
• khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
• khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
• khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
• khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):

10:08 PM Changeset in webkit [9737] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4165001>

2005-05-27 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)

• khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
• khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.

9:52 PM Changeset in webkit [9736] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4165000>

2005-05-05 David Hyatt <​hyatt@apple.com>

Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.

The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.

Reviewed by John Sullivan

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
• khtml/xml/dom_docimpl.h:
• layout-tests/fast/dynamic/flash-replacement-test.html: Added.

9:38 PM Changeset in webkit [9735] by adele

• 8 edits in branches/Safari-1-3-branch

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164997>

2005-04-26 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

Reviewed by Chris.

• Plugins.subproj/npfunctions.h:
• Plugins.subproj/npruntime.h:

Merged fix from TOT to Safari-1-3-branch

<rdar://problem/4164997>

2005-04-26 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:

Their NPN_SetException has the following signature:

void NPN_SetException(NPObject *npobj, const NPUTF8 *message);

ours has:

void NPN_SetException (NPObject * npobj, const NPString *message);

Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.

I changed both behaviors to match Mozilla.

Reviewed by Chris.

• bindings/NP_jsobject.cpp: (_NPN_SetException):
• bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
• bindings/npruntime.h:
• bindings/npruntime_impl.h:

9:25 PM Changeset in webkit [9734] by adele

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164993>

2005-05-02 Darin Adler <Darin Adler>

Reviewed by Vicki.
Added two layout tests for regression testing.

• redid frameElement (fix for 4091082 below)

The first version lacked a security check, and was also broken.

• khtml/ecma/kjs_window.cpp: (frameElement): Refactored into separate function; added isSafeScript check. (Window::get): Call the new frameElement function.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"

• khtml/ecma/kjs_window.h: Added FrameElement.
• khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
• khtml/ecma/kjs_window.lut.h: Regenerated.

6:08 PM Changeset in webkit [9733] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4178198>

2005-07-12 Kevin Decker <​kdecker@apple.com>

Reviewed by cblu.

Fixed:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3968

<rdar://problem/4172645> REGRESSION: top frame only loads at banking site - ​http://www.skandiabanken.no

Test cases added: None; This fixes a race condition that is not reproducible locally.

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): If a redirect was scheduled during a load, then stop the current load. Otherwise when the current load transitions from a provisional to a committed state, pending redirects may be cancelled.

6:07 PM Changeset in webkit [9732] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4178198>

2005-07-12 Kevin Decker <​kdecker@apple.com>

Reviewed by cblu.

Fixed:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3968

<rdar://problem/4172645> REGRESSION: top frame only loads at banking site - ​http://www.skandiabanken.no

Test cases added: None; This fixes a race condition that is not reproducible locally.

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): If a redirect was scheduled during a load, then stop the current load. Otherwise when the current load transitions from a provisional to a committed state, pending redirects may be cancelled. (KHTMLPart::scheduleLocationChange):

6:02 PM Changeset in webkit [9731] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4176180>

2005-07-07 Adele Peterson <​adele@apple.com>

change by Maciej, reviewed by me.

fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)

No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
called twice for the same document, and this can cause some nodes to unnecessarily remain in the
m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
list after removing all event listeners for the disconnected nodes.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):

6:01 PM Changeset in webkit [9730] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4176180>

2005-07-07 Adele Peterson <​adele@apple.com>

change by Maciej, reviewed by me.

fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)

No test cases added. There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
called twice for the same document, and this can cause some nodes to unnecessarily remain in the
m_disconnectedNodesWithEventListeners list. This fix just clears the m_disconnectedNodesWithEventListeners
list after removing all event listeners for the disconnected nodes.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):

5:57 PM Changeset in webkit [9729] by adele

• 8 edits in branches/Safari-1-3-branch

WebCore:

Merged WebCore part of fix from TOT to Safari-1-3-branch
<rdar://problem/4176173>

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

• better fix for <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3445

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

• khtml/khtml_part.cpp: (KHTMLPart::stopLoading): Factored out from closeURL, make firing of unload and detaching of event handlers optional. (KHTMLPart::closeURL): call stopLoading(true)
• khtml/khtml_part.h:
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge stopLoading]): Call stopLoading(false).

WebKit:

Merged WebKit part of fix from TOT to Safari-1-3-branch
<rdar://problem/4176173>

2005-06-13 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg and Adele.

• better fix for <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3445

With this change and the matching WebKit change we'll still stop loading the moment you click
a download link, but the unload event and detaching of event handlers will not happen early any more.

• WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]): call stopLoading on bridge instead of closeURL.
• WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Revert previous attempt at fix. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): ditto (-[WebFrame stopLoading]): ditto

2005-06-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris Blumenberg.

• fixed <rdar://problem/4142247> REGRESSION: List to browse widgets at Apple website failed. Closing tab afterwards caused Safari crash ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3445

• WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Stop loading the non-provisional data source before swapping in the provisional. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Stop only the provisional load here, we would not want to stop loading if this navigation later turns into a download or is cancelled before being committed. (-[WebFrame stopLoading]): Factored a bit. (-[WebFrame _cancelProvisionalLoad]): New method to stop only provisional load, and cancel any pending policy deicions. (-[WebFrame _stopNonProvisionalLoadOnly]): New mthod that stops only the main load.

3:46 PM Changeset in webkit [9728]

• 54 copies
  2 deletes in tags/WebCore-413~0~6

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~6'.

3:46 PM Changeset in webkit [9727]

• 77 copies in tags/Safari-Char-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-Char-anchor'.

3:46 PM Changeset in webkit [9726] by justing

• 2 edits in branches/gcc-4-0-branch/WebCore

WebCore-413.0.5

3:38 PM Changeset in webkit [9725] by adele

• 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164989>

2005-05-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

• fixed <rdar://problem/3598589> onunload handler doesn't fire when a window is closed

Test cases added:

• layout-tests/fast/events/onunload-expected.txt: Added.
• layout-tests/fast/events/onunload.html: Added.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Don't remove all event handlers from the document here...
• khtml/khtml_part.cpp: (KHTMLPart::closeURL): ...instead do it here, after firing the unload event, but only if the document is not in the back/forward cache...
• kwq/KWQPageState.mm: (-[KWQPageState finalize]): ...and take care of the back/forward cache case here.

3:28 PM Changeset in webkit [9724] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164978>

2005-06-24 Darin Adler <Darin Adler>

Reviewed by Justin Garcia.

• fixed <rdar://problem/4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"

Test cases added:

• layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
• layout-tests/fast/dom/anchor-backslash.html: Added.

• kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore "?" and "#" characters if they were the first character in the string.

3:27 PM Changeset in webkit [9723] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164978>

2005-06-24 Darin Adler <Darin Adler>

Reviewed by Justin Garcia.

• fixed <rdar://problem/4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"

Test cases added:

• layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
• layout-tests/fast/dom/anchor-backslash.html: Added.

• kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore "?" and "#" characters if they were the first character in the string.

3:21 PM Changeset in webkit [9722] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164975>

2005-05-23 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4122661> Regression: 10.3.8-10.3.9: Next lesson doesn't work on Dale Carnegie Action Systems page

• khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::tryCall): added checks for NaN, in case it is passed into window.open for screenx, screeny, left, top, height, or width.

3:19 PM Changeset in webkit [9721] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164975>

2005-05-23 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4122661> Regression: 10.3.8-10.3.9: Next lesson doesn't work on Dale Carnegie Action Systems page

• khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::tryCall): added checks for NaN, in case it is passed into window.open for screenx, screeny, left, top, height, or width.

3:15 PM Changeset in webkit [9720] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164969> A crash occurs when invoking assigned access key on a Button element (DOM::HTMLButtonElementImpl::click(bool) + 36)

2005-06-17 Geoffrey Garen <​ggaren@apple.com>

Patch contributed by Anders Carlsson<​andersca@mac.com>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

• khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
• khtml/html/html_formimpl.h: Ditto.

3:14 PM Changeset in webkit [9719] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164969> A crash occurs when invoking assigned access key on a Button element (DOM::HTMLButtonElementImpl::click(bool) + 36)

2005-06-17 Geoffrey Garen <​ggaren@apple.com>

Patch contributed by Anders Carlsson<​andersca@mac.com>.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Reviewed by Darin.

Test cases added: None. Test requires manual interaction.
Manual test available at: ​http://bugzilla.opendarwin.org/attachment.cgi?id=2207

• khtml/html/html_formimpl.cpp: Eliminated HTMLButtonElementImpl::click. HTMLButtonElementImpl now inherits HTMLElementImpl::click.
• khtml/html/html_formimpl.h: Ditto.

3:06 PM Changeset in webkit [9718] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164967>

2005-06-17 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3419 <rdar://problem/4111752> REGRESSION (125-312/412): Safari doesn't display edmunds.com pages first time through

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): set 'script' flag when parsing <script src="foo" /> case. In this case, parseTag calls the scriptHandler function which expects that flag to be set, and sets it back to false at the appropriate time.

3:05 PM Changeset in webkit [9717] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164967>

2005-06-17 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3419 <rdar://problem/4111752> REGRESSION (125-312/412): Safari doesn't display edmunds.com pages first time through

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): set 'script' flag when parsing <script src="foo" /> case. In this case, parseTag calls the scriptHandler function which expects that flag to be set, and sets it back to false at the appropriate time.

3:00 PM Changeset in webkit [9716] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164964>

2005-05-05 David Hyatt <​hyatt@apple.com>

Eliminate the FOUCS on wired.com. innerWidth and innerHeight on window should not do a layout that ignores
pending stylesheets, since even if stylesheets are loading the correct window dimensions can be determined with
a normal layout.

The radar # is 4109888.

Reviewed by rjw

• khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
• khtml/ecma/kjs_window.h:

2:59 PM Changeset in webkit [9715] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164964>

2005-05-05 David Hyatt <​hyatt@apple.com>

Eliminate the FOUCS on wired.com. innerWidth and innerHeight on window should not do a layout that ignores
pending stylesheets, since even if stylesheets are loading the correct window dimensions can be determined with
a normal layout.

The radar # is 4109888.

Reviewed by rjw

• khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
• khtml/ecma/kjs_window.h:

2:52 PM Changeset in webkit [9714] by kdecker

• 2 edits in trunk/WebCore

Reviewed by cblu.

Fixed:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3968

<rdar://problem/4172645> REGRESSION: top frame only loads at banking site - ​http://www.skandiabanken.no

Test cases added: None; This fixes a race condition that is not reproducible locally.

• khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): If a redirect was scheduled during a load, then stop the current load. Otherwise when the current load transitions from a provisional to a committed state, pending redirects may be cancelled.

2:36 PM Changeset in webkit [9713] by eseidel

• 2 edits in trunk/WebKitTools

Submitted by: eseidel
Reviewed by: mjs

• checkout-svg: Fixed error with symlink creation.

2:18 PM Changeset in webkit [9712] by adele

• 7 edits in branches/Safari-1-3-branch/WebCore

Merged for from TOT to Safari-1-3-branch
<rdar://problem/4164960>

2005-04-29 Darin Adler <Darin Adler>

Reviewed by Chris Blumenberg.
Added two layout tests for regression testing.

• fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Reorganized and partly rewrote this. The change that fixes the bug at hand is to explicitly use XHTML_NAMESPACE for HTML elements, since the old way of getting the namespace will return the null string for HTML elements, and createElementNS will not create an HTML element if passed a null string for the namespace. (DocumentImpl::processHttpEquiv): Removed some bogus getDocument() calls -- no need to call getDocument() in a document object. (DocumentImpl::attrName): Ditto. (DocumentImpl::tagName): Ditto. (DocumentImpl::setFocusNode): Ditto.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Moved the actual cloning here from ElementImpl::cloneNode, because XMLElementImpl already had its own version, and in here we can use createHTMLElement, which will work properly even in an XML document, and is also slightly more efficient.

• khtml/xml/dom_nodeimpl.h: Added a namespaceURI method function to go along with localName.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::namespaceURI): Added. Returns null string to be consistent with localName (only works on certain types of elements as documented).
• khtml/xml/dom_elementimpl.h: Removed ElementImpl::cloneNode (see above). Added an override of namespaceURI for XMLElementImpl.
• khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::namespaceURI): Added. Returns the namespace (consistent with localName).

• layout-tests/fast/dom/importNodeHTML.html: Added. Tests both importNode and cloneNode (for comparison).
• layout-tests/fast/dom/importNodeHTML-expected.txt: Added.
• layout-tests/fast/dom/importNodeXML.xhtml: Added. XML version of the same test as above. Tests a different code path, so useful to have.
• layout-tests/fast/dom/importNodeXML-expected.txt: Added.

2:16 PM Changeset in webkit [9711] by adele

• 7 edits in branches/Safari-2-0-branch/WebCore

Merged for from TOT to Safari-2-0-branch
<rdar://problem/4164960>

2005-04-29 Darin Adler <Darin Adler>

Reviewed by Chris Blumenberg.
Added two layout tests for regression testing.

• fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Reorganized and partly rewrote this. The change that fixes the bug at hand is to explicitly use XHTML_NAMESPACE for HTML elements, since the old way of getting the namespace will return the null string for HTML elements, and createElementNS will not create an HTML element if passed a null string for the namespace. (DocumentImpl::processHttpEquiv): Removed some bogus getDocument() calls -- no need to call getDocument() in a document object. (DocumentImpl::attrName): Ditto. (DocumentImpl::tagName): Ditto. (DocumentImpl::setFocusNode): Ditto.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Moved the actual cloning here from ElementImpl::cloneNode, because XMLElementImpl already had its own version, and in here we can use createHTMLElement, which will work properly even in an XML document, and is also slightly more efficient.

• khtml/xml/dom_nodeimpl.h: Added a namespaceURI method function to go along with localName.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::namespaceURI): Added. Returns null string to be consistent with localName (only works on certain types of elements as documented).
• khtml/xml/dom_elementimpl.h: Removed ElementImpl::cloneNode (see above). Added an override of namespaceURI for XMLElementImpl.
• khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::namespaceURI): Added. Returns the namespace (consistent with localName).

• layout-tests/fast/dom/importNodeHTML.html: Added. Tests both importNode and cloneNode (for comparison).
• layout-tests/fast/dom/importNodeHTML-expected.txt: Added.
• layout-tests/fast/dom/importNodeXML.xhtml: Added. XML version of the same test as above. Tests a different code path, so useful to have.
• layout-tests/fast/dom/importNodeXML-expected.txt: Added.

2:13 PM Changeset in webkit [9710] by eseidel

• 1 edit
  1 add in trunk/WebKitTools

Submitted by: eseidel
Reviewed by: mjs

• checkout-svg: Added. Script to check out WebCore+SVG

2:10 PM Changeset in webkit [9709] by vicki

• 2 edits in branches/Safari-2-0-branch/WebCore

• merge this fix from HEAD

2005-04-22 David Hyatt <​hyatt@apple.com>

Fix for 4096681, fix regression in how the list-style property is parsed. It no longer parses when it hits
a url in the property value list now, because the list pointer did not get advanced. This fixes alistapart.com.

Reviewed by john

• khtml/css/cssparser.cpp: (CSSParser::parseValue):

2:08 PM Changeset in webkit [9708] by vicki

• 2 edits in branches/Safari-1-3-branch/WebCore

• merge this fix from HEAD

2005-04-22 David Hyatt <​hyatt@apple.com>

Fix for 4096681, fix regression in how the list-style property is parsed. It no longer parses when it hits
a url in the property value list now, because the list pointer did not get advanced. This fixes alistapart.com.

Reviewed by john

• khtml/css/cssparser.cpp: (CSSParser::parseValue):

2:06 PM Changeset in webkit [9707] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merge fix from TOT to Safari-2-0-branch
<rdar://problem/4164959>

2005-04-22 David Hyatt <​hyatt@apple.com>

Fix for 4096878, drop shadow effect not displayed correctly on tbray.org/ongoing/. Block minmaxwidth was
broken when negative margins were used and did not properly decrease the max width.

Reviewed by Maciej

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcBlockMinMaxWidth):

2:04 PM Changeset in webkit [9706] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merge fix from TOT to Safari-1-3-branch
<rdar://problem/4164959>

2005-04-22 David Hyatt <​hyatt@apple.com>

Fix for 4096878, drop shadow effect not displayed correctly on tbray.org/ongoing/. Block minmaxwidth was
broken when negative margins were used and did not properly decrease the max width.

Reviewed by Maciej

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcBlockMinMaxWidth):

1:58 PM Changeset in webkit [9705] by adele

• 6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164953>

2005-04-21 David Hyatt <​hyatt@apple.com>

Fix for 4095839, wrong background image used on flechtwerk.de. Make sure that the global mapped
attribute cache hashed background attributes into per-document buckets.

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::mapToEntry):
• khtml/html/html_elementimpl.h: (DOM::):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::mapToEntry): (HTMLTablePartElementImpl::mapToEntry):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::docID):

1:52 PM Changeset in webkit [9704]

• 54 copies
  2 deletes in tags/WebCore-413~0~5

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~5'.

1:52 PM Changeset in webkit [9703] by justing

• 2 edits in branches/gcc-4-0-branch/WebCore

Reviewed by mjs

• kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):

Didn't KWQRetain() the NSCursor in yesterday's gcc 4.0 workaround

1:50 PM Changeset in webkit [9702] by adele

• 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164953>

2005-04-21 David Hyatt <​hyatt@apple.com>

Fix for 4095839, wrong background image used on flechtwerk.de. Make sure that the global mapped
attribute cache hashed background attributes into per-document buckets.

• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::mapToEntry):
• khtml/html/html_elementimpl.h: (DOM::):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::mapToEntry): (HTMLTablePartElementImpl::mapToEntry):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
• khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::docID):

1:50 PM Changeset in webkit [9701] by justing

• 2 edits in branches/gcc-4-0-branch/WebCore

Reviewed by mjs

• kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):

Didn't KWQRetain() the NSCursor in yesterday's gcc 4.0 workaround

1:26 PM Changeset in webkit [9700] by bdakin

• 8 edits in trunk

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3942 and marquee problems in Radar bug

4172312. Vertical marquees default to 200px, and horizontal marquees do not allow text to be truncated by a too-small height attribute.

Reviewed by Hyatt.

Test cases added: (NONE)

• khtml/html/html_blockimpl.cpp: deleted former changes to make marquee height work correctly. (HTMLMarqueeElementImpl::mapToEntry): (HTMLMarqueeElementImpl::parseMappedAttribute):
• khtml/rendering/render_layer.cpp: this is where the height issues are now addressed (Marquee::updateMarqueeStyle):
• khtml/rendering/render_layer.h: (khtml::):
• khtml/rendering/render_style.h: added function fontSize() (khtml::RenderStyle::fontSize):
• khtml/xml/dom_elementimpl.h: deleted addition of EMarquee hash key (DOM::):
• layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
• layout-tests/fast/css/MarqueeLayoutTest.html: added vertical marquees to test.

1:26 PM Changeset in webkit [9699] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164952>

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.
No test case added because our layout test system doesn't allow us to do inline input.

• fixed <rdar://problem/4094066> REGRESSION (1.2.5-1.3): unconfirmed inline input is ignored in <textarea>, lost when form is submitted

• kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Call setWantsNotificationForMarkedText:YES.

1:23 PM Changeset in webkit [9698] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164952>

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.
No test case added because our layout test system doesn't allow us to do inline input.

• fixed <rdar://problem/4094066> REGRESSION (1.2.5-1.3): unconfirmed inline input is ignored in <textarea>, lost when form is submitted

• kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Call setWantsNotificationForMarkedText:YES.

1:11 PM Changeset in webkit [9697] by adele

• 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164950> Safari crashes if Esc key is held down during series of authentication sheets

2005-05-13 John Sullivan <​sullivan@apple.com>

Reviewed by Kevin.

• fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series of authentication sheets

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as: <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down

1:10 PM Changeset in webkit [9696] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164950> Safari crashes if Esc key is held down during series of authentication sheets

2005-05-13 John Sullivan <​sullivan@apple.com>

Reviewed by Kevin.

• fixed <rdar://problem/4093306> Safari crashes if Esc key is held down during series of authentication sheets

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): retain and autorelease self. This is a workaround for an AppKit key-handling issue, which I wrote up as: <rdar://problem/4118422> Key-down events can be sent to a closed window if a key is kept pressed down

1:06 PM Changeset in webkit [9695] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164949> REGRESSION (Tiger): progressively loaded background images "scroll down" instead of just appearing

2005-04-18 Darin Adler <Darin Adler>

Reviewed by Hyatt.

• fixed <rdar://problem/4092614> REGRESSION (Tiger): progressively loaded background images "scroll around" instead of just appearing

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]): Moved a global inside this function, since it's only used here. (-[WebImageData _cacheImages:allImages:]): Fixed a sizeof that was getting the size of the wrong thing. (-[WebImageData _isSizeAvailable]): Used calloc in a more consistent way. (drawPattern): Removed an unneeded cast. (-[WebImageData tileInRect:fromPoint:context:]): Here's the actual bug fix. Don't use the image size when deciding whether the image needs to be tiled as a pattern nor when creating the pattern: in both cases, use the tile size. The old way was wrong, and the new way works perfectly. Also removed uneeded error message when the image is not yet loaded enough to create a CGImageRef for it -- it's fine to draw nothing in that case.

1:05 PM Changeset in webkit [9694] by adele

• 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164949> REGRESSION (Tiger): progressively loaded background images "scroll down" instead of just appearing

2005-04-18 Darin Adler <Darin Adler>

Reviewed by Hyatt.

• fixed <rdar://problem/4092614> REGRESSION (Tiger): progressively loaded background images "scroll around" instead of just appearing

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]): Moved a global inside this function, since it's only used here. (-[WebImageData _cacheImages:allImages:]): Fixed a sizeof that was getting the size of the wrong thing. (-[WebImageData _isSizeAvailable]): Used calloc in a more consistent way. (drawPattern): Removed an unneeded cast. (-[WebImageData tileInRect:fromPoint:context:]): Here's the actual bug fix. Don't use the image size when deciding whether the image needs to be tiled as a pattern nor when creating the pattern: in both cases, use the tile size. The old way was wrong, and the new way works perfectly. Also removed uneeded error message when the image is not yet loaded enough to create a CGImageRef for it -- it's fine to draw nothing in that case.

12:10 PM Changeset in webkit [9693] by vicki

• 2 edits in branches/Safari-1-3-branch/WebCore

• merge this fix from HEAD

2005-05-12 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

fix for <rdar://problem/4117656> deleting an input element in its onBlur handler crashes Safari

• khtml/rendering/render_form.cpp: (RenderLineEdit::handleFocusOut): added nil check for element

12:09 PM Changeset in webkit [9692] by vicki

• 2 edits in branches/Safari-2-0-branch/WebCore

• merge this fix from HEAD

2005-05-12 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

fix for <rdar://problem/4117656> deleting an input element in its onBlur handler crashes Safari

• khtml/rendering/render_form.cpp: (RenderLineEdit::handleFocusOut): added nil check for element

12:04 PM Changeset in webkit [9691] by vicki

• 2 edits in branches/Safari-1-3-branch/WebCore

• merge this fix from HEAD

2005-07-11 Geoffrey Garen <​ggaren@apple.com>

-fixed rdar://problem/4170960
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3952
iFrame name and id information incorrectly returned

Reviewed by mjs.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): removed misleading comment (HTMLIFrameElementImpl::attach): copied FrameElementImpl behavior for initializing m_name

12:04 PM Changeset in webkit [9690] by vicki

• 2 edits in branches/Safari-2-0-branch/WebCore

• merge this fix from HEAD

2005-07-11 Geoffrey Garen <​ggaren@apple.com>

-fixed rdar://problem/4170960
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3952
iFrame name and id information incorrectly returned

Reviewed by mjs.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): removed misleading comment (HTMLIFrameElementImpl::attach): copied FrameElementImpl behavior for initializing m_name

11:29 AM Changeset in webkit [9689] by adele

• 6 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164941> REGRESSION (1.2.4-1.3): many titles with non-ASCII characters do not display properly (XHTML strict only)

2005-06-22 Anders Carlsson <​andersca@mac.com>

Reviewed and landed by Darin Adler.

Test cases added:

• layout-tests/fast/dom/title-text-property-expected.txt: Added
• layout-tests/fast/dom/title-text-property.html: Added
• layout-tests/fast/dom/title-text-property-expected-2.txt: Added
• layout-tests/fast/dom/title-text-property-2.html: Added

• fixed <rdar://problem/3831364> getting or setting text for a <title> element doesn't work
• fixed <rdar://problem/4091225> REGRESSION (1.2.4-1.3): many titles with non-ASCII characters do not display properly (XHTML strict only)
• fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3586> Setting and getting title's text attribute does not work

• khtml/dom/html_head.cpp: (HTMLTitleElement::text): (HTMLTitleElement::setText): Call HTMLTitleElementImpl::text() and ::setText().

• khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::HTMLTitleElementImpl): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::removedFromDocument): (HTMLTitleElementImpl::childrenChanged): Pass the current title node to DocumentImpl::setTitle and ::removeTitle.

(HTMLTitleElementImpl::text):
Return the title.

(HTMLTitleElementImpl::setText):
Set the new title.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::setTitle): (DocumentImpl::removeTitle):
• khtml/xml/dom_docimpl.h: Only update the title if it's done by setting document.title or by changing the child nodes of the title element.

11:26 AM Changeset in webkit [9688] by adele

• 6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164941> REGRESSION (1.2.4-1.3): many titles with non-ASCII characters do not display properly (XHTML strict only)

2005-06-22 Anders Carlsson <​andersca@mac.com>

Reviewed and landed by Darin Adler.

Test cases added:

• layout-tests/fast/dom/title-text-property-expected.txt: Added
• layout-tests/fast/dom/title-text-property.html: Added
• layout-tests/fast/dom/title-text-property-expected-2.txt: Added
• layout-tests/fast/dom/title-text-property-2.html: Added

• fixed <rdar://problem/3831364> getting or setting text for a <title> element doesn't work
• fixed <rdar://problem/4091225> REGRESSION (1.2.4-1.3): many titles with non-ASCII characters do not display properly (XHTML strict only)
• fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3586> Setting and getting title's text attribute does not work

• khtml/dom/html_head.cpp: (HTMLTitleElement::text): (HTMLTitleElement::setText): Call HTMLTitleElementImpl::text() and ::setText().

• khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::HTMLTitleElementImpl): (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::removedFromDocument): (HTMLTitleElementImpl::childrenChanged): Pass the current title node to DocumentImpl::setTitle and ::removeTitle.

(HTMLTitleElementImpl::text):
Return the title.

(HTMLTitleElementImpl::setText):
Set the new title.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::setTitle): (DocumentImpl::removeTitle):
• khtml/xml/dom_docimpl.h: Only update the title if it's done by setting document.title or by changing the child nodes of the title element.

11:23 AM Changeset in webkit [9687] by vicki

• 2 edits in branches/Safari-2-0-branch/WebKit

• merged this fix from HEAD

2005-07-11 Kevin Decker <​kdecker@apple.com>

Reviewed by cblu and mjs.

Fixed: <rdar://problem/4099552> REGRESSION: Safari 1.3 Netscape API NPN_PostURL[Notify]
no longer allows manual headers

Most plugins (flash) send 2 CRFL's between the header and body of their POST requests, while
the Adboe plugin sends two LF's. This caused us to send custom headers as part of the actual
POST data itself, and correspondently, would skew Content-Length.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[NSData _web_locationAfterFirstBlankLine]): Look for two LF's as well

11:23 AM Changeset in webkit [9686] by vicki

• 2 edits in branches/Safari-1-3-branch/WebKit

• merged this fix from HEAD

2005-07-11 Kevin Decker <​kdecker@apple.com>

Reviewed by cblu and mjs.

Fixed: <rdar://problem/4099552> REGRESSION: Safari 1.3 Netscape API NPN_PostURL[Notify]
no longer allows manual headers

Most plugins (flash) send 2 CRFL's between the header and body of their POST requests, while
the Adboe plugin sends two LF's. This caused us to send custom headers as part of the actual
POST data itself, and correspondently, would skew Content-Length.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[NSData _web_locationAfterFirstBlankLine]): Look for two LF's as well

11:20 AM Changeset in webkit [9685] by ggaren

• 2 edits in trunk/JavaScriptCore

Reviewed by mjs.

• kjs/function.cpp: (KJS::IndexToNameMap::operator[]): fixed infinite recursion bug in last checkin

11:13 AM Changeset in webkit [9684] by ggaren

• 2 edits in trunk

Test cases modified:

• layout-tests/fast/frames/iframe-name-and-id.html: now tests dynamically creating frames[x].name

10:52 AM Changeset in webkit [9683] by vicki

• 2 edits in branches/Safari-1-3-branch/WebCore

• merge this fix from HEAD

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4105097> REGRESSION (138-139): Hitting Enter on a checkbox toggles check mark instead of submitting form

• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): Separate the checks for the space bar and the Enter key and make Enter submit the form on a check box or radio button.

10:52 AM Changeset in webkit [9682] by vicki

• 2 edits in branches/Safari-2-0-branch/WebCore

• merge this fix from HEAD

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4105097> REGRESSION (138-139): Hitting Enter on a checkbox toggles check mark instead of submitting form

• khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): Separate the checks for the space bar and the Enter key and make Enter submit the form on a check box or radio button.

10:44 AM Changeset in webkit [9681] by ggaren

• 4 edits
  1 add in trunk

WebCore:

Added layout test for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3435
Parentheses are backwards in Hebrew text (no bidi mirroring?)

Test is manual because results only reflect visually -
the layout is the same either way.

Test cases added:

• manual-tests/bidi-parens.html: Added.

WebKit:

-rolled in patch by ​opendarwin.org@mitzpettel.com
for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3435
Parentheses are backwards in Hebrew text (no bidi mirroring?)

Reviewed by mjs.

Layout test added to WebCore.

• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _initializeATSUStyle]): (applyMirroringToRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):

10:42 AM Changeset in webkit [9680] by vicki

• 2 edits in branches/Safari-1-3-branch/WebCore

• merge this fix from HEAD

2005-04-25 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item

• kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types. Test cases added: (NONE)

10:37 AM Changeset in webkit [9679] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
<rdar://problem/4164939> Selects wrapped by Span or Label elements do not resize when options are added via javascript

2005-06-17 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Test cases added: None, since this test requires manual interaction.

• fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements do not resize when options are added via javascript

• khtml/rendering/render_form.cpp: (RenderSelect::layout): Remove call setting setNeedsLayout to true. setNeedsLayout is already true at this point, and this additional call has the negative effect of marking m_normalChildNeedsLayout on the element's parent, which keeps layout from propagating all the way up to the root later on.

10:36 AM Changeset in webkit [9678] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164939> Selects wrapped by Span or Label elements do not resize when options are added via javascript

2005-06-17 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Test cases added: None, since this test requires manual interaction.

• fixed <rdar://problem/4086793> Selects wrapped by Span or Label elements do not resize when options are added via javascript

• khtml/rendering/render_form.cpp: (RenderSelect::layout): Remove call setting setNeedsLayout to true. setNeedsLayout is already true at this point, and this additional call has the negative effect of marking m_normalChildNeedsLayout on the element's parent, which keeps layout from propagating all the way up to the root later on.

9:57 AM Changeset in webkit [9677] by adele

• 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164931> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp

2005-05-11 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4061979> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp

• khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement): added a nil check for the document
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inDocument): added check for document in case the document has been destroyed before the node has been removed. A lot of code already assumes that if inDocument returns true, a document exists.

9:48 AM Changeset in webkit [9676] by ggaren

• 4 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3881
arguments object should share values with function parameters

Reviewed by mjs.

ArgumentsImp now uses a simple hash lookup to share values
with the activation object.

• kjs/function.cpp: (KJS::FunctionImp::getParameterName): (KJS::IndexToNameMap::IndexToNameMap): (KJS::IndexToNameMap::~IndexToNameMap): (KJS::IndexToNameMap::isMapped): (KJS::IndexToNameMap::unMap): (KJS::IndexToNameMap::operator[]): (KJS::ArgumentsImp::ArgumentsImp): (KJS::ArgumentsImp::mark): (KJS::ArgumentsImp::get): (KJS::ArgumentsImp::put): (KJS::ArgumentsImp::deleteProperty): (KJS::ArgumentsImp::hasOwnProperty): (KJS::ActivationImp::createArgumentsObject):
• kjs/function.h:
• tests/mozilla/expected.html: updated results

9:37 AM Changeset in webkit [9675] by kocienda

• 2 edits in trunk/WebCore

Reviewed by me

Test cases added: (NONE)

• kwq/KWQTextCodec.mm: Fix build breakage. /me is a real genius.

9:32 AM Changeset in webkit [9674] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4164931> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp

2005-05-11 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4061979> crash in DOM::ElementImpl::setAttribute at www.nitto-kohki.co.jp

• khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement): added a nil check for the document
• khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inDocument): added check for document in case the document has been destroyed before the node has been removed. A lot of code already assumes that if inDocument returns true, a document exists.

9:29 AM Changeset in webkit [9673] by kocienda

• 6 edits
  1 delete in trunk

WebCore:

Reviewed by Chris Blumenberg

Test cases added: (NONE)

Switched over from TEC to ICU for unicode text conversion. TEC support has now been
removed from KWQTextCodec. I just added this dual support yesterday, and while Maciej
and I agreed that it was good to land in the tree in case we run into problems in the
near future, we also agreed that cutting over to using ICU full time right now is
probably the best way to find bugs.

• kwq/KWQTextCodec.mm: Removed TEC support. (QTextCodec::fromUnicode): Ditto. (KWQTextDecoder::KWQTextDecoder): Ditto. (KWQTextDecoder::~KWQTextDecoder): Ditto. (KWQTextDecoder::convert): Ditto.
• kwq/WebCoreBridge.h: Removed some glue that allowed the converters to be changed at runtime.
• kwq/WebCoreTextConversionMethod.h: Removed. This also was glue for the runtime switch.
• WebCore.pbproj/project.pbxproj: Removed WebCoreTextConversionMethod.h file.

WebKit:

Reviewed by Chris Blumenberg

• WebCoreSupport.subproj/WebBridge.m: Removed some glue that allowed one of two unicode (TEC or ICU ) to be chosen at runtime. I just added this dual support yesterday, and while Maciej and I agreed that it was good to land in the tree in case we run into problems in the near future, we also agreed that cutting over to using ICU full time right now is probably the best way to find bugs.

9:24 AM Changeset in webkit [9672] by adele

• 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merging fix from TOT to Safari-2-0-branch
<rdar://problem/4164929> String.replace() method not working when regex pattern contains {n, m}

2005-06-21 Adele Peterson <​adele@apple.com>

Patch from Anders Carlsson <​andersca@mac.com>, reviewed by Darin.

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

• pcre/pcre.c: (pcre_compile): Remember the last char length so it can be subtracted correctly if needed.

9:23 AM Changeset in webkit [9671] by adele

• 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Merging fix from TOT to Safari-1-3-branch
<rdar://problem/4164929> String.replace() method not working when regex pattern contains {n, m}

2005-06-21 Adele Peterson <​adele@apple.com>

Patch from Anders Carlsson <​andersca@mac.com>, reviewed by Darin.

Fixed: <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/3881901> String.replace() method not working when regex pattern contains {n, m}

• pcre/pcre.c: (pcre_compile): Remember the last char length so it can be subtracted correctly if needed.

12:20 AM Changeset in webkit [9670] by eseidel

• 1 edit
  2 adds in trunk/WebCore

Bug #: 3961
Submitted by: andersca
Reviewed by: hyatt

• icu/unicode/ucnv.h: Added.
• icu/unicode/ucnv_err.h: Added. Fixes build break for externals caused by KWQTextCodec.mm changes. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3961