Context Navigation

← Previous Period
Next Period →

Timeline

Jul 15, 2005:

11:45 PM Changeset in webkit [9818] by adele

4 edits
2 adds in trunk

Written by Anders Carlsson <andersca@mac.com>
Reviewed by Dave Hyatt.

Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3653>

Test cases added:
layout-tests/fast/dom/createDocumentType.html: Added
layout-tests/fast/dom/createDocumentType-expected.txt: Added

khtml/xml/dom_nodeimpl.cpp: (DocumentPtr::nullDocumentPtr):
khtml/xml/dom_nodeimpl.h: Add nullDocumentPtr() function which returns a shared DocumentPtr object whose document always is 0.

khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocumentType): Pass nullDocumentPtr as the document type's document.

11:17 PM Changeset in webkit [9817] by adele

3 edits
3 adds in trunk

Written by Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.

Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3808>

Test cases added:

layout-tests/fast/js/location-assign.html: Added.
layout-tests/fast/js/location-assign-expected.txt: Added.
layout-tests/fast/js/resources/new-location.html: Added.

khtml/ecma/kjs_window.cpp: (KJS::Location::get): (KJS::LocationFunc::tryCall):
khtml/ecma/kjs_window.h: (KJS::Location::): Implement location.assign.

10:53 PM Changeset in webkit [9816] by adele

2 edits in trunk/WebKit

Written by Trey Matteson <trey@usa.net>
Reviewed by John Sullivan.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3910 - REGRESSION: Replying "Cancel" to the form repost nag leaves wrong b/f cursor

WebView.subproj/WebFrame.m: (-[WebFrame _resetBackForwardList]): new helper method (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): If the delegate bailed on the navigation, tell the main frame to reset the b/f cursor back to where it was before we started.

10:39 PM Changeset in webkit [9815] by adele

7 edits in trunk

Updated layout tests for formatting changes from change for
http://bugzilla.opendarwin.org/show_bug.cgi?id=3601

layout-tests/fast/dom/outerText-no-element-expected.txt:
layout-tests/fast/dynamic/outerHTML-no-element-expected.txt:
layout-tests/fast/js/array-every-expected.txt:
layout-tests/fast/js/array-foreach-expected.txt:
layout-tests/fast/js/array-some-expected.txt:
layout-tests/fast/js/toString-stack-overflow-expected.txt:

3:59 PM Changeset in webkit [9814] by sullivan

3 edits in trunk/WebKit

Written by Trey Matteson
Reviewed by me.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4013

text find doesn't wrap in PDF files

This just works once WebPDFView implements the WebDocumentText protocol, which is
mostly just a matter of forwarding the methods to PDFKit appropriately.

WebView.subproj/WebPDFView.h:
WebView.subproj/WebPDFView.m: (-[WebPDFView supportsTextEncoding]): (-[WebPDFView string]): (-[WebPDFView attributedString]): (-[WebPDFView selectedString]): (-[WebPDFView selectedAttributedString]): (-[WebPDFView selectAll]): (-[WebPDFView deselectAll]):

3:16 PM Changeset in webkit [9813] by sullivan

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

fixed <rdar://problem/4181884> Searching for text that overlaps selection works differently in PDFView than in HTMLView

WebView.subproj/WebPDFView.m: (PDFSelectionsAreEqual): new function, stand-in for nonexistent -[PDFSelection isEqual:] since calling isEqual: on two identical PDFSelections returns NO (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): Make search algorithm match that in WebCore: initially search inside selection, then check for the case where the found text exactly matches the previous selection, and search from past the selection if so. The implementation is slightly more complicated than it should be due to PDFKit API limitations (about which I added FIXMEs and filed bugs)

1:35 PM Changeset in webkit [9812] by sullivan

2 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

fixed these bugs: <rdar://problem/4181875> Searching for text that overlaps selection works differently in WebTextView than in HTMLView <rdar://problem/3393678> Find not finding text in plain (non-HTML) if all text is selected

Misc.subproj/WebSearchableTextView.m: (-[NSString findString:selectedRange:options:wrap:]): Make search algorithm match that in WebCore: initially search inside selection, then check for the case where the found text exactly matches the previous selection, and search from past the selection if so.

11:06 AM Changeset in webkit [9811]

68 copies
2 deletes in tags/WebCore-315~9

This commit was manufactured by cvs2svn to create tag
'WebCore-315~9'.

11:06 AM Changeset in webkit [9810] by adele

2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Safari-1-3-branch - WebCore-315.9

11:05 AM Changeset in webkit [9809] by adele

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-15 Kevin Decker <kdecker@apple.com>

Reviewed by Adele

Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

11:02 AM Changeset in webkit [9808]

88 copies
2 deletes in tags/WebCore-415~13

This commit was manufactured by cvs2svn to create tag
'WebCore-415~13'.

11:02 AM Changeset in webkit [9807]

122 copies in branches/Safari-OC-branch

This commit was manufactured by cvs2svn to create branch
'Safari-OC-branch'.

11:02 AM Changeset in webkit [9806]

122 copies in tags/Safari-OC-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-OC-anchor'.

11:02 AM Changeset in webkit [9805] by adele

2 edits in branches/Safari-2-0-branch/WebCore

fix versioning for Safari-2-0-branch - WebCore-415.13

10:58 AM Changeset in webkit [9804] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.12

10:56 AM Changeset in webkit [9803] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-15 Kevin Decker <kdecker@apple.com>

Reviewed by Adele

Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

10:50 AM Changeset in webkit [9802] by kdecker

2 edits in trunk/WebCore

Reviewed by Adele

Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=4009
Test cases added: none, doesn't affect layout

khtml/khtml_part.cpp: (KHTMLPart::scheduleLocationChange): Corrected an earlier mistake of testing an always non-zero constant.

10:32 AM Changeset in webkit [9801]

11 copies
3 deletes in tags/JavaScriptCore-412~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~5'.

10:32 AM Changeset in webkit [9800] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning for Safari-2-0-branch - JavaScriptCore-412.5

10:28 AM Changeset in webkit [9799]

25 copies
3 deletes in tags/WebKit-412~7

This commit was manufactured by cvs2svn to create tag 'WebKit-412~7'.

10:28 AM Changeset in webkit [9798] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.7

10:23 AM Changeset in webkit [9797]

21 copies
3 deletes in tags/WebKit-312~5

This commit was manufactured by cvs2svn to create tag 'WebKit-312~5'.

10:23 AM Changeset in webkit [9796] by adele

2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.5

9:58 AM Changeset in webkit [9795] by ggaren

5 edits in trunk/JavaScriptCore

-rolled in KDE fixes for http://bugzilla.opendarwin.org/show_bug.cgi?id=3601
Error instance type info

Reviewed by mjs.

kjs/error_object.cpp:
Created ErrorInstanceImp class for Error() objects.
Changed parent object for Native Errors to "Function" (matches ECMA spec). (ErrorInstanceImp::ErrorInstanceImp): (ErrorProtoFuncImp::call): (ErrorObjectImp::construct): (NativeErrorImp::construct):

kjs/error_object.h: (KJS::ErrorInstanceImp::classInfo):
kjs/object.h: made comment more informative about ClassInfo

tests/mozilla/expected.html:

9:55 AM Changeset in webkit [9794] by adele

2 edits in branches/Safari-2-0-branch/WebKit

added missing line from last fix.

WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]):

Jul 14, 2005:

5:56 PM Changeset in webkit [9793]

21 copies
3 deletes in tags/WebKit-412~6~2

This commit was manufactured by cvs2svn to create tag
'WebKit-412~6~2'.

5:56 PM Changeset in webkit [9792] by adele

3 edits in branches/Ti-2005-007-branch/WebKit

WebView.subproj/WebPDFView.m: added #import of WebFrame.h and WebFrameView.h
WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): added missing semicolon and fixed typo.

5:55 PM Changeset in webkit [9791] by kdecker

1 edit in branches/Safari-2-0-branch/WebKit/WebView.subproj/WebPDFView.m

corrected headers..

5:47 PM Changeset in webkit [9790] by ggaren

3 edits in trunk/JavaScriptCore

fixed: JS test suite expects an out of memory error that our memory efficiency avoids

Reviewed by mjs.

tests/mozilla/js1_5/Array/regress-157652.js: test now expects normal execution

tests/mozilla/expected.html:

5:36 PM Changeset in webkit [9789] by kdecker

5 edits in branches/Safari-2-0-branch/WebKit

Merged fix for <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

5:01 PM Changeset in webkit [9788] by adele

2 edits in branches/Ti-2005-007-branch/WebKit

Versioning to Ti-2005-007-branch - WebKit-412.6.2

5:00 PM Changeset in webkit [9787] by adele

2 edits in branches/Ti-2005-007-branch/WebCore

Rolling out last fix since this was not picked up for Cambridge.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):

4:53 PM Changeset in webkit [9786] by sullivan

9 edits in trunk/WebCore

Reviewed by Ken Kocienda (setFocusNode) and Dave Hyatt (everything).

WebCore part of fix for: <rdar://problem/4181227> webpages incorrectly use standard instead of secondary highlighting in certain cases

Test cases added: none, doesn't affect layout

There were two different problems leading to the same symptom, both of which needed to be fixed.
The first problem was that ancient and unneeded code in setFocusNode(0) was setting the focus
to the enclosing WebHTMLView. The second problem was that the WebHTMLView didn't learn about
form controls resigning first-responder-hood, and so didn't update the displayed focus state.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Removed a line of code that was setting the focus on the WebHTMLView whenever a form control lost focus. This doesn't make sense in a world where the focus might be moving to something outside of the web page entirely. This line of code was added ages ago to fix Radar 3037974, which is not reproducible anymore with this line of code removed.

kwq/WebCoreBridge.h: New bridge method -formControlIsResigningFirstResponder:, used to inform WebKit that a form control is losing first-responder-hood.

kwq/KWQButton.mm: (-[KWQButton resignFirstResponder]): call formControlIsResigningFirstResponder:

kwq/KWQComboBox.mm: (-[KWQPopUpButton resignFirstResponder]): ditto

kwq/KWQListBox.mm: (-[KWQTableView resignFirstResponder]): ditto

kwq/KWQSlider.mm: (-[KWQSlider resignFirstResponder]): ditto

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView resignFirstResponder]): ditto

kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): ditto

4:52 PM Changeset in webkit [9785] by sullivan

4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

WebKit part of fix for: <rdar://problem/4181227> webpages incorrectly use standard instead of secondary highlighting in certain cases

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge formControlIsResigningFirstResponder:]): Implementation of new method defined in WebCore, passes call along to WebHTMLView

WebView.subproj/WebHTMLViewInternal.h: declare _formControlIsResigningFirstResponder: so bridge can call it

WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusState]): just moved in file so it could be called from a different category (-[WebHTMLView _formControlIsResigningFirstResponder:]): new method, updates focus state

4:51 PM Changeset in webkit [9784] by sullivan

2 edits in trunk/WebKit

added missing #import to fix build

WebView.subproj/WebPDFView.m

4:40 PM Changeset in webkit [9783] by kdecker

5 edits in branches/Ti-2005-007-branch/WebKit

Merged fix for <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

4:06 PM Changeset in webkit [9782] by kdecker

5 edits in trunk/WebKit

Reviewed by cblu

Fixed: <rdar://problem/4122282> clicking a link in an PDF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

WebView.subproj/WebFrame.m: (-[WebFrame _safeLoadURL:]): added
WebView.subproj/WebFrameInternal.h:
WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]): (-[WebPDFView PDFViewWillClickOnLink:withURL:]): prevents evilness with a call to _safeLoadURL
WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): factored calling out to the bridge, and instead call _safeLoadURL

3:32 PM Changeset in webkit [9781] by ggaren

4 edits in trunk/JavaScriptCore

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4006 testkjs doesn't implement gc()

test failure: ecma_3/Function/regress-104584.js

Reviewed by mjs.

kjs/interpreter.cpp: (Interpreter::finalCheck): removed misleading while && comment

kjs/testkjs.cpp: added "gc" function to global object (TestFunctionImp::): (TestFunctionImp::call): (main):

tests/mozilla/expected.html:

2:48 PM Changeset in webkit [9780] by adele

5 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4180841> [GENENTECH] window.opener not available when child opened via target="_new"

2005-07-14 Vicki Murley <vicki@apple.com>

Reviewed by Kocienda.

WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

WebKit:

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4180841> [GENENTECH] window.opener not available when child opened via target="_new"

2005-07-14 Vicki Murley <vicki@apple.com>

Reviewed by Kocienda.

WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

1:58 PM Changeset in webkit [9779]

32 copies
3 deletes in tags/JavaScriptCore-412~1~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~1~1'.

1:58 PM Changeset in webkit [9778] by adele

2 edits in branches/gcc-4-0-branch/JavaScriptCore

Versioning for gcc-4-0-branch - JavaScriptCore-412.1.1

1:55 PM Changeset in webkit [9777]

54 copies
2 deletes in tags/WebCore-413~0~7

This commit was manufactured by cvs2svn to create tag
'WebCore-413~0~7'.

1:55 PM Changeset in webkit [9776] by adele

2 edits in branches/gcc-4-0-branch/WebCore

Merged changes from TOT.

2005-03-11 David Harrison <harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

1:54 PM Changeset in webkit [9775] by justing

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by mjs

Fixes <rdar://problem/4124326> [RTL] Lines in messages with Hebrew text and numbers are truncated by Tiger Mail

Mail sends plaintext when a message doesn't have any formatting, plaintext depends on
innertext, which depends on TextIterators. A TextIterator iterates over text boxes
in render order, but assumes logical order, which was causing the problems.

Test cases added:

layout-tests/fast/text/international/bidi-innertext-expected.txt: Added.
layout-tests/fast/text/international/bidi-innertext.html: Added.

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

If the text node contains reversed text, sort the text boxes (m_sortedTextBoxes).
Not all reversed text will be out of logical order, but this simple check is less expensive
than doing an exhaustive one. Most text is LTR and an exhaustive check might hurt performance.

(khtml::TextIterator::handleTextBox):

Iterates over sorted text boxes when necessary

khtml/editing/visible_text.h:
khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::position):

If asked to position a text box with reversed text, modify m_containsReversedText

khtml/rendering/render_text.h: (khtml::InlineTextBox::operator ==): Added to facilitate sorting (khtml::InlineTextBox::operator <): Ditto (khtml::RenderText::containsReversedText):

1:53 PM Changeset in webkit [9774]

16 copies
3 deletes in tags/WebKit-412~0~3

This commit was manufactured by cvs2svn to create tag
'WebKit-412~0~3'.

1:53 PM Changeset in webkit [9773] by adele

3 edits in branches/gcc-4-0-branch/WebKit

Versioning for gcc-4-0-branch - WebKit-412.0.3

1:51 PM Changeset in webkit [9772] by justing

5 edits
2 adds in trunk

Reviewed by mjs

Fixes <rdar://problem/4124326> [RTL] Lines in messages with Hebrew text and numbers are truncated by Tiger Mail Mail sends plaintext when a message doesn't have any formatting, plaintext depends on innertext, which depends on TextIterators. A TextIterator iterates over text boxes in render order, but assumes logical order, which was causing the problems.

Test cases added:

layout-tests/fast/text/international/bidi-innertext-expected.txt: Added.
layout-tests/fast/text/international/bidi-innertext.html: Added.

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

If the text node contains reversed text, sort the text boxes (m_sortedTextBoxes).
Not all reversed text will be out of logical order, but this simple check is less expensive
than doing an exhaustive one. Most text is LTR and an exhaustive check might hurt performance.

(khtml::TextIterator::handleTextBox):

Iterates over sorted text boxes when necessary

khtml/editing/visible_text.h:
khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::position):

If asked to position a text box with reversed text, modify m_containsReversedText

khtml/rendering/render_text.h: (khtml::InlineTextBox::operator ==): Added to facilitate sorting (khtml::InlineTextBox::operator <): Ditto (khtml::RenderText::containsReversedText):

1:23 PM Changeset in webkit [9771] by justing

3 edits
2 adds in trunk

Patch by Anders Carlsson and justin

Reviewed by mjs

Fixes the following related bugs:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3298> insertRow generates DOM Exception if TABLE does not possess a TBODY
<rdar://problem/4045213> insertRow fails on a <table> that has no <tbody> but does have other children in the DOM
<rdar://problem/3609576> insertRow() on table object containing any characters but no TR & TD elements fails (3476)

Does a better job of maintaining the firstBody variable so that it's not invalidated on .innerHTML = ""
Better check for when to add an implicit tbody to hold the inserted row.

Test cases added: (NONE)

layout-tests/fast/dom/HTMLTableElement/insert-row-expected.txt: Added.
layout-tests/fast/dom/HTMLTableElement/insert-row.html: Added.

khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::~HTMLTableElementImpl): (DOM::HTMLTableElementImpl::setTBody): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::childrenChanged):
khtml/html/html_tableimpl.h:

12:51 PM Changeset in webkit [9770] by vicki

5 edits in branches/Safari-1-3-branch

WebCore:

merge this fix from HEAD

2005-07-14 Vicki Murley <vicki@apple.com>

Reviewed by Kocienda.

WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

WebKit:

merge this fix from HEAD

2005-07-14 Vicki Murley <vicki@apple.com>

Reviewed by Kocienda.

WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

12:06 PM Changeset in webkit [9769] by vicki

2 edits
1 add in trunk/WebCore

Reviewed by hyatt, patch from Carsten Guenther.

fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3855

Test cases added:

manual-tests/bugzilla-3855.html: Added.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): check for the existence of the cell renderer

11:27 AM Changeset in webkit [9768] by ggaren

70 edits in trunk/JavaScriptCore

-rolled in patches for http://bugzilla.opendarwin.org/show_bug.cgi?id=3945
[PATCH] Safe merges of comments and other trivialities from KDE's kjs

-patch by Martijn Klingens <klingens@kde.org>

kjs/array_instance.h:
kjs/array_object.cpp:
kjs/array_object.h:
kjs/bool_object.cpp:
kjs/bool_object.h:
kjs/collector.cpp:
kjs/collector.h:
kjs/completion.h:
kjs/context.h:
kjs/date_object.cpp:
kjs/date_object.h:
kjs/debugger.cpp:
kjs/debugger.h:
kjs/dtoa.h:
kjs/error_object.cpp:
kjs/error_object.h:
kjs/function.cpp:
kjs/function.h:
kjs/function_object.cpp:
kjs/function_object.h:
kjs/grammar.y:
kjs/identifier.cpp:
kjs/identifier.h:
kjs/internal.cpp:
kjs/internal.h:
kjs/interpreter.cpp:
kjs/interpreter.h:
kjs/interpreter_map.cpp:
kjs/interpreter_map.h:
kjs/lexer.cpp:
kjs/lexer.h:
kjs/list.cpp:
kjs/list.h:
kjs/lookup.cpp:
kjs/lookup.h:
kjs/math_object.cpp:
kjs/math_object.h:
kjs/nodes.cpp:
kjs/nodes.h:
kjs/nodes2string.cpp:
kjs/number_object.cpp:
kjs/number_object.h:
kjs/object.cpp:
kjs/object.h:
kjs/object_object.cpp:
kjs/object_object.h:
kjs/operations.cpp:
kjs/operations.h:
kjs/property_map.cpp:
kjs/property_map.h:
kjs/reference.cpp:
kjs/reference.h:
kjs/reference_list.cpp:
kjs/reference_list.h:
kjs/regexp.cpp:
kjs/regexp.h:
kjs/regexp_object.cpp:
kjs/regexp_object.h:
kjs/scope_chain.cpp:
kjs/scope_chain.h:
kjs/simple_number.h:
kjs/string_object.cpp:
kjs/string_object.h:
kjs/testkjs.cpp:
kjs/types.h:
kjs/ustring.cpp:
kjs/ustring.h:
kjs/value.cpp:
kjs/value.h:

11:13 AM Changeset in webkit [9767] by ggaren

4 edits in trunk/JavaScriptCore

-fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3970
throw statements fail inside eval statements

Reviewed by mjs.

kjs/function.cpp: (KJS::GlobalFuncImp::call): Big change since I fixed the tabbing. The important part is: if (c.complType() == Throw) exec->setException(c.value());

kjs/nodes.cpp: (ThrowNode::execute): removed duplicate KJS_CHECKEXCEPTION (TryNode::execute): try now clears the exception state before the finally block executes, and checks the state after the block executes, so that exceptions in finally code get caught.

tests/mozilla/expected.html:

11:08 AM Changeset in webkit [9766] by vicki

1 edit
2 adds in trunk/WebCore

added manual tests for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Test cases added:

manual-tests/target_new-1.html: Added.
manual-tests/target_new.html: Added.

11:05 AM Changeset in webkit [9765] by adele

2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for:
<rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari

Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):

10:58 AM Changeset in webkit [9764] by ggaren

3 edits
2 adds in trunk

landed fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=3677> Safari fail to access a second time an element whose content was dynamically modified.

patch by Anders Carlsson <andersca@mac.com>.

Reviewed by mjs + darin.

Test cases added:

layout-tests/fast/dom/ids/duplicate-ids-expected.txt: Added.
layout-tests/fast/dom/ids/duplicate-ids.html: Added.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): If no element in the id dict can be found and we know that there's at least one other element with the same id around, then traverse the document and insert the new element in the id table.

(DocumentImpl::addElementById):
(DocumentImpl::removeElementById):
Increment and decrement the id count accordingly.

khtml/xml/dom_docimpl.h: Add QDict for id counts. Make element QDict mutable.

10:55 AM Changeset in webkit [9763] by adele

2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for:
<rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):

10:52 AM Changeset in webkit [9762] by adele

2 edits in branches/gcc-4-0-branch/WebKit

Merged fix for :
<rdar://problem/4118278> mail divide by zero navigating messages

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):

10:44 AM Changeset in webkit [9761] by adele

2 edits in branches/gcc-4-0-branch/WebCore

Merged changes from TOT.

2005-03-11 David Harrison <harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

10:38 AM Changeset in webkit [9760] by adele

2 edits in branches/gcc-4-0-branch/JavaScriptCore

Merged changes from TOT

2005-04-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Chris.

<rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com

kjs/string_object.cpp: (StringObjectFuncImp::call): Allocate adopted ustring buffer properly.

10:33 AM Changeset in webkit [9759] by adele

30 edits in branches/gcc-4-0-branch

JavaScriptCore:

Merged changes from TOT.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by Maciej.

kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by John.

fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present

kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.

kjs/grammar.cpp: Regenerated.

2005-04-20 Darin Adler <Darin Adler>

Reviewed by Maciej.

speedups, total 12% on JavaScript iBench

I ran the benchmark under Shark and followed its advice a lot, mainly.

kjs/collector.cpp: (KJS::Collector::allocate): Take out special case for 0; costing speed but unexercised. Use numLiveObjectsAtLastCollect instead of numAllocationsSinceLastCollect so we don't have to bump it each time we call allocate. Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset rather than a pointer so we don't need a special case for NULL. Allow freeList to point to some bogus item when the entire block is full rather than going out of our way to make it point to NULL. (KJS::Collector::markProtectedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::collect): Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset as above. Put numLiveObjects into a local variable to cut down on global variable accesses. Set numLiveObjectsAtLastCollect rather than numAllocationsSinceLastCollect. (KJS::Collector::numReferencedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::rootObjectClasses): Ditto.

kjs/internal.h: Make Value be a friend of NumberImp so it can construct number objects directly, avoiding the conversion from Number to Value.

kjs/internal.cpp: (StringImp::toObject): Don't use Object::dynamicCast, because we know the thing is an object and we don't want to do all the extra work; just cast directly.

kjs/list.cpp: (KJS::List::List): Construct valueRefCount in a way that avoids the need for a branch -- in the hot case this just meant avoiding checking a variable we just set to false.

kjs/lookup.cpp: (keysMatch): Marked this inline.

kjs/nodes.cpp: Disabled KJS_BREAKPOINT, to avoid calling hitStatement all the time. (BooleanNode::evaluate): Make a Value directly, rather than making a Boolean which is converted into a Value. (NumberNode::evaluate): Ditto. (StringNode::evaluate): Ditto. (ArrayNode::evaluate): Ditto. (FunctionCallNode::evaluate): Use new inline baseIfMutable to avoid unnecessary getBase function. Also just use a pointer for func, rather than an Object. (PostfixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (DeleteNode::evaluate): Make a Value directly. (TypeOfNode::evaluate): Use new inline baseIfMutable and make Value directly. (PrefixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (UnaryPlusNode::evaluate): Make a Value directly. (NegateNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (BitwiseNotNode::evaluate): Make a Value directly. (LogicalNotNode::evaluate): Ditto. (ShiftNode::evaluate): Don't convert to a double before making a Value. (RelationalNode::evaluate): Make a Value directly. (EqualNode::evaluate): Ditto. (BitOperNode::evaluate): Ditto. (AssignNode::evaluate): Make a Value directly. Change code so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (VarDeclNode::evaluate): Make a Value directly. (ForNode::execute): Remove unused local variable.

kjs/operations.h: (KJS::isNaN): Inlined. (KJS::isInf): Ditto. (KJS::isPosInf): Ditto. (KJS::isNegInf): Ditto.

kjs/operations.cpp: Change isNaN, isInf, isPosInf, and isNegInf to be inlines. (KJS::equal): Rewrite to avoid creating values and recursing back into the function. (KJS::relation): Rearranged code so that we don't need explicit isNaN checks. (KJS::add): Changed code to make Value directly, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (KJS::mult): Ditto.

kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::clear): Ditto. Clear value pointer in addition to key, so we can just look at the value pointer in the mark function. (KJS::PropertyMap::get): Get sizeMask and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::put): Ditto. (KJS::PropertyMap::insert): Ditto. (KJS::PropertyMap::remove): Ditto. (KJS::PropertyMap::mark): Get size and entries pointer outside loop to avoid re-getting them inside the loop. Don't bother checking key for 0, since we already have to check value for 0. (Also had to change clear() to set value to 0.) (KJS::PropertyMap::addEnumerablesToReferenceList): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Ditto. (KJS::PropertyMap::save): Ditto.

other changes

kjs/protected_values.h: Remove unneeded class name qualifiers.

kjs/reference.h: (KJS::Reference::baseIfMutable): New inline function: replaces isMutable(). (KJS::Reference::Reference): Inlined.
kjs/reference.cpp: (KJS::Reference::getValue): Rewrite to not use getBase. (KJS::Reference::putValue): Ditto. (KJS::Reference::deleteValue): Dittol

kjs/simple_number.h: (KJS::SimpleNumber::integerFits): Added. For use when the parameter is known to be integral.

kjs/string_object.cpp: (StringProtoFuncImp::call): Create the number without first converting to double in various cases that involve integers.

kjs/ustring.h: (KJS::UString::attach): Inlined. (KJS::UString::release): Inlined.
kjs/ustring.cpp: (KJS::UString::find): Get first character outside the loop instead of re-fetching it each time.

kjs/value.cpp: (Value::Value): Added overloads for all the various specific types of values, so you don't have to convert from, say, Number to Value, just to create one. (Number::Number): Added an overload that takes a boolean to indicate the number is already known to be an integer.

kjs/value.h: Added more Value constructors, added a version of toNumber that returns a boolean to indicate if the number is known to be an integer (because it was a "simple number"). (KJS::ValueImp::marked): Inlined. (KJS::ValueImp::dispatchType): Inlined. (KJS::ValueImp::dispatchToPrimitive): Inlined. (KJS::ValueImp::dispatchToBoolean): Inlined. (KJS::ValueImp::dispatchToNumber): Inlined. (KJS::ValueImp::dispatchToString): Inlined. (KJS::ValueImp::dispatchToUInt32): Inlined.

2005-04-14 Maciej Stachowiak <mjs@apple.com>

make fast_malloc.h a private header, not project

JavaScriptCore.pbproj/project.pbxproj:

2005-04-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Richard.

<rdar://problem/4089734> JavaScript iBench can be sped up ~10% with custom allocator

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

JavaScriptCore.pbproj/project.pbxproj:
kjs/collector.cpp: (KJS::Collector::allocate): Use dlmalloc to allocate the collector blocks. (KJS::Collector::collect): And dlfree to free it.
kjs/fast_malloc.cpp: Added, just the standard dlmalloc here.
kjs/fast_malloc.h: Added. Declarations for the functions. Also added a handy macro to give a class custom operator new/delete
kjs/identifier.cpp: (KJS::Identifier::add): Use dlmalloc/dlfree.
kjs/nodes.h: make nodes KJS_FAST_ALLOCATED.
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Use dlmalloc/dlfree. (KJS::PropertyMap::rehash): ditto
kjs/scope_chain.h:
kjs/ustring.cpp: (KJS::UString::Rep::createCopying): New named constructor that copies a passed-in buffer, to hide allocation details from webcore. (KJS::UString::UString): use createCopying when appropriate. (KJS::UString::Rep::destroy): Use dlmalloc/dlfree. (KJS::UString::expandedSize): likewise (KJS::UString::expandCapacity): likewise (KJS::UString::expandPreCapacity): likewise (KJS::UString::spliceSubstringsWithSeparators): likewise (KJS::UString::append): likewise (KJS::UString::operator=): likewise (KJS::UString::detach): likewise
kjs/ustring.h: make UString and UString::Rep KJS_FAST_ALLOCATED.

2005-04-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by John.

<rdar://problem/4086819> Avoid using protect count hash table so much for 5.6% JS iBench speedup

Avoid using protected values hash for the two most common cases
Bump up ListImp high water mark, new testing shows 508 ListImps are created during JS iBench.

Net result is a 5.6% speedup on JavaScript iBench

kjs/collector.cpp: (KJS::Collector::collect): mark protected lists as appropriate.
kjs/context.h:
kjs/list.cpp: (KJS::ListImp::markValues): Moved implementation from List::markValues (KJS::List::markProtectedLists): Implemented - scan pool and overflow list. (KJS::allocateListImp): link lists outside the pool into a separate doubly linked list to be able to mark protected lists (KJS::deallocateListImp): do the corresponding delinking (KJS::List::derefValues): do nothing in conservative GC mode (KJS::List::refValues): do nothing in conservative GC mode (KJS::List::markValues): call ListImp version (KJS::List::append):
kjs/list.h:

WebCore:

Merged change from TOT.

2005-04-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Richard.

use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench

khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):

10:24 AM Changeset in webkit [9758] by ggaren

4 edits
2 adds in trunk

JavaScriptCore:

-landed fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3412
Object.prototype is missing toLocaleString

patch by Mark Rowe (bdash) <opendarwin.org@bdash.net.nz>

-layout test info in webcore changelog

Reviewed by mjs.

kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::call):
kjs/object_object.h: (KJS::ObjectProtoFuncImp::):

WebCore:

-landed layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3412
Object.prototype is missing toLocaleString

Reviewed by mjs.

Test cases added:

layout-tests/fast/js/object-prototype-toLocaleString-expected.txt: Added.
layout-tests/fast/js/object-prototype-toLocaleString.html: Added.

9:29 AM Changeset in webkit [9757] by vicki

5 edits in trunk

WebCore:

Reviewed by Kocienda.

WebCore part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm:

WebKit:

Reviewed by Kocienda.

WebKit part of fix for <rdar://problem/4172380> [GENENTECH] window.opener not available when child opened via target="_new"

Add a setOpener function to the WebCore bridge, and call this function when opening
new windows through Web Kit.

WebView.subproj/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):

Jul 13, 2005:

9:48 PM Changeset in webkit [9756] by mjs

6 edits
2 adds in trunk

Reviewed by Kevin.

convert some more things to use the new hashtable

khtml/ecma/kjs_binding.cpp: (KJS::domObjects): (KJS::domNodesPerDocument): (KJS::ScriptInterpreter::getDOMObject): (KJS::ScriptInterpreter::putDOMObject): (KJS::ScriptInterpreter::deleteDOMObject): (KJS::ScriptInterpreter::forgetDOMObject): (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): (KJS::ScriptInterpreter::mark): (KJS::ScriptInterpreter::updateDOMNodeDocument):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_window.h: Include QPtrDict header
khtml/ecma/xmlhttprequest.h: ditto

fix a bug with remove of a nonexistent key - it used to trash the table

khtml/misc/hashtable.h: (khtml::::remove):

7:43 PM Changeset in webkit [9755] by justing

10 edits in trunk/WebKit

Reviewed by John

Rolling in changes necessary to build with newer versions of gcc 4.0

History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]):
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithLowercasedScheme]): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]):
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
WebView.subproj/WebFrame.m: (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]):
WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): (-[WebView mainFrameTitle]):

7:32 PM Changeset in webkit [9754] by justing

10 edits in trunk/WebCore

Reviewed by mjs

Rolled in workarounds necessary to build with a gcc 4.0 regression introduced in build 5208:
<rdar://problem/4175534> Regression in gcc-5208 "comparison of distinct Objective-C types lacks a cast" warning
Problems overloading methods that take Objective-C typed arguments

kwq/KWQCursor.h:
kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):
kwq/KWQKCursor.mm: (KCursor::crossCursor): (KCursor::handCursor): (KCursor::sizeAllCursor): (KCursor::ibeamCursor): (KCursor::waitCursor): (KCursor::whatsThisCursor): (KCursor::eastResizeCursor): (KCursor::northResizeCursor): (KCursor::northEastResizeCursor): (KCursor::northWestResizeCursor): (KCursor::southResizeCursor): (KCursor::southEastResizeCursor): (KCursor::southWestResizeCursor): (KCursor::westResizeCursor):
kwq/KWQKJobClasses.mm: (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
kwq/KWQSignal.h:
kwq/KWQSignal.mm: (KWQSignal::callWithData): (KWQSignal::callWithResponse):
kwq/KWQSlot.h:
kwq/KWQSlot.mm: (KWQSlot::callWithData): (KWQSlot::callWithResponse):
kwq/KWQWidget.mm: (QWidget::cursor):

7:22 PM Changeset in webkit [9753] by justing

15 edits in trunk/WebCore

Reviewed by mjs

Rolling in changes necessary to build with newer versions of gcc 4.0

kwq/DOM-CSS.mm: (+[DOMCSSPrimitiveValue _valueWithImpl:]):
kwq/DOMEvents.h:
kwq/DOMInternal.h: (addDOMWrapper):
kwq/KWQButton.mm: (QButton::setWritingDirection):
kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage):
kwq/KWQComboBox.mm: (QComboBox::setWritingDirection): (QComboBox::populateMenu):
kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::fileWrapperForElement):
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit):
kwq/KWQListBox.mm: (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::doneAppendingItems): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::setWritingDirection):
kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
kwq/KWQTextArea.mm: (-[KWQTextArea _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView _enclosingTextArea]): (-[KWQTextAreaTextView _resizeCornerRect]):
kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): (QTextEdit::setWritingDirection): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setPalette):
kwq/KWQWidget.mm: (QWidget::hasFocus):
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:30 PM Changeset in webkit [9752] by adele

1 edit in branches/Safari-1-3-branch/WebCore/WebCore.pbproj/project.pbxproj

Rolling out accidental checkin of bad version string.

5:26 PM Changeset in webkit [9751] by sullivan

3 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

cleaned up Find-related experimental code that I checked in a while back

WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): remove variant of this method that had findInSelection flag; this method is now the same as it was on Tiger.

WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

5:26 PM Changeset in webkit [9750] by sullivan

5 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

cleaned up Find-related experimental code that I checked in a while back

kwq/KWQKHTMLPart.h: remove findInSelection flag from findString()
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): remove findInSelection flag. Always search the selection first, but if the found range is the same as the selection range, then search again from beyond the selection.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): remove findInSelection flag

5:16 PM Changeset in webkit [9749] by adele

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-13 Adele Peterson <adele@apple.com>

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.

Test cases added: None. This test case involves tabbing to form controls and scrolling.

kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]):

5:14 PM Changeset in webkit [9748] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-13 Adele Peterson <adele@apple.com>

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.

Test cases added: None. This test case involves tabbing to form controls and scrolling.

kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:forceCentering:]):

5:10 PM Changeset in webkit [9747] by adele

2 edits in trunk/WebCore

Reviewed by John.

Fixed <rdar://problem/4170963> Focusing a field unnecessarily horizontally scrolls

Horizontal scrolling while tabbing through forms can be surprising, and distracting. This
change will minimize that scrolling if we're not explicitly trying to center a rectangle in
_KWQ_scrollRectToVisible.