Timeline



Jul 23, 2005:

1:49 PM Changeset in webkit [9877] by justing
  • 1 edit
    1 add in trunk/WebCore

Adding a manual test for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>, since
our layout test font doesn't include glyphs for bidi control characters

Test cases added:

  • manual-tests/bidi-visible-control-characters.html: Added.
1:45 PM Changeset in webkit [9876] by justing
  • 2 edits in trunk/WebKit

Patch by <​opendarwin.org@mitzpettel.com>

Reviewed by darin and hyatt

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
The fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
so that they would be rendered if the font includes a glyph for bidi control characters.

Also adding a manual test (our default layout test font does not include bidi control characters)

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun):

Jul 22, 2005:

5:50 PM Changeset in webkit [9875] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

  • kjs/date_object.cpp: DatePrototypeImp now identifies itself as a child class of DateInstanceImp -- this enables calls to Date.ValueOf().

fixes: ecma/Date/15.9.5.js (once we enable the date tests).

5:34 PM Changeset in webkit [9874] by ggaren
  • 4 edits
    2 adds
    1 delete in trunk

JavaScriptCore:

Reviewed by darin.

  • tests/mozilla/jsDriver.pl: now takes the path to testkjs as a command-line argument
  • tests/mozilla/run-mozilla-tests: Removed.

WebKitTools:

Moved Tools/Scripts/run-mozilla-tests to WebKitTools/Scripts/run-javascriptcore-tests.
run-javascriptcore-tests now passes its command-line arguments to jsDriver.pl

Moved Tools/Scripts/update-mozilla-js-test-results to
WebKitTools/Scripts/update-javascriptcore-test-results.

Reviewed by darin.

  • Scripts/run-javascriptcore-tests: Added.
2:52 PM Changeset in webkit [9873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Justin Garcia.

Mail (running on tip of tree WebKit) was running into an assertion I recently added.
The assertion is actually correct, catching an old bug in this code.

  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): if the first responder is a WebFrameView, then we've found the WebFrameView we're looking for, and we shouldn't look at its superviews.
2:34 PM Changeset in webkit [9872] by hyatt
  • 2 edits in trunk/WebCore

Put back in the <script src="foo"/> self-closing tag quirk in HTML. Unfortunately
Dashboard widgets are dependent on this quirk.

Reviewed by mjs

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
11:09 AM Changeset in webkit [9871] by sullivan
  • 9 edits in trunk

WebCore:

Reviewed by Chris Blumenberg.

Test cases added: none, this only affects Safari autocomplete; it doesn't affect any
web pages.

  • some changes in the direction of weaning all the form-related SPI from NSView
  • kwq/DOMExtensions.h: added -[DOMHTMLInputElement isTextField]
  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement isTextField]): new method that returns YES if this element is one of the types that's represented by a text field (as opposed to a button, slider, etc.). I could have put this method in Safari, but it seems useful for other WebKit clients.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge viewForElement:]): added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm: to return DOMElements rather than NSViews, while keeping autocomplete working in Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit (it will always fail to find anything to autocomplete) (-[WebCoreBridge controlsInForm:]): now returns an array of DOMElement* rather than an array of NSView*

WebKit:

Reviewed by Chris Blumenberg.

  • some changes in the direction of weaning all the form-related SPI from NSView
  • PublicHeaderChangesFromTiger.txt: noted that the WebCore change to add -[DOMHTMLInputElement isTextField] to DOMExtensions.h is a public header change.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation viewForElement:]): added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm: to return DOMElements rather than NSViews, while keeping autocomplete working in Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit (it will always fail to find anything to autocomplete)

Jul 21, 2005:

8:10 PM Changeset in webkit [9870] by adele
  • 58 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merge from TOT to Safari-2-0-branch
<rdar://problem/4164147>

2005-04-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Chris.

<rdar://problem/4092136> reproducible crash in KJS::kjs_fast_realloc loading maps.google.com

  • kjs/string_object.cpp: (StringObjectFuncImp::call): Allocate adopted ustring buffer properly.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • kjs/ustring.cpp: (KJS::UString::UTF8String): Fix off-by-one error in surrogate pair logic.

2005-04-22 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/4090046> JavaScript throw statement causes parse error when no semicolon is present
  • kjs/grammar.y: Added an additional rule for throw like the ones we have for all the other semicolon rules. Not sure why we missed this one earlier.
  • kjs/grammar.cpp: Regenerated.

2005-04-20 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • speedups, total 12% on JavaScript iBench

I ran the benchmark under Shark and followed its advice a lot, mainly.

  • kjs/collector.cpp: (KJS::Collector::allocate): Take out special case for 0; costing speed but unexercised. Use numLiveObjectsAtLastCollect instead of numAllocationsSinceLastCollect so we don't have to bump it each time we call allocate. Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset rather than a pointer so we don't need a special case for NULL. Allow freeList to point to some bogus item when the entire block is full rather than going out of our way to make it point to NULL. (KJS::Collector::markProtectedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::collect): Put numLiveObjects into a local variable to cut down on global variable accesses. Make "next" cell pointer be a byte offset as above. Put numLiveObjects into a local variable to cut down on global variable accesses. Set numLiveObjectsAtLastCollect rather than numAllocationsSinceLastCollect. (KJS::Collector::numReferencedObjects): Get table size and pointer into locals outside the loop to avoid re-loading them over and over again. (KJS::Collector::rootObjectClasses): Ditto.
  • kjs/internal.h: Make Value be a friend of NumberImp so it can construct number objects directly, avoiding the conversion from Number to Value.
  • kjs/internal.cpp: (StringImp::toObject): Don't use Object::dynamicCast, because we know the thing is an object and we don't want to do all the extra work; just cast directly.
  • kjs/list.cpp: (KJS::List::List): Construct valueRefCount in a way that avoids the need for a branch -- in the hot case this just meant avoiding checking a variable we just set to false.
  • kjs/lookup.cpp: (keysMatch): Marked this inline.
  • kjs/nodes.cpp: Disabled KJS_BREAKPOINT, to avoid calling hitStatement all the time. (BooleanNode::evaluate): Make a Value directly, rather than making a Boolean which is converted into a Value. (NumberNode::evaluate): Ditto. (StringNode::evaluate): Ditto. (ArrayNode::evaluate): Ditto. (FunctionCallNode::evaluate): Use new inline baseIfMutable to avoid unnecessary getBase function. Also just use a pointer for func, rather than an Object. (PostfixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (DeleteNode::evaluate): Make a Value directly. (TypeOfNode::evaluate): Use new inline baseIfMutable and make Value directly. (PrefixNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (UnaryPlusNode::evaluate): Make a Value directly. (NegateNode::evaluate): Change code so that it doesn't make an excess Number, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (BitwiseNotNode::evaluate): Make a Value directly. (LogicalNotNode::evaluate): Ditto. (ShiftNode::evaluate): Don't convert to a double before making a Value. (RelationalNode::evaluate): Make a Value directly. (EqualNode::evaluate): Ditto. (BitOperNode::evaluate): Ditto. (AssignNode::evaluate): Make a Value directly. Change code so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (VarDeclNode::evaluate): Make a Value directly. (ForNode::execute): Remove unused local variable.
  • kjs/operations.h: (KJS::isNaN): Inlined. (KJS::isInf): Ditto. (KJS::isPosInf): Ditto. (KJS::isNegInf): Ditto.
  • kjs/operations.cpp: Change isNaN, isInf, isPosInf, and isNegInf to be inlines. (KJS::equal): Rewrite to avoid creating values and recursing back into the function. (KJS::relation): Rearranged code so that we don't need explicit isNaN checks. (KJS::add): Changed code to make Value directly, and so that it passes a "known to be integer" boolean in, often avoiding a conversion from floating point to integer and back. (KJS::mult): Ditto.
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::clear): Ditto. Clear value pointer in addition to key, so we can just look at the value pointer in the mark function. (KJS::PropertyMap::get): Get sizeMask and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::put): Ditto. (KJS::PropertyMap::insert): Ditto. (KJS::PropertyMap::remove): Ditto. (KJS::PropertyMap::mark): Get size and entries pointer outside loop to avoid re-getting them inside the loop. Don't bother checking key for 0, since we already have to check value for 0. (Also had to change clear() to set value to 0.) (KJS::PropertyMap::addEnumerablesToReferenceList): Get size and entries pointer outside loop to avoid re-getting them inside the loop. (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Ditto. (KJS::PropertyMap::save): Ditto.
  • other changes
  • kjs/protected_values.h: Remove unneeded class name qualifiers.
  • kjs/reference.h: (KJS::Reference::baseIfMutable): New inline function: replaces isMutable(). (KJS::Reference::Reference): Inlined.
  • kjs/reference.cpp: (KJS::Reference::getValue): Rewrite to not use getBase. (KJS::Reference::putValue): Ditto. (KJS::Reference::deleteValue): Dittol
  • kjs/simple_number.h: (KJS::SimpleNumber::integerFits): Added. For use when the parameter is known to be integral.
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Create the number without first converting to double in various cases that involve integers.
  • kjs/ustring.h: (KJS::UString::attach): Inlined. (KJS::UString::release): Inlined.
  • kjs/ustring.cpp: (KJS::UString::find): Get first character outside the loop instead of re-fetching it each time.
  • kjs/value.cpp: (Value::Value): Added overloads for all the various specific types of values, so you don't have to convert from, say, Number to Value, just to create one. (Number::Number): Added an overload that takes a boolean to indicate the number is already known to be an integer.
  • kjs/value.h: Added more Value constructors, added a version of toNumber that returns a boolean to indicate if the number is known to be an integer (because it was a "simple number"). (KJS::ValueImp::marked): Inlined. (KJS::ValueImp::dispatchType): Inlined. (KJS::ValueImp::dispatchToPrimitive): Inlined. (KJS::ValueImp::dispatchToBoolean): Inlined. (KJS::ValueImp::dispatchToNumber): Inlined. (KJS::ValueImp::dispatchToString): Inlined. (KJS::ValueImp::dispatchToUInt32): Inlined.

2005-04-14 Maciej Stachowiak <​mjs@apple.com>

  • make fast_malloc.h a private header, not project

2005-04-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Richard.

<rdar://problem/4089734> JavaScript iBench can be sped up ~10% with custom allocator

  • use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench
  • JavaScriptCore.pbproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::allocate): Use dlmalloc to allocate the collector blocks. (KJS::Collector::collect): And dlfree to free it.
  • kjs/fast_malloc.cpp: Added, just the standard dlmalloc here.
  • kjs/fast_malloc.h: Added. Declarations for the functions. Also added a handy macro to give a class custom operator new/delete
  • kjs/identifier.cpp: (KJS::Identifier::add): Use dlmalloc/dlfree.
  • kjs/nodes.h: make nodes KJS_FAST_ALLOCATED.
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Use dlmalloc/dlfree. (KJS::PropertyMap::rehash): ditto
  • kjs/scope_chain.h:
  • kjs/ustring.cpp: (KJS::UString::Rep::createCopying): New named constructor that copies a passed-in buffer, to hide allocation details from webcore. (KJS::UString::UString): use createCopying when appropriate. (KJS::UString::Rep::destroy): Use dlmalloc/dlfree. (KJS::UString::expandedSize): likewise (KJS::UString::expandCapacity): likewise (KJS::UString::expandPreCapacity): likewise (KJS::UString::spliceSubstringsWithSeparators): likewise (KJS::UString::append): likewise (KJS::UString::operator=): likewise (KJS::UString::detach): likewise
  • kjs/ustring.h: make UString and UString::Rep KJS_FAST_ALLOCATED.

2005-04-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

<rdar://problem/4086819> Avoid using protect count hash table so much for 5.6% JS iBench speedup

  • Avoid using protected values hash for the two most common cases
  • Bump up ListImp high water mark, new testing shows 508 ListImps are created during JS iBench.

Net result is a 5.6% speedup on JavaScript iBench

  • kjs/collector.cpp: (KJS::Collector::collect): mark protected lists as appropriate.
  • kjs/context.h:
  • kjs/list.cpp: (KJS::ListImp::markValues): Moved implementation from List::markValues (KJS::List::markProtectedLists): Implemented - scan pool and overflow list. (KJS::allocateListImp): link lists outside the pool into a separate doubly linked list to be able to mark protected lists (KJS::deallocateListImp): do the corresponding delinking (KJS::List::derefValues): do nothing in conservative GC mode (KJS::List::refValues): do nothing in conservative GC mode (KJS::List::markValues): call ListImp version (KJS::List::append):
  • kjs/list.h:

WebCore:

Merge from TOT to Safari-2-0-branch
<rdar://problem/4164147>

2005-04-17 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • use single-threaded malloc in places where malloc is hot for an 8% speed improvement on cvs-base
  • ForwardingHeaders/misc/fast_malloc.h: Added.
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssstyleselector.h:
  • khtml/misc/arena.cpp: (ArenaAllocate): (FreeArenaList): (ArenaFinish):
  • khtml/misc/main_thread_malloc.cpp: Added.
  • khtml/misc/main_thread_malloc.h: Added.
  • khtml/rendering/render_style.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::NamedAttrMapImpl): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.h:
  • kwq/KWQFontFamily.h:
  • kwq/KWQListImpl.mm:
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (ALLOC_CHAR): (ALLOC_QCHAR): (QString::setBufferFromCFString): (allocatePageNode):

2005-04-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Richard.

  • use custom single-threaded malloc for all non-GC JavaScriptCore allocations, for a 9.1% speedup on JavaScript iBench
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
  • khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):

2005-03-11 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

WebKit:

Merge from TOT to Safari-2-0-branch
<rdar://problem/4164147>
<rdar://problem/4164149>

2005-07-21 Adele Peterson <​adele@apple.com>

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4132797> don't register thin PPC WebKit plug-ins Merged fix for: <rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari
  • Plugins.subproj/WebBasePluginPackage.h: Added isNativeLibraryData method.
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): Added isNativeLibraryData method.
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): calls isNativeLibraryData to determine whether or not to register the plug-in.
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): ditto.
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): added comment for #ifdef.

2005-07-20 Adele Peterson <​adele@apple.com>

Merged fix for:
<rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):

2005-07-20 Adele Peterson <​adele@apple.com>

Merged fix for :
<rdar://problem/4118278> mail divide by zero navigating messages

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):
6:57 PM Changeset in webkit [9869] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Changing temporary #ifndef to #if

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):
6:23 PM Changeset in webkit [9868] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Scripts/build-dumprendertree: changed XCode 2.0 project file reference to 2.1
6:18 PM Changeset in webkit [9867] by adele
  • 77 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merge from TOT to Safari-2-0-branch to build with gcc 4.0
<rdar://problem/4164127>

2005-05-16 Darin Adler <Darin Adler>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.

2005-05-04 Darin Adler <Darin Adler>

Reviewed by Dave Hyatt.

  • another gcc-4.0-related fix
  • bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.

2005-04-28 Darin Adler <Darin Adler>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
  • bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
  • kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
  • kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
  • kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
  • kjs/string_object.cpp: (replace): Ditto.

WebCore:

Merge from TOT to Safari-2-0-branch to build with gcc 4.0
<rdar://problem/4164127>

2005-07-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by mjs

  • kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):

Didn't KWQRetain() the NSCursor in yesterday's gcc 4.0 workaround

2005-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by mjs

Workarounds to get WebCore to compile with gcc 4.0 build 5208

  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (QCursor::makeWithNSCursor):
  • kwq/KWQKCursor.mm: (KCursor::crossCursor): (KCursor::handCursor): (KCursor::sizeAllCursor): (KCursor::ibeamCursor): (KCursor::waitCursor): (KCursor::whatsThisCursor): (KCursor::eastResizeCursor): (KCursor::northResizeCursor): (KCursor::northEastResizeCursor): (KCursor::northWestResizeCursor): (KCursor::southResizeCursor): (KCursor::southEastResizeCursor): (KCursor::southWestResizeCursor): (KCursor::westResizeCursor):
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::callWithData): (KWQSignal::callWithResponse):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::callWithData): (KWQSlot::callWithResponse):
  • kwq/KWQWidget.mm: (QWidget::cursor):

2005-07-08 Justin Garcia <​justin.garcia@apple.com>

Reviewed by john

Changes needed in order to compile with gcc 4.0 build 5204
Mostly obj-c type and casting issues

  • kwq/DOM-CSS.mm: (+[DOMCSSPrimitiveValue _valueWithImpl:]): Wrote wrapper _valuewithimpl that calls parent class's method
  • kwq/DOMEvents.h:
  • kwq/DOMInternal.h: (addDOMWrapper):
  • kwq/KWQButton.mm: (QButton::setWritingDirection):
  • kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage):
  • kwq/KWQComboBox.mm: (QComboBox::setWritingDirection): (QComboBox::populateMenu):
  • kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::passWidgetMouseDownEventToWidget): (KWQKHTMLPart::fileWrapperForElement): renderer->pixmap().image() was used as an NSImage, but a WebCoreImageRenderer doesn't have any association with NSImage, should be investigated further
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit):
  • kwq/KWQListBox.mm: (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::doneAppendingItems): (QListBox::setSelected): (QListBox::isSelected): (QListBox::setEnabled): (QListBox::sizeForNumberOfLines): (QListBox::setWritingDirection):
  • kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
  • kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): (QTextEdit::setWritingDirection): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setPalette):
  • kwq/KWQWidget.mm: (QWidget::hasFocus):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

2005-05-16 Darin Adler <Darin Adler>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
  • khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
  • khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
  • khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
  • khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
  • khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
  • khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
  • khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
  • khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
  • kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

2005-04-28 Darin Adler <Darin Adler>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
  • khtml/css/parser.cpp: Regenerated.
  • khtml/css/parser.h: Regenerated.
  • khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
  • kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
  • kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
  • kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
  • kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • WebCore-combined.exp: Regenerated.
  • WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.

WebKit:

Merge from TOT to Safari-2-0-branch to build with gcc 4.0
<rdar://problem/4164127>

2005-07-08 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John

Changes to compile with gcc 4.0 build 5204

The construct "variable = if ? then : else" is more strict about the types of 'then' and 'else'

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]):
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]):
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithLowercasedScheme]): (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]):
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): (-[WebView mainFrameTitle]):

2005-04-28 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
  • WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.
5:02 PM Changeset in webkit [9866] by adele
  • 6 edits in trunk/WebKit

Reviewed by Chris Blumenberg.

  • fixed <rdar://problem/4132797> don't register thin PPC WebKit plug-ins Merged fix for: <rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari
  • Plugins.subproj/WebBasePluginPackage.h: Added isNativeLibraryData method.
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): Added isNativeLibraryData method.
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): calls isNativeLibraryData to determine whether or not to register the plug-in.
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): ditto.
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): added comment for #ifdef.
3:48 PM Changeset in webkit [9865] by ggaren
  • 3 deletes in trunk

Removing old XCode project files.

3:47 PM Changeset in webkit [9864] by ggaren
  • 1 edit
    1 delete in trunk/WebKitTools

Removing old XCode project files.

Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/DumpRenderTree.xcode/.cvsignore: Removed.
1:38 PM Changeset in webkit [9863] by ggaren
  • 1 edit
    1 delete in trunk/WebKitTools

Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Removed.
1:33 PM Changeset in webkit [9862] by ggaren
  • 2 edits
    2 deletes in trunk

WebCore:

Reviewed by NOBODY (OOPS!).

Test cases added: (NONE)

  • WebCore.pbproj/project.pbxproj: Removed.

WebKit:

Reviewed by NOBODY (OOPS!).

  • WebKit.pbproj/project.pbxproj: Removed.
1:28 PM Changeset in webkit [9861] by ggaren
  • in /

file .cvsignore was added on branch Safari-2-0-branch on 2005-07-29 23:31:52 +0000

1:28 PM Changeset in webkit [9860] by ggaren
  • in /

file .cvsignore was added on branch Safari-2-0-branch on 2005-07-29 23:29:41 +0000

1:28 PM Changeset in webkit [9859] by ggaren
  • 8 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by NOBODY (OOPS!).

WebCore:

Reviewed by NOBODY (OOPS!).

Test cases added: (NONE)

  • WebCore.xcodeproj/.cvsignore: Added.

WebKit:

Reviewed by NOBODY (OOPS!).

  • WebKit.xcodeproj/.cvsignore: Added.

WebKitTools:

Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/DumpRenderTree.xcodeproj/.cvsignore: Added.
1:28 PM Changeset in webkit [9858] by ggaren
  • in /

file .cvsignore was added on branch Safari-2-0-branch on 2005-07-29 23:25:37 +0000

1:24 PM Changeset in webkit [9857] by ggaren
  • 3 edits
    6 adds in trunk

WebCore:

Reviewed by NOBODY (OOPS!).

Test cases added: (NONE)

  • WebCore.xcodeproj/project.pbxproj: Added.

WebKit:

Reviewed by NOBODY (OOPS!).

  • WebKit.xcodeproj/project.pbxproj: Added.

WebKitTools:

Reviewed by NOBODY (OOPS!).

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added.
12:46 PM Changeset in webkit [9856] by ggaren
  • 2 deletes in trunk/JavaScriptCore/JavaScriptCore.xcodeproj

* empty log message *

12:44 PM Changeset in webkit [9855] by ggaren
  • 8 edits
    4 adds
    1 delete in trunk

JavaScriptCore:

Reviewed by NOBODY (OOPS!).

WebCore:

Reviewed by NOBODY (OOPS!).

Test cases added: (NONE)

  • Makefile.am:

WebKit:

Reviewed by NOBODY (OOPS!).

  • Makefile.am:

WebKitTools:

Reviewed by NOBODY (OOPS!).

  • Scripts/build-webkit:
9:33 AM Changeset in webkit [9854] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

-fix for <rdar://problem/4169069> Also fixes the behavior of generated content
when it is specified within a list element.

Test cases added: (NONE)

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle): Added loop to skip over list elements hen updating

generatedcontent.

(khtml::RenderBlock::updateFirstLetter): Added clause so that the function updates the

first letter instead of just creating it.

  • khtml/rendering/render_inline.cpp: (RenderInline::setStyle): Added loop to skip over list elements when updating generated

content.

Jul 20, 2005:

9:10 PM Changeset in webkit [9853] by mjs
  • 13 edits
    2 adds in trunk

Reviewed by Geoff.

  • fix handling of special properties of the HTML document object. Now we completely match IE.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/document-special-properties.html: Added; new exhaustive test case.
  • layout-tests/fast/dom/HTMLDocument/document-special-properties-expected.txt: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): Check for named and doc extra named items. (KJS::HTMLDocument::get): Return the appropriate element, window or collection by name; give such named items precedence over built-in and custom properties.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::get): Replace quirky &* idiom with call to get().
  • khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::parseMappedAttribute): Track by name as a doc extra named item. (HTMLIFrameElementImpl::insertedIntoDocument): ditto (HTMLIFrameElementImpl::removedFromDocument): ditto
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_documentimpl.cpp: (DOM::addItemToMap): Factored out from addNamedItem (DOM::removeItemFromMap): Factored out from removeNamedItem (DOM::HTMLDocumentImpl::addNamedItem): refactored (DOM::HTMLDocumentImpl::removeNamedItem): refactored (DOM::HTMLDocumentImpl::addDocExtraNamedItem): new method - maintains a hashtable of the "extra" named items for a document, which are iframes by name and applets and embeds by id. (DOM::HTMLDocumentImpl::removeDocExtraNamedItem): ditto (DOM::HTMLDocumentImpl::hasDocExtraNamedItem): ditto
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::traverseNextItem): Remove support for DOC_NAMEABLE_ITEMS collection - no longer needed. (DOM::HTMLNameCollectionImpl::traverseNextItem): Add support for DOCUMENT_NAMED_ITEMS, implementing the correct document rule.
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): Track by id as doc extra named item (DOM::HTMLAppletElementImpl::insertedIntoDocument): ditto (DOM::HTMLAppletElementImpl::removedFromDocument): ditto (DOM::HTMLObjectElementImpl::parseMappedAttribute): ditto (DOM::HTMLObjectElementImpl::insertedIntoDocument): ditto (DOM::HTMLObjectElementImpl::removedFromDocument): ditto
  • khtml/html/html_objectimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::nameableItems): removed - no longer used (DocumentImpl::documentNamedItems): added
  • khtml/xml/dom_docimpl.h:
3:55 PM Changeset in webkit [9852] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Vicki Murley.

  • removed some form-related methods that weren't being used anywhere, in preparation for weaning WebKit's WebFormDelegate protocol from NSView.

Test cases added: none, no behavior change

  • kwq/KWQTextField.mm:
  • kwq/WebCoreBridge.h: removed these methods: -control:didFailToFormatString:errorDescription: -control:didFailToValidatePartialString:errorDescription: -control:isValidObject:

WebKit:

Reviewed by Vicki Murley.

  • removed some form-related methods that weren't being used anywhere, in preparation for weaning WebKit's WebFormDelegate protocol from NSView.
  • WebCoreSupport.subproj/WebBridge.m:
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: removed these methods: -control:didFailToFormatString:errorDescription: -control:didFailToValidatePartialString:errorDescription: -control:isValidObject:
1:36 PM Changeset in webkit [9851] by adele
  • 2 edits in trunk/WebKit

Merged fix for:
<rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):
1:04 PM Changeset in webkit [9850] by adele
  • 2 edits in trunk/WebKit

Merged fix for :
<rdar://problem/4118278> mail divide by zero navigating messages

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):
12:55 PM Changeset in webkit [9849] by adele
  • 2 edits in trunk/WebCore

Rolling fix for <rdar://problem/4046602> back in.

2005-03-11 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.
11:34 AM Changeset in webkit [9848] by sullivan
  • 1 edit in trunk/WebKit/ChangeLog

Fixed reviewer name from previous checkin.

11:30 AM Changeset in webkit [9847] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Adele Amchan.

  • added -[WebView selectedFrame] to SPI (pending public API), needed for 4180958
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): new method, extracted from _selectedOrMainFrame (-[WebView _selectedOrMainFrame]): now calls extracted method
  • WebView.subproj/WebViewPrivate.h: add -selectedFrame to PendingPublic category
11:17 AM Changeset in webkit [9846] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • fixed <rdar://problem/4181058> 8C45: Safari repro crash with document.write (DOM::NodeImpl::dispatchEvent)

Test cases added:

  • manual-tests/textfield-onblur.html: Added.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): added nil check for widget, since it can get deleted during an event.
12:29 AM Changeset in webkit [9845] by mjs
  • 4 edits in trunk

JavaScriptCore:

Patch from Trey Matteson <​trey@usa.net>, reviewed by me.

  • JavaScriptCore.pbproj/project.pbxproj: Generate symbols even for Deployment.

WebCore:

Patch from Trey Matteson <​trey@usa.net>, reviewed by me.

  • WebCore.pbproj/project.pbxproj: Generate symbols even for Deployment.

Jul 19, 2005:

9:04 PM Changeset in webkit [9844] by mjs
  • 3 edits in trunk

Reviewed by Kevin.

  • fixed some mistakes in my previous checkin
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): Take name attribute out of the "do nothing" case (duh).
  • layout-tests/fast/dom/Window/window-special-properties-expected.txt: Update for change to the text at the top.
7:35 PM Changeset in webkit [9843] by mjs
  • 15 edits
    3 adds in trunk

Reviewed by Darin.

  • fix handling of special properties of the Window object. now we almost completely match Win IE.

Test cases added:

  • layout-tests/fast/dom/Window/window-special-properties-expected.txt: Added.
  • layout-tests/fast/dom/Window/window-special-properties.html: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::get): (KJS::Window::hasOwnProperty):
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::addNamedItem): (DOM::HTMLDocumentImpl::removeNamedItem): (DOM::HTMLDocumentImpl::hasNamedItem):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::attach): (DOM::HTMLFormElementImpl::insertedIntoDocument): (DOM::HTMLFormElementImpl::removedFromDocument): (DOM::HTMLFormElementImpl::parseMappedAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseMappedAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::insertedIntoDocument): (HTMLImageElementImpl::removedFromDocument):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::HTMLCollectionImpl): (DOM::HTMLCollectionImpl::traverseNextItem): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLNameCollectionImpl::HTMLNameCollectionImpl): (DOM::HTMLNameCollectionImpl::traverseNextItem): (DOM::HTMLFormCollectionImpl::getNamedFormItem): (DOM::HTMLFormCollectionImpl::nextNamedItem):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): (DOM::HTMLAppletElementImpl::insertedIntoDocument): (DOM::HTMLAppletElementImpl::removedFromDocument): (DOM::HTMLEmbedElementImpl::parseMappedAttribute): (DOM::HTMLEmbedElementImpl::attach): (DOM::HTMLEmbedElementImpl::insertedIntoDocument): (DOM::HTMLEmbedElementImpl::removedFromDocument): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::detach): (DOM::HTMLObjectElementImpl::insertedIntoDocument): (DOM::HTMLObjectElementImpl::removedFromDocument):
  • khtml/html/html_objectimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::windowNamedItems):
  • khtml/xml/dom_docimpl.h:
7:23 PM Changeset in webkit [9842] by ggaren
  • 3 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3991
JSC doesn't implement Array.prototype.toLocaleString()

-test failure: ecma_3/Array/15.4.4.3-1.js

Reviewed by mjs.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): now searches for toString and toLocaleString overrides in the array's elements
  • tests/mozilla/expected.html: failures are under 100! woohoo!
7:04 PM Changeset in webkit [9841] by ggaren
  • 3 edits
    1 add in trunk/WebCore

-rolled in patch by Anders Carlsson <​andersca@mac.com> for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3751
REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content

Reviewed by mjs.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::defaultValue): (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h:

Test cases added:

  • manual-tests/textarea-after-stylesheet-link.html: Added. Test is manual because the result doesn't show up in DumpRenderTree
6:17 PM Changeset in webkit [9840] by justing
  • 2 edits in trunk/WebCore

Added a virtual deconstructor to fix gcc4 build warning

  • khtml/rendering/render_theme.h: (khtml::RenderTheme::~RenderTheme):
5:50 PM Changeset in webkit [9839] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Darin Adler.

  • cleaned up code related to dealing with the "selected frame"; fixes radar bugs 4118830 and 4118820
  • WebView.subproj/WebTextView.m: (-[WebTextView resignFirstResponder]): call deselectAll here instead of replicating its guts, just for clarity
  • WebView.subproj/WebViewInternal.h: eliminated category WebInternal; all of these methods were used only inside WebView.m, so I moved them into the existing category WebFileInternal that was declared and implemented in WebView.m
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): updated for name changes. Also, uses new _deselectFrame: to clear the selection if the found text is in a different frame. (-[WebView pasteboardTypesForSelection]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView setSelectedDOMRange:affinity:]): (-[WebView selectedDOMRange]): (-[WebView selectionAffinity]): (-[WebView setTypingStyle:]): (-[WebView typingStyle]): (-[WebView styleDeclarationWithText:]): (-[WebView replaceSelectionWithNode:]): (-[WebView replaceSelectionWithText:]): (-[WebView replaceSelectionWithMarkupString:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView deleteSelection]): (-[WebView applyStyle:]): updated for name changes only

(-[WebView _frameIsSelected:]):
new method, returns YES if given frame has a non-zero-length selection
(-[WebView _deselectFrame:]):
new method, clears selection from given frame
(-[WebView _findSelectedFrameStartingFromFrame:]):
new method, recursive helper used by _findSelectedFrame
(-[WebView _findSelectedFrame]):
new method, finds first frame that returns YES for _frameIsSelected, or nil
(-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]):
new method, recursive helper used by _debugCheckForMultipleSelectedFrames
(-[WebView _debugCheckForMultipleSelectedFrames]):
new method for debugging, fires an assertion if there's more than one selected frame.
(-[WebView _selectedOrMainFrame]):
renamed from _frameForCurrentSelection, which was a misleading name since the returned
frame does not necessarily have a selection (or even focus). Now checks for a selected
but non-focused frame if the first responder is not in any frame. Also, moved in file
from WebInternal category to WebFileInternal category.
(-[WebView _bridgeForSelectedOrMainFrame]):
renamed from _bridgeForCurrentSelection, which was a misleading name for the same
reasons as _frameForCurrentSelection. Also, moved in file from WebInternal category to
WebFileInternal category.
(-[WebView _isLoading]):
(-[WebView _frameViewAtWindowPoint:]):
(-[WebView _bridgeAtPoint:]):
just moved in file from WebInternal category to WebFileInternal category

5:45 PM Changeset in webkit [9838] by hyatt
  • 6 edits
    4 adds in trunk/WebCore

Adding support for the "checkbox" appearance value. This is not yet implemented, but the
methods are now stubbed out and will get called.

Reviewed by mjs

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/html4.css:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::createRenderer):
  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
  • khtml/rendering/render_theme.cpp: Added. (khtml::RenderTheme::adjustStyle): (khtml::RenderTheme::paint):
  • khtml/rendering/render_theme.h: Added.
  • khtml/rendering/render_theme_mac.h: Added.
  • khtml/rendering/render_theme_mac.mm: Added. (khtml::theme): (khtml::RenderThemeMac::adjustCheckboxStyle): (khtml::RenderThemeMac::paintCheckbox):
4:44 PM Changeset in webkit [9837] by hyatt
  • 5 edits in trunk/WebCore

Fix performance regressions from attribute QName landing.

Reviewed by mjs

  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): (khtml::HTMLTokenizer::write):

Make sure attributes have a faster constructor that can avoid the copy of QualifiedNames.

Make sure to grab the part from the document outside the loop, so that it is not fetched
over and over again for every character in the source.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):

Only call paintCaret if the block is actually editable.

  • khtml/xml/dom_atomicstring.h: (DOM::operator!=):
  • khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::AttributeImpl): (DOM::AttributeImpl::~AttributeImpl): (DOM::MappedAttributeImpl::MappedAttributeImpl):

Add != comparison operator with a char* to speed up the / check for attribute invalidity.

3:41 PM Changeset in webkit [9836] by vicki
  • 5 edits
    2 adds in trunk/WebCore

Reviewed by Maciej.

Test cases added:

  • manual-tests/scrollIntoView-horizontal.html: Added.
  • manual-tests/scrollIntoView-vertical.html: Added.
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Added.
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMElement::):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElementProtoFunc::tryCall): glue for new scrollIntoView function
2:18 PM Changeset in webkit [9835] by ggaren
  • 141 edits in trunk

Reviewed by hyatt.

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine):

Lots of new test case results because previous results had inappropriately
split text runs.

  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-002-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-003-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt:
  • layout-tests/editing/style/smoosh-styles-003-expected.txt:
  • layout-tests/fast/block/basic/018-expected.txt:
  • layout-tests/fast/block/float/002-expected.txt:
  • layout-tests/fast/block/float/021-expected.txt:
  • layout-tests/fast/block/float/023-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/float/029-expected.txt:
  • layout-tests/fast/block/float/030-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/margin-collapse/101-expected.txt:
  • layout-tests/fast/block/positioning/060-expected.txt:
  • layout-tests/fast/block/positioning/auto/001-expected.txt:
  • layout-tests/fast/block/positioning/auto/002-expected.txt:
  • layout-tests/fast/block/positioning/auto/003-expected.txt:
  • layout-tests/fast/block/positioning/auto/004-expected.txt:
  • layout-tests/fast/block/positioning/auto/005-expected.txt:
  • layout-tests/fast/block/positioning/auto/006-expected.txt:
  • layout-tests/fast/clip/001-expected.txt:
  • layout-tests/fast/clip/002-expected.txt:
  • layout-tests/fast/clip/003-expected.txt:
  • layout-tests/fast/clip/004-expected.txt:
  • layout-tests/fast/clip/005-expected.txt:
  • layout-tests/fast/clip/006-expected.txt:
  • layout-tests/fast/clip/007-expected.txt:
  • layout-tests/fast/clip/008-expected.txt:
  • layout-tests/fast/clip/009-expected.txt:
  • layout-tests/fast/clip/010-expected.txt:
  • layout-tests/fast/clip/011-expected.txt:
  • layout-tests/fast/clip/012-expected.txt:
  • layout-tests/fast/clip/013-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/clip/015-expected.txt:
  • layout-tests/fast/clip/016-expected.txt:
  • layout-tests/fast/css-generated-content/012-expected.txt:
  • layout-tests/fast/css/008-expected.txt:
  • layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
  • layout-tests/fast/css/apple-prefix-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/dynamic/noninlinebadness-expected.txt:
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/001-expected.txt:
  • layout-tests/fast/flexbox/004-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/010-expected.txt:
  • layout-tests/fast/flexbox/012-expected.txt:
  • layout-tests/fast/flexbox/013-expected.txt:
  • layout-tests/fast/flexbox/014-expected.txt:
  • layout-tests/fast/flexbox/015-expected.txt:
  • layout-tests/fast/flexbox/018-expected.txt:
  • layout-tests/fast/flexbox/019-expected.txt:
  • layout-tests/fast/flexbox/020-expected.txt:
  • layout-tests/fast/flexbox/021-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/023-expected.txt:
  • layout-tests/fast/flexbox/024-expected.txt:
  • layout-tests/fast/invalid/012-expected.txt:
  • layout-tests/fast/invalid/016-expected.txt:
  • layout-tests/fast/invalid/nestedh3s-expected.txt:
  • layout-tests/fast/lists/003-expected.txt:
  • layout-tests/fast/replaced/004-expected.txt:
  • layout-tests/fast/selectors/166-expected.txt:
  • layout-tests/fast/table/032-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/text/basic/003-expected.txt:
  • layout-tests/fast/text/basic/004-expected.txt:
  • layout-tests/fast/text/basic/005-expected.txt:
  • layout-tests/fast/text/basic/009-expected.txt:
2:16 PM Changeset in webkit [9834] by darin
  • 3 edits in trunk/JavaScriptCore
  • fixed the build
  • kjs/lookup.h: (KJS::lookupPut): Remove bogus const; was preventing WebCore from compiling (not sure why this didn't affect my other build machine).
  • one other tiny tweak (so sue me)
  • bindings/runtime_root.cpp: Remove unneeded declaration.
12:52 PM Changeset in webkit [9833] by darin
  • 25 edits in trunk

JavaScriptCore:

Reviewed by Geoff Garen.

  • eliminated try wrappers for get/put/call since we don't use C++ exceptions any more
  • kjs/lookup.h: Changed tryCall in IMPLEMENT_PROTOFUNC here to call. It doesn't make sense for this macro to use the name tryCall anyway, since that's specific to how WebCore used this, so this is good anyway. On the other hand, it might be a problem for KDOM or KSVG, in which case we'll need another macro for them, since JavaScriptCore should presumably not have the C++ exception support.

WebCore:

Reviewed by Geoff Garen.

Test cases added: None. Structural change only.

  • eliminated try wrappers for get/put/call since we don't use C++ exceptions any more
  • khtml/ecma/kjs_binding.cpp: Removed DOMObject::get, DOMObject::set, DOMFunction::get, and DOMFunction::call.
  • khtml/ecma/kjs_binding.h: Removed get, set, tryGet, trySet, call, tryCall from DOMObject and DOMFunction. Removed DOMObjectLookupGet, DOMObjectLookupGetValue, and DOMObjectLookupPut. We can just do things the normal way now.

The rest of the changes are just renames and removal of a couple stray tryCall wrappers.

tryGet -> get
tryPut -> put
tryCall -> call
putValue -> putValueProperty
DOMObjectLookupGet -> lookupGet
DOMObjectLookupGetValue -> lookupGetValue
DOMObjectLookupPut -> lookupPut

  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::call):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::get): (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::call): (KJS::DOMStyleSheet::get): (KJS::DOMStyleSheet::put): (KJS::DOMStyleSheetList::get): (KJS::DOMStyleSheetListFunc::call): (KJS::DOMMediaList::get): (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::call): (KJS::DOMCSSStyleSheet::get): (KJS::DOMCSSStyleSheetProtoFunc::call): (KJS::DOMCSSRuleList::get): (KJS::DOMCSSRuleListFunc::call): (KJS::DOMCSSRule::get): (KJS::DOMCSSRule::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSRuleFunc::call): (KJS::CSSRuleConstructor::get): (KJS::DOMCSSValue::get): (KJS::DOMCSSValue::put): (KJS::CSSValueConstructor::get): (KJS::DOMCSSPrimitiveValue::get): (KJS::DOMCSSPrimitiveValueProtoFunc::call): (KJS::CSSPrimitiveValueConstructor::get): (KJS::DOMCSSValueList::get): (KJS::DOMCSSValueListFunc::call): (KJS::DOMRGBColor::get): (KJS::DOMRect::get): (KJS::DOMCounter::get):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::get): (KJS::DOMNode::put): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::call): (KJS::DOMNodeList::get): (KJS::DOMNodeList::call): (KJS::DOMNodeListFunc::call): (KJS::DOMAttr::get): (KJS::DOMAttr::put): (KJS::DOMAttr::putValueProperty): (KJS::DOMDocument::get): (KJS::DOMDocument::put): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::call): (KJS::DOMElement::get): (KJS::DOMElementProtoFunc::call): (KJS::DOMDOMImplementationProtoFunc::call): (KJS::DOMDocumentType::get): (KJS::DOMNamedNodeMap::get): (KJS::DOMNamedNodeMapProtoFunc::call): (KJS::DOMProcessingInstruction::get): (KJS::DOMProcessingInstruction::put): (KJS::DOMNotation::get): (KJS::DOMEntity::get): (KJS::NodeConstructor::get): (KJS::DOMExceptionConstructor::get): (KJS::DOMNamedNodesCollection::get): (KJS::DOMCharacterData::get): (KJS::DOMCharacterData::put): (KJS::DOMCharacterDataProtoFunc::call): (KJS::DOMText::get): (KJS::DOMTextProtoFunc::call):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::EventConstructor::get): (KJS::DOMEvent::get): (KJS::DOMEvent::put): (KJS::DOMEvent::putValueProperty): (KJS::DOMEventProtoFunc::call): (KJS::EventExceptionConstructor::get): (KJS::DOMUIEvent::get): (KJS::DOMUIEventProtoFunc::call): (KJS::DOMMouseEvent::get): (KJS::DOMMouseEventProtoFunc::call): (KJS::DOMKeyboardEvent::get): (KJS::DOMKeyboardEventProtoFunc::call): (KJS::MutationEventConstructor::get): (KJS::DOMMutationEvent::get): (KJS::DOMMutationEventProtoFunc::call): (KJS::DOMWheelEvent::get): (KJS::DOMWheelEventProtoFunc::call): (KJS::Clipboard::get): (KJS::Clipboard::put): (KJS::Clipboard::putValueProperty): (KJS::ClipboardProtoFunc::call):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::call): (KJS::HTMLDocument::get): (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLDocument::putValueProperty): (KJS::KJS::HTMLElement::get): (KJS::KJS::HTMLElementFunction::call): (KJS::KJS::HTMLElement::put): (KJS::HTMLElement::putValueProperty): (KJS::KJS::HTMLCollection::get): (KJS::KJS::HTMLCollection::call): (KJS::KJS::HTMLCollectionProtoFunc::call): (KJS::KJS::HTMLSelectCollection::get): (KJS::KJS::HTMLSelectCollection::put): (KJS::Image::get): (KJS::Image::put): (KJS::Image::putValueProperty): (KJS::KJS::Context2DFunction::call): (KJS::Context2D::get): (KJS::Context2D::put): (KJS::Context2D::putValueProperty): (KJS::GradientFunction::call): (KJS::Gradient::get): (KJS::Gradient::put): (KJS::Gradient::putValueProperty): (KJS::ImagePattern::get): (KJS::ImagePattern::put): (KJS::ImagePattern::putValueProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginsFunc::call): (KJS::NavigatorFunc::call):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::get): (KJS::DOMRangeProtoFunc::call): (KJS::RangeConstructor::get):
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::get): (KJS::DOMNodeIteratorProtoFunc::call): (KJS::NodeFilterConstructor::get): (KJS::DOMNodeFilterProtoFunc::call): (KJS::DOMTreeWalker::get): (KJS::DOMTreeWalker::put): (KJS::DOMTreeWalkerProtoFunc::call):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::get): (KJS::DOMAbstractViewFunc::call):
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::call): (KJS::LocationFunc::call): (KJS::SelectionFunc::call): (KJS::HistoryFunc::call): (KJS::KonquerorFunc::call):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::get): (KJS::XMLHttpRequest::put): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequestProtoFunc::call):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::call):
12:48 PM Changeset in webkit [9832] by darin
  • 2 edits in trunk/WebKit

Reviewed by Geoff Garen.

  • improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Add "hidden" to the list of reasons to clip out all plug-in drawing.
11:43 AM Changeset in webkit [9831] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed broken bi-di layout tests: the "dir" attribute was broken
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Fix one case that said "direction" where it should say "dir".
11:35 AM Changeset in webkit [9830] by darin
  • 3 edits in trunk
  • updated results of two tests that reflect properly-preserved namespace prefixes for attributes
  • layout-tests/fast/dom/dom-parse-serialize-display-expected.txt:
  • layout-tests/fast/dom/dom-parse-serialize-expected.txt:
10:11 AM Changeset in webkit [9829] by sullivan
  • 4 edits in trunk/WebKit

Written by Trey Matteson <​trey@usa.net>
Reviewed by John Sullivan.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4049

scroll position not restored when going back/forward at ebay

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4061

When going back/forward to some pages, they redraw at top before restoring scroll position

The short story is that attempting to restore the scroll position
at the time when the first layout finishes addresses both of these
issues. An explanation of the underlying race condition is in
a large comment near -_restoreScrollPosition.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didFirstLayout]): Pass through to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Get rid of attempt to restoreScrollPosition that never did anything because the docView was always 0x0 size at that point. (-[WebFrame _opened]): Get rid of redundant call to restoreScrollPosition. The imminent call to layoutCompleted makes the same call. (-[WebFrame _didFirstLayout]): Restore the scroll position on first layout, if we're doing a b/f nav.
  • WebView.subproj/WebFrameInternal.h:
Note: See TracTimeline for information about the timeline view.