Timeline



Jul 26, 2005:

7:01 PM Changeset in webkit [9920] by justing
  • 2 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>

Reviewed by John Sullivan.

Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=4072>
Pressing back in browser misses out a page

  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): When reloading the same page or refreshing the page, update the URL in the b/f item with the URL that we wind up at. Due to cookies, it might be different than the result we just got when we loaded the same page.
6:53 PM Changeset in webkit [9919] by justing
  • 5 edits in trunk/WebCore

Patch by Trey Matteson <​trey@usa.net>

Reviewed by hyatt.

Fixed <rdar://problem/4083496> some elements draw selection when printing
Also listed as <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3992>

Simply added tests to prevent selection drawing when printing.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint):
  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::paint):
6:34 PM Changeset in webkit [9918] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin

Added forward declarations to fix new gcc4 errors

  • khtml/ecma/kjs_window.h:
  • khtml/xml/dom_elementimpl.h:
  • kwq/KWQMapImpl.h:
6:28 PM Changeset in webkit [9917] by justing
  • 2 edits in trunk/JavaScriptCore

Added a forward declaration to fix gcc4 build error

  • kjs/function.h:
6:12 PM Changeset in webkit [9916] by hyatt
  • 12 edits in trunk/WebCore

Have to commit with my own checkin message, since commit-log-editor dies on this patch for some odd reason.

4:12 PM Changeset in webkit [9915] by eseidel
  • 2 edits
    41 deletes in trunk/WebCore

Bug #: 4133
Submitted by: eseidel
Reviewed by: darin

  • WebCore.xcodeproj/project.pbxproj: Removed unused C++ DOM
  • khtml/dom/css_rule.cpp: Removed.
  • khtml/dom/css_stylesheet.cpp: Removed.
  • khtml/dom/css_value.cpp: Removed.
  • khtml/dom/dom2_range.cpp: Removed.
  • khtml/dom/dom2_views.cpp: Removed.
  • khtml/dom/dom2_views.h: Removed.
  • khtml/dom/dom_core.h: Removed.
  • khtml/dom/dom_doc.cpp: Removed.
  • khtml/dom/dom_doc.h: Removed.
  • khtml/dom/dom_element.cpp: Removed.
  • khtml/dom/dom_element.h: Removed.
  • khtml/dom/dom_html.h: Removed.
  • khtml/dom/dom_node.cpp: Removed.
  • khtml/dom/dom_text.cpp: Removed.
  • khtml/dom/dom_text.h: Removed.
  • khtml/dom/dom_xml.cpp: Removed.
  • khtml/dom/dom_xml.h: Removed.
  • khtml/dom/html_base.cpp: Removed.
  • khtml/dom/html_base.h: Removed.
  • khtml/dom/html_block.cpp: Removed.
  • khtml/dom/html_block.h: Removed.
  • khtml/dom/html_document.cpp: Removed.
  • khtml/dom/html_document.h: Removed.
  • khtml/dom/html_element.cpp: Removed.
  • khtml/dom/html_element.h: Removed.
  • khtml/dom/html_form.cpp: Removed.
  • khtml/dom/html_form.h: Removed.
  • khtml/dom/html_head.cpp: Removed.
  • khtml/dom/html_head.h: Removed.
  • khtml/dom/html_image.cpp: Removed.
  • khtml/dom/html_image.h: Removed.
  • khtml/dom/html_inline.cpp: Removed.
  • khtml/dom/html_inline.h: Removed.
  • khtml/dom/html_list.cpp: Removed.
  • khtml/dom/html_list.h: Removed.
  • khtml/dom/html_misc.cpp: Removed.
  • khtml/dom/html_misc.h: Removed.
  • khtml/dom/html_object.cpp: Removed.
  • khtml/dom/html_object.h: Removed.
  • khtml/dom/html_table.cpp: Removed.
  • khtml/dom/html_table.h: Removed. This removes unused C++ DOM files from both the project and the repository. There are a few left (css_, dom_) which will need to be cleaned over time.
3:45 PM Changeset in webkit [9914] by adele
  • 11 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch. Needed for other editing fixes on the branch.

2005-05-06 David Harrison <​harrison@apple.com>

Reviewed by Maciej, Darin.

<rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order

  • WebCore.pbproj/project.pbxproj: Removed dom_positioniterator.h and dom_positioniterator.cpp.
  • khtml/editing/htmlediting.cpp: Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
  • khtml/editing/selection.cpp: Removed unused include of dom_positioniterator.h.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::maxDeepOffset): Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atStart): (DOM::Position::atEnd): Moved here, replacing VisiblePosition's duplicate and PositionIterator. Fixed to return positions in order and not skip positions.

(DOM::Position::previousCharacterPosition):
(DOM::Position::nextCharacterPosition):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

(DOM::isStreamer):
(DOM::Position::upstream):
(DOM::Position::downstream):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

  • khtml/xml/dom_positioniterator.cpp: Removed.
  • khtml/xml/dom_positioniterator.h: Removed. Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
2:44 PM Changeset in webkit [9913] by adele
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-12 Justin Garcia <​justin.garcia@apple.com>

Reviewed by mjs

  • Fixes <rdar://problem/4124326> [RTL] Lines in messages with Hebrew text and numbers are truncated by Tiger Mail

Mail sends plaintext when a message doesn't have any formatting, plaintext depends on
innertext, which depends on TextIterators. A TextIterator iterates over text boxes
in render order, but assumes logical order, which was causing the problems.

Test cases added:

  • layout-tests/fast/text/international/bidi-innertext-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-innertext.html: Added.
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

If the text node contains reversed text, sort the text boxes (m_sortedTextBoxes).
Not all reversed text will be out of logical order, but this simple check is less expensive
than doing an exhaustive one. Most text is LTR and an exhaustive check might hurt performance.

(khtml::TextIterator::handleTextBox):

Iterates over sorted text boxes when necessary

  • khtml/editing/visible_text.h:
  • khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::position):

If asked to position a text box with reversed text, modify m_containsReversedText

  • khtml/rendering/render_text.h: (khtml::InlineTextBox::operator ==): Added to facilitate sorting (khtml::InlineTextBox::operator <): Ditto (khtml::RenderText::containsReversedText):
2:14 PM Changeset in webkit [9912] by adele
  • 13 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-05-26 David Harrison <​harrison@apple.com>

Reviewed by John.

<rdar://problem/4120518> Mail: control-T in an empty message crashes mail

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeOfCharactersAroundCaret]): Nil-check result of VisiblePosition previous() and next().
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::VisiblePosition::previousVisiblePosition): Make sure previous() does not return the original position. Also, simplified. Commented odd, but required, behavior in previousVisiblePosition().
  • khtml/editing/visible_units.cpp: (khtml::startOfEditableContent): (khtml::endOfEditableContent): Removed redundant check for isEditableContent().
  • khtml/editing/jsediting.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::transpose):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issueTransposeCommand):
  • layout-tests/editing/editing.js:
  • kwq/WebCoreBridge.h: Add support for transpose command in JavaScript and therefore layout tests.
  • layout-tests/editing/deleting/transpose-empty-expected.txt: Added.
  • layout-tests/editing/deleting/transpose-empty.html: Added. New test for this bug.

WebKit:

Merged fix from TOT to Safari-2-0-branch

2005-05-26 David Harrison <​harrison@apple.com>

<rdar://problem/4120518> Mail: control-T in an empty message crashes mail

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issueTransposeCommand]): New, to support transpose in JS.
1:57 PM Changeset in webkit [9911] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-04-26 Darin Adler <Darin Adler>

Reviewed by Maciej.

  • fixed <rdar://problem/4098826> Bezier curves broken in new Safari canvas object (last two parameters parsed incorrectly)
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Fixed incorrect argument indices. Thanks to Brian Campbell who figured out what was wrong.
1:44 PM Changeset in webkit [9910] by adele
  • 8 edits in branches/Safari-2-0-branch

Merged fix from TOT to Safari-2-0-branch

2005-04-26 Adele Peterson <​adele@apple.com>

Fixed by Darin, reviewed by me.

Fix for <rdar://problem/4084029> designMode doesn't allow editing when iframe src = "" or = about:blank

This change will add an HTML element for empty documents. Now that there will be an HTMLDocument in this case,
a body will also be created (see rdar://problem/3758785). This was preventing frames with empty documents from
being editable.

  • khtml/html/htmlparser.cpp: (KHTMLParser::finished):

Updated these tests to expect the HTML and BODY elements

  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/frames/002-expected.txt:
  • layout-tests/fast/frames/contentWindow_Frame-expected.txt:
  • layout-tests/fast/frames/contentWindow_iFrame-expected.txt:
  • layout-tests/fast/frames/empty-frame-src-expected.txt:
1:32 PM Changeset in webkit [9909] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-05-10 John Sullivan <​sullivan@apple.com>

Reviewed by Chris.

  • fixed <rdar://problem/4067981> Mail places RTF flavor before RTFD flavor when dragging mixed image/text content.
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _selectionPasteboardTypes]): put RTFD type before RTF type in array of types to declare
1:29 PM Changeset in webkit [9908] by hyatt
  • 3 edits in trunk/WebKit

Make WebHTMLView inherit from NSControl instead of NSView.
This change is necessary because the theme renderer for
WebCore that draws controls with the Aqua appearance does so
using NSCells. NSCells must be hosted within a control view
in order to paint properly.

The method updateCell must be overridden because it wants to
repaint the whole control when the windows resigns/becomes
key, and this would result in behavior that we don't want
(the repainting of the whole view). We already have hooks
in WebHTMLView for the window resigning/becoming key so
we will do our proper control updating there instead (in a
future patch).

Reviewed by john

  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateCell:]):
10:37 AM Changeset in webkit [9907] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Chris Blumenberg.

Test cases added: none, only affects Safari autofill

  • more work to wean form-related SPI from NSView. All that's left (but this is a big "all") is viewForElement: and elementForView:
  • kwq/WebCoreBridge.h: Rename control:textView:doCommandBySelector: to textField:doCommandBySelector:, and changed to take DOMHTMLInputElement* rather than NSControl* and NSTextView*
  • kwq/KWQTextField.mm: (-[KWQTextFieldController control:textView:doCommandBySelector:]): call renamed bridge method, passing DOMElement* instead of NSView*

WebKit:

Reviewed by Chris Blumenberg.

  • more work to wean form-related SPI from NSView. All that's left (but this is a big "all") is viewForElement: and elementForView:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textField:doCommandBySelector:]): changed signature to pass along DOMElement* rather than NSView*
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textField:doCommandBySelector:inFrame:]): ditto
10:28 AM Changeset in webkit [9906] by cblu
  • 3 edits in trunk

For every makefile that we set Xcode's default for PBXProductDirectory, also set PBXIntermediatesDirectory. This allows multiple CVS trees to live on one system without confusing each other.

9:34 AM Changeset in webkit [9905] by sullivan
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

Test cases added: none, only affects Safari autofill

  • big hunk of weaning form-related SPI from NSView; autofill continues to work (but only on tip of tree Safari)
  • kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): call renamed bridge method, passing DOMElement* instead of NSView*
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): call renamed bridge method, passing DOMElement* instead of NSView* (-[KWQTextFieldController controlTextDidEndEditing:]): ditto (-[KWQTextFieldController controlTextDidChange:]): ditto (-[KWQTextFieldController control:textShouldBeginEditing:]): don't call through to bridge form-delegate-related method; I deleted it because it was not being used (-[KWQTextFieldController control:textShouldEndEditing:]): ditto (-[KWQTextFieldController textView:shouldHandleEvent:]): call renamed bridge method, passing DOMElement* instead of NSView*
  • kwq/WebCoreBridge.h: Remove textShouldBeginEditing and textShouldEndEditing methods since they weren't being used. Rename other methods and made them take DOMElement* instead of NSView*

WebKit:

Reviewed by Darin Adler.

  • big hunk of weaning form-related SPI from NSView; autofill continues to work (but only on tip of tree Safari)
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textFieldDidBeginEditing:]): changed name from controlTextXXX:, now takes a DOMHTMLInputElement* (-[WebBridge textFieldDidEndEditing:]): ditto (-[WebBridge textDidChangeInTextField:]): ditto (-[WebBridge textDidChangeInTextArea:]): changed name from textDidChange:, now takes a DOMHTMLTextAreaElement* (-[WebBridge control:textShouldBeginEditing:]): removed this method as it wasn't being used by autofill, and did nothing in WebKit (-[WebBridge control:textShouldEndEditing:]): ditto (-[WebBridge textField:shouldHandleEvent:]): changed name from control:textView:shouldHandleEvent:, now takes a DOMHTMLInputElement*. The textView parameter wasn't being used, so I eliminated it.
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]): (-[WebFormDelegate textFieldDidEndEditing:inFrame:]): (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]): (-[WebFormDelegate control:textShouldEndEditing:inFrame:]): (-[WebFormDelegate textDidChangeInTextField:inFrame:]): (-[WebFormDelegate textDidChangeInTextArea:inFrame:]): (-[WebFormDelegate textField:shouldHandleEvent:inFrame:]): These all changed in the same way as the WebBridge methods
1:54 AM Changeset in webkit [9904] by mjs
  • 1 edit
    9 adds in trunk

WebCore:

  • imported much of the w3c DOM test suite:

DOM Level 1 Core (html version)
DOM Level 2 Core (html version)
DOM Level 2 Events (html version)
DOM Level 2 HTML (html version)

For now I left out the XHTML versions.

Test cases added: (NONE)

  • layout-tests/dom/html/level1/core/*
  • layout-tests/dom/html/level2/core/*
  • layout-tests/dom/html/level2/events/*
  • layout-tests/dom/html/level2/html/*

WebKitTools:

Reviewed by Darin.

  • new script to review the DOM layout test results and see where we stand on actual success and failure
  • Scripts/check-dom-results: Added.
1:36 AM Changeset in webkit [9903] by mjs
  • 1 edit
    2898 adds in trunk

WebCore:

  • imported much of the w3c DOM test suite:

DOM Level 1 Core (html version)
DOM Level 2 Core (html version)
DOM Level 2 Events (html version)
DOM Level 2 HTML (html version)

For now I left out the XHTML versions.

Test cases added: (NONE)

  • layout-tests/dom/html/level1/core/*
  • layout-tests/dom/html/level2/core/*
  • layout-tests/dom/html/level2/events/*
  • layout-tests/dom/html/level2/html/*

WebKitTools:

Reviewed by Darin.

  • new script to review the DOM layout test results and see where we stand on actual success and failure
  • Scripts/check-dom-results: Added.

Jul 25, 2005:

9:39 PM Changeset in webkit [9902] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Check in missing line of code.
8:58 PM Changeset in webkit [9901] by darin
  • 5 edits in trunk/WebKitTools
  • fixed problem that was causing JavaScriptCore test to fail (except for people who had set DYLD_FRAMEWORK_PATH)
  • Scripts/run-javascriptcore-tests: Add code to set DYLD_FRAMEWORK_PATH. Add code to parse configuration parameter so you can pass --deployment if you like.
  • Scripts/run-webkit-tests: Add code to parse configuration parameter.
  • Scripts/update-javascriptcore-test-results: Add license header.
  • Scripts/webkitdirs.pm: Change code that reads configuration option to remove it from @ARGV. This lets us use this option in commands that take other options and pass them along to a subsequent tool.
5:56 PM Changeset in webkit [9900]
  • 37 copies
    3 deletes in tags/JavaScriptCore-412~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~6'.

5:56 PM Changeset in webkit [9899] by adele
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning for Safari-2-0-branch - JavaScriptCore-412.6

5:52 PM Changeset in webkit [9898]
  • 140 copies
    2 deletes in tags/WebCore-415~15

This commit was manufactured by cvs2svn to create tag
'WebCore-415~15'.

5:52 PM Changeset in webkit [9897] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-415.15

5:48 PM Changeset in webkit [9896]
  • 36 copies
    3 deletes in tags/WebKit-412~8

This commit was manufactured by cvs2svn to create tag 'WebKit-412~8'.

5:48 PM Changeset in webkit [9895] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-412.8

5:40 PM Changeset in webkit [9894] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merge from TOT to Safari-2-0-branch
<rdar://problem/3470523>

2005-07-25 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

  • fixed <rdar://problem/3470523> Safari's user agent should be changed to say Intel rather than PPC on Intel machines
  • WebView.subproj/WebView.m: add conditional #defines for "PPC" and "Intel" (-[WebView userAgentForURL:]): use this variable when constructing the user agent string
5:14 PM Changeset in webkit [9893] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • fixed mistake in my last checkin -- the expected results included results from a patch that hasn't landed yet.
  • tests/mozilla/expected.html:
5:11 PM Changeset in webkit [9892] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fixed <rdar://problem/3470523> Safari's user agent should be changed to say Intel rather than PPC on Intel machines
  • WebView.subproj/WebView.m: add conditional #defines for "PPC" and "Intel" (-[WebView userAgentForURL:]): use this variable when constructing the user agent string
4:35 PM Changeset in webkit [9891] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix mistake in last change that leads to assertion failure in the Development build
  • kjs/lookup.h: (KJS::lookupGetOwnValue):
4:13 PM Changeset in webkit [9890] by vicki
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Beth Dakin.

  • fixed <rdar://problem/4011544> selecting an item from a <select> menu with the mouse doesn't place the focus on the menu

Test cases added:

  • manual-tests/focus-select-when-clicked.html: Added.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES
3:17 PM Changeset in webkit [9889] by mjs
  • 50 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • 10% speedup on JavaScript iBench
  • 5% speedup on 24fun BenchJS benchmark

Changed all get methods to getOwnProperty - they are no longer
responsible for prototype lookup, and determine if the property
was found as a side efect.

get() is now a nonvirtual ObjectImp method which calls the virtual
getOwnProperty and walks the prototype chain. A few selected
methods were inlined.

Changed ResolveNode::evaluate plus some other places to use
getProperty which does get() and hasProperty() in one lookup.

Also miscellaneous code cleanup.

  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp): (ObjcFallbackObjectImp::getOwnProperty):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::getOwnProperty):
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp: (RuntimeMethodImp::getOwnProperty):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getOwnProperty):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::getOwnProperty): (ArrayPrototypeImp::getOwnProperty): (ArrayProtoFuncImp::call):
  • kjs/array_object.h:
  • kjs/date_object.cpp: (DatePrototypeImp::getOwnProperty):
  • kjs/date_object.h:
  • kjs/function.cpp: (KJS::FunctionImp::getOwnProperty): (KJS::ArgumentsImp::getOwnProperty): (KJS::ActivationImp::getOwnProperty):
  • kjs/function.h:
  • kjs/lookup.h: (KJS::lookupGetOwnProperty): (KJS::lookupGetOwnFunction): (KJS::lookupGetOwnValue):
  • kjs/math_object.cpp: (MathObjectImp::getOwnProperty): (MathObjectImp::getValueProperty):
  • kjs/math_object.h:
  • kjs/nodes.cpp: (ResolveNode::evaluate):
  • kjs/number_object.cpp: (NumberObjectImp::getOwnProperty):
  • kjs/number_object.h:
  • kjs/object.cpp: (KJS::ObjectImp::get): (KJS::ObjectImp::getOwnProperty): (KJS::ObjectImp::getProperty):
  • kjs/object.h: (KJS::ObjectImp::getProperty): (KJS::ObjectImp::getOwnProperty):
  • kjs/object_object.cpp: (ObjectProtoFuncImp::call):
  • kjs/regexp_object.cpp: (RegExpObjectImp::getOwnProperty):
  • kjs/regexp_object.h:
  • kjs/string_object.cpp: (StringInstanceImp::getOwnProperty): (StringPrototypeImp::getOwnProperty):
  • kjs/string_object.h:

WebCore:

Reviewed by Darin.

  • 10% speedup on JavaScript iBench
  • 5% speedup on 24fun BenchJS benchmark

Changed all get methods to getOwnProperty - they are no longer responsible for
prototype lookup, and determine if the property was found as a side efect.

Also miscellaneous code cleanup.

  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::getOwnProperty): (KJS::DOMStyleSheet::getOwnProperty): (KJS::DOMStyleSheetList::getOwnProperty): (KJS::DOMMediaList::getOwnProperty): (KJS::DOMCSSStyleSheet::getOwnProperty): (KJS::DOMCSSRuleList::getOwnProperty): (KJS::DOMCSSRule::getOwnProperty): (KJS::DOMCSSRule::getValueProperty): (KJS::CSSRuleConstructor::getOwnProperty): (KJS::DOMCSSValue::getOwnProperty): (KJS::CSSValueConstructor::getOwnProperty): (KJS::DOMCSSPrimitiveValue::getOwnProperty): (KJS::CSSPrimitiveValueConstructor::getOwnProperty): (KJS::DOMCSSValueList::getOwnProperty): (KJS::DOMRGBColor::getOwnProperty): (KJS::DOMRect::getOwnProperty): (KJS::DOMCounter::getOwnProperty):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getOwnProperty): (KJS::DOMNodeList::getOwnProperty): (KJS::DOMAttr::getOwnProperty): (KJS::DOMDocument::getOwnProperty): (KJS::DOMElement::getOwnProperty): (KJS::DOMDocumentType::getOwnProperty): (KJS::DOMNamedNodeMap::getOwnProperty): (KJS::DOMProcessingInstruction::getOwnProperty): (KJS::DOMNotation::getOwnProperty): (KJS::DOMEntity::getOwnProperty): (KJS::NodeConstructor::getOwnProperty): (KJS::DOMExceptionConstructor::getOwnProperty): (KJS::DOMNamedNodesCollection::getOwnProperty): (KJS::DOMCharacterData::getOwnProperty):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::EventConstructor::getOwnProperty): (KJS::DOMEvent::getOwnProperty): (KJS::EventExceptionConstructor::getOwnProperty): (KJS::DOMUIEvent::getOwnProperty): (KJS::DOMMouseEvent::getOwnProperty): (KJS::DOMKeyboardEvent::getOwnProperty): (KJS::MutationEventConstructor::getOwnProperty): (KJS::DOMMutationEvent::getOwnProperty): (KJS::DOMWheelEvent::getOwnProperty): (KJS::Clipboard::getOwnProperty):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::getOwnProperty): (KJS::KJS::HTMLElement::getOwnProperty): (KJS::KJS::HTMLCollection::getOwnProperty): (KJS::KJS::HTMLSelectCollection::getOwnProperty): (KJS::Image::getOwnProperty): (KJS::Context2D::getOwnProperty): (KJS::Gradient::getOwnProperty): (KJS::ImagePattern::getOwnProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::Plugin::Plugin): (KJS::Navigator::getOwnProperty): (KJS::Plugins::getOwnProperty): (KJS::MimeTypes::getOwnProperty): (KJS::Plugin::getOwnProperty): (KJS::MimeType::getOwnProperty):
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getOwnProperty): (KJS::RangeConstructor::getOwnProperty):
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getOwnProperty): (KJS::NodeFilterConstructor::getOwnProperty): (KJS::DOMTreeWalker::getOwnProperty):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::getOwnProperty):
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getOwnProperty): (KJS::Window::~Window): (KJS::Window::getOwnProperty): (KJS::Window::put): (KJS::FrameArray::getOwnProperty): (KJS::Location::Location): (KJS::Location::getOwnProperty): (KJS::Location::put): (KJS::Selection::Selection): (KJS::Selection::getOwnProperty): (KJS::BarInfo::getOwnProperty): (KJS::History::getOwnProperty):
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getOwnProperty):
  • khtml/ecma/xmlhttprequest.h:
2:55 PM Changeset in webkit [9888] by darin
  • 4 edits in trunk/WebKitTools

Reviewed by Geoff Garen.

  • Fixed run-safari and gdb-safari to use the Safari application in the build results directory, if any, falling back to the one in the Applications directory otherwise. Does no harm for open source contributors who don't build Safari, and helps out the Safari team, since we do build Safari.
  • Scripts/webkitdirs.pm: Added safariPath function that uses WEBKIT_SAFARI environment variable, and if that's not present, looks in either the build results directory or /Applications; factors code that was in both scripts before into a shared function. Also removed some Xcode 2.0 support which is no longer relevant since our projects are now in Xcode 2.1 format and incompatible with older versions of Xcode.
  • Scripts/gdb-safari: Use safariPath.
  • Scripts/run-safari: Use safariPath.
2:50 PM Changeset in webkit [9887] by justing
  • 2 edits in trunk/WebCore

Reviewed by hyatt

Backing out a change that made the caret invisible in Mail in certain situations.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
1:38 PM Changeset in webkit [9886] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by darin.

  • tests/mozilla/js1_2/Array/tostring_1.js: now tests only for JS 1.5 behavior
  • tests/mozilla/js1_2/Array/tostring_2.js: ditto
  • tests/mozilla/expected.html:
9:59 AM Changeset in webkit [9885] by justing
  • 1 edit
    1 add in trunk/WebCore

Added a manual test for a recent change to WebKit

Test cases added:

  • manual-tests/deleteToEndOfLine.html: Added.

Jul 24, 2005:

5:35 PM Changeset in webkit [9884] by justing
  • 2 edits in trunk/WebKit

Reviewed by mjs

  • Fixes <rdar://problem/4120535> deleteToEndOfLine: does not delete thew newline when at the end of a line

Fix to match NSTextView. Delete the next character if deleteToEndOfLine fails

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView deleteToEndOfLine:]):
3:58 PM Changeset in webkit [9883] by justing
  • 5 edits in trunk/WebKit

Patch by Trey Matteson <​trey@apple.com>

Reviewed by john

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3953> back-forward items have wrong titles after sub-frame navigations

This was caused by a mistaken data structure, where WebDataSource tried to keep a list of
b/f items it was responsible for. The problem arose in the case of frames, where a subframe
was loaded with new content. When this happens a fresh tree of b/f items is created,
but the reference in the DataSource still pointed to the old item.

Since the WebFrame does a lot of work to track the current b/f item, the easiest thing is to
get rid of the DataSource's reference, and have it ask the WebFrame to set the title on the
right b/f item.

  • WebView.subproj/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _setTitle:]):
  • WebView.subproj/WebFramePrivate.h:
3:44 PM Changeset in webkit [9882] by justing
  • 3 edits in trunk/WebCore

Patch by Anders Carlsson <​andersca@mac.com>

Reviewed by hyatt

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::call): (KJS::Context2D::updateFillImagePattern): (KJS::Context2D::updateStrokeImagePattern): (KJS::Context2D::putValueProperty): (KJS::Context2D::Context2D): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h:
3:01 PM Changeset in webkit [9881] by justing
  • 4 edits in trunk

Reviewed by kevin.

Fixes make clean problem introduced in xcode2.1 transition

  • Makefile.am:
2:58 PM Changeset in webkit [9880] by justing
  • 2 edits in trunk/WebKit

Reviewed by kevin

Fixed make clean problem

  • Makefile.am:
2:36 PM Changeset in webkit [9879] by justing
  • 1 edit in trunk/WebKit/ChangeLog

Patch by <​opendarwin.org@mitzpettel.com>

Reviewed by darin and hyatt

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
The fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
so that they would be rendered if the font includes a glyph for bidi control characters.

Also adding a manual test

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun):
2:35 PM Changeset in webkit [9878] by justing
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Adding a manual test for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>

Test cases added:

  • manual-tests/bidi-visible-control-characters.html: Added.

Jul 23, 2005:

1:49 PM Changeset in webkit [9877] by justing
  • 1 edit
    1 add in trunk/WebCore

Adding a manual test for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>, since
our layout test font doesn't include glyphs for bidi control characters

Test cases added:

  • manual-tests/bidi-visible-control-characters.html: Added.
1:45 PM Changeset in webkit [9876] by justing
  • 2 edits in trunk/WebKit

Patch by <​opendarwin.org@mitzpettel.com>

Reviewed by darin and hyatt

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
The fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
so that they would be rendered if the font includes a glyph for bidi control characters.

Also adding a manual test (our default layout test font does not include bidi control characters)

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun):

Jul 22, 2005:

5:50 PM Changeset in webkit [9875] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

  • kjs/date_object.cpp: DatePrototypeImp now identifies itself as a child class of DateInstanceImp -- this enables calls to Date.ValueOf().

fixes: ecma/Date/15.9.5.js (once we enable the date tests).

5:34 PM Changeset in webkit [9874] by ggaren
  • 4 edits
    2 adds
    1 delete in trunk

JavaScriptCore:

Reviewed by darin.

  • tests/mozilla/jsDriver.pl: now takes the path to testkjs as a command-line argument
  • tests/mozilla/run-mozilla-tests: Removed.

WebKitTools:

Moved Tools/Scripts/run-mozilla-tests to WebKitTools/Scripts/run-javascriptcore-tests.
run-javascriptcore-tests now passes its command-line arguments to jsDriver.pl

Moved Tools/Scripts/update-mozilla-js-test-results to
WebKitTools/Scripts/update-javascriptcore-test-results.

Reviewed by darin.

  • Scripts/run-javascriptcore-tests: Added.
2:52 PM Changeset in webkit [9873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Justin Garcia.

Mail (running on tip of tree WebKit) was running into an assertion I recently added.
The assertion is actually correct, catching an old bug in this code.

  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): if the first responder is a WebFrameView, then we've found the WebFrameView we're looking for, and we shouldn't look at its superviews.
2:34 PM Changeset in webkit [9872] by hyatt
  • 2 edits in trunk/WebCore

Put back in the <script src="foo"/> self-closing tag quirk in HTML. Unfortunately
Dashboard widgets are dependent on this quirk.

Reviewed by mjs

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
11:09 AM Changeset in webkit [9871] by sullivan
  • 9 edits in trunk

WebCore:

Reviewed by Chris Blumenberg.

Test cases added: none, this only affects Safari autocomplete; it doesn't affect any
web pages.

  • some changes in the direction of weaning all the form-related SPI from NSView
  • kwq/DOMExtensions.h: added -[DOMHTMLInputElement isTextField]
  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement isTextField]): new method that returns YES if this element is one of the types that's represented by a text field (as opposed to a button, slider, etc.). I could have put this method in Safari, but it seems useful for other WebKit clients.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge viewForElement:]): added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm: to return DOMElements rather than NSViews, while keeping autocomplete working in Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit (it will always fail to find anything to autocomplete) (-[WebCoreBridge controlsInForm:]): now returns an array of DOMElement* rather than an array of NSView*

WebKit:

Reviewed by Chris Blumenberg.

  • some changes in the direction of weaning all the form-related SPI from NSView
  • PublicHeaderChangesFromTiger.txt: noted that the WebCore change to add -[DOMHTMLInputElement isTextField] to DOMExtensions.h is a public header change.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation viewForElement:]): added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm: to return DOMElements rather than NSViews, while keeping autocomplete working in Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit (it will always fail to find anything to autocomplete)
Note: See TracTimeline for information about the timeline view.