Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 13, 2005:

1:23 PM Changeset in webkit [10172]

• 328 copies
  3 deletes in tags/Safari-416~1

This commit was manufactured by cvs2svn to create tag 'Safari-416~1'.

1:23 PM Changeset in webkit [10171] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This was a regression caused by the acid2 changes, so it needs to be on the branch too.

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.
Could not figure out how to make an <object> fallback, so for now, no layout test.

• fixed <rdar://problem/4134124> REGRESSION (tip of tree): crash in QWidget::getView handling onunload event (yahoo.com)

• khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::getObjectInstance): Check type of RenderObject to be sure it is a RenderWidget before calling widget() on it.

10:25 AM Changeset in webkit [10170] by adele

• 6 edits in branches/Safari-2-0-branch

Versioning for Safari-2-0-branch - Safari-416.1

10:13 AM Changeset in webkit [10169] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Rolled out fix since it doesn't work right on the branch
<rdar://problem/4202641> Line breaks do not happen inside whitespace:pre; word-wrap: break-word

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

Aug 12, 2005:

4:20 PM Changeset in webkit [10168] by mjs

• 4 edits in trunk/JavaScriptCore

Reviewed by John.

• two simple speed improvements for a 3% speed gain

• JavaScriptCore.xcodeproj/project.pbxproj: turn on -fstrict-aliasing

• kjs/scope_chain.h: (KJS::ScopeChainIterator::ScopeChainIterator): Add a scope chain iterator so you can walk a scope chain without having to make a copy that you then mutate. (KJS::ScopeChainIterator::operator*): standard iterator operation (KJS::ScopeChainIterator::operator->): ditto (KJS::ScopeChainIterator::operator++): ditto (KJS::ScopeChainIterator::operator==): ditto (KJS::ScopeChainIterator::operator!=): ditto (KJS::ScopeChain::begin): Iterator for the top of the scope chain (KJS::ScopeChain::end): Iterator for one past the bottom (i.e. null)
• kjs/nodes.cpp: (ResolveNode::evaluate): Use scope chain iterator instead of copying a scope chain and then modifying the copy (ResolveNode::evaluateReference): ditto (FunctionCallResolveNode::evaluate): ditto (AssignResolveNode::evaluate): ditto

4:02 PM Changeset in webkit [10167] by ggaren

• 1 delete in branches/pcre-6-1-branch/JavaScriptCore/pcre/pcre.c

removed old file: pcre.c

3:43 PM Changeset in webkit [10166] by ggaren

• 2 edits in trunk/WebCore

Reviewed by adele.

• manual-tests/liveconnect-security-exception.html:
  • fixed wrong codebase path
  • added instruction to disable popup blocking

3:26 PM Changeset in webkit [10165] by darin

• 24 deletes in trunk/JavaScriptCore/pcre

remove files from TOT that should only have been on the branch

3:23 PM Changeset in webkit [10164]

• 6 copies
  26 deletes in tags/pcre-6-1

This commit was manufactured by cvs2svn to create tag 'pcre-6-1'.

3:23 PM Changeset in webkit [10163] by darin

• 5 edits
  4 deletes in branches/pcre-6-1-branch/JavaScriptCore/pcre

reapply changes I meant to do on the branch in the first place

3:18 PM Changeset in webkit [10162]

• 1 copy
  21 deletes in branches/pcre-6-1-branch

This commit was manufactured by cvs2svn to create branch
'pcre-6-1-branch'.

3:18 PM Changeset in webkit [10161]

• 1 copy
  21 deletes in tags/pcre-6-1-anchor

This commit was manufactured by cvs2svn to create tag
'pcre-6-1-anchor'.

3:18 PM Changeset in webkit [10160] by darin

• 5 edits
  5 adds in trunk/JavaScriptCore/pcre

oops; roll back, this was supposed to be on a branch

3:13 PM Changeset in webkit [10159] by darin

• 5 edits
  24 adds
  5 deletes in trunk/JavaScriptCore/pcre

checking in PCRE 6.1 sources with no changes yet

3:03 PM Changeset in webkit [10158] by darin

• 1 delete in trunk/JavaScriptCore/pcre/pcregrep.c

another unneeded file

3:02 PM Changeset in webkit [10157] by darin

• 2 deletes in trunk/JavaScriptCore/pcre

more unneeded files

3:02 PM Changeset in webkit [10156] by darin

• 1 delete in trunk/JavaScriptCore/pcre/mkinstalldirs

removed another unneeded file

3:01 PM Changeset in webkit [10155] by darin

• 6 deletes in trunk/JavaScriptCore/pcre

remove some files -- we should remove them on TOT too later

12:58 PM Changeset in webkit [10154] by mjs

• 2 edits in trunk/JavaScriptCore

Patch from Anders Carlsson, reviewed by me.

• kjs/nodes.h: Fix build breakage.

11:56 AM Changeset in webkit [10153] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Added a few more missing changes for acid2.

• khtml/khtmlview.cpp: (KHTMLView::layout):
• khtml/rendering/render_box.cpp: (RenderBox::setStyle):

11:25 AM Changeset in webkit [10152] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Added missing nil check from acid2 merge.

• khtml/khtmlview.cpp: (KHTMLView::layout):

1:47 AM Changeset in webkit [10151] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fixes from TOT to Safari-2-0-branch
<rdar://problem/4213775> Several fixes in WebCore's bidi algorithm

1:36 AM Changeset in webkit [10150] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4214024> Several improvements to WebKit's ability to render international text

1:27 AM Changeset in webkit [10149] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4205174> Hebrew or Arabic text on long pages becomes garbled

12:36 AM Changeset in webkit [10148] by mjs

• 7 edits in trunk/JavaScriptCore

Reviewed by hyatt.

• refactor function calls, 3% speedup on JS iBench.

• kjs/grammar.y:
• kjs/nodes.cpp: (Node::throwError): Added new useful variants. (FunctionCallValueNode::evaluate): New node to handle calls on expressions that are strictly values, not references. (FunctionCallValueNode::ref): ditto (FunctionCallValueNode::deref): ditto (FunctionCallResolveNode::evaluate): New node to handle calls on identifier expressions, so that they are looked up in the scope chain. (FunctionCallResolveNode::ref): ditto (FunctionCallResolveNode::deref): ditto (FunctionCallBracketNode::evaluate): New node to handle calls on bracket dereferences, so that the expression before brackets is used as the this object. (FunctionCallBracketNode::ref): ditto (FunctionCallBracketNode::deref): ditto (FunctionCallDotNode::evaluate): New node to handle calls on dot dereferences, so that the expression before the dot is used as the this object. (FunctionCallDotNode::ref): ditto (FunctionCallDotNode::deref): ditto (dotExprNotAnObjectString): helper function to avoid global variable access. (dotExprDoesNotAllowCallsString): ditto
• kjs/nodes.h: Declared new classes.
• kjs/nodes2string.cpp: (FunctionCallValueNode::streamTo): Added - serializes the appropriate function call (FunctionCallResolveNode::streamTo): ditto (FunctionCallBracketNode::streamTo): ditto (FunctionCallParenBracketNode::streamTo): ditto (FunctionCallDotNode::streamTo): ditto (FunctionCallParenDotNode::streamTo): ditto
• kjs/object.h: (KJS::ObjectImp::isActivation): Change how activation objects are detected in the scope chain, a virtual function is cheaper than the old inheritance test.
• kjs/function.h: (KJS::ActivationImp::isActivation): Ditto.

Aug 11, 2005:

6:53 PM Changeset in webkit [10147] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Beth Dakin <Beth Dakin>

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

• Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

6:35 PM Changeset in webkit [10146] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

• kwq/KWQListBox.h: added setFont method
• kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

6:30 PM Changeset in webkit [10145] by adele

• 3 edits in trunk/WebCore

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

• kwq/KWQListBox.h: added setFont method
• kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

4:10 PM Changeset in webkit [10144] by bdakin

• 2 edits in trunk/WebKit

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

• Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

2:37 PM Changeset in webkit [10143] by hyatt

• 2 edits
  2 adds in trunk

Refine the baseline alignment rule for inline blocks to cover for a hole in the spec. The spec doesnt say what to do
for overflow cases, e.g., when the last line is clipped, when the overflow box is scrolled, or even when overflow is
visible but the last line is outside your content box. We just revert to the old behavior in those cases. Hopefully
the spec will be clarified to explain what the right behavior is.

Reviewed by beth

Test cases added: fast/inline-block/tricky-baseline.html

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::baselinePosition):

1:57 PM Changeset in webkit [10142] by mjs

• 1 edit
  1 add in trunk/JavaScriptCore

• added missing file from earlier checkin

• kjs/grammar_types.h: Added. (KJS::makeNodePair): (KJS::makeNodeWithIdent):

11:58 AM Changeset in webkit [10141] by eseidel

• 4 edits in trunk/WebCore

Bug #: 4384
Submitted by: eseidel
Reviewed by: darin

• WebCore+SVG/DrawView.mm: (-[DrawViewPrivate drawRect:]): added additional NULL check.
• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): removed NSLog.
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): removed NSLog. Removed debugging logs, and fixed crasher for empty SVGs. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4384

10:40 AM Changeset in webkit [10140] by ggaren

• 2 edits in trunk

• layout-tests/fast/js/date-big-setdate.html: fixed title

4:58 AM Changeset in webkit [10139] by eseidel

• 2 edits in trunk/WebKitTools

Bug #: 4385
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

• DrawTest/TestController.m: (-[TestController imagePathForSVGPath:]): Fixed support for using TextViewer with the layout-tests. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4385

4:35 AM Changeset in webkit [10138] by eseidel

• 903 edits in trunk

Bug #: 4382
Submitted by: eseidel

No review needed, copyright update in comments.
All kdom, ksvg2, and kcanvas files affected.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4382

3:57 AM Changeset in webkit [10137] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

• kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
• tests/mozilla/expected.html: Updated for newly fixed test.

3:34 AM Changeset in webkit [10136] by mjs

• 2 edits in trunk/JavaScriptCore

• updated for one of the tests that Darin incidentally fixed.

• tests/mozilla/expected.html:

3:26 AM Changeset in webkit [10135] by mjs

• 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Refactor assignment grammar to avoid Reference type, and to later
be able to take advantage of writeable PropertySlots, when those
are added. I also fixed a minor bug, turning a function to a
string lost parentheses, I made sure they are printed at least
where semantically significant.

Test cases: see WebCore

• kjs/grammar.y: Change grammar so that assignment expressions are parsed directly to nodes that know how to set the kind of location being assigned, instead of having a generic assign node that counts on evaluateReference.
• kjs/lexer.cpp: Include grammar_types.h.
• kjs/nodes.cpp: (BracketAccessorNode): Renamed from AccessorNode1 for clarity. (DotAccessorNode): Renamed from AccessorNode2 for clarity. (combineForAssignment): Inline function for doing the proper kind of operation for various update assignments like += or *=. (AssignResolveNode): Node that handles assignment to a bare identifier. (AssignDotNode): Node that handles assignments of the form EXPR . IDENT = EXPR (AssignBracketNode): EXPR [ IDENT ] = EXPR
• kjs/nodes.h: Updated for declarations/renames of new classes.
• kjs/nodes2string.cpp: (GroupNode::streamTo): Fixed to print parens around the expression. (BracketAccessorNode::streamTo): Renamed. (DotAccessorNode::streamTo): Renamed. (AssignResolveNode::streamTo): Added. (AssignBracketNode::streamTo): Added. (AssignDotNode::streamTo): Added. (streamAssignmentOperatorTo): helper function for the above
• kjs/property_slot.h: (KJS::PropertySlot::isSet): Made this const.

WebCore:

Reviewed by Geoff.

Test cases added:

• layout-tests/fast/js/assign.html: Added. Test case for assignment to make sure I didn't break anything.
• layout-tests/fast/js/code-serialize-paren.html: Added, test case for a minor bug I fixed where parens were not getting serialized at all when turning a function into a string.

2:39 AM Changeset in webkit [10134] by mjs

• 10 edits in trunk

WebCore:

At Least Rougly Glanced At by Anders.

• fix change with totally breaks the layout tests.

Changed all the tests below to avoid dumping more than once -
since this now prints more than one separator, it totally throws
off the layout test driver so it needs to be avoided.

• layout-tests/dom/html/level2/html/HTMLFormElement10-expected.txt:
• layout-tests/dom/html/level2/html/HTMLFormElement10.html:
• layout-tests/dom/html/level2/html/HTMLFormElement10.js:
• layout-tests/fast/events/onunload-expected.txt:
• layout-tests/fast/events/onunload.html:
• layout-tests/fast/js/location-assign-expected.txt:
• layout-tests/fast/js/location-assign.html:

WebKitTools:

At Least Rougly Glanced At by Anders.

• fix change with totally breaks the layout tests.

• DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Make tests unready if you start another load, to avoid dumping twice accidentally.

Aug 10, 2005:

8:38 PM Changeset in webkit [10133] by eseidel

• 2 edits in trunk/WebKitTools

Bug #: 3840
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: darin

• DumpRenderTree/DumpRenderTree.m: Added support for rendering to a PNG file. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3840

6:39 PM Changeset in webkit [10132] by adele

• 2 edits in branches/Safari-2-0-branch/WebKit

Changes made to WebSubresourceLoader.m need to be made on WebSubresourceClient.m, since the file was renamed on TOT.

• WebCoreSupport.subproj/WebSubresourceClient.m:

6:28 PM Changeset in webkit [10131] by ggaren

• 1 edit
  4 adds in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

6:01 PM Changeset in webkit [10130] by vicki

• 12 edits in trunk

Changes from Curt Arnold, reviewed by Vicki.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4174 (DOM layout tests involving two
documents fail due to test framework problem), and update expected results for tests
affected by this change.

• layout-tests/dom/html/level1/core/hc_attrappendchild5-expected.txt:
• layout-tests/dom/html/level1/core/hc_attrinsertbefore6-expected.txt:
• layout-tests/dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
• layout-tests/dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
• layout-tests/dom/html/level1/core/hc_nodeappendchildnewchilddiffdocument-expected.txt:
• layout-tests/dom/html/level1/core/hc_nodeinsertbeforenewchilddiffdocument-expected.txt:
• layout-tests/dom/html/level1/core/hc_nodereplacechildnewchilddiffdocument-expected.txt:
• layout-tests/dom/html/level1/core/selfhtml.js:
• layout-tests/dom/html/level2/core/selfhtml.js:
• layout-tests/dom/html/level2/events/selfhtml.js:
• layout-tests/dom/html/level2/html/selfhtml.js:

5:42 PM Changeset in webkit [10129] by eseidel

• 1 edit
  16 adds
  8 deletes in trunk

Bug #: 4338
Submitted by: eseidel
Reviewed by: darin

• svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/script-handle-03-b.svg: Added.
• svg-tests/W3C-SVG-1.1/script-handle-03-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/script-handle-04-b.svg: Added.
• svg-tests/W3C-SVG-1.1/script-handle-04-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg-disabled: Removed.
• svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg: Added.
• svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg-disabled: Removed. Re-enabled previously crashing SVG test cases: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4338

5:28 PM Changeset in webkit [10128] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Vicki Murley <​vicki@apple.com>

Reviewed by John.

• attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

3:46 PM Changeset in webkit [10127] by vicki

• 2 edits in trunk/WebCore

Reviewed by John.

• attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

2:55 PM Changeset in webkit [10126] by adele

• in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:14:56 +0000

2:55 PM Changeset in webkit [10125] by adele

• in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:00 +0000

2:55 PM Changeset in webkit [10124] by adele

• 6 edits in trunk

Bumping version to 420+

• Info.plist:

2:54 PM Changeset in webkit [10123] by adele

• in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:09 +0000

2:41 PM Changeset in webkit [10122] by adele

• 5 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Geoffrey Garen <​ggaren@apple.com>

-fixed <rdar://problem/4151132> REGRESSION: Some applet liveconnect calls
throws privilege exception.

Reviewed by richard and mjs.

-I removed the global static JavaClass cache, since it violated Java
security to cache classes between websites and applets.

• bindings/jni/jni_class.cpp:

-removed global static cache dictionary
-instance constructor and destructor now do the work that used to
be done by static factory methods
-removed obsolete functions

(JavaClass::JavaClass):
(JavaClass::~JavaClass):

• bindings/jni/jni_class.h:

-removed obsolete function declarations
-made copying private since it's unused and it's also not clear
excatly how copying would work with Java security
-made default construction private since it's meaningless

• bindings/jni/jni_instance.cpp:

-removed obsolete functions

(JavaInstance::~JavaInstance):
(JavaInstance::getClass):

• bindings/jni/jni_instance.h:

-made copying private since it's unused and it's also not clear

excatly how copying would work with Java security
-made default construction private since it's meaningless

1:51 PM Changeset in webkit [10121] by ggaren

• 5 edits in trunk/JavaScriptCore

Bug #:
Submitted by:
Reviewed by:

10:44 AM Changeset in webkit [10120] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-09 David Harrison <​harrison@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/4210906> Word selection wrong with tabs

• khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):

10:19 AM Changeset in webkit [10119] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch.

• khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::tryCall): changes made to tryCall, which has been renamed on TOT.

2005-08-09 Vicki Murley <​vicki@apple.com>

Fixed by Anders Carlsson, Reviewed by Maciej.

• fixed <rdar://problem/4071417> add XMLSerializer object to WebCore's JavaScript support (4046)

Test cases added:

• layout-tests/fast/dom/XMLSerializer-expected.txt: Added.
• layout-tests/fast/dom/XMLSerializer.html: Added.

• khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction): allow any node to be serialized, not just documents

Aug 9, 2005:

7:48 PM Changeset in webkit [10118] by ggaren

• 8 edits in branches/Safari-2-0-branch

Bug #:
Submitted by:
Reviewed by:

6:13 PM Changeset in webkit [10117] by harrison

• 2 edits
  2 adds in trunk

Reviewed by Dave Hyatt.

<rdar://problem/4210906> Word selection wrong with tabs

Test cases added: selection/extend-by-word-001-html

• khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode):
• layout-tests/editing/selection/extend-by-word-001-html: Added.
• layout-tests/editing/selection/extend-by-word-001-expected.txt: Added.

4:53 PM Changeset in webkit [10116] by hyatt

• 4 edits in branches/Safari-2-0-branch/WebKit

Land the changes to pass Acid2.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

4:52 PM Changeset in webkit [10115] by hyatt

• 28 edits in branches/Safari-2-0-branch/WebCore

Land all the necessary changes to pass Acid2.

• khtml/css/html4.css:
• khtml/html/dtd.cpp: (DOM::checkChild):
• khtml/html/dtd.h:
• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseHTMLAttribute): (HTMLLinkElementImpl::tokenizeRelAttribute): (HTMLLinkElementImpl::process):
• khtml/html/html_headimpl.h:
• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::parseHTMLAttribute): (HTMLObjectElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::createRenderer): (HTMLObjectElementImpl::attach): (HTMLObjectElementImpl::detach): (HTMLObjectElementImpl::recalcStyle): (HTMLObjectElementImpl::childrenChanged): (HTMLObjectElementImpl::isImageType): (HTMLObjectElementImpl::renderFallbackContent):
• khtml/html/html_objectimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
• khtml/khtml_part.cpp: (KHTMLPart::requestObject): (KHTMLPart::processObjectRequest): (KHTMLPart::handleFallbackContent):
• khtml/khtml_part.h:
• khtml/khtmlpart_p.h: (khtml::ChildFrame::ChildFrame):
• khtml/khtmlview.cpp: (KHTMLView::applyOverflowToViewport): (KHTMLView::layout):
• khtml/khtmlview.h:
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::isSelfCollapsingBlock): (khtml::RenderBlock::layoutBlock):
• khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox):
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcHeight): (RenderBox::calcHeightUsing): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
• khtml/rendering/render_box.h:
• khtml/rendering/render_frames.cpp: (RenderPartObject::RenderPartObject): (RenderPartObject::updateWidget):
• khtml/rendering/render_frames.h: (khtml::RenderPart::hasFallbackContent):
• khtml/rendering/render_replaced.cpp: (RenderReplaced::RenderReplaced):
• khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::calcRowHeight): (RenderTableCell::baselinePosition):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::childAllowed):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
• kwq/KWQPainter.mm: (QPainter::_drawPoints):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mainResourceError]):

3:22 PM Changeset in webkit [10114] by justing

• 2 edits
  2 adds in trunk

Patch by Anders Carlsson <​andersca@mac.com>

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3837>

Page nearly loads but then returned to default page by javascript issue

Reviewed by darin

Test cases added:

• layout-tests/fast/tokenizer/script-after-frameset-expected.txt: Added.
• layout-tests/fast/tokenizer/script-after-frameset.html: Added.

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler):

2:55 PM Changeset in webkit [10113] by adele

• 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog-2005-08-23

Adding bug number to ChangeLog comment

2:54 PM Changeset in webkit [10112] by justing

• 8 edits in trunk

Patch by Anders Carlsson <​andersca@mac.com>

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=4330>

hasFeature('xhtml', ...) should return true

Reviewed by darin

Test cases updated:

• layout-tests/dom/html/level2/html/HTMLBodyElement09-expected.txt:
• layout-tests/dom/html/level2/html/HTMLBodyElement10-expected.txt:
• layout-tests/dom/html/level2/html/HTMLDocument24-expected.txt:
• layout-tests/dom/html/level2/html/HTMLDocument25-expected.txt:
• layout-tests/dom/html/level2/html/hasFeature03-expected.txt:
• layout-tests/dom/html/level2/html/hasFeature04-expected.txt: These are successful now.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): Support "xhtml".

2:47 PM Changeset in webkit [10111] by justing

• 3 edits in trunk

Patch by Anders Carlsson <​andersca@mac.com>

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=4322>

date-big-setdate.html testcase fails if the timezone isn't UTC-8

Reviewed by darin

Test cases added:

• layout-tests/fast/js/date-big-setdate-expected.txt:
• layout-tests/fast/js/date-big-setdate.html: Compare the millisecond value of the dates to see if they're sequential instead of simply printing the dates.

2:45 PM Changeset in webkit [10110] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-06-14 David Hyatt <​hyatt@apple.com>

The behavior of <pre> is broken so that the newline
is not always properly being eaten after the open of the tag. In addition we were eating the first newline
after all other tags. This patch stops eating newlines after other tags and refines the behavior for
pre to catch all cases.

Reviewed by sullivan

Test cases added: fast/text/whitespace/030.html

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write):

2:29 PM Changeset in webkit [10109] by justing

• 23 edits in trunk

Patch by Anders Carlsson <​andersca@mac.com

Reviewed by darin

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=4331> dispatchEvent should raise an exception

Test cases added:

• layout-tests/dom/html/level2/events/createEvent01-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent01-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent02-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent03-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent04-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent05-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent06-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent07-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent09-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent11-expected.txt:
• layout-tests/dom/html/level2/events/initEvent01-expected.txt:
• layout-tests/dom/html/level2/events/initEvent02-expected.txt:
• layout-tests/dom/html/level2/events/initEvent03-expected.txt: These tests pass now.

• layout-tests/dom/html/level2/events/dispatchEvent08-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent10-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt:
• layout-tests/dom/html/level2/events/dispatchEvent13-expected.txt: These tests fail somplace else now.

• khtml/dom/dom2_events.h: (DOM::EventException::): Add _EXCEPTION_OFFSET and _EXCEPTION_MAX.

• khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Handle EventExceptions.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Allow "Events" as event type.

• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): Raise exception if event is NULL, uninitialized, or if its name is the empty string.

• kwq/DOMInternal.mm: (raiseDOMException): Handle EventExceptions.

1:58 PM Changeset in webkit [10108] by hyatt

• 10 edits
  2 adds in trunk

Implement baseline alignment support for inline blocks. Inline blocks are supposed to use
the baseline of the last line in the block as their baseline. For marquees we still
bottom align, since marquees really have no discernible baseline in many cases (and this
retains compatibility with WinIE).

Reviewed by cblu

Test cases added: 006.html in fast/inline-block

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::baselinePosition): (khtml::RenderBlock::getBaselineOfLastLineBox):
• khtml/rendering/render_block.h:
• khtml/rendering/render_object.h: (khtml::RenderObject::getBaselineOfLastLineBox):
• layout-tests/css1/box_properties/acid_test-expected.txt:
• layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
• layout-tests/fast/forms/007-expected.txt:
• layout-tests/fast/inline-block/001-expected.txt:
• layout-tests/fast/inline-block/001.html:
• layout-tests/fast/inline-block/006-expected.txt: Added.
• layout-tests/fast/inline-block/006.html: Added.
• layout-tests/fast/selectors/064-expected.txt:

12:15 PM Changeset in webkit [10107] by vicki

• 2 edits
  2 adds in trunk

Fixed by Anders Carlsson, Reviewed by Maciej.

• fixed <rdar://problem/4071417> add XMLSerializer object to WebCore's JavaScript support (4046)

Test cases added:

• layout-tests/fast/dom/XMLSerializer-expected.txt: Added.
• layout-tests/fast/dom/XMLSerializer.html: Added.

• khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction): allow any node to be serialized, not just documents

11:46 AM Changeset in webkit [10106] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

change by Justin to fix build error.

• khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input):

11:22 AM Changeset in webkit [10105] by adele

• 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2005-07-14 Geoffrey Garen <​ggaren@apple.com>

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3970
throw statements fail inside eval statements

Reviewed by mjs.

• kjs/function.cpp: (KJS::GlobalFuncImp::call): Big change since I fixed the tabbing. The important part is: if (c.complType() == Throw) exec->setException(c.value());

• kjs/nodes.cpp: (ThrowNode::execute): removed duplicate KJS_CHECKEXCEPTION (TryNode::execute): try now clears the exception state before the finally block executes, and checks the state after the block executes, so that exceptions in finally code get caught.

10:52 AM Changeset in webkit [10104] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-08 David Hyatt <​hyatt@apple.com>

Fix for radar bug #4202641, make sure line breaks happen inside
white-space:pre if word-wrap:break-word is set.

Reviewed by darin

Test cases added: fast/text/whitespace/pre-break-word.html

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

10:48 AM Changeset in webkit [10103] by adele

• 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-04 Justin Garcia <​justin.garcia@apple.com>

Reviewed by kocienda

Fix for:

• <rdar://problem/4132360> HIM-8A428:Space key works like Return key in Mail application.
• <rdar://problem/4122708> Mail: when composing new mail with a Korean input method, the first space doesn't work

If the user terminates marked text with a space, a string including marked characters and a normal,
breaking space, is passed to WebCore in order to replace the previous marked sequence. The fix ensures
that the space becomes a non breaking space if necessary.

Test cases added:

• manual-tests/korean-input-space.html

• khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):

10:34 AM Changeset in webkit [10102] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-09 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

• fixed <rdar://problem/4056369> XML parsing hits disk to turn URL incorrectly passed as relative path name into absolute (prevents idle sleep)

• khtml/xml/xml_tokenizer.cpp: (khtml::createQStringParser): removed last parameter, since we are no longer passing the url to xmlCreatePushParserCtxt (khtml::XMLTokenizer::finish): removed last parameter from createQStringParser

10:33 AM Changeset in webkit [10101] by adele

• 2 edits in trunk/WebCore

Reviewed by Darin.

• fixed <rdar://problem/4056369> XML parsing hits disk to turn URL incorrectly passed as relative path name into absolute (prevents idle sleep)

• khtml/xml/xml_tokenizer.cpp: (khtml::createQStringParser): removed last parameter, since we are no longer passing the url to xmlCreatePushParserCtxt (khtml::XMLTokenizer::finish): removed last parameter from createQStringParser