Context Navigation

← Previous Period
Next Period →

Timeline

Aug 14, 2005:

10:01 PM Changeset in webkit [10192] by darin

2 edits
2 adds in trunk

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3429 Text transformed with text-transform does not copy with transform applied

Test cases added:

layout-tests/editing/pasteboard/paste-text-019-expected.txt: Added.
layout-tests/editing/pasteboard/paste-text-019.html: Added.

khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode): Use the DOMString from the RenderText, not the DOM text node. (khtml::TextIterator::handleTextBox): Ditto.

9:58 PM Changeset in webkit [10191] by darin

2 edits in trunk/WebCore

fixed build of some unit tests

khtml/misc/main_thread_malloc.h: We use functions from <stdlib.h> here in debug mode, so #include <stdlib.h>.

9:36 PM Changeset in webkit [10190] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4422 QFont has mistake where it caches computed pitch value incorrectly

kwq/KWQFont.mm: (QFont::setFamily): Set _pitch to Unknown when setting _NSFont to nil. (QFont::setFirstFamily): Ditto. (QFont::setPixelSize): Ditto. Might be unneeded; it would be bad to have the same font with different pitch settings at different sizes. But better to be safe. (QFont::setWeight): Ditto. Same caveat. (QFont::setItalic): Ditto. Ditto.

9:31 PM Changeset in webkit [10189] by darin

9 edits
2 adds in trunk

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3692 Word-spacing doesn't work as expected

Test cases added:

layout-tests/fast/css/word-space-extra-expected.txt: Added.
layout-tests/fast/css/word-space-extra.html: Added.

khtml/rendering/bidi.cpp: (khtml::RenderBlock::constructLine): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::findNextLineBreak):
khtml/rendering/font.cpp: (Font::drawText):
khtml/rendering/font.h: (khtml::Font::getWordSpacing):
khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally):
khtml/rendering/render_line.h:
khtml/rendering/render_text.cpp: (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth):
khtml/rendering/render_text.h: (khtml::InlineTextBox::setStart): (khtml::InlineTextBox::setLen):

8:40 PM Changeset in webkit [10188] by mjs

274 edits in trunk

updated test cases for new editing delegate output

layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
layout-tests/editing/deleting/delete-3608430-fix-expected.txt:
layout-tests/editing/deleting/delete-3608445-fix-expected.txt:
layout-tests/editing/deleting/delete-3608462-fix-expected.txt:
layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
layout-tests/editing/deleting/delete-3800834-fix-expected.txt:
layout-tests/editing/deleting/delete-3857753-fix-expected.txt:
layout-tests/editing/deleting/delete-3865854-fix-expected.txt:
layout-tests/editing/deleting/delete-3928305-fix-expected.txt:
layout-tests/editing/deleting/delete-3959464-fix-expected.txt:
layout-tests/editing/deleting/delete-4038408-fix-expected.txt:
layout-tests/editing/deleting/delete-4083333-fix-expected.txt:
layout-tests/editing/deleting/delete-after-span-ws-001-expected.txt:
layout-tests/editing/deleting/delete-after-span-ws-002-expected.txt:
layout-tests/editing/deleting/delete-after-span-ws-003-expected.txt:
layout-tests/editing/deleting/delete-and-undo-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
layout-tests/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
layout-tests/editing/deleting/delete-block-contents-001-expected.txt:
layout-tests/editing/deleting/delete-block-contents-002-expected.txt:
layout-tests/editing/deleting/delete-block-contents-003-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-002-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-003-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-004-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-005-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-006-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-007-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-008-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-009-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-010-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-013-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-014-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-015-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-018-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-019-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-020-expected.txt:
layout-tests/editing/deleting/delete-block-merge-contents-021-expected.txt:
layout-tests/editing/deleting/delete-br-001-expected.txt:
layout-tests/editing/deleting/delete-br-002-expected.txt:
layout-tests/editing/deleting/delete-br-003-expected.txt:
layout-tests/editing/deleting/delete-br-004-expected.txt:
layout-tests/editing/deleting/delete-br-005-expected.txt:
layout-tests/editing/deleting/delete-br-006-expected.txt:
layout-tests/editing/deleting/delete-br-007-expected.txt:
layout-tests/editing/deleting/delete-br-008-expected.txt:
layout-tests/editing/deleting/delete-br-009-expected.txt:
layout-tests/editing/deleting/delete-br-010-expected.txt:
layout-tests/editing/deleting/delete-br-011-expected.txt:
layout-tests/editing/deleting/delete-character-001-expected.txt:
layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
layout-tests/editing/deleting/delete-image-001-expected.txt:
layout-tests/editing/deleting/delete-image-002-expected.txt:
layout-tests/editing/deleting/delete-image-003-expected.txt:
layout-tests/editing/deleting/delete-image-004-expected.txt:
layout-tests/editing/deleting/delete-leading-ws-001-expected.txt:
layout-tests/editing/deleting/delete-line-001-expected.txt:
layout-tests/editing/deleting/delete-line-002-expected.txt:
layout-tests/editing/deleting/delete-line-003-expected.txt:
layout-tests/editing/deleting/delete-line-004-expected.txt:
layout-tests/editing/deleting/delete-line-005-expected.txt:
layout-tests/editing/deleting/delete-line-006-expected.txt:
layout-tests/editing/deleting/delete-line-007-expected.txt:
layout-tests/editing/deleting/delete-line-008-expected.txt:
layout-tests/editing/deleting/delete-line-009-expected.txt:
layout-tests/editing/deleting/delete-line-010-expected.txt:
layout-tests/editing/deleting/delete-line-011-expected.txt:
layout-tests/editing/deleting/delete-line-012-expected.txt:
layout-tests/editing/deleting/delete-line-013-expected.txt:
layout-tests/editing/deleting/delete-line-014-expected.txt:
layout-tests/editing/deleting/delete-line-015-expected.txt:
layout-tests/editing/deleting/delete-line-016-expected.txt:
layout-tests/editing/deleting/delete-line-017-expected.txt:
layout-tests/editing/deleting/delete-line-end-ws-001-expected.txt:
layout-tests/editing/deleting/delete-line-end-ws-002-expected.txt:
layout-tests/editing/deleting/delete-select-all-001-expected.txt:
layout-tests/editing/deleting/delete-select-all-002-expected.txt:
layout-tests/editing/deleting/delete-select-all-003-expected.txt:
layout-tests/editing/deleting/delete-selection-001-expected.txt:
layout-tests/editing/deleting/delete-tab-001-expected.txt:
layout-tests/editing/deleting/delete-tab-002-expected.txt:
layout-tests/editing/deleting/delete-tab-003-expected.txt:
layout-tests/editing/deleting/delete-tab-004-expected.txt:
layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
layout-tests/editing/deleting/delete-trailing-ws-002-expected.txt:
layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt:
layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt:
layout-tests/editing/deleting/forward-delete-expected.txt:
layout-tests/editing/deleting/smart-delete-001-expected.txt:
layout-tests/editing/deleting/smart-delete-002-expected.txt:
layout-tests/editing/execCommand/boldSelection-expected.txt:
layout-tests/editing/execCommand/italicizeByCharacter-expected.txt:
layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt:
layout-tests/editing/execCommand/selectAll-expected.txt:
layout-tests/editing/inserting/insert-3654864-fix-expected.txt:
layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
layout-tests/editing/inserting/insert-3786362-fix-expected.txt:
layout-tests/editing/inserting/insert-3800346-fix-expected.txt:
layout-tests/editing/inserting/insert-3851164-fix-expected.txt:
layout-tests/editing/inserting/insert-3907422-fix-expected.txt:
layout-tests/editing/inserting/insert-after-delete-001-expected.txt:
layout-tests/editing/inserting/insert-br-001-expected.txt:
layout-tests/editing/inserting/insert-br-002-expected.txt:
layout-tests/editing/inserting/insert-br-003-expected.txt:
layout-tests/editing/inserting/insert-br-004-expected.txt:
layout-tests/editing/inserting/insert-br-005-expected.txt:
layout-tests/editing/inserting/insert-br-006-expected.txt:
layout-tests/editing/inserting/insert-br-007-expected.txt:
layout-tests/editing/inserting/insert-br-008-expected.txt:
layout-tests/editing/inserting/insert-div-001-expected.txt:
layout-tests/editing/inserting/insert-div-002-expected.txt:
layout-tests/editing/inserting/insert-div-003-expected.txt:
layout-tests/editing/inserting/insert-div-004-expected.txt:
layout-tests/editing/inserting/insert-div-005-expected.txt:
layout-tests/editing/inserting/insert-div-006-expected.txt:
layout-tests/editing/inserting/insert-div-007-expected.txt:
layout-tests/editing/inserting/insert-div-008-expected.txt:
layout-tests/editing/inserting/insert-div-009-expected.txt:
layout-tests/editing/inserting/insert-div-010-expected.txt:
layout-tests/editing/inserting/insert-div-011-expected.txt:
layout-tests/editing/inserting/insert-div-012-expected.txt:
layout-tests/editing/inserting/insert-div-013-expected.txt:
layout-tests/editing/inserting/insert-div-014-expected.txt:
layout-tests/editing/inserting/insert-div-015-expected.txt:
layout-tests/editing/inserting/insert-div-016-expected.txt:
layout-tests/editing/inserting/insert-div-017-expected.txt:
layout-tests/editing/inserting/insert-div-018-expected.txt:
layout-tests/editing/inserting/insert-div-019-expected.txt:
layout-tests/editing/inserting/insert-div-020-expected.txt:
layout-tests/editing/inserting/insert-div-021-expected.txt:
layout-tests/editing/inserting/insert-div-022-expected.txt:
layout-tests/editing/inserting/insert-div-023-expected.txt:
layout-tests/editing/inserting/insert-div-024-expected.txt:
layout-tests/editing/inserting/insert-div-025-expected.txt:
layout-tests/editing/inserting/insert-div-026-expected.txt:
layout-tests/editing/inserting/insert-div-027-expected.txt:
layout-tests/editing/inserting/insert-space-in-empty-doc-expected.txt:
layout-tests/editing/inserting/insert-tab-001-expected.txt:
layout-tests/editing/inserting/insert-tab-002-expected.txt:
layout-tests/editing/inserting/insert-tab-003-expected.txt:
layout-tests/editing/inserting/insert-tab-004-expected.txt:
layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
layout-tests/editing/inserting/return-key-with-selection-001-expected.txt:
layout-tests/editing/inserting/return-key-with-selection-002-expected.txt:
layout-tests/editing/inserting/return-key-with-selection-003-expected.txt:
layout-tests/editing/inserting/typing-001-expected.txt:
layout-tests/editing/inserting/typing-002-expected.txt:
layout-tests/editing/inserting/typing-003-expected.txt:
layout-tests/editing/inserting/typing-around-br-001-expected.txt:
layout-tests/editing/inserting/typing-around-image-001-expected.txt:
layout-tests/editing/pasteboard/cut-text-001-expected.txt:
layout-tests/editing/pasteboard/paste-4035648-fix-expected.txt:
layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-001-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-002-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-003-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-004-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-005-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-006-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-007-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-008-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-009-expected.txt:
layout-tests/editing/pasteboard/paste-line-endings-010-expected.txt:
layout-tests/editing/pasteboard/paste-match-style-001-expected.txt:
layout-tests/editing/pasteboard/paste-match-style-002-expected.txt:
layout-tests/editing/pasteboard/paste-pre-001-expected.txt:
layout-tests/editing/pasteboard/paste-text-001-expected.txt:
layout-tests/editing/pasteboard/paste-text-002-expected.txt:
layout-tests/editing/pasteboard/paste-text-003-expected.txt:
layout-tests/editing/pasteboard/paste-text-004-expected.txt:
layout-tests/editing/pasteboard/paste-text-005-expected.txt:
layout-tests/editing/pasteboard/paste-text-006-expected.txt:
layout-tests/editing/pasteboard/paste-text-007-expected.txt:
layout-tests/editing/pasteboard/paste-text-008-expected.txt:
layout-tests/editing/pasteboard/paste-text-009-expected.txt:
layout-tests/editing/pasteboard/paste-text-010-expected.txt:
layout-tests/editing/pasteboard/paste-text-011-expected.txt:
layout-tests/editing/pasteboard/paste-text-012-expected.txt:
layout-tests/editing/pasteboard/paste-text-013-expected.txt:
layout-tests/editing/pasteboard/paste-text-014-expected.txt:
layout-tests/editing/pasteboard/paste-text-015-expected.txt:
layout-tests/editing/pasteboard/paste-text-016-expected.txt:
layout-tests/editing/pasteboard/paste-text-017-expected.txt:
layout-tests/editing/pasteboard/paste-text-018-expected.txt:
layout-tests/editing/pasteboard/smart-paste-001-expected.txt:
layout-tests/editing/pasteboard/smart-paste-002-expected.txt:
layout-tests/editing/pasteboard/smart-paste-003-expected.txt:
layout-tests/editing/pasteboard/smart-paste-004-expected.txt:
layout-tests/editing/pasteboard/smart-paste-005-expected.txt:
layout-tests/editing/pasteboard/smart-paste-006-expected.txt:
layout-tests/editing/pasteboard/smart-paste-007-expected.txt:
layout-tests/editing/selection/move-between-blocks-no-001-expected.txt:
layout-tests/editing/selection/select-all-001-expected.txt:
layout-tests/editing/selection/select-all-002-expected.txt:
layout-tests/editing/selection/select-all-003-expected.txt:
layout-tests/editing/selection/select-all-004-expected.txt:
layout-tests/editing/style/block-style-001-expected.txt:
layout-tests/editing/style/block-style-002-expected.txt:
layout-tests/editing/style/block-style-003-expected.txt:
layout-tests/editing/style/block-style-004-expected.txt:
layout-tests/editing/style/block-style-005-expected.txt:
layout-tests/editing/style/block-style-006-expected.txt:
layout-tests/editing/style/block-styles-007-expected.txt:
layout-tests/editing/style/create-block-for-style-001-expected.txt:
layout-tests/editing/style/create-block-for-style-002-expected.txt:
layout-tests/editing/style/create-block-for-style-003-expected.txt:
layout-tests/editing/style/create-block-for-style-004-expected.txt:
layout-tests/editing/style/create-block-for-style-005-expected.txt:
layout-tests/editing/style/create-block-for-style-006-expected.txt:
layout-tests/editing/style/create-block-for-style-007-expected.txt:
layout-tests/editing/style/create-block-for-style-008-expected.txt:
layout-tests/editing/style/create-block-for-style-009-expected.txt:
layout-tests/editing/style/create-block-for-style-010-expected.txt:
layout-tests/editing/style/create-block-for-style-011-expected.txt:
layout-tests/editing/style/create-block-for-style-012-expected.txt:
layout-tests/editing/style/create-block-for-style-013-expected.txt:
layout-tests/editing/style/relative-font-size-change-001-expected.txt:
layout-tests/editing/style/relative-font-size-change-002-expected.txt:
layout-tests/editing/style/relative-font-size-change-003-expected.txt:
layout-tests/editing/style/relative-font-size-change-004-expected.txt:
layout-tests/editing/style/remove-underline-across-paragraph-expected.txt:
layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
layout-tests/editing/style/remove-underline-after-paragraph-expected.txt:
layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
layout-tests/editing/style/remove-underline-expected.txt:
layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt:
layout-tests/editing/style/remove-underline-in-bold-expected.txt:
layout-tests/editing/style/smoosh-styles-001-expected.txt:
layout-tests/editing/style/smoosh-styles-002-expected.txt:
layout-tests/editing/style/smoosh-styles-003-expected.txt:
layout-tests/editing/style/style-3681552-fix-001-expected.txt:
layout-tests/editing/style/style-3681552-fix-002-expected.txt:
layout-tests/editing/style/style-3690704-fix-expected.txt:
layout-tests/editing/style/style-3998892-fix-expected.txt:
layout-tests/editing/style/style-boundary-001-expected.txt:
layout-tests/editing/style/style-boundary-002-expected.txt:
layout-tests/editing/style/style-boundary-003-expected.txt:
layout-tests/editing/style/style-boundary-004-expected.txt:
layout-tests/editing/style/typing-style-001-expected.txt:
layout-tests/editing/style/typing-style-002-expected.txt:
layout-tests/editing/style/typing-style-003-expected.txt:
layout-tests/editing/style/unbold-in-bold-expected.txt:
layout-tests/editing/style/underline-expected.txt:
layout-tests/editing/undo/redo-typing-001-expected.txt:
layout-tests/editing/undo/undo-typing-001-expected.txt:
layout-tests/editing/unsupported-content/list-delete-001-expected.txt:
layout-tests/editing/unsupported-content/list-delete-002-expected.txt:
layout-tests/editing/unsupported-content/list-delete-003-expected.txt:
layout-tests/editing/unsupported-content/list-type-after-expected.txt:
layout-tests/editing/unsupported-content/list-type-before-expected.txt:
layout-tests/editing/unsupported-content/table-delete-001-expected.txt:
layout-tests/editing/unsupported-content/table-delete-002-expected.txt:
layout-tests/editing/unsupported-content/table-delete-003-expected.txt:
layout-tests/editing/unsupported-content/table-type-after-expected.txt:
layout-tests/editing/unsupported-content/table-type-before-expected.txt:
layout-tests/fast/selectors/159-expected.txt:
layout-tests/fast/selectors/177a-expected.txt:

8:35 PM Changeset in webkit [10187] by darin

3 edits in trunk/WebKitTools

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4251 Ideally would be able to pass arguments to apps using run-safari and run-webkit-app scripts

Scripts/run-safari: Pass arguments through to Safari on command line.
Scripts/run-webkit-app: Pass arguments through to "open" tool on command line.

7:57 PM Changeset in webkit [10186] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4420 make border drawing faster by removing code to alloc/dealloc NSBezierPath

kwq/KWQPainter.h: Remove unused drawLineSegments, drawPolyline, and drawPolygon.
kwq/KWQPainter.mm: (QPainter::drawConvexPolygon): Move the body of _drawPoints into here, and remove the various unused code paths. Use CoreGraphics calls instead of NSBezierPath.

7:55 PM Changeset in webkit [10185] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed crash observed on one of the Apple-only layout tests

kjs/property_map.cpp: (KJS::PropertyMap::mark): Change code to understand that deleted entries have a value of NULL, so the deleted sentinel count doesn't need to be included in the count of things to mark since we're ignoring the keys.

5:58 PM Changeset in webkit [10184] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

1% speedup on HTML load speed iBench by avoiding icon database thrash http://bugzilla.opendarwin.org/show_bug.cgi?id=4423

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]): Be more aggressive about returning early, because updating the database does some expensive data structure copies.

5:32 PM Changeset in webkit [10183] by mjs

8 edits in trunk/WebCore

Reviewed by Darin.

apply a tasty candy shell of inlining and main_thread_malloc for a 1% speedup on HTML iBench http://bugzilla.opendarwin.org/show_bug.cgi?id=4425

kwq/KWQArrayImpl.h: (KWQArrayImpl::size):
kwq/KWQArrayImpl.mm:
kwq/KWQMapImpl.h:
kwq/KWQMapImpl.mm:
kwq/KWQRefPtr.h: (::KWQRefPtr): (::operator): (::ref): (::unref):
kwq/KWQValueListImpl.h: (KWQValueListIteratorImpl::KWQValueListIteratorImpl): (KWQValueListIteratorImpl::operator==): (KWQValueListIteratorImpl::operator!=): (KWQValueListIteratorImpl::node): (KWQValueListIteratorImpl::operator++): (KWQValueListIteratorImpl::operator--): (KWQValueListNodeImpl::KWQValueListNodeImpl):
kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::KWQValueListPrivate::~KWQValueListPrivate):

9:41 AM Changeset in webkit [10182] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4421 speed up JavaScript by inlining some label stack functions

kjs/internal.h: Removed the copy constructor and assignment operator for LabelStack. They were unused, and the implementations had bugs; I removed them rather than fixing them. Also removed the clear function, since that was only needed to help the assignment operator share code with the destructor, and was not efficient enough for the destructor. (KJS::LabelStack::~LabelStack): Made this inline. Also used an efficient implementation that's nice and fast when the stack is empty, better than the old clear() function which used to keep updating and refetching "tos" each time through the loop. (KJS::LabelStack::pop): Made this inline.

kjs/internal.cpp: Deleted the now-inline functions and the obsolete functions. Also deleted a commented-out line of code.

9:34 AM Changeset in webkit [10181] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4419 speed up JavaScript by improving KJS::List

my measurements show an improvement of 1% on iBench JavaScript

kjs/list.cpp: Rearrange list to make the values and free list share the same storage, which saves 4 bytes per list. Also remove the pointers used only on the heap from the lists that are in the pool, which saves 8 bytes per list. Moving the free list pointer closer to the start of the list object also speeds up access to the free list. New "HeapListImp" struct is used only for the lists on the heap. (KJS::List::markProtectedLists): Shadowed global variable in local and updated for the new terminology ("heap" instead of "outside pool"). (KJS::allocateListImp): Updated for new terminology. (KJS::List::release): Moved the code from deallocateListImp in here -- it wasn't being inlined and didn't need to be in a separate function.

9:27 AM Changeset in webkit [10180] by darin

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4417 speed up JavaScript with some small changes to the property map code

my measurements show an improvement of 2% on iBench JavaScript

kjs/property_map.h: (KJS::PropertyMap::PropertyMap): Made the default constructor inline.
kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): Changed loop to exit early once we know we've processed all the hash table entries, based on the count. (KJS::PropertyMap::mark): Ditto.

kjs/object.h: Made an arbitrary change here to force recompiling so we pick up changes to property_map.h. Works around what seems to be an Xcode header dependency bug.

9:17 AM Changeset in webkit [10179] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4416 speed up JavaScript with some improvements to the garbage collector

seems to give about 2% on iBench JavaScript

kjs/collector.cpp: (KJS::Collector::allocate): Use local variables to shadow globals instead of repeatedly going at global variables. Tighten up loop implementations to make the common case fast. (KJS::Collector::markStackObjectsConservatively): Use local variables to shadow globals. Used a goto to eliminate a boolean since it was showing up in the profile. (KJS::Collector::markProtectedObjects): Iterate through the table using pointer rather than an index since the profile showed that generating better code. (KJS::Collector::collect): Added a special case for blocks where all cells are used, Use local variables to shadow globals. Eliminated a boolean by computing it another way (checking to see if the number of live objects changed). Also used local variables to shadow fields in the current cell when sweeping. (KJS::Collector::numReferencedObjects): Use AllocatedValueImp instead of ValueImp in one place -- means we get faster versions of various functions that don't worry about SimpleNumber. (KJS::className): Ditto. (KJS::Collector::rootObjectClasses): Ditto.

9:04 AM Changeset in webkit [10178] by darin

7 edits in trunk/JavaScriptCore

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4344 REGRESSION: JavaScript crash when going back from viewing a thread (NULL protoype)

kjs/error_object.cpp: (NativeErrorImp::NativeErrorImp): Set proto in a more straightforward way. The old code set the proto to 0 and then to the correct value. This showed up as a "false positive" when searching for places that set prototype to NULL/0 so I fixed it.

kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): Change to not pass an explicit "0" to the base class (InternalFunctionImp) constructor.

kjs/internal.h: Added a default constructor for InternalFunctionImp.
kjs/internal.cpp: (KJS::InternalFunctionImp::InternalFunctionImp): Added the default constructor (empty body, just calls base class's default constructor).

kjs/object.h: (KJS::ObjectImp::ObjectImp): Add an assertion to catch NULL prototypes earlier in Development builds. (KJS::ObjectImp::setPrototype): Ditto.

2:12 AM Changeset in webkit [10177] by darin

11 edits in trunk

WebCore:

Reviewed and landed by Darin.

WebCore part of fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4011>:
"Editing delegate selection methods not called when using mouse"

Clicking on editable content would move the cursor or alter the selection without
calling the appropriate editing delegate method
(webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:). The
core of the patch is in the KHTMLPart::hadnleMousePressEvent* methods, the rest
is glue needed to drill through all the layers.

khtml/khtml_part.cpp:
khtml/khtml_part.cpp: (KHTMLPart::shouldChangeSelection): Glue to call editing delegate. (KHTMLPart::findTextNext): Call editing delegate before changing selection. (KHTMLPart::selectClosestWordFromMouseEvent): Ditto. (KHTMLPart::handleMousePressEventTripleClick): Ditto. (KHTMLPart::handleMousePressEventSingleClick): Ditto. (KHTMLPart::handleMouseMoveEventSelection): Ditto. (KHTMLPart::khtmlMouseReleaseEvent): Ditto. (KHTMLPart::selectAll): Ditto. (KHTMLPart::appliedEditing): Ditto. (KHTMLPart::unappliedEditing): Ditto. (KHTMLPart::reappliedEditing): Ditto. (KHTMLPart::selectFrameElementInParentIfFullySelected): Ditto.

khtml/khtml_part.h: Added shouldChangeSelection glue method.
kwq/KWQKHTMLPart.h: Ditto.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldChangeSelection): Glue to call editing delegate.

kwq/WebCoreBridge.h: Added shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: glue method.

WebKit:

Reviewed and landed by Darin.

WebKit part of fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4011>:
"Editing delegate selection methods not called when using mouse"

Clicking on editable content would move the cursor or alter the selection without
calling the appropriate editing delegate method
(webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:). The
core of the patch is in the KHTMLPart::handleMousePressEvent* methods, the rest
is glue needed to drill through all the layers.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): Bridge glue.

WebView.subproj/WebView.m: (-[WebView(WebViewEditingExtras) _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): Final step in glue, calling editing delegate.

WebView.subproj/WebViewInternal.h: Added _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting: private method to WebViewEditingExtras category.

1:47 AM Changeset in webkit [10176] by darin

2 edits
2 adds in trunk

Fixed by Alexey Proskuryakov <ap@nypop.com>.
Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3590 should allow <meta> tags for encoding even after </head>

Test cases added:

layout-tests/fast/encoding/mispositioned-meta-expected.txt: Added.
layout-tests/fast/encoding/mispositioned-meta.html: Added.

khtml/misc/decoder.cpp: (Decoder::decode): Don't stop scanning when seeing </head>.

1:28 AM Changeset in webkit [10175] by darin

8 edits in trunk

Reviewed and landed by Darin.

Test cases added:

layout-tests/dom/html/level2/events/dispatchEvent08-expected.txt:
layout-tests/dom/html/level2/events/dispatchEvent10-expected.txt:
layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt: These pass now.

layout-tests/dom/html/level2/events/dispatchEvent11-expected.txt:
layout-tests/dom/html/level2/events/dispatchEvent13-expected.txt: These fail someplace else now.

khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Check if the listener has a "handleEvent" function property and call that.

khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): A capturing event listener should not be triggered if an event is dispatched directly to the node to which the listener has been added.

1:18 AM Changeset in webkit [10174] by darin

3 edits in trunk

Reviewed and landed by Darin.

Test cases added:

layout-tests/dom/html/level2/core/hc_nodedocumentfragmentnormalize2-expected.txt: This passes now.

khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::normalize): If there's a single empty text child, remove it.

1:07 AM Changeset in webkit [10173] by darin

7 edits in trunk

Reviewed and landed by Darin.

Test cases added:

layout-tests/dom/html/level2/html/HTMLSelectElement20-expected.txt: This passes now.

khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLSelectCollection::put): Handle exceptions.

khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::add):
khtml/html/html_formimpl.h: Make ::add raise an exception if before isn't a descendant of the select element.

kwq/DOMHTML.mm: (-[DOMHTMLSelectElement add::]): Handle the exception.

Aug 13, 2005:

1:23 PM Changeset in webkit [10172]

328 copies
3 deletes in tags/Safari-416~1

This commit was manufactured by cvs2svn to create tag 'Safari-416~1'.

1:23 PM Changeset in webkit [10171] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This was a regression caused by the acid2 changes, so it needs to be on the branch too.

2005-05-30 Darin Adler <Darin Adler>

Reviewed by John.
Could not figure out how to make an <object> fallback, so for now, no layout test.

fixed <rdar://problem/4134124> REGRESSION (tip of tree): crash in QWidget::getView handling onunload event (yahoo.com)

khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::getObjectInstance): Check type of RenderObject to be sure it is a RenderWidget before calling widget() on it.

10:25 AM Changeset in webkit [10170] by adele

6 edits in branches/Safari-2-0-branch

Versioning for Safari-2-0-branch - Safari-416.1

10:13 AM Changeset in webkit [10169] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Rolled out fix since it doesn't work right on the branch
<rdar://problem/4202641> Line breaks do not happen inside whitespace:pre; word-wrap: break-word

khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

Aug 12, 2005:

4:20 PM Changeset in webkit [10168] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by John.

two simple speed improvements for a 3% speed gain

JavaScriptCore.xcodeproj/project.pbxproj: turn on -fstrict-aliasing

kjs/scope_chain.h: (KJS::ScopeChainIterator::ScopeChainIterator): Add a scope chain iterator so you can walk a scope chain without having to make a copy that you then mutate. (KJS::ScopeChainIterator::operator*): standard iterator operation (KJS::ScopeChainIterator::operator->): ditto (KJS::ScopeChainIterator::operator++): ditto (KJS::ScopeChainIterator::operator==): ditto (KJS::ScopeChainIterator::operator!=): ditto (KJS::ScopeChain::begin): Iterator for the top of the scope chain (KJS::ScopeChain::end): Iterator for one past the bottom (i.e. null)
kjs/nodes.cpp: (ResolveNode::evaluate): Use scope chain iterator instead of copying a scope chain and then modifying the copy (ResolveNode::evaluateReference): ditto (FunctionCallResolveNode::evaluate): ditto (AssignResolveNode::evaluate): ditto

4:02 PM Changeset in webkit [10167] by ggaren

1 delete in branches/pcre-6-1-branch/JavaScriptCore/pcre/pcre.c

removed old file: pcre.c

3:43 PM Changeset in webkit [10166] by ggaren

2 edits in trunk/WebCore

Reviewed by adele.

manual-tests/liveconnect-security-exception.html:
- fixed wrong codebase path
- added instruction to disable popup blocking

3:26 PM Changeset in webkit [10165] by darin

24 deletes in trunk/JavaScriptCore/pcre

remove files from TOT that should only have been on the branch

3:23 PM Changeset in webkit [10164]

6 copies
26 deletes in tags/pcre-6-1

This commit was manufactured by cvs2svn to create tag 'pcre-6-1'.

3:23 PM Changeset in webkit [10163] by darin

5 edits
4 deletes in branches/pcre-6-1-branch/JavaScriptCore/pcre

reapply changes I meant to do on the branch in the first place

3:18 PM Changeset in webkit [10162]

1 copy
21 deletes in branches/pcre-6-1-branch

This commit was manufactured by cvs2svn to create branch
'pcre-6-1-branch'.

3:18 PM Changeset in webkit [10161]

1 copy
21 deletes in tags/pcre-6-1-anchor

This commit was manufactured by cvs2svn to create tag
'pcre-6-1-anchor'.

3:18 PM Changeset in webkit [10160] by darin

5 edits
5 adds in trunk/JavaScriptCore/pcre

oops; roll back, this was supposed to be on a branch

3:13 PM Changeset in webkit [10159] by darin

5 edits
24 adds
5 deletes in trunk/JavaScriptCore/pcre

checking in PCRE 6.1 sources with no changes yet

3:03 PM Changeset in webkit [10158] by darin

1 delete in trunk/JavaScriptCore/pcre/pcregrep.c

another unneeded file

3:02 PM Changeset in webkit [10157] by darin

2 deletes in trunk/JavaScriptCore/pcre

more unneeded files

3:02 PM Changeset in webkit [10156] by darin

1 delete in trunk/JavaScriptCore/pcre/mkinstalldirs

removed another unneeded file

3:01 PM Changeset in webkit [10155] by darin

6 deletes in trunk/JavaScriptCore/pcre

remove some files -- we should remove them on TOT too later

12:58 PM Changeset in webkit [10154] by mjs

2 edits in trunk/JavaScriptCore

Patch from Anders Carlsson, reviewed by me.

kjs/nodes.h: Fix build breakage.

11:56 AM Changeset in webkit [10153] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Added a few more missing changes for acid2.

khtml/khtmlview.cpp: (KHTMLView::layout):
khtml/rendering/render_box.cpp: (RenderBox::setStyle):

11:25 AM Changeset in webkit [10152] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Added missing nil check from acid2 merge.

khtml/khtmlview.cpp: (KHTMLView::layout):

1:47 AM Changeset in webkit [10151] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fixes from TOT to Safari-2-0-branch
<rdar://problem/4213775> Several fixes in WebCore's bidi algorithm

1:36 AM Changeset in webkit [10150] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4214024> Several improvements to WebKit's ability to render international text

1:27 AM Changeset in webkit [10149] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4205174> Hebrew or Arabic text on long pages becomes garbled

12:36 AM Changeset in webkit [10148] by mjs

7 edits in trunk/JavaScriptCore

Reviewed by hyatt.

refactor function calls, 3% speedup on JS iBench.

kjs/grammar.y:
kjs/nodes.cpp: (Node::throwError): Added new useful variants. (FunctionCallValueNode::evaluate): New node to handle calls on expressions that are strictly values, not references. (FunctionCallValueNode::ref): ditto (FunctionCallValueNode::deref): ditto (FunctionCallResolveNode::evaluate): New node to handle calls on identifier expressions, so that they are looked up in the scope chain. (FunctionCallResolveNode::ref): ditto (FunctionCallResolveNode::deref): ditto (FunctionCallBracketNode::evaluate): New node to handle calls on bracket dereferences, so that the expression before brackets is used as the this object. (FunctionCallBracketNode::ref): ditto (FunctionCallBracketNode::deref): ditto (FunctionCallDotNode::evaluate): New node to handle calls on dot dereferences, so that the expression before the dot is used as the this object. (FunctionCallDotNode::ref): ditto (FunctionCallDotNode::deref): ditto (dotExprNotAnObjectString): helper function to avoid global variable access. (dotExprDoesNotAllowCallsString): ditto
kjs/nodes.h: Declared new classes.
kjs/nodes2string.cpp: (FunctionCallValueNode::streamTo): Added - serializes the appropriate function call (FunctionCallResolveNode::streamTo): ditto (FunctionCallBracketNode::streamTo): ditto (FunctionCallParenBracketNode::streamTo): ditto (FunctionCallDotNode::streamTo): ditto (FunctionCallParenDotNode::streamTo): ditto
kjs/object.h: (KJS::ObjectImp::isActivation): Change how activation objects are detected in the scope chain, a virtual function is cheaper than the old inheritance test.
kjs/function.h: (KJS::ActivationImp::isActivation): Ditto.

Aug 11, 2005:

6:53 PM Changeset in webkit [10147] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Beth Dakin <Beth Dakin>

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

6:35 PM Changeset in webkit [10146] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

kwq/KWQListBox.h: added setFont method
kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

6:30 PM Changeset in webkit [10145] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

kwq/KWQListBox.h: added setFont method
kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

4:10 PM Changeset in webkit [10144] by bdakin

2 edits in trunk/WebKit

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

2:37 PM Changeset in webkit [10143] by hyatt

2 edits
2 adds in trunk

Refine the baseline alignment rule for inline blocks to cover for a hole in the spec. The spec doesnt say what to do
for overflow cases, e.g., when the last line is clipped, when the overflow box is scrolled, or even when overflow is
visible but the last line is outside your content box. We just revert to the old behavior in those cases. Hopefully
the spec will be clarified to explain what the right behavior is.

Reviewed by beth

Test cases added: fast/inline-block/tricky-baseline.html

khtml/rendering/render_block.cpp: (khtml::RenderBlock::baselinePosition):

1:57 PM Changeset in webkit [10142] by mjs

1 edit
1 add in trunk/JavaScriptCore

added missing file from earlier checkin

kjs/grammar_types.h: Added. (KJS::makeNodePair): (KJS::makeNodeWithIdent):

11:58 AM Changeset in webkit [10141] by eseidel

4 edits in trunk/WebCore

Bug #: 4384
Submitted by: eseidel
Reviewed by: darin

WebCore+SVG/DrawView.mm: (-[DrawViewPrivate drawRect:]): added additional NULL check.
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): removed NSLog.
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): removed NSLog. Removed debugging logs, and fixed crasher for empty SVGs. http://bugzilla.opendarwin.org/show_bug.cgi?id=4384

10:40 AM Changeset in webkit [10140] by ggaren

2 edits in trunk

layout-tests/fast/js/date-big-setdate.html: fixed title

4:58 AM Changeset in webkit [10139] by eseidel

2 edits in trunk/WebKitTools

Bug #: 4385
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel

DrawTest/TestController.m: (-[TestController imagePathForSVGPath:]): Fixed support for using TextViewer with the layout-tests. http://bugzilla.opendarwin.org/show_bug.cgi?id=4385

4:35 AM Changeset in webkit [10138] by eseidel

903 edits in trunk

Bug #: 4382
Submitted by: eseidel

No review needed, copyright update in comments.
All kdom, ksvg2, and kcanvas files affected.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4382

3:57 AM Changeset in webkit [10137] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
tests/mozilla/expected.html: Updated for newly fixed test.

3:34 AM Changeset in webkit [10136] by mjs

2 edits in trunk/JavaScriptCore

updated for one of the tests that Darin incidentally fixed.

tests/mozilla/expected.html:

3:26 AM Changeset in webkit [10135] by mjs

8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Refactor assignment grammar to avoid Reference type, and to later
be able to take advantage of writeable PropertySlots, when those
are added. I also fixed a minor bug, turning a function to a
string lost parentheses, I made sure they are printed at least
where semantically significant.

Test cases: see WebCore

kjs/grammar.y: Change grammar so that assignment expressions are parsed directly to nodes that know how to set the kind of location being assigned, instead of having a generic assign node that counts on evaluateReference.
kjs/lexer.cpp: Include grammar_types.h.
kjs/nodes.cpp: (BracketAccessorNode): Renamed from AccessorNode1 for clarity. (DotAccessorNode): Renamed from AccessorNode2 for clarity. (combineForAssignment): Inline function for doing the proper kind of operation for various update assignments like += or *=. (AssignResolveNode): Node that handles assignment to a bare identifier. (AssignDotNode): Node that handles assignments of the form EXPR . IDENT = EXPR (AssignBracketNode): EXPR [ IDENT ] = EXPR
kjs/nodes.h: Updated for declarations/renames of new classes.
kjs/nodes2string.cpp: (GroupNode::streamTo): Fixed to print parens around the expression. (BracketAccessorNode::streamTo): Renamed. (DotAccessorNode::streamTo): Renamed. (AssignResolveNode::streamTo): Added. (AssignBracketNode::streamTo): Added. (AssignDotNode::streamTo): Added. (streamAssignmentOperatorTo): helper function for the above
kjs/property_slot.h: (KJS::PropertySlot::isSet): Made this const.

WebCore:

Reviewed by Geoff.

Test cases added:

layout-tests/fast/js/assign.html: Added. Test case for assignment to make sure I didn't break anything.
layout-tests/fast/js/code-serialize-paren.html: Added, test case for a minor bug I fixed where parens were not getting serialized at all when turning a function into a string.

2:39 AM Changeset in webkit [10134] by mjs

10 edits in trunk

WebCore:

At Least Rougly Glanced At by Anders.

fix change with totally breaks the layout tests.

Changed all the tests below to avoid dumping more than once -
since this now prints more than one separator, it totally throws
off the layout test driver so it needs to be avoided.

layout-tests/dom/html/level2/html/HTMLFormElement10-expected.txt:
layout-tests/dom/html/level2/html/HTMLFormElement10.html:
layout-tests/dom/html/level2/html/HTMLFormElement10.js:
layout-tests/fast/events/onunload-expected.txt:
layout-tests/fast/events/onunload.html:
layout-tests/fast/js/location-assign-expected.txt:
layout-tests/fast/js/location-assign.html:

WebKitTools:

At Least Rougly Glanced At by Anders.

fix change with totally breaks the layout tests.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Make tests unready if you start another load, to avoid dumping twice accidentally.

Aug 10, 2005:

8:38 PM Changeset in webkit [10133] by eseidel

2 edits in trunk/WebKitTools

Bug #: 3840
Submitted by: Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by: darin

DumpRenderTree/DumpRenderTree.m: Added support for rendering to a PNG file. http://bugzilla.opendarwin.org/show_bug.cgi?id=3840

6:39 PM Changeset in webkit [10132] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Changes made to WebSubresourceLoader.m need to be made on WebSubresourceClient.m, since the file was renamed on TOT.

WebCoreSupport.subproj/WebSubresourceClient.m:

6:28 PM Changeset in webkit [10131] by ggaren

1 edit
4 adds in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

6:01 PM Changeset in webkit [10130] by vicki

12 edits in trunk

Changes from Curt Arnold, reviewed by Vicki.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4174 (DOM layout tests involving two
documents fail due to test framework problem), and update expected results for tests
affected by this change.

layout-tests/dom/html/level1/core/hc_attrappendchild5-expected.txt:
layout-tests/dom/html/level1/core/hc_attrinsertbefore6-expected.txt:
layout-tests/dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
layout-tests/dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
layout-tests/dom/html/level1/core/hc_nodeappendchildnewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/hc_nodeinsertbeforenewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/hc_nodereplacechildnewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/selfhtml.js:
layout-tests/dom/html/level2/core/selfhtml.js:
layout-tests/dom/html/level2/events/selfhtml.js:
layout-tests/dom/html/level2/html/selfhtml.js:

5:42 PM Changeset in webkit [10129] by eseidel

1 edit
16 adds
8 deletes in trunk

Bug #: 4338
Submitted by: eseidel
Reviewed by: darin

svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/script-handle-03-b.svg: Added.
svg-tests/W3C-SVG-1.1/script-handle-03-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/script-handle-04-b.svg: Added.
svg-tests/W3C-SVG-1.1/script-handle-04-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg-disabled: Removed. Re-enabled previously crashing SVG test cases: http://bugzilla.opendarwin.org/show_bug.cgi?id=4338

5:28 PM Changeset in webkit [10128] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Vicki Murley <vicki@apple.com>

Reviewed by John.

attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

3:46 PM Changeset in webkit [10127] by vicki

2 edits in trunk/WebCore

Reviewed by John.

attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

2:55 PM Changeset in webkit [10126] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:14:56 +0000

2:55 PM Changeset in webkit [10125] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:00 +0000

2:55 PM Changeset in webkit [10124] by adele

6 edits in trunk

Bumping version to 420+

Info.plist:

2:54 PM Changeset in webkit [10123] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:09 +0000

2:41 PM Changeset in webkit [10122] by adele

5 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Geoffrey Garen <ggaren@apple.com>

-fixed <rdar://problem/4151132> REGRESSION: Some applet liveconnect calls
throws privilege exception.

Reviewed by richard and mjs.

-I removed the global static JavaClass cache, since it violated Java
security to cache classes between websites and applets.

bindings/jni/jni_class.cpp:

-removed global static cache dictionary
-instance constructor and destructor now do the work that used to
be done by static factory methods
-removed obsolete functions

(JavaClass::JavaClass):
(JavaClass::~JavaClass):

bindings/jni/jni_class.h:

-removed obsolete function declarations
-made copying private since it's unused and it's also not clear
excatly how copying would work with Java security
-made default construction private since it's meaningless

bindings/jni/jni_instance.cpp:

-removed obsolete functions

(JavaInstance::~JavaInstance):
(JavaInstance::getClass):

bindings/jni/jni_instance.h:

-made copying private since it's unused and it's also not clear

excatly how copying would work with Java security
-made default construction private since it's meaningless

1:51 PM Changeset in webkit [10121] by ggaren