Context Navigation

← Previous Period
Next Period →

Timeline

Sep 2, 2005:

3:56 PM Changeset in webkit [10452]

337 copies
33 deletes in tags/Safari-416~6

This commit was manufactured by cvs2svn to create tag 'Safari-416~6'.

3:56 PM Changeset in webkit [10451] by adele

6 edits in branches/Safari-2-0-branch

Versioning for Safari-2-0-branch - Safari-416.6

3:27 PM Changeset in webkit [10450] by adele

4 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Beth Dakin <Beth Dakin>

Fix for <rdar://problem/4235531> Regression: Safari crash in KWQStringData::makeUnicode
The other half of the fix is in WebCore.

Fix written by Maciej and Darin.
Reviewed by me/Maciej

As Maciej said in Radar: These problems was caused by a conflict between some of our custom
allocators, causing them to return null. Symptom is typically a null pointer dereference in
a place where it might be expected an allocation has just occurred.

kjs/fast_malloc.cpp: Added #define for MORECORE_CONTIGUOUS, MORECORE_CANNOT_TRIM,

and MALLOC_FAILURE_ACTION.

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Beth Dakin <Beth Dakin>

Fix for <rdar://problem/4235531> Denver Regression: Safari crash in KWQStringData::makeUnicode
The other half of the fix is in JavaScriptCore

Fix written by Maciej and Darin.
Reviewed by me/Maciej

As Maciej said in Radar: These problems was caused by a conflict between some of our custom
allocators, causing them to return null. Symptom is typically a null pointer dereference in
a place where it might be expected an allocation has just occurred.

khtml/misc/main_thread_malloc.cpp: Added #define for MORECORE_CONTIGUOUS, MORECORE_CANNOT_TRIM,

and MALLOC_FAILURE_ACTION.

3:14 PM Changeset in webkit [10449] by adele

9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Test cases updated: manual-tests/select_hr.html:
updated for case where selection is changed for a list box that has an <hr> in its list items, even though it doesn't appear in the list.

khtml/rendering/render_form.cpp: (RenderSelect::slotSelectionChanged): Added counter that increments only for visible list items (options and optgroups). Before this change, list boxes that had invisible <hr>s could have the visible selected option get out of sync from the selected state. (RenderSelect::updateSelection): ditto.
kwq/KWQListBox.h: Changed enum from ItemType to KWQListBoxItemType and values to KWQListBoxOption, KWQListBoxGroupLabel, and KWQListBoxSeparator. (KWQListBoxItem::KWQListBoxItem): ditto. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
kwq/KWQListBox.mm: (QListBox::appendItem): ditto. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
kwq/KWQComboBox.h: (QComboBox::appendItem): ditto. (QComboBox::appendGroupLabel): ditto. (QComboBox::appendSeparator): ditto.
kwq/KWQComboBox.mm: (QComboBox::setTitle): ditto. (QComboBox::appendItem): ditto. (QComboBox::sizeHint): ditto. (QComboBox::populateMenu): ditto.

2005-08-31 Adele Peterson <adele@apple.com>

Reviewed by Dave Hyatt.

fixed <rdar://problem/4229189> add a way to get a separator into a <select>

This will allow an <hr> within a select element to display a separator in a popup menu.
These extra elements are added to our listItems array, which we use internally. But this should not
affect JavaScript operations, such as getting an index of an option element, or getting the length of the select,
or getting the selected index. In these cases, the <hr>s will be ignored.

Test cases added:

manual-tests/select_hr.html: Added.

khtml/html/html_formimpl.h: (DOM::HTMLSelectElementImpl::listItems): Now that our listItems can also contain <hr>s, I've changed listItems to be a QMemArray<HTMLElementImpl*> instead of QMemArray<HTMLGenericFormElementImpl*> (DOM::HTMLOptGroupElementImpl::checkDTD): Added check for <hr>

khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::checkDTD): Added check for <hr> (DOM::HTMLSelectElementImpl::add): Added check for <hr> so these elements can be added through Javascript. (DOM::HTMLSelectElementImpl::recalcListItems): Added case for <hr> to add the element to the listItems array. (DOM::HTMLSelectElementImpl::selectedIndex): Updated type for array of listItems. (DOM::HTMLSelectElementImpl::setSelectedIndex): ditto. (DOM::HTMLSelectElementImpl::length): ditto. (DOM::HTMLSelectElementImpl::remove): ditto. (DOM::HTMLSelectElementImpl::value): ditto. (DOM::HTMLSelectElementImpl::setValue): ditto. (DOM::HTMLSelectElementImpl::state): ditto. (DOM::HTMLSelectElementImpl::restoreState): ditto. (DOM::HTMLSelectElementImpl::appendFormData): ditto. (DOM::HTMLSelectElementImpl::optionToListIndex): ditto. (DOM::HTMLSelectElementImpl::listToOptionIndex): ditto. (DOM::HTMLSelectElementImpl::reset): ditto. (DOM::HTMLSelectElementImpl::notifyOptionSelected): ditto. (DOM::HTMLOptionElementImpl::index): ditto.

khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): If the list item is an <hr>, and we're not using a ListBox, then we call appendSeparator on the widget. (RenderSelect::layout): Updated type for array of listItems. (RenderSelect::slotSelected): ditto. (RenderSelect::slotSelectionChanged): ditto. (RenderSelect::updateSelection): ditto.

kwq/KWQListBox.h: Added ItemType enum with the following values: Option, GroupLabel, and Separator. (KWQListBoxItem::KWQListBoxItem): Updated to use ItemType instead of old isGroupLabel bool. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.

kwq/KWQComboBox.h: (QComboBox::appendItem): the private version of appendItem used to take isLabel as a parameter. Now it takes an ItemType. (QComboBox::appendGroupLabel): calls appendItem with an ItemType of GroupLabel (QComboBox::appendSeparator): calls appendItem with an ItemType of Separator

kwq/KWQComboBox.mm: (QComboBox::setTitle): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::appendItem): If the new item is a Separator, then we add a separatorItem to the popup menu. (QComboBox::sizeHint): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::populateMenu): If the new item is a Separator, then we add a separatorItem to the popup menu.

kwq/KWQListBox.mm: (QListBox::appendItem): Updated to use the ItemType instead of the old isLabel bool. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.

2:34 PM Changeset in webkit [10448] by adele

7 edits in trunk/WebCore

Reviewed by Darin.

Test cases updated: manual-tests/select_hr.html:
updated for case where selection is changed for a list box that has an <hr> in its list items, even though it doesn't appear in the list.

khtml/rendering/render_form.cpp: (RenderSelect::slotSelectionChanged): Added counter that increments only for visible list items (options and optgroups). Before this change, list boxes that had invisible <hr>s could have the visible selected option get out of sync from the selected state. (RenderSelect::updateSelection): ditto.
kwq/KWQListBox.h: Changed enum from ItemType to KWQListBoxItemType and values to KWQListBoxOption, KWQListBoxGroupLabel, and KWQListBoxSeparator. (KWQListBoxItem::KWQListBoxItem): ditto. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
kwq/KWQListBox.mm: (QListBox::appendItem): ditto. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
kwq/KWQComboBox.h: (QComboBox::appendItem): ditto. (QComboBox::appendGroupLabel): ditto. (QComboBox::appendSeparator): ditto.
kwq/KWQComboBox.mm: (QComboBox::setTitle): ditto. (QComboBox::appendItem): ditto. (QComboBox::sizeHint): ditto. (QComboBox::populateMenu): ditto.

11:08 AM Changeset in webkit [10447] by bdakin

4 edits in trunk

* empty log message *

9:47 AM Changeset in webkit [10446] by darin

1 edit
2 adds
1 delete in trunk

added back a test now that Vicki fixed it so it no longer crashes

layout-tests/dom/html/level2/html/HTMLFrameElement09.html: Added.
layout-tests/dom/html/level2/html/HTMLFrameElement09-expected.txt: Added.
layout-tests/dom/html/level2/html/HTMLFrameElement09.html-disabled: Removed.

9:45 AM Changeset in webkit [10445] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4757 leaks found by code inspection in apply-style command

khtml/editing/apply_style_command.h: Change m_style to be a SharedPtr.
khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): Added use of SharedPtr. (khtml::StyleChange::currentlyHasStyle): Ditto. (khtml::ApplyStyleCommand::ApplyStyleCommand): Ditto. (khtml::ApplyStyleCommand::~ApplyStyleCommand): Ditto. (khtml::ApplyStyleCommand::doApply): Ditto. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. (khtml::hasTextDecorationProperty): Ditto. (khtml::ApplyStyleCommand::extractTextDecorationStyle): Ditto. (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): Ditto. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Ditto. (khtml::ApplyStyleCommand::removeInlineStyle): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::computedFontSize): Ditto.

4:15 AM Changeset in webkit [10444] by eseidel

12 edits
1 add in trunk

Bug #: 4799
Submitted by: eseidel
Reviewed by: mjs

ForwardingHeaders/q3ptrdict.h: Added.
kdom/cache/KDOMCacheHelper.h:
kdom/cache/KDOMCachedDocument.cpp: (CachedDocument::checkNotify): (CachedDocument::error):
kdom/cache/KDOMCachedImage.cpp: (CachedImage::do_notify): (CachedImage::movieStatus): (CachedImage::data): (CachedImage::error):
kdom/cache/KDOMCachedObject.h:
kdom/cache/KDOMCachedScript.cpp: (CachedScript::checkNotify):
kdom/cache/KDOMCachedStyleSheet.cpp: (CachedStyleSheet::checkNotify): (CachedStyleSheet::error):
kdom/cache/KDOMLoader.cpp: (DocumentLoader::setAutoloadImages): (DocumentLoader::setShowAnimations): (Loader::numRequests): (Loader::cancelRequests): (Loader::jobForRequest):
kdom/cache/KDOMLoader.h:
kdom/ecma/Ecma.cpp: (Ecma::createEventListener):
kdom/ecma/ScriptInterpreter.cpp: (ScriptInterpreter::mark):
kwq/KWQPtrDict.h: Re-ran scripts from previous commit, now including QPtrDict. http://bugzilla.opendarwin.org/show_bug.cgi?id=4799

3:03 AM Changeset in webkit [10443] by eseidel

101 edits
10 adds in trunk

Bug #: 4799
Submitted by: eseidel
Reviewed by: mjs

ForwardingHeaders/q3cstring.h: Added.
ForwardingHeaders/q3dict.h: Added.
ForwardingHeaders/q3intdict.h: Added.
ForwardingHeaders/q3memarray.h: Added.
ForwardingHeaders/q3paintdevicemetrics.h: Added.
ForwardingHeaders/q3ptrcollection.h: Added.
ForwardingHeaders/q3ptrlist.h: Added.
ForwardingHeaders/q3ptrstack.h: Added.
ForwardingHeaders/q3valuelist.h: Added.
ForwardingHeaders/q3valuevector.h: Added.
kcanvas/KCanvas.cpp: (KCanvas::setCanvasSize): (KCanvas::invalidate):
kcanvas/KCanvasFilters.h: (KCanvasFEColorMatrix::values): (KCanvasFEColorMatrix::setValues):
kcanvas/KCanvasItem.h:
kcanvas/KCanvasPath.h:
kcanvas/KCanvasRegistry.cpp: (operator<<):
kcanvas/KCanvasRegistry.h:
kcanvas/KCanvasResources.h:
kcanvas/KCanvasTreeDebug.h: (operator<<):
kcanvas/KCanvasTypes.h:
kcanvas/KCanvasView.cpp:
kcanvas/device/KRenderingDevice.h:
kcanvas/device/KRenderingDeviceFactory.cpp: (KRenderingDeviceFactory::request): (KRenderingDeviceFactory::deviceList):
kcanvas/device/KRenderingDeviceFactory.h:
kcanvas/device/KRenderingPaintServerGradient.cpp: (KCSortedGradientStopList::compareItems):
kcanvas/device/KRenderingPaintServerGradient.h:
kcanvas/device/KRenderingStyle.h:
kdom/KDOMSettings.cpp: (KDOMSettings::isAdFiltered):
kdom/cache/KDOMCache.cpp: (Cache::init): (Cache::hasPending): (Cache::statistics):
kdom/cache/KDOMCache.h:
kdom/cache/KDOMCacheHelper.h:
kdom/cache/KDOMLoader.cpp: (Loader::numRequests): (Loader::cancelRequests):
kdom/cache/KDOMLoader.h:
kdom/core/DOMList.h:
kdom/core/DocumentImpl.cpp: (DocumentImpl::getElementById): (DocumentImpl::setPaintDevice): (DocumentImpl::getId):
kdom/core/DocumentImpl.h: (KDOM::DocumentImpl::paintDeviceMetrics): (KDOM::DocumentImpl::IdNameMapping::~IdNameMapping):
kdom/core/NamedNodeMapImpl.cpp: (RONamedNodeMapImpl::RONamedNodeMapImpl): (RONamedNodeMapImpl::getNamedItem):
kdom/core/NamedNodeMapImpl.h:
kdom/core/NodeImpl.cpp: (NodeImpl::compareDocumentPosition):
kdom/core/TextImpl.cpp: (TextImpl::wholeText): (TextImpl::checkChildren): (TextImpl::replaceWholeText): (TextImpl::logicallyAdjacentTextNodes):
kdom/core/TextImpl.h:
kdom/css/CSSPrimitiveValueImpl.cpp: (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat):
kdom/css/CSSPrimitiveValueImpl.h:
kdom/css/CSSRuleListImpl.h:
kdom/css/CSSStyleDeclarationImpl.cpp: (CSSStyleDeclarationImpl::CSSStyleDeclarationImpl): (CSSStyleDeclarationImpl::operator=): (CSSStyleDeclarationImpl::cssText): (CSSStyleDeclarationImpl::setCssText): (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::getPropertyPriority): (CSSStyleDeclarationImpl::setProperty):
kdom/css/CSSStyleDeclarationImpl.h: (KDOM::CSSStyleDeclarationImpl::values):
kdom/css/CSSStyleRuleImpl.cpp: (CSSStyleRuleImpl::setSelector):
kdom/css/CSSStyleRuleImpl.h: (KDOM::CSSStyleRuleImpl::selector):
kdom/css/CSSStyleSelector.cpp: (CSSStyleSelector::CSSStyleSelector): (CSSStyleSelector::computeFontSizes): (CSSStyleSelector::computeFontSizesFor): (nextFontSize): (CSSStyleSelector::addInlineDeclarations): (CSSStyleSelector::buildLists): (CSSStyleSelectorList::CSSStyleSelectorList): (CSSStyleSelectorList::append): (CSSStyleSelectorList::collect): (CSSOrderedPropertyList::compareItems): (CSSOrderedPropertyList::append): (CSSStyleSelector::convertToLength): (CSSStyleSelector::applyRule):
kdom/css/CSSStyleSelector.h: (KDOM::CSSStyleSelector::fontSizes): (KDOM::CSSStyleSelector::fixedFontSizes):
kdom/css/CSSStyleSheetImpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl):
kdom/css/CSSValueListImpl.cpp: (CSSValueListImpl::cssText):
kdom/css/CSSValueListImpl.h:
kdom/css/Font.cpp: (Font::update):
kdom/css/Font.h:
kdom/css/KDOMCSSParser.cpp: (CSSParser::createStyleDeclaration): (CSSParser::createCSSStyleDeclaration):
kdom/css/KDOMCSSParser.h:
kdom/css/MediaListImpl.cpp: (MediaListImpl::mediaText): (MediaListImpl::deleteMedium):
kdom/css/MediaListImpl.h:
kdom/css/StyleBaseImpl.cpp: (StyleBaseImpl::setParsedValue):
kdom/css/StyleBaseImpl.h:
kdom/css/StyleSheetListImpl.cpp: (StyleSheetListImpl::~StyleSheetListImpl): (StyleSheetListImpl::length): (StyleSheetListImpl::item):
kdom/css/StyleSheetListImpl.h:
kdom/ecma/ScriptInterpreter.cpp: (ScriptInterpreter::forgetDOMObject):
kdom/events/EventTargetImpl.cpp: (EventTargetImpl::addEventListener): (EventTargetImpl::removeEventListener): (EventTargetImpl::dispatchEvent): (EventTargetImpl::handleLocalEvents):
kdom/events/EventTargetImpl.h:
kdom/ls/LSParserImpl.cpp: (LSParserImpl::parse):
kdom/parser/KDOMDocumentBuilder.cpp:
kdom/xpath/impl/expression.cpp: (Expression::~Expression): (Expression::optimize): (Expression::isConstant):
kdom/xpath/impl/expression.h:
kdom/xpath/impl/functions.cpp: (Function::setArguments): (FunctionLibrary::getFunction):
kdom/xpath/impl/functions.h:
kdom/xpath/impl/path.cpp: (Path::~Path): (Path::optimize): (Path::doEvaluate): (Path::dump):
kdom/xpath/impl/path.h:
kdom/xpath/impl/step.cpp: (Step::Step): (Step::~Step): (Step::evaluate): (Step::optimize): (Step::dump):
kdom/xpath/impl/step.h:
kdom/xpath/impl/tokenizer.cpp: (Tokenizer::isAxisName): (Tokenizer::isNodeTypeName):
kdom/xpath/impl/tokenizer.h:
kdom/xpath/impl/util.h:
kdom/xpath/impl/variablereference.cpp: (VariableReference::doEvaluate):
kdom/xpointer/impl/ElementSchemeImpl.cpp: (ElementSchemeImpl::evaluate):
kdom/xpointer/impl/ElementSchemeImpl.h:
kdom/xpointer/impl/XPointerEvaluatorImpl.cpp: (XPointerEvaluatorImpl::createXPointer):
kdom/xpointer/impl/XPointerExpressionImpl.cpp:
kdom/xpointer/impl/XPointerExpressionImpl.h:
ksvg2/KSVGFactory.cpp: (KSVGFactory::createPartObject): (KSVGFactory::registerPart):
ksvg2/KSVGFactory.h: (KSVG::KSVGFactory::partList):
ksvg2/css/KSVGCSSParser.cpp: (SVGCSSParser::createCSSStyleDeclaration):
ksvg2/css/KSVGCSSParser.h:
ksvg2/css/SVGCSSStyleDeclarationImpl.cpp: (SVGCSSStyleDeclarationImpl::SVGCSSStyleDeclarationImpl):
ksvg2/css/SVGCSSStyleDeclarationImpl.h:
ksvg2/css/SVGCSSStyleSelector.cpp: (SVGCSSStyleSelector::loadDefaultStyle): (SVGCSSStyleSelector::addExtraDeclarations):
ksvg2/css/SVGCSSStyleSelector.h:
ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateStroke): (KCanvasRenderingStyle::cssPrimitiveToLength):
ksvg2/misc/KSVGTimeScheduler.cpp: (SVGTimer::notifyAll):
ksvg2/misc/KSVGTimeScheduler.h:
ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::finishedParsing): (SVGDocumentImpl::recalcStyleSelector):
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::createCanvasItem):
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::pixelUnitToMillimeterX): (SVGSVGElementImpl::pixelUnitToMillimeterY):
kwq/KWQCString.h: Added #define q->q3.
kwq/KWQCollection.h:
kwq/KWQDict.h:
kwq/KWQIntDict.h:
kwq/KWQMemArray.h:
kwq/KWQPaintDeviceMetrics.h:
kwq/KWQPtrList.h:
kwq/KWQPtrStack.h:
kwq/KWQValueList.h:
kwq/KWQValueVector.h: Pulled over first section of Qt4 changes from kdom, mapping existing Qt3 classes to their new Qt4 names and adding necessary #defines to kwq to allow supporting both names. http://bugzilla.opendarwin.org/show_bug.cgi?id=4799

Sep 1, 2005:

5:19 PM Changeset in webkit [10442] by vicki

2 edits in trunk/WebCore

Reviewed by John.

Test cases added: No new tests, HTMLFrameElement09.html covers this crash

fixed <rdar://problem/4224088> crash in KWQKHTMLPart::handledOnloadEvents loading test HTMLFrameElement09.html

khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose): nil check on the part

5:02 PM Changeset in webkit [10441]

21 copies
3 deletes in tags/WebKit-312~5~1

This commit was manufactured by cvs2svn to create tag
'WebKit-312~5~1'.

5:02 PM Changeset in webkit [10440] by adele

2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.5.1

4:58 PM Changeset in webkit [10439] by adele

3 edits in branches/Safari-1-3-branch/WebKit

Merged fix for <rdar://problem/4208261> from TOT to Safari-1-3-branch

2005-05-17 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error

4:40 PM Changeset in webkit [10438] by darin

2 edits
2 adds in trunk

Reviewed by Maciej.

fixed <rdar://problem/3524912> repro crash in KHTMLParser::parseToken, due to parser's current element being destroyed (www.gnnetcom.dk)

Test cases added:

layout-tests/fast/parser/remove-parser-current-node.html: Added.
layout-tests/fast/parser/remove-parser-current-node-expected.txt: Added.

khtml/html/htmlparser.cpp: Changed block stack to hold a SharedPtr to the nodes in the stack -- needed because they might be destroyed by JavaScript. (HTMLParser::insertNode): Don't call attach() on the new node if the parent node isn't also attached. This happens when the parent node is no longer in the DOM tree because it was removed by JavaScript. (HTMLParser::popNestedHeaderTag): Updated since node is now a SharedPtr. (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Ditto. (HTMLParser::popOneBlock): Ditto.

12:41 PM Changeset in webkit [10437] by sullivan

2 edits in trunk/WebKitTools

Scripts/run-webkit-tests: Excluded a known system leak to reduce noise; added comments about which leaks are being excluded.

11:57 AM Changeset in webkit [10436] by eseidel

2 edits in trunk/WebCore

Bug #: 4790
Submitted by: eseidel
Reviewed by: sullivan

kwq/KWQSlot.mm: changed ksvg2/core to ksvg/misc Build fix: issed one include from previous change. http://bugzilla.opendarwin.org/show_bug.cgi?id=4790

11:51 AM Changeset in webkit [10435] by tomernic

2 edits in trunk/WebKitTools

Change made by Darin, reviewed by John and myself.

Allow semicolons at the end of method declarations (this is for method implementations; the semicolon is required for interface declarations).

Scripts/prepare-ChangeLog:

11:03 AM Changeset in webkit [10434] by harrison

10 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4054701> assertion failure in khtml::isEqualIgnoringAffinity using VoiceOver in new Mail message

Problem was that an AXTextMarker was erroneously given UPSTREAM affinity. Fixed by having the
VisiblePosition constructors make the actual affinity DOWNSTREAM if UPSTREAM was specified, but
the Position is not at a line wrap.

Test cases added:

There is no way to automate a test for this because it requires using the AX APIs, which are
not available to the tests.
A manual test involves creating an email and using VoiceOver on it. Seems like too much.

khtml/editing/selection.h:
khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::next):
khtml/editing/visible_position.h:
khtml/editing/visible_units.cpp: (khtml::nextBoundary): (khtml::endOfLine):
khtml/khtml_part.cpp: (KHTMLPart::findTextNext): (KHTMLPart::selectFrameElementInParentIfFullySelected):
khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling):
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]):

10:40 AM Changeset in webkit [10433] by adele

8 edits
1 add in trunk/WebCore

Reviewed by Dave Hyatt.

fixed <rdar://problem/4229189> add a way to get a separator into a <select>

This will allow an <hr> within a select element to display a separator in a popup menu.
These extra elements are added to our listItems array, which we use internally. But this should not
affect JavaScript operations, such as getting an index of an option element, or getting the length of the select,
or getting the selected index. In these cases, the <hr>s will be ignored.

Test cases added:

manual-tests/select_hr.html: Added.

khtml/html/html_formimpl.h: (DOM::HTMLSelectElementImpl::listItems): Now that our listItems can also contain <hr>s, I've changed listItems to be a QMemArray<HTMLElementImpl*> instead of QMemArray<HTMLGenericFormElementImpl*> (DOM::HTMLOptGroupElementImpl::checkDTD): Added check for <hr>

khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::checkDTD): Added check for <hr> (DOM::HTMLSelectElementImpl::add): Added check for <hr> so these elements can be added through Javascript. (DOM::HTMLSelectElementImpl::recalcListItems): Added case for <hr> to add the element to the listItems array. (DOM::HTMLSelectElementImpl::selectedIndex): Updated type for array of listItems. (DOM::HTMLSelectElementImpl::setSelectedIndex): ditto. (DOM::HTMLSelectElementImpl::length): ditto. (DOM::HTMLSelectElementImpl::remove): ditto. (DOM::HTMLSelectElementImpl::value): ditto. (DOM::HTMLSelectElementImpl::setValue): ditto. (DOM::HTMLSelectElementImpl::state): ditto. (DOM::HTMLSelectElementImpl::restoreState): ditto. (DOM::HTMLSelectElementImpl::appendFormData): ditto. (DOM::HTMLSelectElementImpl::optionToListIndex): ditto. (DOM::HTMLSelectElementImpl::listToOptionIndex): ditto. (DOM::HTMLSelectElementImpl::reset): ditto. (DOM::HTMLSelectElementImpl::notifyOptionSelected): ditto. (DOM::HTMLOptionElementImpl::index): ditto.

khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): If the list item is an <hr>, and we're not using a ListBox, then we call appendSeparator on the widget. (RenderSelect::layout): Updated type for array of listItems. (RenderSelect::slotSelected): ditto. (RenderSelect::slotSelectionChanged): ditto. (RenderSelect::updateSelection): ditto.

kwq/KWQListBox.h: Added ItemType enum with the following values: Option, GroupLabel, and Separator. (KWQListBoxItem::KWQListBoxItem): Updated to use ItemType instead of old isGroupLabel bool. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.

kwq/KWQComboBox.h: (QComboBox::appendItem): the private version of appendItem used to take isLabel as a parameter. Now it takes an ItemType. (QComboBox::appendGroupLabel): calls appendItem with an ItemType of GroupLabel (QComboBox::appendSeparator): calls appendItem with an ItemType of Separator

kwq/KWQComboBox.mm: (QComboBox::setTitle): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::appendItem): If the new item is a Separator, then we add a separatorItem to the popup menu. (QComboBox::sizeHint): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::populateMenu): If the new item is a Separator, then we add a separatorItem to the popup menu.

kwq/KWQListBox.mm: (QListBox::appendItem): Updated to use the ItemType instead of the old isLabel bool. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.

9:21 AM Changeset in webkit [10432] by darin

3 edits
1 add in trunk/WebCore

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4672 Incorrect highlight when selection begins with space and word-spacing>0

Test cases added:

manual-tests/word-spacing-highlight.html: Added.

khtml/rendering/render_text.h: (InlineTextBox::textObject): Made inline.
khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): Add word spacing in as necessary when computing the rect.

3:12 AM Changeset in webkit [10431] by eseidel

1 edit
5 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none

Removing unused files from SVG repository, no review requested.

ksvg2/dom/SVGAElement.cpp: Removed.
ksvg2/dom/SVGAElement.h: Removed.
ksvg2/dom/SVGAngle.cpp: Removed.
ksvg2/dom/SVGAngle.h: Removed.
ksvg2/dom/SVGAnimateColorElement.cpp: Removed.
ksvg2/dom/SVGAnimateColorElement.h: Removed.
ksvg2/dom/SVGAnimateElement.cpp: Removed.
ksvg2/dom/SVGAnimateElement.h: Removed.
ksvg2/dom/SVGAnimateTransformElement.cpp: Removed.
ksvg2/dom/SVGAnimateTransformElement.h: Removed.
ksvg2/dom/SVGAnimatedAngle.cpp: Removed.
ksvg2/dom/SVGAnimatedAngle.h: Removed.
ksvg2/dom/SVGAnimatedBoolean.cpp: Removed.
ksvg2/dom/SVGAnimatedBoolean.h: Removed.
ksvg2/dom/SVGAnimatedEnumeration.cpp: Removed.
ksvg2/dom/SVGAnimatedEnumeration.h: Removed.
ksvg2/dom/SVGAnimatedInteger.cpp: Removed.
ksvg2/dom/SVGAnimatedInteger.h: Removed.
ksvg2/dom/SVGAnimatedLength.cpp: Removed.
ksvg2/dom/SVGAnimatedLength.h: Removed.
ksvg2/dom/SVGAnimatedLengthList.cpp: Removed.
ksvg2/dom/SVGAnimatedLengthList.h: Removed.
ksvg2/dom/SVGAnimatedNumber.cpp: Removed.
ksvg2/dom/SVGAnimatedNumber.h: Removed.
ksvg2/dom/SVGAnimatedNumberList.cpp: Removed.
ksvg2/dom/SVGAnimatedNumberList.h: Removed.
ksvg2/dom/SVGAnimatedPathData.cpp: Removed.
ksvg2/dom/SVGAnimatedPathData.h: Removed.
ksvg2/dom/SVGAnimatedPoints.cpp: Removed.
ksvg2/dom/SVGAnimatedPoints.h: Removed.
ksvg2/dom/SVGAnimatedPreserveAspectRatio.cpp: Removed.
ksvg2/dom/SVGAnimatedPreserveAspectRatio.h: Removed.
ksvg2/dom/SVGAnimatedRect.cpp: Removed.
ksvg2/dom/SVGAnimatedRect.h: Removed.
ksvg2/dom/SVGAnimatedString.cpp: Removed.
ksvg2/dom/SVGAnimatedString.h: Removed.
ksvg2/dom/SVGAnimatedTransformList.cpp: Removed.
ksvg2/dom/SVGAnimatedTransformList.h: Removed.
ksvg2/dom/SVGAnimationElement.cpp: Removed.
ksvg2/dom/SVGAnimationElement.h: Removed.
ksvg2/dom/SVGCircleElement.cpp: Removed.
ksvg2/dom/SVGCircleElement.h: Removed.
ksvg2/dom/SVGClipPathElement.cpp: Removed.
ksvg2/dom/SVGClipPathElement.h: Removed.
ksvg2/dom/SVGColor.cpp: Removed.
ksvg2/dom/SVGColor.h: Removed.
ksvg2/dom/SVGComponentTransferFunctionElement.cpp: Removed.
ksvg2/dom/SVGComponentTransferFunctionElement.h: Removed.
ksvg2/dom/SVGDOMImplementation.cpp: Removed.
ksvg2/dom/SVGDOMImplementation.h: Removed.
ksvg2/dom/SVGDefsElement.cpp: Removed.
ksvg2/dom/SVGDefsElement.h: Removed.
ksvg2/dom/SVGDescElement.cpp: Removed.
ksvg2/dom/SVGDescElement.h: Removed.
ksvg2/dom/SVGDocument.cpp: Removed.
ksvg2/dom/SVGDocument.h: Removed.
ksvg2/dom/SVGElement.cpp: Removed.
ksvg2/dom/SVGElement.h: Removed.
ksvg2/dom/SVGElementInstance.cpp: Removed.
ksvg2/dom/SVGElementInstance.h: Removed.
ksvg2/dom/SVGElementInstanceList.cpp: Removed.
ksvg2/dom/SVGElementInstanceList.h: Removed.
ksvg2/dom/SVGEllipseElement.cpp: Removed.
ksvg2/dom/SVGEllipseElement.h: Removed.
ksvg2/dom/SVGException.cpp: Removed.
ksvg2/dom/SVGException.h: Removed.
ksvg2/dom/SVGExternalResourcesRequired.cpp: Removed.
ksvg2/dom/SVGExternalResourcesRequired.h: Removed.
ksvg2/dom/SVGFEBlendElement.cpp: Removed.
ksvg2/dom/SVGFEBlendElement.h: Removed.
ksvg2/dom/SVGFEColorMatrixElement.cpp: Removed.
ksvg2/dom/SVGFEColorMatrixElement.h: Removed.
ksvg2/dom/SVGFEComponentTransferElement.cpp: Removed.
ksvg2/dom/SVGFEComponentTransferElement.h: Removed.
ksvg2/dom/SVGFECompositeElement.cpp: Removed.
ksvg2/dom/SVGFECompositeElement.h: Removed.
ksvg2/dom/SVGFEFloodElement.cpp: Removed.
ksvg2/dom/SVGFEFloodElement.h: Removed.
ksvg2/dom/SVGFEFuncAElement.cpp: Removed.
ksvg2/dom/SVGFEFuncAElement.h: Removed.
ksvg2/dom/SVGFEFuncBElement.cpp: Removed.
ksvg2/dom/SVGFEFuncBElement.h: Removed.
ksvg2/dom/SVGFEFuncGElement.cpp: Removed.
ksvg2/dom/SVGFEFuncGElement.h: Removed.
ksvg2/dom/SVGFEFuncRElement.cpp: Removed.
ksvg2/dom/SVGFEFuncRElement.h: Removed.
ksvg2/dom/SVGFEGaussianBlurElement.cpp: Removed.
ksvg2/dom/SVGFEGaussianBlurElement.h: Removed.
ksvg2/dom/SVGFEImageElement.cpp: Removed.
ksvg2/dom/SVGFEImageElement.h: Removed.
ksvg2/dom/SVGFEMergeElement.cpp: Removed.
ksvg2/dom/SVGFEMergeElement.h: Removed.
ksvg2/dom/SVGFEMergeNodeElement.cpp: Removed.
ksvg2/dom/SVGFEMergeNodeElement.h: Removed.
ksvg2/dom/SVGFEOffsetElement.cpp: Removed.
ksvg2/dom/SVGFEOffsetElement.h: Removed.
ksvg2/dom/SVGFETileElement.cpp: Removed.
ksvg2/dom/SVGFETileElement.h: Removed.
ksvg2/dom/SVGFETurbulenceElement.cpp: Removed.
ksvg2/dom/SVGFETurbulenceElement.h: Removed.
ksvg2/dom/SVGFilterElement.cpp: Removed.
ksvg2/dom/SVGFilterElement.h: Removed.
ksvg2/dom/SVGFilterPrimitiveStandardAttributes.cpp: Removed.
ksvg2/dom/SVGFilterPrimitiveStandardAttributes.h: Removed.
ksvg2/dom/SVGFitToViewBox.cpp: Removed.
ksvg2/dom/SVGFitToViewBox.h: Removed.
ksvg2/dom/SVGGElement.cpp: Removed.
ksvg2/dom/SVGGElement.h: Removed.
ksvg2/dom/SVGGradientElement.cpp: Removed.
ksvg2/dom/SVGGradientElement.h: Removed.
ksvg2/dom/SVGImageElement.cpp: Removed.
ksvg2/dom/SVGImageElement.h: Removed.
ksvg2/dom/SVGLangSpace.cpp: Removed.
ksvg2/dom/SVGLangSpace.h: Removed.
ksvg2/dom/SVGLength.cpp: Removed.
ksvg2/dom/SVGLength.h: Removed.
ksvg2/dom/SVGLengthList.cpp: Removed.
ksvg2/dom/SVGLengthList.h: Removed.
ksvg2/dom/SVGLineElement.cpp: Removed.
ksvg2/dom/SVGLineElement.h: Removed.
ksvg2/dom/SVGLinearGradientElement.cpp: Removed.
ksvg2/dom/SVGLinearGradientElement.h: Removed.
ksvg2/dom/SVGLocatable.cpp: Removed.
ksvg2/dom/SVGLocatable.h: Removed.
ksvg2/dom/SVGMarkerElement.cpp: Removed.
ksvg2/dom/SVGMarkerElement.h: Removed.
ksvg2/dom/SVGMatrix.cpp: Removed.
ksvg2/dom/SVGMatrix.h: Removed.
ksvg2/dom/SVGNumber.cpp: Removed.
ksvg2/dom/SVGNumber.h: Removed.
ksvg2/dom/SVGNumberList.cpp: Removed.
ksvg2/dom/SVGNumberList.h: Removed.
ksvg2/dom/SVGPaint.cpp: Removed.
ksvg2/dom/SVGPaint.h: Removed.
ksvg2/dom/SVGPathElement.cpp: Removed.
ksvg2/dom/SVGPathElement.h: Removed.
ksvg2/dom/SVGPathSeg.cpp: Removed.
ksvg2/dom/SVGPathSeg.h: Removed.
ksvg2/dom/SVGPathSegArc.cpp: Removed.
ksvg2/dom/SVGPathSegArc.h: Removed.
ksvg2/dom/SVGPathSegClosePath.cpp: Removed.
ksvg2/dom/SVGPathSegClosePath.h: Removed.
ksvg2/dom/SVGPathSegCurvetoCubic.cpp: Removed.
ksvg2/dom/SVGPathSegCurvetoCubic.h: Removed.
ksvg2/dom/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
ksvg2/dom/SVGPathSegCurvetoCubicSmooth.h: Removed.
ksvg2/dom/SVGPathSegCurvetoQuadratic.cpp: Removed.
ksvg2/dom/SVGPathSegCurvetoQuadratic.h: Removed.
ksvg2/dom/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
ksvg2/dom/SVGPathSegCurvetoQuadraticSmooth.h: Removed.
ksvg2/dom/SVGPathSegLineto.cpp: Removed.
ksvg2/dom/SVGPathSegLineto.h: Removed.
ksvg2/dom/SVGPathSegLinetoHorizontal.cpp: Removed.
ksvg2/dom/SVGPathSegLinetoHorizontal.h: Removed.
ksvg2/dom/SVGPathSegLinetoVertical.cpp: Removed.
ksvg2/dom/SVGPathSegLinetoVertical.h: Removed.
ksvg2/dom/SVGPathSegList.cpp: Removed.
ksvg2/dom/SVGPathSegList.h: Removed.
ksvg2/dom/SVGPathSegMoveto.cpp: Removed.
ksvg2/dom/SVGPathSegMoveto.h: Removed.
ksvg2/dom/SVGPatternElement.cpp: Removed.
ksvg2/dom/SVGPatternElement.h: Removed.
ksvg2/dom/SVGPoint.cpp: Removed.
ksvg2/dom/SVGPoint.h: Removed.
ksvg2/dom/SVGPointList.cpp: Removed.
ksvg2/dom/SVGPointList.h: Removed.
ksvg2/dom/SVGPolygonElement.cpp: Removed.
ksvg2/dom/SVGPolygonElement.h: Removed.
ksvg2/dom/SVGPolylineElement.cpp: Removed.
ksvg2/dom/SVGPolylineElement.h: Removed.
ksvg2/dom/SVGPreserveAspectRatio.cpp: Removed.
ksvg2/dom/SVGPreserveAspectRatio.h: Removed.
ksvg2/dom/SVGRadialGradientElement.cpp: Removed.
ksvg2/dom/SVGRadialGradientElement.h: Removed.
ksvg2/dom/SVGRect.cpp: Removed.
ksvg2/dom/SVGRect.h: Removed.
ksvg2/dom/SVGRectElement.cpp: Removed.
ksvg2/dom/SVGRectElement.h: Removed.
ksvg2/dom/SVGSVGElement.cpp: Removed.
ksvg2/dom/SVGSVGElement.h: Removed.
ksvg2/dom/SVGScriptElement.cpp: Removed.
ksvg2/dom/SVGScriptElement.h: Removed.
ksvg2/dom/SVGSetElement.cpp: Removed.
ksvg2/dom/SVGSetElement.h: Removed.
ksvg2/dom/SVGStopElement.cpp: Removed.
ksvg2/dom/SVGStopElement.h: Removed.
ksvg2/dom/SVGStringList.cpp: Removed.
ksvg2/dom/SVGStringList.h: Removed.
ksvg2/dom/SVGStylable.cpp: Removed.
ksvg2/dom/SVGStylable.h: Removed.
ksvg2/dom/SVGStyleElement.cpp: Removed.
ksvg2/dom/SVGStyleElement.h: Removed.
ksvg2/dom/SVGSwitchElement.cpp: Removed.
ksvg2/dom/SVGSwitchElement.h: Removed.
ksvg2/dom/SVGSymbolElement.cpp: Removed.
ksvg2/dom/SVGSymbolElement.h: Removed.
ksvg2/dom/SVGTSpanElement.cpp: Removed.
ksvg2/dom/SVGTSpanElement.h: Removed.
ksvg2/dom/SVGTests.cpp: Removed.
ksvg2/dom/SVGTests.h: Removed.
ksvg2/dom/SVGTextContentElement.cpp: Removed.
ksvg2/dom/SVGTextContentElement.h: Removed.
ksvg2/dom/SVGTextElement.cpp: Removed.
ksvg2/dom/SVGTextElement.h: Removed.
ksvg2/dom/SVGTextPositioningElement.cpp: Removed.
ksvg2/dom/SVGTextPositioningElement.h: Removed.
ksvg2/dom/SVGTitleElement.cpp: Removed.
ksvg2/dom/SVGTitleElement.h: Removed.
ksvg2/dom/SVGTransform.cpp: Removed.
ksvg2/dom/SVGTransform.h: Removed.
ksvg2/dom/SVGTransformList.cpp: Removed.
ksvg2/dom/SVGTransformList.h: Removed.
ksvg2/dom/SVGTransformable.cpp: Removed.
ksvg2/dom/SVGTransformable.h: Removed.
ksvg2/dom/SVGURIReference.cpp: Removed.
ksvg2/dom/SVGURIReference.h: Removed.
ksvg2/dom/SVGUseElement.cpp: Removed.
ksvg2/dom/SVGUseElement.h: Removed.
ksvg2/dom/SVGViewElement.cpp: Removed.
ksvg2/dom/SVGViewElement.h: Removed.
ksvg2/dom/SVGZoomAndPan.cpp: Removed.
ksvg2/dom/SVGZoomAndPan.h: Removed.
ksvg2/events/SVGEvent.cpp: Removed.
ksvg2/events/SVGEvent.h: Removed.
ksvg2/events/SVGZoomEvent.cpp: Removed.
ksvg2/events/SVGZoomEvent.h: Removed.

2:39 AM Changeset in webkit [10430] by eseidel

158 edits in trunk

Bug #: 4790
Submitted by: eseidel
Reviewed by: mjs

WebCore+SVG/DrawCanvasItem.mm: header include changes.
WebCore+SVG/DrawDocument.mm:
WebCore.xcodeproj/project.pbxproj:
kcanvas/KCanvasTreeDebug.cpp:
kdom/cache/KDOMLoader.cpp:
kdom/core/AttrImpl.h:
kdom/core/CDATASectionImpl.h:
kdom/core/CDFInterface.cpp:
kdom/core/CDFInterface.h:
kdom/core/CharacterDataImpl.h:
kdom/core/CommentImpl.h:
kdom/core/DOMConfigurationImpl.h:
kdom/core/DOMImplementationImpl.cpp:
kdom/core/DocumentFragmentImpl.h:
kdom/core/DocumentImpl.cpp:
kdom/core/DocumentImpl.h:
kdom/core/DocumentTypeImpl.h:
kdom/core/ElementImpl.h:
kdom/core/EntityImpl.h:
kdom/core/EntityReferenceImpl.h:
kdom/core/NamedAttrMapImpl.h:
kdom/core/NamedNodeMapImpl.h:
kdom/core/NodeImpl.h:
kdom/core/NotationImpl.h:
kdom/core/ProcessingInstructionImpl.h:
kdom/core/TagNodeListImpl.h:
kdom/core/TextImpl.h:
kdom/core/XMLElementImpl.h:
kdom/css/CSSCharsetRuleImpl.h:
kdom/css/CSSFontFaceRuleImpl.h:
kdom/css/CSSHelper.h:
kdom/css/CSSImageValueImpl.cpp:
kdom/css/CSSImageValueImpl.h:
kdom/css/CSSImportRuleImpl.h:
kdom/css/CSSMediaRuleImpl.h:
kdom/css/CSSPageRuleImpl.h:
kdom/css/CSSPrimitiveValueImpl.cpp:
kdom/css/CSSPrimitiveValueImpl.h:
kdom/css/CSSRuleImpl.h:
kdom/css/CSSStyleDeclarationImpl.cpp:
kdom/css/CSSStyleDeclarationImpl.h:
kdom/css/CSSStyleRuleImpl.h:
kdom/css/CSSStyleSelector.cpp:
kdom/css/CSSStyleSelector.h:
kdom/css/CSSStyleSheetImpl.h:
kdom/css/CSSUnknownRuleImpl.h:
kdom/css/CSSValueImpl.h:
kdom/css/CSSValueListImpl.h:
kdom/css/DocumentCSSImpl.h:
kdom/css/KDOMCSSParser.cpp:
kdom/css/KDOMCSSParser.h:
kdom/css/MediaListImpl.h:
kdom/css/RenderStyle.h:
kdom/css/RenderStyleDefs.h:
kdom/css/StyleBaseImpl.cpp:
kdom/css/StyleBaseImpl.h:
kdom/css/StyleSheetImpl.h:
kdom/css/kdomparsercss.y:
kdom/events/EventListenerImpl.h:
kdom/events/KeyboardEventImpl.h:
kdom/events/MouseEventImpl.h:
kdom/events/MutationEventImpl.h:
kdom/events/UIEventImpl.h:
kdom/ls/LSParserImpl.h:
kdom/ls/LSSerializerFilterImpl.h:
kdom/parser/KDOMParser.h:
kdom/range/DocumentRangeImpl.cpp:
kdom/traversal/NodeIteratorImpl.h:
kdom/traversal/TreeWalkerImpl.h:
kdom/xpath/XPathNamespaceImpl.h:
ksvg2/css/KSVGCSSParser.cpp:
ksvg2/css/KSVGCSSParser.h:
ksvg2/css/SVGCSSStyleDeclarationImpl.cpp:
ksvg2/css/SVGCSSStyleDeclarationImpl.h:
ksvg2/css/SVGCSSStyleSelector.cpp:
ksvg2/css/SVGCSSStyleSelector.h:
ksvg2/css/SVGCSSStyleSheetImpl.h:
ksvg2/css/SVGRenderStyle.h:
ksvg2/ecma/Ecma.cpp:
ksvg2/ecma/GlobalObject.cpp:
ksvg2/events/SVGEvent.cpp:
ksvg2/events/SVGEventImpl.h:
ksvg2/events/SVGZoomEvent.cpp:
ksvg2/events/SVGZoomEventImpl.h:
ksvg2/misc/KCanvasRenderingStyle.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/svg/CDFInterface.cpp:
ksvg2/svg/CDFInterface.h:
ksvg2/svg/SVGAElementImpl.cpp:
ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGCircleElementImpl.cpp:
ksvg2/svg/SVGClipPathElementImpl.cpp:
ksvg2/svg/SVGColorImpl.cpp:
ksvg2/svg/SVGColorImpl.h:
ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.h:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGElementImpl.h:
ksvg2/svg/SVGElementInstanceImpl.h:
ksvg2/svg/SVGEllipseElementImpl.cpp:
ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp:
ksvg2/svg/SVGFEBlendElementImpl.cpp:
ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
ksvg2/svg/SVGFECompositeElementImpl.cpp:
ksvg2/svg/SVGFEFloodElementImpl.cpp:
ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
ksvg2/svg/SVGFEImageElementImpl.cpp:
ksvg2/svg/SVGFEMergeElementImpl.cpp:
ksvg2/svg/SVGFEMergeNodeElementImpl.cpp:
ksvg2/svg/SVGFEOffsetElementImpl.cpp:
ksvg2/svg/SVGFETileElementImpl.cpp:
ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
ksvg2/svg/SVGFilterElementImpl.cpp:
ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
ksvg2/svg/SVGFitToViewBoxImpl.cpp:
ksvg2/svg/SVGGradientElementImpl.cpp:
ksvg2/svg/SVGImageElementImpl.cpp:
ksvg2/svg/SVGLangSpaceImpl.cpp:
ksvg2/svg/SVGLengthImpl.h:
ksvg2/svg/SVGLineElementImpl.cpp:
ksvg2/svg/SVGLinearGradientElementImpl.cpp:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGMarkerElementImpl.cpp:
ksvg2/svg/SVGPathElementImpl.cpp:
ksvg2/svg/SVGPathSegClosePathImpl.h:
ksvg2/svg/SVGPathSegImpl.h:
ksvg2/svg/SVGPathSegLinetoHorizontalImpl.h:
ksvg2/svg/SVGPathSegLinetoImpl.h:
ksvg2/svg/SVGPathSegLinetoVerticalImpl.h:
ksvg2/svg/SVGPathSegMovetoImpl.h:
ksvg2/svg/SVGPatternElementImpl.cpp:
ksvg2/svg/SVGPolyElementImpl.cpp:
ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
ksvg2/svg/SVGRadialGradientElementImpl.cpp:
ksvg2/svg/SVGRectElementImpl.cpp:
ksvg2/svg/SVGSVGElementImpl.cpp:
ksvg2/svg/SVGSVGElementImpl.h:
ksvg2/svg/SVGScriptElementImpl.cpp:
ksvg2/svg/SVGStopElementImpl.cpp:
ksvg2/svg/SVGStringListImpl.h:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyledElementImpl.cpp:
ksvg2/svg/SVGStyledElementImpl.h:
ksvg2/svg/SVGSwitchElementImpl.cpp:
ksvg2/svg/SVGTestsImpl.cpp:
ksvg2/svg/SVGTextContentElementImpl.cpp:
ksvg2/svg/SVGTextPositioningElementImpl.cpp:
ksvg2/svg/SVGTransformableImpl.cpp:
ksvg2/svg/SVGURIReferenceImpl.cpp:
ksvg2/svg/SVGUseElementImpl.cpp:
ksvg2/svg/SVGViewElementImpl.cpp:
ksvg2/svg/SVGZoomAndPanImpl.cpp: I renamed: kdom/impl -> kdom/core kdom/css/impl/* -> kdom/css/* kdom/css/impl/* -> kdom/css/* kdom/ls/impl/* -> kdom/ls/* kdom/events/impl/* -> kdom/events/* kdom/range/impl/* -> kdom/range/* kdom/traversal/impl/* -> kdom/traversal/* ksvg2/core -> ksvg2/misc kdom/impl -> kdom/svg ksvg2/css/impl/* -> ksvg2/css/* ksvg2/events/impl/* -> ksvg2/events/* And made all the necessary header include and project file changes. This now brings our source tree fully up-to-date with all the recent kdom/ksvg2 file re-orgs (which were done per our request). http://bugzilla.opendarwin.org/show_bug.cgi?id=4790

12:35 AM Changeset in webkit [10429] by eseidel

834 edits in trunk

Bug #: 4752
Submitted by: eseidel
Reviewed by: mjs

Replaced tabs with spaces throughout all of SVGSupport, excepting
kdom/xpath upon specific request of the kdom/xpath maintainer.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4752

Aug 31, 2005:

11:42 PM Changeset in webkit [10428] by mjs

2 edits in trunk/WebKitTools

Reviewed by Darin.

set color variant and font settings to a consistent value. (http://bugzilla.opendarwin.org/show_bug.cgi?id=4769)

DumpRenderTree/DumpRenderTree.m: (main):

11:13 PM Changeset in webkit [10427] by mjs

331 edits in trunk

update test results for Mitz's recent border AA change

layout-tests/css1/basic/class_as_selector-expected.checksum:
layout-tests/css1/basic/class_as_selector-expected.png:
layout-tests/css1/basic/comments-expected.checksum:
layout-tests/css1/basic/comments-expected.png:
layout-tests/css1/basic/containment-expected.checksum:
layout-tests/css1/basic/containment-expected.png:
layout-tests/css1/basic/contextual_selectors-expected.checksum:
layout-tests/css1/basic/contextual_selectors-expected.png:
layout-tests/css1/basic/grouping-expected.checksum:
layout-tests/css1/basic/grouping-expected.png:
layout-tests/css1/basic/id_as_selector-expected.checksum:
layout-tests/css1/basic/id_as_selector-expected.png:
layout-tests/css1/basic/inheritance-expected.checksum:
layout-tests/css1/basic/inheritance-expected.png:
layout-tests/css1/box_properties/border-expected.checksum:
layout-tests/css1/box_properties/border-expected.png:
layout-tests/css1/box_properties/border_bottom-expected.checksum:
layout-tests/css1/box_properties/border_bottom-expected.png:
layout-tests/css1/box_properties/border_bottom_inline-expected.checksum:
layout-tests/css1/box_properties/border_bottom_inline-expected.png:
layout-tests/css1/box_properties/border_bottom_width-expected.checksum:
layout-tests/css1/box_properties/border_bottom_width-expected.png:
layout-tests/css1/box_properties/border_bottom_width_inline-expected.checksum:
layout-tests/css1/box_properties/border_bottom_width_inline-expected.png:
layout-tests/css1/box_properties/border_color-expected.checksum:
layout-tests/css1/box_properties/border_color-expected.png:
layout-tests/css1/box_properties/border_color_inline-expected.checksum:
layout-tests/css1/box_properties/border_color_inline-expected.png:
layout-tests/css1/box_properties/border_inline-expected.checksum:
layout-tests/css1/box_properties/border_inline-expected.png:
layout-tests/css1/box_properties/border_left-expected.checksum:
layout-tests/css1/box_properties/border_left-expected.png:
layout-tests/css1/box_properties/border_left_inline-expected.checksum:
layout-tests/css1/box_properties/border_left_inline-expected.png:
layout-tests/css1/box_properties/border_left_width-expected.checksum:
layout-tests/css1/box_properties/border_left_width-expected.png:
layout-tests/css1/box_properties/border_left_width_inline-expected.checksum:
layout-tests/css1/box_properties/border_left_width_inline-expected.png:
layout-tests/css1/box_properties/border_right-expected.checksum:
layout-tests/css1/box_properties/border_right-expected.png:
layout-tests/css1/box_properties/border_right_inline-expected.checksum:
layout-tests/css1/box_properties/border_right_inline-expected.png:
layout-tests/css1/box_properties/border_right_width-expected.checksum:
layout-tests/css1/box_properties/border_right_width-expected.png:
layout-tests/css1/box_properties/border_right_width_inline-expected.checksum:
layout-tests/css1/box_properties/border_right_width_inline-expected.png:
layout-tests/css1/box_properties/border_style-expected.checksum:
layout-tests/css1/box_properties/border_style-expected.png:
layout-tests/css1/box_properties/border_style_inline-expected.checksum:
layout-tests/css1/box_properties/border_style_inline-expected.png:
layout-tests/css1/box_properties/border_top-expected.checksum:
layout-tests/css1/box_properties/border_top-expected.png:
layout-tests/css1/box_properties/border_top_inline-expected.checksum:
layout-tests/css1/box_properties/border_top_inline-expected.png:
layout-tests/css1/box_properties/border_top_width-expected.checksum:
layout-tests/css1/box_properties/border_top_width-expected.png:
layout-tests/css1/box_properties/border_top_width_inline-expected.checksum:
layout-tests/css1/box_properties/border_top_width_inline-expected.png:
layout-tests/css1/box_properties/border_width-expected.checksum:
layout-tests/css1/box_properties/border_width-expected.png:
layout-tests/css1/box_properties/border_width_inline-expected.checksum:
layout-tests/css1/box_properties/border_width_inline-expected.png:
layout-tests/css1/box_properties/clear-expected.checksum:
layout-tests/css1/box_properties/clear-expected.png:
layout-tests/css1/box_properties/clear_float-expected.checksum:
layout-tests/css1/box_properties/clear_float-expected.png:
layout-tests/css1/box_properties/float-expected.checksum:
layout-tests/css1/box_properties/float-expected.png:
layout-tests/css1/box_properties/float_elements_in_series-expected.checksum:
layout-tests/css1/box_properties/float_elements_in_series-expected.png:
layout-tests/css1/box_properties/float_margin-expected.checksum:
layout-tests/css1/box_properties/float_margin-expected.png:
layout-tests/css1/box_properties/float_on_text_elements-expected.checksum:
layout-tests/css1/box_properties/float_on_text_elements-expected.png:
layout-tests/css1/box_properties/height-expected.checksum:
layout-tests/css1/box_properties/height-expected.png:
layout-tests/css1/box_properties/margin-expected.checksum:
layout-tests/css1/box_properties/margin-expected.png:
layout-tests/css1/box_properties/margin_bottom-expected.checksum:
layout-tests/css1/box_properties/margin_bottom-expected.png:
layout-tests/css1/box_properties/margin_bottom_inline-expected.checksum:
layout-tests/css1/box_properties/margin_bottom_inline-expected.png:
layout-tests/css1/box_properties/margin_inline-expected.checksum:
layout-tests/css1/box_properties/margin_inline-expected.png:
layout-tests/css1/box_properties/margin_left-expected.checksum:
layout-tests/css1/box_properties/margin_left-expected.png:
layout-tests/css1/box_properties/margin_left_inline-expected.checksum:
layout-tests/css1/box_properties/margin_left_inline-expected.png:
layout-tests/css1/box_properties/margin_right-expected.checksum:
layout-tests/css1/box_properties/margin_right-expected.png:
layout-tests/css1/box_properties/margin_right_inline-expected.checksum:
layout-tests/css1/box_properties/margin_right_inline-expected.png:
layout-tests/css1/box_properties/margin_top-expected.checksum:
layout-tests/css1/box_properties/margin_top-expected.png:
layout-tests/css1/box_properties/margin_top_inline-expected.checksum:
layout-tests/css1/box_properties/margin_top_inline-expected.png:
layout-tests/css1/box_properties/padding-expected.checksum:
layout-tests/css1/box_properties/padding-expected.png:
layout-tests/css1/box_properties/padding_bottom-expected.checksum:
layout-tests/css1/box_properties/padding_bottom-expected.png:
layout-tests/css1/box_properties/padding_bottom_inline-expected.checksum:
layout-tests/css1/box_properties/padding_bottom_inline-expected.png:
layout-tests/css1/box_properties/padding_inline-expected.checksum:
layout-tests/css1/box_properties/padding_inline-expected.png:
layout-tests/css1/box_properties/padding_left-expected.checksum:
layout-tests/css1/box_properties/padding_left-expected.png:
layout-tests/css1/box_properties/padding_left_inline-expected.checksum:
layout-tests/css1/box_properties/padding_left_inline-expected.png:
layout-tests/css1/box_properties/padding_right-expected.checksum:
layout-tests/css1/box_properties/padding_right-expected.png:
layout-tests/css1/box_properties/padding_right_inline-expected.checksum:
layout-tests/css1/box_properties/padding_right_inline-expected.png:
layout-tests/css1/box_properties/padding_top-expected.checksum:
layout-tests/css1/box_properties/padding_top-expected.png:
layout-tests/css1/box_properties/padding_top_inline-expected.checksum:
layout-tests/css1/box_properties/padding_top_inline-expected.png:
layout-tests/css1/box_properties/width-expected.checksum:
layout-tests/css1/box_properties/width-expected.png:
layout-tests/css1/cascade/cascade_order-expected.checksum:
layout-tests/css1/cascade/cascade_order-expected.png:
layout-tests/css1/cascade/important-expected.checksum:
layout-tests/css1/cascade/important-expected.png:
layout-tests/css1/classification/display-expected.checksum:
layout-tests/css1/classification/display-expected.png:
layout-tests/css1/classification/list_style-expected.checksum:
layout-tests/css1/classification/list_style-expected.png:
layout-tests/css1/classification/list_style_image-expected.checksum:
layout-tests/css1/classification/list_style_image-expected.png:
layout-tests/css1/classification/list_style_position-expected.checksum:
layout-tests/css1/classification/list_style_position-expected.png:
layout-tests/css1/classification/list_style_type-expected.checksum:
layout-tests/css1/classification/list_style_type-expected.png:
layout-tests/css1/classification/white_space-expected.checksum:
layout-tests/css1/classification/white_space-expected.png:
layout-tests/css1/color_and_background/background-expected.checksum:
layout-tests/css1/color_and_background/background-expected.png:
layout-tests/css1/color_and_background/background_attachment-expected.checksum:
layout-tests/css1/color_and_background/background_attachment-expected.png:
layout-tests/css1/color_and_background/background_color-expected.checksum:
layout-tests/css1/color_and_background/background_color-expected.png:
layout-tests/css1/color_and_background/background_image-expected.checksum:
layout-tests/css1/color_and_background/background_image-expected.png:
layout-tests/css1/color_and_background/background_position-expected.checksum:
layout-tests/css1/color_and_background/background_position-expected.png:
layout-tests/css1/color_and_background/background_repeat-expected.checksum:
layout-tests/css1/color_and_background/background_repeat-expected.png:
layout-tests/css1/color_and_background/color-expected.checksum:
layout-tests/css1/color_and_background/color-expected.png:
layout-tests/css1/font_properties/font-expected.checksum:
layout-tests/css1/font_properties/font-expected.png:
layout-tests/css1/font_properties/font_family-expected.checksum:
layout-tests/css1/font_properties/font_family-expected.png:
layout-tests/css1/font_properties/font_size-expected.checksum:
layout-tests/css1/font_properties/font_size-expected.png:
layout-tests/css1/font_properties/font_style-expected.checksum:
layout-tests/css1/font_properties/font_style-expected.png:
layout-tests/css1/font_properties/font_variant-expected.checksum:
layout-tests/css1/font_properties/font_variant-expected.png:
layout-tests/css1/font_properties/font_weight-expected.checksum:
layout-tests/css1/font_properties/font_weight-expected.png:
layout-tests/css1/formatting_model/canvas-expected.checksum:
layout-tests/css1/formatting_model/canvas-expected.png:
layout-tests/css1/formatting_model/floating_elements-expected.checksum:
layout-tests/css1/formatting_model/floating_elements-expected.png:
layout-tests/css1/formatting_model/height_of_lines-expected.checksum:
layout-tests/css1/formatting_model/height_of_lines-expected.png:
layout-tests/css1/formatting_model/inline_elements-expected.checksum:
layout-tests/css1/formatting_model/inline_elements-expected.png:
layout-tests/css1/formatting_model/replaced_elements-expected.checksum:
layout-tests/css1/formatting_model/replaced_elements-expected.png:
layout-tests/css1/formatting_model/vertical_formatting-expected.checksum:
layout-tests/css1/formatting_model/vertical_formatting-expected.png:
layout-tests/css1/pseudo/anchor-expected.checksum:
layout-tests/css1/pseudo/anchor-expected.png:
layout-tests/css1/pseudo/firstletter-expected.checksum:
layout-tests/css1/pseudo/firstletter-expected.png:
layout-tests/css1/pseudo/firstline-expected.checksum:
layout-tests/css1/pseudo/firstline-expected.png:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.checksum:
layout-tests/css1/pseudo/multiple_pseudo_elements-expected.png:
layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.checksum:
layout-tests/css1/pseudo/pseudo_elements_in_selectors-expected.png:
layout-tests/css1/text_properties/letter_spacing-expected.checksum:
layout-tests/css1/text_properties/letter_spacing-expected.png:
layout-tests/css1/text_properties/line_height-expected.checksum:
layout-tests/css1/text_properties/line_height-expected.png:
layout-tests/css1/text_properties/text_align-expected.checksum:
layout-tests/css1/text_properties/text_align-expected.png:
layout-tests/css1/text_properties/text_decoration-expected.checksum:
layout-tests/css1/text_properties/text_decoration-expected.png:
layout-tests/css1/text_properties/text_indent-expected.checksum:
layout-tests/css1/text_properties/text_indent-expected.png:
layout-tests/css1/text_properties/text_transform-expected.checksum:
layout-tests/css1/text_properties/text_transform-expected.png:
layout-tests/css1/text_properties/vertical_align-expected.checksum:
layout-tests/css1/text_properties/vertical_align-expected.png:
layout-tests/css1/text_properties/word_spacing-expected.checksum:
layout-tests/css1/text_properties/word_spacing-expected.png:
layout-tests/css1/units/color_units-expected.checksum:
layout-tests/css1/units/color_units-expected.png:
layout-tests/css1/units/length_units-expected.checksum:
layout-tests/css1/units/length_units-expected.png:
layout-tests/css1/units/percentage_units-expected.checksum:
layout-tests/css1/units/percentage_units-expected.png:
layout-tests/css1/units/urls-expected.checksum:
layout-tests/css1/units/urls-expected.png:
layout-tests/editing/selection/move-by-line-001-expected.checksum:
layout-tests/editing/selection/move-by-line-001-expected.png:
layout-tests/editing/unsupported-content/table-type-after-expected.checksum:
layout-tests/editing/unsupported-content/table-type-after-expected.png:
layout-tests/editing/unsupported-content/table-type-before-expected.checksum:
layout-tests/editing/unsupported-content/table-type-before-expected.png:
layout-tests/fast/block/basic/018-expected.checksum:
layout-tests/fast/block/basic/018-expected.png:
layout-tests/fast/block/float/015-expected.checksum:
layout-tests/fast/block/float/015-expected.png:
layout-tests/fast/block/float/016-expected.checksum:
layout-tests/fast/block/float/016-expected.png:
layout-tests/fast/block/float/025-expected.checksum:
layout-tests/fast/block/float/025-expected.png:
layout-tests/fast/block/float/026-expected.checksum:
layout-tests/fast/block/float/026-expected.png:
layout-tests/fast/block/float/027-expected.checksum:
layout-tests/fast/block/float/027-expected.png:
layout-tests/fast/block/float/028-expected.checksum:
layout-tests/fast/block/float/028-expected.png:
layout-tests/fast/css/MarqueeLayoutTest-expected.checksum:
layout-tests/fast/css/MarqueeLayoutTest-expected.png:
layout-tests/fast/css/apple-prefix-expected.checksum:
layout-tests/fast/css/apple-prefix-expected.png:
layout-tests/fast/css/list-outline-expected.checksum:
layout-tests/fast/css/list-outline-expected.png:
layout-tests/fast/dom/HTMLElement/bdo-expected.checksum:
layout-tests/fast/dom/HTMLElement/bdo-expected.png:
layout-tests/fast/dom/HTMLTableElement/colSpan-expected.checksum:
layout-tests/fast/dom/HTMLTableElement/colSpan-expected.png:
layout-tests/fast/dom/HTMLTableElement/createCaption-expected.checksum:
layout-tests/fast/dom/HTMLTableElement/createCaption-expected.png:
layout-tests/fast/dom/clone-node-dynamic-style-expected.checksum:
layout-tests/fast/dom/clone-node-dynamic-style-expected.png:
layout-tests/fast/dom/row-inner-text-expected.checksum:
layout-tests/fast/dom/row-inner-text-expected.png:
layout-tests/fast/dynamic/012-expected.checksum:
layout-tests/fast/dynamic/012-expected.png:
layout-tests/fast/dynamic/013-expected.checksum:
layout-tests/fast/dynamic/013-expected.png:
layout-tests/fast/encoding/invalid-UTF-8-expected.checksum:
layout-tests/fast/encoding/invalid-UTF-8-expected.png:
layout-tests/fast/encoding/utf-16-big-endian-expected.checksum:
layout-tests/fast/encoding/utf-16-big-endian-expected.png:
layout-tests/fast/encoding/utf-16-little-endian-expected.checksum:
layout-tests/fast/encoding/utf-16-little-endian-expected.png:
layout-tests/fast/forms/001-expected.checksum:
layout-tests/fast/forms/001-expected.png:
layout-tests/fast/forms/006-expected.checksum:
layout-tests/fast/forms/006-expected.png:
layout-tests/fast/forms/007-expected.checksum:
layout-tests/fast/forms/007-expected.png:
layout-tests/fast/forms/input-value-expected.checksum:
layout-tests/fast/forms/input-value-expected.png:
layout-tests/fast/lists/004-expected.checksum:
layout-tests/fast/lists/004-expected.png:
layout-tests/fast/overflow/002-expected.checksum:
layout-tests/fast/overflow/002-expected.png:
layout-tests/fast/replaced/005-expected.checksum:
layout-tests/fast/replaced/005-expected.png:
layout-tests/fast/selectors/032-expected.checksum:
layout-tests/fast/selectors/032-expected.png:
layout-tests/fast/selectors/064-expected.checksum:
layout-tests/fast/selectors/064-expected.png:
layout-tests/fast/selectors/077-expected.checksum:
layout-tests/fast/selectors/077-expected.png:
layout-tests/fast/selectors/077b-expected.checksum:
layout-tests/fast/selectors/077b-expected.png:
layout-tests/fast/selectors/078b-expected.checksum:
layout-tests/fast/selectors/078b-expected.png:
layout-tests/fast/table/003-expected.checksum:
layout-tests/fast/table/003-expected.png:
layout-tests/fast/table/004-expected.checksum:
layout-tests/fast/table/004-expected.png:
layout-tests/fast/table/006-expected.checksum:
layout-tests/fast/table/006-expected.png:
layout-tests/fast/table/007-expected.checksum:
layout-tests/fast/table/007-expected.png:
layout-tests/fast/table/009-expected.checksum:
layout-tests/fast/table/009-expected.png:
layout-tests/fast/table/017-expected.checksum:
layout-tests/fast/table/017-expected.png:
layout-tests/fast/table/018-expected.checksum:
layout-tests/fast/table/018-expected.png:
layout-tests/fast/table/020-expected.checksum:
layout-tests/fast/table/020-expected.png:
layout-tests/fast/table/029-expected.checksum:
layout-tests/fast/table/029-expected.png:
layout-tests/fast/table/030-expected.checksum:
layout-tests/fast/table/030-expected.png:
layout-tests/fast/table/035-expected.checksum:
layout-tests/fast/table/035-expected.png:
layout-tests/fast/table/038-expected.checksum:
layout-tests/fast/table/038-expected.png:
layout-tests/fast/table/039-expected.checksum:
layout-tests/fast/table/039-expected.png:
layout-tests/fast/table/040-expected.checksum:
layout-tests/fast/table/040-expected.png:
layout-tests/fast/table/041-expected.checksum:
layout-tests/fast/table/041-expected.png:
layout-tests/fast/table/empty-table-percent-height-expected.checksum:
layout-tests/fast/table/empty-table-percent-height-expected.png:
layout-tests/fast/table/large-width-expected.checksum:
layout-tests/fast/table/large-width-expected.png:
layout-tests/fast/table/multiple-percent-height-rows-expected.checksum:
layout-tests/fast/table/multiple-percent-height-rows-expected.png:
layout-tests/fast/table/nobr-expected.checksum:
layout-tests/fast/table/nobr-expected.png:
layout-tests/fast/table/percent-heights-expected.checksum:
layout-tests/fast/table/percent-heights-expected.png:
layout-tests/fast/table/rowspan-paint-order-expected.checksum:
layout-tests/fast/table/rowspan-paint-order-expected.png:
layout-tests/fast/text/basic/001-expected.checksum:
layout-tests/fast/text/basic/001-expected.png:
layout-tests/fast/text/basic/006-expected.checksum:
layout-tests/fast/text/basic/006-expected.png:
layout-tests/fast/text/basic/007-expected.checksum:
layout-tests/fast/text/basic/007-expected.png:
layout-tests/fast/text/international/003-expected.checksum:
layout-tests/fast/text/international/003-expected.png:
layout-tests/fast/text/international/bidi-innertext-expected.checksum:
layout-tests/fast/text/international/bidi-innertext-expected.png:
layout-tests/fast/text/whitespace/027-expected.checksum:
layout-tests/fast/text/whitespace/027-expected.png:

10:37 PM Changeset in webkit [10426] by darin

2 edits
4 adds in trunk

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4560 Markup in <title> prevents decoder from looking for a charset

Test cases added:

layout-tests/fast/encoding/tag-in-title.html: Added.
layout-tests/fast/encoding/tag-in-title-expected.png: Added.
layout-tests/fast/encoding/tag-in-title-expected.txt: Added.

khtml/misc/decoder.cpp: (Decoder::decode): Ignore tags within <title>.

10:04 PM Changeset in webkit [10425] by mjs

5 edits in trunk

updated pixel test baselines that had the button text off by one - I think this was a bug in a 10.4.2 pre-release that I was running

layout-tests/fast/forms/001-expected.checksum:
layout-tests/fast/forms/001-expected.png:
layout-tests/fast/forms/input-value-expected.checksum:
layout-tests/fast/forms/input-value-expected.png:

9:44 PM Changeset in webkit [10424] by darin

5 edits in trunk

Reviewed, tweaked, and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4626 bidi-fallback-font-weight test requires font that's not part of default OS X install

layout-tests/fast/text/international/bidi-fallback-font-weight.html: Removed the part that used the Raanana font.
layout-tests/fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
layout-tests/fast/text/international/bidi-fallback-font-weight-expected.png: Ditto.
layout-tests/fast/text/international/bidi-fallback-font-weight-expected.txt: Ditto.

9:40 PM Changeset in webkit [10423] by eseidel

242 edits
1 add in trunk

Bug #: 4472
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel

Test cases updated:

svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/rects-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.txt:
svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.txt:
svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.txt:
svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.txt:
svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.txt:
svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-04-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-05-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-align-06-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-text-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-text-03-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.txt:
svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.txt:

WebCore.xcodeproj/project.pbxproj: Added KCanvasPath.cpp
kcanvas/KCanvasFilters.cpp: (KCanvasFilter::externalRepresentation): added. (operator<<): added. (KCanvasFilterEffect::externalRepresentation): (KCanvasFEDistantLight::externalRepresentation): (KCanvasFEPointLight::externalRepresentation): (KCanvasFESpotLight::externalRepresentation): (KCanvasFEBlend::externalRepresentation): (KCanvasFEColorMatrix::externalRepresentation): (KCanvasFEComponentTransfer::externalRepresentation): (KCanvasFEComposite::externalRepresentation): (KCanvasFEConvolveMatrix::externalRepresentation): (KCanvasFEDiffuseLighting::externalRepresentation): (KCanvasFEDisplacementMap::externalRepresentation): (KCanvasFEFlood::externalRepresentation): (KCanvasFEGaussianBlur::externalRepresentation): (KCanvasFEImage::externalRepresentation): (KCanvasFEMerge::externalRepresentation): (KCanvasFEMorphology::externalRepresentation): (KCanvasFEOffset::externalRepresentation): (KCanvasFESpecularLighting::externalRepresentation): (KCanvasFETile::externalRepresentation): (KCanvasFETurbulence::externalRepresentation):
kcanvas/KCanvasFilters.h: (KCanvasFEDistantLight::azimuth): (KCanvasFEDistantLight::elevation): (KCanvasFEComposite::k1): (KCanvasFEComposite::k2): (KCanvasFEComposite::k3): (KCanvasFEComposite::k4):
kcanvas/KCanvasPath.cpp: Added. (operator<<):
kcanvas/KCanvasPath.h:
kcanvas/KCanvasRegistry.cpp: (KCanvasRegistry::addPaintServerById): (KCanvasRegistry::addResourceById): (operator<<):
kcanvas/KCanvasRegistry.h:
kcanvas/KCanvasResources.cpp: (operator<<): (KCanvasResource::idInRegistry): (KCanvasResource::setIdInRegistry): (KCanvasResource::externalRepresentation): (KCanvasClipper::externalRepresentation): (KCanvasMarker::externalRepresentation):
kcanvas/KCanvasResources.h:
kcanvas/KCanvasTreeDebug.cpp: (QTextStreamSeparator::QTextStreamSeparator): (operator<<): (writeIndent): (externalRepresentation):
kcanvas/KCanvasTreeDebug.h: (operator<<):
kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::idInRegistry): (KRenderingPaintServer::setIdInRegistry):
kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): (KRenderingPaintServerGradient::externalRepresentation): (KRenderingPaintServerLinearGradient::externalRepresentation): (KRenderingPaintServerRadialGradient::externalRepresentation):
kcanvas/device/KRenderingPaintServerGradient.h:
kcanvas/device/KRenderingPaintServerImage.cpp: (KRenderingPaintServerImage::externalRepresentation):
kcanvas/device/KRenderingPaintServerImage.h:
kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::externalRepresentation):
kcanvas/device/KRenderingPaintServerPattern.h:
kcanvas/device/KRenderingPaintServerSolid.cpp: (operator<<): (KRenderingPaintServerSolid::externalRepresentation):
kcanvas/device/KRenderingPaintServerSolid.h:
kwq/KWQTextStream.h:
kwq/KWQTextStream.mm: (QTextStream::QTextStream): (QTextStream::operator<<): (QTextStream::precision): added. Necessary additions for much better KCanvas render tree dumps. http://bugzilla.opendarwin.org/show_bug.cgi?id=4472

8:30 PM Changeset in webkit [10422] by darin

2 edits in trunk/WebCore

Reviewed and landed by Darin.

fixed http://bugzilla.opendarwin.org/attachment.cgi?id=3702 Acid2 test has orange border around nose

kwq/KWQPainter.mm: (QPainter::drawConvexPolygon): Add back a call to CGContextSetShouldAntialias, accidentally rolled out.

6:01 PM Changeset in webkit [10421] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-31 Vicki Murley <vicki@apple.com>

Reviewed by hyatt.

fixed <rdar://problem/4233844> in some cases, HTML href named anchors don't scroll to the right place

Test cases added:

manual-tests/scrollToAnchorWithNewline.html: Added.

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): skip text nodes that do not have associated text boxes

4:05 PM Changeset in webkit [10420] by harrison

2 edits
1 add in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4234658> SUTiDenver8F17: Dragging in this HTML example crashes Safari

Problem is KWQKHTMLPart::snapshotDragImage() leaves the layout needing updating, that
layout gets triggered (in this case) by the foreground draw in the RenderLayer code,
thereby deleting the RenderLayer itself. Simple fix is for snapshotDragImage() to
updateLayout() after resetting the drag state.

Test cases added:

manual-tests/drag_with_opacity.html: Added.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::snapshotDragImage): Call updateLayout() after resetting the drag state

4:02 PM Changeset in webkit [10419] by vicki

2 edits
1 add in trunk/WebCore

Reviewed by hyatt.

fixed <rdar://problem/4233844> in some cases, HTML href named anchors don't scroll to the right place

Test cases added:

manual-tests/scrollToAnchorWithNewline.html: Added.

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): skip text nodes that do not have associated text boxes

2:12 PM Changeset in webkit [10418] by eseidel

3 edits in trunk

Bug #: 4780
Submitted by: eseidel
Reviewed by: vicki

WebCore.xcodeproj/project.pbxproj: added EventNames.*
kdom/css/impl/Font.h: Fixed includes. Build fixes necessary after recent WebCore changes. http://bugzilla.opendarwin.org/show_bug.cgi?id=4780

11:37 AM Changeset in webkit [10417] by ggaren

1 edit
2 adds in trunk

-rolled in layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
kjs does not allow named functions in function expressions

Test cases added:

layout-tests/fast/js/named-function-expression-expected.txt: Added.
layout-tests/fast/js/named-function-expression.html: Added.

11:36 AM Changeset in webkit [10416] by ggaren

4 edits in trunk/JavaScriptCore

-rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
kjs does not allow named functions in function expressions

Fix by Arthur Langereis.

Reviewed by darin.

kjs/grammar.y:
kjs/nodes.cpp: (FuncExprNode::evaluate):
kjs/nodes.h: (KJS::FuncExprNode::FuncExprNode):

Test cases added:

layout-tests/fast/js/named-function-expression-expected.txt: Added.
layout-tests/fast/js/named-function-expression.html: Added.

8:36 AM Changeset in webkit [10415] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4766 many callers of removeChild are leaking the removed node

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterText): Added ref/deref around removeChild call.
khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::remove): Ditto. (DOM::HTMLTextAreaElementImpl::setDefaultValue): Ditto.
khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::deleteTHead): Ditto. (DOM::HTMLTableElementImpl::deleteTFoot): Ditto. (DOM::HTMLTableElementImpl::deleteCaption): Ditto. (DOM::HTMLTableSectionElementImpl::deleteRow): Ditto. (DOM::HTMLTableRowElementImpl::deleteCell): Ditto.
khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents): Ditto. (DOM::RangeImpl::surroundContents): Ditto.

5:49 AM Changeset in webkit [10414] by andersca

1 edit in trunk/WebCore/khtml/rendering/render_object.cpp

Fix build, it's #ifndef, not #infdef.

2:46 AM Changeset in webkit [10413] by mjs

4 edits in trunk/WebCore

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4768
(Add counters for NodeImpl, ElementImpl and RenderObject in debug builds)

Test cases added: None, this just adds debug output (which shows up on the regular layout tests).

khtml/rendering/render_object.cpp: (RenderObjectCounter::~RenderObjectCounter): (RenderObject::RenderObject): (RenderObject::~RenderObject):
khtml/xml/dom_elementimpl.cpp: (ElementImplCounter::~ElementImplCounter): (ElementImpl::ElementImpl): (ElementImpl::~ElementImpl):
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImplCounter::~NodeImplCounter): (DOM::NodeImpl::NodeImpl): (DOM::NodeImpl::~NodeImpl):

12:57 AM Changeset in webkit [10412] by darin

4 edits in trunk/JavaScriptCore

Reviewed, tweaked, and landed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4085
fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4087
fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4096 Some fixes for compiling on windows.

kjs/config.h: Added a WIN32 case in here, with suitable defines. (To be tweaked as necessary.)
kjs/function.cpp: Took out APPLE_CHANGES around use of ICU.
kjs/operations.cpp: Removed some bogus code that always set HAVE_FLOAT_H.

12:36 AM Changeset in webkit [10411] by andersca

1 edit in trunk/WebCore/ChangeLog-2005-12-19

Fix ChangeLog.

12:34 AM Changeset in webkit [10410] by andersca

2 edits in trunk/WebCore

Reviewed by Darin and Maciej.

khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Close the output buffer so we won't leak it.

Aug 30, 2005:

11:46 PM Changeset in webkit [10409] by mjs

7 edits in trunk

remove color profile info from some of the w3c images, and update results

layout-tests/dom/html/level2/html/frame-expected.checksum:
layout-tests/dom/html/level2/html/frame-expected.png:
layout-tests/dom/html/level2/html/iframe-expected.checksum:
layout-tests/dom/html/level2/html/iframe-expected.png:
layout-tests/dom/html/level2/html/right.png:
layout-tests/dom/html/level2/html/w3c_main.png:

11:37 PM Changeset in webkit [10408] by eseidel

1 edit
2 deletes in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Scripts/build-svg2png: Removed.
svg2png/ImageDiff.h: Removed.
svg2png/ImageDiff.m: Removed.
svg2png/svg2png.m: Removed.
svg2png/svg2png.xcodeproj/project.pbxproj: Removed.
svg2png/svg2png_Prefix.pch: Removed. svg2png is no longer needed.

11:20 PM Changeset in webkit [10407] by mjs

3 edits
2 adds in trunk

update image results

layout-tests/fast/parser/comments-expected.checksum:
layout-tests/fast/parser/comments-expected.png:
layout-tests/fast/text/line-breaks-expected.checksum: Added.
layout-tests/fast/text/line-breaks-expected.png: Added.

11:12 PM Changeset in webkit [10406] by darin

3 edits
1 add in trunk/WebKitTools

Scripts/check-dom-results: Special case 100% to say something nice.
Scripts/cvs-apply: Added "--merge" which automatically rolls back the tree before applying the patch (need a better name).
Scripts/find-extra-includes: Added. Experimental tool to find unneeded includes.

10:12 PM Changeset in webkit [10405] by mjs

4 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4232371> leak of DOMStringImpl called from DOMStringImpl::substring, seen running webkit tests
<rdar://problem/4232355> leak of DOMStringImpl called from RenderTextFragment::originalString, seen running webkit tests

Test cases added: None, these leaks were already caught by the layout tests.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
khtml/rendering/render_text.h:

10:09 PM Changeset in webkit [10404] by mjs

3 edits in trunk/WebCore

Reviewed by Vicki

<rdar://problem/4231978> many leaks of StyleSurroundData called beneath RenderStyle::setMarginTop, seen running webkit tests
<rdar://problem/4232017> many leaks of StyleInheritedData called from different RenderStyle methods, seen running webkit tests
<rdar://problem/4232175> leak of RenderObject called from RenderContainer::updatePseudoChild, seen running webkit tests
<rdar://problem/4232214> many leaks of RenderStyle from CSSStyleSelector::pseudoStyleForElement, seen running webkit tests
<rdar://problem/4232252> many leaks of RenderStyle called beneath NodeImpl::createRendererIfNeeded, seen running webkit tests
<rdar://problem/4232263> many leaks of RenderObject called from TextImpl::createRenderer, seen running webkit tests
<rdar://problem/4233690> leaks of StyleBackgroundData called within setBackgroundColor, seen running webkit tests

Test cases added: None, these leaks were already caught by the layout tests.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):

9:55 PM Changeset in webkit [10403] by darin

5 edits in trunk

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4574 HTML parser does not put attributes on the <isindex> element

layout-tests/dom/html/level2/html/HTMLIsIndexElement01-expected.txt:
layout-tests/dom/html/level2/html/HTMLIsIndexElement02-expected.txt:
layout-tests/dom/html/level2/html/HTMLIsIndexElement03-expected.txt: Updated to expect success.

khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex): Updated to put the attributes on the <isindex> element.

9:38 PM Changeset in webkit [10402] by darin

37 edits
3 adds in trunk

Reviewed by Maciej.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4540 event handlers for all custom events called when any custom event is set

layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt: Updated results to expect success.

khtml/xml/EventNames.h: Added.
khtml/xml/EventNames.cpp: Added.
ForwardingHeaders/xml/EventNames.h: Added.
WebCore.xcodeproj/project.pbxproj: Added EventNames.h and EventNames.cpp.

khtml/xml/dom2_eventsimpl.h: Removed EventId type. Made a few more functions inline.
khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::EventImpl): (DOM::EventImpl::~EventImpl): (DOM::EventImpl::initEvent): (DOM::UIEventImpl::UIEventImpl): (DOM::UIEventImpl::initUIEvent): (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): (DOM::MouseEventImpl::MouseEventImpl): (DOM::MouseEventImpl::initMouseEvent): (DOM::MouseEventImpl::isDragEvent): (DOM::KeyboardEventImpl::KeyboardEventImpl): (DOM::KeyboardEventImpl::initKeyboardEvent): (DOM::KeyboardEventImpl::keyCode): (DOM::MutationEventImpl::MutationEventImpl): (DOM::MutationEventImpl::initMutationEvent): (DOM::ClipboardEventImpl::ClipboardEventImpl): (DOM::WheelEventImpl::WheelEventImpl): (DOM::RegisteredEventListener::RegisteredEventListener): (DOM::RegisteredEventListener::~RegisteredEventListener): Updated to use the new AtomicString type rather than a type string and separate ID.

khtml/xml/dom_atomicstring.h: Implemented the constructor that takes an NSString.

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::wasRunByUserGesture):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNode::setListener): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::getNodeEventListener): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::DOMMutationEventProtoFunc::callAsFunction):
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction):
khtml/ecma/kjs_window.h:
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::detach):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): (HTMLElementImpl::click): (inlineTagList): (blockTagList):
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::prepareSubmit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLFormElementImpl::parseMappedAttribute): (DOM::HTMLGenericFormElementImpl::onSelect): (DOM::HTMLGenericFormElementImpl::onChange): (DOM::HTMLGenericFormElementImpl::defaultEventHandler): (DOM::HTMLButtonElementImpl::parseMappedAttribute): (DOM::HTMLButtonElementImpl::defaultEventHandler): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::setValueFromRenderer): (DOM::HTMLInputElementImpl::preDispatchEventHandler): (DOM::HTMLInputElementImpl::defaultEventHandler): (DOM::HTMLLabelElementImpl::parseMappedAttribute): (DOM::HTMLSelectElementImpl::parseMappedAttribute): (DOM::HTMLSelectElementImpl::defaultEventHandler): (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): (HTMLImageElementImpl::parseMappedAttribute):
khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler):
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::attach): (DOM::HTMLObjectElementImpl::detach): (DOM::HTMLObjectElementImpl::recalcStyle):
khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::stopLoading):
khtml/khtmlview.cpp: (KHTMLView::resizeEvent): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchDragEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop): (KHTMLView::dispatchMouseEvent):
khtml/khtmlview.h:
khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked): (RenderLineEdit::slotPerformSearch): (RenderSlider::slotSliderValueChanged):
khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollToOffset):
khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
khtml/rendering/render_replaced.cpp: (RenderWidget::sendConsumedMouseUp): (RenderWidget::eventFilter):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose): (DocumentImpl::setFocusNode): (DocumentImpl::defaultEventHandler): (DocumentImpl::setHTMLWindowEventListener): (DocumentImpl::getHTMLWindowEventListener): (DocumentImpl::removeHTMLWindowEventListener): (DocumentImpl::addWindowEventListener): (DocumentImpl::removeWindowEventListener): (DocumentImpl::hasWindowEventListener):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::dispatchAttrRemovalEvent): (ElementImpl::dispatchAttrAdditionEvent):
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addEventListener): (DOM::NodeImpl::removeEventListener): (DOM::NodeImpl::removeHTMLEventListener): (DOM::NodeImpl::setHTMLEventListener): (DOM::NodeImpl::getHTMLEventListener): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::handleLocalEvents): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents):
khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::dispatchModifiedEvent):
kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): (KWQKHTMLPart::sendScrollEvent): (KWQKHTMLPart::dispatchDragSrcEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::dispatchCPPEvent): (KWQKHTMLPart::mayCut): (KWQKHTMLPart::mayCopy): (KWQKHTMLPart::mayPaste): (KWQKHTMLPart::tryCut): (KWQKHTMLPart::tryCopy): (KWQKHTMLPart::tryPaste): (KWQKHTMLPart::sendContextMenuEvent): (KWQKHTMLPart::setWindowHasFocus):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]): (-[KWQTextAreaTextView cut:]): (-[KWQTextAreaTextView copy:]): (-[KWQTextAreaTextView paste:]): (-[KWQTextAreaTextView pasteAsPlainText:]): (-[KWQTextAreaTextView pasteAsRichText:]): Use the new namespace, types, and use AtomicString instead of event ID.

7:25 PM Changeset in webkit [10401] by darin

2 edits in trunk/WebKitTools

Scripts/run-webkit-tests: Small formatting fix for leaks mode.

5:49 PM Changeset in webkit [10400] by adele

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-30 John Sullivan <sullivan@apple.com>

Reviewed by Maciej.

Test cases added: none, doesn't affect layout

fixed <rdar://problem/4237183> REGRESSION (Denver): crash in JSUnprotectedEventListener::~JSUnprotectedEventListener

khtml/ecma/kjs_events.cpp: (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): check for nil window pointer (KJS::JSUnprotectedEventListener::clearWindowObj): new method, sets window pointer to nil

(KJS::JSEventListener::~JSEventListener):
(KJS::JSEventListener::clearWindowObj):
same changes for this class. We don't think the bug would ever happen for
this similar class, but we're not completely sure, so best to play it safe.

khtml/ecma/kjs_events.h: declaration of new clearWindowObj methods

khtml/ecma/kjs_window.cpp: (KJS::Window::~Window): iterate through event listeners, clearing their window pointers

4:56 PM Changeset in webkit [10399] by darin

11 edits
1 add in trunk

JavaScriptCore:

Reviewed by John Sullivan.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4758 unify SharedPtr in WebCore and JavaScriptCore

kjs/shared_ptr.h: Updated namespace to KXMLCore instead of kxhmlcore. Made a few small improvements to use local variables a bit more and added an "operator int" to reduce the chance that we'll convert a SharedPtr to an int by accident. Also made the == operators normal functions rather than friend functions, added a couple of comemnts.

kjs/function.h: Updated for namespace change.
kjs/function.cpp: Ditto.
kjs/function_object.cpp: Ditto.
kjs/internal.h: Ditto.
kjs/internal.cpp: Ditto.
kjs/nodes.h: Ditto.
kjs/nodes2string.cpp: Ditto.

WebCore:

Reviewed by John Sullivan.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4758 unify SharedPtr in WebCore and JavaScriptCore

ForwardingHeaders/kjs/shared_ptr.h: Added.
khtml/misc/shared.h: Removed SharedPtr, and instead included <kjs/shared_ptr.h> and did some using statements to import the template into the khtml namespace.

3:59 PM Changeset in webkit [10398] by hyatt

4 edits in trunk

Fix for bugzilla bug 4573, make sure click() fires CLICK and not KHTML_CLICK,
so that the click() method on checkboxes actually works.

Also eliminate the WinIE compatibiilty for event.button and match the
standard DOM behavior instead (like Firefox does).

Reviewed by darin

Test cases added: None, since one of the level 2 DOM tests changes to
pass and tests this feature.

khtml/ecma/kjs_events.cpp: (KJS::DOMMouseEvent::getValueProperty):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click):
layout-tests/dom/html/level2/html/HTMLInputElement21-expected.txt:

2:36 PM Changeset in webkit [10397] by hyatt

8 edits in trunk/WebCore

Change the value of "element" for khtml-user-select to "ignore". Also undo the support of "-moz"
for any -moz property. Add support for -webkit as an alternative to -khtml.

Reviewed by darin

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/css/cssvalues.in:
khtml/css/html4.css:
khtml/css/parser.y:
khtml/rendering/render_style.h: (khtml::):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect):

1:12 PM Changeset in webkit [10396] by sullivan

2 edits in trunk/WebCore

Reviewed by Kevin Decker.

Test cases added: none, doesn't affect layout

fixed <rdar://problem/4238024> leak of DocumentFragmentImpl if parseXMLDocumentFragment fails

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): deref fragment before early return

11:20 AM Changeset in webkit [10395] by sullivan

4 edits in trunk/WebCore

Reviewed by Maciej.

Test cases added: none, doesn't affect layout

fixed <rdar://problem/4237183> REGRESSION (Denver): crash in JSUnprotectedEventListener::~JSUnprotectedEventListener

khtml/ecma/kjs_events.cpp: (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): check for nil window pointer (KJS::JSUnprotectedEventListener::clearWindowObj): new method, sets window pointer to nil

(KJS::JSEventListener::~JSEventListener):
(KJS::JSEventListener::clearWindowObj):
same changes for this class. We don't think the bug would ever happen for
this similar class, but we're not completely sure, so best to play it safe.

khtml/ecma/kjs_events.h: declaration of new clearWindowObj methods

khtml/ecma/kjs_window.cpp: (KJS::Window::~Window): iterate through event listeners, clearing their window pointers

2:55 AM Changeset in webkit [10394] by mjs

1 edit
4 adds in trunk

Add some test cases that I apparently forgot to commit before.

layout-tests/fast/js/assign-expected.txt: Added.
layout-tests/fast/js/assign.html: Added.
layout-tests/fast/js/code-serialize-paren-expected.txt: Added.
layout-tests/fast/js/code-serialize-paren.html: Added.

2:30 AM Changeset in webkit [10393] by mjs

22 edits
1 add in trunk/WebCore

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4749 (Reduce header dependencies);

Test cases added: None, no functional change.

ForwardingHeaders/qpen.h: Added.
khtml/rendering/font.h:
khtml/rendering/render_box.cpp:
khtml/rendering/render_image.cpp:
khtml/rendering/render_line.cpp:
khtml/rendering/render_list.cpp:
khtml/rendering/render_object.cpp:
khtml/rendering/render_text.cpp:
kwq/KWQApplication.h:
kwq/KWQApplication.mm:
kwq/KWQButton.h:
kwq/KWQKCursor.h:
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm:
kwq/KWQListBox.h:
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::setCompositeOperation): (QPainter::compositeOperatorFromString):
kwq/KWQPixmap.h:
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm:
kwq/KWQWidget.h:
kwq/KWQWidget.mm:

2:04 AM Changeset in webkit [10392] by hyatt

2 edits in trunk/LayoutTests/fast/parser

Fix layout test.

Aug 29, 2005:

8:46 PM Changeset in webkit [10391] by mjs

13 edits
2 adds
13 deletes in trunk

make the JS tests that weren't already doing so dump as text, and remove their image results.

layout-tests/fast/js/date-parse-test-expected.checksum: Removed.
layout-tests/fast/js/date-parse-test-expected.png: Removed.
layout-tests/fast/js/date-parse-test-expected.txt:
layout-tests/fast/js/date-parse-test.html:
layout-tests/fast/js/declaration-in-block-expected.checksum: Removed.
layout-tests/fast/js/declaration-in-block-expected.png: Removed.
layout-tests/fast/js/declaration-in-block-expected.txt:
layout-tests/fast/js/declaration-in-block.html:
layout-tests/fast/js/encode-URI-test-expected.txt: Added.
layout-tests/fast/js/encode-URI-test.html: Added.
layout-tests/fast/js/global/encode-URI-test-expected.checksum: Removed.
layout-tests/fast/js/global/encode-URI-test-expected.png: Removed.
layout-tests/fast/js/global/encode-URI-test-expected.txt: Removed.
layout-tests/fast/js/global/encode-URI-test.html: Removed.
layout-tests/fast/js/has-own-property-expected.checksum: Removed.
layout-tests/fast/js/has-own-property-expected.png: Removed.
layout-tests/fast/js/has-own-property-expected.txt:
layout-tests/fast/js/has-own-property.html:
layout-tests/fast/js/slash-lineterminator-parse-expected.checksum: Removed.
layout-tests/fast/js/slash-lineterminator-parse-expected.png: Removed.
layout-tests/fast/js/slash-lineterminator-parse-expected.txt:
layout-tests/fast/js/slash-lineterminator-parse.html:
layout-tests/fast/js/string-from-char-code-expected.checksum: Removed.
layout-tests/fast/js/string-from-char-code-expected.png: Removed.
layout-tests/fast/js/string-from-char-code-expected.txt:
layout-tests/fast/js/string-from-char-code.html:
layout-tests/fast/js/window-object-cross-frame-calls-expected.checksum: Removed.
layout-tests/fast/js/window-object-cross-frame-calls-expected.png: Removed.
layout-tests/fast/js/window-object-cross-frame-calls-expected.txt:
layout-tests/fast/js/window-object-cross-frame-calls.html:

4:39 PM Changeset in webkit [10390] by sullivan

2 edits in trunk/WebCore

Written by Justin Garcia
Reviewed by me and Darin Adler

Test cases added: none, doesn't affect layout

fixed <rdar://problem/4232303> many objects leaked from HTMLTokenizer::parseTag() within -[WebView paste:], seen running webkit tests (probably affects Mail)

khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::removeNode): guard removeChild call with ref/deref, so if this is the last reference it won't be left floating, and will properly self-destruct

2:42 PM Changeset in webkit [10389] by mjs

2 edits in trunk/WebKitTools

Reviewed by Darin.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4723 (some pixel tests fail when AA settings are changed)

DumpRenderTree/DumpRenderTree.m: (main): set AA settings to the default values

2:29 PM Changeset in webkit [10388] by darin

40 edits in trunk/WebCore

Rubber stamped by Maciej.

renamed DOMString::implementation() to DOMString::impl() and DOMString::impl to DOMString::m_impl

khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::CSSPrimitiveValueImpl::setStringValue):
khtml/css/csshelper.cpp: (khtml::parseURL):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSRuleSet::addRule): (khtml::CSSStyleSelector::applyProperty):
khtml/dom/dom_string.cpp: (DOM::DOMString::DOMString): (DOM::DOMString::operator =): (DOM::DOMString::operator += ): (DOM::DOMString::insert): (DOM::DOMString::operator []): (DOM::DOMString::find): (DOM::DOMString::length): (DOM::DOMString::truncate): (DOM::DOMString::remove): (DOM::DOMString::substring): (DOM::DOMString::split): (DOM::DOMString::lower): (DOM::DOMString::upper): (DOM::DOMString::percentage): (DOM::DOMString::unicode): (DOM::DOMString::qstring): (DOM::DOMString::toInt): (DOM::DOMString::copy): (DOM::DOMString::isEmpty): (DOM::DOMString::toCoordsArray): (DOM::DOMString::toLengthArray): (DOM::DOMString::ascii): (DOM::operator==):
khtml/dom/dom_string.h: (DOM::DOMString::DOMString): (DOM::DOMString::~DOMString): (DOM::DOMString::isNull): (DOM::DOMString::impl):
khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMDocument::getValueProperty):
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::classInfo): (KJS::HTMLElement::getSetInfo):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewFunc::callAsFunction):
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty):
khtml/editing/jsediting.cpp: (DOM::DocumentImpl::commandImp):
khtml/editing/remove_node_attribute_command.cpp: (khtml::RemoveNodeAttributeCommand::doUnapply):
khtml/editing/set_node_attribute_command.cpp: (khtml::SetNodeAttributeCommand::doApply): (khtml::SetNodeAttributeCommand::doUnapply):
khtml/html/html_blockimpl.cpp: (HTMLHRElementImpl::parseMappedAttribute):
khtml/html/html_documentimpl.cpp: (DOM::addItemToMap): (DOM::removeItemFromMap): (DOM::HTMLDocumentImpl::hasNamedItem): (DOM::HTMLDocumentImpl::hasDocExtraNamedItem):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::nodeName): (HTMLElementImpl::isRecognizedTagName): (inlineTagList): (blockTagList): (HTMLElementImpl::inEitherTagList): (HTMLElementImpl::inInlineTagList): (HTMLElementImpl::inBlockTagList):
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::radioButtonChecked): (DOM::HTMLFormElementImpl::removeFormElement): (DOM::HTMLInputElementImpl::isKeyboardFocusable): (DOM::HTMLInputElementImpl::setInputType):
khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::setText): (HTMLTitleElementImpl::setText):
khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
khtml/html/htmlparser.cpp: (HTMLParser::getNode): (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
khtml/khtml_part.cpp: (KHTMLPart::findTextNext): (KHTMLPart::selectionComputedStyle):
khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
khtml/xml/dom2_eventsimpl.cpp: (EventImpl::EventImpl): (EventImpl::initEvent): (KeyboardEventImpl::KeyboardEventImpl): (KeyboardEventImpl::initKeyboardEvent): (MutationEventImpl::MutationEventImpl): (MutationEventImpl::initMutationEvent):
khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::equal):
khtml/xml/dom_atomicstring.h: (DOM::AtomicString::AtomicString): (DOM::AtomicString::impl): (DOM::AtomicString::equal):
khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): (DocumentImpl::impl): (DocumentImpl::createEntityReference): (DocumentImpl::importNode): (DocumentImpl::createAttributeNS):
khtml/xml/dom_docimpl.h: (DOM::DocumentTypeImpl::impl):
khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): (AttrImpl::setValue): (AttrImpl::childrenChanged): (ElementImpl::setAttribute): (ElementImpl::getAttributeNS): (ElementImpl::setAttributeNS): (ElementImpl::removeAttributeNS): (ElementImpl::getAttributeNodeNS): (ElementImpl::hasAttributeNS): (NamedAttrMapImpl::getNamedItemNS): (NamedAttrMapImpl::removeNamedItemNS): (StyledElementImpl::getMappedAttributeDecl): (StyledElementImpl::setMappedAttributeDecl): (StyledElementImpl::removeMappedAttributeDecl): (NamedMappedAttrMapImpl::parseClassAttribute): (StyledElementImpl::parseMappedAttribute): (StyledElementImpl::addCSSLength):
khtml/xml/dom_qname.cpp: (DOM::QNameHash::hash): (DOM::equalComponents): (DOM::QualifiedName::QualifiedName):
khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): (CharacterDataImpl::setData): (CharacterDataImpl::appendData): (CharacterDataImpl::insertData): (CharacterDataImpl::replaceData):
khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl): (DOM::ProcessingInstructionImpl::setData): (DOM::ProcessingInstructionImpl::checkStyleSheet):
khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
kwq/DOM-CSS.mm: (-[DOMDocument getComputedStyle::]):
kwq/DOM.mm: (-[DOMNode setPrefix:]): (-[DOMDocument implementation]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getOverrideStyle::]):
kwq/DOMHTML.mm: (-[DOMHTMLSelectElement setValue:]): (-[DOMHTMLOptionElement setValue:]):
kwq/DOMInternal.mm: (DOMString::DOMString):
kwq/KWQFontFamily.mm: (KWQFontFamily::getNSFamily):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::styleForSelectionStart):

2:10 PM Changeset in webkit [10387] by justing

2 edits in trunk/WebCore

Reviewed by john

Fixes <rdar://problem/4236218>
many leaks of StyleBaseImpl within -[WebCoreBridge markupStringFromRange:nodes:] within -[WebHTMLView copy:]

Test cases added: none, doesn't affect layout

khtml/editing/markup.cpp: (khtml::createMarkup): deref defaultStyle on the early return

11:00 AM Changeset in webkit [10386] by darin

10 edits in trunk/WebCore

Reviewed by John Sullivan.

fixed cases where I changed functions from string() to qstring() incorrectly

khtml/rendering/render_text.h: Change function name back to string().
khtml/xml/dom_textimpl.h: Ditto.

khtml/xml/dom_textimpl.cpp: (CommentImpl::nodeName): Call domString(), not qstring(). (TextImpl::nodeName): Ditto.

khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::deleteInsignificantText):
khtml/editing/selection.cpp: (khtml::Selection::debugRenderer):
khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextNode): (khtml::TextIterator::handleTextBox):
khtml/html/htmlparser.cpp: (HTMLParser::handleError):
khtml/rendering/render_text.cpp: (InlineTextBox::paint): (InlineTextBox::selectionStartEnd): (RenderText::originalString): (RenderTextFragment::originalString): Change callers back from qstring() to string().

10:42 AM Changeset in webkit [10385] by sullivan

6 edits in trunk/WebCore

Reviewed by Beth Dakin.

Test cases added: none, doesn't affect layout

fixed <rdar://problem/4232588> many leaks beneath ApplyStyleCommand::mergeEndWithNextIfIdentical, seen running webkit tests (probably affects Mail)

Fixed by making NodeImpl::childNodes() return a SharedPtr.

khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): use get() to get the pointer from the SharedPtr

khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): expect a SharedPtr for childNodes(); no need to delete at end of block. (This code was already managing memory correctly, but other callers of childNodes() where not.) (DOM::HTMLTableSectionElementImpl::deleteRow): ditto (DOM::HTMLTableRowElementImpl::insertCell): ditto (DOM::HTMLTableRowElementImpl::deleteCell): ditto

khtml/xml/dom_nodeimpl.h:
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): return SharedPtr

kwq/DOM.mm: (-[DOMNode childNodes]): use get() to get the pointer from the SharedPtr

9:51 AM Changeset in webkit [10384] by darin

2 edits in trunk/WebKitTools

Reviewed by John Sullivan.

Scripts/run-webkit-tests: Added a mode where each test is run with a separate executable -- much slower but can help pinpoint leaks. Changed formatting of some messages too.

12:23 AM Changeset in webkit [10383] by mjs

2 edits in trunk/WebKitTools

Reviewed by Eric.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4720 (webkit pixel tests don't give consistent results with changed scrollbar arrow setting)

DumpRenderTree/DumpRenderTree.m: (main): set scrollbar arrow setting to a consistent value

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed