Timeline



Sep 11, 2005:

9:42 PM Changeset in webkit [10524] by darin
  • 2 edits
    2 adds in trunk

Reviewed by John Sullivan.

  • fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent

Test cases added:

  • layout-tests/fast/events/access-key-self-destruct.html: Added.
  • layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration with a SharedPtr; this helps in cases where the last reference to the node goes away inside the event handler.
8:43 PM Changeset in webkit [10523] by darin
  • 1 edit in trunk/WebCore/khtml/xml/dom_atomicstringlist.h

Forgot to check this in (was mentioned in ChangeLog).

8:40 PM Changeset in webkit [10522] by darin
  • 7 edits in trunk/WebCore

Reviewed by Eric.

  • changed back the name of a couple of string() functions that were renamed to qstring() by accident
  • kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring(). This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.
  • khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current AtomicString to string() back from qstring()!
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring(). (khtml::checkPseudoState): Ditto. (khtml::CSSStyleSelector::checkOneSelector): Ditto.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed boolean instead of re-checking a couple of data members. (DOM::parseLength): Use string() instead of qstring(). (DOM::DOMStringImpl::toInt): Ditto.
  • removed some dead code
  • khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.
10:04 AM Changeset in webkit [10521] by darin
  • 6 edits in trunk

WebKit:

Reviewed, tweaked, and landed by Darin.

  • WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]): If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH is set in the environment, then unset DYLD_FRAMEWORK_PATH.
  • WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in configurations other than Default -- we don't want that code in production builds, but we want it in builds we do ourselves and nightly builds.

WebKitTools:

Reviewed, tweaked, and landed by Darin.

  • Scripts/run-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH.
  • Scripts/run-webkit-app: Ditto.
3:41 AM Changeset in webkit [10520] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 4932
Submitted by: eseidel
Reviewed by: self, only affects SVG; build fix.

2:28 AM Changeset in webkit [10519] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Oops. Use spaces, not tabs.
2:23 AM Changeset in webkit [10518] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/run-webkit-tests: Sort tests with a new "pathcmp" function that's better in two ways: 1) puts all files in a directory before any files in a subdirectory, and 2) sort file names with numeric digits in them in a logical way, so test-33 will come before test-3.

Sep 10, 2005:

10:27 PM Changeset in webkit [10517] by darin
  • 1 edit
    2 adds in trunk/JavaScriptCore

Reviewed and landed by Darin.

  • Makefile.vc: Added.
  • README-Win32.txt: Added.
2:33 PM Changeset in webkit [10516] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin.

Wasn't able to make a layout test for this because there's no easy way to
simulate separate writes to the tokenizer.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Rolled back to code more like the original KDE stuff -- our change broke this -- but changed the limit so it works with 8-character entities.
2:22 PM Changeset in webkit [10515] by darin
  • 1 edit
    2 deletes in trunk
  • remove test case I just added -- it's not working
  • layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Removed.
  • layout-tests/fast/dom/document-write-infinite-recursion.html: Removed.
2:03 PM Changeset in webkit [10514] by darin
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

Test cases added:

  • layout-tests/fast/parser/area-in-div.html: Added.
  • layout-tests/fast/parser/area-in-div-expected.txt: Added.
  • khtml/html/htmlparser.h: Declared mapCreateErrorCheck.
  • khtml/html/htmlparser.cpp: (HTMLParser::handleError): Fix formatting and indentation. (HTMLParser::formCreateErrorCheck): Added code to create the form too, so we can squirrel the form pointer away. Return false to prevent the factory from creating it. (HTMLParser::mapCreateErrorCheck): Added. Same kind of thing here, but without the logic that prevents creating a form if there's already a form open. (HTMLParser::getNode): Added the code to put the map function into the table. Also removed the form special-case code here that accomplishes what is now done inside the formCreateErrorCheck above instead.
1:47 PM Changeset in webkit [10513] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Maciej.

Test cases added:

  • layout-tests/fast/dom/document-write-infinite-recursion.html: Added.
  • layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose): Simplify a bit to make more readable. Remove the code to delete the tokenizer an extra time -- that can end up deleting the newly created tokenizer that's still needed for the newly opened page. (DocumentImpl::write): Added an assertion to catch the badness that caused infinite recursion so it's easier to recognize next time.
12:10 PM Changeset in webkit [10512] by darin
  • 2 edits in trunk/JavaScriptCore
  • fixed compilation for WebCore (another try)
  • kjs/simple_number.h: Added more "using" lines.
11:58 AM Changeset in webkit [10511] by darin
  • 2 edits in trunk/JavaScriptCore
  • fixed compilation for WebCore
  • kjs/simple_number.h: Have to include <cmath> here to work around a bug in the GCC standard C++ library headers.
11:24 AM Changeset in webkit [10510] by darin
  • 5 edits in trunk/JavaScriptCore

Windows changes by Krzysztof Kowalczyk <​kkowalczyk@gmail.com>.

  • kjs/simple_number.h: (KJS::isNegativeZero): Added. Inline function. Has a case for Windows that uses _fpclass and a case for other platforms that uses signbit. (KJS::SimpleNumber::fits): Use inline isNegativeZero instead of macro IS_NEGATIVE_ZERO.
  • kjs/internal.cpp: Remove definition of now-unneeded negZero global.
  • kjs/value.cpp: Touched the file because Xcode didn't know it needed to recompile it.
  • improved test engine
  • tests/mozilla/jsDriver.pl: Sort tests in numeric order instead of using a plain-ASCII sort; now test 33 will be after test 5 in any given set of numbered tests.
10:36 AM Changeset in webkit [10509] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): Removed unused local variable.
9:50 AM Changeset in webkit [10508] by darin
  • 1 edit
    1 add in trunk
  • add expected success result for newly-enabled test
  • layout-tests/dom/html/level2/html/HTMLIFrameElement11-expected.txt: Added.

Sep 9, 2005:

11:10 PM Changeset in webkit [10507] by vicki
  • 3 edits
    4 adds in trunk

Reviewed by Dave Hyatt.

  • fix <rdar://problem/4234256> REGRESSION: image tag broken in TOT

Test cases added:

  • layout-tests/fast/replaced/image-tag-expected.checksum: Added.
  • layout-tests/fast/replaced/image-tag-expected.png: Added.
  • layout-tests/fast/replaced/image-tag-expected.txt: Added.
  • layout-tests/fast/replaced/image-tag.html: Added.
  • khtml/html/htmlnames.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
3:14 PM Changeset in webkit [10506] by tomernic
  • 3 edits
    1 add in trunk/WebKit

Reviewed by John Sullivan.

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): SPI to remove a given WebHistoryItem.
  • History.subproj/WebBackForwardListPrivate.h: Added.
  • WebKit.xcodeproj/project.pbxproj: Added WebBackForwardListPrivate.h as a private header.
11:34 AM Changeset in webkit [10505] by sullivan
  • 4 edits in trunk

WebCore:

Reviewed by Tim Omernick.

Test cases added: none, doesn't affect layout

  • fixed <rdar://problem/4250792> Find in HTML doesn't reveal match if only match was already selected
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): If we end up finding the previously-selected text, just go through the normal success code path instead of bailing out early.

WebKit:

Reviewed by Tim Omernick.

fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4070:
Find in plain text won't find only occurrence if it overlaps selection

  • Misc.subproj/WebSearchableTextView.m: (-[NSString findString:selectedRange:options:wrap:]): in the wrap case, extend the search range far enough that text overlapping the selection (including the exact-match case) will be considered.
11:30 AM Changeset in webkit [10504]
  • 227 copies
    14 deletes in tags/WebCore-416~7

This commit was manufactured by cvs2svn to create tag
'WebCore-416~7'.

11:30 AM Changeset in webkit [10503]
  • 344 copies
    33 deletes in branches/Safari-Den-branch

This commit was manufactured by cvs2svn to create branch
'Safari-Den-branch'.

11:30 AM Changeset in webkit [10502]
  • 344 copies
    33 deletes in tags/Safari-Den-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-Den-anchor'.

11:30 AM Changeset in webkit [10501] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for Safari-2-0-branch - WebCore-416.7

11:29 AM Changeset in webkit [10500]
  • 49 copies
    22 deletes in tags/WebKit-416~7

This commit was manufactured by cvs2svn to create tag 'WebKit-416~7'.

11:29 AM Changeset in webkit [10499] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning for Safari-2-0-branch - WebKit-416.7

10:49 AM Changeset in webkit [10498] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-07 Vicki Murley <​vicki@apple.com>

Reviewed by Justin.

  • fix <rdar://problem/4246096> REGRESSION links to named anchors don't scroll to the right place (4825)

This is really just a better fix for 4233844. Also consolidated manual-tests/scrollToAnchorWithNewline.html
and the test case from Bugzilla bug 4825 into manual-tests/scrollToAnchor.html.

Test cases added:

  • manual-tests/scrollToAnchor.html: Added.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): when calculating scroll position, skip child nodes of the anchor if they do not have text boxes.
10:17 AM Changeset in webkit [10497] by adele
  • 20 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-09-08 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin

WebCore portion of multipart/x-mixed-replace support

  • khtml/misc/loader.cpp: (Request::Request): (Loader::slotReceivedResponse): Only allow a multipart load for images, clear out the old multipart section to prepare for a replace (Loader::slotData): Multipart sections are delivered to the coreLoader by WebKit all at once, send eof to CachedImage::data
  • khtml/misc/loader.h: (khtml::CachedObject::isImage): Added (khtml::CachedImage::isImage):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::cancel): Added a way to cancel a subresource loader from WebCore
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseIsMultipart):
  • kwq/KWQResourceLoader.h:
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader jobCanceledLoad]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

2005-09-08 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin

WebKit portion of multipart/x-mixed-replace support

  • WebCoreSupport.subproj/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Subresource case: Check for Foundation level multipart support (-[WebSubresourceLoader didReceiveResponse:]): Send previously received data in a multipart section to the coreLoader (-[WebSubresourceLoader didReceiveData:lengthReceived:]): Don't send data to the coreLoader until it has been completely received
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): Main resource case: check for Foundation level multipart support (+[WebDataSource _repTypesAllowImageTypeOmission:]): Some server apps send data right after declaring content multipart/x-mixed-replace, and expect it to be treated as html (-[WebDataSource _commitIfReady:]): Don't ask the WebFrame to close its old WebDataSource when loading a multipart section, because we're going to reuse it (-[WebDataSource _receivedData:]): For non text/html multipart sections, we commit the data all at once, at the end (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): Added heuristic for when to commit the load incrementally (-[WebDataSource _commitLoadWithData:]): Moved from _receivedData into its own function (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): Commits the data received for the previous multipart section if it wasn't loaded progresively, clears out the WebFrame and WebDatasource for the next multipart section
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): The very first multipart section is treated as a normal load, so that the back/forward list and history are updated. All later sections have a new load type, WebFrameLoadTypeReplace, and are treated like reloads (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto (-[WebFrame _itemForRestoringDocState]): Ditto (-[WebFrame _setupForReplace]): Clears out the WebFrame for the next multipart section
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): See above
  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol clearResourceData]): (-[NSURLProtocol setSupportsMultipartContent:]):
  • WebView.subproj/WebMainResourceLoader.m: Straightforward (-[WebMainResourceLoader didReceiveResponse:]):

Sep 8, 2005:

6:19 PM Changeset in webkit [10496] by darin
  • 3 edits in trunk/JavaScriptCore
  • fixed overloaded versions of throwError so that they substitute *all* expected parameters into the message string -- some versions used to skip parameters, resulting in "%s" being printed in the error message.

Reviewed by Geoff.

  • kjs/nodes.h: Updated declarations to use "const &" and not to name parameters
  • kjs/nodes.cpp: (Node::throwError): Updated to match above and add one missing call to substitute.
5:51 PM Changeset in webkit [10495] by darin
  • 9 edits
    22 adds
    5 deletes in trunk/JavaScriptCore

Reviewed by Geoff.

  • updated to PCRE 6.1

The original PCRE 6.1 sources are checked into the tree with the tag
"pcre-6-1" for reference. What we're checking in right now is the original
plus our changes to make it support UTF-16 and at least one other tweak
(vertical tab considered whitespace). Our work to get our changes was
done on "pcre-6-1-branch", with an anchor at "pcre-6-1-anchor" so you can
see the evolution of the UTF-16 changes.

Note also that there was one small change made here that's not on the branch
in pcre_compile.c.

  • Info.plist: Updated the part of the copyright message that's about PCRE.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new PCRE source files, removed obsolete ones.
  • pcre/AUTHORS: Updated to PCRE 6.1. Includes credits for Apple's UTF-16 changes, but not the credits for Google's C++ wrapper, since we don't include that.
  • pcre/COPYING: Updated to PCRE 6.1.
  • pcre/LICENCE: Ditto.
  • pcre/dftables.c: Ditto.
  • pcre/pcre-config.h: Ditto.
  • pcre/pcre.h: Ditto.
  • pcre/pcre_compile.c: Added for PCRE 6.1.
  • pcre/pcre_config.c: Ditto.
  • pcre/pcre_exec.c: Ditto.
  • pcre/pcre_fullinfo.c: Ditto.
  • pcre/pcre_get.c: Ditto.
  • pcre/pcre_globals.c: Ditto.
  • pcre/pcre_info.c: Ditto.
  • pcre/pcre_internal.h: Ditto.
  • pcre/pcre_maketables.c: Ditto.
  • pcre/pcre_ord2utf8.c: Ditto.
  • pcre/pcre_printint.c: Ditto.
  • pcre/pcre_refcount.c: Ditto.
  • pcre/pcre_study.c: Ditto.
  • pcre/pcre_tables.c: Ditto.
  • pcre/pcre_try_flipped.c: Ditto.
  • pcre/pcre_ucp_findchar.c: Ditto.
  • pcre/pcre_version.c: Ditto.
  • pcre/pcre_xclass.c: Ditto.
  • pcre/ucp.h: Ditto.
  • pcre/ucp_findchar.c: Ditto.
  • pcre/ucpinternal.h: Ditto.
  • pcre/ucptable.c: Ditto.
  • pcre/get.c: Removed.
  • pcre/internal.h: Removed.
  • pcre/maketables.c: Removed.
  • pcre/pcre.c: Removed.
  • pcre/study.c: Removed.
5:16 PM Changeset in webkit [10494] by darin
  • 1 edit in branches/pcre-6-1-branch/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Merge with TOT.

5:15 PM Changeset in webkit [10493] by darin
  • 1 edit in branches/pcre-6-1-branch/JavaScriptCore/pcre/pcre_compile.c

Took out one unnecessary and incorrect UTF-16 code path for escaped
characters -- the UTF-8 code path already correctly computes the length.

Also fixed one place to use a more efficient manner to compute the length
of a UTF-8 sequence.

3:54 PM Changeset in webkit [10492] by vicki
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fixed <rdar://problem/4168089> CRASH: Using A9 Maps new interface (also occurs on google maps)
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::getAttributeNS): add a check for the document, before checking to see if this is an HTML document
2:38 PM Changeset in webkit [10491] by justing
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by darin

  • Scripts/update-webkitsysteminterface: Added. Builds webkitsysteminterface and moves the built product and header into WebKitLibraries
2:35 PM Changeset in webkit [10490] by justing
  • 9 edits in trunk/WebCore

Reviewed by darin

WebCore portion of multipart/x-mixed-replace support

  • khtml/misc/loader.cpp: (Request::Request): (Loader::slotReceivedResponse): Only allow a multipart load for images, clear out the old multipart section to prepare for a replace (Loader::slotData): Multipart sections are delivered to the coreLoader by WebKit all at once, send eof to CachedImage::data
  • khtml/misc/loader.h: (khtml::CachedObject::isImage): Added (khtml::CachedImage::isImage):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::cancel): Added a way to cancel a subresource loader from WebCore
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseIsMultipart):
  • kwq/KWQResourceLoader.h:
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader jobCanceledLoad]):
2:35 PM Changeset in webkit [10489] by justing
  • 11 edits in trunk/WebKit

Reviewed by darin

WebKit portion of multipart/x-mixed-replace support

  • WebCoreSupport.subproj/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Subresource case: Check for Foundation level multipart support (-[WebSubresourceLoader didReceiveResponse:]): Send previously received data in a multipart section to the coreLoader (-[WebSubresourceLoader didReceiveData:lengthReceived:]): Don't send data to the coreLoader until it has been completely received
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): Main resource case: check for Foundation level multipart support (+[WebDataSource _repTypesAllowImageTypeOmission:]): Some server apps send data right after declaring content multipart/x-mixed-replace, and expect it to be treated as html (-[WebDataSource _commitIfReady:]): Don't ask the WebFrame to close its old WebDataSource when loading a multipart section, because we're going to reuse it (-[WebDataSource _receivedData:]): For non text/html multipart sections, we commit the data all at once, at the end (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): Added heuristic for when to commit the load incrementally (-[WebDataSource _commitLoadWithData:]): Moved from _receivedData into its own function (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): Commits the data received for the previous multipart section if it wasn't loaded progresively, clears out the WebFrame and WebDatasource for the next multipart section
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): The very first multipart section is treated as a normal load, so that the back/forward list and history are updated. All later sections have a new load type, WebFrameLoadTypeReplace, and are treated like reloads (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto (-[WebFrame _itemForRestoringDocState]): Ditto (-[WebFrame _setupForReplace]): Clears out the WebFrame for the next multipart section
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): See above
  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol clearResourceData]): (-[NSURLProtocol setSupportsMultipartContent:]):
  • WebView.subproj/WebMainResourceLoader.m: Straightforward (-[WebMainResourceLoader didReceiveResponse:]):
2:33 PM Changeset in webkit [10488] by justing
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Update to latest
  • libWebKitSystemInterface.a: ditto
2:29 PM Changeset in webkit [12198] by adele
  • 2 edits in branches/Safari-2-0-branch/JavaScriptGlue

Versioning for Safari-2-0-branch - Safari-416.6 (JavaScriptGlue)

1:52 PM Changeset in webkit [12197] by adele
  • 2 edits in branches/Safari-2-0-branch/JavaScriptGlue

Versioning for Safari-2-0-branch - JavaScriptGlue-17

1:42 PM Changeset in webkit [12196] by adele
  • 3 edits
    1 delete in branches/Safari-2-0-branch/JavaScriptGlue

Reviewed by Geoff and Tim.

Converting project to XCode 2.1 on the Safari-2-0-branch

  • JavaScriptGlue.pbproj/project.pbxproj: Removed.
  • JavaScriptGlue.xcodeproj/.cvsignore: Added.
  • JavaScriptGlue.xcodeproj/project.pbxproj: Added.
1:42 PM Changeset in webkit [12195]
  • 1 copy in branches/Safari-2-0-branch/JavaScriptGlue/JavaScriptGlue.xcodeproj

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

12:57 PM Changeset in webkit [10487] by vicki
  • 2 edits
    1 add
    1 delete in trunk

Reviewed by Don Melton.

  • layout-tests/dom/html/level2/html/HTMLIFrameElement11.js: check for correct title of resources/frame.html
  • layout-tests/dom/html/level2/html/HTMLIFrameElement11.html: Added.
  • layout-tests/dom/html/level2/html/HTMLIFrameElement11.html-disabled: Removed.
11:05 AM Changeset in webkit [10486] by ggaren
  • 2 edits in trunk/WebCore

-fixed gcc 4.0 build bustage due to inconsitent return type

Reviewed by john.

  • kwq/KWQTextField.mm: (-[NSTextField _KWQ_currentEditor]): editor is now cast as an NSTextView instead of an NSText (which makes sense regardless of build bustage, given that we first test for isKindOfClass:[NSTextView class] before defining editor)
1:03 AM Changeset in webkit [10485] by eseidel
  • 119 edits
    7 adds in trunk

Bug #: 4863
Submitted by: eseidel
Reviewed by: darin

Merged various changes from KDE, including:
Qt3->Qt4 change: QWMatrix -> QMatrix
A few remaining DOMString -> DOMStringImpl changes
KRenderingDevicePaintServer now inherits KCanvasResource
Various whitespace adjustments.
Fewer, clearer logs from kcanvas/device/quartz code.
DOM exception support.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4863

  • ForwardingHeaders/qmatrix.h: Added.
  • WebCore+SVG/DrawDocument.mm: (-[DrawDocumentPrivate init]): (-[DrawDocumentPrivate dealloc]): (-[DrawDocumentPrivate setPrimaryView:]):
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvas.cpp: (KCanvas::~KCanvas): (KCanvas::reset):
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::bbox): (KCanvasContainer::collisions): (KCanvasContainer::first): (KCanvasContainer::last):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasMatrix.cpp: (KCanvasMatrix::KCanvasMatrix): (KCanvasMatrix::operator=): (KCanvasMatrix::operator==): (KCanvasMatrix::operator!=): (KCanvasMatrix::translate): (KCanvasMatrix::multiply): (KCanvasMatrix::scale): (KCanvasMatrix::rotate): (KCanvasMatrix::rotateFromVector): (KCanvasMatrix::skewX): (KCanvasMatrix::skewY): (KCanvasMatrix::qmatrix):
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasRegistry.cpp: (operator<<):
  • kcanvas/KCanvasRegistry.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasResource::KCanvasResource): (KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasView.cpp: (KCanvasView::setCanvas):
  • kcanvas/KCanvasView.h:
  • kcanvas/device/KRenderingFillPainter.cpp: (KRenderingFillPainter::draw):
  • kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KRenderingPaintServerGradient::Private::Private): (KRenderingPaintServerGradient::KRenderingPaintServerGradient): (KRenderingPaintServerGradient::listener): (KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::Private::Private): (KRenderingPaintServerPattern::KRenderingPaintServerPattern): (KRenderingPaintServerPattern::listener): (KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingStrokePainter.cpp: (KRenderingStrokePainter::setPaintServer): (KRenderingStrokePainter::draw):
  • kcanvas/device/KRenderingStyle.cpp: (KRenderingStyle::Private::Private):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (cgGradientCallback): (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerImageQuartz::draw):
  • kdom/KDOMSettings.cpp: (KDOMSettings::init): (KDOMSettings::strToAdvice):
  • kdom/Shared.h: (KDOM::KDOM_SAFE_SET):
  • kdom/backends/libxml/LibXMLParser.cpp: (sax_start_doc): (sax_internal_subset): (sax_entity_decl):
  • kdom/bindings/IDLParser.pm:
  • kdom/bindings/IDLStructure.pm:
  • kdom/cache/KDOMCache.h:
  • kdom/cache/KDOMCachedObject.h:
  • kdom/cache/KDOMLoader.cpp: (DocumentLoader::setAutoloadImages):
  • kdom/cache/KDOMLoader.h:
  • kdom/core/AttrImpl.cpp: (AttrImpl::value): (AttrImpl::setPrefix):
  • kdom/core/DOMConfigurationImpl.cpp: (DOMConfigurationImpl::normalizeCharacters):
  • kdom/core/DOMImplementationImpl.cpp: (DOMImplementationImpl::DOMImplementationImpl): (DOMImplementationImpl::createDocument): (DOMImplementationImpl::idToType):
  • kdom/core/DOMImplementationImpl.h:
  • kdom/core/DocumentImpl.cpp: (DocumentImpl::removeListenerType): (DocumentImpl::getId):
  • kdom/core/DocumentTypeImpl.cpp: (DocumentTypeImpl::internalSubset):
  • kdom/core/NamedAttrMapImpl.cpp: (NamedAttrMapImpl::setValue): (NamedAttrMapImpl::dispatchAttrMutationEvent):
  • kdom/core/NamedNodeMapImpl.cpp: (RONamedNodeMapImpl::getNamedItem):
  • kdom/core/NodeImpl.cpp: (NodeBaseImpl::removeChildren): (NodeImpl::lookupNamespaceURI):
  • kdom/core/ProcessingInstructionImpl.cpp: (ProcessingInstructionImpl::ProcessingInstructionImpl): (ProcessingInstructionImpl::~ProcessingInstructionImpl):
  • kdom/core/ProcessingInstructionImpl.h:
  • kdom/core/domattrs.c:
  • kdom/css/CSSPrimitiveValueImpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl):
  • kdom/css/CSSStyleRuleImpl.cpp: (CSSStyleRuleImpl::parseString):
  • kdom/css/CSSStyleRuleImpl.h:
  • kdom/css/CSSStyleSelector.cpp: (CSSStyleSelector::CSSStyleSelector): (CSSStyleSelector::styleForElement): (CSSStyleSelector::applyRule): (CSSStyleSelector::getLangAttribute):
  • kdom/css/CSSStyleSelector.h:
  • kdom/css/CSSStyleSheetImpl.cpp: (CSSStyleSheetImpl::type):
  • kdom/css/CSSValueImpl.cpp: (ShadowValueImpl::cssText):
  • kdom/css/Font.h:
  • kdom/css/LinkStyleImpl.cpp: Added. (LinkStyleImpl::LinkStyleImpl): (LinkStyleImpl::~LinkStyleImpl): (LinkStyleImpl::sheet):
  • kdom/css/LinkStyleImpl.h: Added.
  • kdom/css/MediaListImpl.cpp: (MediaListImpl::setMediaText):
  • kdom/css/RectImpl.cpp:
  • kdom/css/RectImpl.h: (KDOM::RectImpl::top): (KDOM::RectImpl::right): (KDOM::RectImpl::bottom): (KDOM::RectImpl::left):
  • kdom/css/RenderStyle.cpp: (RenderStyle::diff):
  • kdom/css/RenderStyle.h:
  • kdom/css/RenderStyleDefs.cpp: (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==):
  • kdom/css/RenderStyleDefs.h:
  • kdom/css/StyleBaseImpl.cpp: (CSSSelector::print): (CSSSelector::extractPseudoType):
  • kdom/events/EventTargetImpl.cpp: (EventTargetImpl::addEventListener):
  • kdom/kdom.h: (KDOM::):
  • kdom/ls/DOMImplementationLSImpl.cpp: Added. (DOMImplementationLSImpl::DOMImplementationLSImpl): (DOMImplementationLSImpl::~DOMImplementationLSImpl): (DOMImplementationLSImpl::createLSParser): (DOMImplementationLSImpl::createLSInput): (DOMImplementationLSImpl::createLSOutput): (DOMImplementationLSImpl::createLSSerializer):
  • kdom/ls/DOMImplementationLSImpl.h: Added.
  • kdom/ls/LSParserImpl.cpp: (LSParserImpl::parseURI):
  • kdom/ls/LSParserImpl.h:
  • kdom/ls/LSResourceResolverImpl.cpp: (LSResourceResolverImpl::resolveResource):
  • kdom/ls/LSResourceResolverImpl.h:
  • kdom/ls/LSSerializerImpl.cpp: (LSSerializerImpl::newLine): (LSSerializerImpl::writeToString): (LSSerializerImpl::escape): (LSSerializerImpl::escapeAttribute):
  • kdom/ls/LSSerializerImpl.h:
  • kdom/parser/KDOMParser.cpp: (Parser::handleError): (Parser::bufferForUrl):
  • kdom/range/RangeImpl.cpp: (RangeImpl::toString):
  • kdom/range/RangeImpl.h:
  • kdom/scripts/cssmakeprops:
  • kdom/scripts/cssmakevalues:
  • kdom/xpointer/PointerPartImpl.cpp: (PointerPartImpl::PointerPartImpl):
  • kdom/xpointer/ShortHandImpl.cpp: (ShortHandImpl::ShortHandImpl):
  • kdom/xpointer/XPointerEvaluatorImpl.cpp: (XPointerEvaluatorImpl::createXPointer):
  • kdom/xpointer/XPointerResultImpl.h:
  • kdom/xpointer/kdomxpointer.h: (KDOM::XPointer::):
  • ksvg2/KSVGFactory.cpp: (KSVGFactory::createPartObject):
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/events/SVGEventImpl.cpp: (SVGEventImpl::SVGEventImpl): (SVGEventImpl::initEvent):
  • ksvg2/events/SVGEventImpl.h: (KSVG::):
  • ksvg2/events/SVGZoomEventImpl.cpp: (SVGZoomEventImpl::SVGZoomEventImpl):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateFill): (KCanvasRenderingStyle::updateStroke): (KCanvasRenderingStyle::startMarker): (KCanvasRenderingStyle::midMarker): (KCanvasRenderingStyle::endMarker): (KCanvasRenderingStyle::filter):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.cpp: Added. (SVGCursorElementImpl::SVGCursorElementImpl): (SVGCursorElementImpl::~SVGCursorElementImpl): (SVGCursorElementImpl::x): (SVGCursorElementImpl::y): (SVGCursorElementImpl::parseAttribute): (SVGCursorElementImpl::notifyFinished):
  • ksvg2/svg/SVGCursorElementImpl.h: Added. (KSVG::SVGCursorElementImpl::pixmap):
  • ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::hasFeature): (SVGDOMImplementationImpl::createDocumentType): (SVGDOMImplementationImpl::createDocument): (SVGDOMImplementationImpl::typeToId): (SVGDOMImplementationImpl::idToType):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl): (SVGDocumentImpl::createSVGElement): (SVGDocumentImpl::createElement): (SVGDocumentImpl::createElementNS): (SVGDocumentImpl::createEvent): (SVGDocumentImpl::notifyFinished): (SVGDocumentImpl::defaultNS): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::prepareMouseEvent): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::getId): (SVGElementImpl::xmlbase): (SVGElementImpl::tryGetAttribute): (SVGElementImpl::tryGetAttributeNS): (SVGElementImpl::parseAttribute): (SVGElementImpl::addSVGEventListener):
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::parseAttribute):
  • ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished):
  • ksvg2/svg/SVGLengthListImpl.cpp: (SVGLengthListImpl::parse):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::x2):
  • ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl): (SVGMatrixImpl::postMultiply): (SVGMatrixImpl::postTranslate): (SVGMatrixImpl::postScale): (SVGMatrixImpl::postScaleNonUniform): (SVGMatrixImpl::postRotate): (SVGMatrixImpl::postRotateFromVector): (SVGMatrixImpl::postFlipX): (SVGMatrixImpl::postFlipY): (SVGMatrixImpl::postSkewX): (SVGMatrixImpl::postSkewY): (SVGMatrixImpl::multiply): (SVGMatrixImpl::setMatrix): (SVGMatrixImpl::qmatrix):
  • ksvg2/svg/SVGMatrixImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::parseAttribute):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::width): (SVGSVGElementImpl::height): (SVGSVGElementImpl::contentScriptType): (SVGSVGElementImpl::contentStyleType): (SVGSVGElementImpl::setContentStyleType): (SVGSVGElementImpl::createEvent):
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::parseAttribute): (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGScriptElementImpl.h:
  • ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGStyleElementImpl.cpp: (SVGStyleElementImpl::xmlspace): (SVGStyleElementImpl::type): (SVGStyleElementImpl::media): (SVGStyleElementImpl::title): (SVGStyleElementImpl::childrenChanged):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attach):
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::updateSubtreeMatrices): (SVGTransformableImpl::parseAttribute): (SVGTransformableImpl::parseTransformAttribute):
  • ksvg2/svg/SVGTransformableImpl.h:
  • kwq/KWQNamespace.h: (Qt::): Added LayoutDirection for Qt4 support
  • kwq/KWQWMatrix.h: #define mapping QMatrix to QWMatrix

Sep 7, 2005:

4:27 PM Changeset in webkit [10484] by ggaren
  • 1 edit
    2 adds in trunk

-added layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
Date.setMonth fails with big values due to overflow

Fix is in JavaScriptCore.

Test cases added:

  • layout-tests/fast/js/date-big-setmonth-expected.txt: Added.
  • layout-tests/fast/js/date-big-setmonth.html: Added.
4:27 PM Changeset in webkit [10483] by ggaren
  • 2 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
Date.setMonth fails with big values due to overflow

Reviewed by darin.

  • kjs/date_object.cpp: (timetUsingCF): for consistency, changed return statement to invalidDate instead of LONG_MAX (KJS::fillStructuresUsingTimeArgs): modified for readability (KJS::fillStructuresUsingDateArgs): new function analogous to fillStructuresUsingTimeArgs (KJS::DateProtoFuncImp::callAsFunction): modified to use fillStructuresUsingDateArgs (KJS::DateObjectImp::construct): moved variable declaration to proper scope (KJS::DateObjectFuncImp::callAsFunction): moved variable declaration to proper scope
3:08 PM Changeset in webkit [10482] by ggaren
  • 2 edits in trunk/JavaScriptCore

-updated expected test results to reflect fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
kjs does not allow named functions in function expressions

  • tests/mozilla/expected.html:
11:10 AM Changeset in webkit [10481] by vicki
  • 2 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Justin.

  • fix <rdar://problem/4246096> REGRESSION links to named anchors don't scroll to the right place (4825)

This is really just a better fix for 4233844. Also consolidated manual-tests/scrollToAnchorWithNewline.html
and the test case from Bugzilla bug 4825 into manual-tests/scrollToAnchor.html.

Test cases added:

  • manual-tests/scrollToAnchor.html: Added.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): when calculating scroll position, skip child nodes of the anchor if they do not have text boxes.
1:00 AM Changeset in webkit [10480] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 4868
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createCanvasPathData):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::contextForImage):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): Fixed several leaks. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4868
Note: See TracTimeline for information about the timeline view.