Timeline



Sep 15, 2005:

11:36 PM Changeset in webkit [10544] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4907
Submitted by: eseidel
Reviewed by: mjs

  • khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded): One line change to prevent adding text objects as direct children to FrameSet objects in the render tree.
7:54 PM Changeset in webkit [10543] by mjs
  • 40 edits in branches/Safari-Den-branch

JavaScriptCore:

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Also added assertions to ensure that the locking rules are followed for the relevant
resources.

  • Makefile.am:
  • bindings/NP_jsobject.cpp: (identifierFromNPIdentifier): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
  • bindings/jni/jni_jsobject.cpp: (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::convertJObjectToValue):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/runtime.cpp: (Instance::createRuntimeObject):
  • bindings/runtime_root.h:
  • bindings/testbindings.cpp: (main):
  • bindings/testbindings.mm: (main):
  • kjs/fast_malloc.cpp: (KJS::kjs_fast_malloc): (KJS::kjs_fast_calloc): (KJS::kjs_fast_free): (KJS::kjs_fast_realloc):
  • kjs/fast_malloc.h:
  • kjs/identifier.h:
  • kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::mark): (InterpreterImp::checkSyntax): (InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::globalObject):
  • kjs/interpreter.cpp: (Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock):
  • kjs/nodes.h:
  • kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::~ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::~ProtectedObject): (KJS::ProtectedObject::operator=): (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=):
  • kjs/protected_object.h:
  • kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount):
  • kjs/string_object.cpp: (StringObjectImp::StringObjectImp):
  • kjs/testkjs.cpp: (main):

WebCore:

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Added assertions to ensure that main_thread_malloc and friends are
only called on the main thread.

Also changed main_thread_free to schedule a free on the main
thread if called from a background thread. This contingency is
rare, but unavoidable in the case that JavaScript runs on
background threads, since then objects can be garbage collected on
any thread.

Test cases added: Node, this is impossible to reproduce in Safari without the use of
PAC files.

  • Makefile.am:
  • khtml/dom/dom_misc.h:
  • khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::~KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_window.cpp: (Window::clear): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
  • khtml/misc/main_thread_malloc.cpp: (khtml::main_thread_malloc): (khtml::main_thread_calloc): (khtml::main_thread_free): (khtml::main_thread_realloc): (khtml::initialize_scheduled_free_list): (khtml::drain_scheduled_free_list): (khtml::schedule_free_on_main_thread): (khtml::public_fREe):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQPageState.mm: (-[KWQPageState clear]):
  • kwq/KWQTimer.h:
  • kwq/KWQTimer.mm: (-[KWQMainThreadPerformTarget initWithFunction:]): (-[KWQMainThreadPerformTarget callFunction:]): (QTimer::immediateSingleShotOnMainThread):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
7:34 PM Changeset in webkit [10542] by mjs
  • 40 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Also added assertions to ensure that the locking rules are followed for the relevant
resources.

  • Makefile.am:
  • bindings/NP_jsobject.cpp: (identifierFromNPIdentifier): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
  • bindings/jni/jni_jsobject.cpp: (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::convertJObjectToValue):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/runtime.cpp: (Instance::createRuntimeObject):
  • bindings/runtime_root.h:
  • bindings/testbindings.cpp: (main):
  • bindings/testbindings.mm: (main):
  • kjs/fast_malloc.cpp: (KJS::kjs_fast_malloc): (KJS::kjs_fast_calloc): (KJS::kjs_fast_free): (KJS::kjs_fast_realloc):
  • kjs/fast_malloc.h:
  • kjs/identifier.h:
  • kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::mark): (InterpreterImp::checkSyntax): (InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::globalObject):
  • kjs/interpreter.cpp: (Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock):
  • kjs/nodes.h:
  • kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::~ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::~ProtectedObject): (KJS::ProtectedObject::operator=): (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=):
  • kjs/protected_object.h:
  • kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount):
  • kjs/string_object.cpp: (StringObjectImp::StringObjectImp):
  • kjs/testkjs.cpp: (main):

WebCore:

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Added assertions to ensure that main_thread_malloc and friends are
only called on the main thread.

Also changed main_thread_free to schedule a free on the main
thread if called from a background thread. This contingency is
rare, but unavoidable in the case that JavaScript runs on
background threads, since then objects can be garbage collected on
any thread.

Test cases added: Node, this is impossible to reproduce in Safari without the use of
PAC files.

  • Makefile.am:
  • khtml/dom/dom_misc.h:
  • khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::~KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_window.cpp: (Window::clear): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
  • khtml/misc/main_thread_malloc.cpp: (khtml::main_thread_malloc): (khtml::main_thread_calloc): (khtml::main_thread_free): (khtml::main_thread_realloc): (khtml::initialize_scheduled_free_list): (khtml::drain_scheduled_free_list): (khtml::schedule_free_on_main_thread): (khtml::public_fREe):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQPageState.mm: (-[KWQPageState clear]):
  • kwq/KWQTimer.h:
  • kwq/KWQTimer.mm: (-[KWQMainThreadPerformTarget initWithFunction:]): (-[KWQMainThreadPerformTarget callFunction:]): (QTimer::immediateSingleShotOnMainThread):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
7:31 PM Changeset in webkit [12199] by mjs
  • 5 edits in branches/Safari-2-0-branch/JavaScriptGlue

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

  • JSUtils.cpp: (CFStringToUString): (JSObjectKJSValue): (KJSValueToCFTypeInternal):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JavaScriptGlue.cpp: (JSCollect):
4:50 PM Changeset in webkit [10541] by harrison
  • 4 edits
    4 adds in trunk

Reviewed by Dave Hyatt.

<rdar://problem/4244976> reproducible hang at ocharleys.com in VisiblePosition::initDownstream

Problem is that RenderText::nextOffset() passes an empty string the UBreakIterator, which returns
UBRK_DONE (-1) from ubrk_following, and that -1 is used without question as return result of
nextOffset(). Fixed by checking for UBRK_DONE and returning offset+1 in that case. Similar
change in RenderText::previousOffset().

Test cases added:

  • layout-tests/editing/selection/extend-by-word-002-expected.checksum: Added.
  • layout-tests/editing/selection/extend-by-word-002-expected.png: Added.
  • layout-tests/editing/selection/extend-by-word-002-expected.txt: Added.
  • layout-tests/editing/selection/extend-by-word-002.html: Added.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter): Added comments. Slight format adjustments.
  • khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Slight format adjustment.

(RenderText::previousOffset):
(RenderText::nextOffset):
Check for UBRK_DONE.

(RenderTextFragment::RenderTextFragment)
(RenderTextFragment::RenderTextFragment)
Fixed parameter names.

(m_generatedContentStr):

  • khtml/rendering/render_text.h: Fixed parameter names in the two RenderTextFragment constructors.

Sep 14, 2005:

10:22 PM Changeset in webkit [10540] by darin
  • 2 edits
    2 adds in trunk

Reviewed, tweaked, and landed by Darin.

Test cases added:

  • layout-tests/fast/encoding/xml-utf-8-default.xml: Added.
  • layout-tests/fast/encoding/xml-utf-8-default-expected.txt: Added.
  • khtml/misc/decoder.cpp: (Decoder::decode): Always set encoding when we see an XML header.
10:16 PM Changeset in webkit [10539] by darin
  • 2 edits in trunk
  • layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now that DumpRenderTree handles this case properly. The old expected result just had the word "error"!
10:13 PM Changeset in webkit [10538] by darin
  • 3 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dump): Dump the innerText of the document element rather than of the body element. This works with typical XHTML documents. We can probably do something even better in the long run, but this fixes the immediate issue.
  • separate tweak
  • Scripts/run-webkit-tests: Show the results in the current built Safari by using run-safari instead of just using "open", which often runs another copy of Safari instead.
6:26 PM Changeset in webkit [10537] by justing
  • 5 edits in trunk/WebKit

Reviewed by john

Fixes <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload
We were adding the movie to the document twice after the changes were added to handle fallback content.
There are some errors for which we should not render fall back content

  • Misc.subproj/WebKitErrorsPrivate.h: Introduced WebKitErrorPlugInWillHandleLoad to represent the cancel we do to prevent loading plugin content twice
  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView dataSourceUpdated:]): Ditto
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Don't handleFallbackContent on WebKitErrorPlugInWillHandleLoad or on a user cancel
6:25 PM Changeset in webkit [10536] by justing
  • 3 edits in trunk/WebCore

Reviewed by john

Test cases added: none, method rename

Part of fix for <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge handleFallbackContent]): Renamed bridge method mainResourceError to handleFallbackContent, since there are some main resource errors for which we should not render fallback content. E.G user cancels and the cancel we do to prevent loading plugin content twice (see <rdar://problem/4258008>)
5:57 PM Changeset in webkit [10535] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)

Test cases added: None. Manual testing is way to awkward, and automated testing
is not possible. Filed following bug to get automation.
<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • kwq/KWQAccObject.mm: (AXAttributedStringAppendText):
5:20 PM Changeset in webkit [10534] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner):
4:54 PM Changeset in webkit [10533] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • WebKit.xcodeproj/project.pbxproj: made WebDashboardRegion.h a private header
2:06 PM Changeset in webkit [10532] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

No easy way to test this in layout tests, so no test added.

  • kwq/KWQPainter.mm: (QPainter::save): Do nothing if painting is disabled. (QPainter::restore): Ditto. (QPainter::drawRect): Inset so that we "frame" the rectangle rather than "stroking" the rectangle. The former draws inside the rectangle but the latter draws centered on the edge of the rectangle.
9:21 AM Changeset in webkit [10531] by darin
  • 8 edits in trunk

WebCore:

Reviewed by Maciej.

  • kwq/KWQPainter.h: Made no-op xForm be an inline. Reformatted to remove extraneous spaces. Removed clearFocusRing. Changed the name of various private functions to remove underscore prefix, and reorganize them.
  • kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): Remove the NSBezierPath for focus. (QPainterPrivate::~QPainterPrivate): Ditto. (QPainter::save): Use CGContext instead of NSGraphicsContext. (QPainter::restore): Ditto. (QPainter::drawRect): Use CGContextFillRect instead of _fillRectXX, and CGContextStrokeRect instead of NSFrameRect. (QPainter::setFillColor): Added. Sets CGContext fill color based on brush. (QPainter::setFillColorFromCurrentBrush): Added. Sets CGContext fill color based on QPainter's current brush. (QPainter::setFillColorFromCurrentPen): Added. Sets CGContext fill color based on QPainter's current pen. (QPainter::setStrokeColorAndLineWidthFromCurrentPen): Added. Set CGContext stroke color and line width based on QPainter's current pen. (QPainter::drawLine): Use CGContextStrokeLineSegments instead of NSBezierPath. (QPainter::drawEllipse): Use CGContextFillEllipseInRect instead of CGContextFillPath and CGContextStrokeEllipseInRect instead of CGContextStrokePath. (QPainter::drawArc): Removed some uneeded type casts, changed to call the new private functions, currentContext and setStrokeColorAndLineWidthFromCurrentPen. (QPainter::drawConvexPolygon): Use new private functions, also use CGContextDrawPath in the case where we want to both fill and stroke the polygon. (QPainter::getCompositeOperation): Remove unneeded cast. (QPainter::setCompositeOperation): Map from name to operation here rather than relying on the code on the WebKit side to do it (allows us to remove names entirely from the WebKit side). (QPainter::compositeOperatorFromString): Remove a local variable and some casts. (getBlendedColorComponent): Rewrote to do the same computation without any conversion to float. (QPainter::fillRect): Use CGContextFillRect instead of _fillRectXXX. (QPainter::addClip): Use CGContextClipToRect instead of NSBezierPath. (QPainter::addRoundedRectClip): Add missing call to CGContextBeginPath. (QPainter::beginTransparencyLayer): Use CGContextSaveGState instead of NSGraphicsContext. (QPainter::endTransparencyLayer): Use CGContextRestoreGState instead of NSGraphicsContext. (QPainter::initFocusRing): Use CGContextBeginPath instead of creating an NSBezierPath. (QPainter::addFocusRingRect): Use CGContextAddRect instead of NSBezierPath. (QPainter::drawFocusRing): Use CGContextFillPath instead of NSBezierPath.
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintFocusRing): Remove call to clearFocusRing. No longer exists.
  • khtml/rendering/render_object.cpp: (RenderObject::paintOutline): Ditto.
  • kwq/WebCoreImageRendererFactory.h: Remove setCGCompositeOperationFromString method.

WebKit:

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString method, no longer needed.

Sep 13, 2005:

8:43 PM Changeset in webkit [10530] by harrison
  • 7 edits
    1 add in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4204892> Correcting incorrect spelling in Mail causes others to lose their red squiggles

Fixed by having SplitTextNodeCommand::doApply copy the markers to the new node, and having SplitTextNodeCommand::doUnapply
copy the markers from the merged-in node to the combined node.

btw - filed <rdar://problem/4256492> "WebCore editing automated layout tests verify spelling markers"
so that we can automate tests for this.

Test cases added:

  • manual-tests/keep_spelling_markers.html: Added.
  • khtml/editing/split_text_node_command.cpp: (khtml::SplitTextNodeCommand::doApply): (khtml::SplitTextNodeCommand::doUnapply): Call new copyMarkers() function.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeMarkers): (DocumentImpl::addMarker): (DocumentImpl::copyMarkers): (DocumentImpl::markersForNode): (DocumentImpl::shiftMarkers):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentMarker::): Added copyMarkers() function. Reorganized code for clarity.
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): (CharacterDataImpl::deleteData): (CharacterDataImpl::replaceData):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge unmarkAllMisspellings]): Update calls to marker functions.
1:51 PM Changeset in webkit [10529] by tomernic
  • 5 edits in trunk/WebKit

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h: Added 'isTransparent' instance variable.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty region of the opaque ancestor. This means that a partially-transparent plugin, which by definition does not clear its port on redraw, will not overdraw the valid parts of its port. (-[WebBaseNetscapePluginView sendEvent:]): Disabled the "green debug background" for transparent plugins -- since they are not expected to cover their entire port every redraw, this debug code makes no sense. (-[WebBaseNetscapePluginView setVariable:value:]): Implemented -setVariable:value:, which is called from NPN_SetValue() (previously unimplemented). Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other plugin variables, then we may do so here.
  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added SPI for -[WebBaseNetscapePluginView setVariable:value].
  • Plugins.subproj/npapi.m: (NPN_SetValue): Implemented this function so that plugins may set state (such as window mode).

Sep 12, 2005:

5:32 PM Changeset in webkit [10528]
  • 227 copies
    14 deletes in tags/WebCore-417

This commit was manufactured by cvs2svn to create tag 'WebCore-417'.

5:32 PM Changeset in webkit [10527] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin and Adele.

A workaround for a GCC bug, Justin to file a radar with a reduction soon.

  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap):
5:28 PM Changeset in webkit [10526] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin and Adele.

A workaround for a GCC bug, Justin to file a radar with a reduction soon.

  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap):
2:53 PM Changeset in webkit [10525] by eseidel
  • 5 edits in trunk

Bug #: none
Submitted by: eseidel
Reviewed by: none, build fix only for svg.

Fixes build after qstring() -> string() rename this weekend.

  • kdom/Helper.cpp: (parseLength):
  • kdom/core/DOMStringImpl.cpp: (DOMStringImpl::toInt):
  • kdom/core/DocumentImpl.cpp: (DocumentImpl::getId):
  • kdom/css/CSSStyleSelector.cpp: (checkPseudoState):

Sep 11, 2005:

9:42 PM Changeset in webkit [10524] by darin
  • 2 edits
    2 adds in trunk

Reviewed by John Sullivan.

  • fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent

Test cases added:

  • layout-tests/fast/events/access-key-self-destruct.html: Added.
  • layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration with a SharedPtr; this helps in cases where the last reference to the node goes away inside the event handler.
8:43 PM Changeset in webkit [10523] by darin
  • 1 edit in trunk/WebCore/khtml/xml/dom_atomicstringlist.h

Forgot to check this in (was mentioned in ChangeLog).

8:40 PM Changeset in webkit [10522] by darin
  • 7 edits in trunk/WebCore

Reviewed by Eric.

  • changed back the name of a couple of string() functions that were renamed to qstring() by accident
  • kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring(). This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.
  • khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current AtomicString to string() back from qstring()!
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring(). (khtml::checkPseudoState): Ditto. (khtml::CSSStyleSelector::checkOneSelector): Ditto.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed boolean instead of re-checking a couple of data members. (DOM::parseLength): Use string() instead of qstring(). (DOM::DOMStringImpl::toInt): Ditto.
  • removed some dead code
  • khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.
10:04 AM Changeset in webkit [10521] by darin
  • 6 edits in trunk

WebKit:

Reviewed, tweaked, and landed by Darin.

  • WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]): If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH is set in the environment, then unset DYLD_FRAMEWORK_PATH.
  • WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in configurations other than Default -- we don't want that code in production builds, but we want it in builds we do ourselves and nightly builds.

WebKitTools:

Reviewed, tweaked, and landed by Darin.

  • Scripts/run-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH.
  • Scripts/run-webkit-app: Ditto.
3:41 AM Changeset in webkit [10520] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 4932
Submitted by: eseidel
Reviewed by: self, only affects SVG; build fix.

2:28 AM Changeset in webkit [10519] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Oops. Use spaces, not tabs.
2:23 AM Changeset in webkit [10518] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/run-webkit-tests: Sort tests with a new "pathcmp" function that's better in two ways: 1) puts all files in a directory before any files in a subdirectory, and 2) sort file names with numeric digits in them in a logical way, so test-33 will come before test-3.
Note: See TracTimeline for information about the timeline view.