Timeline



Sep 21, 2005:

2:58 PM Changeset in webkit [10592] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by Geoff.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
2:52 PM Changeset in webkit [10591] by hyatt
  • 5 edits in trunk/LayoutTests/editing

Update editing tests to fix failures.

2:05 PM Changeset in webkit [10590] by vicki
  • 4 edits
    24 adds in trunk

Changes by Romain Brestac, reviewed by Darin.

  • khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::data):
  • khtml/misc/loader.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

Test cases added:

  • layout-tests/fast/xsl/resources/unicode.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc-cyr.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc16.xsl: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr.xml: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16to16.xml: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.png: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.txt: Added.
  • layout-tests/fast/xsl/xslt_unicode.xml: Added.
10:32 AM Changeset in webkit [10589] by vicki
  • 5 edits
    8 adds in trunk

Reviewed by Darin.

  • fix these bugs <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043) <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): if the index is the same as the number of rows in the section, we should append

Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.

  • layout-tests/fast/dynamic/013-expected.checksum:
  • layout-tests/fast/dynamic/013-expected.png:
  • layout-tests/fast/dynamic/013-expected.txt:

Test cases added:

  • layout-tests/fast/dynamic/014-expected.checksum: Added.
  • layout-tests/fast/dynamic/014-expected.png: Added.
  • layout-tests/fast/dynamic/014-expected.txt: Added.
  • layout-tests/fast/dynamic/014.html: Added.
  • layout-tests/fast/dynamic/015-expected.checksum: Added.
  • layout-tests/fast/dynamic/015-expected.png: Added.
  • layout-tests/fast/dynamic/015-expected.txt: Added.
  • layout-tests/fast/dynamic/015.html: Added.

Sep 20, 2005:

10:53 PM Changeset in webkit [10588] by mjs
  • 4 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Geoff and partly by Darin.

This change gets us down from over 200 shift/reduce and 45 reduce/reduce to
9 shift/reduce and 45 reduce/reduce.

  • kjs/grammar.y:
  • kjs/grammar_types.h: Removed.
  • kjs/lexer.cpp:
  • kjs/nodes.h: (KJS::Node::isGroupNode): (KJS::Node::isLocation): (KJS::Node::isResolveNode): (KJS::Node::isBracketAccessorNode): (KJS::Node::isDotAccessorNode): (KJS::ResolveNode::isLocation): (KJS::ResolveNode::isResolveNode): (KJS::ResolveNode::identifier): (KJS::GroupNode::isGroupNode): (KJS::GroupNode::leafNode): (KJS::BracketAccessorNode::isLocation): (KJS::BracketAccessorNode::isBracketAccessorNode): (KJS::BracketAccessorNode::base): (KJS::BracketAccessorNode::subscript): (KJS::DotAccessorNode::isLocation): (KJS::DotAccessorNode::isDotAccessorNode): (KJS::DotAccessorNode::base): (KJS::DotAccessorNode::identifier): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncExprNode::identifier): (KJS::FuncDeclNode::FuncDeclNode): (KJS::FuncDeclNode::execute):
9:47 PM Changeset in webkit [10587] by mjs
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests/fast/dom

Add results for new replaceChild test.

6:10 PM Changeset in webkit [10586] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Oops. The 4263434 change was only appropriate on the branch. Rolling out.

Reviewed by eric.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark):
5:33 PM Changeset in webkit [10585] by ggaren
  • 3 edits in trunk/JavaScriptCore
  • More changes needed to fix <rdar://problem/4214783> 8F29 REGRESSION(Denver/Chardonnay): kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Added InterpreterLocks in some places in the bindings we missed before.

Reviewed by john.

  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):
5:25 PM Changeset in webkit [10584] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by me.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
5:24 PM Changeset in webkit [10583] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

Fix the SVG build buy linking EcmaInterface.cpp
from derived sources into the source root and
adding to the compiled sources.

4:59 PM Changeset in webkit [10582] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

4:38 PM Changeset in webkit [10581] by bdakin
  • 2 edits
    2 adds in trunk

Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:

4:08 PM Changeset in webkit [10580] by hyatt
  • 46 edits in trunk/LayoutTests/fast

Update layout tests to deal with trailing whitespace at the end of a document properly.

4:01 PM Changeset in webkit [10579] by hyatt
  • 7 edits in trunk/WebCore

Meant to land this ages ago. Make radio buttons work dynamically
when name and type change (make them pick up the correct new
group).

Also fix a bug in the tokenizer where trailing spaces/newlines at
the end of a document were getting lost. Messed up .innerHTML
on DHTML sites.

Reviewed by darin

  • khtml/css/html4.css:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::radioButtonChecked): (DOM::HTMLGenericFormElementImpl::name): (DOM::HTMLInputElementImpl::name): (DOM::HTMLInputElementImpl::setInputType): (DOM::HTMLInputElementImpl::parseMappedAttribute): (DOM::HTMLInputElementImpl::attach): (DOM::HTMLInputElementImpl::preDispatchEventHandler): (DOM::HTMLInputElementImpl::postDispatchEventHandler): (DOM::HTMLIsIndexElementImpl::HTMLIsIndexElementImpl):
  • khtml/html/html_formimpl.h:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::preDispatchEventHandler): (DOM::NodeImpl::postDispatchEventHandler):
3:31 PM Changeset in webkit [10578] by sullivan
  • 6 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • fixed <rdar://problem/3228554> We should enforce one selection per WebView instead of per window

Note that this checkin does not mean that we will always maintain a selection in a WebView when
the focus is elsewhere. Instead it means that there should never be more than one frame containing
a selection in a WebView, and that it's possible to maintain a selection in a WebView when the focus
is elsewhere.

  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): removed unnecessary and somewhat confusing comment (-[WebView selectedFrame]): now calls the extracted method -_focusedFrame (-[WebView _focusedFrame]): new method, extracted from -selectedFrame; returns frame containing first responder, if any (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): added skippingFrame parameter, which is never returned (-[WebView _findSelectedFrameSkippingFrame:]): new method, starts from main frame and passes a frame to skip (-[WebView _findSelectedFrame]): now calls _findSelectedFrameSkippingFrame:nil (-[WebView _selectedFrameDidChange]): new method, called by WebDocumentText protocol implementors; calls -deselectAll on frame that formerly displayed a selection, if any
  • WebView.subproj/WebViewInternal.h: added category WebDocumentSelectionExtras, with the one method _selectedFrameDidChange
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): call -[WebView _selectedFrameDidChange]
  • WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): call -[WebView _selectedFrameDidChange] (-[WebPDFView resignFirstResponder]): deselect all unless webview says not to; note that this doesn't work in all cases due to: <rdar://problem/4265966> PDFs continue to show a (secondary) selection when the focus moves elsewhere
  • WebView.subproj/WebTextView.m: (-[WebTextView becomeFirstResponder]): call -[WebView _selectedFrameDidChange] (-[WebTextView resignFirstResponder]): deselect all unless webview says not to
3:09 PM Changeset in webkit [10577] by eseidel
  • 53 edits
    136 adds
    8 deletes in trunk

Bug #: 4946
Submitted by: eseidel
Reviewed by: mjs

Pickup latest Ecma changes from KDE, including
adding in the SVG ecma bindings and DOM 3 LS bindings.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4946

  • WebCore.xcodeproj/project.pbxproj:
  • kdom/bindings/IDLCodeGenerator.pm:
  • kdom/bindings/IDLCodeGeneratorCpp.pm:
  • kdom/bindings/IDLCodeGeneratorEcmaInterface.pm: Added.
  • kdom/bindings/IDLCodeGeneratorJs.pm:
  • kdom/bindings/idl/core/Attr.idl:
  • kdom/bindings/idl/core/CharacterData.idl:
  • kdom/bindings/idl/core/DOMConfiguration.idl:
  • kdom/bindings/idl/core/DOMException.idl:
  • kdom/bindings/idl/core/DOMImplementation.idl:
  • kdom/bindings/idl/core/DOMImplementationList.idl: Removed.
  • kdom/bindings/idl/core/DOMImplementationSource.idl: Removed.
  • kdom/bindings/idl/core/DOMString.idl: Removed.
  • kdom/bindings/idl/core/Document.idl:
  • kdom/bindings/idl/core/Element.idl:
  • kdom/bindings/idl/core/NameList.idl: Removed.
  • kdom/bindings/idl/core/NamedNodeMap.idl:
  • kdom/bindings/idl/core/Node.idl:
  • kdom/bindings/idl/core/ProcessingInstruction.idl:
  • kdom/bindings/idl/core/Text.idl:
  • kdom/bindings/idl/core/UserDataHandler.idl: Removed.
  • kdom/bindings/idl/css/CSSCharsetRule.idl:
  • kdom/bindings/idl/css/CSSMediaRule.idl:
  • kdom/bindings/idl/css/CSSPageRule.idl:
  • kdom/bindings/idl/css/CSSPrimitiveValue.idl:
  • kdom/bindings/idl/css/CSSRule.idl:
  • kdom/bindings/idl/css/CSSStyleDeclaration.idl:
  • kdom/bindings/idl/css/CSSStyleRule.idl:
  • kdom/bindings/idl/css/CSSStyleSheet.idl:
  • kdom/bindings/idl/css/CSSValue.idl:
  • kdom/bindings/idl/css/ViewCSS.idl: Removed.
  • kdom/bindings/idl/events/DocumentEvent.idl:
  • kdom/bindings/idl/events/EventException.idl:
  • kdom/bindings/idl/events/EventTarget.idl:
  • kdom/bindings/idl/ls/DOMImplementationLS.idl: Added.
  • kdom/bindings/idl/ls/LSException.idl: Added.
  • kdom/bindings/idl/ls/LSInput.idl: Added.
  • kdom/bindings/idl/ls/LSOutput.idl: Added.
  • kdom/bindings/idl/ls/LSParser.idl: Added.
  • kdom/bindings/idl/ls/LSParserFilter.idl: Added.
  • kdom/bindings/idl/ls/LSResourceResolver.idl: Added.
  • kdom/bindings/idl/ls/LSSerializer.idl: Added.
  • kdom/bindings/idl/ls/LSSerializerFilter.idl: Added.
  • kdom/bindings/idl/ls/kdomdefs.idl: Added.
  • kdom/bindings/idl/range/Range.idl:
  • kdom/bindings/idl/range/RangeException.idl:
  • kdom/bindings/idl/stylesheets/LinkStyle.idl:
  • kdom/bindings/idl/stylesheets/MediaList.idl:
  • kdom/bindings/idl/traversal/DocumentTraversal.idl:
  • kdom/bindings/idl/traversal/NodeIterator.idl:
  • kdom/bindings/idl/traversal/TreeWalker.idl:
  • kdom/bindings/idl/xpath/XPathEvaluator.idl:
  • kdom/bindings/idl/xpath/XPathException.idl:
  • kdom/bindings/idl/xpath/XPathExpression.idl:
  • kdom/bindings/idl/xpath/XPathNSResolver.idl:
  • kdom/bindings/idl/xpath/XPathNamespace.idl:
  • kdom/bindings/idl/xpath/XPathResult.idl:
  • kdom/bindings/idl/xpointer/XPointerException.idl:
  • kdom/bindings/kdombinder.sh:
  • kdom/bindings/kdomidl.pl:
  • kdom/core/CDFInterface.cpp: (CDFInterface::ecmaInterface):
  • kdom/core/CDFInterface.h:
  • kdom/ecma/DOMBridge.h: (KDOM::DOMRWBridge::put):
  • kdom/ecma/DOMLookup.h:
  • kdom/ecma/Ecma.cpp: (Ecma::Private::Private): (Ecma::setup): (Ecma::setupDocument): (Ecma::interface): (Ecma::createEventListener): (KDOM::getDOMNode): (KDOM::getDOMEvent):
  • kdom/ecma/Ecma.h:
  • kdom/ecma/EcmaInterface.h: Removed.
  • kdom/ecma/GlobalObject.cpp: (GlobalObject::get): (GlobalObjectFunc::callAsFunction): (ScheduledAction::execute): (GlobalQObject::parentDestroyed): (GlobalQObject::clearTimeout): (GlobalQObject::timerEvent):
  • kdom/ecma/GlobalObject.h: (KDOM::GlobalObject::):
  • kdom/ecma/ScriptInterpreter.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createKDOMDocument):
  • khtml/xml/dom_docimpl.h:
  • ksvg2/bindings/idl/svg/GetSVGDocument.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAngle.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGColor.idl: Added.
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Added.
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGDescElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGDocument.idl: Added.
  • ksvg2/bindings/idl/svg/SVGElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl: Added.
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGEvent.idl: Added.
  • ksvg2/bindings/idl/svg/SVGException.idl: Added.
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Added.
  • ksvg2/bindings/idl/svg/SVGGElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGICCColor.idl: Added.
  • ksvg2/bindings/idl/svg/SVGImageElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLength.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLengthList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLineElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGLocatable.idl: Added.
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGMatrix.idl: Added.
  • ksvg2/bindings/idl/svg/SVGNumber.idl: Added.
  • ksvg2/bindings/idl/svg/SVGNumberList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPaint.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPoint.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPointList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Added.
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGRect.idl: Added.
  • ksvg2/bindings/idl/svg/SVGRectElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Added.
  • ksvg2/bindings/idl/svg/SVGSVGElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGSetElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGStopElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGStringList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGStylable.idl: Added.
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTests.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTextElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTransform.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTransformList.idl: Added.
  • ksvg2/bindings/idl/svg/SVGTransformable.idl: Added.
  • ksvg2/bindings/idl/svg/SVGURIReference.idl: Added.
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Added.
  • ksvg2/bindings/idl/svg/SVGUseElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGViewElement.idl: Added.
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Added.
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Added.
  • ksvg2/bindings/idl/svg/kdomdefs.idl: Added.
  • ksvg2/ecma/EcmaInterface.h: Removed.
2:40 AM Changeset in webkit [10576] by eseidel
  • 2 edits in trunk

Bug #: 5058
Submitted by: Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>
Reviewed by: eseidel

1:33 AM Changeset in webkit [10575] by eseidel
  • 20 edits in trunk/WebKit

Bug #: 5037
Submitted by: eseidel
Reviewed by: mjs

Moved MIME type support from a hard coded list
(in two places) to single lists in the corresponding
*Representation classes. Also moved the list of types
supported by WebCore (WebHTMLRepresentation) into WebCore.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5037

  • WebView.subproj/WebDataSource.m: (addTypesFromClass): new inline function (+[WebDataSource _repTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebFrameView.m: (addTypesFromClass): new inline function (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedMIMETypes]):
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView supportedMIMETypes]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebImageRepresentation.h:
  • WebView.subproj/WebImageRepresentation.m: (+[WebImageRepresentation supportedMIMETypes]):
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (+[WebImageView supportedMIMETypes]):
  • WebView.subproj/WebPDFRepresentation.h:
  • WebView.subproj/WebPDFRepresentation.m: (+[WebPDFRepresentation supportedMIMETypes]):
  • WebView.subproj/WebPDFView.h:
  • WebView.subproj/WebPDFView.m: (+[WebPDFView supportedMIMETypes]):
  • WebView.subproj/WebTextRepresentation.h:
  • WebView.subproj/WebTextRepresentation.m: (+[WebTextRepresentation supportedMIMETypes]):
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (+[WebTextView supportedMIMETypes]):
  • WebView.subproj/WebView.m: (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): (+[WebView MIMETypesShownAsHTML]): updated to match style (+[WebView setMIMETypesShownAsHTML:]): ditto
1:31 AM Changeset in webkit [10574] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5037
Submitted by: eseidel
Reviewed by: mjs

Moved MIME types list from WebKit into WebCore.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5037

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (+[WebCoreBridge supportedMIMETypes]): added.
1:10 AM Changeset in webkit [10573] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Test cases added:

  • layout-tests/fast/js/date-big-constructor-expected.txt: Added.
  • layout-tests/fast/js/date-big-constructor.html: Added.

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::fillStructuresUsingDateArgs): (KJS::makeTime):
1:08 AM Changeset in webkit [10572] by ggaren
  • 1 edit
    2 adds in trunk

Test cases added:

  • layout-tests/fast/js/date-big-constructor-expected.txt: Added.
  • layout-tests/fast/js/date-big-constructor.html: Added.
1:07 AM Changeset in webkit [10571] by ggaren
  • 2 edits in trunk/JavaScriptCore

Test cases added:

  • layout-tests/fast/js/date-big-constructor-expected.txt: Added.
  • layout-tests/fast/js/date-big-constructor.html: Added.

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::fillStructuresUsingDateArgs): (KJS::makeTime):
12:55 AM Changeset in webkit [10570] by ggaren
  • 2 edits in trunk/WebCore

No layout test because we don't have test machinery for the Obj-C bindings yet.

Reviewed by eric.

  • kwq/DOM.mm: (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::ObjCEventListener): (ObjCEventListener::~ObjCEventListener): (ObjCEventListener::handleEvent):
12:46 AM Changeset in webkit [10569] by ggaren
  • 2 edits in trunk/WebCore

No test case because this is a build fix.

Reviewed by darin.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::processToken):

Sep 19, 2005:

6:23 PM Changeset in webkit [10568] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 4613
Submitted by: eseidel
Reviewed by: darin

2:53 PM Changeset in webkit [10567] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Rolled out changes to simple_number.h, and added fits(long long) and SimpleNumber::fits(unsigned long long) to the old system.

Reviewed by mjs.

  • kjs/simple_number.h: (KJS::SimpleNumber::): (KJS::SimpleNumber::value): (KJS::SimpleNumber::fits): (KJS::SimpleNumber::integerFits): (KJS::SimpleNumber::make):
1:54 PM Changeset in webkit [10566] by bdakin
  • 10 edits
    2 adds in trunk

Bug #:
Submitted by:
Reviewed by:

11:52 AM Changeset in webkit [10565] by mjs
  • 18 edits in trunk/WebCore

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Added assertions to ensure that main_thread_malloc and friends are
only called on the main thread.

Also changed main_thread_free to schedule a free on the main
thread if called from a background thread. This contingency is
rare, but unavoidable in the case that JavaScript runs on
background threads, since then objects can be garbage collected on
any thread.

Test cases added: Node, this is impossible to reproduce in Safari without the use of
PAC files.

  • Makefile.am:
  • khtml/dom/dom_misc.h:
  • khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::handleEvent): (JSLazyEventListener::parseCode): (KJS::getDOMEvent):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::~KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_traversal.cpp: (JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_window.cpp: (Window::clear): (ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished):
  • khtml/misc/main_thread_malloc.cpp: (khtml::main_thread_malloc): (khtml::main_thread_calloc): (khtml::main_thread_free): (khtml::main_thread_realloc): (khtml::initialize_scheduled_free_list): (khtml::drain_scheduled_free_list): (khtml::schedule_free_on_main_thread): (khtml::public_fREe):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bindingRootObject): (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQPageState.mm: (-[KWQPageState clear]):
  • kwq/KWQTimer.h:
  • kwq/KWQTimer.mm: (-[KWQMainThreadPerformTarget initWithFunction:]): (-[KWQMainThreadPerformTarget callFunction:]): (QTimer::immediateSingleShotOnMainThread):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]):
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): (+[WebCoreJavaScript garbageCollect]):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
11:10 AM Changeset in webkit [10564] by mjs
  • 1 add in trunk/JavaScriptCore/kjs/protected_reference.h

Bug #:
Submitted by:
Reviewed by:

Sep 18, 2005:

11:57 PM Changeset in webkit [10563] by mjs
  • 23 edits
    1 delete in trunk/JavaScriptCore

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Also added assertions to ensure that the locking rules are followed for the relevant
resources.

  • Makefile.am:
  • bindings/NP_jsobject.cpp: (identifierFromNPIdentifier): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
  • bindings/jni/jni_jsobject.cpp: (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::convertJObjectToValue):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/runtime.cpp: (Instance::createRuntimeObject):
  • bindings/runtime_root.h:
  • bindings/testbindings.cpp: (main):
  • bindings/testbindings.mm: (main):
  • kjs/fast_malloc.cpp: (KJS::kjs_fast_malloc): (KJS::kjs_fast_calloc): (KJS::kjs_fast_free): (KJS::kjs_fast_realloc):
  • kjs/fast_malloc.h:
  • kjs/identifier.h:
  • kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::clear): (InterpreterImp::mark): (InterpreterImp::checkSyntax): (InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::globalObject):
  • kjs/interpreter.cpp: (Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock):
  • kjs/nodes.h:
  • kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::~ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::~ProtectedObject): (KJS::ProtectedObject::operator=): (KJS::ProtectedReference::ProtectedReference): (KJS::ProtectedReference::~ProtectedReference): (KJS::ProtectedReference::operator=):
  • kjs/protected_object.h:
  • kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): (KJS::ProtectedValues::increaseProtectCount): (KJS::ProtectedValues::decreaseProtectCount):
  • kjs/string_object.cpp: (StringObjectImp::StringObjectImp):
  • kjs/testkjs.cpp: (main):
2:45 PM Changeset in webkit [10562] by eseidel
  • 11 edits in trunk

Bug #: 5045
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

  • WebCore+SVG/DrawDocument.mm: (-[DrawView primaryView]): cast to DrawView * (newer gcc fix)
  • kdom/cache/KDOMLoader.cpp: (Loader::slotFinished): toLong -> toInt
  • ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::setValueAsString): toFloat -> toDouble
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::parseAttribute): ditto
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::parseAttribute): ditto
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::parseAttribute): ditto
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::parseAttribute): ditto
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp: (SVGFitToViewBoxImpl::parseViewBox): ditto
  • ksvg2/svg/SVGNumberListImpl.cpp: (SVGNumberListImpl::parse): ditto
  • ksvg2/svg/SVGStopElementImpl.cpp: (SVGStopElementImpl::parseAttribute): ditto
Note: See TracTimeline for information about the timeline view.