Timeline



Sep 24, 2005:

3:39 PM Changeset in webkit [10622] by mjs
  • 1 edit
    8 adds in trunk
  • some JavaScript syntax test cases
  • layout-tests/fast/js/delete-syntax-expected.txt: Added.
  • layout-tests/fast/js/delete-syntax.html: Added.
  • layout-tests/fast/js/postfix-syntax-expected.txt: Added.
  • layout-tests/fast/js/postfix-syntax.html: Added.
  • layout-tests/fast/js/prefix-syntax-expected.txt: Added.
  • layout-tests/fast/js/prefix-syntax.html: Added.
  • layout-tests/fast/js/typeof-syntax-expected.txt: Added.
  • layout-tests/fast/js/typeof-syntax.html: Added.
3:34 PM Changeset in webkit [10621] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4260479> Finish deploying PropertySlot in the interpreter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5112

Convert postfix, prefix, delete, prefix, and for..in expressions to use
PropertySlot-based lookup instead of evaluateReference.

3% speedup on JS iBench.

Fixed two of the JS tests:

  • tests/mozilla/expected.html:
  • kjs/grammar.y:
  • kjs/nodes.cpp: (PostfixResolveNode::evaluate): (PostfixBracketNode::evaluate): (PostfixDotNode::evaluate): (DeleteResolveNode::evaluate): (DeleteBracketNode::evaluate): (DeleteDotNode::evaluate): (DeleteValueNode::evaluate): (typeStringForValue): (TypeOfResolveNode::evaluate): (TypeOfValueNode::evaluate): (PrefixResolveNode::evaluate): (PrefixBracketNode::evaluate): (PrefixDotNode::evaluate): (ForInNode::execute):
  • kjs/nodes.h: (KJS::PostfixResolveNode::PostfixResolveNode): (KJS::PostfixBracketNode::PostfixBracketNode): (KJS::PostfixDotNode::PostfixDotNode): (KJS::DeleteResolveNode::DeleteResolveNode): (KJS::DeleteBracketNode::DeleteBracketNode): (KJS::DeleteDotNode::DeleteDotNode): (KJS::DeleteValueNode::DeleteValueNode): (KJS::TypeOfResolveNode::TypeOfResolveNode): (KJS::TypeOfValueNode::TypeOfValueNode): (KJS::PrefixResolveNode::PrefixResolveNode): (KJS::PrefixBracketNode::PrefixBracketNode): (KJS::PrefixDotNode::PrefixDotNode):
  • kjs/nodes2string.cpp: (PostfixResolveNode::streamTo): (PostfixBracketNode::streamTo): (PostfixDotNode::streamTo): (DeleteResolveNode::streamTo): (DeleteBracketNode::streamTo): (DeleteDotNode::streamTo): (DeleteValueNode::streamTo): (TypeOfValueNode::streamTo): (TypeOfResolveNode::streamTo): (PrefixResolveNode::streamTo): (PrefixBracketNode::streamTo): (PrefixDotNode::streamTo):
  • kjs/reference.cpp: (KJS::Reference::Reference): (KJS::Reference::getPropertyName): (KJS::Reference::getValue): (KJS::Reference::deleteValue):
  • kjs/reference.h:
6:50 AM Changeset in webkit [10620] by darin
  • 5 edits
    8 adds in trunk

WebCore:

Test cases added:

  • layout-tests/editing/selection/fake-drag.html: Added.
  • layout-tests/editing/selection/fake-doubleclick: Added.

WebKitTools:

Reviewed by Maciej.
Landed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController init]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): Add eventSender javascript object, that sends fake mouse events to the webview.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: link with Carbon.framework
6:39 AM Changeset in webkit [10619] by darin
  • 1 edit
    1 add in trunk/WebCore
  • added Mitz's test for flipped text rendering (using dragged links)
  • manual-tests/flipped-text-rendering.html: Added.
6:36 AM Changeset in webkit [10618] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Set up a the CGContext with a matrix that flips the text if the view is not flipped.
6:18 AM Changeset in webkit [10617] by darin
  • 18 edits
    6 adds in trunk

WebCore:

  • added tests and updated results for WebKit ATSU text measurement change
  • layout-tests/fast/text/cg-vs-atsui.html: Added.
  • layout-tests/fast/text/cg-vs-atsui-expected.checksum: Added.
  • layout-tests/fast/text/cg-vs-atsui-expected.png: Added.
  • layout-tests/fast/text/cg-vs-atsui-expected.txt: Added.
  • layout-tests/css1/text_properties/text-transCapitalize-expected.checksum: Updated.
  • layout-tests/css1/text_properties/text-transCapitalize-expected.png: Updated.
  • layout-tests/css1/text_properties/text-transCapitalize-expected.txt: Updated.
  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.checksum: Updated.
  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.png: Updated.
  • layout-tests/fast/text/international/bidi-CS-after-AN-expected.txt: Updated.
  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.png: Updated.
  • layout-tests/fast/text/international/bidi-explicit-embedding-expected.txt: Updated.
  • layout-tests/fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
  • layout-tests/fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
  • layout-tests/fast/text/international/bidi-fallback-font-weight-expected.txt: Updated.
  • layout-tests/fast/text/international/bidi-override-expected.checksum: Updated.
  • layout-tests/fast/text/international/bidi-override-expected.png: Updated.
  • layout-tests/fast/text/international/bidi-override-expected.txt: Updated.
  • added pixel results for this test
  • layout-tests/editing/pasteboard/3976872-expected.checksum: Added.
  • layout-tests/editing/pasteboard/3976872-expected.png: Added.

WebKit:

Reviewed, tweaked a tiny bit, and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Added. ATSU callback to do the rounding. (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): Use the new createATSULayoutParameters function instead of calling _createATSUTextLayoutForRun. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Use createATSULayoutParameters, and also compute the width in a way that works for any direction combination. (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use createATSULayoutParameters. (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): Use createATSULayoutParameters. Also put in code that seems to work around an ATSU bug. (createATSULayoutParameters): Added. (disposeATSULayoutParameters): Added.
5:05 AM Changeset in webkit [10616] by darin
  • 2 edits in trunk/WebKit

Reviewed by Dave.
Landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (addDirectionalOverride): Renamed, and made it work in both directions. (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): Updated to call addDirectionalOverride. (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): More of the same. (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): Ditto.
4:55 AM Changeset in webkit [10615] by darin
  • 5 edits
    6 adds in trunk
  • fixed a few layout test results
  • layout-tests/fast/js/date-big-constructor.html: Added code to make this test dump as text.
  • layout-tests/fast/js/date-big-constructor-expected.txt: Updated.
  • layout-tests/fast/parser/script-tag-with-trailing-slash.html: Fixed code that said window.dumpAsText() instead of layoutTestController.dumpAsText() so this test would dump as text.
  • layout-tests/fast/parser/script-tag-with-trailing-slash-expected.txt: Updated.
  • layout-tests/fast/dom/replaceChild-expected.checksum: Added.
  • layout-tests/fast/dom/replaceChild-expected.png: Added.
  • layout-tests/fast/encoding/utf-16-no-bom-expected.checksum: Added.
  • layout-tests/fast/encoding/utf-16-no-bom-expected.png: Added.
  • layout-tests/fast/table/overflowHidden-expected.checksum: Added.
  • layout-tests/fast/table/overflowHidden-expected.png: Added.
4:45 AM Changeset in webkit [10614] by darin
  • 17 edits
    4 adds in trunk

Reviewed by Dave.
Landed by Darin.

Test cases added:

  • layout-tests/fast/text/international/bidi-override.html: Added.
  • layout-tests/fast/text/international/bidi-override-expected.checksum: Added.
  • layout-tests/fast/text/international/bidi-override-expected.png: Added.
  • layout-tests/fast/text/international/bidi-override-expected.txt: Added.
  • khtml/rendering/bidi.h: Include an "override direction" flag in BidiRun.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeVerticalPositionsForLine): Pass in "override direction" parameter. (khtml::RenderBlock::bidiReorderLine): Set direction based on override. (khtml::RenderBlock::layoutInlineChildren): Pass in "override direction" parameter.
  • khtml/rendering/render_object.h: Update position function to take an "override direction" parameter.
  • khtml/rendering/render_box.h: Ditto.
  • khtml/rendering/render_box.cpp: (RenderBox::position): Ditto.
  • khtml/rendering/render_text.h: Add an m_dirOverride field to InlineTextBox.
  • khtml/rendering/render_text.cpp: (InlineTextBox::paint): Pass true for override to drawText if m_dirOverride is set. (InlineTextBox::paintSelection): Ditto. (InlineTextBox::paintMarkedTextBackground): Ditto. (RenderText::position): Set up m_dirOverride in the InlineTextBox based on the override parameter.
  • kwq/WebCoreTextRenderer.h: Replace visuallyOrdered flag with a directionalOverride flag.
  • kwq/WebCoreTextRendererFactory.mm: (WebCoreInitializeEmptyTextStyle): Ditto.
  • kwq/KWQPainter.mm: (QPainter::drawText): Ditto. (QPainter::drawHighlightForText): Ditto.
  • updated pixel test results for unrelated tests with results that recently changed
  • layout-tests/fast/forms/006-expected.checksum:
  • layout-tests/fast/forms/006-expected.png:
  • layout-tests/fast/forms/007-expected.checksum:
  • layout-tests/fast/forms/007-expected.png:
  • layout-tests/fast/text/whitespace/013-expected.checksum:
  • layout-tests/fast/text/whitespace/013-expected.png:
4:05 AM Changeset in webkit [10613] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.
Landed by Darin (after taking tabs out).

  • kwq/KWQLineEdit.mm: (QLineEdit::setCursorPosition): Don't use NSMakeRange. (QLineEdit::setSelection): Ditto.
  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap): Rearrange things so we don't get a warning.
  • kwq/KWQTextEdit.mm: (QTextEdit::selectionEnd): Don't use NSMaxRange. (QTextEdit::setSelectionRange): Don't use NSMakeRange.
3:58 AM Changeset in webkit [10612] by darin
  • 3 edits in trunk/WebKit

Tweaked, reviewed, and landed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[NSArray mouseDown:]): Removed misleading comment and added code to send mouse event to input manager. (-[NSArray mouseDragged:]): Added code to send mouse event to input manager. (-[NSArray mouseUp:]): Ditto. (-[WebHTMLView _discardMarkedText]): Umnmark text before calling markedTextAbandoned: to match behavior of NSTextView (not sure why we did things in the opposite order before). (-[WebHTMLView _updateSelectionForInputManager]): Ditto.
  • unrelated tweak
  • WebView.subproj/WebView.m: (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): Fix typecast that used ... for no good reason.
3:07 AM Changeset in webkit [10611] by darin
  • 2 edits
    5 adds in trunk

Reviewed and landed by Darin.

Test cases added:

  • layout-tests/fast/xsl/xslt-text.xml: Added.
  • layout-tests/fast/xsl/xslt-text.xsl: Added.
  • layout-tests/fast/xsl/xslt-text-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-text-expected.png: Added.
  • layout-tests/fast/xsl/xslt-text-expected.txt: Added.
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Use text rather than CDATA, using entities for & and < so that we can parse no matter what characters are in the text. Also add a head and a title element so the document is well formed.
2:49 AM Changeset in webkit [10610] by darin
  • 2 edits
    2 adds in trunk

Reviewed and landed by Darin.

Test cases added:

  • layout-tests/fast/encoding/utf-16-no-bom.xml: Added.
  • layout-tests/fast/encoding/utf-16-no-bom-expected.txt: Added.
  • khtml/misc/decoder.cpp: (Decoder::decode): Auto-detect an XML header with 16-bit characters (big or little endian) and decide encoding based on that.

Sep 23, 2005:

11:29 PM Changeset in webkit [10609] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5113
Submitted by: eseidel
Reviewed by: none, build fix only.

10:49 PM Changeset in webkit [10608] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5111
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: mjs

8:28 PM Changeset in webkit [10607] by darin
  • 1 edit
    2 adds in trunk/JavaScriptCore

Reviewed and landed by Darin.

  • a Windows-specific file
  • os-win32/stdint.h: Added. We plan to remove dependency on the <stdint.h> types, and if we do so, we will remove this file.
6:19 PM Changeset in webkit [10606] by darin
  • 35 edits
    1 add
    3 deletes in trunk

WebCore:

Reviewed and landed by Darin.

  • name changes to prepare for fixing bugzilla bug 4582

Renamed khtml::Selection to khtml::SelectionController since it's far more
than just the selection position itself. Also renamed WebSelectionDirection
WebSelectionGranularity and their constants to have a WebBridge prefix so they
don't collide with possible public enums with a similar purpose.

  • ForwardingHeaders/editing/SelectionController.h: Added.
  • ForwardingHeaders/editing/selection.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Added new files, removed old files.
  • khtml/editing/SelectionController.cpp: New name for selection.cpp, contents renamed.
  • khtml/editing/SelectionController.h: New name for selection.h, contents renamed.
  • khtml/editing/selection.cpp: Removed.
  • khtml/editing/selection.h: Removed.
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/delete_selection_command.h:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/edit_command.h:
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/khtml_part.cpp:
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/rendering/render_block.cpp:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_nodeimpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: Renaming.

WebKit:

Reviewed and landed by Darin.

  • name changes to prepare for fixing bugzilla bug 4582
  • WebView.subproj/WebHTMLView.m: Changed names to match WebCore changes.
11:24 AM Changeset in webkit [10605] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/DOM-CSS.mm: (-[DOMObject sheet]): Added.
11:20 AM Changeset in webkit [10604] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/DOM-CSS.mm: (-[DOMStyleSheet _initWithStyleSheetImpl:]): Changed the name of this method to be consistent with other method names in the DOM wrappers. The old name had an extraneous "DOM" in it. (+[DOMStyleSheet _DOMStyleSheetWithImpl:]): Create a wrapper of an appropriate class that matches the actual style sheet. This is analogous to what +[DOMNode _nodeWithImpl:] does. (+[DOMCSSStyleSheet _CSSStyleSheetWithImpl:]): Call through to the base class. The only difference here is the static type of the parameter, which ensures a compile-time error if you pass the wrong type of pointer.
10:38 AM Changeset in webkit [10603] by darin
  • 4 edits in trunk

Reviewed by Maciej.
Tested, landed, and tweaked a tiny bit by Darin.

Fix was to remove the "pending" concept from the tokenizer, which streamlined the
code and also fixed one minor bug seen in one of the layout tests where we discarded
too much after the <pre>.

  • khtml/html/htmltokenizer.h: Removed the addPending function and the pending field. Also removed SpaceDiscard and AllDiscard since we don't use them any more. We still use LFDiscard to discard the first LF after a <pre>.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): Don't initialize pending. (khtml::HTMLTokenizer::processListing): Tweaked formatting to match guidelines. Removed calls to addPending. Write "\n" right away instead of using LFPending. Write " " right away instead of using SpacePending by removing separate code for space. (khtml::HTMLTokenizer::write): Ditto. (khtml::HTMLTokenizer::finish): Remove the call to addPending we just added a few days ago. This is what was causing the crash.
  • layout-tests/fast/text/whitespace/013-expected.txt: Updated results. Old results incorrectly expected spaces *and* a newline to be discarded after a <pre> tag, which was happening by accident. I tested Firefox and it matches what we do now -- only discards a newline just after a <pre>, not a run of spaces and a subsequent newline.

Sep 22, 2005:

8:54 PM Changeset in webkit [10602] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4649
Submitted by: Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>
Reviewed by: eseidel

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: Deployment build fix.
8:31 PM Changeset in webkit [10601] by eseidel
  • 10 edits
    2 deletes in trunk/WebKitTools

Bug #: 5003
Submitted by: eseidel
Reviewed by: mjs

Update tools for WebCore+SVG -> WebCore rename.
Also fold several SVG specific tools into their original
WebCore counterparts.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5003

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj:
  • Scripts/build-drawtest:
  • Scripts/build-dumpkcanvastree:
  • Scripts/build-webcore-svg: Removed.
  • Scripts/build-webkit: added --svg option
  • Scripts/run-drawtest:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm: various additions.
  • checkout: added --svg option
  • checkout-svg: Removed.
8:28 PM Changeset in webkit [10600] by eseidel
  • 7 edits
    8 adds in trunk/WebCore

Bug #: 5003
Submitted by: eseidel
Reviewed by: hyatt

Added KDOM and KCanvas wrapper objects for the WebCore DOM
and WebCore render tree. This allows using SVG in any
WebKit app, including Safari.
Also added extensions to QPainter to return a
KRenderingDeviceContext object to be passed into KCanvas.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5003

  • WebCore+SVG/dom_kdomdocumentwrapper.cpp: Added. (KDOMDocumentWrapperImpl::renderingDevice): (KDOMDocumentWrapperImpl::KDOMDocumentWrapperImpl): (KDOMDocumentWrapperImpl::~KDOMDocumentWrapperImpl): (DOM::KDOMDocumentWrapperImpl::createTokenizer): (KDOMDocumentWrapperImpl::svgView):
  • WebCore+SVG/dom_kdomdocumentwrapper.h: Added.
  • WebCore+SVG/dom_kdomnodetreewrapper.cpp: Added. (DOM::KDOMNodeTreeWrapperImpl::KDOMNodeTreeWrapperImpl): (KDOMNodeTreeWrapperImpl::~KDOMNodeTreeWrapperImpl): (KDOMNodeTreeWrapperImpl::attach): (KDOMNodeTreeWrapperImpl::createRenderer):
  • WebCore+SVG/dom_kdomnodetreewrapper.h: Added.
  • WebCore+SVG/render_kcanvaswrapper.cpp: Added. (RenderKCanvasWrapper::RenderKCanvasWrapper): (RenderKCanvasWrapper::~RenderKCanvasWrapper): (RenderKCanvasWrapper::layout): (RenderKCanvasWrapper::paint): (RenderKCanvasWrapper::intrinsicWidth): (RenderKCanvasWrapper::intrinsicHeight):
  • WebCore+SVG/render_kcanvaswrapper.h: Added. (khtml::RenderKCanvasWrapper::renderName): (khtml::RenderKCanvasWrapper::setCanvas):
  • WebCore+SVG/xml_kdomtokenizer.cpp: Added. (KDOMTokenizer::KDOMTokenizer): (KDOMTokenizer::~KDOMTokenizer): (KDOMTokenizer::documentWrapper): (KDOMTokenizer::write): (KDOMTokenizer::setOnHold): (KDOMTokenizer::finish): (KDOMTokenizer::isWaitingForScripts): (khtml::newKDOMTokenizer):
  • WebCore+SVG/xml_kdomtokenizer.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createKDOMDocument):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): (QPainterPrivate::~QPainterPrivate): (QPainter::renderingDeviceContext):
4:33 PM Changeset in webkit [10599]
  • 80 copies
    5 deletes in tags/JavaScriptCore-416~9

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~9'.

4:33 PM Changeset in webkit [10598] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Added versioning for JavaScriptCore-416.9 submission.

1:09 PM Changeset in webkit [10597] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin and mjs.

  • kjs/simple_number.h: changed enums to indenpendent constants to clarify types (KJS::isNegativeZero): changed to static function - no reason to export (KJS::SimpleNumber::rightShiftSignExtended): new function for clarity (KJS::SimpleNumber::make): specified cast as reinterpret_cast (KJS::SimpleNumber::is): changed to use uintptr_t for portability (KJS::SimpleNumber::value): changed to use uintptr_t and rightShiftSignExtended (KJS::SimpleNumber::fits): inverted tests - probably only a performance win for double (KJS::SimpleNumber::integerFits): ditto
12:28 PM Changeset in webkit [10596] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by Geoff.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
12:22 PM Changeset in webkit [10595] by thatcher
  • 3 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-20 Geoffrey Garen <​ggaren@apple.com>

  • More changes needed to fix <rdar://problem/4214783> 8F29 REGRESSION(Denver/Chardonnay): kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Added InterpreterLocks in some places in the bindings we missed before.

Reviewed by john.

  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):
12:19 PM Changeset in webkit [10594] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMDocumentNode): Don't use a static (global) identifier for the string "document" -- instead just create one each time. This eliminates the kjs_fast_malloc assertion on quit and does not create a significant performance regression because this is done at most once per JavaScript window object.
12:14 PM Changeset in webkit [10593] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-20 Geoffrey Garen <​ggaren@apple.com>

  • More changes needed to fix <rdar://problem/4214783> 8F29 REGRESSION(Denver/Chardonnay): kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Added InterpreterLocks in some places in the bindings we missed before.

Reviewed by john.

  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):

Sep 21, 2005:

2:58 PM Changeset in webkit [10592] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by Geoff.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
2:52 PM Changeset in webkit [10591] by hyatt
  • 5 edits in trunk/LayoutTests/editing

Update editing tests to fix failures.

2:05 PM Changeset in webkit [10590] by vicki
  • 4 edits
    24 adds in trunk

Changes by Romain Brestac, reviewed by Darin.

  • khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::data):
  • khtml/misc/loader.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

Test cases added:

  • layout-tests/fast/xsl/resources/unicode.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc-cyr.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc16.xsl: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr.xml: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16to16.xml: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.png: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.txt: Added.
  • layout-tests/fast/xsl/xslt_unicode.xml: Added.
10:32 AM Changeset in webkit [10589] by vicki
  • 5 edits
    8 adds in trunk

Reviewed by Darin.

  • fix these bugs <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043) <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): if the index is the same as the number of rows in the section, we should append

Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.

  • layout-tests/fast/dynamic/013-expected.checksum:
  • layout-tests/fast/dynamic/013-expected.png:
  • layout-tests/fast/dynamic/013-expected.txt:

Test cases added:

  • layout-tests/fast/dynamic/014-expected.checksum: Added.
  • layout-tests/fast/dynamic/014-expected.png: Added.
  • layout-tests/fast/dynamic/014-expected.txt: Added.
  • layout-tests/fast/dynamic/014.html: Added.
  • layout-tests/fast/dynamic/015-expected.checksum: Added.
  • layout-tests/fast/dynamic/015-expected.png: Added.
  • layout-tests/fast/dynamic/015-expected.txt: Added.
  • layout-tests/fast/dynamic/015.html: Added.
Note: See TracTimeline for information about the timeline view.