Timeline



Oct 2, 2005:

11:21 PM Changeset in webkit [10697] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5209
Submitted by: eseidel
Reviewed by: darin

Closes large memory leak in KSVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5209

  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attach): delete orphans unless PatternImpl
11:15 PM Changeset in webkit [10696] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 5132
Submitted by: eseidel
Reviewed by: mjs

Fixes SVG animation support in Safari/WebKit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5132

  • WebCore+SVG/dom_kdomnodetreewrapper.cpp: (KDOMNodeTreeWrapperImpl::attach): setup kcanvasviewquartz (KDOMNodeTreeWrapperImpl::detach): tear down kcanvasviewquartz
  • WebCore+SVG/dom_kdomnodetreewrapper.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.mm: fix spaces (KCanvasViewQuartz::KCanvasViewQuartz): (KCanvasViewQuartz::~KCanvasViewQuartz): (KCanvasViewQuartz::view): (KCanvasViewQuartz::setView): (KCanvasViewQuartz::renderObject): alternative to view (KCanvasViewQuartz::setRenderObject): (KCanvasViewQuartz::invalidateCanvasRect): (KCanvasViewQuartz::viewToCanvasMatrix): (KCanvasViewQuartz::canvasSizeChanged): (KCanvasViewQuartz::viewHeight): (KCanvasViewQuartz::viewWidth):
11:08 PM Changeset in webkit [10695] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • fast/xsl/xslt-url-expected.txt: Added.
  • fast/xsl/xslt-url.xml: Added.
  • fast/xsl/xslt-url.xsl: Added.
11:02 PM Changeset in webkit [10694] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

Fix XSLT to preserve document.URL.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
10:21 PM Changeset in webkit [10693] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5238
Submitted by: eseidel
Reviewed by: mjs

Fix crash when encountering XML processing directives w/ KDOM:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5238

  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::recalcStyleSelector): null check.
12:51 PM Changeset in webkit [10692] by eseidel
  • 2 edits
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, removing unused svg files only.

Removing unused SVG source files.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/ecma/Constructors.cpp: Removed.
  • ksvg2/ecma/Constructors.h: Removed.
10:17 AM Changeset in webkit [10691] by andersca
  • 3 edits in trunk/WebCore

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::localName): (AttrImpl::namespaceURI):
  • khtml/xml/dom_elementimpl.h: Implement localName and namespaceURI for attributes.
10:15 AM Changeset in webkit [10690] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/dom/attribute-namespaces-expected.txt: Added.
  • fast/dom/attribute-namespaces.xhtml: Added.

Sep 30, 2005:

11:28 PM Changeset in webkit [10689] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
11:14 PM Changeset in webkit [10688]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~12

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~12'.

11:14 PM Changeset in webkit [10687] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.12, also amending the ChangeLog to show the correct reviewer.

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
7:52 PM Changeset in webkit [10686] by thatcher
  • 3 edits in branches/Safari-Den-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Reviewed by Geoff someone.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
4:18 PM Changeset in webkit [10685] by eseidel
  • 1 add in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved WebCore/layout-tests to LayoutTests

2:52 PM Changeset in webkit [10684] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved layout-tests to ../LayoutTests

2:44 PM Changeset in webkit [10683] by eseidel
  • 6 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Updated all the scripts for the move:
WebCore/layout-tests -> LayoutTests

  • Scripts/check-dom-results:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-webkit-tests:
  • Scripts/update-webkit: added --no-tests
  • checkout: added --no-tests
10:57 AM Changeset in webkit [10682]
  • 68 copies
    5 deletes in tags/JavaScriptCore-417~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~1'.

10:57 AM Changeset in webkit [10681] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.1

10:55 AM Changeset in webkit [10680] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-29 Geoffrey Garen <​ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
10:47 AM Changeset in webkit [10679]
  • 81 copies
    5 deletes in tags/JavaScriptCore-416~11

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~11'.

10:47 AM Changeset in webkit [10678] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.11

10:45 AM Changeset in webkit [10677] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-29 Geoffrey Garen <​ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
9:35 AM Changeset in webkit [10676] by ggaren
  • 2 edits in trunk

Patch reviewed by john.

  • layout-tests/fast/js/date-parse-test.html: Added a test case for <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com
9:16 AM Changeset in webkit [10675] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by john.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)

Added test case to fast/js/date-parse-test.html.

12:03 AM Changeset in webkit [10674]
  • 52 copies
    22 deletes in tags/WebKit-416~9

This commit was manufactured by cvs2svn to create tag 'WebKit-416~9'.

12:03 AM Changeset in webkit [10673] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Versioning to WebKit-416.9

Sep 29, 2005:

11:59 PM Changeset in webkit [10672]
  • 52 copies
    22 deletes in tags/WebKit-417~1

This commit was manufactured by cvs2svn to create tag 'WebKit-417~1'.

11:59 PM Changeset in webkit [10671] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.1

11:53 PM Changeset in webkit [10670] by thatcher
  • 5 edits in branches/Safari-Den-branch/WebKit

Merged fix from TOT to Safari-Den-branch

2005-09-28 Justin Garcia <​justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

11:50 PM Changeset in webkit [10669] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-09-28 Justin Garcia <​justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

10:06 PM Changeset in webkit [10668]
  • 234 copies
    14 deletes in tags/WebCore-417~2

This commit was manufactured by cvs2svn to create tag
'WebCore-417~2'.

10:06 PM Changeset in webkit [10667] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.2

9:57 PM Changeset in webkit [10666] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merge over of various leak fixes from TOT to Safari-2-0-branch

2005-09-29 Timothy Hatcher <​timothy@apple.com>

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
9:04 PM Changeset in webkit [10665] by thatcher
  • 7 edits in trunk/WebCore

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQPoint.mm: ditto
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQRect.mm: ditto
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
  • kwq/KWQSize.mm: ditto
5:03 PM Changeset in webkit [10664] by hyatt
  • 7 edits in trunk/WebCore

Add support for parsing of the CSS3 box-sizing property. This
property will have to be fully implemented for form controls that
respect border and padding (buttons, textfields, list boxes, etc.).

Reviewed by john

Test cases added: (NONE, property just being parsed, not supported)

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssvalues.in:
  • khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::setBoxSizing): (khtml::RenderStyle::initialBoxSizing):
3:05 PM Changeset in webkit [10663] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5176
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: darin

Fix JSC memory smasher in TOT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5176

  • pcre/pcre_exec.c: (match):
1:10 PM Changeset in webkit [10662] by hyatt
  • 19 edits in trunk/WebCore

Make all form controls treat width: auto as width:intrinsic and
add support for intrinsic widths when computing sizes of
block-level flows.

Rename the term Variable to Auto, since this more accurately
matches the term in the CSS spec.

Reviewed by darin

Test cases added: (None needed, <button> and <legend> test this)

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/misc/khtmllayout.h: (khtml::): (khtml::Length::width): (khtml::Length::minWidth): (khtml::Length::isAuto): (khtml::Length::isIntrinsicOrAuto):
  • khtml/rendering/bidi.cpp: (khtml::getBPMWidth):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::MarginInfo::MarginInfo): (khtml::RenderBlock::isSelfCollapsingBlock): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::determineHorizontalPosition): (khtml::getBPMWidth): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::shouldCheckLines):
  • khtml/rendering/render_box.cpp: (RenderBox::getClipRect): (RenderBox::relativePositionOffset): (RenderBox::calcWidth): (RenderBox::calcWidthUsing): (RenderBox::sizesToIntrinsicWidth): (RenderBox::calcHorizontalMargins): (RenderBox::calcHeight): (RenderBox::calcHeightUsing): (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSlider::calcMinMaxWidth):
  • khtml/rendering/render_layer.cpp: (khtml::Marquee::updateMarqueeStyle):
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::marginLeft): (khtml::InlineFlowBox::marginRight):
  • khtml/rendering/render_object.cpp: (RenderObject::hasStaticX): (RenderObject::hasStaticY): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight): (RenderObject::usesLineWidth):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
  • khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::resetPadding): (khtml::RenderStyle::initialPadding):
  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTableSection::addCell): (RenderTableSection::layoutRows):
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::setCheckboxSize): (khtml::RenderThemeMac::setRadioSize):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (FixedTableLayout::layout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (shouldScaleColumns): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):
12:47 AM Changeset in webkit [10661] by justing
  • 9 edits
    11 adds in trunk

Reviewed by harrison

<rdar://problem/4278698> Adding a space inside whitespace:pre text collapses space
<rdar://problem/4076267> Mail behaves oddly when pasting in text with leading/trailing whitespace
<rdar://problem/4063751> Redo Typing can add extra space characters
<rdar://problem/4120558> Mail/WebKit: Repeated capitalizeWord command deletes spaces and does not capitalize

Reblance whitespace was finding the extent of surrounding whitespace incorrectly.
createFragmentFromMarkup was not dealing with the special cases for spaces at the start/end
of a line. InsertTextCommand was removing collapsable whitespace without regard for the
whitespace mode. createFragmentFromMarkup and RebalanceWhitespace command now use one method
to produce rebalanced sequences. Removed special case whitespace handling from
InsertTextCommand, that's RebalanceWhiteSpaceCommand's job.

Test cases added:

  • layout-tests/editing/inserting/4278698.html: Added.
  • layout-tests/editing/pasteboard/4076267-2.html: Added.
  • layout-tests/editing/pasteboard/4076267-3.html: Added.
  • layout-tests/editing/pasteboard/4076267.html: Added.
  • layout-tests/editing/undo/4063751.html: Added.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::rebalanceWhitespaceAt): Added. The old convenience method, rebalanceWhitespace, can probably be removed, because there is never a non-caret selection after an editing command.
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/htmlediting.cpp: (khtml::rebalanceWhitespaceInTextNode):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
  • khtml/editing/rebalance_whitespace_command.cpp: (khtml::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): (khtml::isWhitespace): Changed from isNBSP to include all forms of whitespace, to aid readability. (khtml::RebalanceWhitespaceCommand::doApply): (khtml::RebalanceWhitespaceCommand::doUnapply): Removed the unused m_downstreamOffset
  • layout-tests/editing/editingStyle.css: Added.
12:24 AM Changeset in webkit [10660] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5179
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: mjs

Sep 28, 2005:

7:59 PM Changeset in webkit [10659]
  • 81 copies
    5 deletes in tags/JavaScriptCore-416~10

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~10'.

7:59 PM Changeset in webkit [10658] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-28 Geoffrey Garen <​ggaren@apple.com>

  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
7:58 PM Changeset in webkit [10657]
  • 68 copies
    5 deletes in tags/JavaScriptCore-417

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417'.

7:58 PM Changeset in webkit [10656] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-28 Geoffrey Garen <​ggaren@apple.com>

  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
6:55 PM Changeset in webkit [10655] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
3:27 PM Changeset in webkit [10654] by mjs
  • 3 edits in trunk/JavaScriptCore

Patch from George Staikos, reviewed by me.

  • fixed some compile issues on Linux
  • kjs/property_slot.h:
  • kjs/simple_number.h:
3:01 PM Changeset in webkit [10653] by mjs
  • 21 edits
    9 adds
    5 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::interpreterMap): Function that fetches the interpreter map on demand. (KJS::InterpreterImp::InterpreterImp): Replace use of InterpreterMap class with an appropriate HashMap. (KJS::InterpreterImp::clear): ditto (KJS::InterpreterImp::interpreterWithGlobalObject): ditto
  • kjs/interpreter_map.cpp: Removed.
  • kjs/interpreter_map.h: Removed.

The HashMap/HashSet code (copied and slightly tweaked from WebCore)

  • kxmlcore/HashFunctions.h: Added. (KXMLCore::4): (KXMLCore::8): (KXMLCore::): (KXMLCore::PointerHash::hash): (KXMLCore::PointerHash::equal):
  • kxmlcore/HashMap.h: Added. (KXMLCore::extractFirst): (KXMLCore::HashMap::HashMap): (KXMLCore::::size): (KXMLCore::::capacity): (KXMLCore::::isEmpty): (KXMLCore::::begin): (KXMLCore::::end): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::set): (KXMLCore::::get): (KXMLCore::::remove): (KXMLCore::::clear): (KXMLCore::deleteAllValues):
  • kxmlcore/HashMapPtrSpec.h: Added. (KXMLCore::PointerHashIteratorAdapter::PointerHashIteratorAdapter): (KXMLCore::PointerHashIteratorAdapter::operator*): (KXMLCore::PointerHashIteratorAdapter::operator->): (KXMLCore::PointerHashIteratorAdapter::operator++): (KXMLCore::PointerHashIteratorAdapter::operator==): (KXMLCore::PointerHashIteratorAdapter::operator!=): (KXMLCore::PointerHashConstIteratorAdapter::PointerHashConstIteratorAdapter): (KXMLCore::PointerHashConstIteratorAdapter::operator*): (KXMLCore::PointerHashConstIteratorAdapter::operator->): (KXMLCore::PointerHashConstIteratorAdapter::operator++): (KXMLCore::PointerHashConstIteratorAdapter::operator==): (KXMLCore::PointerHashConstIteratorAdapter::operator!=): (KXMLCore::):
  • kxmlcore/HashSet.h: Added. (KXMLCore::identityExtract): (KXMLCore::convertAdapter): (KXMLCore::HashSet::HashSet): (KXMLCore::::size): (KXMLCore::::capacity): (KXMLCore::::isEmpty): (KXMLCore::::begin): (KXMLCore::::end): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::insert): (KXMLCore::::remove): (KXMLCore::::clear):
  • kxmlcore/HashTable.cpp: Added. (KXMLCore::HashTableStats::~HashTableStats): (KXMLCore::HashTableStats::recordCollisionAtCount):
  • kxmlcore/HashTable.h: Added. (KXMLCore::HashTableIterator::skipEmptyBuckets): (KXMLCore::HashTableIterator::HashTableIterator): (KXMLCore::HashTableIterator::operator*): (KXMLCore::HashTableIterator::operator->): (KXMLCore::HashTableIterator::operator++): (KXMLCore::HashTableIterator::operator==): (KXMLCore::HashTableIterator::operator!=): (KXMLCore::HashTableConstIterator::HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator*): (KXMLCore::HashTableConstIterator::operator->): (KXMLCore::HashTableConstIterator::skipEmptyBuckets): (KXMLCore::HashTableConstIterator::operator++): (KXMLCore::HashTableConstIterator::operator==): (KXMLCore::HashTableConstIterator::operator!=): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::~HashTable): (KXMLCore::HashTable::begin): (KXMLCore::HashTable::end): (KXMLCore::HashTable::size): (KXMLCore::HashTable::capacity): (KXMLCore::HashTable::insert): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::isEmptyOrDeletedBucket): (KXMLCore::HashTable::hash): (KXMLCore::HashTable::equal): (KXMLCore::HashTable::identityConvert): (KXMLCore::HashTable::extractKey): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::shouldExpand): (KXMLCore::HashTable::mustRehashInPlace): (KXMLCore::HashTable::shouldShrink): (KXMLCore::HashTable::shrink): (KXMLCore::HashTable::clearBucket): (KXMLCore::HashTable::deleteBucket): (KXMLCore::HashTable::makeLookupResult): (KXMLCore::HashTable::makeIterator): (KXMLCore::HashTable::makeConstIterator): (KXMLCore::::lookup): (KXMLCore::::insert): (KXMLCore::::reinsert): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::remove): (KXMLCore::::allocateTable): (KXMLCore::::expand): (KXMLCore::::rehash): (KXMLCore::::clear): (KXMLCore::::HashTable): (KXMLCore::::swap): (KXMLCore::::operator): (KXMLCore::::checkTableConsistency): (KXMLCore::::checkTableConsistencyExceptSize):
  • kxmlcore/HashTraits.h: Added. (KXMLCore::HashTraits::emptyValue): (KXMLCore::): (KXMLCore::PairHashTraits::emptyValue): (KXMLCore::PairHashTraits::deletedValue):

WebCore:

Reviewed by Eric.

  • ForwardingHeaders/kxmlcore/HashMap.h: Added.
  • ForwardingHeaders/kxmlcore/HashSet.h: Added.
  • ForwardingHeaders/misc/hashmap.h: Removed.
  • ForwardingHeaders/misc/hashset.h: Removed.
  • ForwardingHeaders/misc/pointerhash.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSRuleSet::getIDRules): (khtml::CSSRuleSet::getClassRules): (khtml::CSSRuleSet::getTagRules): (khtml::CSSRuleSet::getUniversalRules): (khtml::CSSRuleSet::addToRuleSet):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/html/html_documentimpl.cpp: (DOM::addItemToMap):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::radioButtonChecked):
  • khtml/html/html_formimpl.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::getNode):
  • khtml/xml/dom_atomicstring.cpp:
  • khtml/xml/dom_qname.cpp:
  • khtml/xml/dom_stringimpl.h: (KXMLCore::): (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/DOM.mm: (ObjCEventListener::ObjCEventListener):
2:04 PM Changeset in webkit [10652] by justing
  • 5 edits in trunk/WebKit

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

1:55 PM Changeset in webkit [10651] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't check if the text dump matches.
1:40 PM Changeset in webkit [10650] by darin
  • 5 edits in trunk
  • layout-tests/fast/js/array-every.html: Fixed test case; one of the tests was using the wrong function, so it wasn't testing what it claimed it was.
  • layout-tests/fast/js/array-every-expected.txt: Updated test result; one section now has a different result.
  • layout-tests/fast/js/const.html: Added a test case that checks that variables after the first in a const declaration are also const; this was broken until my recent change to the JavaScript grammar.
  • layout-tests/fast/js/const-expected.txt: Updated test results.
11:52 AM Changeset in webkit [10649]
  • 51 copies
    22 deletes in tags/WebKit-417

This commit was manufactured by cvs2svn to create tag 'WebKit-417'.

11:52 AM Changeset in webkit [10648]
  • 231 copies
    14 deletes in tags/WebCore-417~1

This commit was manufactured by cvs2svn to create tag
'WebCore-417~1'.

11:52 AM Changeset in webkit [10647] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning to 417 and WebCore-417.1

11:51 AM Changeset in webkit [10646] by darin
  • 6 edits
    3 deletes in trunk/JavaScriptCore

Reviewed by Maciej.

  • update grammar to fix conflicts; fixes one of our test cases because it resolves the relationship between function expressions and declarations in the way required by the ECMA specification
  • kjs/grammar.y: Added lots of new grammar rules so we have no conflicts. A new set of rules for "no bracket or function at start of expression" and another set of rules for "no in anywhere in expression". Also simplified the handling of try to use only a single node and used operator precedence to get rid of the conflict in handling of if and else. Also used a macro to streamline the handling of automatic semicolons and changed parenthesis handling to use a virtual function.
  • kjs/nodes.h: Added nodeInsideAllParens, removed unused abortStatement. (KJS::TryNode::TryNode): Updated to hold catch and finally blocks directly instead of using a special node for each.
  • kjs/nodes.cpp: (Node::createErrorCompletion): Added. Used instead of throwError when creating errors that should not be in a completion rather than an ExecState. (Node::throwUndefinedVariableError): Added. Sets source location unlike the call it replaces. (Node::nodeInsideAllParens): Added. (GroupNode::nodeInsideAllParens): Added. (StatListNode::execute): Removed code to move exceptions into completion objects; that's now done solely by the KJS_CHECKEXCEPTION macro. (TryNode::execute): Include execution of catch and finally here rather than using separate nodes. (FuncDeclNode::execute): Moved here, no longer inline.
  • kjs/nodes2string.cpp: (TryNode::streamTo): Updated for change. (FuncDeclNode::streamTo): Ditto. (FuncExprNode::streamTo): Ditto.
  • kjs/kjs-test: Removed. Was part of "make check".
  • kjs/kjs-test.chk: Ditto.
  • kjs/test.js: Ditto.
  • tests/mozilla/expected.html: Updated because one more test succeeds.
11:47 AM Changeset in webkit [12201] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptGlue

Versioning to 417

11:43 AM Changeset in webkit [10645] by adele
  • 5 edits
    1 add in trunk/WebKit

Reviewed by John.

Moved _downloadWithLoadingConnection and _downloadWithRequestfrom WebDownload.h to WebDownloadInternal.h

  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebDownloadInternal.h: Added.
  • WebKit.xcodeproj/project.pbxproj: Added WebDownloadInternal.h
  • WebView.subproj/WebMainResourceLoader.m: Added import of WebDownloadInternal.h
  • WebView.subproj/WebView.m: ditto.
11:24 AM Changeset in webkit [10644] by thatcher
  • 9 edits in branches/Safari-2-0-branch/WebCore

Merge over of various leak fixes from TOT to Safari-2-0-branch

<rdar://problem/4231952> leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running WebKit tests
<rdar://problem/4231978> many leaks of StyleSurroundData called beneath RenderStyle::setMarginTop, seen running webkit tests
<rdar://problem/4232017> many leaks of StyleInheritedData called from different RenderStyle methods, seen running webkit tests
<rdar://problem/4232175> leak of RenderObject called from RenderContainer::updatePseudoChild, seen running webkit tests
<rdar://problem/4232214> many leaks of RenderStyle from CSSStyleSelector::pseudoStyleForElement, seen running webkit tests
<rdar://problem/4232252> many leaks of RenderStyle called beneath NodeImpl::createRendererIfNeeded, seen running webkit tests
<rdar://problem/4232263> many leaks of RenderObject called from TextImpl::createRenderer, seen running webkit tests
<rdar://problem/4232303> many objects leaked from HTMLTokenizer::parseTag() within -[WebView paste:], seen running webkit tests (probably affects Mail)
<rdar://problem/4232355> leak of DOMStringImpl called from RenderTextFragment::originalString, seen running webkit tests
<rdar://problem/4232371> leak of DOMStringImpl called from DOMStringImpl::substring, seen running webkit tests
<rdar://problem/4232588> many leaks beneath ApplyStyleCommand::mergeEndWithNextIfIdentical, seen running webkit tests (probably affects Mail)
<rdar://problem/4232812> leaks of NodeImpl called from HTMLParser::textCreateErrorCheck, seen running webkit tests
<rdar://problem/4233683> leaks of NodeImpl called from HTMLElementImpl::setOuterText, seen running webkit tests
<rdar://problem/4233690> leaks of StyleBackgroundData called within setBackgroundColor, seen running webkit tests
<rdar://problem/4233701> leaks inside QFontMetrics::setFont, seen running webkit tests
<rdar://problem/4233800> leak inside DOM::DocumentImpl::DocumentImpl, seen running webkit tests
<rdar://problem/4236218> many leaks of StyleBaseImpl within -[WebCoreBridge markupStringFromRange:nodes:] within -[WebHTMLView copy:]
<rdar://problem/4238024> leak of DocumentFragmentImpl if parseXMLDocumentFragment fails
<rdar://problem/4241457> many callers of removeChild are leaking the removed node

  • khtml/editing/markup.cpp: (khtml::createMarkup):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): (HTMLElementImpl::setOuterText):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::setCaption): (HTMLTableElementImpl::setTHead): (HTMLTableElementImpl::setTFoot): (HTMLTableElementImpl::setTBody):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::normalize):
10:48 AM Changeset in webkit [10643] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning of JavaScriptCore-416.10

Note: See TracTimeline for information about the timeline view.