Timeline



Oct 3, 2005:

11:14 PM Changeset in webkit [10727] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 4233558
Submitted by: eseidel
Reviewed by: mjs

Test case for event.view.toString()
<rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

  • fast/events/event-view-toString-expected.txt: Added.
  • fast/events/event-view-toString.html: Added.
11:13 PM Changeset in webkit [10726] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Make mouseDown and mouseUp force layout before acting.
This is used by a new test case for 4233558.

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): force layout (-[EventSendingController mouseUp]): force layout
11:11 PM Changeset in webkit [10725] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4233538
Submitted by: eseidel
Reviewed by: mjs

Fixed AbstractView toString(), by giving it a prototype.
<rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::DOMAbstractView): sets prototype (KJS::DOMAbstractView::getOwnPropertySlot): now getStaticValue (KJS::DOMAbstractViewProtoFunc::callAsFunction): renamed
  • khtml/ecma/kjs_views.h:
10:57 PM Changeset in webkit [10724] by mjs
  • 4 edits in trunk/JavaScriptCore

Patch from George Staikos <​staikos@kde.org>, reviewed and tweaked a bit by me.

  • more Linux build fixes
  • kjs/operations.cpp:
  • kxmlcore/FastMalloc.h:
  • kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
10:42 PM Changeset in webkit [10723] by hyatt
  • 2 edits in trunk/WebCore

Fix regression caused by variable->auto change. Accidentally removed a line of code from calcWidthUsing.

Reviewed by mjs

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidthUsing):
9:08 PM Changeset in webkit [10722] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

Test cases for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

  • fast/events/stopPropagation-checkbox-expected.txt: Added.
  • fast/events/stopPropagation-checkbox.html: Added.
  • fast/events/stopPropagation-submit-expected.txt: Added.
  • fast/events/stopPropagation-submit.html: Added.
9:01 PM Changeset in webkit [10721]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~13

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~13'.

9:01 PM Changeset in webkit [10720] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.13

8:56 PM Changeset in webkit [10719]
  • 209 copies
    15 deletes in tags/WebCore-416~9

This commit was manufactured by cvs2svn to create tag
'WebCore-416~9'.

8:56 PM Changeset in webkit [10718] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Versioning to WebCore-416.9

8:54 PM Changeset in webkit [10717] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Versioning to WebKit-416.10

7:40 PM Changeset in webkit [10716] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Merged fix from TOT to Safari-Den-branch

2005-10-03 Tim Omernick <​tomernick@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):

If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

7:36 PM Changeset in webkit [10715] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Tim Omernick <​tomernick@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):

If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

6:59 PM Changeset in webkit [10714] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/4060947> Safari crashes trying to save PDF file as web archive (NULL KHTMLPart)

  • kwq/WebCoreBridge.mm: (+[WebCoreBridge bridgeForDOMDocument:]): Added a check for a null part.
6:43 PM Changeset in webkit [10713] by mjs
  • 8 edits in trunk/JavaScriptCore

Patch from George Staikos <​staikos@kde.org>, reviewed and tweaked a bit by me.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5174
Add support for compiling on Linux (likely to help for other POSIX systems too)

  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively):
  • kjs/config.h:
  • kjs/date_object.cpp: (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::timeZoneOffset): (KJS::DateProtoFuncImp::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::makeTime):
  • kjs/identifier.cpp:
  • kjs/internal.cpp: (KJS::initializeInterpreterLock): (KJS::lockInterpreter): (KJS::unlockInterpreter): (KJS::UndefinedImp::toPrimitive): (KJS::UndefinedImp::toBoolean): (KJS::UndefinedImp::toNumber): (KJS::UndefinedImp::toString): (KJS::NullImp::toPrimitive): (KJS::NullImp::toBoolean): (KJS::NullImp::toNumber): (KJS::NullImp::toString): (KJS::BooleanImp::toPrimitive): (KJS::BooleanImp::toBoolean): (KJS::BooleanImp::toNumber): (KJS::BooleanImp::toString): (KJS::StringImp::toPrimitive): (KJS::StringImp::toBoolean): (KJS::StringImp::toNumber): (KJS::StringImp::toString):
  • kjs/internal.h:
  • kjs/protected_values.cpp:
6:31 PM Changeset in webkit [10712] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan, Maciej Stachowiak.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]): If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it. This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

5:56 PM Changeset in webkit [10711] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Justin Garcia <​justin.garcia@apple.com>

Fixes <rdar://problem/4275492> REGRESSION (SuTiDenver): EMBED tag with bogus type attribute downloads .wmv file twice (gorillamask.net)

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
5:50 PM Changeset in webkit [10710] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Merged fix from TOT to Safari-Den-branch

2005-10-03 Justin Garcia <​justin.garcia@apple.com>

Fixes <rdar://problem/4275492> REGRESSION (SuTiDenver): EMBED tag with bogus type attribute downloads .wmv file twice (gorillamask.net)

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
4:12 PM Changeset in webkit [10709] by justing
  • 1 edit in trunk/WebCore/khtml/khtml_part.cpp

darin tweaked my previous commit

4:11 PM Changeset in webkit [10708]
  • 1 copy
    7 deletes in tags/post-fm-fixes

This commit was manufactured by cvs2svn to create tag
'post-fm-fixes'.

4:11 PM Changeset in webkit [10707] by justing
  • 2 edits in trunk/WebCore

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
4:00 PM Changeset in webkit [10706] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • add missing config.h
  • khtml/config.h: Added.
3:45 PM Changeset in webkit [10705] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore
  • Fixed <rdar://problem/4244084> Denver Regression: setUTC() functions don't take into account Daylight Savings Time

Reviewed by kevin.

Fix was to roll in this change from TOT:

2005-08-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
  • tests/mozilla/expected.html: Updated for newly fixed test.
3:44 PM Changeset in webkit [10704] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4244084> Denver Regression: setUTC() functions don't take into account Daylight Savings Time

Reviewed by kevin.

Fix was to roll in this change from TOT:

2005-08-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
  • tests/mozilla/expected.html: Updated for newly fixed test.
3:42 PM Changeset in webkit [10703] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix Development build after last checkin
  • kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread):
2:34 PM Changeset in webkit [10702] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

Amusingly this bug existed in 3 different places.

  • khtml/ecma/kjs_events.cpp: (KJS::DOMEventProtoFunc::callAsFunction): Don't let stopPropagation fall through to preventDefault.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::postDispatchEventHandler): Only consider preventDefault for purposes of reverting checkbox/radiobutton state change, not stopPropagation.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): Don't let stopPropagation prevent calling default event handlers; only preventDefault does that.
2:13 PM Changeset in webkit [10701] by mjs
  • 343 edits
    1 add
    1 delete in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

A number of optimizations to the new threadsafe malloc that make it actually as fast
as dlmalloc (I measured wrong before) and as memory-efficient as the system malloc.

  • use fastMalloc for everything - it now gets applied to all new/delete allocations via a private inline operator new that is now included into every file via config.h.
  • tweaked some of the numeric parameters for size classes and amount of wasted memory allowed per allocation - this saves on memory use and consequently improves speed.
  • so long as the allocator is not being used on background threads, get the per-thread cache from a global variable instead of from pthread_getspecific, since the latter is slow.
  • inline more functions, and force the ones GCC refuses to inline with attribute(always_inline), nearly all of these have one call site so inlining them has to be a win.
  • use some tricks to calculate allocation size more efficiently and fewer times for small allocations, to avoid hitting the huge size table array.
  • avoid hitting the per-thread cache on code paths that don't need it.
  • implement inline assembly version of spinlock for PowerPC (was already done for x86)
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_class.cpp:
  • bindings/c/c_instance.cpp:
  • bindings/c/c_runtime.cpp:
  • bindings/c/c_utility.cpp:
  • bindings/jni/jni_class.cpp:
  • bindings/jni/jni_instance.cpp:
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_objc.mm:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_utility.cpp:
  • bindings/npruntime.cpp:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/objc_class.mm:
  • bindings/objc/objc_instance.mm:
  • bindings/objc/objc_runtime.mm:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.cpp:
  • bindings/runtime_array.cpp:
  • bindings/runtime_method.cpp:
  • bindings/runtime_object.cpp:
  • bindings/runtime_root.cpp:
  • bindings/testbindings.cpp:
  • bindings/testbindings.mm:
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): (ArrayInstanceImp::~ArrayInstanceImp): (ArrayInstanceImp::resizeStorage):
  • kjs/bool_object.cpp:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • kjs/config.h:
  • kjs/debugger.cpp:
  • kjs/error_object.cpp:
  • kjs/function.cpp:
  • kjs/function_object.cpp:
  • kjs/identifier.cpp: (KJS::Identifier::rehash):
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): (KJS::clearNewNodes):
  • kjs/interpreter.cpp:
  • kjs/lexer.cpp: (Lexer::doneParsing): (Lexer::makeIdentifier): (Lexer::makeUString):
  • kjs/list.cpp:
  • kjs/math_object.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
  • kjs/object.cpp:
  • kjs/object_object.cpp:
  • kjs/property_map.cpp:
  • kjs/property_slot.cpp:
  • kjs/protected_values.cpp: (KJS::ProtectedValues::rehash):
  • kjs/reference.cpp:
  • kjs/reference_list.cpp:
  • kjs/regexp.cpp:
  • kjs/regexp_object.cpp:
  • kjs/scope_chain.cpp:
  • kjs/scope_chain.h:
  • kjs/string_object.cpp:
  • kjs/testkjs.cpp:
  • kjs/ustring.h:
  • kjs/value.cpp:
  • kxmlcore/Assertions.mm:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::InitSizeClasses): (KXMLCore::DLL_IsEmpty): (KXMLCore::DLL_Prepend): (KXMLCore::TCMalloc_Central_FreeList::Insert): (KXMLCore::TCMalloc_Central_FreeList::Remove): (KXMLCore::TCMalloc_Central_FreeList::Populate): (KXMLCore::TCMalloc_ThreadCache::Allocate): (KXMLCore::TCMalloc_ThreadCache::FetchFromCentralCache): (KXMLCore::fastMallocRegisterThread): (KXMLCore::TCMalloc_ThreadCache::GetCache): (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent): (KXMLCore::TCMalloc_ThreadCache::CreateCacheIfNecessary): (KXMLCore::do_malloc): (KXMLCore::do_free): (KXMLCore::realloc):
  • kxmlcore/FastMalloc.h: (operator new): (operator delete): (operator new[]): (operator delete[]):
  • kxmlcore/HashTable.cpp:
  • kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • kxmlcore/TCSystemAlloc.cpp:

WebCore:

Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

  • use fastMalloc for everything - it now gets applied to all new/delete allocations via a private inline operator new that is now included into every file via config.h
  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • khtml/css/css_base.cpp:
  • khtml/css/css_base.h:
  • khtml/css/css_computedstyle.cpp:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssparser.cpp: (ValueList::ValueList): (ValueList::~ValueList): (ValueList::addValue): (CSSParser::CSSParser): (CSSParser::~CSSParser): (CSSParser::setupParser): (CSSParser::addProperty):
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_misc.cpp:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Gradient::~Gradient): (KJS::Gradient::addColorStop): (KJS::Gradient::colorStops):
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/ecma/kjs_proxy.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/merge_identical_elements_command.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/remove_css_property_command.cpp:
  • khtml/editing/remove_node_attribute_command.cpp:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/set_node_attribute_command.cpp:
  • khtml/editing/split_element_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_range.cpp:
  • khtml/editing/visible_text.cpp: (khtml::CircularSearchBuffer::~CircularSearchBuffer): (khtml::CircularSearchBuffer::CircularSearchBuffer):
  • khtml/editing/visible_units.cpp:
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_miscimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlnames.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::enlargeBuffer): (khtml::HTMLTokenizer::enlargeScriptBuffer):
  • khtml/khtml_events.cpp:
  • khtml/khtml_part.cpp:
  • khtml/khtmlview.cpp:
  • khtml/misc/arena.cpp:
  • khtml/misc/arena.h:
  • khtml/misc/decoder.cpp:
  • khtml/misc/formdata.cpp:
  • khtml/misc/helper.cpp:
  • khtml/misc/loader.cpp:
  • khtml/misc/stringit.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/break_lines.cpp:
  • khtml/rendering/font.cpp:
  • khtml/rendering/render_arena.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::~RenderCanvasImage): (RenderCanvasImage::createDrawingContext):
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_flexbox.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_style.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_text.cpp:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/rendering/table_layout.cpp:
  • khtml/xbl/xbl_binding.cpp:
  • khtml/xbl/xbl_binding_manager.cpp:
  • khtml/xbl/xbl_docimpl.cpp:
  • khtml/xbl/xbl_protobinding.cpp:
  • khtml/xbl/xbl_protohandler.cpp:
  • khtml/xbl/xbl_protoimplementation.cpp:
  • khtml/xbl/xbl_tokenizer.cpp:
  • khtml/xml/EventNames.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.cpp:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_atomicstring.cpp:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_qname.cpp:
  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_textimpl.cpp:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/DOM-CSS.mm:
  • kwq/DOM.mm:
  • kwq/DOMEvents.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm: (DOMString::DOMString):
  • kwq/DOMUtility.mm:
  • kwq/DOMViews.mm:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQApplication.mm:
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQBuffer.mm:
  • kwq/KWQButton.mm:
  • kwq/KWQCString.mm:
  • kwq/KWQCharsets.mm:
  • kwq/KWQClipboard.mm:
  • kwq/KWQCollection.mm:
  • kwq/KWQColor.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQCursor.mm:
  • kwq/KWQDateTime.mm:
  • kwq/KWQDictImpl.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQEvent.mm:
  • kwq/KWQExceptions.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontFamily.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQFormData.mm:
  • kwq/KWQFrame.mm:
  • kwq/KWQGlobal.mm:
  • kwq/KWQGuardedPtr.mm:
  • kwq/KWQKCharsets.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKCookieJar.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKGlobal.mm:
  • kwq/KWQKGlobalSettings.mm:
  • kwq/KWQKHTMLFactory.mm:
  • kwq/KWQKHTMLPart.cpp:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKHTMLView.mm:
  • kwq/KWQKHistoryProvider.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQKJob.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKPartsBrowserInterface.mm:
  • kwq/KWQKPartsEvent.mm:
  • kwq/KWQKPartsPart.mm:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQKStandardDirs.mm:
  • kwq/KWQKStringHandler.mm:
  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (encodeRelativeString):
  • kwq/KWQKWin.mm:
  • kwq/KWQKWinModule.mm:
  • kwq/KWQLabel.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQListImpl.mm:
  • kwq/KWQLoader.mm: (KWQIsResponseURLEqualToURL):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQMovie.mm:
  • kwq/KWQObject.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPaintDeviceMetrics.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQPalette.mm:
  • kwq/KWQPen.mm:
  • kwq/KWQPixmap.mm:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.mm:
  • kwq/KWQPtrDictImpl.mm:
  • kwq/KWQPushButton.mm:
  • kwq/KWQRect.mm:
  • kwq/KWQRegExp.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQResourceLoader.mm:
  • kwq/KWQScrollBar.mm:
  • kwq/KWQScrollView.mm:
  • kwq/KWQSignal.mm:
  • kwq/KWQSignalStubs.mm:
  • kwq/KWQSize.mm:
  • kwq/KWQSlider.mm:
  • kwq/KWQSlot.mm:
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (ALLOC_CHAR): (REALLOC_CHAR): (DELETE_CHAR): (ALLOC_QCHAR): (REALLOC_QCHAR): (DELETE_QCHAR): (_printQStringAllocationStatistics): (allocateHandle): (KWQStringData::operator new): (KWQStringData::operator delete): (freeHandle):
  • kwq/KWQStringList.mm:
  • kwq/KWQStyle.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextCodec.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQTextStream.mm:
  • kwq/KWQTextUtilities.mm:
  • kwq/KWQTimer.mm:
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm:
  • kwq/KWQVariant.mm:
  • kwq/KWQVectorImpl.mm: (KWQVectorImpl::KWQVectorImpl): (KWQVectorImpl::~KWQVectorImpl): (KWQVectorImpl::clear): (KWQVectorImpl::resize): (KWQVectorImpl::assign):
  • kwq/KWQWMatrix.mm:
  • kwq/KWQWidget.mm:
  • kwq/KWQWindowWidget.mm:
  • kwq/WebCoreBridge.mm:
  • kwq/WebCoreCache.mm:
  • kwq/WebCoreEncodings.mm:
  • kwq/WebCoreJavaScript.mm:
  • kwq/WebCoreScriptDebugger.mm:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • kwq/can-convert.mm:
1:55 PM Changeset in webkit [10700]
  • 1 copy
    7 deletes in tags/pre-fm-fixes

This commit was manufactured by cvs2svn to create tag 'pre-fm-fixes'.

1:55 PM Changeset in webkit [10699] by bdakin
  • 7 edits
    2 adds in trunk

* empty log message *

1:55 AM Changeset in webkit [10698] by eseidel
  • 2 edits
    5 adds in trunk

Bug #: 5239
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes hang, caused by path parser spinning forever.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5239

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
  • svg-tests/custom/path-bad-data-expected.checksum: Added.
  • svg-tests/custom/path-bad-data-expected.png: Added.
  • svg-tests/custom/path-bad-data-expected.txt: Added.
  • svg-tests/custom/path-bad-data.svg: Added.

Oct 2, 2005:

11:21 PM Changeset in webkit [10697] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5209
Submitted by: eseidel
Reviewed by: darin

Closes large memory leak in KSVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5209

  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attach): delete orphans unless PatternImpl
11:15 PM Changeset in webkit [10696] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 5132
Submitted by: eseidel
Reviewed by: mjs

Fixes SVG animation support in Safari/WebKit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5132

  • WebCore+SVG/dom_kdomnodetreewrapper.cpp: (KDOMNodeTreeWrapperImpl::attach): setup kcanvasviewquartz (KDOMNodeTreeWrapperImpl::detach): tear down kcanvasviewquartz
  • WebCore+SVG/dom_kdomnodetreewrapper.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.mm: fix spaces (KCanvasViewQuartz::KCanvasViewQuartz): (KCanvasViewQuartz::~KCanvasViewQuartz): (KCanvasViewQuartz::view): (KCanvasViewQuartz::setView): (KCanvasViewQuartz::renderObject): alternative to view (KCanvasViewQuartz::setRenderObject): (KCanvasViewQuartz::invalidateCanvasRect): (KCanvasViewQuartz::viewToCanvasMatrix): (KCanvasViewQuartz::canvasSizeChanged): (KCanvasViewQuartz::viewHeight): (KCanvasViewQuartz::viewWidth):
11:08 PM Changeset in webkit [10695] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • fast/xsl/xslt-url-expected.txt: Added.
  • fast/xsl/xslt-url.xml: Added.
  • fast/xsl/xslt-url.xsl: Added.
11:02 PM Changeset in webkit [10694] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

Fix XSLT to preserve document.URL.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
10:21 PM Changeset in webkit [10693] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5238
Submitted by: eseidel
Reviewed by: mjs

Fix crash when encountering XML processing directives w/ KDOM:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5238

  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::recalcStyleSelector): null check.
12:51 PM Changeset in webkit [10692] by eseidel
  • 2 edits
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, removing unused svg files only.

Removing unused SVG source files.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/ecma/Constructors.cpp: Removed.
  • ksvg2/ecma/Constructors.h: Removed.
10:17 AM Changeset in webkit [10691] by andersca
  • 3 edits in trunk/WebCore

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::localName): (AttrImpl::namespaceURI):
  • khtml/xml/dom_elementimpl.h: Implement localName and namespaceURI for attributes.
10:15 AM Changeset in webkit [10690] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/dom/attribute-namespaces-expected.txt: Added.
  • fast/dom/attribute-namespaces.xhtml: Added.

Sep 30, 2005:

11:28 PM Changeset in webkit [10689] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
11:14 PM Changeset in webkit [10688]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~12

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~12'.

11:14 PM Changeset in webkit [10687] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.12, also amending the ChangeLog to show the correct reviewer.

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
7:52 PM Changeset in webkit [10686] by thatcher
  • 3 edits in branches/Safari-Den-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Reviewed by Geoff someone.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
4:18 PM Changeset in webkit [10685] by eseidel
  • 1 add in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved WebCore/layout-tests to LayoutTests

2:52 PM Changeset in webkit [10684] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved layout-tests to ../LayoutTests

2:44 PM Changeset in webkit [10683] by eseidel
  • 6 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Updated all the scripts for the move:
WebCore/layout-tests -> LayoutTests

  • Scripts/check-dom-results:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-webkit-tests:
  • Scripts/update-webkit: added --no-tests
  • checkout: added --no-tests
10:57 AM Changeset in webkit [10682]
  • 68 copies
    5 deletes in tags/JavaScriptCore-417~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~1'.

10:57 AM Changeset in webkit [10681] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.1

10:55 AM Changeset in webkit [10680] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-29 Geoffrey Garen <​ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
10:47 AM Changeset in webkit [10679]
  • 81 copies
    5 deletes in tags/JavaScriptCore-416~11

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~11'.

10:47 AM Changeset in webkit [10678] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.11

10:45 AM Changeset in webkit [10677] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-29 Geoffrey Garen <​ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
9:35 AM Changeset in webkit [10676] by ggaren
  • 2 edits in trunk

Patch reviewed by john.

  • layout-tests/fast/js/date-parse-test.html: Added a test case for <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com
9:16 AM Changeset in webkit [10675] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by john.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)

Added test case to fast/js/date-parse-test.html.

12:03 AM Changeset in webkit [10674]
  • 52 copies
    22 deletes in tags/WebKit-416~9

This commit was manufactured by cvs2svn to create tag 'WebKit-416~9'.

12:03 AM Changeset in webkit [10673] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Versioning to WebKit-416.9

Sep 29, 2005:

11:59 PM Changeset in webkit [10672]
  • 52 copies
    22 deletes in tags/WebKit-417~1

This commit was manufactured by cvs2svn to create tag 'WebKit-417~1'.

11:59 PM Changeset in webkit [10671] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.1

11:53 PM Changeset in webkit [10670] by thatcher
  • 5 edits in branches/Safari-Den-branch/WebKit

Merged fix from TOT to Safari-Den-branch

2005-09-28 Justin Garcia <​justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

11:50 PM Changeset in webkit [10669] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-09-28 Justin Garcia <​justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

10:06 PM Changeset in webkit [10668]
  • 234 copies
    14 deletes in tags/WebCore-417~2

This commit was manufactured by cvs2svn to create tag
'WebCore-417~2'.

10:06 PM Changeset in webkit [10667] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.2

9:57 PM Changeset in webkit [10666] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merge over of various leak fixes from TOT to Safari-2-0-branch

2005-09-29 Timothy Hatcher <​timothy@apple.com>

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
9:04 PM Changeset in webkit [10665] by thatcher
  • 7 edits in trunk/WebCore

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQPoint.mm: ditto
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQRect.mm: ditto
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
  • kwq/KWQSize.mm: ditto
5:03 PM Changeset in webkit [10664] by hyatt
  • 7 edits in trunk/WebCore

Add support for parsing of the CSS3 box-sizing property. This
property will have to be fully implemented for form controls that
respect border and padding (buttons, textfields, list boxes, etc.).

Reviewed by john

Test cases added: (NONE, property just being parsed, not supported)

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssvalues.in:
  • khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::setBoxSizing): (khtml::RenderStyle::initialBoxSizing):
3:05 PM Changeset in webkit [10663] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5176
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: darin

Fix JSC memory smasher in TOT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5176

  • pcre/pcre_exec.c: (match):
1:10 PM Changeset in webkit [10662] by hyatt
  • 19 edits in trunk/WebCore

Make all form controls treat width: auto as width:intrinsic and
add support for intrinsic widths when computing sizes of
block-level flows.

Rename the term Variable to Auto, since this more accurately
matches the term in the CSS spec.

Reviewed by darin

Test cases added: (None needed, <button> and <legend> test this)

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/misc/khtmllayout.h: (khtml::): (khtml::Length::width): (khtml::Length::minWidth): (khtml::Length::isAuto): (khtml::Length::isIntrinsicOrAuto):
  • khtml/rendering/bidi.cpp: (khtml::getBPMWidth):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::MarginInfo::MarginInfo): (khtml::RenderBlock::isSelfCollapsingBlock): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::determineHorizontalPosition): (khtml::getBPMWidth): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::shouldCheckLines):
  • khtml/rendering/render_box.cpp: (RenderBox::getClipRect): (RenderBox::relativePositionOffset): (RenderBox::calcWidth): (RenderBox::calcWidthUsing): (RenderBox::sizesToIntrinsicWidth): (RenderBox::calcHorizontalMargins): (RenderBox::calcHeight): (RenderBox::calcHeightUsing): (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSlider::calcMinMaxWidth):
  • khtml/rendering/render_layer.cpp: (khtml::Marquee::updateMarqueeStyle):
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::marginLeft): (khtml::InlineFlowBox::marginRight):
  • khtml/rendering/render_object.cpp: (RenderObject::hasStaticX): (RenderObject::hasStaticY): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight): (RenderObject::usesLineWidth):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
  • khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::resetPadding): (khtml::RenderStyle::initialPadding):
  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTableSection::addCell): (RenderTableSection::layoutRows):
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::setCheckboxSize): (khtml::RenderThemeMac::setRadioSize):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (FixedTableLayout::layout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (shouldScaleColumns): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):
12:47 AM Changeset in webkit [10661] by justing
  • 9 edits
    11 adds in trunk

Reviewed by harrison

<rdar://problem/4278698> Adding a space inside whitespace:pre text collapses space
<rdar://problem/4076267> Mail behaves oddly when pasting in text with leading/trailing whitespace
<rdar://problem/4063751> Redo Typing can add extra space characters
<rdar://problem/4120558> Mail/WebKit: Repeated capitalizeWord command deletes spaces and does not capitalize

Reblance whitespace was finding the extent of surrounding whitespace incorrectly.
createFragmentFromMarkup was not dealing with the special cases for spaces at the start/end
of a line. InsertTextCommand was removing collapsable whitespace without regard for the
whitespace mode. createFragmentFromMarkup and RebalanceWhitespace command now use one method
to produce rebalanced sequences. Removed special case whitespace handling from
InsertTextCommand, that's RebalanceWhiteSpaceCommand's job.

Test cases added:

  • layout-tests/editing/inserting/4278698.html: Added.
  • layout-tests/editing/pasteboard/4076267-2.html: Added.
  • layout-tests/editing/pasteboard/4076267-3.html: Added.
  • layout-tests/editing/pasteboard/4076267.html: Added.
  • layout-tests/editing/undo/4063751.html: Added.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::rebalanceWhitespaceAt): Added. The old convenience method, rebalanceWhitespace, can probably be removed, because there is never a non-caret selection after an editing command.
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/htmlediting.cpp: (khtml::rebalanceWhitespaceInTextNode):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
  • khtml/editing/rebalance_whitespace_command.cpp: (khtml::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): (khtml::isWhitespace): Changed from isNBSP to include all forms of whitespace, to aid readability. (khtml::RebalanceWhitespaceCommand::doApply): (khtml::RebalanceWhitespaceCommand::doUnapply): Removed the unused m_downstreamOffset
  • layout-tests/editing/editingStyle.css: Added.
12:24 AM Changeset in webkit [10660] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5179
Submitted by: Mitz Pettel <​opendarwin.org@mitzpettel.com>
Reviewed by: mjs

Note: See TracTimeline for information about the timeline view.