Timeline



Oct 5, 2005:

11:38 PM Changeset in webkit [10761] by vicki
  • 1 edit
    4 adds in trunk/LayoutTests

Test cases for <rdar://problem/4288829> repro crash on isIndex tag with no attributes

This test case will have to be updated once <rdar://problem/4288839> (isindex tag alone in
document doesn't end up in the DOM) is fixed

  • fast/dom/isindex-alone-expected.checksum: Added.
  • fast/dom/isindex-alone-expected.png: Added.
  • fast/dom/isindex-alone-expected.txt: Added.
  • fast/dom/isindex-alone.html: Added.
11:31 PM Changeset in webkit [10760] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4288829> repro crash on isIndex tag with no attributes
  • khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex): only deref attributes if they exist
11:22 PM Changeset in webkit [10759] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Test cases for <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)

  • ChangeLog:
  • fast/dom/early-frame-url-expected.txt: Added.
  • fast/dom/early-frame-url.html: Added.
  • fast/dom/resources/a.html: Added.
  • fast/dom/resources/b.html: Added.
9:36 PM Changeset in webkit [12202] by mjs
  • 5 edits in trunk/JavaScriptGlue

Forgot to commit this to TOT way back when; will be useful when actually porting JSGlue.

Reviewed by Geoff.

  • fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

  • JSUtils.cpp: (CFStringToUString): (JSObjectKJSValue): (KJSValueToCFTypeInternal):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JavaScriptGlue.cpp: (JSCollect):
9:13 PM Changeset in webkit [10758] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.
6:13 PM Changeset in webkit [10757] by ggaren
  • 12 edits in trunk/JavaScriptCore
  • Darin and I rewrote our implementation of the SimpleNumber class to store number bit patterns in their floating point formats.

My tweaks reviewed by Darin.

~1% speedup on JS iBench.

  • kjs/internal.h: removed obsolete jsNumber declarations.
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction): changed KJS::isNaN to isNaN
  • kjs/nodes.cpp: (PostfixResolveNode::evaluate): removed obsolete knownToBeInteger (PostfixBracketNode::evaluate): ditto (PostfixDotNode::evaluate): ditto (PrefixResolveNode::evaluate): ditto (PrefixBracketNode::evaluate): ditto (PrefixDotNode::evaluate): ditto (NegateNode::evaluate): ditto (valueForReadModifyAssignment): ditto
  • kjs/number_object.cpp: removed obsolete comment
  • kjs/operations.cpp: (KJS::equal): removed unnecessary isNaN checks (KJS::strictEqual): ditto (KJS::add): removed obsolete knownToBeInteger (KJS::mult): ditto
  • kjs/operations.h: removed include of "value.h" to prevent circular reference
  • kjs/simple_number.h: removed unnecessary #includes (KJS::SimpleNumber::make): see above (KJS::SimpleNumber::is): ditto (KJS::SimpleNumber::value): ditto
  • kjs/string_object.cpp: (StringProtoFuncImp::callAsFunction): changed KJS::isNaN to isNaN
  • kjs/ustring.cpp: removed unnecessary isNaN check (KJS::UString::toUInt32): ditto
  • kjs/value.cpp: (KJS::jsNumber): removed obsolete jsNumber definitions (KJS::ConstantValues::init): NaN is no longer a ConstantValue (KJS::ConstantValues::clear): ditto (KJS::ConstantValues::mark): ditto
  • kjs/value.h: removed obsolete knownToBeInteger (KJS::jsNaN): now returns a SimpleNumber (KJS::ValueImp::getUInt32): changed to account for NaN being a SimpleNumber (KJS::ValueImp::toBoolean): ditto (KJS::ValueImp::toString): changed to account for +/- 0.0 (KJS::jsZero): changed to reflect that SimpleNumber::make takes a double (KJS::jsOne): ditto (KJS::jsTwo): ditto (KJS::Number): removed obsolete non-double constructor declarations
6:00 PM Changeset in webkit [10756] by thatcher
  • 2 edits
    1 add in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4269934> JavaScriptCore needs to limit its exports

Reviewed by Geoff.

5:54 PM Changeset in webkit [10755] by harrison
  • 29 edits in trunk/WebCore

Reviewed by Darin.

No test cases added or changed because this patch does not address a bug.

For clarity, renamed the "detach()" function to "destroy()" in the following classes:
RenderObject (and subclasses), BidiRun, ClipRects, InlineBox (and subclasses).

  • khtml/rendering/bidi.cpp: (khtml::BidiRun::destroy): (khtml::BidiRun::operator delete): (khtml::deleteBidiRuns):
  • khtml/rendering/bidi.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::destroy): (RenderBox::dirtyLineBoxes): (RenderBox::position): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::updatePseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::deleteLineBoxes): (RenderFlow::destroy):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderTextArea::destroy):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_layer.cpp: (khtml::ClipRects::operator delete): (khtml::ClipRects::destroy): (khtml::RenderLayer::operator delete): (khtml::RenderLayer::destroy): (khtml::RenderLayer::removeOnlyThisLayer):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::deref):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::destroy): (khtml::InlineBox::operator delete): (khtml::InlineBox::deleteLine): (khtml::InlineFlowBox::deleteLine): (khtml::RootInlineBox::destroy): (khtml::RootInlineBox::detachEllipsisBox):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::destroy):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::operator delete): (RenderObject::destroy):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::operator delete):
  • khtml/rendering/render_table.cpp: (RenderTableSection::destroy): (RenderTableRow::destroy): (RenderTableRow::removeChildNode): (RenderTableCell::destroy):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (InlineTextBox::destroy): (InlineTextBox::operator delete): (InlineTextBox::deleteLine): (RenderText::destroy): (RenderText::deleteTextBoxes): (RenderText::position):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach):
2:07 PM Changeset in webkit [10754] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/4158439> Safari appears to hang when sending synchronous XMLHttpRequest that gets no server response

No testcase - not testable w/o network.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Set a timeout of 10.
1:54 PM Changeset in webkit [10753] by justing
  • 1 edit
    14 adds in trunk/LayoutTests

Reviewed by beth

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5245>
Adding missing pixel results for test cases checked in recently.

  • editing/inserting/4278698-expected.checksum: Added.
  • editing/inserting/4278698-expected.png: Added.
  • editing/pasteboard/4076267-2-expected.checksum: Added.
  • editing/pasteboard/4076267-2-expected.png: Added.
  • editing/pasteboard/4076267-3-expected.checksum: Added.
  • editing/pasteboard/4076267-3-expected.png: Added.
  • editing/pasteboard/4076267-expected.checksum: Added.
  • editing/pasteboard/4076267-expected.png: Added.
  • editing/undo/4063751-expected.checksum: Added.
  • editing/undo/4063751-expected.png: Added.
  • fast/css/imageTileOpacity-expected.checksum: Added.
  • fast/css/imageTileOpacity-expected.png: Added.
  • fast/forms/textAreaLineHeight-expected.checksum: Added.
  • fast/forms/textAreaLineHeight-expected.png: Added.
9:18 AM Changeset in webkit [10752]
  • 209 copies
    15 deletes in tags/WebCore-416~10

This commit was manufactured by cvs2svn to create tag
'WebCore-416~10'.

9:18 AM Changeset in webkit [10751] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Versioning to WebCore-416.10

9:11 AM Changeset in webkit [10750] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
9:09 AM Changeset in webkit [10749] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Merged fix from TOT to Safari-Den-branch

2005-10-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
3:31 AM Changeset in webkit [10748] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::URL): if the URL is empty, return "about:blank", the JS DOM at least counts on this, so we may as well do it for other languages too. (DOM::DocumentImpl::baseURL): base it on URL(), not m_url
1:21 AM Changeset in webkit [10747] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Improves dependency checking so that SVG JavaScript wrapper files
regenerate when the perl scripts change.

  • WebCore.xcodeproj/project.pbxproj:
1:18 AM Changeset in webkit [10746]
  • 1 copy
    7 deletes in tags/mjs-perf-slow-2

This commit was manufactured by cvs2svn to create tag
'mjs-perf-slow-2'.

1:18 AM Changeset in webkit [10745] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5175
Submitted by: eseidel
Reviewed by: mjs

Makes <object> tags not use image mode for svg content:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5175

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
1:05 AM Changeset in webkit [10744] by mjs
  • 14 edits
    4 adds
    5 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • fixed <rdar://problem/4260481> Remove Reference type from JavaScriptCore

Also fixed some bugs with for..in enumeration while I was at it. object
properties now come before prototype properties and duplicates
between object and prototype are listed only once.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/IdentifierSequencedSet.cpp: Added. (KJS::IdentifierSequencedSet::IdentifierSequencedSet): (KJS::IdentifierSequencedSet::deallocateVector): (KJS::IdentifierSequencedSet::~IdentifierSequencedSet): (KJS::IdentifierSequencedSet::insert):
  • kjs/IdentifierSequencedSet.h: Added. (KJS::IdentifierSequencedSetIterator::IdentifierSequencedSetIterator): (KJS::IdentifierSequencedSetIterator::operator*): (KJS::IdentifierSequencedSetIterator::operator->): (KJS::IdentifierSequencedSetIterator::operator++): (KJS::IdentifierSequencedSetIterator::operator==): (KJS::IdentifierSequencedSetIterator::operator!=): (KJS::IdentifierSequencedSet::begin): (KJS::IdentifierSequencedSet::end): (KJS::IdentifierSequencedSet::size):
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::getPropertyNames): (ArrayInstanceImp::setLength): (ArrayInstanceImp::pushUndefinedObjectsToEnd):
  • kjs/nodes.cpp: (ForInNode::execute):
  • kjs/nodes.h:
  • kjs/object.cpp: (KJS::ObjectImp::getPropertyNames):
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::getSparseArrayPropertyNames):
  • kjs/property_map.h:
  • kjs/protect.h:
  • kjs/protected_reference.h: Removed.
  • kjs/reference.cpp: Removed.
  • kjs/reference.h: Removed.
  • kjs/reference_list.cpp: Removed.
  • kjs/reference_list.h: Removed.
  • kjs/ustring.h: (KJS::UString::impl):
  • kxmlcore/HashSet.h:

LayoutTests:

Reviewed by Eric.

  • test case for some fixes I made to for..in enumeration. object properties now come before prototype properties and duplicates between object and prototype are listed only once.
  • fast/js/for-in-expected.txt: Added.
  • fast/js/for-in.html: Added.
12:50 AM Changeset in webkit [10743] by mjs
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: Add JS binding for isSameNode.

(KJS::DOMNode::):

  • khtml/xml/dom_nodeimpl.h: Implement isSameNode.

(DOM::NodeImpl::isSameNode):

  • kwq/DOM.mm: (-[DOMNode isSameNode:]): Add ObjC binding for isSameNode.
12:26 AM Changeset in webkit [10742] by andersca
  • 5 edits in trunk/WebCore

2005-10-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: Add JS binding for isSameNode.

(KJS::DOMNode::):

  • khtml/xml/dom_nodeimpl.h: Implement isSameNode.

(DOM::NodeImpl::isSameNode):

  • kwq/DOM.mm: (-[DOMNode isSameNode:]): Add ObjC binding for isSameNode.
12:14 AM Changeset in webkit [10741]
  • 1 copy
    7 deletes in tags/mjs-perf-fast-2

This commit was manufactured by cvs2svn to create tag
'mjs-perf-fast-2'.

12:14 AM Changeset in webkit [10740] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed a random crasher that happens because the HTMLParser accidentally was refing the document.

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/html/htmlparser.cpp: (HTMLStackElem::HTMLStackElem): (HTMLStackElem::~HTMLStackElem): (HTMLParser::popNestedHeaderTag): (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::popOneBlock):
12:11 AM Changeset in webkit [10739] by andersca
  • 8 edits
    2 adds in trunk/LayoutTests

2005-10-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • dom/xhtml/level3/core/nodeissamenode01-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode02-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode03-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode04-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode05-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode06-expected.txt:
  • dom/xhtml/level3/core/nodeissamenode10-expected.txt: These tests pass now.
12:01 AM Changeset in webkit [10738] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):

Oct 4, 2005:

11:09 PM Changeset in webkit [10737] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs

Test direct name lookup in DOMNamedNodeMap, like FireFox/IE.
<rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

  • fast/dom/namednodemap-namelookup-expected.txt: Added.
  • fast/dom/namednodemap-namelookup.html: Added.
11:08 PM Changeset in webkit [10736]
  • 1 copy
    7 deletes in tags/mjs-perf-fast-1

This commit was manufactured by cvs2svn to create tag
'mjs-perf-fast-1'.

11:08 PM Changeset in webkit [10735] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs

Support direct named attribute lookkup, like FireFox,IE.
This was causing a JavaScript exception for gap.com
<rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::getOwnPropertySlot): if cleanup (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h: added nameGetter
10:36 PM Changeset in webkit [10734] by eseidel
  • 312 edits in trunk

Bug #: 5254
Submitted by: eseidel
Reviewed by: none needed, build fix only.

Fix to include "config.h" in every file.
Necessary to support fastMalloc.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5254

  • WebCore+SVG/DrawCanvasItem.mm:
  • WebCore+SVG/DrawDocument.mm:
  • WebCore+SVG/DrawView.mm:
  • WebCore+SVG/dom_kdomdocumentwrapper.cpp:
  • WebCore+SVG/dom_kdomnodetreewrapper.cpp:
  • WebCore+SVG/render_kcanvaswrapper.cpp:
  • WebCore+SVG/xml_kdomtokenizer.cpp:
  • kcanvas/KCanvas.cpp:
  • kcanvas/KCanvasContainer.cpp:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasImage.cpp:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasRegistry.cpp:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/KCanvasView.cpp:
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDeviceFactory.cpp:
  • kcanvas/device/KRenderingFillPainter.cpp:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerImage.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/KRenderingStrokePainter.cpp:
  • kcanvas/device/KRenderingStyle.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KCanvasViewQuartz.mm:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • kdom/DOMString.cpp:
  • kdom/Helper.cpp:
  • kdom/KDOMPart.cpp:
  • kdom/KDOMSettings.cpp:
  • kdom/KDOMView.cpp:
  • kdom/Shared.cpp:
  • kdom/backends/libxml/LibXMLParser.cpp:
  • kdom/bindings/IDLCodeGeneratorEcmaInterface.pm:
  • kdom/bindings/IDLCodeGeneratorJs.pm:
  • kdom/cache/ImageSource.cpp:
  • kdom/cache/KDOMCache.cpp:
  • kdom/cache/KDOMCachedDocument.cpp:
  • kdom/cache/KDOMCachedImage.cpp:
  • kdom/cache/KDOMCachedObject.cpp:
  • kdom/cache/KDOMCachedScript.cpp:
  • kdom/cache/KDOMCachedStyleSheet.cpp:
  • kdom/cache/KDOMLoader.cpp:
  • kdom/core/AttrImpl.cpp:
  • kdom/core/CDATASectionImpl.cpp:
  • kdom/core/CDFInterface.cpp:
  • kdom/core/CharacterDataImpl.cpp:
  • kdom/core/CommentImpl.cpp:
  • kdom/core/DOMConfigurationImpl.cpp:
  • kdom/core/DOMErrorHandlerImpl.cpp:
  • kdom/core/DOMErrorImpl.cpp:
  • kdom/core/DOMExceptionImpl.cpp:
  • kdom/core/DOMImplementationImpl.cpp:
  • kdom/core/DOMLocatorImpl.cpp:
  • kdom/core/DOMObjectImpl.cpp:
  • kdom/core/DOMStringImpl.cpp:
  • kdom/core/DOMStringListImpl.cpp:
  • kdom/core/DOMUserDataImpl.cpp:
  • kdom/core/DocumentFragmentImpl.cpp:
  • kdom/core/DocumentImpl.cpp:
  • kdom/core/DocumentTypeImpl.cpp:
  • kdom/core/ElementImpl.cpp:
  • kdom/core/EntityImpl.cpp:
  • kdom/core/EntityReferenceImpl.cpp:
  • kdom/core/NamedAttrMapImpl.cpp:
  • kdom/core/NamedNodeMapImpl.cpp:
  • kdom/core/NodeImpl.cpp:
  • kdom/core/NodeListImpl.cpp:
  • kdom/core/NotationImpl.cpp:
  • kdom/core/ProcessingInstructionImpl.cpp:
  • kdom/core/TagNodeListImpl.cpp:
  • kdom/core/TextImpl.cpp:
  • kdom/core/TypeInfoImpl.cpp:
  • kdom/core/XMLElementImpl.cpp:
  • kdom/css/CSSCharsetRuleImpl.cpp:
  • kdom/css/CSSFontFaceRuleImpl.cpp:
  • kdom/css/CSSImageValueImpl.cpp:
  • kdom/css/CSSImportRuleImpl.cpp:
  • kdom/css/CSSMediaRuleImpl.cpp:
  • kdom/css/CSSPageRuleImpl.cpp:
  • kdom/css/CSSPrimitiveValueImpl.cpp:
  • kdom/css/CSSRuleImpl.cpp:
  • kdom/css/CSSRuleListImpl.cpp:
  • kdom/css/CSSStyleDeclarationImpl.cpp:
  • kdom/css/CSSStyleRuleImpl.cpp:
  • kdom/css/CSSStyleSelector.cpp:
  • kdom/css/CSSStyleSheetImpl.cpp:
  • kdom/css/CSSUnknownRuleImpl.cpp:
  • kdom/css/CSSValueImpl.cpp:
  • kdom/css/CSSValueListImpl.cpp:
  • kdom/css/CounterImpl.cpp:
  • kdom/css/DocumentCSSImpl.cpp:
  • kdom/css/DocumentStyleImpl.cpp:
  • kdom/css/KDOMCSSParser.cpp:
  • kdom/css/LinkStyleImpl.cpp:
  • kdom/css/MediaListImpl.cpp:
  • kdom/css/RGBColorImpl.cpp:
  • kdom/css/RectImpl.cpp:
  • kdom/css/RenderStyle.cpp:
  • kdom/css/RenderStyleDefs.cpp:
  • kdom/css/StyleBaseImpl.cpp:
  • kdom/css/StyleSheetImpl.cpp:
  • kdom/css/StyleSheetListImpl.cpp:
  • kdom/css/kdomparsercss.y:
  • kdom/ecma/Ecma.cpp:
  • kdom/ecma/GlobalObject.cpp:
  • kdom/ecma/Helper.cpp:
  • kdom/ecma/ScriptInterpreter.cpp:
  • kdom/events/DocumentEventImpl.cpp:
  • kdom/events/EventExceptionImpl.cpp:
  • kdom/events/EventImpl.cpp:
  • kdom/events/EventListenerImpl.cpp:
  • kdom/events/EventTargetImpl.cpp:
  • kdom/events/KeyboardEventImpl.cpp:
  • kdom/events/MouseEventImpl.cpp:
  • kdom/events/MutationEventImpl.cpp:
  • kdom/events/RegisteredEventListener.cpp:
  • kdom/events/UIEventImpl.cpp:
  • kdom/ls/DOMImplementationLSImpl.cpp:
  • kdom/ls/LSExceptionImpl.cpp:
  • kdom/ls/LSInputImpl.cpp:
  • kdom/ls/LSOutputImpl.cpp:
  • kdom/ls/LSParserFilterImpl.cpp:
  • kdom/ls/LSParserImpl.cpp:
  • kdom/ls/LSResourceResolverImpl.cpp:
  • kdom/ls/LSSerializerFilterImpl.cpp:
  • kdom/ls/LSSerializerImpl.cpp:
  • kdom/parser/KDOMDocumentBuilder.cpp:
  • kdom/parser/KDOMParser.cpp:
  • kdom/range/DocumentRangeImpl.cpp:
  • kdom/range/RangeExceptionImpl.cpp:
  • kdom/range/RangeImpl.cpp:
  • kdom/traversal/DocumentTraversalImpl.cpp:
  • kdom/traversal/NodeFilterImpl.cpp:
  • kdom/traversal/NodeIteratorImpl.cpp:
  • kdom/traversal/TraversalImpl.cpp:
  • kdom/traversal/TreeWalkerImpl.cpp:
  • kdom/views/AbstractViewImpl.cpp:
  • kdom/views/DocumentViewImpl.cpp:
  • kdom/xpath/XPathEvaluatorImpl.cpp:
  • kdom/xpath/XPathExceptionImpl.cpp:
  • kdom/xpath/XPathExpressionImpl.cpp:
  • kdom/xpath/XPathNSResolverImpl.cpp:
  • kdom/xpath/XPathNamespaceImpl.cpp:
  • kdom/xpath/XPathResultImpl.cpp:
  • kdom/xpath/impl/expression.cpp:
  • kdom/xpath/impl/functions.cpp:
  • kdom/xpath/impl/parsedstatement.cpp:
  • kdom/xpath/impl/path.cpp:
  • kdom/xpath/impl/predicate.cpp:
  • kdom/xpath/impl/step.cpp:
  • kdom/xpath/impl/tokenizer.cpp:
  • kdom/xpath/impl/util.cpp:
  • kdom/xpath/impl/variablereference.cpp:
  • kdom/xpath/impl/xpath.y:
  • kdom/xpointer/ElementSchemeImpl.cpp:
  • kdom/xpointer/NBCImpl.cpp:
  • kdom/xpointer/PointerPartImpl.cpp:
  • kdom/xpointer/ShortHandImpl.cpp:
  • kdom/xpointer/XMLNSSchemeImpl.cpp:
  • kdom/xpointer/XPath1SchemeImpl.cpp:
  • kdom/xpointer/XPointerEvaluatorImpl.cpp:
  • kdom/xpointer/XPointerExceptionImpl.cpp:
  • kdom/xpointer/XPointerExpressionImpl.cpp:
  • kdom/xpointer/XPointerHelper.cpp:
  • kdom/xpointer/XPointerResultImpl.cpp:
  • kdom/xpointer/XPointerSchemeImpl.cpp:
  • ksvg2/KSVGFactory.cpp:
  • ksvg2/KSVGSettings.cpp:
  • ksvg2/KWQKSVGPart.mm:
  • ksvg2/KWQKSVGView.mm:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleDeclarationImpl.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGCSSStyleSheetImpl.cpp:
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/events/SVGEventImpl.cpp:
  • ksvg2/events/SVGZoomEventImpl.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGDocumentBuilder.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/svg/CDFInterface.cpp:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGAngleImpl.cpp:
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp:
  • ksvg2/svg/SVGAnimateElementImpl.cpp:
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimatedAngleImpl.cpp:
  • ksvg2/svg/SVGAnimatedBooleanImpl.cpp:
  • ksvg2/svg/SVGAnimatedEnumerationImpl.cpp:
  • ksvg2/svg/SVGAnimatedIntegerImpl.cpp:
  • ksvg2/svg/SVGAnimatedLengthImpl.cpp:
  • ksvg2/svg/SVGAnimatedLengthListImpl.cpp:
  • ksvg2/svg/SVGAnimatedNumberImpl.cpp:
  • ksvg2/svg/SVGAnimatedNumberListImpl.cpp:
  • ksvg2/svg/SVGAnimatedPathDataImpl.cpp:
  • ksvg2/svg/SVGAnimatedPointsImpl.cpp:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGAnimatedRectImpl.cpp:
  • ksvg2/svg/SVGAnimatedStringImpl.cpp:
  • ksvg2/svg/SVGAnimatedTransformListImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGCircleElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDefsElementImpl.cpp:
  • ksvg2/svg/SVGDescElementImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGElementInstanceImpl.cpp:
  • ksvg2/svg/SVGElementInstanceListImpl.cpp:
  • ksvg2/svg/SVGEllipseElementImpl.cpp:
  • ksvg2/svg/SVGExceptionImpl.cpp:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncAElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncBElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncGElementImpl.cpp:
  • ksvg2/svg/SVGFEFuncRElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFilterElementImpl.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp:
  • ksvg2/svg/SVGLengthListImpl.cpp:
  • ksvg2/svg/SVGLineElementImpl.cpp:
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp:
  • ksvg2/svg/SVGLocatableImpl.cpp:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGMatrixImpl.cpp:
  • ksvg2/svg/SVGNumberImpl.cpp:
  • ksvg2/svg/SVGNumberListImpl.cpp:
  • ksvg2/svg/SVGPaintImpl.cpp:
  • ksvg2/svg/SVGPathElementImpl.cpp:
  • ksvg2/svg/SVGPathSegArcImpl.cpp:
  • ksvg2/svg/SVGPathSegClosePathImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticImpl.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothImpl.cpp:
  • ksvg2/svg/SVGPathSegImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoHorizontalImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoImpl.cpp:
  • ksvg2/svg/SVGPathSegLinetoVerticalImpl.cpp:
  • ksvg2/svg/SVGPathSegListImpl.cpp:
  • ksvg2/svg/SVGPathSegMovetoImpl.cpp:
  • ksvg2/svg/SVGPatternElementImpl.cpp:
  • ksvg2/svg/SVGPointImpl.cpp:
  • ksvg2/svg/SVGPointListImpl.cpp:
  • ksvg2/svg/SVGPolyElementImpl.cpp:
  • ksvg2/svg/SVGPolygonElementImpl.cpp:
  • ksvg2/svg/SVGPolylineElementImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp:
  • ksvg2/svg/SVGRectElementImpl.cpp:
  • ksvg2/svg/SVGRectImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGSetElementImpl.cpp:
  • ksvg2/svg/SVGStopElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.cpp:
  • ksvg2/svg/SVGStylableImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGSwitchElementImpl.cpp:
  • ksvg2/svg/SVGSymbolElementImpl.cpp:
  • ksvg2/svg/SVGTSpanElementImpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp:
  • ksvg2/svg/SVGTextContentElementImpl.cpp:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • ksvg2/svg/SVGTextPositioningElementImpl.cpp:
  • ksvg2/svg/SVGTitleElementImpl.cpp:
  • ksvg2/svg/SVGTransformImpl.cpp:
  • ksvg2/svg/SVGTransformListImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • ksvg2/svg/SVGZoomAndPanImpl.cpp:
  • ksvg2/svg/svgpathparser.cpp:
9:16 PM Changeset in webkit [10733] by mjs
  • 3 edits in trunk/WebKitLibraries
  • updated
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
1:24 PM Changeset in webkit [10732] by bdakin
  • 3 edits
    3 adds in trunk

* empty log message *

10:33 AM Changeset in webkit [10731] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Fix for <rdar://problem/4275275> Denver Regression: Drawing glitch
in the transparent dialog's cancel/ok button in the widget manager

Fixed by Beth Dakin.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): CG workaround
10:31 AM Changeset in webkit [10730]
  • 52 copies
    22 deletes in tags/WebKit-416~10

This commit was manufactured by cvs2svn to create tag
'WebKit-416~10'.

10:31 AM Changeset in webkit [10729] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Fix for <rdar://problem/4275275> Denver Regression: Drawing glitch
in the transparent dialog's cancel/ok button in the widget manager

Fixed by Beth Dakin.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): CG workaround
2:33 AM Changeset in webkit [10728] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Code cleanup, which resulted in a small win on iBench.

  • kjs/object.cpp: (KJS::tryGetAndCallProperty): new static inline (KJS::ObjectImp::defaultValue): code cleanup

Oct 3, 2005:

11:14 PM Changeset in webkit [10727] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 4233558
Submitted by: eseidel
Reviewed by: mjs

Test case for event.view.toString()
<rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

  • fast/events/event-view-toString-expected.txt: Added.
  • fast/events/event-view-toString.html: Added.
11:13 PM Changeset in webkit [10726] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Make mouseDown and mouseUp force layout before acting.
This is used by a new test case for 4233558.

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): force layout (-[EventSendingController mouseUp]): force layout
11:11 PM Changeset in webkit [10725] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4233538
Submitted by: eseidel
Reviewed by: mjs

Fixed AbstractView toString(), by giving it a prototype.
<rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::DOMAbstractView): sets prototype (KJS::DOMAbstractView::getOwnPropertySlot): now getStaticValue (KJS::DOMAbstractViewProtoFunc::callAsFunction): renamed
  • khtml/ecma/kjs_views.h:
10:57 PM Changeset in webkit [10724] by mjs
  • 4 edits in trunk/JavaScriptCore

Patch from George Staikos <​staikos@kde.org>, reviewed and tweaked a bit by me.

  • more Linux build fixes
  • kjs/operations.cpp:
  • kxmlcore/FastMalloc.h:
  • kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
10:42 PM Changeset in webkit [10723] by hyatt
  • 2 edits in trunk/WebCore

Fix regression caused by variable->auto change. Accidentally removed a line of code from calcWidthUsing.

Reviewed by mjs

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidthUsing):
9:08 PM Changeset in webkit [10722] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

Test cases for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

  • fast/events/stopPropagation-checkbox-expected.txt: Added.
  • fast/events/stopPropagation-checkbox.html: Added.
  • fast/events/stopPropagation-submit-expected.txt: Added.
  • fast/events/stopPropagation-submit.html: Added.
9:01 PM Changeset in webkit [10721]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~13

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~13'.

9:01 PM Changeset in webkit [10720] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.13

8:56 PM Changeset in webkit [10719]
  • 209 copies
    15 deletes in tags/WebCore-416~9

This commit was manufactured by cvs2svn to create tag
'WebCore-416~9'.

8:56 PM Changeset in webkit [10718] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Versioning to WebCore-416.9

8:54 PM Changeset in webkit [10717] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Versioning to WebKit-416.10

7:40 PM Changeset in webkit [10716] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Merged fix from TOT to Safari-Den-branch

2005-10-03 Tim Omernick <​tomernick@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):

If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

7:36 PM Changeset in webkit [10715] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Tim Omernick <​tomernick@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):

If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

6:59 PM Changeset in webkit [10714] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/4060947> Safari crashes trying to save PDF file as web archive (NULL KHTMLPart)

  • kwq/WebCoreBridge.mm: (+[WebCoreBridge bridgeForDOMDocument:]): Added a check for a null part.
6:43 PM Changeset in webkit [10713] by mjs
  • 8 edits in trunk/JavaScriptCore

Patch from George Staikos <​staikos@kde.org>, reviewed and tweaked a bit by me.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5174
Add support for compiling on Linux (likely to help for other POSIX systems too)

  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively):
  • kjs/config.h:
  • kjs/date_object.cpp: (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::timeZoneOffset): (KJS::DateProtoFuncImp::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::makeTime):
  • kjs/identifier.cpp:
  • kjs/internal.cpp: (KJS::initializeInterpreterLock): (KJS::lockInterpreter): (KJS::unlockInterpreter): (KJS::UndefinedImp::toPrimitive): (KJS::UndefinedImp::toBoolean): (KJS::UndefinedImp::toNumber): (KJS::UndefinedImp::toString): (KJS::NullImp::toPrimitive): (KJS::NullImp::toBoolean): (KJS::NullImp::toNumber): (KJS::NullImp::toString): (KJS::BooleanImp::toPrimitive): (KJS::BooleanImp::toBoolean): (KJS::BooleanImp::toNumber): (KJS::BooleanImp::toString): (KJS::StringImp::toPrimitive): (KJS::StringImp::toBoolean): (KJS::StringImp::toNumber): (KJS::StringImp::toString):
  • kjs/internal.h:
  • kjs/protected_values.cpp:
6:31 PM Changeset in webkit [10712] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan, Maciej Stachowiak.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]): If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it. This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

5:56 PM Changeset in webkit [10711] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-03 Justin Garcia <​justin.garcia@apple.com>

Fixes <rdar://problem/4275492> REGRESSION (SuTiDenver): EMBED tag with bogus type attribute downloads .wmv file twice (gorillamask.net)

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
5:50 PM Changeset in webkit [10710] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebCore

Merged fix from TOT to Safari-Den-branch

2005-10-03 Justin Garcia <​justin.garcia@apple.com>

Fixes <rdar://problem/4275492> REGRESSION (SuTiDenver): EMBED tag with bogus type attribute downloads .wmv file twice (gorillamask.net)

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
4:12 PM Changeset in webkit [10709] by justing
  • 1 edit in trunk/WebCore/khtml/khtml_part.cpp

darin tweaked my previous commit

4:11 PM Changeset in webkit [10708]
  • 1 copy
    7 deletes in tags/post-fm-fixes

This commit was manufactured by cvs2svn to create tag
'post-fm-fixes'.

4:11 PM Changeset in webkit [10707] by justing
  • 2 edits in trunk/WebCore

Reviewed by geoff, darin

  • khtml/khtml_part.cpp: (KHTMLPart::handleFallbackContent): Don't handle fallback content for <embed> tags.
4:00 PM Changeset in webkit [10706] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • add missing config.h
  • khtml/config.h: Added.
3:45 PM Changeset in webkit [10705] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore
  • Fixed <rdar://problem/4244084> Denver Regression: setUTC() functions don't take into account Daylight Savings Time

Reviewed by kevin.

Fix was to roll in this change from TOT:

2005-08-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
  • tests/mozilla/expected.html: Updated for newly fixed test.
3:44 PM Changeset in webkit [10704] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4244084> Denver Regression: setUTC() functions don't take into account Daylight Savings Time

Reviewed by kevin.

Fix was to roll in this change from TOT:

2005-08-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.

  • kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
  • tests/mozilla/expected.html: Updated for newly fixed test.
3:42 PM Changeset in webkit [10703] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix Development build after last checkin
  • kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread):
2:34 PM Changeset in webkit [10702] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

Amusingly this bug existed in 3 different places.

  • khtml/ecma/kjs_events.cpp: (KJS::DOMEventProtoFunc::callAsFunction): Don't let stopPropagation fall through to preventDefault.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::postDispatchEventHandler): Only consider preventDefault for purposes of reverting checkbox/radiobutton state change, not stopPropagation.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): Don't let stopPropagation prevent calling default event handlers; only preventDefault does that.
2:13 PM Changeset in webkit [10701] by mjs
  • 343 edits
    1 add
    1 delete in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

A number of optimizations to the new threadsafe malloc that make it actually as fast
as dlmalloc (I measured wrong before) and as memory-efficient as the system malloc.

  • use fastMalloc for everything - it now gets applied to all new/delete allocations via a private inline operator new that is now included into every file via config.h.
  • tweaked some of the numeric parameters for size classes and amount of wasted memory allowed per allocation - this saves on memory use and consequently improves speed.
  • so long as the allocator is not being used on background threads, get the per-thread cache from a global variable instead of from pthread_getspecific, since the latter is slow.
  • inline more functions, and force the ones GCC refuses to inline with attribute(always_inline), nearly all of these have one call site so inlining them has to be a win.
  • use some tricks to calculate allocation size more efficiently and fewer times for small allocations, to avoid hitting the huge size table array.
  • avoid hitting the per-thread cache on code paths that don't need it.
  • implement inline assembly version of spinlock for PowerPC (was already done for x86)
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_class.cpp:
  • bindings/c/c_instance.cpp:
  • bindings/c/c_runtime.cpp:
  • bindings/c/c_utility.cpp:
  • bindings/jni/jni_class.cpp:
  • bindings/jni/jni_instance.cpp:
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_objc.mm:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_utility.cpp:
  • bindings/npruntime.cpp:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/objc_class.mm:
  • bindings/objc/objc_instance.mm:
  • bindings/objc/objc_runtime.mm:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.cpp:
  • bindings/runtime_array.cpp:
  • bindings/runtime_method.cpp:
  • bindings/runtime_object.cpp:
  • bindings/runtime_root.cpp:
  • bindings/testbindings.cpp:
  • bindings/testbindings.mm:
  • kjs/array_object.cpp: (ArrayInstanceImp::ArrayInstanceImp): (ArrayInstanceImp::~ArrayInstanceImp): (ArrayInstanceImp::resizeStorage):
  • kjs/bool_object.cpp:
  • kjs/collector.cpp: (KJS::Collector::registerThread):
  • kjs/config.h:
  • kjs/debugger.cpp:
  • kjs/error_object.cpp:
  • kjs/function.cpp:
  • kjs/function_object.cpp:
  • kjs/identifier.cpp: (KJS::Identifier::rehash):
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): (KJS::clearNewNodes):
  • kjs/interpreter.cpp:
  • kjs/lexer.cpp: (Lexer::doneParsing): (Lexer::makeIdentifier): (Lexer::makeUString):
  • kjs/list.cpp:
  • kjs/math_object.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/number_object.cpp: (integer_part_noexp): (char_sequence):
  • kjs/object.cpp:
  • kjs/object_object.cpp:
  • kjs/property_map.cpp:
  • kjs/property_slot.cpp:
  • kjs/protected_values.cpp: (KJS::ProtectedValues::rehash):
  • kjs/reference.cpp:
  • kjs/reference_list.cpp:
  • kjs/regexp.cpp:
  • kjs/regexp_object.cpp:
  • kjs/scope_chain.cpp:
  • kjs/scope_chain.h:
  • kjs/string_object.cpp:
  • kjs/testkjs.cpp:
  • kjs/ustring.h:
  • kjs/value.cpp:
  • kxmlcore/Assertions.mm:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::InitSizeClasses): (KXMLCore::DLL_IsEmpty): (KXMLCore::DLL_Prepend): (KXMLCore::TCMalloc_Central_FreeList::Insert): (KXMLCore::TCMalloc_Central_FreeList::Remove): (KXMLCore::TCMalloc_Central_FreeList::Populate): (KXMLCore::TCMalloc_ThreadCache::Allocate): (KXMLCore::TCMalloc_ThreadCache::FetchFromCentralCache): (KXMLCore::fastMallocRegisterThread): (KXMLCore::TCMalloc_ThreadCache::GetCache): (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent): (KXMLCore::TCMalloc_ThreadCache::CreateCacheIfNecessary): (KXMLCore::do_malloc): (KXMLCore::do_free): (KXMLCore::realloc):
  • kxmlcore/FastMalloc.h: (operator new): (operator delete): (operator new[]): (operator delete[]):
  • kxmlcore/HashTable.cpp:
  • kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • kxmlcore/TCSystemAlloc.cpp:

WebCore:

Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

  • use fastMalloc for everything - it now gets applied to all new/delete allocations via a private inline operator new that is now included into every file via config.h
  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • khtml/css/css_base.cpp:
  • khtml/css/css_base.h:
  • khtml/css/css_computedstyle.cpp:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssparser.cpp: (ValueList::ValueList): (ValueList::~ValueList): (ValueList::addValue): (CSSParser::CSSParser): (CSSParser::~CSSParser): (CSSParser::setupParser): (CSSParser::addProperty):
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_misc.cpp:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Gradient::~Gradient): (KJS::Gradient::addColorStop): (KJS::Gradient::colorStops):
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/ecma/kjs_proxy.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/merge_identical_elements_command.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/remove_css_property_command.cpp:
  • khtml/editing/remove_node_attribute_command.cpp:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/set_node_attribute_command.cpp:
  • khtml/editing/split_element_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_range.cpp:
  • khtml/editing/visible_text.cpp: (khtml::CircularSearchBuffer::~CircularSearchBuffer): (khtml::CircularSearchBuffer::CircularSearchBuffer):
  • khtml/editing/visible_units.cpp:
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_miscimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlnames.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::enlargeBuffer): (khtml::HTMLTokenizer::enlargeScriptBuffer):
  • khtml/khtml_events.cpp:
  • khtml/khtml_part.cpp:
  • khtml/khtmlview.cpp:
  • khtml/misc/arena.cpp:
  • khtml/misc/arena.h:
  • khtml/misc/decoder.cpp:
  • khtml/misc/formdata.cpp:
  • khtml/misc/helper.cpp:
  • khtml/misc/loader.cpp:
  • khtml/misc/stringit.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/break_lines.cpp:
  • khtml/rendering/font.cpp:
  • khtml/rendering/render_arena.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_br.cpp:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::~RenderCanvasImage): (RenderCanvasImage::createDrawingContext):
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_flexbox.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_style.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_text.cpp:
  • khtml/rendering/render_theme.cpp:
  • khtml/rendering/render_theme_mac.mm:
  • khtml/rendering/table_layout.cpp:
  • khtml/xbl/xbl_binding.cpp:
  • khtml/xbl/xbl_binding_manager.cpp:
  • khtml/xbl/xbl_docimpl.cpp:
  • khtml/xbl/xbl_protobinding.cpp:
  • khtml/xbl/xbl_protohandler.cpp:
  • khtml/xbl/xbl_protoimplementation.cpp:
  • khtml/xbl/xbl_tokenizer.cpp:
  • khtml/xml/EventNames.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.cpp:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_atomicstring.cpp:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_qname.cpp:
  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_textimpl.cpp:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/DOM-CSS.mm:
  • kwq/DOM.mm:
  • kwq/DOMEvents.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm: (DOMString::DOMString):
  • kwq/DOMUtility.mm:
  • kwq/DOMViews.mm:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQApplication.mm:
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQBuffer.mm:
  • kwq/KWQButton.mm:
  • kwq/KWQCString.mm:
  • kwq/KWQCharsets.mm:
  • kwq/KWQClipboard.mm:
  • kwq/KWQCollection.mm:
  • kwq/KWQColor.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQCursor.mm:
  • kwq/KWQDateTime.mm:
  • kwq/KWQDictImpl.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQEvent.mm:
  • kwq/KWQExceptions.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontFamily.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQFormData.mm:
  • kwq/KWQFrame.mm:
  • kwq/KWQGlobal.mm:
  • kwq/KWQGuardedPtr.mm:
  • kwq/KWQKCharsets.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKCookieJar.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKGlobal.mm:
  • kwq/KWQKGlobalSettings.mm:
  • kwq/KWQKHTMLFactory.mm:
  • kwq/KWQKHTMLPart.cpp:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKHTMLView.mm:
  • kwq/KWQKHistoryProvider.mm:
  • kwq/KWQKJavaAppletWidget.mm:
  • kwq/KWQKJob.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKPartsBrowserInterface.mm:
  • kwq/KWQKPartsEvent.mm:
  • kwq/KWQKPartsPart.mm:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQKStandardDirs.mm:
  • kwq/KWQKStringHandler.mm:
  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (encodeRelativeString):
  • kwq/KWQKWin.mm:
  • kwq/KWQKWinModule.mm:
  • kwq/KWQLabel.mm:
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQListImpl.mm:
  • kwq/KWQLoader.mm: (KWQIsResponseURLEqualToURL):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQMovie.mm:
  • kwq/KWQObject.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPaintDeviceMetrics.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQPalette.mm:
  • kwq/KWQPen.mm:
  • kwq/KWQPixmap.mm:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.mm:
  • kwq/KWQPtrDictImpl.mm:
  • kwq/KWQPushButton.mm:
  • kwq/KWQRect.mm:
  • kwq/KWQRegExp.mm:
  • kwq/KWQRegion.mm:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQResourceLoader.mm:
  • kwq/KWQScrollBar.mm:
  • kwq/KWQScrollView.mm:
  • kwq/KWQSignal.mm:
  • kwq/KWQSignalStubs.mm:
  • kwq/KWQSize.mm:
  • kwq/KWQSlider.mm:
  • kwq/KWQSlot.mm:
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (ALLOC_CHAR): (REALLOC_CHAR): (DELETE_CHAR): (ALLOC_QCHAR): (REALLOC_QCHAR): (DELETE_QCHAR): (_printQStringAllocationStatistics): (allocateHandle): (KWQStringData::operator new): (KWQStringData::operator delete): (freeHandle):
  • kwq/KWQStringList.mm:
  • kwq/KWQStyle.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextCodec.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQTextStream.mm:
  • kwq/KWQTextUtilities.mm:
  • kwq/KWQTimer.mm:
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm:
  • kwq/KWQVariant.mm:
  • kwq/KWQVectorImpl.mm: (KWQVectorImpl::KWQVectorImpl): (KWQVectorImpl::~KWQVectorImpl): (KWQVectorImpl::clear): (KWQVectorImpl::resize): (KWQVectorImpl::assign):
  • kwq/KWQWMatrix.mm:
  • kwq/KWQWidget.mm:
  • kwq/KWQWindowWidget.mm:
  • kwq/WebCoreBridge.mm:
  • kwq/WebCoreCache.mm:
  • kwq/WebCoreEncodings.mm:
  • kwq/WebCoreJavaScript.mm:
  • kwq/WebCoreScriptDebugger.mm:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • kwq/can-convert.mm:
1:55 PM Changeset in webkit [10700]
  • 1 copy
    7 deletes in tags/pre-fm-fixes

This commit was manufactured by cvs2svn to create tag 'pre-fm-fixes'.

1:55 PM Changeset in webkit [10699] by bdakin
  • 7 edits
    2 adds in trunk

* empty log message *

1:55 AM Changeset in webkit [10698] by eseidel
  • 2 edits
    5 adds in trunk

Bug #: 5239
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes hang, caused by path parser spinning forever.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5239

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
  • svg-tests/custom/path-bad-data-expected.checksum: Added.
  • svg-tests/custom/path-bad-data-expected.png: Added.
  • svg-tests/custom/path-bad-data-expected.txt: Added.
  • svg-tests/custom/path-bad-data.svg: Added.

Oct 2, 2005:

11:21 PM Changeset in webkit [10697] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5209
Submitted by: eseidel
Reviewed by: darin

Closes large memory leak in KSVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5209

  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attach): delete orphans unless PatternImpl
11:15 PM Changeset in webkit [10696] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 5132
Submitted by: eseidel
Reviewed by: mjs

Fixes SVG animation support in Safari/WebKit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5132

  • WebCore+SVG/dom_kdomnodetreewrapper.cpp: (KDOMNodeTreeWrapperImpl::attach): setup kcanvasviewquartz (KDOMNodeTreeWrapperImpl::detach): tear down kcanvasviewquartz
  • WebCore+SVG/dom_kdomnodetreewrapper.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.h:
  • kcanvas/device/quartz/KCanvasViewQuartz.mm: fix spaces (KCanvasViewQuartz::KCanvasViewQuartz): (KCanvasViewQuartz::~KCanvasViewQuartz): (KCanvasViewQuartz::view): (KCanvasViewQuartz::setView): (KCanvasViewQuartz::renderObject): alternative to view (KCanvasViewQuartz::setRenderObject): (KCanvasViewQuartz::invalidateCanvasRect): (KCanvasViewQuartz::viewToCanvasMatrix): (KCanvasViewQuartz::canvasSizeChanged): (KCanvasViewQuartz::viewHeight): (KCanvasViewQuartz::viewWidth):
11:08 PM Changeset in webkit [10695] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • fast/xsl/xslt-url-expected.txt: Added.
  • fast/xsl/xslt-url.xml: Added.
  • fast/xsl/xslt-url.xsl: Added.
11:02 PM Changeset in webkit [10694] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5219
Submitted by: Alexey Proskuryakov <​ap@nypop.com>
Reviewed by: eseidel

Fix XSLT to preserve document.URL.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
10:21 PM Changeset in webkit [10693] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5238
Submitted by: eseidel
Reviewed by: mjs

Fix crash when encountering XML processing directives w/ KDOM:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5238

  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::recalcStyleSelector): null check.
12:51 PM Changeset in webkit [10692] by eseidel
  • 2 edits
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, removing unused svg files only.

Removing unused SVG source files.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/ecma/Constructors.cpp: Removed.
  • ksvg2/ecma/Constructors.h: Removed.
10:17 AM Changeset in webkit [10691] by andersca
  • 3 edits in trunk/WebCore

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::localName): (AttrImpl::namespaceURI):
  • khtml/xml/dom_elementimpl.h: Implement localName and namespaceURI for attributes.
10:15 AM Changeset in webkit [10690] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

2005-10-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • fast/dom/attribute-namespaces-expected.txt: Added.
  • fast/dom/attribute-namespaces.xhtml: Added.
Note: See TracTimeline for information about the timeline view.