Context Navigation

← Previous Period
Next Period →

Timeline

Oct 14, 2005:

2:03 PM Changeset in webkit [10855] by ggaren

2 edits in trunk/JavaScriptCore

Style changes recommended by Darin.

Changed to camelCase, changed ValueImp* to ValueImp *.

kjs/simple_number.h: (KJS::SimpleNumber::make): (KJS::SimpleNumber::value):

1:57 PM Changeset in webkit [10854] by ggaren

2 edits in trunk/WebCore

Style change suggested by Darin.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Added "Bugzilla" prefix to bug #.

1:31 PM Changeset in webkit [10853] by vicki

2 edits in trunk/WebKit

Changes by Mitz Pettel, reviewed by Maciej.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): Prefer the main resource if it is an image

1:20 PM Changeset in webkit [10852] by eseidel

2 edits in trunk/WebCore

Bug #: 5336
Submitted by: Julien Palmas <julien.palmas@mac.com>
Reviewed by: eseidel

Fixed crash when animating unsupported elements.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5336

ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetElement):

Oct 13, 2005:

11:10 PM Changeset in webkit [10851] by eseidel

2 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none, removed newline.

Committed file w/ extra newline by mistake.

fast/js/resources/xmlhttprequest-get-data.xml:

4:54 PM Changeset in webkit [10850] by eseidel

1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding the mozilla xslt tests.

fast/xsl/mozilla-tests.xml: Added.
fast/xsl/mozilla-tests.xsl: Added.
fast/xsl/mozilla-tests-expected.txt: Added.

4:51 PM Changeset in webkit [10849] by eseidel

6 adds in trunk/LayoutTests/fast

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

fast/js/resources/xmlhttprequest-get-data.xml: Added.
fast/js/xmlhttprequest-get-expected.txt: Added.
fast/js/xmlhttprequest-get.xhtml: Added.

4:39 PM Changeset in webkit [10848] by eseidel

1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

fast/js/resources/xmlhttprequest-get-data.xml: Added.
fast/js/xmlhttprequest-get-expected.txt: Added.
fast/js/xmlhttprequest-get.xhtml: Added.

3:51 PM Changeset in webkit [10847] by justing

9 edits
4 adds in trunk/LayoutTests

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Updated/added layout tests:

fast/clip/001-expected.txt:
fast/clip/009-expected.txt:
fast/clip/010-expected.txt:
fast/clip/011-expected.txt:
fast/clip/012-expected.txt:
fast/clip/013-expected.txt:
fast/clip/014-expected.txt:
fast/clip/016-expected.txt:
fast/clip/outline-overflowClip-expected.checksum: Added.
fast/clip/outline-overflowClip-expected.png: Added.
fast/clip/outline-overflowClip-expected.txt: Added.
fast/clip/outline-overflowClip.html: Added.

3:45 PM Changeset in webkit [10846] by justing

4 edits in trunk/WebCore

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Test cases added:

fast/clip/outline-overflowClip Test cases changed (since I added the outline rect to the render tree dump)
fast/clip/001
fast/clip/009
fast/clip/010
fast/clip/011
fast/clip/012
fast/clip/013
fast/clip/014
fast/clip/016

khtml/rendering/render_layer.cpp: Clip the outline by a new rect, which is equal to the foreground rect w/o clipping by the overflow rect.

(khtml::RenderLayer::paintLayer):
(khtml::RenderLayer::hitTestLayer):
(khtml::RenderLayer::calculateRects):

khtml/rendering/render_layer.h:
kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers):

3:07 PM Changeset in webkit [10845] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin.

no need to calculate linewidth multiple times in findnextlinebreak()
http://bugzilla.opendarwin.org/show_bug.cgi?id=5319

No test case needed, this is a simple optimization.

khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

12:37 PM Changeset in webkit [10844] by vicki

2 edits in trunk/WebKit

Reviewed by Darin.

fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)

WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self dependency from this function

12:11 PM Changeset in webkit [10843] by ggaren

3 edits in trunk/WebCore

Fixed <rdar://problem/4259434> Safari crashes in HTMLTokenizer::~HTMLTokenizer() at http://www.timewarner.com/corp/careers/jobtools_us/index.html

I changed the test for whether to put a script in the "to be executed" queue to
match the test for whether to ref a script, so that scripts can't end up in the
queue without being refed.

I also renamed cachedScript to pendingScripts.

Reviewed by Darin.

No test case because the crash isn't deterministically reproducible.
However, I did add assertions that should catch the underlying bug
in the future.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::notifyFinished):
khtml/html/htmltokenizer.h:

1:29 AM Changeset in webkit [10842] by eseidel

9 edits in trunk

Bug #: 5326
Submitted by: Rob Buis <rwlbuis@xs4all.nl>
Reviewed by: eseidel

Test cases updated:

svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png:
svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:

Fixed <svg> to base %lengths off of the nearest viewbox.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5326

ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::x): (SVGSVGElementImpl::y): (SVGSVGElementImpl::width): (SVGSVGElementImpl::height):

Oct 12, 2005:

6:41 PM Changeset in webkit [10841]

4 copies
7 deletes in tags/Safari-421

This commit was manufactured by cvs2svn to create tag 'Safari-421'.

6:41 PM Changeset in webkit [10840] by thatcher

3 edits in branches/Safari-Leo-branch

Versioning to 421

6:08 PM Changeset in webkit [10839] by thatcher

10 edits in trunk/WebKit

Reviewed by Darin.

Define WebNSInt and WebNSUInt to wrap around NSInt on Leopard and still build on Tiger
Once building on Tiger isn't needed we will drop WebNSInt and use NSInt

WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
WebView.subproj/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
WebView.subproj/WebLoader.m: (-[NSURLProtocol didReceiveData:lengthReceived:]):
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebUIDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
WebView.subproj/WebViewInternal.h:
WebView.subproj/WebViewPrivate.h:

5:53 PM Changeset in webkit [10838] by vicki

3 edits in trunk/LayoutTests

update expected results for <rdar://problem/4288266> createElement does not validate names when called in an HTML document (4566)

dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt:
dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt:

5:49 PM Changeset in webkit [10837] by vicki

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix <rdar://problem/4288266> createElement does not validate names when called in an HTML document (4566)

khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::createElement):

5:35 PM Changeset in webkit [10836] by bdakin

5 edits
4 adds in trunk

* empty log message *

2:02 PM Changeset in webkit [10835] by darin

2 edits in trunk/WebKit

WebView.subproj/WebPolicyDelegate.h: Fix a comment.

1:58 PM Changeset in webkit [10834] by darin

1 edit
4 deletes in trunk/LayoutTests

removed some old results for tests that are no longer present http://bugzilla.opendarwin.org/show_bug.cgi?id=4850

dom/html/level2/html/frame-expected.checksum: Removed.
dom/html/level2/html/frame-expected.png: Removed.
dom/html/level2/html/iframe-expected.checksum: Removed.
dom/html/level2/html/iframe-expected.png: Removed.

1:28 PM Changeset in webkit [12208] by thatcher

2 edits in trunk/JavaScriptGlue

Setup the proper Framework search path for the Default config.
Prepping for a TOT submission and build by B&I.

JavaScriptGlue.xcodeproj/project.pbxproj:

Oct 11, 2005:

11:55 PM Changeset in webkit [10833]

1 copy
5 deletes in branches/Safari-Leo-branch

This commit was manufactured by cvs2svn to create branch
'Safari-Leo-branch'.

11:55 PM Changeset in webkit [10832] by thatcher

2 edits in trunk/WebCore

Reviewed by Eric.

Crash: Drag element with CSS ::Before absolute positioning applied to it
http://bugzilla.opendarwin.org/show_bug.cgi?id=4088

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):

6:00 PM Changeset in webkit [10831] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

Test for 10.4 because of <rdar://problem/4243463>

WebView.subproj/WebHTMLView.m: (-[WebHTMLView conversationIdentifier]):

5:44 PM Changeset in webkit [10830] by thatcher

3 edits in trunk/WebCore

Reviewed by Darin.

workaround for <rdar://problem/4294625> to fix our build

kwq/KWQPointArray.h:
kwq/KWQSize.h:

4:14 PM Changeset in webkit [10829]

209 copies
15 deletes in tags/WebCore-416~11

This commit was manufactured by cvs2svn to create tag
'WebCore-416~11'.

4:14 PM Changeset in webkit [10828] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Versioning to WebCore-416.11

3:37 PM Changeset in webkit [10827] by adele

2 edits in trunk/WebKit

Rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
since it caused:

REGRESSION text areas draw focus ring around each glyph, no caret in text fields
http://bugzilla.opendarwin.org/show_bug.cgi?id=5335

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]): (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):

3:26 PM Changeset in webkit [10826]

1 copy
7 deletes in tags/perf-search-end

This commit was manufactured by cvs2svn to create tag
'perf-search-end'.

3:26 PM Changeset in webkit [10825] by ggaren

2 edits in trunk/JavaScriptCore

Added regexp_object.lut.h build phase from JavaScriptCore
to JavaScriptCore+SVG.

Reviewed by mitz.

JavaScriptCore.xcodeproj/project.pbxproj:

3:01 PM Changeset in webkit [10824] by ggaren

2 edits in trunk/JavaScriptCore

Fixed build bustage from last checkin (stray characters
in the project file).

Reviewed by mitz.

JavaScriptCore.xcodeproj/project.pbxproj:

2:49 PM Changeset in webkit [10823] by ggaren

2 edits in trunk/JavaScriptCore

New JavaScriptCore test results to reflect the last change.

tests/mozilla/expected.html:

2:12 PM Changeset in webkit [10822] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by eric

<rdar://problem/4283218> M-JPEG / Server Push and JavaScript

Ignore multipart loads in numRequests, call checkCompleted() after each section is complete.

khtml/misc/loader.cpp:

2:00 PM Changeset in webkit [10821] by ggaren

1 edit in trunk/JavaScriptCore/ChangeLog

Small fixup to last Changelog entry.

1:57 PM Changeset in webkit [10820] by ggaren

1 edit
2 adds in trunk/LayoutTests

Added a layout test for the new special properties of the global RegExp object.
(See JavaSriptCore changelog.)

fast/js/regexp-caching-expected.txt: Added.
fast/js/regexp-caching.html: Added.

1:56 PM Changeset in webkit [10819] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Merged fix from TOT to Safari-Den-branch

2005-10-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by eric

<rdar://problem/4283218> M-JPEG / Server Push and JavaScript

Ignore multipart loads in numRequests, call checkCompleted() after each section is complete.

khtml/misc/loader.cpp:

1:43 PM Changeset in webkit [10818] by ggaren

7 edits in trunk/JavaScriptCore

Implemented caching of match state inside the global RegExp object (lastParen, leftContext, rightContext, lastMatch, input).

exec(), test(), match(), search(), and replace() now dipatch regular
expression matching through the RegExp object's performMatch function,
to facilitate caching. This replaces registerRegexp and
setSubPatterns.

Implemented the special '$' aliases (e.g. RegExp.input aliases to RegExp.$_).

Moved support for backreferences into the new static hash table used for other special RegExp properties. Truncated backreferences at $9 to match IE, FF, and the "What's New in Netscape 1.2?" doc. (String.replace still supports double-digit backreferences.)

Tweaked RegExp.prototype.exec to handle ginormous values in lastIndex.

Fixes 11 -- count em, 11 -- JavaScriptCore tests.

Reviewed by NOBODY (OOPS!).

JavaScriptCore.xcodeproj/project.pbxproj: Added regexp_object.lut.h
kjs/create_hash_table: Tweaked to allow for more exotic characters.

We now rely on the compiler to catch illegal
identifiers.

kjs/regexp.cpp: (KJS::RegExp::RegExp):
kjs/regexp_object.cpp: (RegExpProtoFuncImp::callAsFunction): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::performMatch): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::backrefGetter): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getOwnPropertySlot): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::put): (RegExpObjectImp::putValueProperty):
kjs/regexp_object.h: (KJS::RegExpObjectImp::):
kjs/string_object.cpp: (substituteBackreferences): (replace): (StringProtoFuncImp::callAsFunction):

1:33 PM Changeset in webkit [10817] by justing

2 edits in trunk/WebCore

Reviewed by eric

<rdar://problem/4283218> M-JPEG / Server Push and JavaScript

Ignore multipart loads in numRequests, call checkCompleted() after each section is complete.

khtml/misc/loader.cpp:

12:16 PM Changeset in webkit [10816] by adele

10 edits in trunk

LayoutTests:

Rolling out Darin's previous change.

fast/clip/014-expected.checksum: Updated.
fast/clip/014-expected.png: Updated.

WebCore:

Rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
since it caused:

REGRESSION text areas draw focus ring around each glyph, no caret in text fields
http://bugzilla.opendarwin.org/show_bug.cgi?id=5335

And updated expected results.

fast/clip/014-expected.checksum: Updated.
fast/clip/014-expected.png: Updated.

kwq/KWQTextArea.h:
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView displayRectIgnoringOpacity:]): (-[KWQTextAreaTextView textView:shouldDrawInsertionPointInRect:color:turnedOn:]):
kwq/KWQTextField.h:
kwq/KWQTextField.mm: (-[KWQTextFieldController setInDrawingMachinery:]): (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]): (-[KWQTextField displayRectIgnoringOpacity:]): (-[KWQSecureTextField displayRectIgnoringOpacity:]): (-[KWQSearchField displayRectIgnoringOpacity:]):
kwq/KWQWidget.h:
kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::~QWidget): (QWidget::paint): (QWidget::setDeferFirstResponderChanges):

2:33 AM Changeset in webkit [10815] by eseidel

2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: hyatt

Checks for leaks in ImageDiff too.

Scripts/run-webkit-tests:

2:19 AM Changeset in webkit [10814] by eseidel

2 edits in trunk/WebCore

Bug #: 5278
Submitted by: Rob Buis <rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fix SVGSymbolElementImpl to not warn when inheriting viewbox.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5278

ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::close):

2:11 AM Changeset in webkit [10813] by eseidel

4 edits in trunk/WebCore

Bug #: 5301
Submitted by: Julien Palmas <julien.palmas@mac.com>
Reviewed by: eseidel

Fixes WebCore+SVG build under gcc 3.3
http://bugzilla.opendarwin.org/show_bug.cgi?id=5301

WebCore+SVG/DrawCanvasItem.mm:
WebCore+SVG/DrawView.mm: (-[DrawDocument drawRect:initWithDrawView:]):
kwq/KWQSlot.mm:

Oct 10, 2005:

11:55 PM Changeset in webkit [10812] by ggaren

2 edits in trunk/WebCore

Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes in Safari at com.apple.WebCore: KJS::Window::clear + 132

Reviewed by mjs.

No test case because this crash isn't reliably reproducible.

khtml/ecma/kjs_window.cpp: (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we know not to write to it until it's explicitly set to a valid address.

8:45 PM Changeset in webkit [10811] by darin

3 edits in trunk/LayoutTests

updated expected results due to fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5195

The old results were incorrectly clipped. This always worked fine in the
browser, but didn't draw correctly in DumpRenderTree until the bug was fixed.

fast/clip/014-expected.checksum: Updated.
fast/clip/014-expected.png: Updated.

7:49 PM Changeset in webkit [10810] by darin

7 edits in trunk/WebCore

Reviewed by Maciej.

finished fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=5195 Would like API to flush rendering of pending DOM changes

The first half of the fix alone broke DumpRenderTree. Better now.

kwq/KWQWidget.h: Made paint non-virtual (it had no reason to be virtual in KWQ) and added an isPainting function.
kwq/KWQWidget.mm: (QWidget::QWidget): Added painting boolean (actually a count). (QWidget::~QWidget): Check that painting is 0 when the widget is destroyed. (QWidget::paint): Use SPI to draw in a way that works no matter what context we are in. (QWidget::isPainting): Return true if inside the paint function.

kwq/KWQTextArea.h: Remove inDrawingMachinery field since we can use isPainting now.
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Use isPainting() instead of inDrawingMachinery. inDrawingMachinery required that we use displayRectIgnoringOpacity: to paint, which we no longer do.
kwq/KWQTextField.h: More of the same.
kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Ditto.

4:48 PM Changeset in webkit [10809] by eseidel

5 edits in trunk/WebCore

Bug #: 5320
Submitted by: darin
Reviewed by: eseidel

Mem leak fixes in xslt code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5320

khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform): (DocumentImpl::setTransformSourceDocument):
khtml/xml/xml_tokenizer.cpp: (khtml::parseXMLDocumentFragment):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::XSLTProcessorImpl): (DOM::XSLTProcessorImpl::~XSLTProcessorImpl): (DOM::stylesheetLoadFunc): (DOM::XSLTProcessorImpl::transformDocument): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::stylesheet): (DOM::XSLTProcessorImpl::sourceDocument):

4:32 PM Changeset in webkit [12207]