Context Navigation

← Previous Period
Next Period →

Timeline

Oct 16, 2005:

11:20 PM Changeset in webkit [10859] by hyatt

4 edits in trunk/WebCore

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyLeftoverAnonymousChildren):
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::destroy):

Oct 15, 2005:

8:36 PM Changeset in webkit [10858] by mjs

8 edits in trunk/WebCore

Backed out the following changes, since they are in a range that
provably caused a performance regression:

<rdar://problem/4302874> Denver Regression: crash repeatedly reloading www.supermanhomepage.com
<rdar://problem/4302879> Re-land SVG object element fix
<rdar://problem/4302880> Re-land isSameNode change
<rdar://problem/4065748> Repro crash at http://www.vanaqua.org using menu system (KHTMLParser::setCurrent(DOM::NodeImpl*))

khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
khtml/html/htmlparser.cpp: (HTMLStackElem::HTMLStackElem): (HTMLParser::popNestedHeaderTag): (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::popOneBlock):
khtml/xml/dom_nodeimpl.h:
kwq/DOM.mm:

5:46 PM Changeset in webkit [10857] by mjs

13 edits
5 adds
2 deletes in trunk/JavaScriptCore

Reverted fix for this bug, because it was part of a time range that caused a performance
regression:

<rdar://problem/4260481> Remove Reference type from JavaScriptCore

4:27 PM Changeset in webkit [10856] by darin

2 edits in trunk/JavaScriptCore

kxmlcore/HashTable.cpp: Fixed build failure (said hashtable.h instead of HashTable.h).

Oct 14, 2005:

2:03 PM Changeset in webkit [10855] by ggaren

2 edits in trunk/JavaScriptCore

Style changes recommended by Darin.

Changed to camelCase, changed ValueImp* to ValueImp *.

kjs/simple_number.h: (KJS::SimpleNumber::make): (KJS::SimpleNumber::value):

1:57 PM Changeset in webkit [10854] by ggaren

2 edits in trunk/WebCore

Style change suggested by Darin.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Added "Bugzilla" prefix to bug #.

1:31 PM Changeset in webkit [10853] by vicki

2 edits in trunk/WebKit

Changes by Mitz Pettel, reviewed by Maciej.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): Prefer the main resource if it is an image

1:20 PM Changeset in webkit [10852] by eseidel

2 edits in trunk/WebCore

Bug #: 5336
Submitted by: Julien Palmas <julien.palmas@mac.com>
Reviewed by: eseidel

Fixed crash when animating unsupported elements.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5336

ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetElement):

Oct 13, 2005:

11:10 PM Changeset in webkit [10851] by eseidel

2 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none, removed newline.

Committed file w/ extra newline by mistake.

fast/js/resources/xmlhttprequest-get-data.xml:

4:54 PM Changeset in webkit [10850] by eseidel

1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding the mozilla xslt tests.

fast/xsl/mozilla-tests.xml: Added.
fast/xsl/mozilla-tests.xsl: Added.
fast/xsl/mozilla-tests-expected.txt: Added.

4:51 PM Changeset in webkit [10849] by eseidel

6 adds in trunk/LayoutTests/fast

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

fast/js/resources/xmlhttprequest-get-data.xml: Added.
fast/js/xmlhttprequest-get-expected.txt: Added.
fast/js/xmlhttprequest-get.xhtml: Added.

4:39 PM Changeset in webkit [10848] by eseidel

1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Adding a small xmlhttprequest test.

fast/js/resources/xmlhttprequest-get-data.xml: Added.
fast/js/xmlhttprequest-get-expected.txt: Added.
fast/js/xmlhttprequest-get.xhtml: Added.

3:51 PM Changeset in webkit [10847] by justing

9 edits
4 adds in trunk/LayoutTests

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Updated/added layout tests:

fast/clip/001-expected.txt:
fast/clip/009-expected.txt:
fast/clip/010-expected.txt:
fast/clip/011-expected.txt:
fast/clip/012-expected.txt:
fast/clip/013-expected.txt:
fast/clip/014-expected.txt:
fast/clip/016-expected.txt:
fast/clip/outline-overflowClip-expected.checksum: Added.
fast/clip/outline-overflowClip-expected.png: Added.
fast/clip/outline-overflowClip-expected.txt: Added.
fast/clip/outline-overflowClip.html: Added.

3:45 PM Changeset in webkit [10846] by justing

4 edits in trunk/WebCore

Reviewed by hyatt

<rdar://problem/3643259> contentEditable=true elements do not acquire the caret or focus halo when overflow:scroll

Test cases added:

fast/clip/outline-overflowClip Test cases changed (since I added the outline rect to the render tree dump)
fast/clip/001
fast/clip/009
fast/clip/010
fast/clip/011
fast/clip/012
fast/clip/013
fast/clip/014
fast/clip/016

khtml/rendering/render_layer.cpp: Clip the outline by a new rect, which is equal to the foreground rect w/o clipping by the overflow rect.

(khtml::RenderLayer::paintLayer):
(khtml::RenderLayer::hitTestLayer):
(khtml::RenderLayer::calculateRects):

khtml/rendering/render_layer.h:
kwq/KWQRenderTreeDebug.cpp: (write): (writeLayers):

3:07 PM Changeset in webkit [10845] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin.

no need to calculate linewidth multiple times in findnextlinebreak()
http://bugzilla.opendarwin.org/show_bug.cgi?id=5319

No test case needed, this is a simple optimization.

khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):

12:37 PM Changeset in webkit [10844] by vicki

2 edits in trunk/WebKit

Reviewed by Darin.

fix <rdar://problem/4043643> iframe swallows events for overlapping elements (3449)

WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): (-[WebHTMLView _updateMouseoverWithEvent:]): eliminate _hitViewForEvent hackery and self dependency from this function

12:11 PM Changeset in webkit [10843] by ggaren

3 edits in trunk/WebCore

Fixed <rdar://problem/4259434> Safari crashes in HTMLTokenizer::~HTMLTokenizer() at http://www.timewarner.com/corp/careers/jobtools_us/index.html

I changed the test for whether to put a script in the "to be executed" queue to
match the test for whether to ref a script, so that scripts can't end up in the
queue without being refed.

I also renamed cachedScript to pendingScripts.

Reviewed by Darin.

No test case because the crash isn't deterministically reproducible.
However, I did add assertions that should catch the underlying bug
in the future.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::notifyFinished):
khtml/html/htmltokenizer.h:

1:29 AM Changeset in webkit [10842] by eseidel

9 edits in trunk

Bug #: 5326
Submitted by: Rob Buis <rwlbuis@xs4all.nl>
Reviewed by: eseidel

Test cases updated:

svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.png:
svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:

Fixed <svg> to base %lengths off of the nearest viewbox.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5326

ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::x): (SVGSVGElementImpl::y): (SVGSVGElementImpl::width): (SVGSVGElementImpl::height):

Oct 12, 2005:

6:41 PM Changeset in webkit [10841]

4 copies
7 deletes in tags/Safari-421

This commit was manufactured by cvs2svn to create tag 'Safari-421'.

6:41 PM Changeset in webkit [10840] by thatcher

3 edits in branches/Safari-Leo-branch

Versioning to 421

6:08 PM Changeset in webkit [10839] by thatcher

10 edits in trunk/WebKit

Reviewed by Darin.

Define WebNSInt and WebNSUInt to wrap around NSInt on Leopard and still build on Tiger
Once building on Tiger isn't needed we will drop WebNSInt and use NSInt

WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
WebView.subproj/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
WebView.subproj/WebLoader.m: (-[NSURLProtocol didReceiveData:lengthReceived:]):
WebView.subproj/WebResourceLoadDelegate.h:
WebView.subproj/WebUIDelegate.h:
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
WebView.subproj/WebViewInternal.h:
WebView.subproj/WebViewPrivate.h:

5:53 PM Changeset in webkit [10838] by vicki

3 edits in trunk/LayoutTests

update expected results for <rdar://problem/4288266> createElement does not validate names when called in an HTML document (4566)

dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt:
dom/html/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt:

5:49 PM Changeset in webkit [10837] by vicki