Timeline



Oct 18, 2005:

5:03 PM Changeset in webkit [10870] by mjs
  • 6 edits in trunk/WebCore

Reviewed and landed by Maciej.

  • some simple changes that amount to a < 1% speedup.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • kwq/KWQKURL.mm: (hasSlashDotOrDotDot):
  • kwq/KWQString.mm: (QString::~QString):
  • kwq/WebCoreTextRendererFactory.h:
1:45 PM Changeset in webkit [10869] by mjs
  • 10 edits in trunk/WebCore
  • back out the last change, it caused a regression with painting of offscreen plugins
  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/rendering/render_form.cpp: (RenderFormElement::layout):
  • khtml/rendering/render_frames.cpp: (RenderPartObject::layout): (RenderPart::updateWidgetPositions):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollToOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::updateWidgetPositions):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::layout): (RenderWidget::updateWidgetPositions):
  • khtml/rendering/render_replaced.h:
10:08 AM Changeset in webkit [10868] by sullivan
  • 10 edits in trunk/WebCore

Reviewed by Dave Hyatt.
Committed by John Sullivan.

  • .5% or so speedup by removing updateWidgetPositions

Instead, widget sizes are calculated in layout and widget positions are set at
paint time, with the same kind of special handling for incremental repaint that
RenderImage does.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
  • khtml/rendering/render_form.cpp: (RenderFormElement::layout):
  • khtml/rendering/render_frames.cpp: (RenderPartObject::layout):
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollToOffset):
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::layout):
  • khtml/rendering/render_replaced.h:

Oct 17, 2005:

8:15 PM Changeset in webkit [10867] by mjs
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Geoff. Code changes by Darin.

  • some micro-optimizations to FastMalloc to reduce math and branches.
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_Central_FreeList::Populate): (KXMLCore::fastMallocRegisterThread): (KXMLCore::TCMalloc_ThreadCache::GetCache): (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent):

WebCore:

Reviewed by Geoff.

Speed up the tokenizer by keeping more state on the stack instead of in the object,
to avoid load-store traffic. About a .5% speedup.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::setForceSynchronous): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::allDataProcessed): (khtml::HTMLTokenizer::end): (khtml::HTMLTokenizer::finish): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::isWaitingForScripts):
  • khtml/html/htmltokenizer.h: (khtml::HTMLTokenizer::): (khtml::HTMLTokenizer::State::State): (khtml::HTMLTokenizer::State::tagState): (khtml::HTMLTokenizer::State::setTagState): (khtml::HTMLTokenizer::State::entityState): (khtml::HTMLTokenizer::State::setEntityState): (khtml::HTMLTokenizer::State::inScript): (khtml::HTMLTokenizer::State::setInScript): (khtml::HTMLTokenizer::State::inStyle): (khtml::HTMLTokenizer::State::setInStyle): (khtml::HTMLTokenizer::State::inSelect): (khtml::HTMLTokenizer::State::setInSelect): (khtml::HTMLTokenizer::State::inXmp): (khtml::HTMLTokenizer::State::setInXmp): (khtml::HTMLTokenizer::State::inTitle): (khtml::HTMLTokenizer::State::setInTitle): (khtml::HTMLTokenizer::State::inPlainText): (khtml::HTMLTokenizer::State::setInPlainText): (khtml::HTMLTokenizer::State::inProcessingInstruction): (khtml::HTMLTokenizer::State::setInProcessingInstruction): (khtml::HTMLTokenizer::State::inComment): (khtml::HTMLTokenizer::State::setInComment): (khtml::HTMLTokenizer::State::inTextArea): (khtml::HTMLTokenizer::State::setInTextArea): (khtml::HTMLTokenizer::State::escaped): (khtml::HTMLTokenizer::State::setEscaped): (khtml::HTMLTokenizer::State::inServer): (khtml::HTMLTokenizer::State::setInServer): (khtml::HTMLTokenizer::State::skipLF): (khtml::HTMLTokenizer::State::setSkipLF): (khtml::HTMLTokenizer::State::startTag): (khtml::HTMLTokenizer::State::setStartTag): (khtml::HTMLTokenizer::State::discardLF): (khtml::HTMLTokenizer::State::setDiscardLF): (khtml::HTMLTokenizer::State::allowYield): (khtml::HTMLTokenizer::State::setAllowYield): (khtml::HTMLTokenizer::State::loadingExtScript): (khtml::HTMLTokenizer::State::setLoadingExtScript): (khtml::HTMLTokenizer::State::forceSynchronous): (khtml::HTMLTokenizer::State::setForceSynchronous): (khtml::HTMLTokenizer::State::inAnySpecial): (khtml::HTMLTokenizer::State::hasTagState): (khtml::HTMLTokenizer::State::hasEntityState): (khtml::HTMLTokenizer::State::): (khtml::HTMLTokenizer::State::setBit): (khtml::HTMLTokenizer::State::testBit):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::checkLinesForTextOverflow):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_object.cpp: (RenderObject::firstLineStyle):
  • khtml/rendering/render_object.h: (khtml::RenderObject::style):
5:16 PM Changeset in webkit [10866] by mjs
  • 12 edits in trunk

LayoutTests:

  • temporarily back out hyatt's recent changes since the tree was closed
  • fast/clip/008-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/dom/gc-3.html:
  • fast/table/overflowHidden-expected.txt:

WebCore:

  • temporarily back out hyatt's recent changes since the tree was closed
  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyChildren):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy):
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::sortByZOrder):
  • khtml/rendering/render_layer.h:
2:23 PM Changeset in webkit [10865] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • JavaScriptCore.exp: Rolled out some NPN symbols from my last commit that Tim O. and I determined are not public.
11:41 AM Changeset in webkit [10864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed: <rdar://problem/4300099> JavaScriptCore export file needs to include symbols used by Java/liveconnect and other bindings clients

Reviewed by Darin and Geoff.

  • JavaScriptCore.exp: adding a few sysmbols for jni bindings also add the WebUndefined ObjC class symbol, and some missing NPN symbols
12:37 AM Changeset in webkit [10863] by hyatt
  • 1 edit in trunk/LayoutTests/fast/table/overflowHidden-expected.txt

check in fixed overflow:hidden table case.

12:36 AM Changeset in webkit [10862] by hyatt
  • 2 edits in trunk/LayoutTests/fast/css

Check in fixed acid2.

12:35 AM Changeset in webkit [10861] by hyatt
  • 1 edit in trunk/LayoutTests/fast/clip/008-expected.txt

Fix clip test.

12:29 AM Changeset in webkit [10860] by hyatt
  • 3 edits in trunk/WebCore

Fix for bugzilla bug 5283. Make overflow layers lose to other kinds of
layers if z-index is equivalent. Technically overflow isn't even supposed
to establish a stacking context, so the use of RenderLayer for overflow,
although elegant and simple, isn't correct. This patch is essentially a hack
to make the common problem go away, but the deeper mistake remains.

Reviewed by eseidel

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::isOverflowOnly): (khtml::compare): (khtml::sortByZOrder):
  • khtml/rendering/render_layer.h:

Oct 16, 2005:

11:20 PM Changeset in webkit [10859] by hyatt
  • 4 edits in trunk/WebCore

Clean up the deletion of anonymous boxes in the render tree.
Renamed methods to make it more clear and also added comments.

Reviewed by bdakin

  • khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyLeftoverAnonymousChildren):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::destroy):

Oct 15, 2005:

8:36 PM Changeset in webkit [10858] by mjs
  • 8 edits in trunk/WebCore

Backed out the following changes, since they are in a range that
provably caused a performance regression:

<rdar://problem/4302874> Denver Regression: crash repeatedly reloading www.supermanhomepage.com
<rdar://problem/4302879> Re-land SVG object element fix
<rdar://problem/4302880> Re-land isSameNode change
<rdar://problem/4065748> Repro crash at ​http://www.vanaqua.org using menu system (KHTMLParser::setCurrent(DOM::NodeImpl*))

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
  • khtml/html/htmlparser.cpp: (HTMLStackElem::HTMLStackElem): (HTMLParser::popNestedHeaderTag): (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::popOneBlock):
  • khtml/xml/dom_nodeimpl.h:
  • kwq/DOM.mm:
5:46 PM Changeset in webkit [10857] by mjs
  • 13 edits
    5 adds
    2 deletes in trunk/JavaScriptCore

Reverted fix for this bug, because it was part of a time range that caused a performance
regression:

<rdar://problem/4260481> Remove Reference type from JavaScriptCore

4:27 PM Changeset in webkit [10856] by darin
  • 2 edits in trunk/JavaScriptCore
  • kxmlcore/HashTable.cpp: Fixed build failure (said hashtable.h instead of HashTable.h).

Oct 14, 2005:

2:03 PM Changeset in webkit [10855] by ggaren
  • 2 edits in trunk/JavaScriptCore

Style changes recommended by Darin.

Changed to camelCase, changed ValueImp* to ValueImp *.

  • kjs/simple_number.h: (KJS::SimpleNumber::make): (KJS::SimpleNumber::value):
1:57 PM Changeset in webkit [10854] by ggaren
  • 2 edits in trunk/WebCore

Style change suggested by Darin.

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Added "Bugzilla" prefix to bug #.
1:31 PM Changeset in webkit [10853] by vicki
  • 2 edits in trunk/WebKit

Changes by Mitz Pettel, reviewed by Maciej.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5029 (Assertion failure in -[NSPasteboard(WebExtras)
_web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon)

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:URL:title:archive:types:]): Prefer the main resource if it is an image
1:20 PM Changeset in webkit [10852] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5336
Submitted by: Julien Palmas <​julien.palmas@mac.com>
Reviewed by: eseidel

Fixed crash when animating unsupported elements.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5336

  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetElement):
Note: See TracTimeline for information about the timeline view.