Context Navigation

khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::insertTab):
khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString):

Oct 29, 2005:

10:26 PM Changeset in webkit [11008] by hyatt

4 edits in trunk/WebCore

Fix the performance regression caused by doing too much copying of background/border values. This patch attempts to rectify things by doing the following:

(1) Don't initialize the border/background cached values on every single style resolution.
(2) Only cache the border/background values just after user agent styles have been resolved if the user agent set an appearance.
(3) Only check for appearance disabling if you had a UA appearance originally (and then continue to have an appearance after author/user styles have been resolved too)
(4) Make sure to patch the pseudoStyleForElement method too. With the removal of the initialization code for the values running over and over again, I needed to make sure to patch this function to match styleForElement.

Reviewed by sullivan

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/css/cssstyleselector.h:

Oct 28, 2005:

3:29 PM Changeset in webkit [11007]

71 copies
5 deletes in tags/JavaScriptCore-417~4

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~4'.

3:29 PM Changeset in webkit [11006] by thatcher

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.4

10:35 AM Changeset in webkit [11005] by bdakin

6 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

10:14 AM Changeset in webkit [11004] by adele

2 edits in trunk/WebCore

Reviewed by Beth.

fixed <rdar://problem/4319232> finding text in overflow area doesn't always scroll to the right place

khtml/rendering/render_text.cpp: (RenderText::selectionRect): Subtracts scroll offset of containing block layer.

4:46 AM Changeset in webkit [11003] by hyatt

3 edits in trunk/LayoutTests/editing/selection

Update editing tests for button changes

4:24 AM Changeset in webkit [11002] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_theme_mac.mm

Adjust the padding of mini buttons down from 11px to 8px so that they fit better in small spaces.

1:44 AM Changeset in webkit [11001] by hyatt

2 adds in trunk/LayoutTests/fast/forms

Add positioned test for buttons.

1:42 AM Changeset in webkit [11000] by hyatt

2 edits in trunk/WebCore

Make sure positioned content works with width:intrinsic. Fixes positioned buttons. The bug
is bugzilla #5520.

Reviewed by mjs

fast/forms/positioned-button.html

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues):

1:01 AM Changeset in webkit [10999] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

-fixed <rdar://problem/4081091> focus() does not work properly on anchors
<rdar://problem/4317689> new form elements don't get revealed when focus() is called on them

khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): call scrollRectToVisible.

12:25 AM Changeset in webkit [10998] by hyatt

11 edits in trunk/LayoutTests/fast

Check in updated button tests.

12:03 AM Changeset in webkit [10997] by hyatt

9 edits in trunk/WebCore

Fix for bug 5519, buttons need to honor background/border: none and turn off styles.
This patch changes the default style rules so that buttons have both a border and
a background color.

If the author changes the border/background so that it no longer matches these chosen
defaults, we assume that the button has now been styled and we turn off the Aqua
appearance.

We also play more games with border and padding and juggle the values around so that
things look right with Aqua turned on and off.

Reviewed by mjs

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyDeclarations):
khtml/css/cssstyleselector.h:
khtml/css/html4.css:
khtml/rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderData::operator!=): (khtml::RenderStyle::border):
khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint): (khtml::RenderTheme::isControlStyled):
khtml/rendering/render_theme.h:
khtml/rendering/render_theme_mac.h:
khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustButtonStyle): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):

Oct 27, 2005:

6:51 PM Changeset in webkit [10996] by vicki

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix problems with link jumping. In the cases below, we were calculating the wrong position to scroll to.

<rdar://problem/4247537> link jumping should scroll to tallest object on line, not first object on line
<rdar://problem/3489554> when calculating position for link jumping, skip siblings that are unrendered whitespace
<rdar://problem/4244382> Safari - erratic behavior of empty anchor tags followed by whitespace
<rdar://problem/4256060> Link scrolling to last object on the page doesn't work if the link being scrolled to contains an empty inline
<rdar://problem/4276623> erratic link jumping when tables are involved

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner):

5:49 PM Changeset in webkit [10995] by eseidel

5 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, build fix only.

Build fix, forgot to commit project file.
Also need to make XSLT #ifdef's work for portability.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3275

WebCore.xcodeproj/project.pbxproj:
khtml/ecma/XSLTProcessor.cpp:
khtml/ecma/XSLTProcessor.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):

5:06 PM Changeset in webkit [10994] by eseidel

2 edits in trunk

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

No review needed, svg build fix only.

kdom/xpointer/XPointerExpressionImpl.cpp: "Shared.h" to "kdom/Shared.h"

4:19 PM Changeset in webkit [10993] by harrison

1 edit
2 adds in trunk/LayoutTests

Reviewed by Justin Garcia and Dave Hyatt.

Test cases for <rdar://problem/4134884>.

fast/events/event-targets-expected.txt: Added.
fast/events/event-targets.html: Added.

4:15 PM Changeset in webkit [10992] by harrison

11 edits in trunk/WebCore

Reviewed by Justin Garcia and Dave Hyatt.

<rdar://problem/4134884> crash trying to forward msg - khtml::RenderBlock::addChildToFlow

Problem was that onunload events were being fired while in the middle of trying to detach, which resulted in updateDocumentsRendering re-attaching the previously detached nodes. Similar problem with load events while attaching.

Solved by eliminating load and unload for object nodes, pre-sending unload before detach, and sending dom mutation and load events after attaching.

Also, added asserts to catch this problem more easily in the future.

Added test:

fast/events/event-targets.html Make sure that load and unload events do not fire on certain objects.

khtml/ecma/kjs_html.cpp: (KJS::Image::notifyFinished): Use constant string for "load" event name.
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): Use constant strings for "load" and "readystatechange" event names.
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::close): (HTMLFrameElementImpl::willRemove): (HTMLFrameElementImpl::detach): Add willRemove() function.
khtml/html/html_baseimpl.h: Add willRemove() function.
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::attach): (DOM::HTMLObjectElementImpl::detach): Stop needlessly sending load and unload events for OBJECT elements.
khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeIteratorImpl::notifyBeforeNodeRemoval): Rename local variable from willRemove to removedNode for clarity.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::forbidEventDispatch): (DocumentImpl::allowEventDispatch): (DocumentImpl::eventDispatchForbidden): (DocumentImpl::createEvent): Add mechanism to prevent event dispatch.
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::NodeImpl::willRemove): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::willRemove): (DOM::ContainerNodeImpl::willRemoveChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents): Prevent event dispatch during DOM node removals and additions.
khtml/xml/dom_nodeimpl.h:

3:49 PM Changeset in webkit [10991] by ggaren

1 edit
2 adds in trunk/LayoutTests

Layout test included with http://bugzilla.opendarwin.org/show_bug.cgi?id=5303
TextInputController should support attributed strings

fast/forms/attributed-strings-expected.txt: Added.
fast/forms/attributed-strings.html: Added.

3:42 PM Changeset in webkit [10990] by eseidel

1 edit
2 adds in trunk/LayoutTests

Bug #: 3275
Submitted by: eseidel
Reviewed by: darin

Test cases for the new XSLTProcessor JS object.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3275

fast/xsl/xslt-processer-expected.txt: Added.
fast/xsl/xslt-processer.html: Added.

3:35 PM Changeset in webkit [10989] by harrison

2 edits in trunk/WebCore

Reviewed by Tim Omerick.

<rdar://problem/4251172> AX: Safari crashes on www.mozilla.org with Voice Over - khtml::RenderImage::imageMap

Test cases added: None. Manual testing is way to awkward, and automated testing
is not possible. See following bug...
<rdar://problem/4256882> Need automated testing support for accessibility APIs

ChangeLog:
khtml/rendering/render_image.cpp: (RenderImage::RenderImage): (RenderImage::imageMap): (RenderImage::updateAltText):

3:34 PM Changeset in webkit [10988] by eseidel

10 edits
2 adds in trunk/WebCore

Bug #: 3275
Submitted by: eseidel
Reviewed by: hyatt, darin

Add XSLTProcessor support to WebCore's JavaScript bindings.
<rdar://problem/3642402> add XSLTProcessor to WebCore's JavaScript support
http://bugzilla.opendarwin.org/show_bug.cgi?id=3275

WebCore.xcodeproj/project.pbxproj:
khtml/ecma/XSLTProcessor.cpp: Added. (KJS::): (KJS::XSLTProcessor::XSLTProcessor): (KJS::XSLTProcessor::~XSLTProcessor): (KJS::XSLTProcessorProtoFunc::callAsFunction):
khtml/ecma/XSLTProcessor.h: Added. (KJS::XSLTProcessor::classInfo): (KJS::XSLTProcessor::): (KJS::XSLTProcessor::impl): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp): (KJS::XSLTProcessorConstructorImp::implementsConstruct): (KJS::XSLTProcessorConstructorImp::construct):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
khtml/ecma/kjs_window.h: (KJS::Window::):
khtml/khtml_part.cpp: (KHTMLPart::replaceDocImpl):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::applyXSLTransform):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument): (DOM::DocumentImpl::setTransformSourceDocument):
khtml/xml/xml_tokenizer.cpp: (khtml::xmlDocPtrForString): (khtml::XMLTokenizer::setTransformSource):
khtml/xml/xml_tokenizer.h:
khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc): (DOM::stylesheetLoadFunc): (DOM::setXSLTLoadCallBack): (DOM::writeToQString): (DOM::saveResultToString): (DOM::transformTextStringToXHTMLDocumentString): (DOM::xsltParamArrayFromQDict): (DOM::freeXsltParamArray): (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::resultMIMEType): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::setParameter): (DOM::XSLTProcessorImpl::getParameter): (DOM::XSLTProcessorImpl::removeParameter):
khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::XSLTProcessorImpl): (DOM::XSLTProcessorImpl::setXSLStylesheet): (DOM::XSLTProcessorImpl::importStylesheet): (DOM::XSLTProcessorImpl::clearParameters): (DOM::XSLTProcessorImpl::reset): (DOM::XSLTProcessorImpl::xslStylesheet):

3:15 PM Changeset in webkit [10987] by ggaren

2 edits in trunk/WebKitTools

Patch by Alexey Proskuryakov.

Reviewed by Maciej.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=5303
TextInputController should support attributed strings

DumpRenderTree/TextInputController.m: (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]): (+[NSMutableAttributedString webScriptNameForSelector:]): (-[NSMutableAttributedString getLength]): (-[NSMutableAttributedString attributeNamesAtIndex:]): (-[NSMutableAttributedString valueOfAttribute:atIndex:]): (-[NSMutableAttributedString addAttribute:value:]): (-[NSMutableAttributedString addAttribute:value:from:length:]): (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]): (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]): (-[NSMutableAttributedString addFontAttribute:fontName:size:]): (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController insertText:]): (-[TextInputController attributedSubstringFrom:length:]): (-[TextInputController attributedStringWithString:]):

1:13 PM Changeset in webkit [10986] by adele

2 edits in trunk/WebCore

Reviewed by Vicki.

Fixed bug that prevents overflow areas from scrolling to reveal anchor.
Part of <rdar://problem/3612121>.

khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):

10:39 AM Changeset in webkit [10985] by adele

3 edits in trunk/WebCore

Reviewed by Vicki.

fixed <rdar://problem/4318167> REGRESSION: content doesn't scroll far enough to the left after clicking links at aplacecalledcommon.co.uk

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): fixed a typo where verticalAlignment was being passed instead of horizontalAlignment.
khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): specified alignLeft as horizontal alignment.

2:30 AM Changeset in webkit [10984] by hyatt

2 edits in trunk/WebCore

Fix form controls so that they can take advantage of
the style sharing optimization. Special-case the "type"
attribute to accomplish this.

Also add checks for missing pseudo-classes that the sharing
code now needs to check once form controls start sharing
style. These include enabled, checked and indeterminate.

Finally, :target should have been checked all along and was
broken by the original style sharing landing. Add it to the list
of things checked as well.

It's impossible to write a :target test. Other areas more than
covered by existing test cases.

Reviewed by mjs

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector):

2:00 AM Changeset in webkit [10983] by hyatt

2 edits in trunk/WebCore

Fix for bug 5517, percentage height relative block inside a percentage height absolute
block did not stretch properly to fill the absolute block.

Also fixing box-sizing bugs in percentage height calculations. Recurrence in
calcPercentageHeight needed a content box adjustment.

Reviewed by mjs

fast/block/positioning/062.html
fast/box-sizing/percentage-test.html
fast/box-sizing/panels-one.html
fast/box-sizing/panels-two.html

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):

1:57 AM Changeset in webkit [10982] by hyatt

2 adds in trunk/LayoutTests/fast/block/positioning

Add new positioning test.

1:56 AM Changeset in webkit [10981] by hyatt

6 adds in trunk/LayoutTests/fast/box-sizing

Add box-sizing tests.

1:07 AM Changeset in webkit [10980] by eseidel

2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

No review, SVG build fix only.
Fixing fallout from <rdar://problem/4098450>.

WebCore+SVG/xml_kdomtokenizer.cpp: (KDOMTokenizer::write): now returns bool (KDOMTokenizer::finish): error check

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed