Timeline



Nov 1, 2005:

5:59 PM Changeset in webkit [11027] by tomernic
  • 4 edits
    2 adds in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4318632>

I've added a new notification, WebPluginWillPresentNativeUserInterfaceNotification. Plugins are expected to post this
notification before presenting "native UI", such as dialog boxes. A Dashboard client can observe this notification to
hide the Dashboard layer when plugins present external UI.

  • English.lproj/StringsNotToBeLocalized.txt: Added "WebPluginWillPresentNativeUserInterface".
  • Plugins.subproj/WebPluginsPrivate.h: Added.
  • Plugins.subproj/WebPluginsPrivate.m: Added. Declare WebPluginWillPresentNativeUserInterfaceNotification.
  • WebKit.xcodeproj/project.pbxproj: Added WebPluginsPrivate.[hm]
  • WebKit.exp: Added _WebPluginWillPresentNativeUserInterfaceNotification.
5:41 PM Changeset in webkit [11026] by darin
  • 2 edits in trunk/WebKitLibraries
  • libWebKitSystemInterface.a: Updated.
4:53 PM Changeset in webkit [12209] by mjs
  • 5 edits in trunk/JavaScriptGlue

top level:

Reviewed by: Eric.

<rdar://problem/4324107> get JavaScriptGlue working with TOT JavaScriptCore again

  • Makefile.am: re-enable JavaScriptGlue in the build

JavaScriptGlue:

Reviewed by: Eric.

<rdar://problem/4324107> get JavaScriptGlue working with TOT JavaScriptCore again

  • reverted all this stuff to use ReferenceList instead of IdentifierSequencedSet
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
  • UserObjectImp.cpp: (UserObjectImp::propList):
  • UserObjectImp.h:
4:49 PM Changeset in webkit [11025] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 5580, slashdot regression with percentage height
blocks.

Reviewed by darin

Added fast/block/basic/021.html

  • khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
4:41 PM Changeset in webkit [11024] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/basic

Add results for new layout test for slashdot regression

4:27 PM Changeset in webkit [11023] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

fixed deployment build by hiding local variables used only in ASSERTs on builds for
which ASSERT_DISABLED is true.

  • History.subproj/WebHistory.m: (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]):
2:29 PM Changeset in webkit [11022] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison

Tweaked my previous fix for caret movement while scrolling.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): Forgot to copy m_caretPositionOnLayout. (khtml::SelectionController::operator=): Ditto. (khtml::SelectionController::layout): Initialize m_caretPositionOnLayout to a dummy value when the selection isNone.
  • khtml/editing/SelectionController.h: Tweaked my comment.
11:24 AM Changeset in webkit [11021] by sullivan
  • 6 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • fixed <rdar://problem/4324104> Assertion failure (foundDate) in WebHistory

WebFrame was updating the last visited date on a WebHistoryItem behind WebHistory's
back, causing WebHistory's caches of items by date to get out of sync with reality.
Changed to set the date through WebHistory rather than directly.

  • History.subproj/WebHistory.m: (-[WebHistoryPrivate _removeItemFromDateCaches:]): New method, extracted from removeItemForURLString. (-[WebHistoryPrivate removeItemForURLString:]): Now calls extracted method. Cleaned up white space a little. (-[WebHistoryPrivate _addItemToDateCaches:]): New method, extracted from addItem: (-[WebHistoryPrivate addItem:]): Now calls extracted method. Cleaned up white space a little. (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): New method, removes item from date caches, changes date, then adds item back to date caches and sends notification. (-[WebHistory setLastVisitedTimeInterval:forItem:]): New method, cover for WebHistoryPrivate version.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setLastVisitedTimeInterval:]): Don't send notification here; send from new WebHistory method instead.
  • History.subproj/WebHistoryItemPrivate.h: Added comment about avoiding incorrect use of _setLastVisitedTimeInterval:
  • History.subproj/WebHistoryPrivate.h: Added declarations for WebHistory and WebHistoryPrivate versions of setLastVisitedTimeInterval:forItem:
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): change history item's date via new WebHistory method rather than directly
11:20 AM Changeset in webkit [11020] by justing
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Tweaked my ChangeLog entry.

11:19 AM Changeset in webkit [11019] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin

No test cases added, requires Mail

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Crashes were happening after a style was merged with itself. Mail was doing a setTypingStyle with a pointer to our internal typing style. Fix is to only hand out copies of our typingStyle.
11:04 AM Changeset in webkit [11018] by justing
  • 5 edits
    1 add in trunk/WebCore

Reviewed by harrison

Fixed <rdar://problem/3690705> caret does not move when scrolling overflow: auto editable area

  • manual-tests/caretScrolling.html: Added.
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): Removed the unused expectedVisibleRect (khtml::SelectionController::operator=): Ditto. (khtml::SelectionController::layout): Save the caret's absolute position on layout. (khtml::SelectionController::caretRect): Adjust the returned caret rect for offset due to scrolling since the last layout. (khtml::SelectionController::paintCaret):
  • khtml/editing/SelectionController.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Small tweak to a previous change.
  • kwq/KWQRect.h: (QRect::moveTopLeft): Added.
10:36 AM Changeset in webkit [11017] by thatcher
  • 5 edits in trunk/WebCore

Reviewed by Dave Hyatt.
Commited by Tim Hatcher.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5256
Relayout during load causes duplicate plugin part.

This was a problem with <OBJECT>s that contain an <EMBED>, if
layout happened in the middle of the OBJECT but before the EMBED.

No test case added, requires manual testing.

  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::closeRenderer): (DOM::HTMLObjectElementImpl::setComplete):
  • khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isComplete):
  • khtml/html/htmlfactory.cpp: (DOM::objectConstructor):
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
9:33 AM Changeset in webkit [11016] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.
Commited by Tim Hatcher.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5541

HTMLNames constants are not yet initialized at Safari startup,
when bookmarks are imported, which caused a crash in Decoder::decode().

  • kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]):
9:21 AM Changeset in webkit [11015] by sullivan
  • 2 edits in trunk/WebCore

Change by Alexey Proskuryakov, reviewed by Darin Adler.

  • kwq/KWQKURL.mm: (encodeRelativeString): don't use strdup, as it has problems with a curly quote in the string
9:02 AM Changeset in webkit [11014] by andersca
  • 13 edits in trunk/LayoutTests

2005-11-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • dom/xhtml/level3/core/nodegettextcontent06-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent07-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent08-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent09-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent10-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent11-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent12-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent13-expected.txt:
  • dom/xhtml/level3/core/nodegettextcontent14-expected.txt:
  • dom/xhtml/level3/core/nodesettextcontent03-expected.txt:
  • dom/xhtml/level3/core/nodesettextcontent12-expected.txt: These now pass.
  • dom/xhtml/level3/core/nodegettextcontent17-expected.txt: This still fails, but now because entity references are unsupported.
8:59 AM Changeset in webkit [11013] by andersca
  • 6 edits in trunk/WebCore

2005-11-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add setter and setter for textContent.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::textContent): (DOM::NodeImpl::setTextContent):
  • khtml/xml/dom_nodeimpl.h: Implement textContent and setTextContent.
  • kwq/DOM.mm: (-[DOMNode textContent]): (-[DOMNode setTextContent:]): Add Objective C wrappers.

Oct 31, 2005:

11:25 PM Changeset in webkit [11012] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 5529
Submitted by: eseidel
Reviewed by: hyatt

Test cases for XLST recursion check.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5529

  • fast/xsl/resources/xslt-recursion-chain1.xsl: Added.
  • fast/xsl/resources/xslt-recursion-chain2.xsl: Added.
  • fast/xsl/xslt-recursion-expected.txt: Added.
  • fast/xsl/xslt-recursion.xml: Added.
11:16 PM Changeset in webkit [11011] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5529
Submitted by: eseidel
Reviewed by: hyatt

Now ignores XSLT PIs in documents resulting from transforms.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5529

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::processingInstruction):
2:11 PM Changeset in webkit [11010] by thatcher
  • 3 edits in trunk/LayoutTests

Added a correct expected image.

  • fast/dom/dom-parse-serialize-display-expected.checksum:
  • fast/dom/dom-parse-serialize-display-expected.png:
11:04 AM Changeset in webkit [11009] by harrison
  • 3 edits in trunk/WebCore

Remove conditionalized away code added as part of tab character support.

  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::insertTab):
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString):

Oct 29, 2005:

10:26 PM Changeset in webkit [11008] by hyatt
  • 4 edits in trunk/WebCore

Fix the performance regression caused by doing too much copying of background/border values. This patch attempts to rectify things by doing the following:

(1) Don't initialize the border/background cached values on every single style resolution.
(2) Only cache the border/background values just after user agent styles have been resolved if the user agent set an appearance.
(3) Only check for appearance disabling if you had a UA appearance originally (and then continue to have an appearance after author/user styles have been resolved too)
(4) Make sure to patch the pseudoStyleForElement method too. With the removal of the initialization code for the values running over and over again, I needed to make sure to patch this function to match styleForElement.

Reviewed by sullivan

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/css/cssstyleselector.h:

Oct 28, 2005:

3:29 PM Changeset in webkit [11007]
  • 71 copies
    5 deletes in tags/JavaScriptCore-417~4

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~4'.

3:29 PM Changeset in webkit [11006] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.4

10:35 AM Changeset in webkit [11005] by bdakin
  • 6 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

10:14 AM Changeset in webkit [11004] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

  • fixed <rdar://problem/4319232> finding text in overflow area doesn't always scroll to the right place
  • khtml/rendering/render_text.cpp: (RenderText::selectionRect): Subtracts scroll offset of containing block layer.
4:46 AM Changeset in webkit [11003] by hyatt
  • 3 edits in trunk/LayoutTests/editing/selection

Update editing tests for button changes

4:24 AM Changeset in webkit [11002] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/render_theme_mac.mm

Adjust the padding of mini buttons down from 11px to 8px so that they fit better in small spaces.

1:44 AM Changeset in webkit [11001] by hyatt
  • 2 adds in trunk/LayoutTests/fast/forms

Add positioned test for buttons.

1:42 AM Changeset in webkit [11000] by hyatt
  • 2 edits in trunk/WebCore

Make sure positioned content works with width:intrinsic. Fixes positioned buttons. The bug
is bugzilla #5520.

Reviewed by mjs

fast/forms/positioned-button.html

  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues):
1:01 AM Changeset in webkit [10999] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

-fixed <rdar://problem/4081091> focus() does not work properly on anchors
<rdar://problem/4317689> new form elements don't get revealed when focus() is called on them

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): call scrollRectToVisible.
12:25 AM Changeset in webkit [10998] by hyatt
  • 11 edits in trunk/LayoutTests/fast

Check in updated button tests.

12:03 AM Changeset in webkit [10997] by hyatt
  • 9 edits in trunk/WebCore

Fix for bug 5519, buttons need to honor background/border: none and turn off styles.
This patch changes the default style rules so that buttons have both a border and
a background color.

If the author changes the border/background so that it no longer matches these chosen
defaults, we assume that the button has now been styled and we turn off the Aqua
appearance.

We also play more games with border and padding and juggle the values around so that
things look right with Aqua turned on and off.

Reviewed by mjs

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyDeclarations):
  • khtml/css/cssstyleselector.h:
  • khtml/css/html4.css:
  • khtml/rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderData::operator!=): (khtml::RenderStyle::border):
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint): (khtml::RenderTheme::isControlStyled):
  • khtml/rendering/render_theme.h:
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustButtonStyle): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
Note: See TracTimeline for information about the timeline view.