Timeline



Nov 16, 2005:

7:37 PM Changeset in webkit [11229] by justing
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Fixed the line endings in my previous ChangeLog entry.

6:10 PM Changeset in webkit [11228]
  • 212 copies
    17 deletes in tags/WebCore-417~6

This commit was manufactured by cvs2svn to create tag
'WebCore-417~6'.

6:10 PM Changeset in webkit [11227] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Version to WebCore-417.6

6:01 PM Changeset in webkit [11226] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

More workarounds for <rdar://problem/4213314> WebCore build fails with gcc-5216 or later

5:17 PM Changeset in webkit [11225] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-16 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrson.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.
5:05 PM Changeset in webkit [11224] by justing
  • 293 edits in trunk/LayoutTests

Reviewed by harrison

Updated editing tests to reflect changes for:

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

5:04 PM Changeset in webkit [11223] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications


Editing operations used to set an empty selection on the part before
doing work. Doing this 1) isn't necessary* 2) creates an extra didChangeSelection
notification (4108909) 3) produces a strange shouldChangeSelection call after the
editing operation is complete, i.e. "shouldChangeSelection from null to ...?"


There are still strange shouldChangeSelection calls after this change. For example,
after a delete, the selection before the delete no longer exists, so it probably
doesn't make sense to ask the delegate if WebKit shouldChangeSelection. This is filed
as 4343068.


  • This was added on 2004-09-28 in order to mark misspellings in the selection to be operated on (marking misspellings is a side effect of setting a selection). Misspellings in the old selection are still marked, but not until after the operation is complete. Since some editing operations remove the selection from the document (i.e. delete or undo-typing), respondToChangedSelection no longer assumes that the old selection is in the document.


Updated layout tests to reflect this change.


  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): Don't set the part's selection to empty before editing. (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): Don't assume that the old selection is still in the document.
4:39 PM Changeset in webkit [11222] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/xsl/xslt_processorimpl.cpp

Merge fix, was missing one line.

4:32 PM Changeset in webkit [11221] by adele
  • 3 edits in trunk/WebCore

Reviewed by Dave Harrson.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.
4:30 PM Changeset in webkit [11220]
  • 72 copies
    5 deletes in tags/JavaScriptCore-417~7

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~7'.

4:30 PM Changeset in webkit [11219] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.7

2:07 PM Changeset in webkit [11218] by thatcher
  • 3 edits
    1 add in branches/Safari-2-0-branch/JavaScriptCore

Fixes build failures on Glendale and Chardonnay.
We now use an export file for whatever compiler is selected (since the exported symbols differ.)

  • JavaScriptCore.xcodeproj: use GCC_VERSION_IDENTIFIER to pick the proper export file
  • JavaScriptCore.exp: added the 4 type infos that GCC 4 adds.
  • JavaScriptCore-3.3.exp: the GCC 3.3 export file that excluded GCC 4 symbols
1:45 AM Changeset in webkit [11217] by andersca
  • 45 edits in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Updated tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5737>
Implement DOM3 namespace functions.

  • dom/xhtml/level3/core/nodeisdefaultnamespace01-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace02-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace06-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace07-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace08-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace09-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace10-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace11-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace13-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace14-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace15-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace16-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri02-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri03-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri06-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri07-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri10-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri11-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri13-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri14-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri15-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri18-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri19-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix01-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix02-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix03-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix06-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix07-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix08-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix09-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix10-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix11-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix13-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix14-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix15-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix16-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix18-expected.txt: These tests pass now.
1:43 AM Changeset in webkit [11216] by andersca
  • 6 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add JavaScript wrappers for new Node namespace functions.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isDefaultNamespace): (DOM::NodeImpl::lookupPrefix): (DOM::NodeImpl::lookupNamespaceURI): (DOM::NodeImpl::lookupNamespacePrefix): (DOM::NodeImpl::getAncestorElement): Implement Node namespace functions.
  • khtml/xml/dom_nodeimpl.h: Add definitions for Node namespace functions.
  • kwq/DOM.mm: (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): Add objective C wrappers for new Node namespace functions.

Nov 15, 2005:

6:15 PM Changeset in webkit [11215]
  • 2 copies
    6 deletes in tags/JavaScriptCore-521~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-521~2'.

6:15 PM Changeset in webkit [11214] by thatcher
  • 1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning

5:45 PM Changeset in webkit [12214] by ggaren
  • 2 edits in trunk/JavaScriptGlue

Reviewed by mjs.

  • Part of the fix for <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

Added locking in JSRunCreate, since JSRun::JSRun constructs an object.

  • JavaScriptGlue.cpp: (JSRunCreate):
5:45 PM Changeset in webkit [11213] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by mjs.

  • Fixed <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

I took responsibility for initializing and marking ConstantValues away
from InterpreterImp, since it's possible to reference such a value
before any interpreter has been created and after the last interpreter
has been destroyed.

InterpreterImp::lock now initializes ConstantValues. It's a good
place for the initialization because you have to call it before
creating any objects. Since ::lock can be called more than once,
I added a check in ConstantValues::init to ensure that it executes
only once.

Collector:collect is now responsible for marking ConstantValues.

We no longer clear the ConstantValues since we can't guarantee that no
one has a reference to them.

FIXME: This is hackery. The long-term plan is to make ConstantValues
use immediate values that require no initialization.

  • ChangeLog:
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::lock): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/value.cpp: (KJS::ConstantValues::initIfNeeded):
  • kjs/value.h:
5:39 PM Changeset in webkit [11212] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Vicki Murley <​vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
5:36 PM Changeset in webkit [11211] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Vicki Murley <​vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
5:23 PM Changeset in webkit [11210] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

5:20 PM Changeset in webkit [11209] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

4:24 PM Changeset in webkit [11208] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-13 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text
4:23 PM Changeset in webkit [11207] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-13 Vicki Murley <​vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text
4:12 PM Changeset in webkit [11206] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOMExtensions.h

Rolling out the header change from Adele's patch. We can't add to the public API in Glendale.

4:11 PM Changeset in webkit [11205] by thatcher
  • 9 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-14 Adele Peterson <​adele@apple.com>

Reviewed by Maciej and Darin.

  • fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
  • fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

  • fast/dom/focus-contenteditable.html
  • fast/dom/blur-contenteditable.html
  • khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
  • khtml/xml/dom_elementimpl.h: Added focus and blur functions
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
  • khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
  • kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
  • kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):
2:53 PM Changeset in webkit [11204] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
12:02 PM Changeset in webkit [11203] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  • kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
12:00 PM Changeset in webkit [11202] by harrison
  • 7 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.
(updated png and checksums)

  • editing/deleting/delete-block-merge-contents-019-expected.checksum:
  • editing/deleting/delete-block-merge-contents-019-expected.png:
  • editing/deleting/delete-line-011-expected.checksum:
  • editing/deleting/delete-line-011-expected.png:
  • editing/deleting/delete-line-012-expected.checksum:
  • editing/deleting/delete-line-012-expected.png:
11:15 AM Changeset in webkit [11201] by justing
  • 2 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes

Reviewed by justin

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.

Nov 14, 2005:

11:31 PM Changeset in webkit [11200] by adele
  • 10 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-14 Adele Peterson <​adele@apple.com>

Reviewed by Maciej and Darin.

  • fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
  • fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

  • fast/dom/focus-contenteditable.html
  • fast/dom/blur-contenteditable.html
  • khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
  • khtml/xml/dom_elementimpl.h: Added focus and blur functions
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
  • khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
  • kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
  • kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):
9:09 PM Changeset in webkit [11199]
  • 71 copies
    5 deletes in tags/JavaScriptCore-417~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~6'.

9:09 PM Changeset in webkit [11198] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore
  • JavaScriptCore.exp: removed type info sysmbols that we no longer export according to B&I.
7:26 PM Changeset in webkit [11197]
  • 55 copies
    22 deletes in tags/WebKit-417~4

This commit was manufactured by cvs2svn to create tag 'WebKit-417~4'.

7:26 PM Changeset in webkit [11196]
  • 210 copies
    17 deletes in tags/WebCore-417~5

This commit was manufactured by cvs2svn to create tag
'WebCore-417~5'.

7:26 PM Changeset in webkit [11195]
  • 71 copies
    5 deletes in tags/JavaScriptCore-417~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~5'.

7:26 PM Changeset in webkit [11194] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning.

6:05 PM Changeset in webkit [11193] by adele
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Added layout tests for:
<rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
<rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

  • fast/dom/blur-contenteditable-expected.checksum: Added.
  • fast/dom/blur-contenteditable-expected.png: Added.
  • fast/dom/blur-contenteditable-expected.txt: Added.
  • fast/dom/blur-contenteditable.html: Added.
  • fast/dom/focus-contenteditable-expected.checksum: Added.
  • fast/dom/focus-contenteditable-expected.png: Added.
  • fast/dom/focus-contenteditable-expected.txt: Added.
  • fast/dom/focus-contenteditable.html: Added.

WebCore:

Reviewed by Maciej and Darin.

  • fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
  • fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

  • fast/dom/focus-contenteditable.html
  • fast/dom/blur-contenteditable.html
  • khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
  • khtml/xml/dom_elementimpl.h: Added focus and blur functions
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
  • khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
  • kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
  • kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):
5:12 PM Changeset in webkit [11192] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Add copyright for box-sizing render code from Allan Jensen at KDE

3:04 PM Changeset in webkit [11191] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

  • fast/forms/radio_checked.html
  • khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
  • khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
3:03 PM Changeset in webkit [11190] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Applied fix for the Safari-2-0-branch

2005-11-10 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

  • fast/forms/radio_checked.html
  • khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
  • khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
2:09 PM Changeset in webkit [11189] by justing
  • 31 edits
    4 adds in trunk/LayoutTests

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Added/update layout test results:

  • editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
  • editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
  • editing/pasteboard/block-wrappers-necessary.html: Added.
  • editing/style/create-block-for-style-001-expected.checksum:
  • editing/style/create-block-for-style-001-expected.png:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.checksum:
  • editing/style/create-block-for-style-002-expected.png:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.checksum:
  • editing/style/create-block-for-style-003-expected.png:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.checksum:
  • editing/style/create-block-for-style-004-expected.png:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.checksum:
  • editing/style/create-block-for-style-007-expected.png:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.checksum:
  • editing/style/create-block-for-style-010-expected.png:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.checksum:
  • editing/style/create-block-for-style-012-expected.png:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.checksum:
  • editing/style/create-block-for-style-013-expected.png:
  • editing/style/create-block-for-style-013-expected.txt:
2:09 PM Changeset in webkit [11188] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Updated layout test results in editing/style
Added layout test in editing/pasteboard

  • khtml/css/css_valueimpl.cpp: Fixed a comment.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Don't use clones of paragraphs already in the document to hold paragraph contents, since they are likely to introduce unwanted styles, just use a generic paragraph element. It's less likely, but still possible that a generic paragraph element will have unwanted style, so we may want to eventually use class=Apple-style-block.
11:53 AM Changeset in webkit [11187] by harrison
  • 5 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.

  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-019.html:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
11:53 AM Changeset in webkit [11186] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4337532> Paragraph concatenation fails

Updated editing/deleting tests to correctly check this behavior.

  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Remove erroneous check for isStartOfParagraph(visibleEnd) when deciding whether to clear m_mergeBlocksAfterDelete.
11:32 AM Changeset in webkit [11185] by thatcher
  • 4 edits in branches/Safari-1-3-branch

Build fix.

1:55 AM Changeset in webkit [11184] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

2005-11-14 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add bug numbers for recent fixes.
1:51 AM Changeset in webkit [11183] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Actually save the document.

1:44 AM Changeset in webkit [11182] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-11-14 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add bug numbers for recent fixes.

Nov 13, 2005:

11:43 PM Changeset in webkit [11181] by mjs
  • 2 edits in trunk/WebCore
  • fix Deployment build
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
10:46 PM Changeset in webkit [11180] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4341389> crash in elementAtPoint code quitting Safari, and make this code slightly more readable
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): add a nil check
7:49 PM Changeset in webkit [11179] by vicki
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text
3:56 PM Changeset in webkit [11178] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test to make sure that importNode preserves element prefixes.

  • fast/dom/importNode-prefix-expected.txt: Added.
  • fast/dom/importNode-prefix.html: Added.
3:52 PM Changeset in webkit [11177] by andersca
  • 2 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Use tagName() instead of localName() so the prefix will be preserved.
12:42 PM Changeset in webkit [11176] by bdakin
  • 1 edit
    1 add in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

11:45 AM Changeset in webkit [11175] by andersca
  • 12 edits
    2 adds in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Update tests for change to createDocument which now creates a document element.

  • dom/xhtml/level3/core/documentadoptnode14-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode26-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode27-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt: These tests still fail, but elsewhere now.
  • dom/xhtml/level3/core/nodereplacechild14-expected.txt:
  • dom/xhtml/level3/core/nodesettextcontent02-expected.txt: These tests now succeed.
  • fast/dom/createDocument.html: Added.
  • fast/dom/createDocument-expected.txt: Added.
11:44 AM Changeset in webkit [11174] by andersca
  • 2 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Make sure to create a document element.
11:26 AM Changeset in webkit [11173] by andersca
  • 1 add in trunk/LayoutTests/fast/dom/setAttributeNS-expected.txt

Forgot this.

10:53 AM Changeset in webkit [11172] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test for setAttributeNS with null namespaceURI.

  • fast/dom/setAttributeNS.html: Added.
10:52 AM Changeset in webkit [11171] by andersca
  • 6 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
  • khtml/ecma/kjs_binding.h: Add function which converts a JavaScript value to a DOMString, converting the null value to a null DOMString.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Use valueToStringWithNullCheck in setAttributeNS and the textContent setter.
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::insertedIntoDocument): Don't try to evaluate scripts for viewless documents.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isEqualNode): Get the attribute map from the correct element.

Nov 12, 2005:

7:22 PM Changeset in webkit [11170] by thatcher
  • 6 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-06 Beth Dakin <Beth Dakin>

Reviewed by Vicki.

Fix for <rdar://problem/4145535> Crash in khtml::RenderBlock::addOverhangingFloats
with simple HTML test file.

  • khtml/rendering/render_block.cpp: Added nil check (khtml::RenderBlock::addOverhangingFloats):

WebKit:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

  • WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.
5:17 PM Changeset in webkit [11169] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-09-16 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick

  • fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
  • WebView.subproj/WebImageView.m: (-[WebImageView copy:]): declare types to pasteboard before starting to set their data (-[WebImageView writeSelectionToPasteboard:types:]): ditto
5:10 PM Changeset in webkit [11168] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 Geoffrey Garen <​ggaren@apple.com>

Fixed:
<rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function
<rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided
<rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided
<rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

Reviewed by darin.

Test cases added:

  • manual-tests/resources/write-after-open-popup.html: Added.
  • khtml/khtml_part.cpp: (KHTMLPart::didExplicitOpen): now cancels any pending redirection
5:03 PM Changeset in webkit [11167] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
Vicki thinks this fixes <rdar://problem/3562729> location.replace with dynamically written frameset doesn't change view (3621)

2005-08-01 Geoffrey Garen <​ggaren@apple.com>

Fixed <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Reviewed by darin.

Test cases added:

  • manual-tests/open-after-close.html: Added.
  • manual-tests/resources/open-after-close-popup.html: Added.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): We now remove a WebView from WebViewSets when the WebView is *scheduled* to close.
4:20 PM Changeset in webkit [11166] by thatcher
  • 9 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

  • khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
  • khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
  • khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
  • khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
  • layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
  • layout-tests/fast/table/overflowHidden-expected.txt: Added.
  • layout-tests/fast/table/overflowHidden.html: Added.
4:18 PM Changeset in webkit [11165] by thatcher
  • 9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

  • khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
  • khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
  • khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
  • khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
  • layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
  • layout-tests/fast/table/overflowHidden-expected.txt: Added.
  • layout-tests/fast/table/overflowHidden.html: Added.
3:37 PM Changeset in webkit [11164] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

  • khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.
3:36 PM Changeset in webkit [11163] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

  • khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.
Note: See TracTimeline for information about the timeline view.