Context Navigation

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:46 PM Changeset in webkit [11264] by thatcher

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <harrison@apple.com>

Reviewed by Tim Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:36 PM Changeset in webkit [11263] by harrison

4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.

6:36 PM Changeset in webkit [11262] by thatcher

19 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
khtml/ecma/kjs_window.h: (KJS::Window::):
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
khtml/html/htmlnames.h:
khtml/xml/EventNames.h:
khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
WebView.subproj/WebUIDelegatePrivate.h:
WebView.subproj/WebView.m: (-[WebView shouldClose]):
WebView.subproj/WebViewPrivate.h:

6:08 PM Changeset in webkit [11261] by vicki

2 edits in trunk/WebKit

Changes by Tim H, reviewed by Vicki.

call shouldClose on the bridge for the main frame

WebView.subproj/WebView.m: (-[WebView shouldClose]):

5:27 PM Changeset in webkit [11260] by vicki

6 edits in trunk/WebKit

Changes by Darin, reviewed by Beth and Vicki.

fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
WebView.subproj/WebUIDelegatePrivate.h:
WebView.subproj/WebView.m: (-[WebView shouldClose]):
WebView.subproj/WebViewPrivate.h:

5:26 PM Changeset in webkit [11259] by vicki

13 edits in trunk/WebCore

Changes by Darin, reviewed by Beth and Vicki.

fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)

khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
khtml/ecma/kjs_window.h: (KJS::Window::):
khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
khtml/html/htmlnames.h:
khtml/xml/EventNames.h:
khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

4:19 PM Changeset in webkit [11258] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-16 Adele Peterson <adele@apple.com>

Reviewed by Dave Harrson.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

4:12 PM Changeset in webkit [11257] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):

4:11 PM Changeset in webkit [11256] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):

3:42 PM Changeset in webkit [11255] by bdakin

2 edits
1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:39 PM Changeset in webkit [11254] by thatcher

4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 David Harrison <harrison@apple.com>

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

3:38 PM Changeset in webkit [11253] by thatcher

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <harrison@apple.com>

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

2:46 PM Changeset in webkit [11252] by thatcher

17 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 David Hyatt <hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
khtml/css/html4.css:
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
khtml/rendering/render_style.h: (khtml::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):

2:41 PM Changeset in webkit [11251] by thatcher

17 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-29 David Hyatt <hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
khtml/css/html4.css:
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
khtml/rendering/render_style.h: (khtml::):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):

1:35 PM Changeset in webkit [11250] by harrison

1 edit
4 adds in trunk/LayoutTests

Layout tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>

editing/deleting/move-nodes-001-expected.checksum: Added.
editing/deleting/move-nodes-001-expected.png: Added.
editing/deleting/move-nodes-001-expected.txt: Added.
editing/deleting/move-nodes-001.html: Added.

1:34 PM Changeset in webkit [11249] by harrison

4 edits in trunk/WebCore

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):

10:27 AM Changeset in webkit [11248] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5629 REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()

10:26 AM Changeset in webkit [11247] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5629 REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()

10:02 AM Changeset in webkit [11246] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Adele Peterson <adele@apple.com>

Reviewed by Beth.

fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

10:01 AM Changeset in webkit [11245] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Adele Peterson <adele@apple.com>

Reviewed by Beth.

fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

Nov 17, 2005:

4:57 PM Changeset in webkit [11244]

24 copies
3 deletes in tags/WebKit-312~6

This commit was manufactured by cvs2svn to create tag 'WebKit-312~6'.

4:57 PM Changeset in webkit [11243]

105 copies
5 deletes in tags/WebCore-315~11

This commit was manufactured by cvs2svn to create tag
'WebCore-315~11'.

4:57 PM Changeset in webkit [11242]

9 copies
3 deletes in tags/JavaScriptCore-312~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~2'.

4:57 PM Changeset in webkit [11241] by thatcher

3 edits in branches/Safari-1-3-branch

Versioning

4:49 PM Changeset in webkit [11240] by thatcher

3 edits in branches/Safari-1-3-branch

Versioning

3:40 PM Changeset in webkit [11239] by bdakin

3 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:17 PM Changeset in webkit [11238] by adele

2 edits in trunk/WebCore

Reviewed by Beth.

fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.

2:44 PM Changeset in webkit [11237] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Fix by Darin, reviewed by me.

fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)

Changed the constructors to return the emtpy string if the string is null.

kjs/value.cpp: (Value::Value): (String::String):

2:36 PM Changeset in webkit [11236] by thatcher

4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

2:29 PM Changeset in webkit [11235] by hyatt

4 edits in trunk/WebCore

Add support for getting a style property off of a DOMAttr. This is an API that allows
access to the style declaration for HTML presentational attributes like width and height. This API exists only
in Objective-C, since JS would have to make the declaration readonly before it could be safely
returned.

Reviewed by darin

khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::style): (DOM::AttrImpl::style): (DOM::MappedAttributeImpl::style):
kwq/DOM.mm: (-[DOMAttr style]):
kwq/DOMPrivate.h:

2:24 PM Changeset in webkit [11234] by thatcher

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

1:28 PM Changeset in webkit [11233] by hyatt

11 edits in trunk/WebCore

Add support for getMatchedCSSRules, an API that can be used to
inspect the set of rules that match on an element. From Obj-C
you see all rules (user agent, author, user). From JS you just
see author rules.

Reviewed by darin

khtml/css/cssparser.cpp:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
khtml/css/cssstyleselector.h:
khtml/css/parser.y:
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
khtml/xml/dom2_viewsimpl.h:
kwq/DOM-CSS.mm: (-[DOMDocument getMatchedCSSRules::]):
kwq/DOMCSS.h:

10:45 AM Changeset in webkit [11232] by bdakin

5 edits
4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:32 AM Changeset in webkit [11231] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Adele Peterson <adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

10:29 AM Changeset in webkit [11230] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Adele Peterson <adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

Nov 16, 2005:

7:37 PM Changeset in webkit [11229] by justing

1 edit in trunk/WebCore/ChangeLog-2005-12-19

Fixed the line endings in my previous ChangeLog entry.

6:10 PM Changeset in webkit [11228]

212 copies
17 deletes in tags/WebCore-417~6

This commit was manufactured by cvs2svn to create tag
'WebCore-417~6'.

6:10 PM Changeset in webkit [11227] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Version to WebCore-417.6

6:01 PM Changeset in webkit [11226] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

More workarounds for <rdar://problem/4213314> WebCore build fails with gcc-5216 or later

5:17 PM Changeset in webkit [11225] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-16 Adele Peterson <adele@apple.com>

Reviewed by Dave Harrson.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

5:05 PM Changeset in webkit [11224] by justing

293 edits in trunk/LayoutTests

Reviewed by harrison

Updated editing tests to reflect changes for:

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

5:04 PM Changeset in webkit [11223] by justing

3 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

Editing operations used to set an empty selection on the part before
doing work. Doing this 1) isn't necessary* 2) creates an extra didChangeSelection
notification (4108909) 3) produces a strange shouldChangeSelection call after the
editing operation is complete, i.e. "shouldChangeSelection from null to ...?"

There are still strange shouldChangeSelection calls after this change. For example,
after a delete, the selection before the delete no longer exists, so it probably
doesn't make sense to ask the delegate if WebKit shouldChangeSelection. This is filed
as 4343068.

This was added on 2004-09-28 in order to mark misspellings in the selection to be operated on (marking misspellings is a side effect of setting a selection). Misspellings in the old selection are still marked, but not until after the operation is complete. Since some editing operations remove the selection from the document (i.e. delete or undo-typing), respondToChangedSelection no longer assumes that the old selection is in the document.

Updated layout tests to reflect this change.

khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): Don't set the part's selection to empty before editing. (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): Don't assume that the old selection is still in the document.

4:39 PM Changeset in webkit [11222] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/khtml/xsl/xslt_processorimpl.cpp

Merge fix, was missing one line.

4:32 PM Changeset in webkit [11221] by adele

3 edits in trunk/WebCore

Reviewed by Dave Harrson.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5759 <rdar://problem/4346132> REGRESSION (10.4.3-10.4.4): horizontal link scrolling broken at aplacecalledcommon.co.uk (5759)

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.

4:30 PM Changeset in webkit [11220]

72 copies
5 deletes in tags/JavaScriptCore-417~7

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~7'.

4:30 PM Changeset in webkit [11219] by thatcher

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.7

2:07 PM Changeset in webkit [11218] by thatcher

3 edits
1 add in branches/Safari-2-0-branch/JavaScriptCore

Fixes build failures on Glendale and Chardonnay.
We now use an export file for whatever compiler is selected (since the exported symbols differ.)

JavaScriptCore.xcodeproj: use GCC_VERSION_IDENTIFIER to pick the proper export file
JavaScriptCore.exp: added the 4 type infos that GCC 4 adds.
JavaScriptCore-3.3.exp: the GCC 3.3 export file that excluded GCC 4 symbols

1:45 AM Changeset in webkit [11217] by andersca

45 edits in trunk/LayoutTests

2005-11-14 Anders Carlsson <andersca@mac.com>

Reviewed by Eric.

Updated tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5737>
Implement DOM3 namespace functions.

dom/xhtml/level3/core/nodeisdefaultnamespace01-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace02-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace06-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace07-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace08-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace09-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace10-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace11-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace13-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace14-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace15-expected.txt:
dom/xhtml/level3/core/nodeisdefaultnamespace16-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri02-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri03-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri06-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri07-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri10-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri11-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri13-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri14-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri15-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri18-expected.txt:
dom/xhtml/level3/core/nodelookupnamespaceuri19-expected.txt:
dom/xhtml/level3/core/nodelookupprefix01-expected.txt:
dom/xhtml/level3/core/nodelookupprefix02-expected.txt:
dom/xhtml/level3/core/nodelookupprefix03-expected.txt:
dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
dom/xhtml/level3/core/nodelookupprefix06-expected.txt:
dom/xhtml/level3/core/nodelookupprefix07-expected.txt:
dom/xhtml/level3/core/nodelookupprefix08-expected.txt:
dom/xhtml/level3/core/nodelookupprefix09-expected.txt:
dom/xhtml/level3/core/nodelookupprefix10-expected.txt:
dom/xhtml/level3/core/nodelookupprefix11-expected.txt:
dom/xhtml/level3/core/nodelookupprefix13-expected.txt:
dom/xhtml/level3/core/nodelookupprefix14-expected.txt:
dom/xhtml/level3/core/nodelookupprefix15-expected.txt:
dom/xhtml/level3/core/nodelookupprefix16-expected.txt:
dom/xhtml/level3/core/nodelookupprefix18-expected.txt: These tests pass now.

1:43 AM Changeset in webkit [11216] by andersca

6 edits in trunk/WebCore

2005-11-14 Anders Carlsson <andersca@mac.com>

Reviewed by Eric.

fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=5737> Implement DOM3 namespace functions.

khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add JavaScript wrappers for new Node namespace functions.

khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isDefaultNamespace): (DOM::NodeImpl::lookupPrefix): (DOM::NodeImpl::lookupNamespaceURI): (DOM::NodeImpl::lookupNamespacePrefix): (DOM::NodeImpl::getAncestorElement): Implement Node namespace functions.

khtml/xml/dom_nodeimpl.h: Add definitions for Node namespace functions.

kwq/DOM.mm: (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): Add objective C wrappers for new Node namespace functions.

Nov 15, 2005:

6:15 PM Changeset in webkit [11215]

2 copies
6 deletes in tags/JavaScriptCore-521~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-521~2'.

6:15 PM Changeset in webkit [11214] by thatcher

1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning

5:45 PM Changeset in webkit [12214] by ggaren

2 edits in trunk/JavaScriptGlue

Reviewed by mjs.

Part of the fix for <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

Added locking in JSRunCreate, since JSRun::JSRun constructs an object.

JavaScriptGlue.cpp: (JSRunCreate):

5:45 PM Changeset in webkit [11213] by ggaren

6 edits in trunk/JavaScriptCore

Reviewed by mjs.

Fixed <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

I took responsibility for initializing and marking ConstantValues away
from InterpreterImp, since it's possible to reference such a value
before any interpreter has been created and after the last interpreter
has been destroyed.

InterpreterImp::lock now initializes ConstantValues. It's a good
place for the initialization because you have to call it before
creating any objects. Since ::lock can be called more than once,
I added a check in ConstantValues::init to ensure that it executes
only once.

Collector:collect is now responsible for marking ConstantValues.

We no longer clear the ConstantValues since we can't guarantee that no
one has a reference to them.

FIXME: This is hackery. The long-term plan is to make ConstantValues
use immediate values that require no initialization.

ChangeLog:
kjs/collector.cpp: (KJS::Collector::collect):
kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::lock): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::mark):
kjs/internal.h:
kjs/value.cpp: (KJS::ConstantValues::initIfNeeded):
kjs/value.h:

5:39 PM Changeset in webkit [11212] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Vicki Murley <vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:36 PM Changeset in webkit [11211] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Vicki Murley <vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:23 PM Changeset in webkit [11210] by thatcher

1 edit in branches/Safari-1-3-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

5:20 PM Changeset in webkit [11209] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

4:24 PM Changeset in webkit [11208] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-13 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:23 PM Changeset in webkit [11207] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-13 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:12 PM Changeset in webkit [11206] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOMExtensions.h

Rolling out the header change from Adele's patch. We can't add to the public API in Glendale.

4:11 PM Changeset in webkit [11205] by thatcher

9 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-14 Adele Peterson <adele@apple.com>

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

2:53 PM Changeset in webkit [11204] by vicki

2 edits in trunk/WebCore

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

12:02 PM Changeset in webkit [11203] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

12:00 PM Changeset in webkit [11202] by harrison

7 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.
(updated png and checksums)

editing/deleting/delete-block-merge-contents-019-expected.checksum:
editing/deleting/delete-block-merge-contents-019-expected.png:
editing/deleting/delete-line-011-expected.checksum:
editing/deleting/delete-line-011-expected.png:
editing/deleting/delete-line-012-expected.checksum:
editing/deleting/delete-line-012-expected.png:

11:15 AM Changeset in webkit [11201] by justing

2 edits in trunk/WebCore

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes

Reviewed by justin

kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.

Nov 14, 2005:

11:31 PM Changeset in webkit [11200] by adele

10 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-14 Adele Peterson <adele@apple.com>

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

9:09 PM Changeset in webkit [11199]

71 copies
5 deletes in tags/JavaScriptCore-417~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~6'.

9:09 PM Changeset in webkit [11198] by thatcher

3 edits in branches/Safari-2-0-branch/JavaScriptCore

JavaScriptCore.exp: removed type info sysmbols that we no longer export according to B&I.

7:26 PM Changeset in webkit [11197]

55 copies
22 deletes in tags/WebKit-417~4

This commit was manufactured by cvs2svn to create tag 'WebKit-417~4'.

7:26 PM Changeset in webkit [11196]

210 copies
17 deletes in tags/WebCore-417~5

This commit was manufactured by cvs2svn to create tag
'WebCore-417~5'.

7:26 PM Changeset in webkit [11195]

71 copies
5 deletes in tags/JavaScriptCore-417~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~5'.

7:26 PM Changeset in webkit [11194] by thatcher

6 edits in branches/Safari-2-0-branch

Versioning.

6:05 PM Changeset in webkit [11193] by adele

11 edits
8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Added layout tests for:
<rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
<rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

fast/dom/blur-contenteditable-expected.checksum: Added.
fast/dom/blur-contenteditable-expected.png: Added.
fast/dom/blur-contenteditable-expected.txt: Added.
fast/dom/blur-contenteditable.html: Added.
fast/dom/focus-contenteditable-expected.checksum: Added.
fast/dom/focus-contenteditable-expected.png: Added.
fast/dom/focus-contenteditable-expected.txt: Added.
fast/dom/focus-contenteditable.html: Added.

WebCore:

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

5:12 PM Changeset in webkit [11192] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Add copyright for box-sizing render code from Allan Jensen at KDE

3:04 PM Changeset in webkit [11191] by thatcher

4 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-10 Adele Peterson <adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

fast/forms/radio_checked.html

khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

3:03 PM Changeset in webkit [11190] by thatcher

4 edits in branches/Safari-2-0-branch/WebCore

Applied fix for the Safari-2-0-branch

2005-11-10 Adele Peterson <adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

fast/forms/radio_checked.html

khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

2:09 PM Changeset in webkit [11189] by justing

31 edits
4 adds in trunk/LayoutTests

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Added/update layout test results:

editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
editing/pasteboard/block-wrappers-necessary-expected.png: Added.
editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
editing/pasteboard/block-wrappers-necessary.html: Added.
editing/style/create-block-for-style-001-expected.checksum:
editing/style/create-block-for-style-001-expected.png:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.checksum:
editing/style/create-block-for-style-002-expected.png:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.checksum:
editing/style/create-block-for-style-003-expected.png:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.checksum:
editing/style/create-block-for-style-004-expected.png:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-007-expected.checksum:
editing/style/create-block-for-style-007-expected.png:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-009-expected.checksum:
editing/style/create-block-for-style-009-expected.png:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.checksum:
editing/style/create-block-for-style-010-expected.png:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.checksum:
editing/style/create-block-for-style-011-expected.png:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.checksum:
editing/style/create-block-for-style-012-expected.png:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.checksum:
editing/style/create-block-for-style-013-expected.png:
editing/style/create-block-for-style-013-expected.txt:

2:09 PM Changeset in webkit [11188] by justing

3 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Updated layout test results in editing/style
Added layout test in editing/pasteboard

khtml/css/css_valueimpl.cpp: Fixed a comment.
khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Don't use clones of paragraphs already in the document to hold paragraph contents, since they are likely to introduce unwanted styles, just use a generic paragraph element. It's less likely, but still possible that a generic paragraph element will have unwanted style, so we may want to eventually use class=Apple-style-block.

11:53 AM Changeset in webkit [11187] by harrison

5 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.

editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-019.html:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:

11:53 AM Changeset in webkit [11186] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4337532> Paragraph concatenation fails

Updated editing/deleting tests to correctly check this behavior.

khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Remove erroneous check for isStartOfParagraph(visibleEnd) when deciding whether to clear m_mergeBlocksAfterDelete.

11:32 AM Changeset in webkit [11185] by thatcher