Timeline



Dec 1, 2005:

7:48 PM Changeset in webkit [11392] by mjs
  • 29 edits
    1 delete in trunk

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
4:41 PM Changeset in webkit [11391] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:38 PM Changeset in webkit [11390] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:04 PM Changeset in webkit [11389] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:57 PM Changeset in webkit [11388] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
3:55 PM Changeset in webkit [11387] by thatcher
  • 8 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
3:50 PM Changeset in webkit [11386] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:45 PM Changeset in webkit [11385] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
3:25 PM Changeset in webkit [11384] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
3:16 PM Changeset in webkit [11383] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
3:15 PM Changeset in webkit [11382] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
1:59 PM Changeset in webkit [11381] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 PM Changeset in webkit [11380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 AM Changeset in webkit [11379] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 AM Changeset in webkit [11378] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
9:59 AM Changeset in webkit [11377] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
9:58 AM Changeset in webkit [11376] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
2:32 AM Changeset in webkit [11375] by mjs
  • 76 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
12:38 AM Changeset in webkit [11374] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):

Nov 30, 2005:

3:04 PM Changeset in webkit [11373] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5890
Submitted by: eseidel
Reviewed by: darin

No additional tests needed, acid2 covers this case.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
2:46 PM Changeset in webkit [11372] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:44 PM Changeset in webkit [11371] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:40 PM Changeset in webkit [11370] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:39 PM Changeset in webkit [11369] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:25 PM Changeset in webkit [11368] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:24 PM Changeset in webkit [11367] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:15 PM Changeset in webkit [11366] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
2:14 PM Changeset in webkit [11365] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
1:53 PM Changeset in webkit [11364] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Added layout test for <rdar://problem/4344760> REGRESSION
(Safari 416.12-417.2) gmail 'reply' does not fill in to: field or
quoted message (3751)

  • fast/forms/textarea-setvalue-without-renderer-expected.txt: Added.
  • fast/forms/textarea-setvalue-without-renderer.html: Added.
3:49 AM Changeset in webkit [11363] by eseidel
  • 9 edits
    2 adds in trunk/WebCore

Bug #: 5887
Submitted by: eseidel
Reviewed by: mjs

No functionality change, no tests needed.

Make make_names.pl namespace agnostic and add XLinkNames.* for SVG

  • WebCore+SVG/XLinkNamesWrapper.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: added files, build rule.
  • khtml/khtml_part.cpp: (KHTMLPart::init): init XLinkNames
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): remove foreignObjectTag (temp.)
  • ksvg2/misc/xlinkattrs.in: Added.
  • ksvg2/scripts/make_names.pl: make namespace agnostic
  • ksvg2/svg/SVGLocatableImpl.cpp: remove foreignObjectTag (temp.) (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
  • ksvg2/svg/SVGURIReferenceImpl.cpp: use XLinkNames (SVGURIReferenceImpl::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: remove href
  • ksvg2/svg/svgtags.in: comment out unused tags
3:07 AM Changeset in webkit [11362] by eseidel
  • 1 edit
    117 deletes in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none neede, removing unused test results only.

Removing erroneously committed results content.

  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt: Removed.
1:21 AM Changeset in webkit [11361] by eseidel
  • 18 edits in trunk

Bug #: 5881
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes 5 test cases:

  • paths-data-02-t.svg (most noticeable)
  • fonts-elem-01-t.svg
  • fonts-elem-02-t.svg
  • fonts-elem-03-t.svg
  • fonts-elem-04-t.svg

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5881
Quadratic bezier path render error

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):

Nov 29, 2005:

7:12 PM Changeset in webkit [11360] by eseidel
  • 1 edit
    16 adds in trunk/LayoutTests

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • fast/dom/HTMLScriptElement/resources/script-set-src-p1fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p2fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p3pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p4pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p6pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p7pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p8pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failAfter.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failBefore.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9pass.js: Added.
  • fast/dom/HTMLScriptElement/script-set-src-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-set-src.html: Added.
7:12 PM Changeset in webkit [11359] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test: fast/dom/HTMLScriptElement/script-set-src.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): (HTMLScriptElementImpl::closeRenderer):
  • khtml/html/html_headimpl.h:
6:55 PM Changeset in webkit [11358] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820

  • fast/table/cell-width-auto-expected.checksum: Added.
  • fast/table/cell-width-auto-expected.png: Added.
  • fast/table/cell-width-auto-expected.txt: Added.
  • fast/table/cell-width-auto.html: Added.
6:51 PM Changeset in webkit [11357] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test: fast/table/cell-width-auto.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820
Table cells with width:auto should use width from their <col>

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_table.cpp: (RenderTableCell::styleOrColWidth): (RenderTableCell::calcMinMaxWidth):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (AutoTableLayout::recalcColumn): (AutoTableLayout::calcEffectiveWidth):
6:42 PM Changeset in webkit [11356] by eseidel
  • 4 edits
    4 adds in trunk/LayoutTests

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Updated results for word space fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695

  • fast/css/word-space-extra-expected.checksum:
  • fast/css/word-space-extra-expected.png:
  • fast/css/word-space-extra-expected.txt:
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.checksum: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow.html: Added.
6:40 PM Changeset in webkit [11355] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Test: fast/text/span-in-word-space-causes-overflow.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695
<span> in word-spaced text breaks width calc, causes overflow

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
6:07 PM Changeset in webkit [11354] by eseidel
  • 2 edits in trunk/WebKit

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentWithPaths:]):
6:06 PM Changeset in webkit [11353] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

No automated test possible.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • khtml/editing/markup.cpp: (khtml::createFragmentFromNodeList):
  • khtml/editing/markup.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
5:58 PM Changeset in webkit [11352] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5800
Submitted by: mitz
Reviewed by: eseidel

Test case: fast/css/absolute-poition-in-rtl-parent.html
Fix for bug: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
5:53 PM Changeset in webkit [11351] by eseidel
  • 1 edit
    6 adds in trunk/LayoutTests

Bug #: 5800
Submitted by: mitz
Reviewed by: darin

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • fast/css/absolute-poition-in-rtl-parent-expected.checksum: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.txt: Added.
  • fast/css/absolute-poition-in-rtl-parent.html: Added.
4:57 PM Changeset in webkit [11350] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

4:29 PM Changeset in webkit [11349] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5879
Submitted by: mitz
Reviewed by: eseidel

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5879
REGRESSION: Buttons go into pushed state when moused over when text field has focus

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inActiveChain to false.
4:11 PM Changeset in webkit [11348] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Fixes W3C events tests, no additional tests necessary.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5876

  • ksvg2/css/svg.css: added namespace declaration
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): added support of on* attrs
4:03 PM Changeset in webkit [11347] by eseidel
  • 6 edits
    1 delete in trunk/WebKitTools

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Update scripts to run SVG tests automatically (w/o --svg) if
WebCore is built with SVG support.

  • Scripts/build-drawtest: SVG support required
  • Scripts/build-dumpkcanvastree: Removed.
  • Scripts/run-drawtest: SVG support required to run
  • Scripts/run-webkit-tests: pass *.svg files if WebCore has support
  • Scripts/webkitdirs.pm: changed CheckWebCoreSVGSupport
2:34 PM Changeset in webkit [11346] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan, Eric Seidel

<rdar://problem/4340787> Safari sometimes creates 2 instances of plug-ins

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView of the appropriate class. Right now, this can only happen when the loading document is a standalone WebKit plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that kind of page load.

I have verified that this does not affect other kinds of page loads; in all other cases, the representation
class is distinct from the document view class.

I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
approach.

2:14 PM Changeset in webkit [11345] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

Test cases added: None. Manual testing is way to awkward, and automated testing
is not possible. See following bug...
<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::removedFromTree): Replace tab with spaces. Remove braces from one line "if".
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Send unregisterUniqueIdForUIElement unconditionally, for safety. (-[KWQAccObject dealloc]): New. Send [self detach] so KWQObject gets unregistered and other cleanup happens as well. (CreateCGColorIfDifferent): Replace tab with spaces. (-[KWQAccObject removeAccObjectID]): Early to prevent a crash if called on a detached KWQAccObject (i.e. m_renderer == 0).
11:55 AM Changeset in webkit [11344] by vicki
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

fixed a typo in the Changelog

11:49 AM Changeset in webkit [11343] by vicki
  • 2 edits
    1 add in trunk/WebCore

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
9:52 AM Changeset in webkit [11342] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQKURL.h: Added declaration of createCFURL function.
  • kwq/KWQKURL.mm: (KURL::createCFURL): Moved body of getNSURL in here. (KURL::getNSURL): Changed to createCFURL.
9:44 AM Changeset in webkit [11341] by darin
  • 2 edits in trunk/WebCore
  • fixed broken tree (from my last check-in)
  • kwq/DOM-CSS.mm: Added "using namespace DOM" and an import of "dom_docimpl.h".
9:28 AM Changeset in webkit [11340] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/DOM.mm: Removed extra implementation of -[DOMDocument getComputedStyle::].
  • kwq/DOM-CSS.mm: (-[DOMDocument getComputedStyle::]): Copied slightly better implementation from DOM.mm in here.
9:22 AM Changeset in webkit [11339] by darin
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • kwq/KWQFontFamily.h: Replace _NSFamily with _CFFamily.
  • kwq/KWQFontFamily.mm: (KWQFontFamily::KWQFontFamily): Ditto. (KWQFontFamily::operator=): Ditto. (KWQFontFamily::getNSFamily): More of the same. (KWQFontFamily::setFamily): Ditto.
9:17 AM Changeset in webkit [11338] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQDateTime.mm: (QTime::msec): Just multiply and mod the time in seconds, don't bother converting to a Gregorian date first, since that won't affect fractional seconds. (QTime::addMSecs): Multiply by 1/1000 instead of dividing by 1000.
9:14 AM Changeset in webkit [11337] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQEvent.mm: (WindowsKeyCodeForKeyEvent): Add case for tab key. (QKeyEvent::QKeyEvent): Force use of character code 9 for tab key regardless of what AppKit returns.
  • manual-tests/log-keypress-events.html: Added.
9:03 AM Changeset in webkit [11336] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/html/html_imageimpl.h: Removed unused currentImage function.
  • khtml/html/html_imageimpl.cpp: Bits of cleanup in many functins, and: (DOM::HTMLMapElementImpl::mapMouseEvent): Simplified by using traverseNextNode. (DOM::HTMLMapElementImpl::parseMappedAttribute): Fixed bug where parsing a name or attribute value with a "#" prefix would actually modify the value itself by changing the DOMString. Changed the code to make a copy in this case. (DOM::HTMLAreaElementImpl::getRegion): Rearranged to be more readable.
8:35 AM Changeset in webkit [11335] by darin
  • 2 edits in trunk/LayoutTests
8:15 AM Changeset in webkit [11334] by darin
  • 2 edits in trunk/WebCore
  • fixed deployment builds
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): Put decoder local variable inside if statement.
3:20 AM Changeset in webkit [11333] by eseidel
  • 51 edits
    12 adds in trunk

Bug #: 5842
Submitted by: eseidel
Reviewed by: mjs

3 test cases added to cover CSS updates and CDF support.
Updated all test results for absolute bbox change.

Fixed in this patch:

  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::KCanvasContainer): make "replaced" element
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): added parent offset ASSERT
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): account for parent offset (KCanvasContainerQuartz::absoluteTransform): reflect viewport
  • khtml/css/css_valueimpl.cpp: remove HTML special case (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  • khtml/css/cssstyleselector.cpp: remove HTML special case (khtml::CSSStyleSelector::locateCousinList):
  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock): special case KCanvasContainer
  • khtml/rendering/render_style.cpp: (RenderStyle::operator==): fix call into SVGRenderStyle (RenderStyle::inheritedNotEqual): calls into SVGRenderStyle (RenderStyle::diff): calls into SVGRenderStyle
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::equals): include flags in comparison (SVGRenderStyle::inheritedNotEqual): added
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::parseMappedAttribute): clear path first
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attributeChanged): map to ksvg2 attributes
  • ksvg2/svg/SVGStyledElementImpl.h:
2:36 AM Changeset in webkit [11332] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Tests for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • fast/js/date-DST-pre-1970-expected.txt: Added.
  • fast/js/date-DST-pre-1970.html: Added.
2:33 AM Changeset in webkit [11331] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Date conversion to local time gets the DST flag wrong sometimes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • kjs/date_object.cpp: (KJS::isTime_tSigned): (KJS::DateProtoFuncImp::callAsFunction):
2:11 AM Changeset in webkit [11330] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 5310
Submitted by: mitz
Reviewed by: hyatt

Not possible to test (functionality shouldn't change).

Switch QRegion from using NSBezierPath to CGPath
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5310

  • kwq/KWQRegion.h:
  • kwq/KWQRegion.mm: (QRegion::QRegion): (QRegion::~QRegion): (QRegion::operator=): (QRegion::contains): (QRegion::translate): (QRegion::boundingRect):
1:55 AM Changeset in webkit [11329] by eseidel
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

Bug #: 5316
Submitted by: darin
Reviewed by: eseidel

Re-enabling hc_noderemovechild.xhtml and fixing bug (hang).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5316

  • dom/xhtml/level1/core/hc_noderemovechild-expected.txt: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.js: hang workaround.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml-disabled: Removed.
1:07 AM Changeset in webkit [11328] by mjs
  • 4 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin. Commited by Maciej.

  • fast/dom/Document/document-charset-expected.txt: Added.
  • fast/dom/Document/document-charset.html: Added.

WebCore:

Reviewed by Darin. Commited by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):

Nov 28, 2005:

6:11 PM Changeset in webkit [11327] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: none
Submitted by: eseidel
Reviewed by: none

  • ChangeLog: added bug numbers for last two commits.
6:03 PM Changeset in webkit [11326] by eseidel
  • 9 edits in trunk/WebCore

Bug #: 5359
Submitted by: Julien Palmas <​julien.palmas@gmail.com>
Reviewed by: eseidel

Fixes 2 marker test cases.

This patch makes WebCore+SVG's marker support 90% complete
This fixes marker drawing as well as auto-orientation & scaling.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5359

  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::setRef): combined setRefX and setRefY (KCanvasMarker::setScale): combined setScaleX and setScaleY (KCanvasMarker::draw): updated post-merger
  • kcanvas/KCanvasResources.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (DrawMarkersData::DrawMarkersData): new struct (drawMarkerWithData): added, draws one marker (updateMarkerDataForElement): added, helper function during draw (DrawStartAndMidMarkers): added, CGPathApply helper function (KCanvasItemQuartz::drawMarkersIfNeeded): updated (KCanvasItemQuartz::paint): updated.
  • kcanvas/device/quartz/QuartzSupport.h: (CGPointSubtractPoints): added
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateStroke): updated to use static method (KCanvasRenderingStyle::cssPrimitiveToLength): now static
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::parseMappedAttribute): updated (SVGMarkerElementImpl::canvasResource): fixed
5:43 PM Changeset in webkit [11325] by adele
  • 2 edits in trunk/WebCore

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
5:35 PM Changeset in webkit [11324] by justing
  • 7 edits
    4 adds in trunk/LayoutTests

Fixed/added layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
Corner case where you can select outside the bounds of an editable block.

Reviewed by darin

  • editing/inserting/insert-div-023-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/3690719-expected.png:
  • editing/selection/3690719-expected.txt:
  • editing/selection/leave-requested-block-expected.checksum: Added.
  • editing/selection/leave-requested-block-expected.png: Added.
  • editing/selection/leave-requested-block-expected.txt: Added.
  • editing/selection/leave-requested-block.html: Added.
  • editing/style/block-style-004-expected.txt:
5:35 PM Changeset in webkit [11323] by justing
  • 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5354>
Corner case where you can select outside the bounds of an editable block.

Reviewed by darin

Updated/added editing test cases to reflect fix.

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): It's ok to do some hunting to find a valid VisblePosition given a position that is not somewhere visible, like inside an empty div, but only leave the block containing the position used to construct the VisiblePosition if we can't find a VisiblePosition inside that block. We weren't using the equivalentDeepPosition of the input position to make the initUpstream/initDownstream decision, so we were sometimes moving past [br, 0], which is what having initUpstream around is supposed to prevent. I got rid of initUpstream and included the check to prevent moving past [br, 0] inside the now generalized init().
  • khtml/editing/visible_units.cpp: (khtml::endOfParagraph): After the changes to VisiblePosition::init(), asking for the visible position at [br, 1] isn't the right way to include a line break.
4:17 PM Changeset in webkit [11322] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore/khtml/ecma

Build fix, missing generated files.

3:57 PM Changeset in webkit [11321] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, WebCore+SVG build fix only.

Corrected typo in last commit causing WebKit+SVG build failure.

  • kcanvas/KCanvasFilters.h: (QSizeF::QSizeF): fixed typo.
3:34 PM Changeset in webkit [11320] by eseidel
  • 12 edits
    36 adds in trunk/WebCore

Bug #: 5192
Submitted by: oliver hunt
Reviewed by: eseidel

Fixes 2 lighting test cases.

First-pass lighting filter implementation from Oliver.
Also incomplete first-pass feConvolveMatrix
Adding temporary QPointF, QSizeF for filter use.

  • WebCore.xcodeproj/project.pbxproj: added lighting classes
  • kcanvas/KCanvasFilters.cpp: (KCanvasPoint3F::normalize): added (operator<<): (KCPointLightSource::externalRepresentation): added (KCSpotLightSource::externalRepresentation): added (KCDistantLightSource::externalRepresentation): added (KCanvasFEConvolveMatrix::externalRepresentation): added (KCanvasFEDiffuseLighting::externalRepresentation): added
  • kcanvas/KCanvasFilters.h: (KCanvasPoint3F::KCanvasPoint3F): added (KCanvasPoint3F::x): added (KCanvasPoint3F::setX): added (KCanvasPoint3F::y): added (KCanvasPoint3F::setY): added (KCanvasPoint3F::z): added (KCanvasPoint3F::setZ): added (QPointF::QPointF): added (QPointF::x): added (QPointF::setX): added (QPointF::y): added (QPointF::setY): added (QSizeF::QPointF): added (QSizeF::width): added (QSizeF::setWidth): added (QSizeF::height): added (QSizeF::setHeight): added (KCanvasFEConvolveMatrix::kernelSize): added (KCanvasFEConvolveMatrix::setKernelSize): added (KCanvasFEConvolveMatrix::kernel): added (KCanvasFEConvolveMatrix::setKernel): added (KCanvasFEConvolveMatrix::divisor): added (KCanvasFEConvolveMatrix::setDivisor): added (KCanvasFEConvolveMatrix::bias): added (KCanvasFEConvolveMatrix::setBias): added (KCanvasFEConvolveMatrix::targetOffset): added (KCanvasFEConvolveMatrix::setTargetOffset): added (KCanvasFEConvolveMatrix::edgeMode): added (KCanvasFEConvolveMatrix::setEdgeMode): added (KCanvasFEConvolveMatrix::kernelUnitLength): added (KCanvasFEConvolveMatrix::setKernelUnitLength): added (KCanvasFEConvolveMatrix::preserveAlpha): added (KCanvasFEConvolveMatrix::setPreserveAlpha): added (KCLightSource::KCLightSource): added (KCLightSource::~KCLightSource): added (KCLightSource::type): added (KCDistantLightSource::KCDistantLightSource): added (KCDistantLightSource::azimuth): added (KCDistantLightSource::elevation): added (KCPointLightSource::KCPointLightSource) added: (KCPointLightSource::position): added (KCSpotLightSource::KCSpotLightSource): added (KCSpotLightSource::position): added (KCSpotLightSource::direction): added (KCSpotLightSource::specularExponent): added (KCSpotLightSource::limitingConeAngle): added (KCanvasFEDiffuseLighting::lightingColor): added (KCanvasFEDiffuseLighting::setLightingColor): added (KCanvasFEDiffuseLighting::surfaceScale): added (KCanvasFEDiffuseLighting::setSurfaceScale): added (KCanvasFEDiffuseLighting::diffuseConstant): added (KCanvasFEDiffuseLighting::setDiffuseConstant): added (KCanvasFEDiffuseLighting::kernelUnitLengthX): added (KCanvasFEDiffuseLighting::setKernelUnitLengthX): added (KCanvasFEDiffuseLighting::kernelUnitLengthY): added (KCanvasFEDiffuseLighting::setKernelUnitLengthY): added (KCanvasFEDiffuseLighting::lightSource): added (KCanvasFEDiffuseLighting::setLightSource): added (KCanvasFESpecularLighting::lightingColor): added (KCanvasFESpecularLighting::setLightingColor): added (KCanvasFESpecularLighting::surfaceScale): added (KCanvasFESpecularLighting::setSurfaceScale): added (KCanvasFESpecularLighting::specularConstant): added (KCanvasFESpecularLighting::setSpecularConstant): added (KCanvasFESpecularLighting::specularExponent): added (KCanvasFESpecularLighting::setSpecularExponent): added (KCanvasFESpecularLighting::kernelUnitLengthX): added (KCanvasFESpecularLighting::setKernelUnitLengthX): added (KCanvasFESpecularLighting::kernelUnitLengthY): added (KCanvasFESpecularLighting::setKernelUnitLengthY): added (KCanvasFESpecularLighting::lightSource): added (KCanvasFESpecularLighting::setLightSource): added
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciColor): uncommented (ciVector): added (KCanvasFECompositeQuartz::getCIFilter): spacing fix (getPointLightVectors): added (getLightVectors): added (getNormalMap): added (KCanvasFEDiffuseLightingQuartz::getCIFilter): added (KCanvasFEGaussianBlurQuartz::getCIFilter): changed CI filter (KCanvasFESpecularLightingQuartz::getCIFilter): added
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createFilterEffect): added lighting
  • kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKArithmeticFilter.h: Added.
  • kcanvas/device/quartz/filters/WKArithmeticFilter.m: Added. (+[WKArithmeticFilter initialize]): added (+[WKArithmeticFilter filterWithName:]): added (-[WKArithmeticFilter init]): added (-[WKArithmeticFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKDiffuseLightingFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDiffuseLightingFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: Added. (+[WKDiffuseLightingFilter initialize]): added (+[WKDiffuseLightingFilter filterWithName:]): added (-[WKDiffuseLightingFilter init]): added (-[WKDiffuseLightingFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDistantLightFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDistantLightFilter.m: Added. (+[WKDistantLightFilter initialize]): added (+[WKDistantLightFilter filterWithName:]): added (-[WKDistantLightFilter init]): added (-[WKDistantLightFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKNormalMapFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKNormalMapFilter.h: Added.
  • kcanvas/device/quartz/filters/WKNormalMapFilter.m: Added. (+[WKNormalMapFilter initialize]): added (+[WKNormalMapFilter filterWithName:]): added (-[WKNormalMapFilter init]): added (-[WKNormalMapFilter xConvolveArgsWithBumpMap:]): added (-[WKNormalMapFilter yConvolveArgsWithBumpMap:]): added (-[WKNormalMapFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKPointLightFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKPointLightFilter.h: Added.
  • kcanvas/device/quartz/filters/WKPointLightFilter.m: Added. (+[WKPointLightFilter initialize]): added (+[WKPointLightFilter filterWithName:]): added (-[WKPointLightFilter init]): added (-[WKPointLightFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKSpecularLightingFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKSpecularLightingFilter.h: Added.
  • kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: Added. (+[WKSpecularLightingFilter initialize]): added (+[WKSpecularLightingFilter filterWithName:]): added (-[WKSpecularLightingFilter init]): added (-[WKSpecularLightingFilter outputImage]): added
  • kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKSpotLightFilter.h: Added.
  • kcanvas/device/quartz/filters/WKSpotLightFilter.m: Added. (+[WKSpotLightFilter initialize]): added (+[WKSpotLightFilter filterWithName:]): added (-[WKSpotLightFilter init]): added (-[WKSpotLightFilter outputImage]): added
  • ksvg2/scripts/make_names.pl: now creates lighting elements
  • ksvg2/svg/SVGAnimatedColorImpl.cpp: Added. (SVGAnimatedColorImpl::SVGAnimatedColorImpl): added (SVGAnimatedColorImpl::~SVGAnimatedColorImpl): added (SVGAnimatedColorImpl::create): added (SVGAnimatedColorImpl::assign): added
  • ksvg2/svg/SVGAnimatedColorImpl.h: Added.
  • ksvg2/svg/SVGElementImpl.cpp: HTMLNames -> htmlnames
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::parseMappedAttribute): spelling fix
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: Added. (SVGFEDiffuseLightingElementImpl::SVGFEDiffuseLightingElementImpl): (SVGFEDiffuseLightingElementImpl::~SVGFEDiffuseLightingElementImpl): (SVGFEDiffuseLightingElementImpl::in1): added (SVGFEDiffuseLightingElementImpl::diffuseConstant): added (SVGFEDiffuseLightingElementImpl::surfaceScale): added (SVGFEDiffuseLightingElementImpl::kernelUnitLengthX): added (SVGFEDiffuseLightingElementImpl::kernelUnitLengthY): added (SVGFEDiffuseLightingElementImpl::lightingColor): added (SVGFEDiffuseLightingElementImpl::parseMappedAttribute): added (SVGFEDiffuseLightingElementImpl::filterEffect): added (SVGFEDiffuseLightingElementImpl::updateLights): added
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h: Added.
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added. (SVGFEDistantLightElementImpl::SVGFEDistantLightElementImpl): (SVGFEDistantLightElementImpl::~SVGFEDistantLightElementImpl): (SVGFEDistantLightElementImpl::lightSource): added
  • ksvg2/svg/SVGFEDistantLightElementImpl.h: Added.
  • ksvg2/svg/SVGFELightElementImpl.cpp: Added. (SVGFELightElementImpl::SVGFELightElementImpl): added (SVGFELightElementImpl::~SVGFELightElementImpl): added (SVGFELightElementImpl::azimuth): added (SVGFELightElementImpl::elevation): added (SVGFELightElementImpl::x): added (SVGFELightElementImpl::y): added (SVGFELightElementImpl::z): added (SVGFELightElementImpl::pointsAtX): added (SVGFELightElementImpl::pointsAtY): added (SVGFELightElementImpl::pointsAtZ): added (SVGFELightElementImpl::specularExponent): added (SVGFELightElementImpl::limitingConeAngle): added (SVGFELightElementImpl::parseMappedAttribute): added
  • ksvg2/svg/SVGFELightElementImpl.h: Added.
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp: Added. (SVGFEPointLightElementImpl::SVGFEPointLightElementImpl): added (SVGFEPointLightElementImpl::~SVGFEPointLightElementImpl): added (SVGFEPointLightElementImpl::lightSource): added
  • ksvg2/svg/SVGFEPointLightElementImpl.h: Added.
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: Added. (SVGFESpecularLightingElementImpl::SVGFESpecularLightingElementImpl): (SVGFESpecularLightingElementImpl::~SVGFESpecularLightingElementImpl): (SVGFESpecularLightingElementImpl::in1): added (SVGFESpecularLightingElementImpl::specularConstant): added (SVGFESpecularLightingElementImpl::specularExponent): added (SVGFESpecularLightingElementImpl::surfaceScale): added (SVGFESpecularLightingElementImpl::kernelUnitLengthX): added (SVGFESpecularLightingElementImpl::kernelUnitLengthY): added (SVGFESpecularLightingElementImpl::lightingColor): added (SVGFESpecularLightingElementImpl::parseMappedAttribute): added (SVGFESpecularLightingElementImpl::filterEffect): added (SVGFESpecularLightingElementImpl::updateLights): added
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h: Added.
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp: Added. (SVGFESpotLightElementImpl::SVGFESpotLightElementImpl): added (SVGFESpotLightElementImpl::~SVGFESpotLightElementImpl): added (SVGFESpotLightElementImpl::lightSource): added
  • ksvg2/svg/SVGFESpotLightElementImpl.h: Added.
  • ksvg2/svg/SVGSVGElementImpl.cpp: HTMLNames -> htmlnames
2:39 PM Changeset in webkit [11319] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin. Committed by Maciej.

  • WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController doCompletion]):
2:16 PM Changeset in webkit [11318] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Darin. Committed by Maciej.

  • DumpRenderTree/DumpRenderTree.m: (main):
2:13 PM Changeset in webkit [11317] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore/khtml/css

Checking in generated files for build fix.

2:01 PM Changeset in webkit [11316] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore/khtml

Build fix and new generated files.

12:24 PM Changeset in webkit [11315] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim Omernick.

Probable fix for <rdar://problem/4356060> crash in -[WebHistoryItem _mergeAutoCompleteHints:]

  • History.subproj/WebHistory.m: (-[WebHistoryPrivate addItem:]): retain/release oldEntry until we're done with it, since removing it from dictionary might cause it to be dealloc'ed otherwise.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _mergeAutoCompleteHints:]): added an assert
12:04 PM Changeset in webkit [11314] by justing
  • 2 edits in trunk/LayoutTests

I overlooked this layout test when fixing 4108909.

  • fast/forms/attributed-strings-expected.txt:
11:44 AM Changeset in webkit [11313] by adele
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Fix by Darin, reviewed by me.

fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)

Changed the constructors to return the emtpy string if the string is null.

  • kjs/value.cpp: (String::String):
10:50 AM Changeset in webkit [11312] by thatcher
  • 19 edits in branches/Safari-1-3-branch

WebCore:

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/html/htmlnames.h:
  • khtml/xml/EventNames.h:
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
  • khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

WebKit:

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView.subproj/WebUIDelegatePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView shouldClose]):
  • WebView.subproj/WebViewPrivate.h:
10:32 AM Changeset in webkit [11311] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: sullivan and GGAREN

Minor additions to make error messages more clear from cvs-apply.

  • Scripts/cvs-apply: make errors more clear
10:23 AM Changeset in webkit [11310] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

Nov 27, 2005:

10:21 PM Changeset in webkit [11309] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed and committed by Maciej.

  • Scripts/cvs-create-patch: produce proper paths for new files.
8:37 PM Changeset in webkit [11308] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin. Committed by Maciej.

  • fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • fast/text/international/bidi-AN-after-L.html: Added.

WebCore:

Reviewed by Darin. Committed by Maciej.

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine):
2:53 PM Changeset in webkit [11307] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 5172
Submitted by: mitz
Reviewed by: hyatt

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5172

  • fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
  • fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • fast/text/international/bidi-layout-across-linebreak.html: Added.
2:52 PM Changeset in webkit [11306] by eseidel
  • 6 edits in trunk/WebCore

Bug #: 5172
Submitted by: mitz
Reviewed by: hyatt

One test case added:
fast/text/international/bidi-layout-across-linebreak.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5172

  • khtml/rendering/bidi.cpp: (khtml::BidiState::BidiState): (khtml::operator==): (khtml::operator!=): (khtml::BidiIterator::increment): (khtml::appendRunsForObject): (khtml::appendRun): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::computeVerticalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::buildCompactRuns): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::determineStartPosition): (khtml::RenderBlock::determineEndPosition): (khtml::RenderBlock::matchedEndLine): (khtml::RenderBlock::findNextLineBreak):
  • khtml/rendering/bidi.h: (khtml::BidiStatus::BidiStatus):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_line.cpp: (khtml::RootInlineBox::childRemoved): (khtml::RootInlineBox::setLineBreakInfo):
  • khtml/rendering/render_line.h: (khtml::RootInlineBox::RootInlineBox): (khtml::RootInlineBox::lineBreakBidiStatus): (khtml::RootInlineBox::lineBreakBidiContext):
3:02 AM Changeset in webkit [11305] by eseidel
  • 42 edits in trunk/WebCore

Bug #: 5839
Submitted by: eseidel
Reviewed by: mjs

No additional test cases necessary, fixes text dumps for all tests.

Fixes included in this patch:

  • kcanvas/KCanvasItem.cpp: (RenderPath::RenderPath): remove canvas from KCanvasRenderingStyle (RenderPath::~RenderPath): use QPainter::renderingDevice() (RenderPath::fillContains): remove unnecessary code. (RenderPath::strokeContains): remove unnecessary code. (RenderPath::relativeBBox): remove unnecessary code. (RenderPath::setupForDraw): remove unnecessary code. (RenderPath::changePath): added ASSERT
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<): print absolute bbox instead of relative
(getTagName): removed KSVG
(writeRenderResources): added
  • kcanvas/KCanvasTreeDebug.h: added writeRenderResources
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): style update
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): delete filter context
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): only push context if necessary
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): only push context if necessary
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): use QPainter
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): spacing cleanup
  • khtml/rendering/render_canvas.cpp: remove renderingDevice() (RenderCanvas::RenderCanvas): remove m_renderingDevice (RenderCanvas::~RenderCanvas): remove m_renderingDevice
  • khtml/rendering/render_canvas.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::~RenderStyle): delete SVGRenderStyle
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::~SVGRenderStyle): added
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::KCanvasRenderingStyle): remove canvas arg (KCanvasRenderingStyle::updateFill): use QPainter (KCanvasRenderingStyle::updateStroke): use QPainter
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer): use QPainter
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::~SVGClipPathElementImpl): delete resource (SVGClipPathElementImpl::canvasResource): use QPainter
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::~SVGFEBlendElementImpl): delete resource (SVGFEBlendElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::~SVGFEColorMatrixElementImpl): (SVGFEColorMatrixElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::~SVGFEComponentTransferElementImpl): (SVGFEComponentTransferElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::~SVGFECompositeElementImpl): delete rsc (SVGFECompositeElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::~SVGFEFloodElementImpl): delete resource (SVGFEFloodElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::~SVGFEGaussianBlurElementImpl): (SVGFEGaussianBlurElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): delete resource (SVGFEImageElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::~SVGFEMergeElementImpl): delete resource (SVGFEMergeElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::~SVGFEOffsetElementImpl): delete resource (SVGFEOffsetElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::~SVGFETileElementImpl): delete resource (SVGFETileElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::~SVGFETurbulenceElementImpl): (SVGFETurbulenceElementImpl::filterEffect): use QPainter
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::~SVGFilterElementImpl): delete resource (SVGFilterElementImpl::canvasResource): use QPainter
  • ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer): use QPainter
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::~SVGGradientElementImpl): delete resource (SVGGradientElementImpl::canvasResource): use QPainter (SVGGradientElementImpl::rebuildStops): deref style
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): use QPainter (SVGImageElementImpl::notifyFinished): use QPainter
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::~SVGMarkerElementImpl): delete resource (SVGMarkerElementImpl::canvasResource): use QPainter (SVGMarkerElementImpl::createRenderer): use QPainter
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::~SVGPatternElementImpl): delete resource (SVGPatternElementImpl::drawPatternContentIntoTile): use QPainter (SVGPatternElementImpl::createRenderer): use QPainter (SVGPatternElementImpl::canvasResource): use QPainter
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::createRenderer): use QPainter
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer): use QPainter (SVGStyledElementImpl::updateCanvasItem): use QPainter (SVGStyledElementImpl::pushAttributeContext): use QPainter
  • ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer): use QPainter
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): use QPainter
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::renderingDevice): added
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): call writeRenderResources
Note: See TracTimeline for information about the timeline view.