Context Navigation

← Previous Period
Next Period →

Timeline

Dec 17, 2005:

9:01 PM Changeset in webkit [11648] by darin

2 edits
3 adds in trunk/WebCore

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5768 pages with frames that are all "fixed" get no layout and are blank (like www.farnell.nl)

khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
manual-tests/resources/frame1.html: Added.
manual-tests/resources/frame2.html: Added.

7:09 PM Changeset in webkit [11647] by ggaren

1 edit
2 adds in trunk/LayoutTests

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

fast/js/string-split-ignore-case-expected.txt: Added.
fast/js/string-split-ignore-case.html: Added.

7:09 PM Changeset in webkit [11646] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

Glossary:
RegExpImp: The C++ object you get when JavaScript executes

"new RegExp()".

RegExp: A C++ wrapper object that performs regular expression

matching on behalf of a RegExpImp.

Instead of unnecessarily constructing a RegExp which (wrongly) lacks
any modifiers, String.split() now uses the RegExp built in to the
RegExpImp passed to it, which has the right modifiers already.

I also cleaned up other bits of the string code to standardized how
we handle RegExpImp arguments.

ChangeLog:
kjs/string_object.cpp: (replace): (StringProtoFunc::callAsFunction):

12:12 PM Changeset in webkit [11645] by andersca

2 edits in trunk/WebCore

2005-12-17 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=6120> Random crashes when running the test suite

khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.

12:09 PM Changeset in webkit [11644] by andersca

1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-17 Anders Carlsson <andersca@mac.com>

Reviewed by Eric.

khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.

10:10 AM Changeset in webkit [11643] by darin

9 edits
4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5479 Can't select text with RTL override rendered by ATSUI

fast/text/atsui-rtl-override-selection-expected.checksum: Added.
fast/text/atsui-rtl-override-selection-expected.png: Added.
fast/text/atsui-rtl-override-selection-expected.txt: Added.
fast/text/atsui-rtl-override-selection.html: Added.

WebCore:

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5479 Can't select text with RTL override rendered by ATSUI

khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing it with a text direction parameter.
khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag in the style instead.
kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

WebKit:

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5479 Can't select text with RTL override rendered by ATSUI

WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Update since the layout only includes from -> to now. (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove reversed parameter. (CG_floatWidthForRun): Add code to handle RTL case. (addDirectionalOverride): Put the override around the entire run. (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work. Also round. (ATSU_pointToOffset): Remove reversed parameter and run swapping. (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.

Dec 16, 2005:

4:46 PM Changeset in webkit [11642]

211 copies
17 deletes in tags/WebCore-417~15

This commit was manufactured by cvs2svn to create tag
'WebCore-417~15'.

4:46 PM Changeset in webkit [11641] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.15

3:01 PM Changeset in webkit [11640] by hyatt

1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:56 PM Changeset in webkit [11639] by hyatt

1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:48 PM Changeset in webkit [11638] by hyatt

1 edit in trunk/JavaScriptCore/kjs/ustring.cpp

Add assert.h include to ustring.cpp

2:45 PM Changeset in webkit [11637] by hyatt

1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

ifdef out the getpid call on windows.

2:27 PM Changeset in webkit [11636] by hyatt

2 edits in trunk/JavaScriptCore

Remove unused RefPtr constructors that can create an ambiguity in ustring on some platforms.

Reviewed by mjs

kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr):

2:26 PM Changeset in webkit [11635] by eseidel

3 edits in trunk/WebCore

Bug #: 6106
Submitted by: eseidel
Reviewed by: darin

DOMString should hold its impl in a RefPtr
http://bugzilla.opendarwin.org/show_bug.cgi?id=6106
I also cleaned up spacing in dom_string.cpp
No tests needed (no functionality changes).

khtml/dom/dom_string.cpp: (DOM::DOMString::DOMString): (DOM::DOMString::operator += ): (DOM::DOMString::insert): (DOM::DOMString::operator []): (DOM::DOMString::find): (DOM::DOMString::length): (DOM::DOMString::truncate): (DOM::DOMString::remove): (DOM::DOMString::split): (DOM::DOMString::lower): (DOM::DOMString::upper): (DOM::DOMString::percentage): (DOM::DOMString::unicode): (DOM::DOMString::qstring): (DOM::DOMString::toInt): (DOM::DOMString::copy): (DOM::strcasecmp): (DOM::DOMString::toCoordsArray): (DOM::DOMString::toLengthArray): (DOM::operator==):
khtml/dom/dom_string.h: (DOM::DOMString::DOMString): (DOM::DOMString::impl):

2:16 PM Changeset in webkit [11634]

26 copies
3 deletes in tags/WebKit-312~8

This commit was manufactured by cvs2svn to create tag 'WebKit-312~8'.

2:16 PM Changeset in webkit [11633] by thatcher

2 edits in branches/Safari-1-3-branch/WebKit

Versioning.

1:43 PM Changeset in webkit [11632] by eseidel

3 edits in trunk/WebCore

Bug #: 6110
Submitted by: eseidel
Reviewed by: darin

No test cases needed (no functionality changes).

khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::XSLImportRuleImpl): (DOM::XSLImportRuleImpl::~XSLImportRuleImpl): (DOM::XSLImportRuleImpl::setStyleSheet):
khtml/xsl/xsl_stylesheetimpl.h: (DOM::XSLImportRuleImpl::styleSheet):

1:30 PM Changeset in webkit [11631] by adele

2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.

1:21 PM Changeset in webkit [11630] by vicki

2 edits in trunk/WebCore

Reviewed by Tim O.

fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari

khtml/ecma/kjs_window.cpp:

12:35 PM Changeset in webkit [11629] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.

12:33 PM Changeset in webkit [11628] by hyatt

1 edit in trunk/JavaScriptCore/kxmlcore/HashTraits.h

Don't include bits/cpp_type_traits on win32

12:27 PM Changeset in webkit [11627]

120 copies
5 deletes in tags/WebCore-315~13

This commit was manufactured by cvs2svn to create tag
'WebCore-315~13'.

12:27 PM Changeset in webkit [11626] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.13

11:30 AM Changeset in webkit [11625] by thatcher

4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Adele Peterson <adele@apple.com>

Reviewed by Darin and Tim Hatcher.

fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

kwq/KWQScrollView.h: Added scrollPointRecursively.
kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

10:35 AM Changeset in webkit [11624] by ggaren

2 edits in trunk/WebCore

Reviewed by Eric.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

Layout test added:

fast/js/Plug-ins-expected.checksum: Added.
fast/js/Plug-ins-expected.png: Added.
fast/js/Plug-ins-expected.txt: Added.
fast/js/Plug-ins.html: Added.

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): Changed initialization of KConfig from empty string to pluginsinfo.

10:34 AM Changeset in webkit [11623] by ggaren

1 edit
4 adds in trunk/LayoutTests

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

fast/js/Plug-ins-expected.checksum: Added.
fast/js/Plug-ins-expected.png: Added.
fast/js/Plug-ins-expected.txt: Added.
fast/js/Plug-ins.html: Added.

10:20 AM Changeset in webkit [11622] by darin

1 edit
4 adds in trunk/LayoutTests

Reviewed and landed by Darin.

Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

fast/text/international/bidi-european-terminators-expected.checksum: Added.
fast/text/international/bidi-european-terminators-expected.png: Added.
fast/text/international/bidi-european-terminators-expected.txt: Added.
fast/text/international/bidi-european-terminators.html: Added.

10:18 AM Changeset in webkit [11621] by darin

2 edits in trunk/WebCore

Reviewed and landed by Darin.

Test: fast/text/international/bidi-european-terminators.html

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Keep track of the last position before the current run of ETs directly using a new BidiState member, lastBeforeET.

8:51 AM Changeset in webkit [11620] by darin

1 edit
4 adds in trunk/LayoutTests

Added layout tests Evan Gross contributed about converting to attributed string. The results here currently seem wrong, but are what I get with TOT.

fast/text/attributed-substring-from-range-expected.txt: Added.
fast/text/attributed-substring-from-range-lines-expected.txt: Added.
fast/text/attributed-substring-from-range-lines.html: Added.
fast/text/attributed-substring-from-range.html: Added.

8:51 AM Changeset in webkit [11619] by darin

2 edits in trunk/WebKit

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4680 WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"

WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]): Implement by calling the same RTF conversion used when copying to the pasteboard.

8:40 AM Changeset in webkit [11618] by darin

20 edits in trunk

LayoutTests:

Reviewed and landed by Darin.

Updated tests that include RTL or "bidi override" runs since DumpRenderTree now
dumps those runs.

fast/block/basic/016-expected.txt:
fast/block/float/026-expected.txt:
fast/block/float/028-expected.txt:
fast/block/positioning/auto/006-expected.txt:
fast/dom/HTMLElement/bdo-expected.txt:
fast/text/international/bidi-AN-after-L-expected.txt:
fast/text/international/bidi-CS-after-AN-expected.txt:
fast/text/international/bidi-L2-run-reordering-expected.txt:
fast/text/international/bidi-LDB-2-CSS-expected.txt:
fast/text/international/bidi-LDB-2-HTML-expected.txt:
fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
fast/text/international/bidi-explicit-embedding-expected.txt:
fast/text/international/bidi-fallback-font-weight-expected.txt:
fast/text/international/bidi-innertext-expected.txt:
fast/text/international/bidi-layout-across-linebreak-expected.txt:
fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
fast/text/international/bidi-override-expected.txt:

WebCore:

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5486 DumpRenderTree should print the RTL and directional override flags for text runs

kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.

8:18 AM Changeset in webkit [11617] by darin

2 edits
1 add in trunk/WebCore

Reviewed and landed by Darin.

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6043
Incorrect selection highlighting in pre-formatted text with tabs

khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width(). (InlineTextBox::selectionRect): (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::paintMarker): (InlineTextBox::paintMarkedTextUnderline):
manual-tests/pre-tab-selection-rect.html: Added.

8:13 AM Changeset in webkit [11616] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

fast/js/replace-child-siblings-expected.txt: Added.
fast/js/replace-child-siblings.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/js/replace-child-siblings.html

Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::replaceChild): If the new child was right before or right after the old child, then it just stays.

8:11 AM Changeset in webkit [11615] by darin

2 edits in trunk/WebKit

Reviewed and landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6090 REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu

WebView.subproj/WebImageView.m: (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey for the image renderer and WebElementImageKey for the image.

12:08 AM Changeset in webkit [11614] by darin

30 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5688 speed up JavaScript parsing by not creating a UString just to parse

kjs/internal.h:
kjs/internal.cpp: (KJS::InterpreterImp::evaluate): Change to take a character pointer and length rather than a UString.

kjs/interpreter.h:
kjs/interpreter.cpp: (Interpreter::evaluate): Ditto.

kjs/protect.h: Remove uneeded "convert to bool" operator since we already have a "convert to raw pointer" operator in this class.

WebCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5688 speed up JavaScript parsing by not creating a UString just to parse

khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of listenerObjImp.
khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.
khtml/ecma/kjs_window.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::getListener): Ditto. (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.

khtml/ecma/kjs_events.cpp: (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file. (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double logging, and fixed code path to not use UString::ascii(). (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type of the window object is now Window. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto. (KJS::JSUnprotectedEventListener::windowObj): Ditto. (KJS::JSEventListener::JSEventListener): Ditto. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSEventListener::windowObj): Ditto. (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be a DOMString instead of a QString. (KJS::JSLazyEventListener::handleEvent): Removed function because the base class handleEvent already calls listenerObj which takes care of parseCode -- no need to do an additional parseCode here. (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now a DOMString instead of a QString. (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for the clipboard object. (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.

khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed destructors from many classes that don't need them. Used a RefPtr for the ClipboardImpl in a Clipboard object.

khtml/ecma/kjs_proxy.h:
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString. (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.

khtml/xml/dom_docimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code. (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute pointer. Calls through after extracting the code from the attribute value.

khtml/html/html_elementimpl.h:
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New version of function that takes an attribute pointer; calls through to the base class after extracting the code from the attribute value.

khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener and setHTMLEventListener that takes an attribute pointer. (HTMLFrameElementImpl::parseMappedAttribute): Ditto. (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.
khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.

khtml/html/html_headimpl.h:
khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take a DOMString. (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.

khtml/khtml_part.h:
khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code.

kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript machinery. Use QString::fromNSString instead for now.

12:04 AM Changeset in webkit [12224] by darin

2 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

JSRun.cpp: (JSRun::Evaluate): Updated for change to Interpreter::evaluate.

Dec 15, 2005:

11:51 PM Changeset in webkit [11613] by darin

2 edits in trunk/WebCore

fix crash caused by my last check-in

khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction): Use RefPtr to ref/deref the tokenizer.

11:28 PM Changeset in webkit [11612] by darin

2 edits in trunk/WebCore

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText): Add missing null check.

10:39 PM Changeset in webkit [11611] by ggaren

2 edits in trunk/WebCore

Fixed <rdar://problem/4381444> Remove GMail-specific work-around
previously added.

Reviewed by Darin.

No test case because this patch just turns on already-tested behavior
for GMail.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Removed code that hid the selectionEnd property from sites on the GMail domain.

10:33 PM Changeset in webkit [11610] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6092 REGRESSION: dom/xhtml/level2/htmlHTMLInputElement01.xhtml crashes

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer): Initialize the new m_currentNodeIsReferenced field to false for the document case, and true for the non-0 fragment case. Also don't reference the document in the document tokenizer case to avoid a circular reference -- HTML parser already does both of these things. (khtml::XMLTokenizer::~XMLTokenizer): Call setCurrentNode(0) to release the current node in case the tokenizer is being destroyed without finishing parsing. Only call deref on the document inthe fragment-parsing case. (khtml::XMLTokenizer::setCurrentNode): Added. Reference the current node only if it's not the document. Just as with the HTML parser, use a boolean to track whether the current node needs a deref or not. (khtml::XMLTokenizer::startElementNs): Use a RefPtr to keep the newly created element alive at least until setCurrentNode is called. Remove the bogus explicit delete of of the node after calling addChild, since reference counting takes care of it. Stop parsing if we fail to create an element. (khtml::XMLTokenizer::endElementNs): Use setCurrentNode and use a local variable to avoid reference count thrash. (khtml::XMLTokenizer::characters): Changed to only support text nodes. CDATA no longer calls this function. (khtml::XMLTokenizer::enterText): Use setCurrentNode, and remove bogus delete call. (khtml::XMLTokenizer::exitText): Add checks for stopped parser and for whether the current node is a text node so this can be called unconditionally. (khtml::XMLTokenizer::cdataBlock): Use setCurrentNode and move the call before the call to attach to make sure the node is already ref'd when attach is called. (khtml::XMLTokenizer::finish): Call setCurrentNode(0) to release the nodes we've been parsing. (khtml::XMLTokenizer::executeScripts): Fixed incorrect cast to TextImpl to cast to the base class CharacterDataImpl instead.

6:30 PM Changeset in webkit [11609] by eseidel

9 edits
1 delete in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim hatcher

Made SVG on by default!
Also removed last two KHTML_NO_CPLUSPLUS_DOM #ifs and turned off.
Removed APPLE_COMPILE_HACK, fixing or replacing with #if 0 for now.

WebCore.xcodeproj/project.pbxproj: Made SVG default!
ksvg2/KSVGSettings.cpp: Removed.
ksvg2/css/SVGCSSStyleSelector.cpp: fixed copyright.
ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished): fixed
ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): removed dead code.
ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): #if 0 (SVGImageElementImpl::notifyFinished): #if 0
ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::pixelUnitToMillimeterX): #if 0 (SVGSVGElementImpl::pixelUnitToMillimeterY): #if 0
kwq/DOM.mm: removed KHTML_NO_CPLUSPLUS_DOM (ObjCNodeFilterCondition::acceptNode):
kwq/KWQKHTMLPart.mm: removed KHTML_NO_CPLUSPLUS_DOM

6:21 PM Changeset in webkit [11608] by eseidel

2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Scripts/build-webkit: --svg is now default!

6:16 PM Changeset in webkit [11607] by eseidel

2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Don't run svg test automatically if +SVG is built (yet).

Scripts/run-webkit-tests:

4:17 PM Changeset in webkit [11606]

211 copies
17 deletes in tags/WebCore-417~14

This commit was manufactured by cvs2svn to create tag
'WebCore-417~14'.

4:17 PM Changeset in webkit [11605] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:08 PM Changeset in webkit [11604] by eseidel

5 edits in trunk/WebCore

Bug #:
Submitted by: eseidel
Reviewed by: none

Fix build break. (Files missed in previous commit.)

khtml/css/csshelper.cpp:
khtml/ecma/kjs_navigator.cpp:
khtml/rendering/render_canvasimage.cpp:
khtml/rendering/render_image.cpp:

3:40 PM Changeset in webkit [11603] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

fast/forms/option-index-expected.checksum: Added.
fast/forms/option-index-expected.png: Added.
fast/forms/option-index-expected.txt: Added.
fast/forms/option-index.html: Added.

WebCore:

Reviewed by John.

Fix for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

Test: fast/forms/option-index.html

khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::index): nil check for select element.

2:31 PM Changeset in webkit [11602] by eseidel

36 edits
60 deletes in trunk/WebCore

Bug #: 6091
Submitted by: eseidel
Reviewed by: darin

Remove more legacy code from khtml/kwq
http://bugzilla.opendarwin.org/show_bug.cgi?id=6091

No tests needed, no functionality changes.

ForwardingHeaders/kapplication.h: Removed.
ForwardingHeaders/kcompletionbox.h: Removed.
ForwardingHeaders/kdatastream.h: Removed.
ForwardingHeaders/kfiledialog.h: Removed.
ForwardingHeaders/kfileitem.h: Removed.
ForwardingHeaders/khtml_iface.h: Removed.
ForwardingHeaders/khtml_pagecache.h: Removed.
ForwardingHeaders/khtml_printsettings.h: Removed.
ForwardingHeaders/khtml_run.h: Removed.
ForwardingHeaders/kiconloader.h: Removed.
ForwardingHeaders/kio/kprotocolmanager.h: Removed.
ForwardingHeaders/kio/netaccess.h: Removed.
ForwardingHeaders/kmessagebox.h: Removed.
ForwardingHeaders/kmimetype.h: Removed.
ForwardingHeaders/kmultipledrag.h: Removed.
ForwardingHeaders/kparts/partmanager.h: Removed.
ForwardingHeaders/kprinter.h: Removed.
ForwardingHeaders/kprotocolmanager.h: Removed.
ForwardingHeaders/ksimpleconfig.h: Removed.
ForwardingHeaders/ksslcertchain.h: Removed.
ForwardingHeaders/ksslinfodlg.h: Removed.
ForwardingHeaders/kstdaction.h: Removed.
ForwardingHeaders/ktempfile.h: Removed.
ForwardingHeaders/ktrader.h: Removed.
ForwardingHeaders/kurldrag.h: Removed.
ForwardingHeaders/kxmlguifactory.h: Removed.
ForwardingHeaders/netaccess.h: Removed.
ForwardingHeaders/private/qucomextra_p.h: Removed.
ForwardingHeaders/qasyncimageio.h: Removed.
ForwardingHeaders/qbitmap.h: Removed.
ForwardingHeaders/qclipboard.h: Removed.
ForwardingHeaders/qdir.h: Removed.
ForwardingHeaders/qdrawutil.h: Removed.
ForwardingHeaders/qfontdatabase.h: Removed.
ForwardingHeaders/qfontinfo.h: Removed.
ForwardingHeaders/qglobal.h: Removed.
ForwardingHeaders/qhbox.h: Removed.
ForwardingHeaders/qinputdialog.h: Removed.
ForwardingHeaders/qintcache.h: Removed.
ForwardingHeaders/qmetaobject.h: Removed.
ForwardingHeaders/qmovie.h: Removed.
ForwardingHeaders/qobjectlist.h: Removed.
ForwardingHeaders/qtooltip.h: Removed.
ForwardingHeaders/scheduler.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/css/cssstyleselector.cpp:
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::initScript):
khtml/ecma/kjs_window.cpp:
khtml/ecma/kjs_window.moc: Removed.
khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::HTMLDocumentImpl):
khtml/html/html_documentimpl.moc: Removed.
khtml/html/html_formimpl.cpp:
khtml/html/html_formimpl.h:
khtml/html/html_objectimpl.cpp:
khtml/html/html_objectimpl.h:
khtml/html/htmltokenizer.moc: Removed.
khtml/khtml_part.cpp: (KHTMLPart::didOpenURL): (KHTMLPart::stopLoading): (KHTMLPart::createJavaContext): (KHTMLPart::begin): (KHTMLPart::slotRedirection): (KHTMLPart::setSelection): (KHTMLPart::handleFallbackContent):
khtml/khtml_part.h:
khtml/khtml_part.moc: Removed.
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLView::KHTMLView): (KHTMLView::init): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
khtml/khtmlview.h:
khtml/khtmlview.moc: Removed.
khtml/misc/loader.cpp: (CachedImage::CachedImage): (CachedImage::ref): (CachedImage::deref): (CachedImage::pixmap_size): (CachedImage::valid_rect): (CachedImage::clear): (CachedXSLStyleSheet::CachedXSLStyleSheet): (Cache::clear): (Cache::flush): (Cache::getStatistics): (Cache::setCacheDisabled):
khtml/misc/loader.h:
khtml/misc/loader.moc: Removed.
khtml/rendering/render_form.cpp: (ComboBoxWidget::ComboBoxWidget): (RenderSelect::createListBox): (RenderSlider::slotClicked):
khtml/rendering/render_form.h:
khtml/rendering/render_form.moc: Removed.
khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
khtml/rendering/render_frames.moc: Removed.
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent):
khtml/rendering/render_replaced.cpp: (RenderWidget::destroy): (RenderWidget::setSelectionState):
khtml/rendering/render_replaced.moc: Removed.
khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::cloneNode):
khtml/xml/dom_docimpl.moc: Removed.
khtml/xml/xml_tokenizer.cpp:
khtml/xml/xml_tokenizer.moc: Removed.
ksvg2/svg/SVGImageElementImpl.cpp:
kwq/KWQApplication.h: (QApplication::sendEvent):
kwq/KWQComboBox.h:
kwq/KWQKApplication.h: Removed.
kwq/KWQKHTMLPageCache.h: Removed.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
kwq/KWQKHTMLPartBrowserExtension.h:
kwq/KWQKHistoryProvider.mm:
kwq/KWQKJavaAppletContext.h: (KJavaAppletContext::KJavaAppletContext):
kwq/KWQKPartsHistoryProvider.h:
kwq/KWQKPartsPartManager.h: Removed.
kwq/KWQMovie.h: Removed.
kwq/KWQMovie.mm: Removed.
kwq/KWQObject.h:
kwq/KWQScrollView.h:
kwq/KWQScrollView.mm:
kwq/KWQWidget.h:

2:17 PM Changeset in webkit [11601] by mjs

7 edits in trunk/WebKit

Reviewed by Darin.

remove _frameForView: method from WebView and replace with a direct pointer on the WebFrameView in the WebFrame

Misc.subproj/WebNSViewExtras.m:
WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame initWithName:webFrameView:webView:]):
WebView.subproj/WebFrameView.m: (-[WebFrameView _setWebFrame:]): (-[WebFrameView webFrame]):
WebView.subproj/WebFrameViewInternal.h:
WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:

1:39 PM Changeset in webkit [11600] by eseidel

10 edits in trunk/WebCore

Bug #: 6094
Submitted by: eseidel
Reviewed by: darin

khtml/css should use RefPtr instead of manual ref() deref()
http://bugzilla.opendarwin.org/show_bug.cgi?id=6094

No functionality changes, thus no tests.

khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue):
khtml/css/css_ruleimpl.cpp: (DOM::CSSFontFaceRuleImpl::CSSFontFaceRuleImpl): (DOM::CSSFontFaceRuleImpl::~CSSFontFaceRuleImpl): (DOM::CSSImportRuleImpl::CSSImportRuleImpl): (DOM::CSSImportRuleImpl::~CSSImportRuleImpl): (DOM::CSSImportRuleImpl::setStyleSheet): (DOM::CSSMediaRuleImpl::CSSMediaRuleImpl): (DOM::CSSMediaRuleImpl::~CSSMediaRuleImpl): (DOM::CSSPageRuleImpl::CSSPageRuleImpl): (DOM::CSSPageRuleImpl::~CSSPageRuleImpl): (DOM::CSSStyleRuleImpl::CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::~CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::setDeclaration):
khtml/css/css_ruleimpl.h: (DOM::CSSFontFaceRuleImpl::style): (DOM::CSSImportRuleImpl::media): (DOM::CSSImportRuleImpl::styleSheet): (DOM::CSSMediaRuleImpl::cssRules): (DOM::CSSPageRuleImpl::style): (DOM::CSSStyleRuleImpl::style): (DOM::CSSStyleRuleImpl::declaration):
khtml/css/css_stylesheetimpl.cpp: (StyleSheetImpl::StyleSheetImpl): (StyleSheetImpl::~StyleSheetImpl): (StyleSheetImpl::setMedia):
khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::media):
khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue): (DOM::CSSMutableStyleDeclarationImpl::merge): (DOM::CSSStyleDeclarationImpl::diff): (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::CSSPrimitiveValueImpl::cleanup): (DOM::CSSPrimitiveValueImpl::cssText): (DOM::RectImpl::RectImpl): (DOM::RectImpl::~RectImpl): (DOM::RectImpl::setTop): (DOM::RectImpl::setRight): (DOM::RectImpl::setBottom): (DOM::RectImpl::setLeft): (DOM::PairImpl::PairImpl): (DOM::PairImpl::~PairImpl): (DOM::PairImpl::setFirst): (DOM::PairImpl::setSecond): (DOM::CSSBorderImageValueImpl::CSSBorderImageValueImpl): (DOM::CSSBorderImageValueImpl::~CSSBorderImageValueImpl):
khtml/css/css_valueimpl.h: (DOM::RectImpl::top): (DOM::RectImpl::right): (DOM::RectImpl::bottom): (DOM::RectImpl::left): (DOM::PairImpl::first): (DOM::PairImpl::second): (DOM::DashboardRegionImpl::setNext): (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::value):
khtml/css/cssparser.cpp: (CSSParser::parseColor):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::transformToString):

1:37 PM Changeset in webkit [11599] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.

1:36 PM Changeset in webkit [11598] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.

1:06 PM Changeset in webkit [11597] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for <rdar://problem/4381360>, http://bugzilla.opendarwin.org/show_bug.cgi?id=6100
REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)

fast/overflow/overflow-focus-ring-expected.checksum: Added.
fast/overflow/overflow-focus-ring-expected.png: Added.
fast/overflow/overflow-focus-ring-expected.txt: Added.
fast/overflow/overflow-focus-ring.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Fixed <rdar://problem/4381360> REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6100

Test: fast/overflow/overflow-focus-ring.html

khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): For overflow, we don't need to compute the rects for the children.

12:20 PM Changeset in webkit [11596] by darin

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

removed unnecessary conversion between AtomicString and QString

khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions. (HTMLScriptElementImpl::insertedIntoDocument): Ditto.

12:10 PM Changeset in webkit [12223] by darin

2 edits in trunk/JavaScriptGlue

Reviewed by Tim Hatcher.

JavaScriptGlue.xcodeproj/project.pbxproj: Removed some redundant build settings, turned off prebinding explicitly for our Development and Deployment builds, remove .exp file from sources. All "clean-up".

11:37 AM Changeset in webkit [11595] by hyatt

1 edit in trunk/WebCore/ksvg2/css/svg.css

Bug #:
Submitted by:
Reviewed by:

11:07 AM Changeset in webkit [11594]

211 copies
17 deletes in tags/WebCore-417~13

This commit was manufactured by cvs2svn to create tag
'WebCore-417~13'.

11:07 AM Changeset in webkit [11593] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

9:42 AM Changeset in webkit [11592] by darin

2 edits in trunk/WebKitTools

Scripts/run-webkit-tests: Don't run tests in directories named "svg" if SVG support is not compiled in. Report the 10 slowest tests if "--slowest" is passed on the command line.

9:14 AM Changeset in webkit [11591] by darin

2 edits in trunk/LayoutTests

updated test result -- this test now succeeds due to some recent change

dom/xhtml/level2/html/HTMLTextAreaElement12-expected.txt: Regenerated.

Dec 14, 2005:

8:51 PM Changeset in webkit [11590] by adele

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Adele Peterson <adele@apple.com>

Reviewed by Darin and Tim Hatcher.

fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

kwq/KWQScrollView.h: Added scrollPointRecursively.
kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

8:29 PM Changeset in webkit [11589] by adele

4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

kwq/KWQScrollView.h: Added scrollPointRecursively.
kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

3:32 PM Changeset in webkit [11588] by eseidel

46 edits
4 deletes in trunk/WebCore

Bug #: 6078
Submitted by: eseidel
Reviewed by: darin

SVG test cases changed (now the svg.css is loaded properly).
No other functionality changes, just code removal.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6078

ForwardingHeaders/klibloader.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/css/csshelper.cpp:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle):
khtml/css/cssstyleselector.h:
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::eventParameterName): (KJS::JSLazyEventListener::parseCode):
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::implementsCall):
khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::PluginBase):
khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
khtml/ecma/kjs_proxy.h: (KJSProxyImpl::setEventHandlerLineno):
khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
khtml/ecma/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieve): (KJS::Window::clear): (KJS::ScheduledAction::execute):
khtml/ecma/kjs_window.h:
khtml/html/html_canvasimpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData):
khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::evaluateScript):
khtml/html/html_imageimpl.cpp:
khtml/html/html_tableimpl.cpp:
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::processToken):
khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::jScript): (KHTMLPart::executeScript): (KHTMLPart::write): (KHTMLPart::reparseConfiguration): (KHTMLPart::createHTMLEventListener):
khtml/khtml_part.h:
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/misc/decoder.cpp:
khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript):
khtml/rendering/render_flow.cpp:
khtml/rendering/render_frames.cpp:
khtml/rendering/render_inline.cpp:
khtml/rendering/render_line.cpp:
khtml/rendering/render_table.cpp:
khtml/rendering/table_layout.cpp:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitOpen): (DocumentImpl::write):
khtml/xml/dom_nodeimpl.cpp:
ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid):
kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
kwq/KWQKGlobal.h:
kwq/KWQKHTMLFactory.h: (KHTMLFactory::vLinks):
kwq/KWQKHTMLFactory.mm:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::userGestureHint): (KWQKHTMLPart::bindingRootObject):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::fantasyFontName): (KHTMLSettings::isJavaScriptEnabled):
kwq/KWQKInstance.h: Removed.
kwq/KWQKLibrary.h: Removed.
kwq/KWQKPartsFactory.h: Removed.
kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::name):
kwq/KWQKStandardDirs.h:
kwq/KWQKStandardDirs.mm: (locate):
kwq/WebCoreBridge.mm: (-[WebCoreBridge executionContextForView:]):

2:49 PM Changeset in webkit [11587] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.

2:45 PM Changeset in webkit [11586] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.

2:39 PM Changeset in webkit [11585] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:21 PM Changeset in webkit [11584] by bdakin

3 edits
4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:46 AM Changeset in webkit [11583] by adele

3 edits
4 adds in trunk

LayoutTests:

Layout test for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

fast/overflow/overflow-text-hit-testing-expected.checksum: Added.
fast/overflow/overflow-text-hit-testing-expected.png: Added.
fast/overflow/overflow-text-hit-testing-expected.txt: Added.
fast/overflow/overflow-text-hit-testing.html: Added.

WebCore:

Reviewed by Darin & Geoff, committed by Adele.

Test: fast/overflow/overflow-text-hit-testing.html

Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Adjust for containing block scroll

10:19 AM Changeset in webkit [11582] by adele

2 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4362
Add mac-cyrillic to the list of encodings

kwq/mac-encodings.txt: Added maccyrillic

Dec 13, 2005:

11:48 PM Changeset in webkit [11581] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

fast/forms/checkbox-radio-onchange-expected.checksum: Added.
fast/forms/checkbox-radio-onchange-expected.png: Added.
fast/forms/checkbox-radio-onchange-expected.txt: Added.
fast/forms/checkbox-radio-onchange.html: Added.

WebCore:

Reviewed by Maciej.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

Test: fast/forms/checkbox-radio-onchange.html

khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state. This will match our old behavior, and Firefox behavior. This will also fire onChange for radio buttons which matches Firefox behavior.

10:16 PM Changeset in webkit [11580] by mjs

3 edits in trunk/WebKit

Reviewed by Darin.

remove the dead _frameForDataSource: method (WebDataSource now knows its WebFrame) http://bugzilla.opendarwin.org/show_bug.cgi?id=6072

WebView.subproj/WebView.m:
WebView.subproj/WebViewPrivate.h:

6:22 PM Changeset in webkit [11579] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

5:14 PM Changeset in webkit [11578]

5 copies in tags/Safari-521~5

This commit was manufactured by cvs2svn to create tag 'Safari-521~5'.

5:14 PM Changeset in webkit [11577] by thatcher

3 edits in trunk

Adding release markers.

5:12 PM Changeset in webkit [12222] by thatcher

1 edit in trunk/JavaScriptGlue/ChangeLog

Adding release markers.

5:00 PM Changeset in webkit [12221] by ggaren

3 edits in trunk/JavaScriptGlue

Fixed build after Anders's last checkin to JavaScriptCore.

Reviewed by darin.

UserObjectImp.cpp: (UserObjectImp::userObjectGetter): Updated to reflect new argument that getters take (unused here).
UserObjectImp.h:

4:40 PM Changeset in webkit [11576] by thatcher

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS shorthand serialization.

fast/dom/css-shortHands-expected.checksum: Added.
fast/dom/css-shortHands-expected.png: Added.
fast/dom/css-shortHands-expected.txt: Added.
fast/dom/css-shortHands.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-shortHands.html

First cut at leaving off implicit values in shorthand properties.
Need to account for multipl backgrounds and "border" later.

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue):

3:29 PM Changeset in webkit [11575] by thatcher

3 edits in branches/Safari-Leo-branch

Versioning

2:05 PM Changeset in webkit [11574] by ggaren

2 edits in trunk/JavaScriptCore

Updated test results to match Anders's last fix.

tests/mozilla/expected.html:

1:42 PM Changeset in webkit [11573] by andersca

1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-13 Anders Carlsson <andersca@mac.com>

ChangeLog: Add titles to the recent bugzilla bugs.

1:38 PM Changeset in webkit [11572] by andersca

1 edit in trunk/JavaScriptCore/ChangeLog

Correct a date.

1:37 PM Changeset in webkit [11571] by andersca

1 edit in trunk/JavaScriptCore/ChangeLog

2005-12-13 Anders Carlsson <andersca@mac.com>

ChangeLog: Add titles for my bugzilla bugs.

1:37 PM Changeset in webkit [11570] by andersca

1 edit
2 adds in trunk/LayoutTests

2005-12-13 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6041 Support property getters and setters.

fast/js/property-getters-and-setters-expected.txt: Added.
fast/js/property-getters-and-setters.html: Added.

ChangeLog: Add titles for the bugzilla urls.

1:29 PM Changeset in webkit [11569] by andersca

10 edits in trunk/WebCore

2005-12-13 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMMediaList::indexGetter): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSValueList::indexGetter):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMElement::attributeGetter): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::formNameGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::HTMLCollection::lengthGetter): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::nameGetter): (KJS::HTMLSelectCollection::selectedIndexGetter):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::indexGetter): (KJS::Plugins::nameGetter): (KJS::MimeTypes::indexGetter): (KJS::MimeTypes::nameGetter): (KJS::Plugin::indexGetter): (KJS::Plugin::nameGetter):
khtml/ecma/kjs_window.cpp: (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
khtml/ecma/kjs_window.h: Update for changes to PropertySlot::GetValueFunc.

1:26 PM Changeset in webkit [11568] by eseidel

1 edit
12 adds in trunk/LayoutTests

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

3 tests checking expected behavior for bad transform.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

svg/custom/transform-ignore-after-invalid-expected.checksum: Added.
svg/custom/transform-ignore-after-invalid-expected.png: Added.
svg/custom/transform-ignore-after-invalid-expected.txt: Added.
svg/custom/transform-ignore-after-invalid.svg: Added.
svg/custom/transform-invalid-expected.checksum: Added.
svg/custom/transform-invalid-expected.png: Added.
svg/custom/transform-invalid-expected.txt: Added.
svg/custom/transform-invalid.svg: Added.
svg/custom/transform-with-ending-space-expected.checksum: Added.
svg/custom/transform-with-ending-space-expected.png: Added.
svg/custom/transform-with-ending-space-expected.txt: Added.
svg/custom/transform-with-ending-space.svg: Added.

1:25 PM Changeset in webkit [11567] by eseidel

2 edits in trunk/WebCore

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

Fix crash on malformed transform attributes and transforms with
trailing spaces:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):

1:24 PM Changeset in webkit [11566] by andersca

27 edits in trunk/JavaScriptCore

2005-12-12 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=6041>

bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter):
bindings/runtime_array.h:
bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter):
bindings/runtime_object.h:
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::lengthGetter): (getProperty): Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.

kjs/collector.cpp: (KJS::className): Handle GetterSetterType.

kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter):
kjs/function.h: Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.

kjs/grammar.y: Rework grammar parts for get set declarations directly in the object literal.

kjs/internal.cpp: (KJS::GetterSetterImp::mark): (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean): (KJS::GetterSetterImp::toNumber): (KJS::GetterSetterImp::toString): (KJS::GetterSetterImp::toObject): Add type conversion functions. These aren't meant to be called.

(KJS::printInfo):
Handle GetterSetterType.

kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter): Update for changes to PropertySlot::GetValueFunc.

kjs/nodes.cpp: Refactor they way properties nodes are implemented. We now have a PropertyListNode which is a list of PropertyNodes. Each PropertyNode has a name (which is a PropertyNameNode) and an associated value node. PropertyNodes can be of different types. The Constant type is the old constant declaration and the Getter and Setter types are for property getters and setters. (ResolveNode::evaluate): Update for changes to PropertySlot::getValue.

(PropertyListNode::evaluate):
Go through all property nodes and set them on the newly created object. If the
property nodes are of type Getter or Setter, define getters and setters. Otherwise,
just add the properties like before.

(PropertyNode::evaluate):
This should never be called directly.

(PropertyNameNode::evaluate):
Rename from PropertyNode::evaluate.

(FunctionCallResolveNode::evaluate):
(FunctionCallBracketNode::evaluate):
(FunctionCallDotNode::evaluate):
(PostfixResolveNode::evaluate):
(PostfixBracketNode::evaluate):
(PostfixDotNode::evaluate):
(TypeOfResolveNode::evaluate):
(PrefixResolveNode::evaluate):
(PrefixBracketNode::evaluate):
(PrefixDotNode::evaluate):
(AssignResolveNode::evaluate):
(AssignDotNode::evaluate):
(AssignBracketNode::evaluate):
Update for changes to PropertySlot::getValue.

kjs/nodes.h: (KJS::PropertyNameNode::PropertyNameNode): Rename from PropertyNode.

(KJS::PropertyNode::):
(KJS::PropertyNode::PropertyNode):
New class, representing a single property.

(KJS::PropertyListNode::PropertyListNode):
Rename from PropertyValueNode.

(KJS::FuncExprNode::FuncExprNode):
Put ParameterNode parameter last, and make it optional.

(KJS::ObjectLiteralNode::ObjectLiteralNode):
Use a PropertyListNode here now.

kjs/nodes2string.cpp: (PropertyListNode::streamTo): Iterate through all property nodes.

(PropertyNode::streamTo):
Print out the name and value. Doesn't handle getters and setters currently.

(PropertyNameNode::streamTo):
Rename from PropertyNode::streamTo.

kjs/object.cpp: (KJS::JSObject::get): Update for changes to PropertySlot::getValue.

(KJS::JSObject::put):
If the property already exists and has a Setter, invoke
the setter function instead of setting the property directly.

(KJS::JSObject::defineGetter):
(KJS::JSObject::defineSetter):
New functions for defining property getters and setters on the object.

kjs/object.h: (KJS::GetterSetterImp::type): (KJS::GetterSetterImp::GetterSetterImp): (KJS::GetterSetterImp::getGetter): (KJS::GetterSetterImp::setGetter): (KJS::GetterSetterImp::getSetter): (KJS::GetterSetterImp::setSetter): New class for properties which have getters and setters defined. This class is only used internally and should never be seen from the outside.

(KJS::JSObject::getOwnPropertySlot):

If the property is a getter, call setGetterSlot on the property slot.

kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add defineGetter, defineSetter, lookupGetter, lookupSetter to prototype.

(ObjectProtoFunc::callAsFunction):
Implement handlers for new functions.

kjs/object_object.h: (KJS::ObjectProtoFunc::): Add ids for new functions.

kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): Update for changes to PropertySlot::GetValueFunc.

(KJS::PropertySlot::functionGetter):
Call the function getter object and return its value.

kjs/property_slot.h: (KJS::PropertySlot::getValue): Add a new argument which is the original object that getPropertySlot was called on.

(KJS::PropertySlot::setGetterSlot):
(KJS::PropertySlot::):
New function which sets a getter slot. When getValue is called on a
getter slot, the getter function object is invoked.

kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter):
kjs/string_object.h: Update for changes to PropertySlot::GetValueFunc.

kjs/value.h: (KJS::): Add GetterSetterType and make GetterSetterImp a friend class of JSCell.

1:12 PM Changeset in webkit [11565]

56 copies
22 deletes in tags/WebKit-417~9

This commit was manufactured by cvs2svn to create tag 'WebKit-417~9'.

1:12 PM Changeset in webkit [11564]

211 copies
17 deletes in tags/WebCore-417~12

This commit was manufactured by cvs2svn to create tag
'WebCore-417~12'.

1:12 PM Changeset in webkit [11563] by thatcher

4 edits in branches/Safari-2-0-branch

Versioning:
WebCore-417.12
WebKit-417.9

3:46 AM Changeset in webkit [11562] by mjs

2 edits in trunk/WebCore

build fix for last-minute part of previous change

khtml/ecma/kjs_binding.cpp:

3:06 AM Changeset in webkit [11561] by mjs

11 edits
2 adds
2 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

added a new HashCountedSet class for the common pattern of mapping items to counts that can change

kxmlcore/HashCountedSet.h: Added. (KXMLCore::HashCountedSet::*): Implemented, on top of HashMap.
kxmlcore/HashMap.h: (KXMLCore::HashMap::add): New method - does not replace existing value if key already present but otherwise like set(). (KXMLCore::HashMap::set): Improved comments.
kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap::add): Added to specializations too.
JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
kxmlcore/HashFunctions.h: Added include of stdint.h

replaced the custom hashtable for values protected from GC with HashCountedSet

kjs/collector.cpp: (KJS::Collector::protect): Moved code here from ProtectedValues::increaseProtectCount since the code is so simple now. (KJS::Collector::unprotect): Ditto for ProtectedValues::decreaseProtectCount. (KJS::Collector::markProtectedObjects): Updated for new way of doing things, now simpler and safer. (KJS::Collector::numReferencedObjects): ditto (KJS::Collector::rootObjectClasses): ditto
kjs/collector.h: Added protect and unprotect static methods
kjs/protect.h: (KJS::gcProtect): Updated for removal of ProtectedValues class (KJS::gcUnprotect): likewise
kjs/protected_values.cpp: Removed.
kjs/protected_values.h: Removed.

WebCore:

Reviewed by Eric.

updated for new HashCountedSet class

ForwardingHeaders/kxmlcore/HashCountedSet.h: Added forwarding header.
khtml/ecma/kjs_binding.cpp: Moved #define to disable pointer specialization higher in the file.

3:04 AM Changeset in webkit [12220] by mjs

1 edit
1 add in trunk/JavaScriptGlue

Reviewed by Eric.

added forwarding header for HashCountedSet

kxmlcore/HashCountedSet.h: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed