Timeline



Dec 20, 2005:

6:06 PM Changeset in webkit [11708] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by justin

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • editing/input/firstrectforcharacterrange-plain-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-plain.html: Added.
  • editing/input/firstrectforcharacterrange-styled-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-styled.html: Added.
6:05 PM Changeset in webkit [11707] by justing
  • 3 edits in trunk/WebCore

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

Added layout tests:

  • editing/input/firstrectforcharacterrange-styled
  • editing/input/firstrectforcharacterrange-plain
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Return null if the range isn't found, instead of a startless/endless range. Set the end if the requested location+length is out of bounds.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToDOMRange:]): Handle larged unsigned values before calling rangeWithLocationAndLength, which expects signed ints.
6:04 PM Changeset in webkit [11706] by justing
  • 2 edits in trunk/WebKit

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Handle some large unsigned values the way NSTextView does. Actually use the range passed in instead of _selectedRange, use of _selectedRange was a workaround that is no longer necessary.
5:41 PM Changeset in webkit [11705]
  • 222 copies
    18 deletes in tags/WebCore-417~16

This commit was manufactured by cvs2svn to create tag
'WebCore-417~16'.

5:41 PM Changeset in webkit [11704] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.16

5:36 PM Changeset in webkit [11703] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
5:31 PM Changeset in webkit [11702] by thatcher
  • 1 add in branches/Safari-2-0-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

5:16 PM Changeset in webkit [11701] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

This is a problem with a particular font that was installed by Microsoft Office X. Though the
font and/or lower levels of font-handling code in the system are buggy, this bad symptom will
occur for users of Safari and other WebKit clients who happen to have one of these bad fonts.
This adds a workaround to avoid the problem.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]): When we're going to synthesize bold or italic, yet the font we looked up was apparently a match for the traits, try to look up a font that without the to-be-synthesized traits. This way, instead of applying synthetic bold over Arial Bold, we'll apply synthetic bold over Arial Regular, which is uglier than just using Arial Bold, but far less ugly than using Arial Bold with synthetic bold too.

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:48 PM Changeset in webkit [11700] by thatcher
  • 1 delete in branches/Safari-2-0-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-2-0-branch on 2005-12-21 01:31:19 +0000

4:48 PM Changeset in webkit [11699]
  • 1 copy in branches/Safari-2-0-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

4:48 PM Changeset in webkit [11698] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
4:23 PM Changeset in webkit [11697] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin

Layout test for:
<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)

<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

  • editing/selection/selection-actions-expected.checksum: Added.
  • editing/selection/selection-actions-expected.png: Added.
  • editing/selection/selection-actions-expected.txt: Added.
  • editing/selection/selection-actions.html: Added.
4:23 PM Changeset in webkit [11696] by justing
  • 3 edits in trunk/WebKit

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:00 PM Changeset in webkit [11695] by justing
  • 12 edits in trunk/WebCore

Reviewed by: eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

3:05 PM Changeset in webkit [11694] by justing
  • 2 edits in trunk/WebCore

Reviewed by eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEImageQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter):
  • kwq/KWQExceptions.h:
  • kwq/KWQExceptions.mm: (KWQReportBlockedException):
  • kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:_WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::sendContextMenuEvent): (KWQKHTMLPart::fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::imageFromRect):
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQLoader.mm: (KWQCheckCacheObjectStatus):
  • kwq/KWQWidget.mm: (QWidget::frameGeometry): (QWidget::mapFromGlobal):
2:31 PM Changeset in webkit [11693] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4294417> Cannot un-italicize some text after triple clicking it

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.
1:36 PM Changeset in webkit [11692] by justing
  • 2 edits in trunk/WebKit

Reviewed by mitz

Fixed more uninitialized variable warnings, and
removed an extra semicolon.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): (createATSULayoutParameters):
1:18 PM Changeset in webkit [11691] by justing
  • 2 edits in trunk/WebCore

<rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6160> REGRESSION: Crash when running editing/deleting/delete-3800834-fix.html
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6161> REGRESSION: crash when pressing tab in editable WebHTMLView

Reviewed by darin

Some callers call setAttribute on a floating element. So, using
a RefPtr for the element inside addAttribute can destroy
it.

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::addAttribute):
12:48 PM Changeset in webkit [11690] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix bug numbers in last two entries.

12:42 PM Changeset in webkit [11689] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Added bugzilla link.

12:41 PM Changeset in webkit [11688] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.

  • push more of frame lookup and management from WebView to WebFrame, this is in preparation for shifting this to WebCore
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces (-[WebBridge runModal]): ditto
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addFrame:toNamespace:]): This now operates in terms of WebFrames (expected to be the main frame) not WebViews. (+[WebFrameNamespaces framesInNamespace:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame _setFrameNamespace:]): Set self, not WebView. (-[WebFrame _shouldAllowAccessFrom:]): Moved this code above use to avoid prototyping the method. (-[WebFrame _descendantFrameNamed:sourceFrame:]): Ditto. (-[WebFrame _frameInAnyWindowNamed:sourceFrame:]): Copied logic over from WebView. (-[WebFrame findFrameNamed:]): Do it all here, don't call WebView.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
12:40 PM Changeset in webkit [11687] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/xml/dom_elementimpl.cpp: (StyledElementImpl::createAttributeMap): the new attribute map is going in a RefPtr, don't also ref it manually.
12:27 PM Changeset in webkit [11686] by mjs
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Remove accidentally committed change (which I am about to recommit, so no ChangeLog
comment for the revert).

12:18 PM Changeset in webkit [11685] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kxmlcore/AlwaysInline.h:
12:12 PM Changeset in webkit [11684] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • fixed a leak in the assignment operator from PassRefPtr to RefPtr
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::operator=):
  • fix problem with PassRefPtr that darin spotted - it lacked a copy constructor and therefore was using the default one, which can lead to excess derefs

I fixed this by adding a copy constructor from non-const
reference, and by adding a template pass() function that you have
to use when raw pointer or RefPtr are passed where PassRefPtr is
expected.

  • kjs/identifier.cpp: (KJS::Identifier::add): Changed to have PassRefPtr return type and pass() the results.
  • kjs/identifier.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Use pass() where required.
  • kjs/ustring.cpp: (KJS::UString::UString): Use pass() as needed. (KJS::UString::append): ditto (KJS::UString::substr): ditto
  • kjs/ustring.h: (KJS::UString::UString): Use initializer instead of assignment
  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Added copy constructor (KXMLCore::pass): new template function to make it convenient to pass a PassRefPtr

WebCore:

Reviewed by Darin.

  • change an assignment to a contructor declaration to build with PassRefPtr leak fix changes
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
10:47 AM Changeset in webkit [11683] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by adele.

Fixed build failure due to missing 'b's in my last checkin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isStatusbarVisible]): changed 'B' to 'b' (-[WebBridge setStatusbarVisible:]): ditto
10:34 AM Changeset in webkit [11682] by ggaren
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):

LayoutTests:

Layout test for <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

  • fast/js/objc-big-method-name-expected.txt: Added.
  • fast/js/objc-big-method-name.html: Added.
10:29 AM Changeset in webkit [11681] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin, committed by Adele.

  • WebCoreSupport.subproj/WebTextRenderer.m: (createATSULayoutParameters): Assign initial values, which will never be used, to substituteRenderer and firstSmallCap, to avoid uninitialized variable warnings.
9:06 AM Changeset in webkit [11680] by ggaren
  • 8 edits
    3 adds in trunk

WebCore:

Reviewed by John.

Fixed <rdar://problem/4310363> JavaScript window.open: Height is 1
pixel short, and related bugs.

There were a few bugs here.
(1) Our code took size arguments and applied them to the window's

content rect. That's incorrect. The Rhino book says the arguments
should apply to the WebView. Other things that occupy the content
rect include the tab bar, the status bar, and the 1 pixel border
between brushed metal and document. All of these used to impinge
on the web page's display area.

The fix is to calculate sizing based on the WebView instead of
the content rect. This means that the webViewContentRect and
setContentRect delegate methods are obsolete and no longer called
by any of our code. (setContentRect was never called in the
first place.)

(2) None of our sizing accounted for scaled resolutions.

The fix is to ask the WebView to scale all coordintes for us.

(3) Our code assumed that all window accoutrements were on by default.

Safari works that way, but other WebKit clients might not.

The fix is always to explicitly set an on/off state.

(a) To facilitate scaling, I added a new bridge method, webView, to
access the webView.

(b) For internal consistency, I changed _Bars to _bars in bridge
methods, and _bars to _Bars in WinArgs data members. (Interestingly,
the different classes in our code are evenly divided on which format to
use.)

Added manual test:

  • manual-tests/window-open-features.html: Added.
  • manual-tests/resources/200x200.png: Added.
  • manual-tests/resources/popup200x200.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::showModalDialog): see (b) (KJS::WindowFunc::callAsFunction): see (b)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::statusbarVisible): see (b)
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): At the top of this method, I just did some formatting cleanup and moved the 'referrer' variable closer to where it's used. The changes in the middle of the method are (3), the bottom, (2).
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs): see (b)
  • kwq/WebCoreBridge.h: see (a)

WebKit:

Reviewed by John.

Part of fix for <rdar://problem/4310363> JavaScript window.open: Height
is 1 pixel short, and related bugs. See WebCore ChageLog.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge webView]): Added method.
2:08 AM Changeset in webkit [11679] by eseidel
  • 2 edits in trunk/WebKit

Submitted by: eseidel
Reviewed by: mjs

Development-only build fix.

  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): fixed typo
1:59 AM Changeset in webkit [11678] by mjs
  • 2 edits in trunk/WebKit

Not reviewed.

  • revert accidental commit of this file.
1:30 AM Changeset in webkit [11677] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 6156
Submitted by: eseidel
Reviewed by: mjs

Leaks when running SVG tests
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6156
No additional tests necessary, leaks already caught by other tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEDiffuseLighting::setLightSource): takes ownership (KCanvasFESpecularLighting::setLightSource): takes ownership
  • kcanvas/KCanvasFilters.h: (KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::~KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::lightSource): fixed spacing (KCanvasFESpecularLighting::KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::~KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::lightSource): fixed spacing
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::stringForPath): added missing CFRelease
1:16 AM Changeset in webkit [11676] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5931
Submitted by: eseidel
Reviewed by: darin

Remove additional bit-rotted DEBUG* ifdefs from WebCore.
This removes PARSER_DEBUG, FORMS_DEBUG and CSS_STYLESHEET_DEBUG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5931
No tests possible, only removing dead code.

  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::parseString): (CSSStyleSheetImpl::isLoading):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLGenericFormElementImpl::getForm):
  • khtml/html/htmlparser.cpp: (HTMLParser::processCloseTag): (HTMLParser::createHead):
12:49 AM Changeset in webkit [11675] by eseidel
  • 12 edits in trunk/WebCore

Bug #: 6107
Submitted by: eseidel
Reviewed by: darin

Move Decoder onto Shared<T> and clients onto RefPtr.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6107
No test cases possible, no functional changes.

  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished): (KJS::XMLHttpRequest::slotData):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::begin): (KHTMLPart::write):
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
  • khtml/misc/decoder.h:
  • khtml/misc/loader.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setDecoder):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::decoder):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
12:32 AM Changeset in webkit [11674] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.

  • Move handling of frame namespaces down to WebFrame.
  • Put some internal class declarations in the implementation file.
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _setFrameNamespace:]): (-[WebFrame _frameNamespace]):
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView setGroupName:]): (-[WebView groupName]):
  • WebView.subproj/WebViewInternal.h:

Dec 19, 2005:

2:16 PM Changeset in webkit [11673] by adele
  • 35 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • fast/text/atsui-multiple-renderers-expected.png: Added.
  • fast/text/atsui-multiple-renderers-expected.txt: Added.
  • fast/text/atsui-multiple-renderers.html: Added.
  • css1/text_properties/text-transCapitalize-expected.checksum:
  • css1/text_properties/text-transCapitalize-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.checksum:
  • fast/text/international/bidi-AN-after-L-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • fast/text/international/bidi-L2-run-reordering-expected.png:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • fast/text/international/bidi-LDB-2-CSS-expected.png:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • fast/text/international/bidi-LDB-2-HTML-expected.png:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-european-terminators-expected.checksum:
  • fast/text/international/bidi-european-terminators-expected.png:
  • fast/text/international/bidi-european-terminators-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • fast/text/international/bidi-fallback-font-weight-expected.png:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • fast/text/international/bidi-innertext-expected.checksum:
  • fast/text/international/bidi-innertext-expected.png:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-override-expected.checksum:
  • fast/text/international/bidi-override-expected.png:
  • fast/text/international/bidi-override-expected.txt:

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-multiple-renderers.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Fetch renderer info from the renderers array; add synthetic bold offset; render only synthetic bold in the synthetic bold pass. (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define. (initializeATSUStyle): Apply a skewing transform for synthetic oblique. (createATSUTextLayout): Merged into createATSUTextLayout. (createATSULayoutParameters): Merged in createATSUTextLayout; allocate and fill a renderers array and a character buffer for small caps and mirroring; (applyMirroringToRun): Merged into createATSULayoutParameters. (ATSU_drawHighlight): Deleted mirroring code. (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold. (ATSU_pointToOffset): Deleted mirroring code.
1:03 PM Changeset in webkit [11672] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: darin

  • Scripts/run-webkit-tests: stop /etc/catalog warnings
12:54 PM Changeset in webkit [11671] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-kerning-and-ligatures-expected.checksum: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.txt: Added.
  • fast/text/atsui-kerning-and-ligatures.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-kerning-and-ligatures.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeATSUStyle): Disable kerning; disable ligatures unless the font does not contain 'a', in which case it is assumed to never be rendered by the CG code path.
12:48 PM Changeset in webkit [11670] by darin
  • 3 edits in trunk/JavaScriptCore

Originally done by both George Staikos and Alexey Proskuryakov.

Our coding guidelines say "use 0 instead of NULL" and both RefPtr and
PassRefPtr were using NULL, which required including a header that
defines NULL.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Use 0 instead of NULL. (KXMLCore::PassRefPtr::operator!): Use ! instead of == NULL.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Use 0 instead of NULL. (KXMLCore::RefPtr::operator!): Use ! instead of == NULL. Also did some reformatting.
12:41 PM Changeset in webkit [11669] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Remove code to initialize the pointer; not needed since RefPtr gets initialized to 0. (ElementImpl::~ElementImpl): Remove code to deref the pointer; RefPtr handles that. (ElementImpl::attributes): Add get() call to get raw pointer. (ElementImpl::setAttributeMap): Remove code to deref the old map and set the new map. But added code to clear the element pointer from the old map (missing in the old version). Also added a FIXME. (ElementImpl::createAttributeMap): Remove ref(); RefPtr handles that. (NamedAttrMapImpl::addAttribute): Use a RefPtr to guarantee the element does not go away in the middle of dispatching DOM events. (StyledElementImpl::attributeChanged): Clean up code by using the inline function mappedAttributes() instead of doing type casts. (StyledElementImpl::parseMappedAttribute): Ditto. (StyledElementImpl::getClassList): Ditto.
  • khtml/xml/dom_elementimpl.h: Make ElementImpl::namedAttrMap be a RefPtr instead of raw pointer. Added an overload of StyledElementImpl::mappedAttributes for both const and non-const.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addChild): Use a RefPtr to ref/deref the child so that it doesn't leak.
  • khtml/html/htmlparser.h: Changed isindex to use a RefPtr.
  • khtml/html/htmlparser.cpp: (HTMLParser::~HTMLParser): Removed now-unneeded ref. (HTMLParser::isindexCreateErrorCheck): Remove now-unneeded deref/ref. (HTMLParser::handleIsindex): Put isindex element into a RefPtr. This prevents a crash that was otherwise happening during layout tests (caused indirectly by the changes above). (HTMLParser::startBody): Added call to get().
11:56 AM Changeset in webkit [11668] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Call poseAs to substitute our NSPasteboard class for the default one. Create a local pasteboard (really a global one with a unique name) and release it when exiting from the function so we don't leave it in the pasteboard server. (dumpRenderTree): Added an autorelease pool around one small bit of code that ddn't have one. Fixed a leak in an unlikely error case. (+[DumpRenderTreePasteboard generalPasteboard]): Override the default version of this method to return our local pasteboard.
11:53 AM Changeset in webkit [11667] by darin
  • 42 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff Garen and Eric Seidel.

  • kjs/simple_number.h: Removed many unnecessary includes, including the <cmath> one to work around GCC library header bugs. We may have to add some includes elsewhere for platforms other than OS X, since our prefix header takes care of some things.
  • kxmlcore/AlwaysInline.h: Added. Now clients that don't include simple_number.h can still get the ALWAYS_INLINE macro.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added AlwaysInline.h.
  • bindings/NP_jsobject.h: Removed a lot of unnecessary includes and removed C-specific stuff from this C++-only header.
  • bindings/jni/jni_jsobject.h: Removed a lot of unnecessary includes and did some reformatting.
  • bindings/objc/objc_runtime.h: Removed an unnecessary include.
  • bindings/runtime.h: Removed some unneeded includes. Reformatted.
  • bindings/runtime.cpp: Updated to compile with header changes, including a lot of reformatting.
  • bindings/runtime_object.h: Removed an unnecessary include.

WebCore:

Reviewed by Geoff Garen and Eric Seidel.

  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Added.
  • WebCorePrefix.h: Removed the use of <ostream>.
  • kwq/KWQDef.h: Removed now-unused Q_INT64, Q_INT16, Q_UINT16, qRound, and _KWQ_IOSTREAM_.
  • kwq/KWQKHTMLPart.h: Removed some unneeded headers and added forward-declarations of classes instead. Corrected some incorrect member function declarations.
  • kwq/KWQKHTMLPart.mm: Added a now-needed header.
  • khtml/ecma/kjs_window.cpp: Removed the <cmath> workaround.
  • khtml/rendering/bidi.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • khtml/rendering/render_canvasimage.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_image.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_text.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::calculateColor):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): Replaced use of qRound with use of lroundf or lround as appropriate.
  • kwq/KWQCString.h:
  • kwq/KWQCString.mm:
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm:
  • kwq/KWQMap.h:
  • kwq/KWQMemArray.h:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.h:
  • kwq/KWQPtrList.h:
  • kwq/KWQPtrStack.h:
  • kwq/KWQPtrVector.h:
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm:
  • kwq/KWQSize.h:
  • kwq/KWQSize.mm:
  • kwq/KWQValueList.h: Removed _KWQ_IOSTREAM_ code that was used at one time for unit tests, but is now unneeded, and requires <ostream>.
11:51 AM Changeset in webkit [12225] by darin
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Geoff Garen and Eric Seidel.

  • kxmlcore/AlwaysInline.h: Added.
11:50 AM Changeset in webkit [11666] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen and John Sullivan.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:_webcore_dictionaryWithHeaderString:]): Check length of string before calling characterAtIndex:0 since it will fail for an empty string.
11:41 AM Changeset in webkit [11665] by bdakin
  • 2 edits
    1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:37 AM Changeset in webkit [11664] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/should-use-atsui-expected.checksum: Added.
  • fast/text/should-use-atsui-expected.png: Added.
  • fast/text/should-use-atsui-expected.txt: Added.
  • fast/text/should-use-atsui.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/should-use-atsui.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Always start scanning from 0 since drawing and highlighting also measure everything up to run->from.
11:17 AM Changeset in webkit [11663] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

  • khtml/ecma/xmlhttprequest.cpp: (getMIMEType): A helper function to get MIME type from a Content-Type string. (getCharset): A helper function to get charset from a Content-Type string. (KJS::XMLHttpRequest::getValueProperty): Factored out responseIsXML(). (KJS::XMLHttpRequest::getResponseHeader): Return QString instead of JSValue (to get rid of unnecessary JSLocks). (KJS::XMLHttpRequest::responseIsXML): A new method that analyses Content-Type. (KJS::XMLHttpRequest::slotData): Use a correct charset for responses, see bug for details. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Update for getResponseHeader() changes
  • khtml/ecma/xmlhttprequest.h:
11:16 AM Changeset in webkit [11662] by thatcher
  • 1 add in trunk/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

2:38 AM Changeset in webkit [11661] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adele

  • replaced custom Identifier hashtable with HashSet
  • kjs/identifier.cpp: (KXMLCore::): (KJS::identifierTable): (KJS::Identifier::equal): (KJS::hash): (KJS::equal): (KJS::convert): (KJS::Identifier::add): (KJS::Identifier::remove):
  • kjs/identifier.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
2:32 AM Changeset in webkit [11660] by mjs
  • 4 edits
    4 deletes in trunk

WebCore:

Rubber stamped by Eric.

  • removed unused SPI headers
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/DOM-compat.h: Removed.

WebKit:

Rubber stamped by Eric.

  • remove some unused SPI headers.
  • DOM.subproj/WebDOMDocument.h: Removed.
  • DOM.subproj/WebDOMElement.h: Removed.
  • DOM.subproj/WebDOMNode.h: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Dec 18, 2005:

4:27 PM Changeset in webkit [11659] by darin
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed, tweaked, and landed by Darin.

  • kjs/array_object.h:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added implementation of indexOf.

LayoutTests:

Reviewed, tweaked, and landed by Darin.

  • fast/js/array-indexof-expected.txt: Added.
  • fast/js/array-indexof.html: Added.
3:41 PM Changeset in webkit [11658] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.
3:40 PM Changeset in webkit [11657] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast pointer to a TextImpl before calling containsOnlyWhitespace; the code already checked isTextNode.
  • khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an if statement into a few separate ones for slight additional clarity. Added a check of isTextNode and cast pointer to a TextImpl.
  • khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.
  • khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.
2:55 PM Changeset in webkit [11656] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

Test: fast/text/international/bidi-ignored-for-first-child-inline.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiNext): Adjust embedding at inline containers' boundaries instead of inside. (khtml::RenderBlock::bidiFirst): (khtml::RenderBlock::determineStartPosition):
2:37 PM Changeset in webkit [11655] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • test of a particular character set name that is not in the WebCore table but is in the ICU table (see bugzilla 5932)
  • fast/encoding/charset-cp1251-expected.txt: Added.
  • fast/encoding/charset-cp1251.html: Added.

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName): Fall back on ICU encoding names if we don't find the name in the WebCore encoding names table.
2:23 PM Changeset in webkit [11654] by darin
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • XSLT document encoding tests
  • fast/xsl/xslt-doc-enc-expected.txt: Added.
  • fast/xsl/xslt-doc-enc.xml: Added.
  • fast/xsl/xslt-doc-enc.xsl: Added.
  • fast/xsl/xslt-doc-noenc-expected.txt: Added.
  • fast/xsl/xslt-doc-noenc.xml: Added.
  • fast/xsl/xslt-doc-noenc.xsl: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform): Get encoding from transform and pass in to XSLTProcessor.
  • khtml/xsl/xslt_processorimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter. Create a Decoder and use it to decode the source document (default encoding UTF-8). (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the encoding from the libxml2 document object. (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass in to XSLTProcessor. (DOM::XSLTProcessorImpl::transformToFragment): Ditto.
2:13 PM Changeset in webkit [11653] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Fix incorrectly nested else.
5:28 AM Changeset in webkit [11652] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date

5:27 AM Changeset in webkit [11651] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4000
Object.prototype is missing isPrototypeOf

  • fast/js/test-isPrototypeOf-expected.txt: Added.
  • fast/js/test-isPrototypeOf.html: Added.
5:27 AM Changeset in webkit [11650] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add isPrototypeOf to object prototype.

(ObjectProtoFunc::callAsFunction):
Implement isPrototypeOf

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add id for isPrototypeOf.
1:20 AM Changeset in webkit [11649] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

updaated changelog to remove previous suggestion that darin was a nobody

Dec 17, 2005:

9:01 PM Changeset in webkit [11648] by darin
  • 2 edits
    3 adds in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
  • manual-tests/resources/frame1.html: Added.
  • manual-tests/resources/frame2.html: Added.
7:09 PM Changeset in webkit [11647] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

  • fast/js/string-split-ignore-case-expected.txt: Added.
  • fast/js/string-split-ignore-case.html: Added.
7:09 PM Changeset in webkit [11646] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

Glossary:
RegExpImp: The C++ object you get when JavaScript executes

"new RegExp()".

RegExp: A C++ wrapper object that performs regular expression

matching on behalf of a RegExpImp.

Instead of unnecessarily constructing a RegExp which (wrongly) lacks
any modifiers, String.split() now uses the RegExp built in to the
RegExpImp passed to it, which has the right modifiers already.

I also cleaned up other bits of the string code to standardized how
we handle RegExpImp arguments.

  • ChangeLog:
  • kjs/string_object.cpp: (replace): (StringProtoFunc::callAsFunction):
12:12 PM Changeset in webkit [11645] by andersca
  • 2 edits in trunk/WebCore

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
12:09 PM Changeset in webkit [11644] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
10:10 AM Changeset in webkit [11643] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/text/atsui-rtl-override-selection-expected.checksum: Added.
  • fast/text/atsui-rtl-override-selection-expected.png: Added.
  • fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • fast/text/atsui-rtl-override-selection.html: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing it with a text direction parameter.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
  • kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag in the style instead.
  • kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

WebKit:

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Update since the layout only includes from -> to now. (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove reversed parameter. (CG_floatWidthForRun): Add code to handle RTL case. (addDirectionalOverride): Put the override around the entire run. (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work. Also round. (ATSU_pointToOffset): Remove reversed parameter and run swapping. (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.

Dec 16, 2005:

4:46 PM Changeset in webkit [11642]
  • 211 copies
    17 deletes in tags/WebCore-417~15

This commit was manufactured by cvs2svn to create tag
'WebCore-417~15'.

4:46 PM Changeset in webkit [11641] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.15

3:01 PM Changeset in webkit [11640] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:56 PM Changeset in webkit [11639] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:48 PM Changeset in webkit [11638] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/ustring.cpp

Add assert.h include to ustring.cpp

2:45 PM Changeset in webkit [11637] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

ifdef out the getpid call on windows.

2:27 PM Changeset in webkit [11636] by hyatt
  • 2 edits in trunk/JavaScriptCore

Remove unused RefPtr constructors that can create an ambiguity in ustring on some platforms.

Reviewed by mjs

  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr):
2:26 PM Changeset in webkit [11635] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6106
Submitted by: eseidel
Reviewed by: darin

DOMString should hold its impl in a RefPtr
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6106
I also cleaned up spacing in dom_string.cpp
No tests needed (no functionality changes).

  • khtml/dom/dom_string.cpp: (DOM::DOMString::DOMString): (DOM::DOMString::operator += ): (DOM::DOMString::insert): (DOM::DOMString::operator []): (DOM::DOMString::find): (DOM::DOMString::length): (DOM::DOMString::truncate): (DOM::DOMString::remove): (DOM::DOMString::split): (DOM::DOMString::lower): (DOM::DOMString::upper): (DOM::DOMString::percentage): (DOM::DOMString::unicode): (DOM::DOMString::qstring): (DOM::DOMString::toInt): (DOM::DOMString::copy): (DOM::strcasecmp): (DOM::DOMString::toCoordsArray): (DOM::DOMString::toLengthArray): (DOM::operator==):
  • khtml/dom/dom_string.h: (DOM::DOMString::DOMString): (DOM::DOMString::impl):
2:16 PM Changeset in webkit [11634]
  • 26 copies
    3 deletes in tags/WebKit-312~8

This commit was manufactured by cvs2svn to create tag 'WebKit-312~8'.

2:16 PM Changeset in webkit [11633] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning.

1:43 PM Changeset in webkit [11632] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6110
Submitted by: eseidel
Reviewed by: darin

No test cases needed (no functionality changes).

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::XSLImportRuleImpl): (DOM::XSLImportRuleImpl::~XSLImportRuleImpl): (DOM::XSLImportRuleImpl::setStyleSheet):
  • khtml/xsl/xsl_stylesheetimpl.h: (DOM::XSLImportRuleImpl::styleSheet):
1:30 PM Changeset in webkit [11631] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
1:21 PM Changeset in webkit [11630] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim O.

  • fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari
  • khtml/ecma/kjs_window.cpp:
12:35 PM Changeset in webkit [11629] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
12:33 PM Changeset in webkit [11628] by hyatt
  • 1 edit in trunk/JavaScriptCore/kxmlcore/HashTraits.h

Don't include bits/cpp_type_traits on win32

12:27 PM Changeset in webkit [11627]
  • 120 copies
    5 deletes in tags/WebCore-315~13

This commit was manufactured by cvs2svn to create tag
'WebCore-315~13'.

12:27 PM Changeset in webkit [11626] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.13

11:30 AM Changeset in webkit [11625] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
10:35 AM Changeset in webkit [11624] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

Layout test added:

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): Changed initialization of KConfig from empty string to pluginsinfo.
10:34 AM Changeset in webkit [11623] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
10:20 AM Changeset in webkit [11622] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • fast/text/international/bidi-european-terminators-expected.png: Added.
  • fast/text/international/bidi-european-terminators-expected.txt: Added.
  • fast/text/international/bidi-european-terminators.html: Added.
10:18 AM Changeset in webkit [11621] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin.

Test: fast/text/international/bidi-european-terminators.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Keep track of the last position before the current run of ETs directly using a new BidiState member, lastBeforeET.
8:51 AM Changeset in webkit [11620] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • Added layout tests Evan Gross contributed about converting to attributed string. The results here currently seem wrong, but are what I get with TOT.
  • fast/text/attributed-substring-from-range-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range.html: Added.
8:51 AM Changeset in webkit [11619] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]): Implement by calling the same RTF conversion used when copying to the pasteboard.
8:40 AM Changeset in webkit [11618] by darin
  • 20 edits in trunk

LayoutTests:

Reviewed and landed by Darin.

Updated tests that include RTL or "bidi override" runs since DumpRenderTree now
dumps those runs.

  • fast/block/basic/016-expected.txt:
  • fast/block/float/026-expected.txt:
  • fast/block/float/028-expected.txt:
  • fast/block/positioning/auto/006-expected.txt:
  • fast/dom/HTMLElement/bdo-expected.txt:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-CS-after-AN-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-explicit-embedding-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • fast/text/international/bidi-override-expected.txt:

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.
8:18 AM Changeset in webkit [11617] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed and landed by Darin.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6043
Incorrect selection highlighting in pre-formatted text with tabs

  • khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width(). (InlineTextBox::selectionRect): (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::paintMarker): (InlineTextBox::paintMarkedTextUnderline):
  • manual-tests/pre-tab-selection-rect.html: Added.
8:13 AM Changeset in webkit [11616] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • fast/js/replace-child-siblings-expected.txt: Added.
  • fast/js/replace-child-siblings.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/js/replace-child-siblings.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::replaceChild): If the new child was right before or right after the old child, then it just stays.
8:11 AM Changeset in webkit [11615] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebImageView.m: (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey for the image renderer and WebElementImageKey for the image.
12:08 AM Changeset in webkit [11614] by darin
  • 30 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/internal.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::evaluate): Change to take a character pointer and length rather than a UString.
  • kjs/interpreter.h:
  • kjs/interpreter.cpp: (Interpreter::evaluate): Ditto.
  • kjs/protect.h: Remove uneeded "convert to bool" operator since we already have a "convert to raw pointer" operator in this class.

WebCore:

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of listenerObjImp.
  • khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getListener): Ditto. (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.
  • khtml/ecma/kjs_events.cpp: (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file. (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double logging, and fixed code path to not use UString::ascii(). (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type of the window object is now Window. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto. (KJS::JSUnprotectedEventListener::windowObj): Ditto. (KJS::JSEventListener::JSEventListener): Ditto. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSEventListener::windowObj): Ditto. (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be a DOMString instead of a QString. (KJS::JSLazyEventListener::handleEvent): Removed function because the base class handleEvent already calls listenerObj which takes care of parseCode -- no need to do an additional parseCode here. (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now a DOMString instead of a QString. (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for the clipboard object. (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.
  • khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed destructors from many classes that don't need them. Used a RefPtr for the ClipboardImpl in a Clipboard object.
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString. (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code. (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute pointer. Calls through after extracting the code from the attribute value.
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New version of function that takes an attribute pointer; calls through to the base class after extracting the code from the attribute value.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener and setHTMLEventListener that takes an attribute pointer. (HTMLFrameElementImpl::parseMappedAttribute): Ditto. (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_headimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take a DOMString. (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.
  • khtml/khtml_part.h:
  • khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code.
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript machinery. Use QString::fromNSString instead for now.
12:04 AM Changeset in webkit [12224] by darin
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • JSRun.cpp: (JSRun::Evaluate): Updated for change to Interpreter::evaluate.
Note: See TracTimeline for information about the timeline view.