Timeline



Dec 23, 2005:

5:05 PM Changeset in webkit [11754] by ggaren
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Darin, reviewed and landed by me.

  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
4:54 PM Changeset in webkit [11753] by mjs
  • 8 edits in trunk/WebKit

Reviewed by John.

  • move more frame tree traversal code from WebView to WebFrame
  • WebView.subproj/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]): Moved this debug method from WebView, renamed it and changed it to return a boolean so it is appropriate for use in assertions instead of giving its own errors. (-[WebFrame _accumulateFramesWithSelection:]): Helper for the above. (-[WebFrame _findFrameWithSelection]): Moved from WebView and renamed from _findSelectedFrame, also removed the skipping variant. (-[WebFrame _clearSelectionInOtherFrames]): Moved from WebView and changed how the logic works. Instead of clearing selection in any frame but the focus frame, it clears selection in all but this one.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Stop getting WebFrame in needlessly roundabout way. (-[WebPDFView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebTextView.m: (-[WebTextView _webFrame]): New helper method. (-[WebTextView _elementAtWindowPoint:]): Use it. (-[WebTextView becomeFirstResponder]): Call _clearSelectionInOtherFrames (-[WebTextView resignFirstResponder]): Fix style issue (-[WebTextView clickedOnLink:atIndex:]): Use new helkper
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): Call to WebFrame as appropriate (-[WebView _selectedOrMainFrame]): Fix style issue
  • WebView.subproj/WebViewInternal.h:
3:04 PM Changeset in webkit [11752] by ggaren
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by vicki (yay!), eric.

  • Fixed: <rdar://problem/4377597> parsing of window.open features strings needs to be more forgiving

Manual test case: WebCore/manual-tests/window-open-features-parsing.html
Also fixed: WebCore/manual-tests/window-open-features.html, which had an incorrect URL in it.

This patch is long. Luckily, it's also complicated.

The main thing I've done is to change our parsing of the window.open 'features' argument to match Win IE. This is important because we now implement the correct defaults for window.open, and resizing and scrolling are turned off by default. So, if we parse the 'features' string incorrectly, we'll end up with an annoying, incorrectly sized window that can't resize or scroll.

To honor a long-standing request by Eric, I factored out the parsing into two new functions: parseWindowFeatures and constrainToScreen. I also added support for "innerWidth" and "innerHeight," since they're just synonyms for "width" and "height."

  • khtml/ecma/kjs_window.cpp: removed "emit" statements, since emit is #defined as "" (KJS::parseDialogFeatures): renamed from parseFeatures, since we now have a 'parseWindowFeatures'. (KJS::showModalDialog): ditto on parseFeatures. Also added some missing initializations for WindowArgs data members. (KJS::parseWindowFeatures): new function, all new functionality. (KJS::constrainToScreen): new function, no new functionality -- just cut and pasted code that used to run as part of our parsing routine. (KJS::WindowFunc::callAsFunction): (1) Factored out previous parsing code. (2) Factored 17 lines of custom popup-blocking code into 3 lines that use pre-existing 'allowPopUp' function. Gratuitous, but it cried out to me. (3) Changed URL parsing to substitute "" for undefined *and* null values (we already did this for undefined), to avoid trying to navigate to '​http://null'. (4) Factore a multiline if () { if () {}} into an if ( && ) (4) Removed the main body of code from a giant 'else' block by inserting early returns for the exceptional cases. This caused some things to show up in the diff even though they're just whitespace changes. I didn't actually change any code past the line "if (!str.isEmpty() && activePart)"
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Added code to set toolbars to visible if toolBarVisible is true *or* locationBarVisible is true. The parser used to do this for us, but it's really the browser that's responsible for saying that the toolbar and the locationbar are the same thing. Hopefully, we can add a setLocationBarVisible delegate in the future so that other webkit clients can make their own UI decisions.
  • kwq/KWQKPartsBrowserExtension.h: Added locationBarVisible data member to WindowArgs structure and renamed toolBarsVisible to toolBarVisible (see above). Removed initialization code from WindowArgs structure because this file is for platform-specific code, and what defaults to use for window arguments is purely engine stuff.
10:44 AM Changeset in webkit [11751] by eseidel
  • 59 edits
    6 deletes in trunk/WebCore

Bug #: 6138
Submitted by: eseidel
Reviewed by: mjs

Remove many use of .qstring()
Convert several instances of QStrings to DOMStrings
Add DOMString::replace(QChar, QChar)
Remove (unused) KWQLabel, KWQKGlobal
Slight performance improvement.
Also fixed ChangeLog line endings from previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6138

No tests needed, no functionality changes.

  • ChangeLog: Fixed line endings
  • ForwardingHeaders/kglobal.h: Removed.
  • ForwardingHeaders/qlabel.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: removed KWQLabel
  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_stylesheetimpl.cpp: (MediaListImpl::setMediaText):
  • khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState):
  • khtml/dom/dom_string.h: (DOM::DOMString::replace):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::put): (KJS::DOMAttr::put): (KJS::DOMDocument::put):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLElement::put): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported):
  • khtml/editing/markup.cpp: (khtml::stringValueForRange): (khtml::startMarkup):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLInputElementImpl::appendFormData): (DOM::HTMLTextAreaElementImpl::updateValue):
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::isURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableSectionElementImpl::addChild): (DOM::HTMLTableRowElementImpl::addChild):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::checkEmitLoadEvent):
  • khtml/misc/loader.cpp: (CachedObject::finish): (CachedCSSStyleSheet::checkNotify): (CachedXSLStyleSheet::checkNotify): (CachedXBLDocument::checkNotify): (DocLoader::requestImage): (DocLoader::requestStyleSheet): (DocLoader::requestScript): (Loader::servePendingRequests): (Loader::cancelRequests):
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::~RenderBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): (RenderLineEdit::updateFromElement): (RenderTextArea::updateFromElement): (RenderTextArea::text):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListMarker::paint):
  • khtml/rendering/render_text.cpp: (khtml::RenderText::RenderText): (khtml::RenderText::position):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): (DocumentImpl::getElementByAccessKey): (DocumentImpl::recalcStyleSelector): (DocumentImpl::defaultEventHandler):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dump): (DOM::appendAttributeDesc): (DOM::NodeImpl::showNode):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::lower):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::executeScripts):
  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentViewForNode): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::addMessageToConsole): (KWQKHTMLPart::passWheelEventToChildWidget): (KWQKHTMLPart::shouldDragAutoNode): (KWQKHTMLPart::snapshotDragImage): (convertAttributesToUnderlines): (KWQKHTMLPart::setMarkedTextRange): (KWQKHTMLPart::mousePressNode):
  • kwq/KWQKGlobal.h: Removed.
  • kwq/KWQKGlobal.mm: Removed.
  • kwq/KWQLabel.h: Removed.
  • kwq/KWQLabel.mm: Removed.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setAutoSaveName): (QLineEdit::setPlaceholderString):
  • kwq/KWQPainter.mm: (QPainter::compositeOperatorFromString):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::call):
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • ksvg2/scripts/cssmakeprops: removed kglobal.h
  • ksvg2/scripts/cssmakevalues: removed kglobal.h
12:55 AM Changeset in webkit [11750] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp (KJS::XMLHttpRequest::slotFinished): Make sure to fetch response headers and set the state to Loaded, if this hasn't been done already.
12:50 AM Changeset in webkit [11749] by ap
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): Set application/xml as a default Content-Type; use a proper codec for request body if a charset is specified. (KJS::XMLHttpRequest::getRequestHeader): Use getSpecificHeader. (KJS::XMLHttpRequest::getResponseHeader): Ditto. (KJS::XMLHttpRequest::getSpecificHeader): Factored out code from getResponseHeader. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Removed a FIXME (this is done in send() now).
  • khtml/ecma/xmlhttprequest.h:
12:35 AM Changeset in webkit [11748] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

ChangeLog entry for the previous checkin

12:34 AM Changeset in webkit [11747] by mjs
  • 2 edits in trunk/JavaScriptCore
  • this time for sure
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
12:28 AM Changeset in webkit [11746] by ap
  • 6 adds in trunk/LayoutTests/fast/encoding

Reviewed by Darin Adler.

  • fast/encoding/frame-default-enc-expected.checksum: Added.
  • fast/encoding/frame-default-enc-expected.png: Added.
  • fast/encoding/frame-default-enc-expected.txt: Added.
  • fast/encoding/frame-default-enc.html: Added.
  • fast/encoding/resources/frame-default-enc-frame.html: Added.
12:19 AM Changeset in webkit [11745] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Eric.

  • move a few more methods from WebView to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _hasSelection]): Renamed from _frameIsSelected: and moved from WebView. (-[WebFrame _clearSelection]): Renamed from _deselectFrame: and moved from WebView.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Update for renames. (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): Ditto. (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]): Ditto. (-[WebView _selectedFrameDidChange]):
12:05 AM Changeset in webkit [11744] by justing
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6211>
fast/text/attributed-substring-from-range-lines needs LayoutTests/editing/editing.js

  • editing/input/attributed-substring-from-range-lines-expected.txt: Added.
  • editing/input/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-lines.html: Removed.
12:02 AM Changeset in webkit [11743] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Eric.

  • updated for WebCore changes to make XSLT params partially work
  • fast/xsl/xslt-processer-expected.txt:

Dec 22, 2005:

11:55 PM Changeset in webkit [11742] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • khtml/khtml_part.cpp (KHTMLPart::write): Do not use the parent frame encoding as a default for sub-frames (revert rdar://3100151).
11:35 PM Changeset in webkit [11741] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix build problem from last commit.
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
7:57 PM Changeset in webkit [11740] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Eric.

  • made RefPtr<DOMStringImpl> usable as a hashtable key/value
  • changed XSLTProcessorImpl to make use of this instead of a QDict.
  • partially fixed broken param handling for xslt

See LayoutTests for updated test case.

  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h: (KXMLCore::): Set things up so you can use RefPtr<DOMStringImpl> as a hashtable key (should already be usable as a value).
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): Updated to use a HashMap of RefPtrs instead of QDict. Also, fixed bugs that would have kept this from ever working at all. (DOM::XSLTProcessorImpl::transformToString): ditto (DOM::XSLTProcessorImpl::setParameter): ditto (DOM::XSLTProcessorImpl::getParameter): ditto (DOM::XSLTProcessorImpl::removeParameter): ditto
  • khtml/xsl/xslt_processorimpl.h:
5:52 PM Changeset in webkit [11739] by mjs
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The changes for support are relatively simple, but I also made extensive changes to
avoid copying, so that there isn't refcount thrash when you put RefPtrs into a HashMap.

  • kxmlcore/HashTable.h: (KXMLCore::swap): specialize swap for pairs, to swap elements individually, so that excess copies can be avoided. (KXMLCore::Mover::move): Template function to either copy or swap, used when transferring elements from old table to new. (KXMLCore::IdentityHashTranslator::hash): The old "converting lookup" templates that took two or three function parameters now take a class parameter, this is the class used to do a normal lookup. (KXMLCore::IdentityHashTranslator::equal): Ditto. (KXMLCore::IdentityHashTranslator::translate): Ditto. Translate now takes a reference to write into instead of returning a value to avoid redundant copies. (KXMLCore::HashTable::~HashTable): Use deallocateTable instead of freeing directly. (KXMLCore::HashTable::insert): Based on HashTranslator now instead of separate functions. Added a FIXME about a remaining rare excess copy. (KXMLCore::HashTable::isEmptyBucket): Use KeyTraits directly instead of unwrapping the key from Traits, to avoid creating and destroying pair, which copies. (KXMLCore::HashTable::isDeletedBucket): ditto (KXMLCore::HashTable::lookup): Use HashTranslator now instead of separate functions. (KXMLCore::HashTable::initializeBucket): Renamed from emptyBucket. Use placement new to work right for non-POD types. (KXMLCore::HashTable::deleteBucket): Use assignDeleted to avoid excess copies. (KXMLCore::HashTable::reinsert): use Mover template to copy or swap as appropriate (KXMLCore::HashTable::allocateTable): Initialize every bucket if calloc won't do. (KXMLCore::HashTable::deallocateTable): Destruct every bucket if needed. (KXMLCore::HashTable::rehash): Avoid copy before reinserting, so that swap can do its magic. (KXMLCore::HashTable::clear): use deallocateTable instead of freeing directly. (KXMLCore::HashTable::HashTable): be more dumb when copying to ensure that non-POD types work right
  • kxmlcore/HashFunctions.h: (KXMLCore::PointerHash): Specialize PointerHash for RefPtr
  • kxmlcore/HashMap.h: (KXMLCore::extractFirst): Return a reference not a full object to avoid copies. (KXMLCore::HashMapTranslator::hash): Use a special translator for insertion to defer making the pair as long as possible, thus avoiding needless copies. (KXMLCore::HashMapTranslator::equal): ditto (KXMLCore::HashMapTranslator::translate): ditto (KXMLCore::::inlineAdd): Shared by set and add to insert using HashMapTranslator (KXMLCore::::set): Use inlineAdd (KXMLCore::::add): Use inlineAdd
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::): Pass KeyTraits along
  • kxmlcore/HashSet.h: (KXMLCore::identityExtract): Return a reference not a full object to avoid copies. (KXMLCore::HashSetTranslatorAdapter::hash): Redo adapter stuff to work with the new HashTranslator approach. (KXMLCore::HashSetTranslatorAdapter::equal): ditto (KXMLCore::HashSetTranslatorAdapter::translate): ditto (KXMLCore::::insert): ditto
  • kxmlcore/HashTraits.h: (KXMLCore::GenericHashTraits): This is intended be used as a base class for customized traits: sensible defaults. (KXMLCore::): Use it a bunch (KXMLCore::assignDeleted): template function to allow pairs to be assigned the deleted value w/o excess copies. (KXMLCore::PairHashTraits::emptyValue): Updated (KXMLCore::PairHashTraits::deletedValue): Updated (KXMLCore::PairHashTraits::assignDeletedValue): part of assignDeleted hack (KXMLCore::DeletedValueAssigner::assignDeletedValue): Use template magic to either use use deletedValue or assignDeletedValue for the cases where we care.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::swap): Added swap method. (KXMLCore::swap): Added swap free function.
  • kjs/identifier.cpp: (KJS::CStringTranslator::hash): Use new HashTranslator class approach to alternate type based insertion. (KJS::CStringTranslator::equal): ditto (KJS::CStringTranslator::translate): ditto (KJS::Identifier::add): ditto (KJS::UCharBufferTranslator::hash): ditto (KJS::UCharBufferTranslator::equal): ditto (KJS::UCharBufferTranslator::translate): ditto
  • irrelevant change:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Removed a stray space.

WebCore:

Reviewed by Darin.

  • update for new HashTranslator stuff
  • khtml/xml/dom_atomicstring.cpp: (DOM::CStringTranslator::hash): (DOM::CStringTranslator::equal): (DOM::CStringTranslator::translate): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::QCharBufferTranslator::hash): (DOM::QCharBufferTranslator::equal): (DOM::QCharBufferTranslator::translate):
  • khtml/xml/dom_qname.cpp: (DOM::QNameComponentsTranslator::hash): (DOM::QNameComponentsTranslator::equal): (DOM::QNameComponentsTranslator::translate): (DOM::QualifiedName::QualifiedName):
5:13 PM Changeset in webkit [11738] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Cleaned up a previous checkin by defining global const defaultForm.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): (DocumentImpl::checkedRadioButtonForGroup): (DocumentImpl::removeRadioButtonGroup):
4:14 PM Changeset in webkit [11737] by vicki
  • 3 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Eric.

  • fix <rdar://problem/4379899> *Panther* REGRESSION (TOT): Scrollwheel doesn't work on frameset pages (5450) and <rdar://problem/4379906> *Pan EU2* 10.4.4 Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com

Basically plug in the TOT fixes for Panther. Add passWheelEventToChildWidget, but add the event as a
parameter - since there's no concept of _currentEvent on the branch, we have to pass the event around.
Return true when passing the wheel event to the child widget, since we don't want to send the event on
to the nextResponder for this case.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::passWheelEventToChildWidget):
3:06 PM Changeset in webkit [11736] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

Tests for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • fast/forms/radio_checked_dynamic-expected.checksum: Added.
  • fast/forms/radio_checked_dynamic-expected.png: Added.
  • fast/forms/radio_checked_dynamic-expected.txt: Added.
  • fast/forms/radio_checked_dynamic.html: Added.

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): update radio button hash map when moving form elements around. (DOM::HTMLGenericFormElementImpl::insertedIntoTree): ditto.
  • khtml/html/html_formimpl.h: (DOM::HTMLGenericFormElementImpl::isRadioButton): Added. (DOM::HTMLInputElementImpl::isRadioButton): Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): Added comment explaining that we use 1 for the default form. We can't use a null pointer as a key for the hash map. (DocumentImpl::checkedRadioButtonForGroup): Added conversion of null form pointer to 1. (DocumentImpl::removeRadioButtonGroup): ditto.
2:38 PM Changeset in webkit [11735] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-21 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
2:36 PM Changeset in webkit [11734] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-20 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
1:10 PM Changeset in webkit [11733] by andersca
  • 14 edits in trunk/WebCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/XSLTProcessor.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp: Update for changes to JSC.
1:08 PM Changeset in webkit [11732] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove conflict markers

1:07 PM Changeset in webkit [11731] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric and Darin.

  • kjs/lookup.h: Move ClassName from KJS_DECLARE_PROTOTYPE to KJS_IMPLEMENT_PROTOTYPE. Also, namespace all macros by prefixing them with KJS_.
11:59 AM Changeset in webkit [11730] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/rendering/render_table.cpp

Fixing a merge issue with <rdar://problem/4364640> *PanEu2* REGRESSION: Table layout issue occurs at ​http://www.pixar.com/shorts/index.html

8:53 AM Changeset in webkit [11729] by darin
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Eric.

  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::self): Don't use static deleter for two reasons: (1) We don't want any globals with constructors in any of our frameworks because they slow down framework load time. (2) There's no need to destroy this object at process termination time -- it's extra work with no benefit. Because of both these reasons, our KStaticDeleter implementation was basically a no-op.
  • ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::self): Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setDocumentChanged): Ditto.
  • khtml/html/html_canvasimpl.cpp: Removed include of kstringhandler.h.
  • khtml/html/html_imageimpl.cpp: Ditto.
  • khtml/khtmlpart_p.h: Removed something that was in an "APPLE_CANGES" ifdef.
  • ForwardingHeaders/kstaticdeleter.h: Removed.
  • ForwardingHeaders/kstringhandler.h: Removed.
  • kwq/KWQKStaticDeleter.h: Removed.
  • kwq/KWQKStringHandler.h: Removed.
  • kwq/KWQKStringHandler.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
8:50 AM Changeset in webkit [11728] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/parser/nsup-entity-expected.txt: Added.
  • fast/parser/nsup-entity.html: Added.

WebCore:

Reviewed by Eric.

  • khtml/html/kentities.gperf: Add "nsup" to table.
  • khtml/html/htmltokenizer.cpp: Removed old workaround for inlining issue that no longer seems to be necessary; also touches the file which is important because Xcode doesn't seem to understand the dependency on kentities.gperf and the need to recompile.
8:48 AM Changeset in webkit [11727] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Remove non-template constructor that takes RefPtr since the constructor template that takes RefPtr should be sufficient. Add a constructor template that takes PassRefPtr&. (KXMLCore::PassRefPtr::adopt): Use PassRefPtr_Ref to avoid setting pointer first to 0 and then to the pointer. (KXMLCore::PassRefPtr::operator=): Added template versions that take PassRefPtr& and RefPtr parameters. (KXMLCore::PassRefPtr::operator PassRefPtr<U>): Changed to fix leak -- old version would release and then ref. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Add constructor template that takes PassRefPtr. (KXMLCore::RefPtr::operator=): Add assignment operator templates that take RefPtr and PassRefPtr. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
8:46 AM Changeset in webkit [11726] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/rendering/DataRef.h: (khtml::DataRef::operator=): Eliminate an extra branch by doing ref before deref instead of == check.
  • khtml/rendering/render_style.cpp: (khtml::initDefaultStyle): Added. Function to initialize the default style for use in constructor. (khtml::RenderStyle::RenderStyle): Changed constructor to initalize all the members with constructor syntax instead of using assignment on all of them.
  • khtml/rendering/render_style.h: Removed static data member _default -- it's now a file scope global instead.

Dec 21, 2005:

11:39 PM Changeset in webkit [11725] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/cvs-create-patch: Handle newly-added directories using chdir.
10:55 PM Changeset in webkit [11724] by darin
  • 3 edits in trunk/LayoutTests
  • fast/text/attributed-substring-from-range-expected.txt: Updated.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Updated.
8:11 PM Changeset in webkit [11723] by darin
  • 14 edits in trunk/WebCore

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Call new updateLayout member function. (khtml::ApplyStyleCommand::applyInlineStyle): Ditto. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Ditto.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto. (khtml::CompositeEditCommand::findBlockPlaceholder): Ditto. (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Ditto.
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto.
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto. (khtml::EditCommand::updateLayout): Added. Calls updateLayoutIgnorePendingStylesheets on the document.
  • khtml/editing/edit_command.h: Added updateLayout member function.
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply): Call new updateLayout member function.
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Ditto.
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::execCommand): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (DOM::JSEditor::queryCommandEnabled): Ditto. (DOM::JSEditor::queryCommandIndeterm): Ditto. (DOM::JSEditor::queryCommandState): Ditto. (DOM::JSEditor::queryCommandValue): Ditto.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Ditto.
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::insertFragmentForTestRendering): Ditto. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Call new updateLayout member function. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::ReplaceSelectionCommand::doApply): Call new updateLayout member function. (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::nextLinePosition): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]): Ditto. (-[WebCoreBridge smartDeleteRangeForProposedRange:]): Ditto.
8:06 PM Changeset in webkit [11722] by darin
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/ecma/kjs_events.cpp: (KJS::DOMMouseEvent::getValueProperty): Change everything to just call through instead of doing the work here. (KJS::DOMWheelEvent::getValueProperty): Ditto.
  • khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::offsetX): (DOM::MouseRelatedEventImpl::offsetY):
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Initialize new m_pageX, m_pageY, m_layerX, m_layerY, m_offsetX, and m_offsetY. (DOM::MouseRelatedEventImpl::computePositions): Renamed from computeLayerPos since it handles page position andoffset position too now. (DOM::MouseRelatedEventImpl::pageX): Added. Not in header since it's virtual. (DOM::MouseRelatedEventImpl::pageY): Ditto. (DOM::MouseRelatedEventImpl::x): Added, with FIXME since it should change eventually. (DOM::MouseRelatedEventImpl::y): Ditto. (DOM::MouseEventImpl::initMouseEvent): Call computePositions instead of computeLayerPos. (DOM::MouseEventImpl::toElement): Added. (DOM::MouseEventImpl::fromElement): Added.
5:40 PM Changeset in webkit [11721] by thatcher
  • 6 edits in trunk

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:32 PM Changeset in webkit [12226] by thatcher
  • 2 edits in trunk/JavaScriptGlue

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebBrowser:

  • WebBrowser.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKitSystemInterface:

  • WebKitSystemInterface.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:25 PM Changeset in webkit [11720] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick and Darin Adler.

  • fixed HiDPI problem with forms auto-fill menu width

No test cases added; this code is used for "chrome" only.

  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): convert entire rect to window coordinates, not just origin
4:55 PM Changeset in webkit [11719] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Removed evil hack for determining if a type is an integer, replaced
with template metaprogramming.

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab size to 2 for testkjs.cpp
  • kjs/testkjs.cpp: (main): Inserted asserts to test IsInteger. FIXME: Move these to KXMLCore unit tests directory when we create one.
  • kxmlcore/HashTraits.h: (KXMLCore::): Added IsInteger class for querying types.
2:51 PM Changeset in webkit [11718] by harrison
  • 13 edits in trunk/WebCore

Reviewed by Justin).

<rdar://problem/4039777> Pasting particular snippet of HTML containing list items and a link creates too many list items

  • Fixed paste crash by making calling RenderBox::deleteLineBoxWrapper() from RenderObject::remove(), so that the connection is broken before the InlineBox's parent gets deleted.
  • Fixed overzealous style changes when setting the style on a specific range of elements. These specific ranges are derived programmatically, e.g. as a part of pasting, so they must be respected exactly rather than modified by converting the endpoints to VisiblePositions.

Test cases coming soon.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): (khtml::ApplyStyleCommand::updateStartEnd): (khtml::ApplyStyleCommand::startPosition): (khtml::ApplyStyleCommand::endPosition): (khtml::ApplyStyleCommand::applyBlockStyle): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical): (khtml::ApplyStyleCommand::joinChildTextNodes):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::applyStyle):
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/rendering/render_box.cpp: (RenderBox::destroy): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListMarker::~RenderListMarker): (RenderListMarker::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::remove):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy):
2:42 PM Changeset in webkit [11717]
  • 212 copies
    17 deletes in tags/WebCore-417~17

This commit was manufactured by cvs2svn to create tag
'WebCore-417~17'.

2:42 PM Changeset in webkit [11716] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:57 PM Changeset in webkit [11715] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
9:43 AM Changeset in webkit [11714] by thatcher
  • 1 add in branches/Safari-1-3-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

8:51 AM Changeset in webkit [11713] by thatcher
  • 1 delete in branches/Safari-1-3-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-1-3-branch on 2005-12-21 17:43:18 +0000

8:50 AM Changeset in webkit [11712]
  • 1 copy in branches/Safari-1-3-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-1-3-branch'.

8:50 AM Changeset in webkit [11711] by adele
  • 19 edits in trunk

LayoutTests:

Reviewed by Darin.

Updating results for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

These results all changed because we now select all for contenteditable elements when focus() is called on them.

  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:
  • fast/dom/blur-contenteditable-expected.txt:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/dom/focus-contenteditable-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:

WebCore:

Reviewed by Darin.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

I moved the scrolling code out of setFocusNode, and consolidated some of the focus code to scroll when necessary.

  • khtml/html/html_formimpl.cpp: Removed HTMLButtonElementImpl::blur, HTMLButtonElementImpl::focus, HTMLInputElementImpl::blur, HTMLInputElementImpl::focus. New code in ElementImpl::focus will now handle these cases. This allows tabbing through the elements to go through the same code path as calling focus() on an element. Before, focus() would scroll to reveal for any form elements that had a RenderWidget, but wouldn't scroll for anchor elements, or any of the new form elements. Now the behavior will be more consistent. (DOM::HTMLLabelElementImpl::focus): calls ElementImpl::focus. (DOM::HTMLLegendElementImpl::focus): ditto.
  • khtml/html/html_formimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectAll): calls new function selectContentsOfNode (KHTMLPart::selectContentsOfNode): factored out code to selectAll for a particular node- which is useful for contenteditable elements.
  • khtml/khtml_part.h: added selectContentsOfNode
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): removed scrolling code.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Calls updateLayout in case focus() is called before there's a renderer. Makes a selection for editable elements (right now we select all, but this will change). Doesn't scroll if the renderer is a RenderWidget, since that is handled when the view becomes first responder. This will go away when we convert the rest of our form elements.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::revealSelection): Made this more like centerSelectionInVisibleArea where we get the right rectangle if the selection is a caret. (KWQKHTMLPart::nextKeyViewInFrame): call ElementImpl::focus() for the node. This will set the selection too, which used to be done here.
2:53 AM Changeset in webkit [11710] by eseidel
  • 1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

Fixed ChangeLog typo.

2:44 AM Changeset in webkit [11709] by eseidel
  • 3 edits
    2 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Beef up our XSLT processor tests to include a test which passes
a parameter into the transform. I also took this opportunity
to clean up the output a bit, and in the process found another
bug and file: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6180

  • fast/xsl/resources/xslt-param.xml: Added.
  • fast/xsl/resources/xslt-param.xsl: Added.
  • fast/xsl/xslt-processer-expected.txt:
  • fast/xsl/xslt-processer.html:

Dec 20, 2005:

6:06 PM Changeset in webkit [11708] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by justin

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • editing/input/firstrectforcharacterrange-plain-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-plain.html: Added.
  • editing/input/firstrectforcharacterrange-styled-expected.txt: Added.
  • editing/input/firstrectforcharacterrange-styled.html: Added.
6:05 PM Changeset in webkit [11707] by justing
  • 3 edits in trunk/WebCore

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

Added layout tests:

  • editing/input/firstrectforcharacterrange-styled
  • editing/input/firstrectforcharacterrange-plain
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Return null if the range isn't found, instead of a startless/endless range. Set the end if the requested location+length is out of bounds.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToDOMRange:]): Handle larged unsigned values before calling rangeWithLocationAndLength, which expects signed ints.
6:04 PM Changeset in webkit [11706] by justing
  • 2 edits in trunk/WebKit

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4682>
-[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Handle some large unsigned values the way NSTextView does. Actually use the range passed in instead of _selectedRange, use of _selectedRange was a workaround that is no longer necessary.
5:41 PM Changeset in webkit [11705]
  • 222 copies
    18 deletes in tags/WebCore-417~16

This commit was manufactured by cvs2svn to create tag
'WebCore-417~16'.

5:41 PM Changeset in webkit [11704] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.16

5:36 PM Changeset in webkit [11703] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
5:31 PM Changeset in webkit [11702] by thatcher
  • 1 add in branches/Safari-2-0-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

5:16 PM Changeset in webkit [11701] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

This is a problem with a particular font that was installed by Microsoft Office X. Though the
font and/or lower levels of font-handling code in the system are buggy, this bad symptom will
occur for users of Safari and other WebKit clients who happen to have one of these bad fonts.
This adds a workaround to avoid the problem.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]): When we're going to synthesize bold or italic, yet the font we looked up was apparently a match for the traits, try to look up a font that without the to-be-synthesized traits. This way, instead of applying synthetic bold over Arial Bold, we'll apply synthetic bold over Arial Regular, which is uglier than just using Arial Bold, but far less ugly than using Arial Bold with synthetic bold too.

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:48 PM Changeset in webkit [11700] by thatcher
  • 1 delete in branches/Safari-2-0-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-2-0-branch on 2005-12-21 01:31:19 +0000

4:48 PM Changeset in webkit [11699]
  • 1 copy in branches/Safari-2-0-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

4:48 PM Changeset in webkit [11698] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
4:23 PM Changeset in webkit [11697] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin

Layout test for:
<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)

<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

  • editing/selection/selection-actions-expected.checksum: Added.
  • editing/selection/selection-actions-expected.png: Added.
  • editing/selection/selection-actions-expected.txt: Added.
  • editing/selection/selection-actions.html: Added.
4:23 PM Changeset in webkit [11696] by justing
  • 3 edits in trunk/WebKit

2005-12-16 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
<rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const 436

Reviewed by darin

WebCore will crash when a selection that starts or ends in a node
that has been removed from the document is modify()d. This can occur:
(1) in non-editable regions (4103393 and 4330451), (2) in editable
regions (4383146) as the result of arbitrary DOM operations, and (3) in
Mail (4099739) as the result of an editing operation that sets a
bad ending selection.

Crashes of type (1) can occur when the user uses the arrow keys
to interact with a web app, or when the user tries to use
command-shift-arrow to switch tabs (this is a depricated
combo that will work if no one else responds to it). The easiest
way to fix these crashes is to disallow editing'ish selection changes
like moveDown:, selectWord:, pageDown:, etc, when the selection
is in a non-editable region.

Crashes of type (2) will require a more complicated fix (but occur
much less often than type (1)). Crashes of type (3) must be
fixed by tracking down the editing operation that sets bad selections.

Added a layout-test:

  • editing/selection/selection-actions.html
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canAlterCurrentSelection]): (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): (-[WebHTMLView _alterCurrentSelection:verticalDistance:]): (-[WebHTMLView _expandSelectionToGranularity:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
4:00 PM Changeset in webkit [11695] by justing
  • 12 edits in trunk/WebCore

Reviewed by: eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

3:05 PM Changeset in webkit [11694] by justing
  • 2 edits in trunk/WebCore

Reviewed by eric, thatcher

<rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

Needed to undef try/catch because of 4333439. Moved the
declarations of variables that are returned from within a @try
block outside the @try block (because of "might be clobbered by
a longjmp or vfork" warnings). Moved some return statements
inside the @try block to fix volatilization errors with gcc4.

  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEImageQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter):
  • kwq/KWQExceptions.h:
  • kwq/KWQExceptions.mm: (KWQReportBlockedException):
  • kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry):
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_cursorWithName:hotSpot:_WebCore_cursorWithName:hotSpot:]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart): (KWQKHTMLPart::nextKeyView): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::keyEvent): (KWQKHTMLPart::sendContextMenuEvent): (KWQKHTMLPart::fileWrapperForElement): (KWQKHTMLPart::attributedString): (KWQKHTMLPart::imageFromRect):
  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQLoader.mm: (KWQCheckCacheObjectStatus):
  • kwq/KWQWidget.mm: (QWidget::frameGeometry): (QWidget::mapFromGlobal):
2:31 PM Changeset in webkit [11693] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4294417> Cannot un-italicize some text after triple clicking it

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.
1:36 PM Changeset in webkit [11692] by justing
  • 2 edits in trunk/WebKit

Reviewed by mitz

Fixed more uninitialized variable warnings, and
removed an extra semicolon.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): (createATSULayoutParameters):
1:18 PM Changeset in webkit [11691] by justing
  • 2 edits in trunk/WebCore

<rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6160> REGRESSION: Crash when running editing/deleting/delete-3800834-fix.html
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6161> REGRESSION: crash when pressing tab in editable WebHTMLView

Reviewed by darin

Some callers call setAttribute on a floating element. So, using
a RefPtr for the element inside addAttribute can destroy
it.

  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::addAttribute):
12:48 PM Changeset in webkit [11690] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix bug numbers in last two entries.

12:42 PM Changeset in webkit [11689] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Added bugzilla link.

12:41 PM Changeset in webkit [11688] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.

  • push more of frame lookup and management from WebView to WebFrame, this is in preparation for shifting this to WebCore
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces (-[WebBridge runModal]): ditto
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addFrame:toNamespace:]): This now operates in terms of WebFrames (expected to be the main frame) not WebViews. (+[WebFrameNamespaces framesInNamespace:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame _setFrameNamespace:]): Set self, not WebView. (-[WebFrame _shouldAllowAccessFrom:]): Moved this code above use to avoid prototyping the method. (-[WebFrame _descendantFrameNamed:sourceFrame:]): Ditto. (-[WebFrame _frameInAnyWindowNamed:sourceFrame:]): Copied logic over from WebView. (-[WebFrame findFrameNamed:]): Do it all here, don't call WebView.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
12:40 PM Changeset in webkit [11687] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/xml/dom_elementimpl.cpp: (StyledElementImpl::createAttributeMap): the new attribute map is going in a RefPtr, don't also ref it manually.
12:27 PM Changeset in webkit [11686] by mjs
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Remove accidentally committed change (which I am about to recommit, so no ChangeLog
comment for the revert).

12:18 PM Changeset in webkit [11685] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • kxmlcore/AlwaysInline.h:
12:12 PM Changeset in webkit [11684] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • fixed a leak in the assignment operator from PassRefPtr to RefPtr
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::operator=):
  • fix problem with PassRefPtr that darin spotted - it lacked a copy constructor and therefore was using the default one, which can lead to excess derefs

I fixed this by adding a copy constructor from non-const
reference, and by adding a template pass() function that you have
to use when raw pointer or RefPtr are passed where PassRefPtr is
expected.

  • kjs/identifier.cpp: (KJS::Identifier::add): Changed to have PassRefPtr return type and pass() the results.
  • kjs/identifier.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Use pass() where required.
  • kjs/ustring.cpp: (KJS::UString::UString): Use pass() as needed. (KJS::UString::append): ditto (KJS::UString::substr): ditto
  • kjs/ustring.h: (KJS::UString::UString): Use initializer instead of assignment
  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Added copy constructor (KXMLCore::pass): new template function to make it convenient to pass a PassRefPtr

WebCore:

Reviewed by Darin.

  • change an assignment to a contructor declaration to build with PassRefPtr leak fix changes
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
10:47 AM Changeset in webkit [11683] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by adele.

Fixed build failure due to missing 'b's in my last checkin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge isStatusbarVisible]): changed 'B' to 'b' (-[WebBridge setStatusbarVisible:]): ditto
10:34 AM Changeset in webkit [11682] by ggaren
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

Fixed <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

JSMethodNameToObjcMethodName had a check for a name being too long, but
the check was missing a return statement.

A lot of this code was confusing and some of it was wrong, so I fixed
it up, added some asserts to catch this type of bug in the future,
changed some comments, and renamed some variables.

The two advantages of the new algorithm are (1) It makes writing past
the end of the buffer virtually impossible because the test on the main
loop is "while (not past end of buffer)" and (2) It's twice as fast
because it doesn't call strlen. (There's no need to call strlen when
we're walking the string ourselves.)

methodsNamed also supports arbitrary-length method names now. Just in
case the AppKit folks start getting REALLY verbose...

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::JSMethodNameToObjcMethodName):

LayoutTests:

Layout test for <rdar://problem/4370397> Missing return statement in
JSMethodNameToObjcMethodName.

  • fast/js/objc-big-method-name-expected.txt: Added.
  • fast/js/objc-big-method-name.html: Added.
10:29 AM Changeset in webkit [11681] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin, committed by Adele.

  • WebCoreSupport.subproj/WebTextRenderer.m: (createATSULayoutParameters): Assign initial values, which will never be used, to substituteRenderer and firstSmallCap, to avoid uninitialized variable warnings.
9:06 AM Changeset in webkit [11680] by ggaren
  • 8 edits
    3 adds in trunk

WebCore:

Reviewed by John.

Fixed <rdar://problem/4310363> JavaScript window.open: Height is 1
pixel short, and related bugs.

There were a few bugs here.
(1) Our code took size arguments and applied them to the window's

content rect. That's incorrect. The Rhino book says the arguments
should apply to the WebView. Other things that occupy the content
rect include the tab bar, the status bar, and the 1 pixel border
between brushed metal and document. All of these used to impinge
on the web page's display area.

The fix is to calculate sizing based on the WebView instead of
the content rect. This means that the webViewContentRect and
setContentRect delegate methods are obsolete and no longer called
by any of our code. (setContentRect was never called in the
first place.)

(2) None of our sizing accounted for scaled resolutions.

The fix is to ask the WebView to scale all coordintes for us.

(3) Our code assumed that all window accoutrements were on by default.

Safari works that way, but other WebKit clients might not.

The fix is always to explicitly set an on/off state.

(a) To facilitate scaling, I added a new bridge method, webView, to
access the webView.

(b) For internal consistency, I changed _Bars to _bars in bridge
methods, and _bars to _Bars in WinArgs data members. (Interestingly,
the different classes in our code are evenly divided on which format to
use.)

Added manual test:

  • manual-tests/window-open-features.html: Added.
  • manual-tests/resources/200x200.png: Added.
  • manual-tests/resources/popup200x200.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::showModalDialog): see (b) (KJS::WindowFunc::callAsFunction): see (b)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::statusbarVisible): see (b)
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): At the top of this method, I just did some formatting cleanup and moved the 'referrer' variable closer to where it's used. The changes in the middle of the method are (3), the bottom, (2).
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs): see (b)
  • kwq/WebCoreBridge.h: see (a)

WebKit:

Reviewed by John.

Part of fix for <rdar://problem/4310363> JavaScript window.open: Height
is 1 pixel short, and related bugs. See WebCore ChageLog.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge webView]): Added method.
2:08 AM Changeset in webkit [11679] by eseidel
  • 2 edits in trunk/WebKit

Submitted by: eseidel
Reviewed by: mjs

Development-only build fix.

  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): fixed typo
1:59 AM Changeset in webkit [11678] by mjs
  • 2 edits in trunk/WebKit

Not reviewed.

  • revert accidental commit of this file.
1:30 AM Changeset in webkit [11677] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 6156
Submitted by: eseidel
Reviewed by: mjs

Leaks when running SVG tests
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6156
No additional tests necessary, leaks already caught by other tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEDiffuseLighting::setLightSource): takes ownership (KCanvasFESpecularLighting::setLightSource): takes ownership
  • kcanvas/KCanvasFilters.h: (KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::~KCanvasFEDiffuseLighting): added (KCanvasFEDiffuseLighting::lightSource): fixed spacing (KCanvasFESpecularLighting::KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::~KCanvasFESpecularLighting): added (KCanvasFESpecularLighting::lightSource): fixed spacing
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::stringForPath): added missing CFRelease
1:16 AM Changeset in webkit [11676] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5931
Submitted by: eseidel
Reviewed by: darin

Remove additional bit-rotted DEBUG* ifdefs from WebCore.
This removes PARSER_DEBUG, FORMS_DEBUG and CSS_STYLESHEET_DEBUG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5931
No tests possible, only removing dead code.

  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::parseString): (CSSStyleSheetImpl::isLoading):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLGenericFormElementImpl::getForm):
  • khtml/html/htmlparser.cpp: (HTMLParser::processCloseTag): (HTMLParser::createHead):
12:49 AM Changeset in webkit [11675] by eseidel
  • 12 edits in trunk/WebCore

Bug #: 6107
Submitted by: eseidel
Reviewed by: darin

Move Decoder onto Shared<T> and clients onto RefPtr.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6107
No test cases possible, no functional changes.

  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotFinished): (KJS::XMLHttpRequest::slotData):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::begin): (KHTMLPart::write):
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::~Decoder):
  • khtml/misc/decoder.h:
  • khtml/misc/loader.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setDecoder):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::decoder):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
12:32 AM Changeset in webkit [11674] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.

  • Move handling of frame namespaces down to WebFrame.
  • Put some internal class declarations in the implementation file.
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _setFrameNamespace:]): (-[WebFrame _frameNamespace]):
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView setGroupName:]): (-[WebView groupName]):
  • WebView.subproj/WebViewInternal.h:

Dec 19, 2005:

2:16 PM Changeset in webkit [11673] by adele
  • 35 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • fast/text/atsui-multiple-renderers-expected.png: Added.
  • fast/text/atsui-multiple-renderers-expected.txt: Added.
  • fast/text/atsui-multiple-renderers.html: Added.
  • css1/text_properties/text-transCapitalize-expected.checksum:
  • css1/text_properties/text-transCapitalize-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.checksum:
  • fast/text/international/bidi-AN-after-L-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • fast/text/international/bidi-L2-run-reordering-expected.png:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • fast/text/international/bidi-LDB-2-CSS-expected.png:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • fast/text/international/bidi-LDB-2-HTML-expected.png:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-european-terminators-expected.checksum:
  • fast/text/international/bidi-european-terminators-expected.png:
  • fast/text/international/bidi-european-terminators-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • fast/text/international/bidi-fallback-font-weight-expected.png:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • fast/text/international/bidi-innertext-expected.checksum:
  • fast/text/international/bidi-innertext-expected.png:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-override-expected.checksum:
  • fast/text/international/bidi-override-expected.png:
  • fast/text/international/bidi-override-expected.txt:

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-multiple-renderers.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Fetch renderer info from the renderers array; add synthetic bold offset; render only synthetic bold in the synthetic bold pass. (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define. (initializeATSUStyle): Apply a skewing transform for synthetic oblique. (createATSUTextLayout): Merged into createATSUTextLayout. (createATSULayoutParameters): Merged in createATSUTextLayout; allocate and fill a renderers array and a character buffer for small caps and mirroring; (applyMirroringToRun): Merged into createATSULayoutParameters. (ATSU_drawHighlight): Deleted mirroring code. (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold. (ATSU_pointToOffset): Deleted mirroring code.
1:03 PM Changeset in webkit [11672] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: darin

  • Scripts/run-webkit-tests: stop /etc/catalog warnings
12:54 PM Changeset in webkit [11671] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-kerning-and-ligatures-expected.checksum: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.txt: Added.
  • fast/text/atsui-kerning-and-ligatures.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-kerning-and-ligatures.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeATSUStyle): Disable kerning; disable ligatures unless the font does not contain 'a', in which case it is assumed to never be rendered by the CG code path.
12:48 PM Changeset in webkit [11670] by darin
  • 3 edits in trunk/JavaScriptCore

Originally done by both George Staikos and Alexey Proskuryakov.

Our coding guidelines say "use 0 instead of NULL" and both RefPtr and
PassRefPtr were using NULL, which required including a header that
defines NULL.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Use 0 instead of NULL. (KXMLCore::PassRefPtr::operator!): Use ! instead of == NULL.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Use 0 instead of NULL. (KXMLCore::RefPtr::operator!): Use ! instead of == NULL. Also did some reformatting.
12:41 PM Changeset in webkit [11669] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Remove code to initialize the pointer; not needed since RefPtr gets initialized to 0. (ElementImpl::~ElementImpl): Remove code to deref the pointer; RefPtr handles that. (ElementImpl::attributes): Add get() call to get raw pointer. (ElementImpl::setAttributeMap): Remove code to deref the old map and set the new map. But added code to clear the element pointer from the old map (missing in the old version). Also added a FIXME. (ElementImpl::createAttributeMap): Remove ref(); RefPtr handles that. (NamedAttrMapImpl::addAttribute): Use a RefPtr to guarantee the element does not go away in the middle of dispatching DOM events. (StyledElementImpl::attributeChanged): Clean up code by using the inline function mappedAttributes() instead of doing type casts. (StyledElementImpl::parseMappedAttribute): Ditto. (StyledElementImpl::getClassList): Ditto.
  • khtml/xml/dom_elementimpl.h: Make ElementImpl::namedAttrMap be a RefPtr instead of raw pointer. Added an overload of StyledElementImpl::mappedAttributes for both const and non-const.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addChild): Use a RefPtr to ref/deref the child so that it doesn't leak.
  • khtml/html/htmlparser.h: Changed isindex to use a RefPtr.
  • khtml/html/htmlparser.cpp: (HTMLParser::~HTMLParser): Removed now-unneeded ref. (HTMLParser::isindexCreateErrorCheck): Remove now-unneeded deref/ref. (HTMLParser::handleIsindex): Put isindex element into a RefPtr. This prevents a crash that was otherwise happening during layout tests (caused indirectly by the changes above). (HTMLParser::startBody): Added call to get().
11:56 AM Changeset in webkit [11668] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Call poseAs to substitute our NSPasteboard class for the default one. Create a local pasteboard (really a global one with a unique name) and release it when exiting from the function so we don't leave it in the pasteboard server. (dumpRenderTree): Added an autorelease pool around one small bit of code that ddn't have one. Fixed a leak in an unlikely error case. (+[DumpRenderTreePasteboard generalPasteboard]): Override the default version of this method to return our local pasteboard.
11:53 AM Changeset in webkit [11667] by darin
  • 42 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff Garen and Eric Seidel.

  • kjs/simple_number.h: Removed many unnecessary includes, including the <cmath> one to work around GCC library header bugs. We may have to add some includes elsewhere for platforms other than OS X, since our prefix header takes care of some things.
  • kxmlcore/AlwaysInline.h: Added. Now clients that don't include simple_number.h can still get the ALWAYS_INLINE macro.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added AlwaysInline.h.
  • bindings/NP_jsobject.h: Removed a lot of unnecessary includes and removed C-specific stuff from this C++-only header.
  • bindings/jni/jni_jsobject.h: Removed a lot of unnecessary includes and did some reformatting.
  • bindings/objc/objc_runtime.h: Removed an unnecessary include.
  • bindings/runtime.h: Removed some unneeded includes. Reformatted.
  • bindings/runtime.cpp: Updated to compile with header changes, including a lot of reformatting.
  • bindings/runtime_object.h: Removed an unnecessary include.

WebCore:

Reviewed by Geoff Garen and Eric Seidel.

  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Added.
  • WebCorePrefix.h: Removed the use of <ostream>.
  • kwq/KWQDef.h: Removed now-unused Q_INT64, Q_INT16, Q_UINT16, qRound, and _KWQ_IOSTREAM_.
  • kwq/KWQKHTMLPart.h: Removed some unneeded headers and added forward-declarations of classes instead. Corrected some incorrect member function declarations.
  • kwq/KWQKHTMLPart.mm: Added a now-needed header.
  • khtml/ecma/kjs_window.cpp: Removed the <cmath> workaround.
  • khtml/rendering/bidi.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • khtml/rendering/render_canvasimage.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_image.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_text.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::calculateColor):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): Replaced use of qRound with use of lroundf or lround as appropriate.
  • kwq/KWQCString.h:
  • kwq/KWQCString.mm:
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm:
  • kwq/KWQMap.h:
  • kwq/KWQMemArray.h:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.h:
  • kwq/KWQPtrList.h:
  • kwq/KWQPtrStack.h:
  • kwq/KWQPtrVector.h:
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm:
  • kwq/KWQSize.h:
  • kwq/KWQSize.mm:
  • kwq/KWQValueList.h: Removed _KWQ_IOSTREAM_ code that was used at one time for unit tests, but is now unneeded, and requires <ostream>.
11:51 AM Changeset in webkit [12225] by darin
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Geoff Garen and Eric Seidel.

  • kxmlcore/AlwaysInline.h: Added.
11:50 AM Changeset in webkit [11666] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen and John Sullivan.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:_webcore_dictionaryWithHeaderString:]): Check length of string before calling characterAtIndex:0 since it will fail for an empty string.
11:41 AM Changeset in webkit [11665] by bdakin
  • 2 edits
    1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:37 AM Changeset in webkit [11664] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/should-use-atsui-expected.checksum: Added.
  • fast/text/should-use-atsui-expected.png: Added.
  • fast/text/should-use-atsui-expected.txt: Added.
  • fast/text/should-use-atsui.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/should-use-atsui.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Always start scanning from 0 since drawing and highlighting also measure everything up to run->from.
11:17 AM Changeset in webkit [11663] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

  • khtml/ecma/xmlhttprequest.cpp: (getMIMEType): A helper function to get MIME type from a Content-Type string. (getCharset): A helper function to get charset from a Content-Type string. (KJS::XMLHttpRequest::getValueProperty): Factored out responseIsXML(). (KJS::XMLHttpRequest::getResponseHeader): Return QString instead of JSValue (to get rid of unnecessary JSLocks). (KJS::XMLHttpRequest::responseIsXML): A new method that analyses Content-Type. (KJS::XMLHttpRequest::slotData): Use a correct charset for responses, see bug for details. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Update for getResponseHeader() changes
  • khtml/ecma/xmlhttprequest.h:
11:16 AM Changeset in webkit [11662] by thatcher
  • 1 add in trunk/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

2:38 AM Changeset in webkit [11661] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adele

  • replaced custom Identifier hashtable with HashSet
  • kjs/identifier.cpp: (KXMLCore::): (KJS::identifierTable): (KJS::Identifier::equal): (KJS::hash): (KJS::equal): (KJS::convert): (KJS::Identifier::add): (KJS::Identifier::remove):
  • kjs/identifier.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
2:32 AM Changeset in webkit [11660] by mjs
  • 4 edits
    4 deletes in trunk

WebCore:

Rubber stamped by Eric.

  • removed unused SPI headers
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/DOM-compat.h: Removed.

WebKit:

Rubber stamped by Eric.

  • remove some unused SPI headers.
  • DOM.subproj/WebDOMDocument.h: Removed.
  • DOM.subproj/WebDOMElement.h: Removed.
  • DOM.subproj/WebDOMNode.h: Removed.
  • WebKit.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.