Timeline



Dec 27, 2005:

7:47 PM Changeset in webkit [11787] by mjs
  • 3 edits in trunk/LayoutTests

Rubber stamped by Eric.

  • proper length for Array concat function is 1, not 0; also add test for String concat.
  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/resources/function_length.js:
12:06 PM Changeset in webkit [11786] by andersca
  • 5 edits in trunk/LayoutTests

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/array-every-expected.txt:
  • fast/js/array-every.html:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Modify these tests since Array.every and Array.foreach now follow Mozilla and treat arrays as sparse, not visiting non-existing properties.
12:02 PM Changeset in webkit [11785] by andersca
  • 4 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement filter and map. Also, make the existing array iteration functions not invoke the callback for non-existing properties, just as Mozilla does now.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Add filter and map.
  • tests/mozilla/expected.html: Update, two 1.6 tests now pass.
11:13 AM Changeset in webkit [11784] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the size changed and not everything was repainted.
  • manual-tests/bugzilla-5699.html: Added.
11:06 AM Changeset in webkit [11783] by darin
  • 25 edits in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
  • fast/text/international/bidi-AN-after-L-expected.png: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.png: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
  • fast/text/international/bidi-innertext-expected.checksum: Updated.
  • fast/text/international/bidi-innertext-expected.png: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
  • fast/text/international/bidi-override-expected.checksum: Updated.
  • fast/text/international/bidi-override-expected.png: Updated.

WebKit:

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
10:39 AM Changeset in webkit [11782] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • fast/replaced/absolute-image-sizing-expected.png: Added.
  • fast/replaced/absolute-image-sizing-expected.txt: Added.
  • fast/replaced/absolute-image-sizing.html: Added.

WebCore:

Reviewed by Maciej, landed by Darin.

Added layout tests:

  • fast/replaced/absolute-image-sizing.html
  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth() for replaced elements. (RenderBox::calcAbsoluteVerticalValues): Same thing for height.
10:26 AM Changeset in webkit [11781] by darin
  • 8 edits in trunk/WebCore

Reviewed by Geoff and Eric.

  • khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token. Also removed use of bitfields in Token, since there's no need to optimize storage here.
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Update for use of RefPtr in Token. (HTMLParser::textCreateErrorCheck): Ditto. (HTMLParser::commentCreateErrorCheck): Ditto. (HTMLParser::handleIsindex): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): Ditto. (khtml::HTMLTokenizer::processToken): Ditto.
  • khtml/rendering/render_text.h: Reduce the number of includes, change SOFT_HYPHEN from a macro into a constant. Change originalString function to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr member be a RefPtr.
  • khtml/rendering/render_text.cpp: (khtml::RenderText::previousOffset): Update for use of RefPtr for str. (khtml::RenderText::nextOffset): Ditto. (khtml::RenderText::RenderText): Ditto. (khtml::RenderText::originalString): Change to return PassRefPtr, even though it's not necessary at this level (since it's a virtual function). (khtml::RenderText::posOfChar): Update for use of RefPtr for str. (khtml::RenderText::setText): Ditto. (khtml::RenderTextFragment::RenderTextFragment): Ditto. (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.
  • khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
  • kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer included by render_text.h.
10:05 AM Changeset in webkit [11780] by darin
  • 2 edits in trunk/WebCore

Fix suggested by Mitz.

  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions): Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part of my fix for clientX/Y in the original patch.
4:56 AM Changeset in webkit [11779] by mjs
  • 2 edits in trunk/JavaScriptCore
  • updated test results for new JS 1.6 tests
  • tests/mozilla/expected.html:
4:29 AM Changeset in webkit [11778] by andersca
  • 1 edit
    27 adds in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

Add Mozilla JS 1.6 tests.

  • tests/mozilla/js1_6/Array/browser.js: Added.
  • tests/mozilla/js1_6/Array/regress-290592.js: Added.
  • tests/mozilla/js1_6/Array/regress-304828.js: Added.
  • tests/mozilla/js1_6/Array/regress-305002.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
  • tests/mozilla/js1_6/Array/regress-320887.js: Added.
  • tests/mozilla/js1_6/Array/shell.js: Added.
  • tests/mozilla/js1_6/README: Added.
  • tests/mozilla/js1_6/Regress/browser.js: Added.
  • tests/mozilla/js1_6/Regress/regress-301574.js: Added.
  • tests/mozilla/js1_6/Regress/regress-309242.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
  • tests/mozilla/js1_6/Regress/regress-314887.js: Added.
  • tests/mozilla/js1_6/Regress/regress-320172.js: Added.
  • tests/mozilla/js1_6/Regress/shell.js: Added.
  • tests/mozilla/js1_6/String/browser.js: Added.
  • tests/mozilla/js1_6/String/regress-306591.js: Added.
  • tests/mozilla/js1_6/String/shell.js: Added.
  • tests/mozilla/js1_6/browser.js: Added.
  • tests/mozilla/js1_6/shell.js: Added.
  • tests/mozilla/js1_6/template.js: Added.
4:24 AM Changeset in webkit [11777] by mjs
  • 6 edits in trunk/LayoutTests

No review, just a test harness change.

  • avoid bombing out if a shouldBe test case unexpectedly throws an exception
  • fast/js/kde/resources/base.js:
  • this lets some of the tests get a bit further, so new results:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/parse-expected.txt:
4:05 AM Changeset in webkit [11776] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/forms/button-in-forms-collection-expected.txt: Added.
  • fast/forms/button-in-forms-collection.html: Added.

WebCore:

Reviewed and landed by Maciej.

Test: fast/forms/button-in-forms-collection.html

  • khtml/html/html_formimpl.h: (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
3:07 AM Changeset in webkit [11775] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed and landed by Maciej.

  • kjs/array_object.cpp: (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when looking for array properties.

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/js/array-float-delete.html: Added.
2:35 AM Changeset in webkit [11774] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.cpp: (KJS::JSObject::defineSetter): Remove duplicate call to putDirect.
1:24 AM Changeset in webkit [11773] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

Changes by me and Anders.

  • also fixed some warnings reported by -Winline
  • JavaScriptCorePrefix.h: Move new and delete definitions higher so there aren't conflicts with use in standard C++ headers
  • kjs/object.cpp: (KJS::throwSetterError): Moved this piece of put into a seprate function to avoid the PIC branch. (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff when not needed. Also use GetterSetter properties attribute. (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter properties any more, if this one was one. (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter properties now (and use the new attribute). (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot, to avoid global variable access in the hot code path.
  • kjs/object.h: (KJS::): Added GetterSetter attribute. (KJS::JSCell::isObject): Moved lower to be after inline methods it uses. (KJS::JSValue::isObject): ditto (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters as much as possible in the case where they are not being used
  • kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): Ditto (KJS::PropertyMap::setHasGetterSetterProperties): Ditto (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the global "has getter/setter properties" flag in the property map single entry, to avoid making objects any bigger.
  • kjs/value.h: Moved some things to object.h to make -Winline happier

Dec 26, 2005:

3:33 PM Changeset in webkit [11772] by hyatt
  • 5 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the beginnings of a VC 2005 project for JSCore dll.

3:07 PM Changeset in webkit [11771] by mjs
  • 1 edit
    162 adds in trunk/LayoutTests

Rubber stamped by Geoff.

  • land JavaScript tests from the kde version of kjs
  • fast/js/kde/Array-expected.txt: Added.
  • fast/js/kde/Array.html: Added.
  • fast/js/kde/Boolean-expected.txt: Added.
  • fast/js/kde/Boolean.html: Added.
  • fast/js/kde/Date-expected.txt: Added.
  • fast/js/kde/Date.html: Added.
  • fast/js/kde/Error-expected.txt: Added.
  • fast/js/kde/Error.html: Added.
  • fast/js/kde/GlobalObject-expected.txt: Added.
  • fast/js/kde/GlobalObject.html: Added.
  • fast/js/kde/Number-expected.txt: Added.
  • fast/js/kde/Number.html: Added.
  • fast/js/kde/Object-expected.txt: Added.
  • fast/js/kde/Object.html: Added.
  • fast/js/kde/Prototype-expected.txt: Added.
  • fast/js/kde/Prototype.html: Added.
  • fast/js/kde/RegExp-expected.txt: Added.
  • fast/js/kde/RegExp.html: Added.
  • fast/js/kde/StringObject-expected.txt: Added.
  • fast/js/kde/StringObject.html: Added.
  • fast/js/kde/assignments-expected.txt: Added.
  • fast/js/kde/assignments.html: Added.
  • fast/js/kde/cast-expected.txt: Added.
  • fast/js/kde/cast.html: Added.
  • fast/js/kde/comment-1-expected.txt: Added.
  • fast/js/kde/comment-1.html: Added.
  • fast/js/kde/comment-2-expected.txt: Added.
  • fast/js/kde/comment-2.html: Added.
  • fast/js/kde/completion-expected.txt: Added.
  • fast/js/kde/completion.html: Added.
  • fast/js/kde/conditional-expected.txt: Added.
  • fast/js/kde/conditional.html: Added.
  • fast/js/kde/const-expected.txt: Added.
  • fast/js/kde/const.html: Added.
  • fast/js/kde/constructor_length-expected.txt: Added.
  • fast/js/kde/constructor_length.html: Added.
  • fast/js/kde/crash-1-expected.txt: Added.
  • fast/js/kde/crash-1.html: Added.
  • fast/js/kde/crash-2-expected.txt: Added.
  • fast/js/kde/crash-2.html: Added.
  • fast/js/kde/delete-expected.txt: Added.
  • fast/js/kde/delete.html: Added.
  • fast/js/kde/empty-expected.txt: Added.
  • fast/js/kde/empty.html: Added.
  • fast/js/kde/encode_decode_uri-expected.txt: Added.
  • fast/js/kde/encode_decode_uri.html: Added.
  • fast/js/kde/eval-expected.txt: Added.
  • fast/js/kde/eval.html: Added.
  • fast/js/kde/evil-n-expected.txt: Added.
  • fast/js/kde/evil-n.html: Added.
  • fast/js/kde/exception_propagation-expected.txt: Added.
  • fast/js/kde/exception_propagation.html: Added.
  • fast/js/kde/exceptions-expected.txt: Added.
  • fast/js/kde/exceptions.html: Added.
  • fast/js/kde/function-expected.txt: Added.
  • fast/js/kde/function.html: Added.
  • fast/js/kde/function_arguments-expected.txt: Added.
  • fast/js/kde/function_arguments.html: Added.
  • fast/js/kde/function_constructor-expected.txt: Added.
  • fast/js/kde/function_constructor.html: Added.
  • fast/js/kde/function_length-expected.txt: Added.
  • fast/js/kde/function_length.html: Added.
  • fast/js/kde/garbage-n-expected.txt: Added.
  • fast/js/kde/garbage-n.html: Added.
  • fast/js/kde/inbuilt_function_proto-expected.txt: Added.
  • fast/js/kde/inbuilt_function_proto.html: Added.
  • fast/js/kde/inbuilt_function_tostring-expected.txt: Added.
  • fast/js/kde/inbuilt_function_tostring.html: Added.
  • fast/js/kde/iteration-expected.txt: Added.
  • fast/js/kde/iteration.html: Added.
  • fast/js/kde/j-comment-3-expected.txt: Added.
  • fast/js/kde/j-comment-3.html: Added.
  • fast/js/kde/j-comment-4-expected.txt: Added.
  • fast/js/kde/j-comment-4.html: Added.
  • fast/js/kde/literals-expected.txt: Added.
  • fast/js/kde/literals.html: Added.
  • fast/js/kde/math-expected.txt: Added.
  • fast/js/kde/math.html: Added.
  • fast/js/kde/md5-1-expected.txt: Added.
  • fast/js/kde/md5-1.html: Added.
  • fast/js/kde/md5-2-expected.txt: Added.
  • fast/js/kde/md5-2.html: Added.
  • fast/js/kde/object_prototype-expected.txt: Added.
  • fast/js/kde/object_prototype.html: Added.
  • fast/js/kde/object_prototype_tostring-expected.txt: Added.
  • fast/js/kde/object_prototype_tostring.html: Added.
  • fast/js/kde/operators-expected.txt: Added.
  • fast/js/kde/operators.html: Added.
  • fast/js/kde/parse-expected.txt: Added.
  • fast/js/kde/parse.html: Added.
  • fast/js/kde/prototype_length-expected.txt: Added.
  • fast/js/kde/prototype_length.html: Added.
  • fast/js/kde/prototype_proto-expected.txt: Added.
  • fast/js/kde/prototype_proto.html: Added.
  • fast/js/kde/resources/Array.js: Added.
  • fast/js/kde/resources/Boolean.js: Added.
  • fast/js/kde/resources/Date.js: Added.
  • fast/js/kde/resources/Error.js: Added.
  • fast/js/kde/resources/GlobalObject.js: Added.
  • fast/js/kde/resources/KNOWN_FAILURES: Added.
  • fast/js/kde/resources/Number.js: Added.
  • fast/js/kde/resources/Object.js: Added.
  • fast/js/kde/resources/Prototype.js: Added.
  • fast/js/kde/resources/README: Added.
  • fast/js/kde/resources/RegExp.js: Added.
  • fast/js/kde/resources/StringObject.js: Added.
  • fast/js/kde/resources/assignments.js: Added.
  • fast/js/kde/resources/base.js: Added.
  • fast/js/kde/resources/cast.js: Added.
  • fast/js/kde/resources/comment-1.js: Added.
  • fast/js/kde/resources/comment-2.js: Added.
  • fast/js/kde/resources/completion.js: Added.
  • fast/js/kde/resources/conditional.js: Added.
  • fast/js/kde/resources/const.js: Added.
  • fast/js/kde/resources/constructor_length.js: Added.
  • fast/js/kde/resources/crash-1.js: Added.
  • fast/js/kde/resources/crash-2.js: Added.
  • fast/js/kde/resources/delete.js: Added.
  • fast/js/kde/resources/empty.js: Added.
  • fast/js/kde/resources/encode_decode_uri.js: Added.
  • fast/js/kde/resources/eval.js: Added.
  • fast/js/kde/resources/evil-n.js: Added.
  • fast/js/kde/resources/exception_propagation.js: Added.
  • fast/js/kde/resources/exceptions.js: Added.
  • fast/js/kde/resources/function.js: Added.
  • fast/js/kde/resources/function_arguments.js: Added.
  • fast/js/kde/resources/function_constructor.js: Added.
  • fast/js/kde/resources/function_length.js: Added.
  • fast/js/kde/resources/garbage-n.js: Added.
  • fast/js/kde/resources/inbuilt_function_proto.js: Added.
  • fast/js/kde/resources/inbuilt_function_tostring.js: Added.
  • fast/js/kde/resources/iteration.js: Added.
  • fast/js/kde/resources/j-comment-3.js: Added.
  • fast/js/kde/resources/j-comment-4.js: Added.
  • fast/js/kde/resources/literals.js: Added.
  • fast/js/kde/resources/math.js: Added.
  • fast/js/kde/resources/md5-1.js: Added.
  • fast/js/kde/resources/md5-2.js: Added.
  • fast/js/kde/resources/object_prototype.js: Added.
  • fast/js/kde/resources/object_prototype_tostring.js: Added.
  • fast/js/kde/resources/operators.js: Added.
  • fast/js/kde/resources/parse.js: Added.
  • fast/js/kde/resources/prototype_length.js: Added.
  • fast/js/kde/resources/prototype_proto.js: Added.
  • fast/js/kde/resources/scope.js: Added.
  • fast/js/kde/resources/shell.js: Added.
  • fast/js/kde/resources/statements.js: Added.
  • fast/js/kde/resources/string-1-n.js: Added.
  • fast/js/kde/resources/string-2-n.js: Added.
  • fast/js/kde/resources/var_decl_init.js: Added.
  • fast/js/kde/scope-expected.txt: Added.
  • fast/js/kde/scope.html: Added.
  • fast/js/kde/statements-expected.txt: Added.
  • fast/js/kde/statements.html: Added.
  • fast/js/kde/string-1-n-expected.txt: Added.
  • fast/js/kde/string-1-n.html: Added.
  • fast/js/kde/string-2-n-expected.txt: Added.
  • fast/js/kde/string-2-n.html: Added.
  • fast/js/kde/var_decl_init-expected.txt: Added.
  • fast/js/kde/var_decl_init.html: Added.
2:47 PM Changeset in webkit [11770] by hyatt
  • 1 edit in trunk/JavaScriptCore/Makefile.vc

Undo my accidental commit of Makefile.vc

2:23 PM Changeset in webkit [11769] by hyatt
  • 2 edits in trunk/JavaScriptCore/kjs

Make sure assert.h is included by including it in config.h

2:08 PM Changeset in webkit [11768] by hyatt
  • 2 edits in trunk/JavaScriptCore

Fix win32 bustage. ifdef the swap function for std pairs.

1:46 PM Changeset in webkit [11767] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Geoff.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's parent pointer.

WebKit:

Reviewed by Geoff

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly asking for parent via WebFrame (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more because WebFame's _detachFromParent takes care of that now.
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they can remove themselves. (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge until we are done with it. (-[WebFrame _transitionToCommitted:]): Remove some extra braces. (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent field directly. (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private since it is not there any more. (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer explicitly any more. (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field. (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces. (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the coding style. (-[WebFrame _previousFrameWithWrap:]): Ditto. (-[WebFrame parentFrame]): Get parent from the bridge.
12:06 AM Changeset in webkit [11766] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): don't retain self until after the possible early return.

Dec 25, 2005:

10:28 AM Changeset in webkit [11765] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:05 AM Changeset in webkit [11764] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the data source is committed, doesn't make sense to archive otherwise. (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method. (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source is committed. Use the helper. (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that defers callback changed. (-[WebDataSource _startLoading]): Remove stray space. (-[WebDataSource _stopLoading]): Only handle local _stopLoading business. Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal and remove _recursiveStopLoading. (-[WebDataSource _startLoading:]): Clean up an assert slightly. (-[WebDataSource _setTitle:]): Remove stray spaces. (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame can do that. (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame. (-[WebDataSource webArchive]): Return nil if the data source is not yet committed. It makes no sense to archive a provisional data source since it has no data yet. (-[WebDataSource addSubresource:]): Replace an assert with an early return, ASSERT is not an appropriate way to flag problems with the argument of a public method.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _setLoadType:]): Remove stray space. (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes manually and add a FIXME about confusingness of stopping loading here. (-[WebFrame _defersCallbacksChanged]): Tell our subframes. (-[WebFrame _addChild:]): Remove stray space. (-[WebFrame _stopLoadingSubframes]): New helper method. (-[WebFrame _subframeIsLoading]): New helper method, code moved from WebDataSource. (-[WebFrame stopLoading]): Tell subframes to stop loading. (-[WebFrame reload]): Remove extra braces.
  • WebView.subproj/WebFrameInternal.h:
1:22 AM Changeset in webkit [11763] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Eric and Dave Hyatt.

This is a somewhat cheesy change. Having to use PassRefPtr_Ref creates ambiguities
in assignment and copy construction. And this makes life way easier and removes
the need for pass(). It is not really correct, but we pretty much never need a real
const PassRefPtr, and this takes care of things for PassRefPtr temporaries.

  • kjs/identifier.cpp: (KJS::Identifier::add): No more need for pass()
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): No more need for pass()
  • kjs/ustring.cpp: (KJS::UString::Rep::create): Use adoptRef (KJS::UString::UString): No more need for pass (KJS::UString::append): No more need for pass (KJS::UString::substr): No more need for pass
  • kxmlcore/PassRefPtr.h: made m_ptr mutable (ugh) (KXMLCore::PassRefPtr::PassRefPtr): Take a const PassRefPtr reference (KXMLCore::PassRefPtr::release): Made this a const method (ugh) (KXMLCore::PassRefPtr::operator=): clean up appropriately (KXMLCore::adoptRef): Added this to use instead of PassRefPtr<T>::adopt, I think it makes the behavior more clear and it is less verbose. (KXMLCore::static_pointer_cast): use adoptRef (KXMLCore::const_pointer_cast): use adoptRef
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): take const PassRefPtr& (KXMLCore::PassRefPtr::operator=): take const PassRefPtr&
12:11 AM Changeset in webkit [11762] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Unbreak HashTableConstIterator++ by returning const_iterator

  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator++): use const_iterator

Dec 24, 2005:

11:52 PM Changeset in webkit [11761] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Un-break HashTable copy constructor.

  • kxmlcore/HashTable.h: (KXMLCore::::HashTable): use const_iterator instead
9:11 PM Changeset in webkit [11760] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 6236
Submitted by: mitz
Reviewed by: eseidel

  • fast/forms/domstring-replace-crash-expected.txt: Added.
  • fast/forms/domstring-replace-crash.html: Added.
9:11 PM Changeset in webkit [11759] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6326
Submitted by: mitz
Reviewed by: eseidel

Test: fast/forms/domstring-replace-crash.html

  • khtml/dom/dom_string.h: (DOMString::replace): Added check for null m_impl.
2:45 PM Changeset in webkit [11758] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::accessors): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::putValueProperty):
  • khtml/ecma/kjs_html.h:
2:06 PM Changeset in webkit [11757] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap): In all methods, explicitly cast all pointers to void * before passing to internal implementation. Use C-style casts instead of new-style casts, because the real solution would require a combo of reinterpret_cast anc const_cast.
2:00 PM Changeset in webkit [11756] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6231

  • Fixed assertion failure in QString::mid caused by my last checkin. parseWindowFeatuers() sometimes called QString::mid() with a start index past the end of the string but a length of 0. There were two problems there. (1) parseWindowString() shouldn't have gotten past the end of the string. (2) QString had range truncating code that was borked. So I fixed both.
  • khtml/ecma/kjs_window.cpp: (KJS::parseWindowFeatures): One of the "past the end" tests was > instead of >=.
  • kwq/KWQString.mm: (QString::mid): Truncate length *before* deciding whether to return early. Also, compare start and data._length before computing data._length - start, because the error case we're trying to catch will almost certainly cause unsigned overflow.
  • manual-tests/window-open-features-parsing.html: Added trailing ',' to uber-test to catch this failure, too.
2:02 AM Changeset in webkit [11755] by ap
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Changed the parameter type of slotTextChanged to const DOMString &
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): ditto. (RenderLineEdit::slotTextChanged): ditto. (RenderFileButton::RenderFileButton): ditto. (RenderFileButton::slotTextChanged): ditto.

Dec 23, 2005:

5:05 PM Changeset in webkit [11754] by ggaren
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Darin, reviewed and landed by me.

  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
4:54 PM Changeset in webkit [11753] by mjs
  • 8 edits in trunk/WebKit

Reviewed by John.

  • move more frame tree traversal code from WebView to WebFrame
  • WebView.subproj/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]): Moved this debug method from WebView, renamed it and changed it to return a boolean so it is appropriate for use in assertions instead of giving its own errors. (-[WebFrame _accumulateFramesWithSelection:]): Helper for the above. (-[WebFrame _findFrameWithSelection]): Moved from WebView and renamed from _findSelectedFrame, also removed the skipping variant. (-[WebFrame _clearSelectionInOtherFrames]): Moved from WebView and changed how the logic works. Instead of clearing selection in any frame but the focus frame, it clears selection in all but this one.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Stop getting WebFrame in needlessly roundabout way. (-[WebPDFView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebTextView.m: (-[WebTextView _webFrame]): New helper method. (-[WebTextView _elementAtWindowPoint:]): Use it. (-[WebTextView becomeFirstResponder]): Call _clearSelectionInOtherFrames (-[WebTextView resignFirstResponder]): Fix style issue (-[WebTextView clickedOnLink:atIndex:]): Use new helkper
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): Call to WebFrame as appropriate (-[WebView _selectedOrMainFrame]): Fix style issue
  • WebView.subproj/WebViewInternal.h:
3:04 PM Changeset in webkit [11752] by ggaren
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by vicki (yay!), eric.

  • Fixed: <rdar://problem/4377597> parsing of window.open features strings needs to be more forgiving

Manual test case: WebCore/manual-tests/window-open-features-parsing.html
Also fixed: WebCore/manual-tests/window-open-features.html, which had an incorrect URL in it.

This patch is long. Luckily, it's also complicated.

The main thing I've done is to change our parsing of the window.open 'features' argument to match Win IE. This is important because we now implement the correct defaults for window.open, and resizing and scrolling are turned off by default. So, if we parse the 'features' string incorrectly, we'll end up with an annoying, incorrectly sized window that can't resize or scroll.

To honor a long-standing request by Eric, I factored out the parsing into two new functions: parseWindowFeatures and constrainToScreen. I also added support for "innerWidth" and "innerHeight," since they're just synonyms for "width" and "height."

  • khtml/ecma/kjs_window.cpp: removed "emit" statements, since emit is #defined as "" (KJS::parseDialogFeatures): renamed from parseFeatures, since we now have a 'parseWindowFeatures'. (KJS::showModalDialog): ditto on parseFeatures. Also added some missing initializations for WindowArgs data members. (KJS::parseWindowFeatures): new function, all new functionality. (KJS::constrainToScreen): new function, no new functionality -- just cut and pasted code that used to run as part of our parsing routine. (KJS::WindowFunc::callAsFunction): (1) Factored out previous parsing code. (2) Factored 17 lines of custom popup-blocking code into 3 lines that use pre-existing 'allowPopUp' function. Gratuitous, but it cried out to me. (3) Changed URL parsing to substitute "" for undefined *and* null values (we already did this for undefined), to avoid trying to navigate to '​http://null'. (4) Factore a multiline if () { if () {}} into an if ( && ) (4) Removed the main body of code from a giant 'else' block by inserting early returns for the exceptional cases. This caused some things to show up in the diff even though they're just whitespace changes. I didn't actually change any code past the line "if (!str.isEmpty() && activePart)"
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Added code to set toolbars to visible if toolBarVisible is true *or* locationBarVisible is true. The parser used to do this for us, but it's really the browser that's responsible for saying that the toolbar and the locationbar are the same thing. Hopefully, we can add a setLocationBarVisible delegate in the future so that other webkit clients can make their own UI decisions.
  • kwq/KWQKPartsBrowserExtension.h: Added locationBarVisible data member to WindowArgs structure and renamed toolBarsVisible to toolBarVisible (see above). Removed initialization code from WindowArgs structure because this file is for platform-specific code, and what defaults to use for window arguments is purely engine stuff.
10:44 AM Changeset in webkit [11751] by eseidel
  • 59 edits
    6 deletes in trunk/WebCore

Bug #: 6138
Submitted by: eseidel
Reviewed by: mjs

Remove many use of .qstring()
Convert several instances of QStrings to DOMStrings
Add DOMString::replace(QChar, QChar)
Remove (unused) KWQLabel, KWQKGlobal
Slight performance improvement.
Also fixed ChangeLog line endings from previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6138

No tests needed, no functionality changes.

  • ChangeLog: Fixed line endings
  • ForwardingHeaders/kglobal.h: Removed.
  • ForwardingHeaders/qlabel.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: removed KWQLabel
  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_stylesheetimpl.cpp: (MediaListImpl::setMediaText):
  • khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState):
  • khtml/dom/dom_string.h: (DOM::DOMString::replace):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::put): (KJS::DOMAttr::put): (KJS::DOMDocument::put):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLElement::put): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported):
  • khtml/editing/markup.cpp: (khtml::stringValueForRange): (khtml::startMarkup):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLInputElementImpl::appendFormData): (DOM::HTMLTextAreaElementImpl::updateValue):
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::isURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableSectionElementImpl::addChild): (DOM::HTMLTableRowElementImpl::addChild):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::checkEmitLoadEvent):
  • khtml/misc/loader.cpp: (CachedObject::finish): (CachedCSSStyleSheet::checkNotify): (CachedXSLStyleSheet::checkNotify): (CachedXBLDocument::checkNotify): (DocLoader::requestImage): (DocLoader::requestStyleSheet): (DocLoader::requestScript): (Loader::servePendingRequests): (Loader::cancelRequests):
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::~RenderBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): (RenderLineEdit::updateFromElement): (RenderTextArea::updateFromElement): (RenderTextArea::text):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListMarker::paint):
  • khtml/rendering/render_text.cpp: (khtml::RenderText::RenderText): (khtml::RenderText::position):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): (DocumentImpl::getElementByAccessKey): (DocumentImpl::recalcStyleSelector): (DocumentImpl::defaultEventHandler):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dump): (DOM::appendAttributeDesc): (DOM::NodeImpl::showNode):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::lower):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::executeScripts):
  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentViewForNode): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::addMessageToConsole): (KWQKHTMLPart::passWheelEventToChildWidget): (KWQKHTMLPart::shouldDragAutoNode): (KWQKHTMLPart::snapshotDragImage): (convertAttributesToUnderlines): (KWQKHTMLPart::setMarkedTextRange): (KWQKHTMLPart::mousePressNode):
  • kwq/KWQKGlobal.h: Removed.
  • kwq/KWQKGlobal.mm: Removed.
  • kwq/KWQLabel.h: Removed.
  • kwq/KWQLabel.mm: Removed.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setAutoSaveName): (QLineEdit::setPlaceholderString):
  • kwq/KWQPainter.mm: (QPainter::compositeOperatorFromString):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::call):
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • ksvg2/scripts/cssmakeprops: removed kglobal.h
  • ksvg2/scripts/cssmakevalues: removed kglobal.h
12:55 AM Changeset in webkit [11750] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp (KJS::XMLHttpRequest::slotFinished): Make sure to fetch response headers and set the state to Loaded, if this hasn't been done already.
12:50 AM Changeset in webkit [11749] by ap
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): Set application/xml as a default Content-Type; use a proper codec for request body if a charset is specified. (KJS::XMLHttpRequest::getRequestHeader): Use getSpecificHeader. (KJS::XMLHttpRequest::getResponseHeader): Ditto. (KJS::XMLHttpRequest::getSpecificHeader): Factored out code from getResponseHeader. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Removed a FIXME (this is done in send() now).
  • khtml/ecma/xmlhttprequest.h:
12:35 AM Changeset in webkit [11748] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

ChangeLog entry for the previous checkin

12:34 AM Changeset in webkit [11747] by mjs
  • 2 edits in trunk/JavaScriptCore
  • this time for sure
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
12:28 AM Changeset in webkit [11746] by ap
  • 6 adds in trunk/LayoutTests/fast/encoding

Reviewed by Darin Adler.

  • fast/encoding/frame-default-enc-expected.checksum: Added.
  • fast/encoding/frame-default-enc-expected.png: Added.
  • fast/encoding/frame-default-enc-expected.txt: Added.
  • fast/encoding/frame-default-enc.html: Added.
  • fast/encoding/resources/frame-default-enc-frame.html: Added.
12:19 AM Changeset in webkit [11745] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Eric.

  • move a few more methods from WebView to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _hasSelection]): Renamed from _frameIsSelected: and moved from WebView. (-[WebFrame _clearSelection]): Renamed from _deselectFrame: and moved from WebView.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Update for renames. (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): Ditto. (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]): Ditto. (-[WebView _selectedFrameDidChange]):
12:05 AM Changeset in webkit [11744] by justing
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6211>
fast/text/attributed-substring-from-range-lines needs LayoutTests/editing/editing.js

  • editing/input/attributed-substring-from-range-lines-expected.txt: Added.
  • editing/input/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-lines.html: Removed.
12:02 AM Changeset in webkit [11743] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Eric.

  • updated for WebCore changes to make XSLT params partially work
  • fast/xsl/xslt-processer-expected.txt:
Note: See TracTimeline for information about the timeline view.