Timeline



Dec 29, 2005:

11:38 PM Changeset in webkit [11830] by eseidel
  • 65 edits in trunk/LayoutTests

Bug #: 6155
Submitted by: eseidel
Reviewed by: none, just updating pixel results

Updating results, after landing color-matching change.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/custom/conditional-processing-outside-switch-expected.checksum:
  • svg/custom/conditional-processing-outside-switch-expected.png:
  • svg/custom/control-points-for-S-and-T-expected.checksum:
  • svg/custom/control-points-for-S-and-T-expected.png:
  • svg/custom/fill-update-expected.checksum:
  • svg/custom/fill-update-expected.png:
  • svg/custom/junk-data-expected.checksum:
  • svg/custom/junk-data-expected.png:
  • svg/custom/missing-xlink-expected.checksum:
  • svg/custom/missing-xlink-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • svg/custom/path-update-expected.checksum:
  • svg/custom/path-update-expected.png:
  • svg/custom/simpleCDF-expected.checksum:
  • svg/custom/simpleCDF-expected.png:
  • svg/custom/simpleCDF-expected.txt:
  • svg/custom/transform-ignore-after-invalid-expected.checksum:
  • svg/custom/transform-ignore-after-invalid-expected.png:
  • svg/custom/transform-ignore-after-invalid.svg:
  • svg/custom/transform-invalid-expected.checksum:
  • svg/custom/transform-invalid-expected.png:
  • svg/custom/transform-with-ending-space-expected.checksum:
  • svg/custom/transform-with-ending-space-expected.png:
  • svg/custom/use-forward-refs-expected.checksum:
  • svg/custom/use-forward-refs-expected.png:
11:33 PM Changeset in webkit [11829] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel

WebCore+SVG has some problems with rounded rectangles
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

  • svg/custom/rounded-rects-expected.checksum: Added.
  • svg/custom/rounded-rects-expected.png: Added.
  • svg/custom/rounded-rects-expected.txt: Added.
  • svg/custom/rounded-rects.svg: Added.
11:05 PM Changeset in webkit [11828] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric, committed by Maciej.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Use previous character from the buffer instead of ch which may be uninitialized on the first iteration.
11:04 PM Changeset in webkit [11827] by eseidel
  • 3 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Move WebView width/height logic into DumpRenderTree to support
running the W3C SVG 1.1 tests along side other tests. The W3C
SVG 1.1 tests require a 480x360 view.

  • DumpRenderTree/DumpRenderTree.m: (main): don't accept width/height (dump): override width/height for SVG/W3C
  • Scripts/run-webkit-tests: don't pass width/height
10:46 PM Changeset in webkit [11826] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and refined by Darin.

  • fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • fast/css/margin-top-bottom-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

  • khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues): Set all margin values in all cases.
10:43 PM Changeset in webkit [11825] by eseidel
  • 1 edit
    1 delete in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: No review, only removing dead code.

  • DumpKCanvasTree/DumpKCanvasTree.m: Removed.
  • DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.
10:38 PM Changeset in webkit [11824] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 6155
Submitted by: eseidel
Reviewed by: darin

DumpRenderTree should set a consistent color profile while running
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

Creates consistent colormatched renderings on every test machine
using the only way possible with Tiger APIs: by setting the
system color profile on the test machine for the duration of the
tests. This will (unfortunately) cause colors to change while
running DumpRenderTree. This can also cause "permanent" color
changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
This is far from ideal, but it's be best way we've found to deal
with the issue for now.

  • DumpRenderTree/DumpRenderTree.m: (restoreColorSpace): (setDefaultColorProfileToRGB): (main):
9:51 PM Changeset in webkit [11823] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs

XML documents with "html" in dtd name use XHTML entities when they shouldn't
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

  • fast/parser/xhtml-alternate-entities-expected.txt: Added.
  • fast/parser/xhtml-alternate-entities.xml: Added.
9:43 PM Changeset in webkit [11822] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs

XML documents with "html" in dtd name use XHTML entities when they shouldn't
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

  • khtml/xml/xml_tokenizer.cpp: (khtml::externalSubsetHandler): check for exact xhtml types
9:40 PM Changeset in webkit [11821] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6295
Submitted by: eseidel
Reviewed by: mjs

Close leak in CollectionInfo due to HashMap migration
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6295

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
  • khtml/html/html_miscimpl.h:
9:33 PM Changeset in webkit [11820] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6101
Submitted by: eseidel
Reviewed by: mjs

Leaks in XSLTProcessorImpl due to early exit in failure case
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6101

  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xmlDocPtrFromNode): add "shouldDelete" argument (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
9:11 PM Changeset in webkit [11819] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Eric.

  • kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol since it is not actually used.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Removed (this was unused)
  • WebView.subproj/WebFrame.m: (-[WebFrame _removeChild::]): Moved to FrameTraversal category. (-[WebFrame _childFrameCount]): New frame traversal method to avoid getting the count from the array directly. (-[WebFrame _appendChild:]): Factored out the parts of addChild: that seem directly relevant to adding a child. (-[WebFrame _removeChild:]): Moved to FrameTraversal category. (-[WebFrame _detachChildren]): Don't deallocate children array because there's no particular need to. (-[WebFrame _setDataSource:]): make the assert use _childFrameCount (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting from the main frame, check this frame and all ancestors. If a resource for a frame completes, that con only possibly finish loading for that frame and its ancestors, not any other frame in the tree. (-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed. (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new approved way. (-[WebFrame _internalChildFrames]): removed (-[WebFrame _addChild:]): Use _appendChild: for most of the work. (-[WebFrame _generateFrameName]): Get child frame count in the new approved way. (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms, upon further consideration there's no need to copy part of the frame tree here. (-[WebFrame findFrameNamed:]): Remove extra braces. (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
  • WebView.subproj/WebFramePrivate.h: Remove some methods.
  • WebView.subproj/WebMainResourceLoader.m: (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current frame not the main frame (before there was no difference and now the new version is what is desired).
  • WebView.subproj/WebView.m: (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces and update FIXME comment. (-[WebView _receivedError:fromDataSource:]): Remove stray space
8:11 PM Changeset in webkit [11818] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6230
Submitted by: eseidel
Reviewed by: build fix only.

File accidentally omitted from previous commit.

Remove QDict from khtml/html
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6230

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLCollection::getNamedItems):
7:33 PM Changeset in webkit [11817] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6230
Submitted by: eseidel
Reviewed by: mjs

Remove QDict from khtml/html
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
Uses HashMap instead.

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo): (DOM::HTMLCollectionImpl::CollectionInfo::reset): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLCollectionImpl::updateNameCache): (DOM::HTMLCollectionImpl::namedItems): (DOM::HTMLCollectionImpl::nextNamedItem): (DOM::HTMLFormCollectionImpl::nextNamedItemInternal): (DOM::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/html_miscimpl.h:
7:27 PM Changeset in webkit [11816] by eseidel
  • 15 edits in trunk/WebCore

Bug #: 6228
Submitted by: eseidel
Reviewed by: mjs

DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
Added find(), contains(), startsWith() and endsWith() to DOMString
Uses the above functions throughout the code.
Small performance boost.

  • khtml/css/css_base.cpp: (CSSSelector::print):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSImportRuleImpl::init):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::setProperty):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::parseContent):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::setEncodedURL): (khtml::parseUASheet): (khtml::cleanpath): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSRuleSet::addRulesFromSheet): (khtml::CSSStyleSelector::applyProperty):
  • khtml/dom/dom_string.cpp:
  • khtml/dom/dom_string.h: (DOM::DOMString::contains): (DOM::DOMString::find): (DOM::DOMString::startsWith): (DOM::DOMString::endsWith):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseEnctype):
  • khtml/khtml_part.cpp: (KHTMLPart::requestFrame): (KHTMLPart::submitForm):
  • khtml/misc/decoder.cpp: (Decoder::decode):
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::length): (DOM::AtomicString::operator []): (DOM::AtomicString::contains): (DOM::AtomicString::find): (DOM::AtomicString::startsWith): (DOM::AtomicString::endsWith):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv):
  • khtml/xml/dom_stringimpl.cpp: (DOM::equal): (DOM::equalCaseInsensitive): (DOM::DOMStringImpl::find): (DOM::DOMStringImpl::endsWith):
  • khtml/xml/dom_stringimpl.h: (DOM::DOMStringImpl::startsWith):
7:23 PM Changeset in webkit [11815] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel

WebCore+SVG has some problems with rounded rectangles
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

  • ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::toPathData): fixed round rect calculations
6:42 PM Changeset in webkit [11814] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
Support HTML entities on pages parsed as XHTML

  • fast/parser/entities-in-xhtml-expected.txt: Added.
  • fast/parser/entities-in-xhtml.xhtml: Added.
4:43 PM Changeset in webkit [11813] by ggaren
  • 4 edits
    5 adds in trunk/LayoutTests

Updated test results for the last few JavaScriptCore patches
I checked in.

  • ChangeLog:
  • fast/js/array-float-delete-expected.txt: Added.
  • fast/js/kde/Date-expected.txt:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/StringObject-expected.txt:
4:37 PM Changeset in webkit [11812] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Rewrote most of the frame traversal code in WebFrame to use DOM-style
first/last/next/previous methods, to abstract access better in preparation
for moving it down.

As an added bonus, many formerly recursive methods are now iterative.

  • WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that variables can be declared in for loop initializers.
  • added new frame traversal methods, to avoid dealing with the children array directly:
  • WebView.subproj/WebFrame.m: (-[WebFrame _firstChildFrame]): New method. (-[WebFrame _lastChildFrame]): New method. (-[WebFrame _previousSiblingFrame]): New method. (-[WebFrame _nextSiblingFrame]): New method. (-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM; uses some of the previous.
  • apply the new methods

(-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
to use new traversal methods.
(-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
(-[WebFrame _setName:]): Improved comment, removed gratuitous brace
(-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
of looking in child arrays (duh)
(-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
still walk backwards for now.
(-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
(-[WebFrame _childFramesMatchItem:]): ditto
(-[WebFrame _defersCallbacksChanged]): ditto
(-[WebFrame _viewWillMoveToHostWindow:]): ditto
(-[WebFrame _viewDidMoveToHostWindow]): ditto
(-[WebFrame _addChild:]): don't use childFrames method
(-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list,
not obvious if anything needs this but it seems like the right thing to do.
(-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
calling count on nil still gives 0.
(-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
(-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
traversal methods.
(-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
a thin wrapper on _traverseNextFrameStayWithin:
(-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
(-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
(-[WebFrame _reloadForPluginChanges]): ditto
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _documentViews]): ditto
(-[WebFrame _updateDrawsBackground]): ditto
(-[WebFrame _unmarkAllMisspellings]): ditto
(-[WebFrame _atMostOneFrameHasSelection]): ditto
(-[WebFrame _findFrameWithSelection]): ditto
(-[WebFrame _stopLoadingSubframes]): ditto
(-[WebFrame _subframeIsLoading]): ditto
(-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto

3:49 PM Changeset in webkit [11811] by eseidel
  • 4 edits
    1 add in trunk/WebCore

Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel, ggaren, darin

Added layout tests:

  • fast/parser/entities-in-xhtml.xhtml
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML. (khtml::XMLTokenizer::isXHTMLDocument): Ditto. (khtml::externalSubsetHandler): Ditto. (khtml::XMLTokenizer::finish): Ditto. (khtml::getXHTMLEntity): Look up the HTML entity. (khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
  • khtml/html/kentities.h: Added.
  • khtml/html/kentities.gperf: changed entity to Entity
2:02 PM Changeset in webkit [11810] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]): Removed unused "draggingTypes" instance variable.
1:59 PM Changeset in webkit [11809]
  • 212 copies
    17 deletes in tags/WebCore-417~18

This commit was manufactured by cvs2svn to create tag
'WebCore-417~18'.

1:59 PM Changeset in webkit [11808] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.18

3:51 AM Changeset in webkit [11807] by ggaren
  • 2 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, reviewed and landed by me.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction):
3:45 AM Changeset in webkit [11806] by ggaren
  • 3 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, Reviewed and landed by me.

  • kjs/number_object.cpp:
  • kjs/regexp_object.cpp:
3:38 AM Changeset in webkit [11805] by ggaren
  • 3 edits in trunk/JavaScriptCore

Patch by Maks Orlovich, reviewed by mjs.

This has 2 very minor fixes, covered by KJS testsuite:

  1. Enumerates string indices in property list (with the same bug as array object has in corresponding code). This is a mozilla emulation thing.
  2. Permits properties with integer names in prototypes to be found
  • kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): (StringInstanceImp::propList):
  • kjs/string_object.h:
3:30 AM Changeset in webkit [11804] by ggaren
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRenderer.m

forgot to remove the redundant (float) cast, as specified by reviewer

3:27 AM Changeset in webkit [11803] by ggaren
  • 4 edits in trunk

WebCore:

Reviewed by darin

  • khtml/rendering/font.h: (khtml::Font::checkSelectionPoint): Make sure the complete run, used for counting spaces and determining padding per space does not go beyond the text box.

WebKit:

Reviewed by darin

Test: fast/text/atsui-spacing-features.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Add letter- and word-spacing and padding for justification. (createATSULayoutParameters): Compute padding per space.
3:16 AM Changeset in webkit [11802] by ggaren
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by mjs.

This patch does four things:
(1) Standardizes all our linked list nodes to use "next" as their next
pointers.
(2) Creates the ListRefPtr<T> class, a subclass of RefPtr<T> specialized
to iteratively deref "next" pointers.
(3) Standardizes our linked list nodes to use ListRefPtr<T> and
implement the releaseNext() function used by ~ListRefPtr<T>().
(4) Adds to RefPtr<T> the release() method used by releaseNext().

  • Modified existing mozilla test to ensure it would make deployment builds crash as well.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/nodes.cpp: (ElementNode::evaluate): (PropertyListNode::evaluate): (ArgumentListNode::evaluateList): (StatListNode::StatListNode): (StatListNode::execute): (StatListNode::processVarDecls): (VarDeclListNode::evaluate): (VarDeclListNode::processVarDecls): (VarStatementNode::execute): (VarStatementNode::processVarDecls): (BlockNode::BlockNode): (CaseClauseNode::evalStatements): (CaseClauseNode::processVarDecls): (ClauseListNode::processVarDecls): (CaseBlockNode::CaseBlockNode): (CaseBlockNode::evalBlock): (SourceElementsNode::SourceElementsNode): (SourceElementsNode::execute): (SourceElementsNode::processFuncDecl): (SourceElementsNode::processVarDecls):
  • kjs/nodes.h: (KJS::ElementNode::ElementNode): (KJS::ElementNode::releaseNext): (KJS::ArrayNode::ArrayNode): (KJS::PropertyListNode::PropertyListNode): (KJS::PropertyListNode::releaseNext): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentListNode::releaseNext): (KJS::ArgumentsNode::ArgumentsNode): (KJS::StatListNode::releaseNext): (KJS::VarDeclListNode::VarDeclListNode): (KJS::VarDeclListNode::releaseNext): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ClauseListNode::getClause): (KJS::ClauseListNode::getNext): (KJS::ClauseListNode::releaseNext): (KJS::ParameterNode::ParameterNode): (KJS::ParameterNode::releaseNext): (KJS::SourceElementsNode::releaseNext):
  • kjs/nodes2string.cpp: (ElementNode::streamTo): (PropertyListNode::streamTo): (ArgumentListNode::streamTo): (StatListNode::streamTo): (VarDeclListNode::streamTo): (VarStatementNode::streamTo): (CaseClauseNode::streamTo): (ClauseListNode::streamTo): (CaseBlockNode::streamTo): (SourceElementsNode::streamTo):
  • kxmlcore/ListRefPtr.h: Added. (KXMLCore::ListRefPtr::ListRefPtr): (KXMLCore::ListRefPtr::~ListRefPtr): (KXMLCore::ListRefPtr::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::release):
3:02 AM Changeset in webkit [11801] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by mjs.

Added call to sranddev() -- it executes the first time a process
calls Math.random().

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
2:36 AM Changeset in webkit [11800] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by mjs.

We had code that checked for whether a call came from a live PlugIn,
but the live PlugIn dictionary would only get cleared when the
KWQKHTMLPart was destroyed. Since a single part can service multiple
loads, the dictionary needs to clear after each one.

No layout test because this bug is difficult to reproduce.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (1) Unrelated cleanup: Removed manual clearing of form values, replaced with call to clearRecordedFormValues(). (2) Replaced PlugIn dictionary cleanup code and view deref call with call to setView(0), since much of this code was duplicated in setView, and the stuff that wasn't duplicated needed to be.

(KWQKHTMLPart::setView):
(1) Removed some unnecessary braces.
(2) Added PlugIn dictionary cleanup code.
(3) New behavior: clear _bindingRoot and _windowScriptObject after
each view change. This is needed because after a call to
clenaupPluginRootObjects(), both objects have stale references.
(4) Changed a NULL to a 0.

(KWQKHTMLPart::cleanupPluginRootObjects): Removed extra space.

2:11 AM Changeset in webkit [11799] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Changed strings passed to Java back to original "JSObject".

  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
12:58 AM Changeset in webkit [11798] by hyatt
  • 3 edits
    2 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Improvements to the Visual Studio project files. Have dftables generating chartables.c and have set up separate intermediate/output/derivedsources dirs to match the Mac XCode structure.

12:22 AM Changeset in webkit [11797] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • fast/dom/undetectable-document-all-expected.txt: Added.
  • fast/dom/undetectable-document-all.html: Added.
12:20 AM Changeset in webkit [11796] by andersca
  • 3 edits in trunk/WebCore

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::getValueProperty): If "all" has been set to a new value, return the new value.

(KJS::KJS::HTMLDocument::putValueProperty):
Allow "all" to be set to a new value.

(KJS::HTMLAllCollection::toPrimitive):
Return jsNull() if the preferred type is NullType.

(KJS::getAllHTMLCollection):

  • khtml/ecma/kjs_html.h: (KJS::HTMLAllCollection::HTMLAllCollection): Add HTMLAllCollection, a subclass of HTMLCollection which should be undetectable.

(KJS::HTMLAllCollection::toBoolean):
Return false.

12:18 AM Changeset in webkit [11795] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-28 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/operations.cpp: (KJS::equal): When comparing an object with null or undefined, call toPrimitive with NullType as the preferred type.

Dec 28, 2005:

11:02 AM Changeset in webkit [11794] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Eric, landed by ap.

  • fast/block/basic/text-indent-rtl-expected.checksum: Added.
  • fast/block/basic/text-indent-rtl-expected.png: Added.
  • fast/block/basic/text-indent-rtl-expected.txt: Added.
  • fast/block/basic/text-indent-rtl.html: Added.
10:59 AM Changeset in webkit [11793] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by ap.

Test: fast/block/basic/text-indent-rtl.html

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::rightRelOffset): Subtract the indent instead of adding it.
10:48 AM Changeset in webkit [11792] by ap
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin, landed by ap.

  • fast/dom/HTMLScriptElement/resources/script-load.js: Added.
  • fast/dom/HTMLScriptElement/script-load-events-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-load-events.html: Added.
10:46 AM Changeset in webkit [11791] by ap
  • 8 edits in trunk/WebCore

Reviewed by Darin, landed by ap.

Test: fast/dom/HTMLScriptElement/script-load-events.html

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Parse the onload and onerror attributes. (HTMLScriptElementImpl::closeRenderer): Call base class's implementation. (HTMLScriptElementImpl::notifyFinished): Dispatch load and error events.
  • khtml/html/htmlparser.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Return the node that was inserted.
  • khtml/html/htmltokenizer.h: Added scriptNode, a RefPtr to the node corresponding to the current load request.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): Reset scriptNode if a load request was not made. (HTMLTokenizer::parseTag): Set scriptNode to the node created from the script tag. (HTMLTokenizer::processToken): Return the node that was inserted. (HTMLTokenizer::notifyFinished): Reset scriptNode and dispatch load and error events.
  • khtml/misc/loader.h: (CachedScript::errorOccurred): Added.
  • khtml/misc/loader.cpp: (CachedScript::CachedScript): (CachedScript::error):
10:23 AM Changeset in webkit [11790] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

  • editing/input/range-for-empty-document-expected.txt: Added.
  • editing/input/range-for-empty-document.html: Added.
10:21 AM Changeset in webkit [11789] by ap
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: editing/input/range-for-empty-document.html

  • khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Handle the case of an empty document and (0, 0) requested range.
10:18 AM Changeset in webkit [11788] by ggaren
  • 2 edits in trunk/WebCore

Reviewed and landed by Geoff.

  • khtml/rendering/render_text.cpp: (khtml::RenderText::setText): Remove deref().

Dec 27, 2005:

7:47 PM Changeset in webkit [11787] by mjs
  • 3 edits in trunk/LayoutTests

Rubber stamped by Eric.

  • proper length for Array concat function is 1, not 0; also add test for String concat.
  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/resources/function_length.js:
12:06 PM Changeset in webkit [11786] by andersca
  • 5 edits in trunk/LayoutTests

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/array-every-expected.txt:
  • fast/js/array-every.html:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Modify these tests since Array.every and Array.foreach now follow Mozilla and treat arrays as sparse, not visiting non-existing properties.
12:02 PM Changeset in webkit [11785] by andersca
  • 4 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement filter and map. Also, make the existing array iteration functions not invoke the callback for non-existing properties, just as Mozilla does now.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Add filter and map.
  • tests/mozilla/expected.html: Update, two 1.6 tests now pass.
11:13 AM Changeset in webkit [11784] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the size changed and not everything was repainted.
  • manual-tests/bugzilla-5699.html: Added.
11:06 AM Changeset in webkit [11783] by darin
  • 25 edits in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
  • fast/text/international/bidi-AN-after-L-expected.png: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.png: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
  • fast/text/international/bidi-innertext-expected.checksum: Updated.
  • fast/text/international/bidi-innertext-expected.png: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
  • fast/text/international/bidi-override-expected.checksum: Updated.
  • fast/text/international/bidi-override-expected.png: Updated.

WebKit:

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
10:39 AM Changeset in webkit [11782] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • fast/replaced/absolute-image-sizing-expected.png: Added.
  • fast/replaced/absolute-image-sizing-expected.txt: Added.
  • fast/replaced/absolute-image-sizing.html: Added.

WebCore:

Reviewed by Maciej, landed by Darin.

Added layout tests:

  • fast/replaced/absolute-image-sizing.html
  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth() for replaced elements. (RenderBox::calcAbsoluteVerticalValues): Same thing for height.
10:26 AM Changeset in webkit [11781] by darin
  • 8 edits in trunk/WebCore

Reviewed by Geoff and Eric.

  • khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token. Also removed use of bitfields in Token, since there's no need to optimize storage here.
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Update for use of RefPtr in Token. (HTMLParser::textCreateErrorCheck): Ditto. (HTMLParser::commentCreateErrorCheck): Ditto. (HTMLParser::handleIsindex): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): Ditto. (khtml::HTMLTokenizer::processToken): Ditto.
  • khtml/rendering/render_text.h: Reduce the number of includes, change SOFT_HYPHEN from a macro into a constant. Change originalString function to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr member be a RefPtr.
  • khtml/rendering/render_text.cpp: (khtml::RenderText::previousOffset): Update for use of RefPtr for str. (khtml::RenderText::nextOffset): Ditto. (khtml::RenderText::RenderText): Ditto. (khtml::RenderText::originalString): Change to return PassRefPtr, even though it's not necessary at this level (since it's a virtual function). (khtml::RenderText::posOfChar): Update for use of RefPtr for str. (khtml::RenderText::setText): Ditto. (khtml::RenderTextFragment::RenderTextFragment): Ditto. (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.
  • khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
  • kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer included by render_text.h.
10:05 AM Changeset in webkit [11780] by darin
  • 2 edits in trunk/WebCore

Fix suggested by Mitz.

  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions): Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part of my fix for clientX/Y in the original patch.
4:56 AM Changeset in webkit [11779] by mjs
  • 2 edits in trunk/JavaScriptCore
  • updated test results for new JS 1.6 tests
  • tests/mozilla/expected.html:
4:29 AM Changeset in webkit [11778] by andersca
  • 1 edit
    27 adds in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

Add Mozilla JS 1.6 tests.

  • tests/mozilla/js1_6/Array/browser.js: Added.
  • tests/mozilla/js1_6/Array/regress-290592.js: Added.
  • tests/mozilla/js1_6/Array/regress-304828.js: Added.
  • tests/mozilla/js1_6/Array/regress-305002.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
  • tests/mozilla/js1_6/Array/regress-320887.js: Added.
  • tests/mozilla/js1_6/Array/shell.js: Added.
  • tests/mozilla/js1_6/README: Added.
  • tests/mozilla/js1_6/Regress/browser.js: Added.
  • tests/mozilla/js1_6/Regress/regress-301574.js: Added.
  • tests/mozilla/js1_6/Regress/regress-309242.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
  • tests/mozilla/js1_6/Regress/regress-314887.js: Added.
  • tests/mozilla/js1_6/Regress/regress-320172.js: Added.
  • tests/mozilla/js1_6/Regress/shell.js: Added.
  • tests/mozilla/js1_6/String/browser.js: Added.
  • tests/mozilla/js1_6/String/regress-306591.js: Added.
  • tests/mozilla/js1_6/String/shell.js: Added.
  • tests/mozilla/js1_6/browser.js: Added.
  • tests/mozilla/js1_6/shell.js: Added.
  • tests/mozilla/js1_6/template.js: Added.
4:24 AM Changeset in webkit [11777] by mjs
  • 6 edits in trunk/LayoutTests

No review, just a test harness change.

  • avoid bombing out if a shouldBe test case unexpectedly throws an exception
  • fast/js/kde/resources/base.js:
  • this lets some of the tests get a bit further, so new results:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/parse-expected.txt:
4:05 AM Changeset in webkit [11776] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/forms/button-in-forms-collection-expected.txt: Added.
  • fast/forms/button-in-forms-collection.html: Added.

WebCore:

Reviewed and landed by Maciej.

Test: fast/forms/button-in-forms-collection.html

  • khtml/html/html_formimpl.h: (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
3:07 AM Changeset in webkit [11775] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed and landed by Maciej.

  • kjs/array_object.cpp: (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when looking for array properties.

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/js/array-float-delete.html: Added.
2:35 AM Changeset in webkit [11774] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.cpp: (KJS::JSObject::defineSetter): Remove duplicate call to putDirect.
1:24 AM Changeset in webkit [11773] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

Changes by me and Anders.

  • also fixed some warnings reported by -Winline
  • JavaScriptCorePrefix.h: Move new and delete definitions higher so there aren't conflicts with use in standard C++ headers
  • kjs/object.cpp: (KJS::throwSetterError): Moved this piece of put into a seprate function to avoid the PIC branch. (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff when not needed. Also use GetterSetter properties attribute. (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter properties any more, if this one was one. (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter properties now (and use the new attribute). (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot, to avoid global variable access in the hot code path.
  • kjs/object.h: (KJS::): Added GetterSetter attribute. (KJS::JSCell::isObject): Moved lower to be after inline methods it uses. (KJS::JSValue::isObject): ditto (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters as much as possible in the case where they are not being used
  • kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): Ditto (KJS::PropertyMap::setHasGetterSetterProperties): Ditto (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the global "has getter/setter properties" flag in the property map single entry, to avoid making objects any bigger.
  • kjs/value.h: Moved some things to object.h to make -Winline happier

Dec 26, 2005:

3:33 PM Changeset in webkit [11772] by hyatt
  • 5 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the beginnings of a VC 2005 project for JSCore dll.

3:07 PM Changeset in webkit [11771] by mjs
  • 1 edit
    162 adds in trunk/LayoutTests

Rubber stamped by Geoff.

  • land JavaScript tests from the kde version of kjs
  • fast/js/kde/Array-expected.txt: Added.
  • fast/js/kde/Array.html: Added.
  • fast/js/kde/Boolean-expected.txt: Added.
  • fast/js/kde/Boolean.html: Added.
  • fast/js/kde/Date-expected.txt: Added.
  • fast/js/kde/Date.html: Added.
  • fast/js/kde/Error-expected.txt: Added.
  • fast/js/kde/Error.html: Added.
  • fast/js/kde/GlobalObject-expected.txt: Added.
  • fast/js/kde/GlobalObject.html: Added.
  • fast/js/kde/Number-expected.txt: Added.
  • fast/js/kde/Number.html: Added.
  • fast/js/kde/Object-expected.txt: Added.
  • fast/js/kde/Object.html: Added.
  • fast/js/kde/Prototype-expected.txt: Added.
  • fast/js/kde/Prototype.html: Added.
  • fast/js/kde/RegExp-expected.txt: Added.
  • fast/js/kde/RegExp.html: Added.
  • fast/js/kde/StringObject-expected.txt: Added.
  • fast/js/kde/StringObject.html: Added.
  • fast/js/kde/assignments-expected.txt: Added.
  • fast/js/kde/assignments.html: Added.
  • fast/js/kde/cast-expected.txt: Added.
  • fast/js/kde/cast.html: Added.
  • fast/js/kde/comment-1-expected.txt: Added.
  • fast/js/kde/comment-1.html: Added.
  • fast/js/kde/comment-2-expected.txt: Added.
  • fast/js/kde/comment-2.html: Added.
  • fast/js/kde/completion-expected.txt: Added.
  • fast/js/kde/completion.html: Added.
  • fast/js/kde/conditional-expected.txt: Added.
  • fast/js/kde/conditional.html: Added.
  • fast/js/kde/const-expected.txt: Added.
  • fast/js/kde/const.html: Added.
  • fast/js/kde/constructor_length-expected.txt: Added.
  • fast/js/kde/constructor_length.html: Added.
  • fast/js/kde/crash-1-expected.txt: Added.
  • fast/js/kde/crash-1.html: Added.
  • fast/js/kde/crash-2-expected.txt: Added.
  • fast/js/kde/crash-2.html: Added.
  • fast/js/kde/delete-expected.txt: Added.
  • fast/js/kde/delete.html: Added.
  • fast/js/kde/empty-expected.txt: Added.
  • fast/js/kde/empty.html: Added.
  • fast/js/kde/encode_decode_uri-expected.txt: Added.
  • fast/js/kde/encode_decode_uri.html: Added.
  • fast/js/kde/eval-expected.txt: Added.
  • fast/js/kde/eval.html: Added.
  • fast/js/kde/evil-n-expected.txt: Added.
  • fast/js/kde/evil-n.html: Added.
  • fast/js/kde/exception_propagation-expected.txt: Added.
  • fast/js/kde/exception_propagation.html: Added.
  • fast/js/kde/exceptions-expected.txt: Added.
  • fast/js/kde/exceptions.html: Added.
  • fast/js/kde/function-expected.txt: Added.
  • fast/js/kde/function.html: Added.
  • fast/js/kde/function_arguments-expected.txt: Added.
  • fast/js/kde/function_arguments.html: Added.
  • fast/js/kde/function_constructor-expected.txt: Added.
  • fast/js/kde/function_constructor.html: Added.
  • fast/js/kde/function_length-expected.txt: Added.
  • fast/js/kde/function_length.html: Added.
  • fast/js/kde/garbage-n-expected.txt: Added.
  • fast/js/kde/garbage-n.html: Added.
  • fast/js/kde/inbuilt_function_proto-expected.txt: Added.
  • fast/js/kde/inbuilt_function_proto.html: Added.
  • fast/js/kde/inbuilt_function_tostring-expected.txt: Added.
  • fast/js/kde/inbuilt_function_tostring.html: Added.
  • fast/js/kde/iteration-expected.txt: Added.
  • fast/js/kde/iteration.html: Added.
  • fast/js/kde/j-comment-3-expected.txt: Added.
  • fast/js/kde/j-comment-3.html: Added.
  • fast/js/kde/j-comment-4-expected.txt: Added.
  • fast/js/kde/j-comment-4.html: Added.
  • fast/js/kde/literals-expected.txt: Added.
  • fast/js/kde/literals.html: Added.
  • fast/js/kde/math-expected.txt: Added.
  • fast/js/kde/math.html: Added.
  • fast/js/kde/md5-1-expected.txt: Added.
  • fast/js/kde/md5-1.html: Added.
  • fast/js/kde/md5-2-expected.txt: Added.
  • fast/js/kde/md5-2.html: Added.
  • fast/js/kde/object_prototype-expected.txt: Added.
  • fast/js/kde/object_prototype.html: Added.
  • fast/js/kde/object_prototype_tostring-expected.txt: Added.
  • fast/js/kde/object_prototype_tostring.html: Added.
  • fast/js/kde/operators-expected.txt: Added.
  • fast/js/kde/operators.html: Added.
  • fast/js/kde/parse-expected.txt: Added.
  • fast/js/kde/parse.html: Added.
  • fast/js/kde/prototype_length-expected.txt: Added.
  • fast/js/kde/prototype_length.html: Added.
  • fast/js/kde/prototype_proto-expected.txt: Added.
  • fast/js/kde/prototype_proto.html: Added.
  • fast/js/kde/resources/Array.js: Added.
  • fast/js/kde/resources/Boolean.js: Added.
  • fast/js/kde/resources/Date.js: Added.
  • fast/js/kde/resources/Error.js: Added.
  • fast/js/kde/resources/GlobalObject.js: Added.
  • fast/js/kde/resources/KNOWN_FAILURES: Added.
  • fast/js/kde/resources/Number.js: Added.
  • fast/js/kde/resources/Object.js: Added.
  • fast/js/kde/resources/Prototype.js: Added.
  • fast/js/kde/resources/README: Added.
  • fast/js/kde/resources/RegExp.js: Added.
  • fast/js/kde/resources/StringObject.js: Added.
  • fast/js/kde/resources/assignments.js: Added.
  • fast/js/kde/resources/base.js: Added.
  • fast/js/kde/resources/cast.js: Added.
  • fast/js/kde/resources/comment-1.js: Added.
  • fast/js/kde/resources/comment-2.js: Added.
  • fast/js/kde/resources/completion.js: Added.
  • fast/js/kde/resources/conditional.js: Added.
  • fast/js/kde/resources/const.js: Added.
  • fast/js/kde/resources/constructor_length.js: Added.
  • fast/js/kde/resources/crash-1.js: Added.
  • fast/js/kde/resources/crash-2.js: Added.
  • fast/js/kde/resources/delete.js: Added.
  • fast/js/kde/resources/empty.js: Added.
  • fast/js/kde/resources/encode_decode_uri.js: Added.
  • fast/js/kde/resources/eval.js: Added.
  • fast/js/kde/resources/evil-n.js: Added.
  • fast/js/kde/resources/exception_propagation.js: Added.
  • fast/js/kde/resources/exceptions.js: Added.
  • fast/js/kde/resources/function.js: Added.
  • fast/js/kde/resources/function_arguments.js: Added.
  • fast/js/kde/resources/function_constructor.js: Added.
  • fast/js/kde/resources/function_length.js: Added.
  • fast/js/kde/resources/garbage-n.js: Added.
  • fast/js/kde/resources/inbuilt_function_proto.js: Added.
  • fast/js/kde/resources/inbuilt_function_tostring.js: Added.
  • fast/js/kde/resources/iteration.js: Added.
  • fast/js/kde/resources/j-comment-3.js: Added.
  • fast/js/kde/resources/j-comment-4.js: Added.
  • fast/js/kde/resources/literals.js: Added.
  • fast/js/kde/resources/math.js: Added.
  • fast/js/kde/resources/md5-1.js: Added.
  • fast/js/kde/resources/md5-2.js: Added.
  • fast/js/kde/resources/object_prototype.js: Added.
  • fast/js/kde/resources/object_prototype_tostring.js: Added.
  • fast/js/kde/resources/operators.js: Added.
  • fast/js/kde/resources/parse.js: Added.
  • fast/js/kde/resources/prototype_length.js: Added.
  • fast/js/kde/resources/prototype_proto.js: Added.
  • fast/js/kde/resources/scope.js: Added.
  • fast/js/kde/resources/shell.js: Added.
  • fast/js/kde/resources/statements.js: Added.
  • fast/js/kde/resources/string-1-n.js: Added.
  • fast/js/kde/resources/string-2-n.js: Added.
  • fast/js/kde/resources/var_decl_init.js: Added.
  • fast/js/kde/scope-expected.txt: Added.
  • fast/js/kde/scope.html: Added.
  • fast/js/kde/statements-expected.txt: Added.
  • fast/js/kde/statements.html: Added.
  • fast/js/kde/string-1-n-expected.txt: Added.
  • fast/js/kde/string-1-n.html: Added.
  • fast/js/kde/string-2-n-expected.txt: Added.
  • fast/js/kde/string-2-n.html: Added.
  • fast/js/kde/var_decl_init-expected.txt: Added.
  • fast/js/kde/var_decl_init.html: Added.
2:47 PM Changeset in webkit [11770] by hyatt
  • 1 edit in trunk/JavaScriptCore/Makefile.vc

Undo my accidental commit of Makefile.vc

2:23 PM Changeset in webkit [11769] by hyatt
  • 2 edits in trunk/JavaScriptCore/kjs

Make sure assert.h is included by including it in config.h

2:08 PM Changeset in webkit [11768] by hyatt
  • 2 edits in trunk/JavaScriptCore

Fix win32 bustage. ifdef the swap function for std pairs.

1:46 PM Changeset in webkit [11767] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Geoff.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's parent pointer.

WebKit:

Reviewed by Geoff

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly asking for parent via WebFrame (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more because WebFame's _detachFromParent takes care of that now.
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they can remove themselves. (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge until we are done with it. (-[WebFrame _transitionToCommitted:]): Remove some extra braces. (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent field directly. (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private since it is not there any more. (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer explicitly any more. (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field. (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces. (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the coding style. (-[WebFrame _previousFrameWithWrap:]): Ditto. (-[WebFrame parentFrame]): Get parent from the bridge.
12:06 AM Changeset in webkit [11766] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): don't retain self until after the possible early return.

Dec 25, 2005:

10:28 AM Changeset in webkit [11765] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:05 AM Changeset in webkit [11764] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the data source is committed, doesn't make sense to archive otherwise. (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method. (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source is committed. Use the helper. (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that defers callback changed. (-[WebDataSource _startLoading]): Remove stray space. (-[WebDataSource _stopLoading]): Only handle local _stopLoading business. Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal and remove _recursiveStopLoading. (-[WebDataSource _startLoading:]): Clean up an assert slightly. (-[WebDataSource _setTitle:]): Remove stray spaces. (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame can do that. (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame. (-[WebDataSource webArchive]): Return nil if the data source is not yet committed. It makes no sense to archive a provisional data source since it has no data yet. (-[WebDataSource addSubresource:]): Replace an assert with an early return, ASSERT is not an appropriate way to flag problems with the argument of a public method.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _setLoadType:]): Remove stray space. (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes manually and add a FIXME about confusingness of stopping loading here. (-[WebFrame _defersCallbacksChanged]): Tell our subframes. (-[WebFrame _addChild:]): Remove stray space. (-[WebFrame _stopLoadingSubframes]): New helper method. (-[WebFrame _subframeIsLoading]): New helper method, code moved from WebDataSource. (-[WebFrame stopLoading]): Tell subframes to stop loading. (-[WebFrame reload]): Remove extra braces.
  • WebView.subproj/WebFrameInternal.h:
1:22 AM Changeset in webkit [11763] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Eric and Dave Hyatt.

This is a somewhat cheesy change. Having to use PassRefPtr_Ref creates ambiguities
in assignment and copy construction. And this makes life way easier and removes
the need for pass(). It is not really correct, but we pretty much never need a real
const PassRefPtr, and this takes care of things for PassRefPtr temporaries.

  • kjs/identifier.cpp: (KJS::Identifier::add): No more need for pass()
  • kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): No more need for pass()
  • kjs/ustring.cpp: (KJS::UString::Rep::create): Use adoptRef (KJS::UString::UString): No more need for pass (KJS::UString::append): No more need for pass (KJS::UString::substr): No more need for pass
  • kxmlcore/PassRefPtr.h: made m_ptr mutable (ugh) (KXMLCore::PassRefPtr::PassRefPtr): Take a const PassRefPtr reference (KXMLCore::PassRefPtr::release): Made this a const method (ugh) (KXMLCore::PassRefPtr::operator=): clean up appropriately (KXMLCore::adoptRef): Added this to use instead of PassRefPtr<T>::adopt, I think it makes the behavior more clear and it is less verbose. (KXMLCore::static_pointer_cast): use adoptRef (KXMLCore::const_pointer_cast): use adoptRef
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): take const PassRefPtr& (KXMLCore::PassRefPtr::operator=): take const PassRefPtr&
12:11 AM Changeset in webkit [11762] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Unbreak HashTableConstIterator++ by returning const_iterator

  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator++): use const_iterator
Note: See TracTimeline for information about the timeline view.