Timeline



Jan 18, 2006:

10:46 PM Changeset in webkit [12230] by hyatt
  • 56 edits in trunk

Rename KHTMLView to FrameView (since it's been moved to a file called FrameView already).

6:40 PM Changeset in webkit [12229] by thatcher
  • 15 edits
    1 add in trunk/JavaScriptGlue

Adding the license header to all files so we can
move JavaScriptGlue into the open source repository.

  • LICENSE: Added.
  • JSBase.cpp: license header added.
  • JSBase.h: ditto.
  • JSObject.cpp: ditto.
  • JSObject.h: ditto.
  • JSRun.cpp: ditto.
  • JSRun.h: ditto.
  • JSUtils.cpp: ditto.
  • JSUtils.h: ditto.
  • JSValueWrapper.cpp: ditto.
  • JSValueWrapper.h: ditto.
  • JavaScriptGlue.cpp: ditto.
  • JavaScriptGlue.h: ditto.
  • UserObjectImp.cpp: ditto.
  • UserObjectImp.h: ditto.
5:59 PM Changeset in webkit [12190] by thatcher
  • 1 move in tags/WebCore-417.19

Fix a typo.

5:54 PM Changeset in webkit [12189] by thatcher
  • 1 copy in tags/WebCore-417.9/WebCore

Tag for WebCore-417.9

5:53 PM Changeset in webkit [12188] by thatcher
  • 1 add in tags/WebCore-417.9

Tag directory for WebCore-417.9

5:43 PM Changeset in webkit [12187] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to 417.19.

5:34 PM Changeset in webkit [12186] by thatcher
  • 2 edits
    5 adds
    16 deletes in branches/Safari-2-0-branch
  • Removing the .cvsignore on the branch.
  • Added the new Makefiles.
5:30 PM Changeset in webkit [12185] by thatcher
  • 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2006-01-17 Beth Dakin <Beth Dakin>

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.

  • khtml/html/HTMLInputElementImpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): If the click is simulated, set xPos and yPos to 0.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Fix spacing. (HTMLElementImpl::click): It isn't necessary to check if there is a renderer.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTest): Call updateLayout().
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchSimulatedMouseEvent): Set isSimulated to true. (WebCore::NodeImpl::dispatchMouseEvent): Keep track of isSimulated.
  • khtml/xml/NodeImpl.h: Same.
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Add isSimulated to MouseRelatedEventImpl(). (DOM::MouseRelatedEventImpl::computePositions): Only change the offsets if it's not simulated. (DOM::MouseEventImpl::MouseEventImpl): Add isSimulated to MouseEventImpl()
  • khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::isSimulated): Declarations of isSimulated (DOM::MouseEventImpl::isSimulated): Same.
4:59 PM Changeset in webkit [12184] by hyatt
  • 1 edit in trunk/WebCore/page/Frame.h

It's called pure virtual for a reason. (Fingers crossed.)

4:51 PM Changeset in webkit [12183] by hyatt
  • 2 edits in trunk/WebCore

Umm. Yeah. Let's try making BrowserExtensionMac actually declare and use a class called BrowserExtensionMac.

4:43 PM Changeset in webkit [12182] by hyatt
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.mm

Remove KParts using from WebCoreFrameBridge.mm (yes, more bustage).

4:39 PM Changeset in webkit [12181] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

Make sure FrameView includes MacFrame.h on mac only.

4:30 PM Changeset in webkit [12180] by hyatt
  • 1 edit in trunk/WebCore/page/FrameView.cpp

More Mac build bustage. Fix the dashboard region call to still cast to MacFrame.

4:15 PM Changeset in webkit [12179] by hyatt
  • 3 edits in trunk/WebCore

OMG I BROKE THE MAC. (Fixed)

3:59 PM Changeset in webkit [12178] by hyatt
  • 30 edits
    3 moves
    2 deletes in trunk/WebCore

Eliminate uses of MacFrame in cross-platform code.

1:14 PM Changeset in webkit [12177] by hyatt
  • 3 edits in trunk/WebCore/kwq

Make the signals/stubs/slots compile on Win32 by removing #imports.

1:12 PM Changeset in webkit [12176] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • change KWQList to use qsort instead of CFArraySort
  • kwq/KWQListImpl.cpp: (compareFuncWrapper): Wrapper that uses global variables to overcome the lack of a "data" pointer in qsort. Could have used qsort_r but that would be less portable. (KWQListImpl::sort): Use qsort instead of CFArraySortValues.
12:19 PM Changeset in webkit [12175] by darin
  • 4 edits
    3 moves in trunk/WebCore

Reviewed by Beth.

  • changed the three signal/slot related files from ObjC++ to C++ files
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQSignal.cpp: Added.
  • kwq/KWQSignal.mm: Removed.
  • kwq/KWQSignalStubs.cpp: Added.
  • kwq/KWQSignalStubs.mm: Removed.
  • kwq/KWQSlot.cpp: Added.
  • kwq/KWQSlot.mm: Removed.
11:48 AM Changeset in webkit [12174] by hyatt
  • 2 edits in trunk/WebCore

Add KWQListImpl.cpp to Win32 but ifdef out all the LAME LAME LAME CF dependencies.

11:41 AM Changeset in webkit [12173] by thatcher
  • 11 edits
    2 adds in branches/Safari-2-0-branch/LayoutTests

Fix for binary files.

11:31 AM Changeset in webkit [12172] by hyatt
  • 3 edits in trunk/JavaScriptCore

Make testkjs.exe compile without warnings.

11:31 AM Changeset in webkit [12171] by hyatt
  • 5 edits in trunk/WebCore

Make Win32 WebCore build again.

9:19 AM Changeset in webkit [12170] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Added.
  • fast/overflow/overflow-rtl-inline-scrollbar.html: Added.

WebCore:

Test: fast/overflow/overflow-rtl-inline-scrollbar.html

Reviewed by Hyatt.



Inline flows were always returning 0 for leftmostPosition(). Their real leftmost
edges are determined by their inline boxes, which
RenderBlock::leftmostPosition already takes into account.

  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't descend into inline flows. (RenderFlow::rightmostPosition): Ditto. (RenderFlow::leftmostPosition): Ditto.
8:51 AM Changeset in webkit [12169] by andersca
  • 3 edits in trunk/WebCore

2006-01-18 Anders Carlsson <​andersca@mac.com>

Fix build.


  • khtml/ecma/kjs_navigator.cpp:
  • page/FrameView.cpp: Remove kstandarddirs.h includes.
12:57 AM Changeset in webkit [12168] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fixed change log.

12:56 AM Changeset in webkit [12167] by darin
  • 8 edits
    1 move
    2 adds
    6 deletes in trunk/WebCore

Reviewed by Hyatt.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • css/make-css-file-arrays.pl: Added. Used to generate C array forms of the ".css" files.
  • css/UserAgentStyleSheets.cpp: Added. Used to indirectly compile the generated file.
  • WebCore.xcodeproj/project.pbxproj: Added new source files. Added a build phase to invoke the make-css-file-arrays.pl script. Removed the .css files, which no longer need to be installed as part of the final package.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Removed code to read user agent sheets from disk. Replaced with code that gets them from compiled-in arrays instead. Uses a pretty lame DOMString hack that could be reworked some day. (WebCore::CSSStyleSelector::loadDefaultStyle): Change to load from arrays intead of disk.
  • css/html4.css: Added missing license header, tweaked format a bit.
  • css/quirks.css: Added missing license header, tweaked format.
  • css/svg.css: Moved from ksvg2/css directory.
  • ksvg2/css/svg.css: Moved to top level css directory.
  • page/Frame.cpp: Removed includes of qfile.h and kstandarddirs.h.
  • ForwardingHeaders/kstandarddirs.h: Removed.
  • ForwardingHeaders/qfile.h: Removed.
  • kwq/KWQFile.h: Removed.
  • kwq/KWQFile.mm: Removed.
  • kwq/KWQKStandardDirs.h: Removed.
  • kwq/KWQKStandardDirs.mm: Removed.

Jan 17, 2006:

10:41 PM Changeset in webkit [12166] by darin
  • 8 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

  • Remove the now-unused KRenderingPaintServerImage[Quartz].
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
  • kcanvas/device/KRenderingPaintServerImage.h: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • kwq/KWQPainter.mm:
10:16 PM Changeset in webkit [12165] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • bridge/mac/MacFrame.mm: (MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled. (MacFrame::windowScriptObject): Return 0 if JavaScript is disabled. (MacFrame::windowScriptNPObject): Ditto. (MacFrame::partClearedInBegin): Don't call the "window script object available" call if JavaScript is disabled.
9:55 PM Changeset in webkit [12164] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin


Layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclink

9:53 PM Changeset in webkit [12163] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclinks.html


Layout test added:

  • editing/selection/after-line-wrap.html
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): Don't stop at the first candidate, it may be visually equivalent to the original position.
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): Don't move to a position on a different line. (DOM::Position::downstream): Ditto.
8:33 PM Changeset in webkit [12162] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/HashTable.h: (KXMLCore::addIterator): Added. Helper function that adds an iterator to the list maintained by the specified hash table. (KXMLCore::removeIterator): Added. Helper function that removes an iterator from the list maintained by the hash table it's in. (KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable parameter, ignored when not debugging. Call addIterator. (KXMLCore::HashTableConstIterator::~HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator=): Call removeIterator. (KXMLCore::HashTableConstIterator::operator*): Call checkValidity. (KXMLCore::HashTableConstIterator::operator->): Ditto. (KXMLCore::HashTableConstIterator::operator++): Ditto. (KXMLCore::HashTableConstIterator::operator==): Ditto. (KXMLCore::HashTableConstIterator::operator!=): Ditto. (KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table pointer is not 0 and if there are two iterators that both point at the same table. (KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator as an implementation detail, to avoid having two separate iterator implementations. (KXMLCore::HashTableIterator::operator*): Ditto. (KXMLCore::HashTableIterator::operator->): Ditto. (KXMLCore::HashTableIterator::operator++): Ditto. (KXMLCore::HashTableIterator::operator==): Ditto. (KXMLCore::HashTableIterator::operator!=): Ditto. (KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list. (KXMLCore::HashTable::~HashTable): Added call to invalidateIterators. (KXMLCore::HashTable::makeIterator): Pass this pointer. (KXMLCore::HashTable::makeConstIterator): Ditto. (KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public entry point that modifies the hash table. (KXMLCore::HashTable::remove): Ditto. (KXMLCore::HashTable::clear): Ditto. (KXMLCore::HashTable::swap): Ditto. (KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and clears out the table, next, and previous pointers in all of them, and then clears the head so we have an empty list. (KXMLCore::addIterator): Added. Adds the iterator the the linked list in the passed-in table, and points the iterator at the table. (KXMLCore::removeIterator): Added. Removes the iterator from the linked list in the passed-in table.
  • kxmlcore/HashTraits.h: A bit of tweaking and formatting.
8:16 PM Changeset in webkit [12161] by justing
  • 7 edits in trunk

Deployment builds now use -O2

5:33 PM Changeset in webkit [12160] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects

The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.

5:18 PM Changeset in webkit [12159] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for <rdar://problem/4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232

3:56 PM Changeset in webkit [12158] by thatcher
  • 269 adds in trunk/WebKitSite

Moving the webkit.opendarwin.org site into our Subversion repository.

2:49 PM Changeset in webkit [12157] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix group path for rendering in project file.

2:46 PM Changeset in webkit [12156] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage caused by my partial commit.

1:07 PM Changeset in webkit [12155] by hyatt
  • 2 edits
    63 copies
    1 add
    1 delete in trunk/WebCore

Move khtml/rendering to WebCore/rendering.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/rendering: Removed.
  • khtml/rendering/DataRef.h: Removed.
  • khtml/rendering/InlineTextBox.cpp: Removed.
  • khtml/rendering/InlineTextBox.h: Removed.
  • khtml/rendering/RenderText.cpp: Removed.
  • khtml/rendering/RenderText.h: Removed.
  • khtml/rendering/RenderTextFragment.cpp: Removed.
  • khtml/rendering/RenderTextFragment.h: Removed.
  • khtml/rendering/bidi.cpp: Removed.
  • khtml/rendering/bidi.h: Removed.
  • khtml/rendering/break_lines.cpp: Removed.
  • khtml/rendering/break_lines.h: Removed.
  • khtml/rendering/font.cpp: Removed.
  • khtml/rendering/font.h: Removed.
  • khtml/rendering/render_applet.cpp: Removed.
  • khtml/rendering/render_applet.h: Removed.
  • khtml/rendering/render_arena.cpp: Removed.
  • khtml/rendering/render_arena.h: Removed.
  • khtml/rendering/render_block.cpp: Removed.
  • khtml/rendering/render_block.h: Removed.
  • khtml/rendering/render_box.cpp: Removed.
  • khtml/rendering/render_box.h: Removed.
  • khtml/rendering/render_br.cpp: Removed.
  • khtml/rendering/render_br.h: Removed.
  • khtml/rendering/render_button.cpp: Removed.
  • khtml/rendering/render_button.h: Removed.
  • khtml/rendering/render_canvas.cpp: Removed.
  • khtml/rendering/render_canvas.h: Removed.
  • khtml/rendering/render_canvasimage.cpp: Removed.
  • khtml/rendering/render_canvasimage.h: Removed.
  • khtml/rendering/render_container.cpp: Removed.
  • khtml/rendering/render_container.h: Removed.
  • khtml/rendering/render_flexbox.cpp: Removed.
  • khtml/rendering/render_flexbox.h: Removed.
  • khtml/rendering/render_flow.cpp: Removed.
  • khtml/rendering/render_flow.h: Removed.
  • khtml/rendering/render_form.cpp: Removed.
  • khtml/rendering/render_form.h: Removed.
  • khtml/rendering/render_frames.cpp: Removed.
  • khtml/rendering/render_frames.h: Removed.
  • khtml/rendering/render_image.cpp: Removed.
  • khtml/rendering/render_image.h: Removed.
  • khtml/rendering/render_inline.cpp: Removed.
  • khtml/rendering/render_inline.h: Removed.
  • khtml/rendering/render_layer.cpp: Removed.
  • khtml/rendering/render_layer.h: Removed.
  • khtml/rendering/render_line.cpp: Removed.
  • khtml/rendering/render_line.h: Removed.
  • khtml/rendering/render_list.cpp: Removed.
  • khtml/rendering/render_list.h: Removed.
  • khtml/rendering/render_object.cpp: Removed.
  • khtml/rendering/render_object.h: Removed.
  • khtml/rendering/render_replaced.cpp: Removed.
  • khtml/rendering/render_replaced.h: Removed.
  • khtml/rendering/render_style.cpp: Removed.
  • khtml/rendering/render_style.h: Removed.
  • khtml/rendering/render_table.cpp: Removed.
  • khtml/rendering/render_table.h: Removed.
  • khtml/rendering/render_theme.cpp: Removed.
  • khtml/rendering/render_theme.h: Removed.
  • khtml/rendering/render_theme_mac.h: Removed.
  • khtml/rendering/render_theme_mac.mm: Removed.
  • khtml/rendering/table_layout.cpp: Removed.
  • khtml/rendering/table_layout.h: Removed.
  • rendering: Added.
  • rendering/DataRef.h: Added.
  • rendering/InlineTextBox.cpp: Added.
  • rendering/InlineTextBox.h: Added.
  • rendering/RenderText.cpp: Added.
  • rendering/RenderText.h: Added.
  • rendering/RenderTextFragment.cpp: Added.
  • rendering/RenderTextFragment.h: Added.
  • rendering/bidi.cpp: Added.
  • rendering/bidi.h: Added.
  • rendering/break_lines.cpp: Added.
  • rendering/break_lines.h: Added.
  • rendering/font.cpp: Added.
  • rendering/font.h: Added.
  • rendering/render_applet.cpp: Added.
  • rendering/render_applet.h: Added.
  • rendering/render_arena.cpp: Added.
  • rendering/render_arena.h: Added.
  • rendering/render_block.cpp: Added.
  • rendering/render_block.h: Added.
  • rendering/render_box.cpp: Added.
  • rendering/render_box.h: Added.
  • rendering/render_br.cpp: Added.
  • rendering/render_br.h: Added.
  • rendering/render_button.cpp: Added.
  • rendering/render_button.h: Added.
  • rendering/render_canvas.cpp: Added.
  • rendering/render_canvas.h: Added.
  • rendering/render_canvasimage.cpp: Added.
  • rendering/render_canvasimage.h: Added.
  • rendering/render_container.cpp: Added.
  • rendering/render_container.h: Added.
  • rendering/render_flexbox.cpp: Added.
  • rendering/render_flexbox.h: Added.
  • rendering/render_flow.cpp: Added.
  • rendering/render_flow.h: Added.
  • rendering/render_form.cpp: Added.
  • rendering/render_form.h: Added.
  • rendering/render_frames.cpp: Added.
  • rendering/render_frames.h: Added.
  • rendering/render_image.cpp: Added.
  • rendering/render_image.h: Added.
  • rendering/render_inline.cpp: Added.
  • rendering/render_inline.h: Added.
  • rendering/render_layer.cpp: Added.
  • rendering/render_layer.h: Added.
  • rendering/render_line.cpp: Added.
  • rendering/render_line.h: Added.
  • rendering/render_list.cpp: Added.
  • rendering/render_list.h: Added.
  • rendering/render_object.cpp: Added.
  • rendering/render_object.h: Added.
  • rendering/render_replaced.cpp: Added.
  • rendering/render_replaced.h: Added.
  • rendering/render_style.cpp: Added.
  • rendering/render_style.h: Added.
  • rendering/render_table.cpp: Added.
  • rendering/render_table.h: Added.
  • rendering/render_theme.cpp: Added.
  • rendering/render_theme.h: Added.
  • rendering/render_theme_mac.h: Added.
  • rendering/render_theme_mac.mm: Added.
  • rendering/table_layout.cpp: Added.
  • rendering/table_layout.h: Added.
12:52 PM Changeset in webkit [12154] by hyatt
  • 3 edits in trunk/WebCore

Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.


Reviewed by xenon

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMAttr::getValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMAttr::):
11:40 AM Changeset in webkit [12153] by bdakin
  • 8 edits in trunk/WebCore

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`

10:14 AM Changeset in webkit [12152] by ap
  • 21 edits in trunk/WebCore

Patch by Duncan Wilcox, reviewed by Darin.

This patch replaces the use of SelectionController with Selection in the edit commands.

It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.

9:35 AM Changeset in webkit [12151] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/generic-form-element-assert.html: Added.
  • fast/dom/generic-form-element-assert-expected.txt: Added.

WebCore:

Test: fast/dom/generic-form-element-assert.html

Reviewed and reworked by Darin.


  • khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces a bit. Removed unneeded includes. (WebCore::findRoot): Added helper function. (WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check in a simpler way, since the two separate cases amounted to the same check.
9:29 AM Changeset in webkit [12150] by darin
  • 2 edits in trunk/JavaScriptCore/kxmlcore

Updated copyright dates (oops, forgot).

9:28 AM Changeset in webkit [12149] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/PassRefPtr.h: Always set m_ptr before calling deref.
  • kxmlcore/RefPtr.h: Ditto.
1:00 AM Changeset in webkit [12148] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

Fix second part of WebCore-no-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Mark three headers as private rather than project in the WebCore-no-SVG target.

Jan 16, 2006:

11:39 PM Changeset in webkit [12147] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by hyatt

  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Assign the new item to index m_count, not m_size.
10:53 PM Changeset in webkit [12146] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

WebCore-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new files omitted from the target.
10:50 PM Changeset in webkit [12145] by eseidel
  • 2 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Fixed test case to remove invisible chars (thus fixing test).

  • svg/custom/recursive-clippath.svg:
9:41 PM Changeset in webkit [12144] by hyatt
  • 19 edits
    25 copies
    1 add
    2 deletes in trunk/WebCore

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

  • ForwardingHeaders/kdom/css: Removed.
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
  • ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
  • ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
  • WebCore+SVG/RGBColorImpl.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • css: Added.
  • css/css_base.cpp: Added.
  • css/css_base.h: Added.
  • css/css_computedstyle.cpp: Added.
  • css/css_computedstyle.h: Added.
  • css/css_grammar.y: Added.
  • css/css_ruleimpl.cpp: Added.
  • css/css_ruleimpl.h: Added.
  • css/css_stylesheetimpl.cpp: Added.
  • css/css_stylesheetimpl.h: Added.
  • css/css_valueimpl.cpp: Added.
  • css/css_valueimpl.h: Added.
  • css/csshelper.cpp: Added.
  • css/csshelper.h: Added.
  • css/cssparser.cpp: Added.
  • css/cssparser.h: Added.
  • css/cssproperties.in: Added.
  • css/cssstyleselector.cpp: Added.
  • css/cssstyleselector.h: Added.
  • css/cssvalues.in: Added.
  • css/html4.css: Added.
  • css/makeprop: Added.
  • css/maketokenizer: Added.
  • css/makevalues: Added.
  • css/quirks.css: Added.
  • css/tokenizer.flex: Added.
  • khtml/css: Removed.
  • khtml/css/css_base.cpp: Removed.
  • khtml/css/css_base.h: Removed.
  • khtml/css/css_computedstyle.cpp: Removed.
  • khtml/css/css_computedstyle.h: Removed.
  • khtml/css/css_grammar.y: Removed.
  • khtml/css/css_ruleimpl.cpp: Removed.
  • khtml/css/css_ruleimpl.h: Removed.
  • khtml/css/css_stylesheetimpl.cpp: Removed.
  • khtml/css/css_stylesheetimpl.h: Removed.
  • khtml/css/css_valueimpl.cpp: Removed.
  • khtml/css/css_valueimpl.h: Removed.
  • khtml/css/csshelper.cpp: Removed.
  • khtml/css/csshelper.h: Removed.
  • khtml/css/cssparser.cpp: Removed.
  • khtml/css/cssparser.h: Removed.
  • khtml/css/cssproperties.in: Removed.
  • khtml/css/cssstyleselector.cpp: Removed.
  • khtml/css/cssstyleselector.h: Removed.
  • khtml/css/cssvalues.in: Removed.
  • khtml/css/html4.css: Removed.
  • khtml/css/makeprop: Removed.
  • khtml/css/maketokenizer: Removed.
  • khtml/css/makevalues: Removed.
  • khtml/css/quirks.css: Removed.
  • khtml/css/tokenizer.flex: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGMaskElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
9:41 PM Changeset in webkit [12143] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):
6:37 PM Changeset in webkit [12142] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

  • svg/custom/recursive-clippath-expected.checksum: Added.
  • svg/custom/recursive-clippath-expected.png: Added.
  • svg/custom/recursive-clippath-expected.txt: Added.
  • svg/custom/recursive-clippath.svg: Added.
6:20 PM Changeset in webkit [12141] by ggaren
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

  • fast/js/date-proto-generic-invocation-expected.txt: Added.
  • fast/js/date-proto-generic-invocation.html: Added.
  • fast/js/resources/date-proto-generic-invocation.js: Added.
4:35 PM Changeset in webkit [12140] by hyatt
  • 2 edits
    22 moves
    3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bindings: Added.
  • bindings/js: Added.
  • bindings/objc: Added.
  • bindings/objc/DOM.h: Added.
  • bindings/objc/DOM.mm: Added.
  • bindings/objc/DOMCSS.h: Added.
  • bindings/objc/DOMCSS.mm: Added.
  • bindings/objc/DOMCore.h: Added.
  • bindings/objc/DOMEvents.h: Added.
  • bindings/objc/DOMEvents.mm: Added.
  • bindings/objc/DOMEventsInternal.h: Added.
  • bindings/objc/DOMExtensions.h: Added.
  • bindings/objc/DOMHTML.h: Added.
  • bindings/objc/DOMHTML.mm: Added.
  • bindings/objc/DOMHTMLInternal.h: Added.
  • bindings/objc/DOMInternal.h: Added.
  • bindings/objc/DOMInternal.mm: Added.
  • bindings/objc/DOMPrivate.h: Added.
  • bindings/objc/DOMRange.h: Added.
  • bindings/objc/DOMStylesheets.h: Added.
  • bindings/objc/DOMTraversal.h: Added.
  • bindings/objc/DOMUtility.mm: Added.
  • bindings/objc/DOMViews.h: Added.
  • bindings/objc/DOMViews.mm: Added.
  • bindings/objc/DOMViewsInternal.h: Added.
  • kwq/DOM-CSS.mm: Removed.
  • kwq/DOM.h: Removed.
  • kwq/DOM.mm: Removed.
  • kwq/DOMCSS.h: Removed.
  • kwq/DOMCore.h: Removed.
  • kwq/DOMEvents.h: Removed.
  • kwq/DOMEvents.mm: Removed.
  • kwq/DOMEventsInternal.h: Removed.
  • kwq/DOMExtensions.h: Removed.
  • kwq/DOMHTML.h: Removed.
  • kwq/DOMHTML.mm: Removed.
  • kwq/DOMHTMLInternal.h: Removed.
  • kwq/DOMInternal.h: Removed.
  • kwq/DOMInternal.mm: Removed.
  • kwq/DOMPrivate.h: Removed.
  • kwq/DOMRange.h: Removed.
  • kwq/DOMStylesheets.h: Removed.
  • kwq/DOMTraversal.h: Removed.
  • kwq/DOMUtility.mm: Removed.
  • kwq/DOMViews.h: Removed.
  • kwq/DOMViews.mm: Removed.
  • kwq/DOMViewsInternal.h: Removed.
3:43 PM Changeset in webkit [12139] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca
  • 4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.


  • WebInspector.subproj/webInspector/inspector.css:
  • WebInspector.subproj/webInspector/inspector.html:
  • WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.
2:25 PM Changeset in webkit [12137] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley.


  • fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
2:01 PM Changeset in webkit [12136] by ap
  • 4 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

  • khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
  • manual-tests/bugzilla-6473.html: Added.
1:46 PM Changeset in webkit [12135] by ap
  • 2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.
12:34 PM Changeset in webkit [12134] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Justin.

Test: editing/input/wrapped-line-char-rect.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start
12:25 PM Changeset in webkit [12133] by justing
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

  • editing/selection/replaced-boundaries-1-expected.checksum: Added.
  • editing/selection/replaced-boundaries-1-expected.png: Added.
  • editing/selection/replaced-boundaries-1-expected.txt: Added.
  • editing/selection/replaced-boundaries-1.html: Added.
  • editing/selection/replaced-boundaries-2-expected.checksum: Added.
  • editing/selection/replaced-boundaries-2-expected.png: Added.
  • editing/selection/replaced-boundaries-2-expected.txt: Added.
  • editing/selection/replaced-boundaries-2.html: Added.
  • editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • editing/selection/replaced-boundaries-3-expected.png: Added.
  • editing/selection/replaced-boundaries-3-expected.txt: Added.
  • editing/selection/replaced-boundaries-3.html: Added.
12:24 PM Changeset in webkit [12132] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)


Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
  • khtml/rendering/render_replaced.h:
12:04 PM Changeset in webkit [12131] by tomernic
  • 7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • actually removed QPtrDict itself
  • ForwardingHeaders/qptrdict.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
  • kwq/KWQPtrDict.h: Removed.
  • kwq/KWQPtrDictImpl.cpp: Removed.
  • kwq/KWQPtrDictImpl.h: Removed.
9:52 AM Changeset in webkit [12129] by darin
  • 83 edits in trunk/WebCore

Reviewed by John Sullivan.

  • removed all uses of QPtrDict, most uses of QMap
  • khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
  • khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
  • khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
  • khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
  • khtml/ecma/kjs_window.h: Use HashMap.
  • khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
  • khtml/ecma/xmlhttprequest.h: Ditto.
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
  • khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
  • khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
  • khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
  • khtml/xml/dom_elementimpl.h: Use HashMap.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
  • khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.
  • khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
  • khtml/xml/dom_stringimpl.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
  • kcanvas/RenderForeignObject.cpp: Ditto.
  • kcanvas/RenderForeignObject.h: Ditto.
  • kcanvas/RenderSVGImage.h: Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
  • khtml/css/css_ruleimpl.cpp: Ditto.
  • khtml/css/css_valueimpl.h: Ditto.
  • khtml/ecma/kjs_dom.h: Ditto.
  • khtml/ecma/kjs_html.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Ditto.
  • khtml/editing/delete_selection_command.cpp: Ditto.
  • khtml/html/html_tableimpl.cpp: Ditto.
  • khtml/khtml_events.cpp: Ditto.
  • khtml/rendering/RenderText.cpp: Ditto.
  • khtml/rendering/render_block.cpp: Ditto.
  • khtml/rendering/render_br.cpp: Ditto.
  • khtml/rendering/render_inline.cpp: Ditto.
  • khtml/rendering/render_object.cpp: Ditto.
  • khtml/rendering/render_replaced.cpp: Ditto.
  • khtml/xml/dom2_rangeimpl.cpp: Ditto.
  • kwq/DOM.mm: Ditto.
  • page/Frame.cpp: Ditto.
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
  • kcanvas/RenderSVGText.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
  • khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
  • khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.
  • khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
  • khtml/xml/dom_xmlimpl.h: Ditto.
  • ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
  • ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
  • ksvg2/svg/SVGPointImpl.cpp: Ditto.
  • kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.
  • kwq/KWQPainter.h: Added newly-needed include.
  • kwq/KWQPtrVector.h: Added append function.
  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
  • kwq/KWQVectorImpl.h: Added append.
  • kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.
  • kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
  • kwq/KWQWMatrix.h: Ditto.
  • loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.
  • loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
  • loader/CachedCSSStyleSheet.h: Ditto.
  • loader/CachedImage.cpp: Ditto.
  • loader/CachedImage.h: Ditto.
  • loader/CachedImageCallback.cpp: Ditto.
  • loader/CachedObject.cpp: Ditto.
  • loader/CachedObject.h: Ditto.
  • loader/CachedObjectClient.h: Ditto.
  • loader/CachedObjectClientWalker.cpp: Ditto.
  • loader/CachedObjectClientWalker.h: Ditto.
  • loader/CachedScript.cpp: Ditto.
  • loader/CachedScript.h: Ditto.
  • loader/CachedXSLStyleSheet.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
  • loader/loader.h: Ditto.
1:03 AM Changeset in webkit [12128] by eseidel
  • 5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

  • fast/box-sizing/percentage-height-expected.checksum:
  • fast/box-sizing/percentage-height-expected.png:
  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
12:49 AM Changeset in webkit [12127] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.
12:30 AM Changeset in webkit [12126] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.
12:05 AM Changeset in webkit [12125] by andersca
  • 2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.

Jan 15, 2006:

11:50 PM Changeset in webkit [12124] by eseidel
  • 3 edits in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Update out-of-date pixel results.

  • fast/dom/dom-parse-serialize-expected.checksum:
  • fast/dom/dom-parse-serialize-expected.png:
6:45 PM Changeset in webkit [12123] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
6:42 PM Changeset in webkit [12122] by thatcher
  • 24 edits
    38 adds in trunk

WebCore:

Reviewed by Darin.

Support for the new DOM Inspector.

  • khtml/ecma/kjs_dom.cpp: exposes scrollIntoViewIfNeeded to JS
  • khtml/ecma/kjs_dom.h:
  • khtml/rendering/RenderText.cpp: (RenderText::lineBoxRects): returns text run rects
  • khtml/rendering/RenderText.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::lineBoxRects): returns all child line box rects
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_object.cpp: (RenderObject::lineBoxRects): returns an empty list
  • khtml/rendering/render_object.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoViewIfNeeded): scrolls only if needed, bool decides to center to align to nearest edge
  • khtml/xml/dom_elementimpl.h: Ditto
  • kwq/DOM.mm: (-[DOMNode boundingBox]): returns the bounding box for a node (-[DOMNode lineBoxRects]): returns text runs for a node
  • kwq/DOMCore.h: added missing @protocol DOMEventListener and @class DOMEvent
  • kwq/DOMExtensions.h: removes methods that haven't been API reviewed
  • kwq/DOMPrivate.h: new pending public API added for the Inspector

WebKit:

Reviewed by Darin.


New DOM Inspector that lives in WebKit and is accessible from any WebView.
Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.


To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6571

5:29 PM Changeset in webkit [12121] by darin
  • 21 edits
    1 move in trunk/WebCore

Reviewed by Eric.

  • changed WebCore namespace change to work on Win32 as well as Mac OS X
  • WebCorePrefix.h: Removed things needed cross-platform.
  • config.h: Moved from khtml subdirectory. Added defines from WebCorePrefix.h, and added a define that makes KSVG a synonym for WebCore.
  • khtml/config.h: Removed.
  • khtml/css/css_grammar.y: Changed SVG functions to use function name rather than namespace to avoid collision with the XML and HTML DOM. Changes tabs to spaces.
  • khtml/css/css_valueimpl.cpp: (WebCore::propertyID): Add SVG properties ot the ones understood here. This allows us to set SVG properties from JavaScript.
  • ksvg2/scripts/cssmakeprops: Put functions inside the namespace to avoid compiler warning, and renamed functions to include CSS and SVG.
  • ksvg2/scripts/cssmakevalues: Ditto.
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::parseMappedAttribute): Use property ID function by its new name.
  • ksvg2/ksvg.h: Renamed ExceptionCode to SVGExceptionCode.
  • khtml/ecma/XSLTProcessor.cpp: Moved "config.h" header up above the ifdef so that the ifdef works.
  • khtml/xbl/xbl_binding.cpp: Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Ditto.
  • khtml/xbl/xbl_docimpl.cpp: Ditto.
  • khtml/xbl/xbl_protobinding.cpp: Ditto.
  • khtml/xbl/xbl_tokenizer.cpp: Ditto.
  • khtml/xsl/xsl_stylesheetimpl.cpp: Ditto.
  • khtml/xsl/xslt_processorimpl.cpp: Ditto.
  • loader/CachedXBLDocument.cpp: Ditto.
  • ksvg2/svg/SVGFELightElementImpl.h: Removed include of "config.h". That's supposed to only be included by code files, not headers.
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added missing include of "config.h". Did a few other tweaks to the file.
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp: Ditto.
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp: Ditto.
4:38 PM Changeset in webkit [12120] by eseidel
  • 19 edits in trunk/WebCore

2006-01-15 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Updated files w/ missing copyrights from Oliver.

  • kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel:
  • kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKPointLightFilter.cikernel:
  • kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel:
  • ksvg2/svg/SVGAnimatedColorImpl.cpp:
  • ksvg2/svg/SVGAnimatedColorImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEDistantLightElementImpl.cpp:
  • ksvg2/svg/SVGFEDistantLightElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEPointLightElementImpl.cpp:
  • ksvg2/svg/SVGFEPointLightElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFESpotLightElementImpl.cpp:
  • ksvg2/svg/SVGFESpotLightElementImpl.h:
3:37 PM Changeset in webkit [12119] by darin
  • 2 adds in trunk/WebCore/khtml/editing

Oops, didn't check in these two files!

3:32 PM Changeset in webkit [12118] by darin
  • 23 edits in trunk/WebCore

Reviewed and tweaked a bit by Darin.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=6523>
"Extract data from SelectionController"

This patch refactors the data portions of SelectionController into its
own class, "Selection".

The extracted data are the base/extent/start/end positions and cursor
affinity. Also a couple cached values generated by validation are kept around
in the new class.

This patch does away with all the different affinities
(start/end/base/extent) that were never implemented properly, since affinity
only makes sense when the selection is a caret (as per discussion with mjs and
darin on #webkit).

No test cases added because this is a refactoring.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::respondToChangedSelection):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionState]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge selectionAffinity]): (-[WebCoreFrameBridge setMarkDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
  • khtml/editing/Selection.cpp: Added. (khtml::Selection::Selection): (khtml::Selection::clear): (khtml::Selection::toRange): (khtml::Selection::validate): (khtml::Selection::adjustForEditableContent): (khtml::Selection::debugPosition):
  • khtml/editing/Selection.h: Added. (khtml::Selection::): (khtml::Selection::state): (khtml::Selection::setAffinity): (khtml::Selection::affinity): (khtml::Selection::setBase): (khtml::Selection::setExtent): (khtml::Selection::setStart): (khtml::Selection::setEnd): (khtml::Selection::base): (khtml::Selection::extent): (khtml::Selection::start): (khtml::Selection::end): (khtml::Selection::isNone): (khtml::Selection::isCaret): (khtml::Selection::isRange): (khtml::Selection::isCaretOrRange): (khtml::Selection::isBaseFirst): (khtml::operator==): (khtml::operator!=):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::operator=): (khtml::SelectionController::moveTo): (khtml::SelectionController::setModifyBias): (khtml::SelectionController::modifyExtendingRightForward): (khtml::SelectionController::modifyMovingRightForward): (khtml::SelectionController::modifyExtendingLeftBackward): (khtml::SelectionController::modifyMovingLeftBackward): (khtml::SelectionController::modify): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::xPosForVerticalArrowNavigation): (khtml::SelectionController::clear): (khtml::SelectionController::setBase): (khtml::SelectionController::setExtent): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::frame): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::needsCaretRepaint): (khtml::SelectionController::paintCaret): (khtml::SelectionController::debugRenderer): (khtml::SelectionController::formatForDebugger): (khtml::SelectionController::showTree):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::state): (khtml::SelectionController::affinity): (khtml::SelectionController::base): (khtml::SelectionController::extent): (khtml::SelectionController::start): (khtml::SelectionController::end): (khtml::SelectionController::isNone): (khtml::SelectionController::isCaret): (khtml::SelectionController::isRange): (khtml::SelectionController::isCaretOrRange): (khtml::SelectionController::toRange): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::operator==):
  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::updateStartEnd):
  • khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::doApply):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::doApply):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::markMisspellingsAfterTyping):
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::updateSelection):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]):
  • kwq/KWQRenderTreeDebug.cpp: (writeSelection):
  • page/Frame.cpp: (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::revealSelection): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart):


  • <a few other files, including editing ones>: Added includes since Selection.h and SelectionController.h now include fewer things.
2:38 PM Changeset in webkit [12117] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-overflow-selection.html


Reviewed by Darin.

  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): Clip selection rect to the text box (khtml::InlineTextBox::paintSelection): Clip selection painting to the text box.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): Remove code that re-added border width, since it is already included in availableWidth.
1:52 PM Changeset in webkit [12116] by darin
  • 16 edits in trunk/WebCore

Reviewed by Anders.

  • fix regression in duplicate ID layout test
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::getElementById): Change to take AtomicString, so we can use the string pointer as a hash key and not worry about ref'ing the pointer or about object lifetime since the string will be stored for the lifetime of the ID attribute. Also update for the counted set formerly named m_idCount to use its new name, m_duplicateIds. (DocumentImpl::addElementById): Ditto. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::recalcStyleSelector): Pass a DOMStringImpl* (see below).
  • khtml/xml/DocumentImpl.h: Change functions to take AtomicString.
  • kcanvas/KCanvasFilters.cpp: (getFilterById): Use AtomicString.
  • kcanvas/KCanvasFilters.h: Ditto.
  • kcanvas/KCanvasResources.cpp: (getResourceById): Ditto. (getMarkerById): Ditto. (getClipperById): Ditto. (getMaskerById): Ditto. (getPaintServerById): Ditto.
  • kcanvas/KCanvasResources.h: Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): Ditto.
  • khtml/html/HTMLLabelElementImpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Ditto.
  • khtml/xml/NodeListImpl.cpp: (DOM::NodeListImpl::itemById): Ditto.
  • khtml/xml/NodeListImpl.h: Ditto. Also removed unnecessary "virtual".
  • khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheetList::nameGetter): Pass a DOMStringImpl*, which gets converted to an AtomicString implicitly, rather than a DOMString, which does not. (But that's a crazy rule -- we should change this around long term.) (KJS::DOMStyleSheetList::getOwnPropertySlot): Ditto.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::nameGetter): Ditto. (KJS::DOMNodeList::getOwnPropertySlot): Ditto. (KJS::DOMDocumentProtoFunc::callAsFunction): Ditto.
  • Merge khtml, DOM, and KDOM into one big namespace, WebCore.
  • WebCorePrefix.h: Use defined to map the old namespace names to WebCore. Now that this is done in the prefix, we can start actually calling it by that name, phase out the old names, then remove the defines.
  • other changes
  • khtml/xml/DocumentTypeImpl.cpp: Converted tabs to spaces.
  • khtml/xml/dom2_eventsimpl.cpp: Ditto.
12:04 PM Changeset in webkit [12115] by andersca
  • 18 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Remove KCanvasCommonArgs and pass around RenderPath objects instead.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTypes.h: Removed.
  • kcanvas/device/KRenderingDevice.cpp:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerImageQuartz::draw):
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGPatternElementImpl.h:
7:14 AM Changeset in webkit [12114] by darin
  • 22 edits
    5 deletes in trunk/WebCore

Reviewed by Hyatt.

I ran performance tests and the change results in a slight improvement.

  • bridge/mac/MacFrame.h: Removed include of KWQDict.h. Changed didTellBridgeAboutLoad and haveToldBridgeAboutLoad functions to take DOMString instead of QString. Changed urlsBridgeKnowsAbout from a QDict to a HashMap.
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad): Updated to use QDict and DOMString. (MacFrame::haveToldBridgeAboutLoad): Ditto.
  • khtml/editing/jsediting.h: Removed include of qdict.h.
  • khtml/rendering/render_frames.cpp: Removed include of qdict.h. Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. (khtml::RenderPartObject::updateWidget): Changed the local variable uniqueParamNames to be a HashSet instead of a QDict.
  • khtml/xml/DocumentImpl.h: Removed include of qdict.h, changed m_elementsById, m_idCount, and m_elementsByAccessKey to use HashMap and HashCountedSet instead of QDict.
  • khtml/xml/DocumentImpl.cpp: Changed tabs to spaces. (DocumentImpl::getElementById): Updated to use HashMap for m_elementsById and HashCountedSet for m_idCount. (DocumentImpl::addElementById): Ditto. Remove code to clear m_accessKeyDictValid, since setDocumentChanged already takes care of that. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Updated to use HashMap for m_elementsByAccessKey. (DocumentImpl::setDocumentChanged): Rearranged to do a couple fewer branches. Clear out the m_elementsByAccessKey map when clearing m_accessKeyMapValid to avoid keeping stale pointers around.
  • ksvg2/svg/SVGDocumentImpl.cpp: Removed include of q3dict.h.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed obsolete QDict sources.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • ForwardingHeaders/q3dict.h: Removed.
  • ForwardingHeaders/qdict.h: Removed.
  • kwq/KWQDict.h: Removed.
  • kwq/KWQDictImpl.cpp: Removed.
  • kwq/KWQDictImpl.h: Removed.
  • WebCore+SVG/SVGNamesWrapper.cpp: Touched this file just so I could build again.
  • kwq/KWQKURL.h: Removed unused canonicalURL, _path, _user, _pass, and _host functions.
  • kwq/KWQKURL.mm: Changed tabs to spaces, removed unused functions, replaced NULL with 0.
  • kwq/KWQLoader.mm: Changed tabs to spaces. (KWQServeRequest): Removed QString conversion from call to didTellBridgeAboutLoad. (KWQServeSynchronousRequest): Ditto. (KWQCheckCacheObjectStatus): Ditto. Same for haveToldBridgeAboutLoad.
  • loader/Cache.h: Removed include of qdict.h. Changed declaration of the LRUList struct to just be a forward declaration. Changed tabs to spaces. Removed the static data member called "cache". Added a static member function called get. Renamed removeCacheEntry to remove.
  • loader/Cache.cpp: Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. Changed the main cache itself to a HashMap and made it a static variable local to this file instead of a static data member of Cache to hide its type from the header. Also made the LRUList type private to this file. (khtml::Cache::init): Create a HashMap instead of a QDict. (khtml::Cache::clear): To replace the use of setAutoDelete, write a loop to delete all the items in the cache map. (khtml::Cache::requestImage): Change code to use HashMap functions instead of QDict. (khtml::Cache::requestStyleSheet): Ditto. (khtml::Cache::preloadStyleSheet): Ditto. (khtml::Cache::requestScript): Ditto. (khtml::Cache::preloadScript): Ditto. (khtml::Cache::requestXSLStyleSheet): Ditto. (khtml::Cache::requestXBLDocument): Ditto. (khtml::Cache::removeCacheEntry): Ditto. (khtml::Cache::FastLog2): Fixed this for 64-bit compiles. (khtml::Cache::getStatistics): Ditto. (khtml::Cache::flushAll): Ditto. (khtml::Cache::get): Added. Function used by the loader.
  • loader/CachedObject.h: Removed include of qdict.h.
  • loader/DocLoader.h: Removed include of qdict.h.
  • loader/DocLoader.cpp: (khtml::DocLoader::needReload): Changed to use new get function of Cache instead of getting at the map directly. Also changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImage.cpp: (khtml::CachedImage::data): Changed call to removeCacheEntry to remove because it was renamed.
  • loader/CachedImageCallback.cpp: (khtml::CachedImageCallback::handleError): Ditto.
  • loader/loader.cpp: (khtml::Loader::slotFinished): Ditto. (khtml::Loader::cancelRequests): Ditto.
6:39 AM Changeset in webkit [12113] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • JavaScriptCore/tests/mozilla/Getopt/Mixed.pm: Changed revision number to 1.8 (broken by svn migration).
4:28 AM Changeset in webkit [12112] by eseidel
  • 1 edit
    1 move in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until results can be consistent:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Added.
4:03 AM Changeset in webkit [12111] by eseidel
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2006-01-15 Eric Seidel <​eseidel@apple.com>

Disabling broken test until timezone bug is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6547

  • fast/js/kde/Date-expected.txt: Removed.
  • fast/js/kde/Date.html: Removed.
  • fast/js/kde/Date.html-disabled: Added.
3:48 AM Changeset in webkit [12110] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-14 David Kilzer <​ddkilzer@kilzer.net>

Reviewed and landed by Anders.

  • kjs/create_hash_table: Fixed comment typo.
3:47 AM Changeset in webkit [12109] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<mask> inside <defs> crashes Safari.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
2:47 AM Changeset in webkit [12108] by eseidel
  • 39 edits in trunk

2006-01-15 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add basic <tspan> support using RenderInline.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6428
Also fix <text transform=""> while we're at it.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6552

  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::parseMappedAttribute): code cleanup
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::parseMappedAttribute): cleanup
  • ksvg2/svg/SVGTSpanElementImpl.cpp: (SVGTSpanElementImpl::childShouldCreateRenderer): added. (SVGTSpanElementImpl::createRenderer): added.
  • ksvg2/svg/SVGTSpanElementImpl.h: (KSVG::SVGTSpanElementImpl::rendererIsNeeded): added.
  • ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::transform): added. (SVGTextElementImpl::localMatrix): added. (SVGTextElementImpl::parseMappedAttribute): support transform. (SVGTextElementImpl::updateLocalTransform): added. (SVGTextElementImpl::attach): added. (SVGTextElementImpl::childShouldCreateRenderer): allow tspan.
  • ksvg2/svg/SVGTextElementImpl.h:
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute): code cleanup.
  • ksvg2/svg/SVGTransformableImpl.h:

Jan 14, 2006:

11:56 PM Changeset in webkit [12107] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Append an '=' to the cookie string if it has none, so that +[NSHTTPCookie cookiesWithResponseHeaderFields:forURL:] can parse it.
11:32 PM Changeset in webkit [12106] by hyatt
  • 3 edits
    2 moves
    1 delete in trunk/WebCore

Move arena.cpp/.h out of khtml/misc and into platform/Arena.cpp/h. Also removed another unused
header, khtmldata.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/misc/arena.cpp: Removed.
  • khtml/misc/arena.h: Removed.
  • khtml/misc/khtmldata.h: Removed.
  • khtml/rendering/render_arena.h:
  • platform/Arena.cpp: Added.
  • platform/Arena.h: Added.
11:12 PM Changeset in webkit [12105] by hyatt
  • 6 edits
    2 moves in trunk/WebCore

Rename TokenizerString to SegmentedString and place it in the platform directory.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::setSrc):
  • khtml/html/htmltokenizer.h:
  • khtml/misc/stringit.cpp: Removed.
  • khtml/misc/stringit.h: Removed.
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::write):
  • khtml/xml/xml_tokenizer.h:
  • platform/SegmentedString.cpp: Added. (WebCore::SegmentedString::length): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString):
  • platform/SegmentedString.h: Added. (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedString::SegmentedString):
10:09 PM Changeset in webkit [12104] by mjs
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Eric.

  • added bridging infrastructure for Page class


The Page class itself is coming very soon.

  • WebCore.exp: Export WebCorePageBridge.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCorePageBridge.h: Added.
  • bridge/mac/WebCorePageBridge.mm: Added. (-[WebCorePageBridge initWithMainFrame:]): Added new class, obvious (-[WebCorePageBridge dealloc]): ditto (-[WebCorePageBridge mainFrame]): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge init]): Fixed style a bit.

WebKit:

Reviewed by Eric.

  • added bridging infrastructure for Page class


  • WebCoreSupport.subproj/WebPageBridge.h: Added.
  • WebCoreSupport.subproj/WebPageBridge.m: Added. (-[WebPageBridge initWithMainFrameName:view:]): New class, somewhat obvious.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): Don't use _mainFrameBrige, use _pageBridge (-[WebView _close]): ditto (-[WebView _commonInitializationWithFrameName:groupName:]): ditto (-[WebView mainFrame]): ditto
9:43 PM Changeset in webkit [12103] by eseidel
  • 15 edits
    23 adds in trunk

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Implement basic <foreignObject> support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5974
Also fixed <image> to support clip, filter and mask
Updated <text> to support hit testing and clip, filter, mask

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/RenderForeignObject.cpp: Added. (RenderForeignObject::RenderForeignObject): (RenderForeignObject::translationForAttributes): (RenderForeignObject::paint): (RenderForeignObject::nodeAtPoint):
  • kcanvas/RenderForeignObject.h: Added. (RenderForeignObject::renderName): added. (RenderForeignObject::localTransform): added. (RenderForeignObject::setLocalTransform): added.
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): added filter, clip mask support
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::localTransform): added. (KSVG::RenderSVGImage::setLocalTransform): added.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::translationTopToBaseline): return qmatrix (RenderSVGText::translationForAttributes): return qmatrix (RenderSVGText::paint): added filter, clip, mask support (RenderSVGText::nodeAtPoint): added.
  • kcanvas/RenderSVGText.h: (RenderSVGText::localTransform): added. (RenderSVGText::setLocalTransform): added.
  • khtml/rendering/render_object.h: (khtml::RenderObject::setLocalTransform): added assert(0)
  • ksvg2/css/svg.css: added foreignObject display: block
  • ksvg2/svg/SVGForeignObjectElementImpl.cpp: Added. (KSVG::SVGForeignObjectElementImpl::SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::~SVGForeignObjectElementImpl): (KSVG::SVGForeignObjectElementImpl::x): (KSVG::SVGForeignObjectElementImpl::y): (KSVG::SVGForeignObjectElementImpl::width): (KSVG::SVGForeignObjectElementImpl::height): (KSVG::SVGForeignObjectElementImpl::parseMappedAttribute): (KSVG::SVGForeignObjectElementImpl::createRenderer): (KSVG::SVGForeignObjectElementImpl::childShouldCreateRenderer):
  • ksvg2/svg/SVGForeignObjectElementImpl.h: Added. (KSVG::SVGForeignObjectElementImpl::isValid): added (KSVG::SVGForeignObjectElementImpl::rendererIsNeeded): added
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach): fixed static_cast
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::nearestViewportElement): foreignObject support (SVGLocatableImpl::farthestViewportElement): foreignObject support
  • ksvg2/svg/svgtags.in: added foreignObject
  • kwq/KWQWMatrix.cpp: (QWMatrix::isInvertible): fixed
8:55 PM Changeset in webkit [12102] by hyatt
  • 4 edits in trunk/WebCore

More khtml namespace bustage, this time on Win32 (caused by the removal of SHared from the khtml namespace.

8:48 PM Changeset in webkit [12101] by hyatt
  • 80 edits
    1 move
    1 delete in trunk/WebCore

Move shared.h from khtml/misc into the platform directory and move it into the WebCore namespace.

Reviewed by eseidel

  • ForwardingHeaders/kdom/Shared.h: Removed.
  • WebCore+SVG/DOMList.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/RGBColorImpl.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/htmlediting.h:
  • khtml/editing/visible_position.h:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/misc/shared.h: Removed.
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_style.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeListImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::SVGAngleImpl):
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimatedBooleanImpl.cpp: (SVGAnimatedBooleanImpl::SVGAnimatedBooleanImpl):
  • ksvg2/svg/SVGAnimatedBooleanImpl.h:
  • ksvg2/svg/SVGAnimatedEnumerationImpl.cpp: (SVGAnimatedEnumerationImpl::SVGAnimatedEnumerationImpl):
  • ksvg2/svg/SVGAnimatedEnumerationImpl.h:
  • ksvg2/svg/SVGAnimatedIntegerImpl.cpp: (SVGAnimatedIntegerImpl::SVGAnimatedIntegerImpl):
  • ksvg2/svg/SVGAnimatedIntegerImpl.h:
  • ksvg2/svg/SVGAnimatedLengthListImpl.h:
  • ksvg2/svg/SVGAnimatedNumberImpl.cpp: (SVGAnimatedNumberImpl::SVGAnimatedNumberImpl):
  • ksvg2/svg/SVGAnimatedNumberImpl.h:
  • ksvg2/svg/SVGAnimatedNumberListImpl.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimatedTransformListImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::SVGLengthImpl):
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl):
  • ksvg2/svg/SVGMatrixImpl.h:
  • ksvg2/svg/SVGNumberImpl.cpp: (SVGNumberImpl::SVGNumberImpl):
  • ksvg2/svg/SVGNumberImpl.h:
  • ksvg2/svg/SVGPathSegImpl.cpp: (SVGPathSegImpl::SVGPathSegImpl):
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
  • ksvg2/svg/SVGPointImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
  • ksvg2/svg/SVGPreserveAspectRatioImpl.h:
  • ksvg2/svg/SVGRectImpl.cpp: (SVGRectImpl::SVGRectImpl):
  • ksvg2/svg/SVGRectImpl.h:
  • ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl):
  • ksvg2/svg/SVGTransformImpl.h:
  • kwq/DOM-CSS.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate):
  • kwq/KWQVariant.cpp:
  • platform/ArrayImpl.h:
  • platform/Shared.h: Added.
7:33 PM Changeset in webkit [12100] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Fix build break. (oops!)

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
7:29 PM Changeset in webkit [12099] by eseidel
  • 2 edits in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Initialize m_isXHTMLDocument(false) properly.
No tests possible, random failure only.

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer):
6:57 PM Changeset in webkit [12098] by eseidel
  • 4 edits in trunk/WebCore

2006-01-15 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for svg css property writing-mode.

  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::InheritedFlags::): (KSVG::SVGRenderStyle::setBitDefaults):
  • ksvg2/css/SVGRenderStyleDefs.h: (KSVG::):
6:42 PM Changeset in webkit [12097] by eseidel
  • 13 edits in trunk/WebCore

2006-01-14 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Refactor out cases of KCanvasRenderingStyle used as an instance to
store the current style. Temporarily unify the data passing via
KCanvasCommonArgs.

  • kcanvas/KCanvasItem.cpp: Removing override of setStyle used to hook into KCanvasRenderingStyle::updateStyle. (RenderPath::commonArgs):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::KCanvasCommonArgs): (KCanvasCommonArgs::renderStyle): (KCanvasCommonArgs::setRenderStyle): (KCanvasCommonArgs::renderPath): (KCanvasCommonArgs::setRenderPath):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): (KCanvasItemQuartz::bboxForPath): (KCanvasItemQuartz::hitsPath):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: Remove overrideFillPaintServer and overrideStrokePaintServer hacks and make most other methods static, remove most instance variables. (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::isFilled): (KCanvasRenderingStyle::fillPaintServer): (KCanvasRenderingStyle::isStroked): (KCanvasRenderingStyle::strokePaintServer): (KCanvasRenderingStyle::strokePainter): Merged stroke logic in from updateStyle. (KCanvasRenderingStyle::fillPainter): Merged fill logic in from updateStyle.
  • ksvg2/misc/KCanvasRenderingStyle.h:
6:39 PM Changeset in webkit [12096] by hyatt
  • 1 edit in trunk/WebCore/ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h

Fix mac bustage from kdom forwarding header.

6:38 PM Changeset in webkit [12095] by hyatt
  • 2 edits in trunk/WebCore

Fix win32 build bustage caused by the file moves all day.

6:38 PM Changeset in webkit [12094] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage caused by the file moves all day.

6:31 PM Changeset in webkit [12093] by eseidel
  • 1 edit
    4 moves
    12 deletes in trunk/LayoutTests

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Disabling text-intro* tests until font fallback is fixed:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6524

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Added.
6:15 PM Changeset in webkit [12092] by hyatt
  • 14 edits
    1 move in trunk/WebCore

Move loader_client.h to CachedObjectClient.h.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_html.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/rendering/render_object.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xsl_stylesheetimpl.h:
  • loader/CachedObject.h:
  • loader/CachedObjectClient.h: Added.
  • loader/CachedObjectClientWalker.h:
  • loader/loader_client.h: Removed.
6:13 PM Changeset in webkit [12091] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

6:09 PM Changeset in webkit [12090] by andersca
  • 9 edits
    8 deletes in trunk/WebCore

2006-01-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Dave.

  • ForwardingHeaders/kglobalsettings.h: Removed.
  • ForwardingHeaders/kimageio.h: Removed.
  • ForwardingHeaders/qasyncio.h: Removed.
  • ForwardingHeaders/qstylesheet.h: Removed.
  • kwq/KWQAsyncIO.h: Removed.
  • kwq/KWQKGlobalSettings.h: Removed.
  • kwq/KWQKImageIO.h: Removed.
  • kwq/KWQStyleSheet.h: Removed.


  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::recalcStyle):
  • loader/CachedImageCallback.cpp:
  • loader/CachedObject.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp: (KHTMLView::KHTMLView): Remove header inclusions


5:16 PM Changeset in webkit [12089] by hyatt
  • 64 edits
    25 moves
    1 add in trunk/WebCore

Shift the loader-related files out of the khtml/misc directory and into a new loader directory.
Remove the use of paths when including files from misc.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasPath.h:
  • khtml/css/css_base.h:
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssparser.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.h:
  • khtml/editing/edit_command.h:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/HTMLOptionsCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_canvasimpl.h:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.h:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/Cache.cpp: Removed.
  • khtml/misc/Cache.h: Removed.
  • khtml/misc/CachedCSSStyleSheet.cpp: Removed.
  • khtml/misc/CachedCSSStyleSheet.h: Removed.
  • khtml/misc/CachedImage.cpp: Removed.
  • khtml/misc/CachedImage.h: Removed.
  • khtml/misc/CachedImageCallback.cpp: Removed.
  • khtml/misc/CachedImageCallback.h: Removed.
  • khtml/misc/CachedObject.cpp: Removed.
  • khtml/misc/CachedObject.h: Removed.
  • khtml/misc/CachedObjectClientWalker.cpp: Removed.
  • khtml/misc/CachedObjectClientWalker.h: Removed.
  • khtml/misc/CachedScript.cpp: Removed.
  • khtml/misc/CachedScript.h: Removed.
  • khtml/misc/CachedXBLDocument.cpp: Removed.
  • khtml/misc/CachedXBLDocument.h: Removed.
  • khtml/misc/CachedXSLStyleSheet.cpp: Removed.
  • khtml/misc/CachedXSLStyleSheet.h: Removed.
  • khtml/misc/DocLoader.cpp: Removed.
  • khtml/misc/DocLoader.h: Removed.
  • khtml/misc/Request.cpp: Removed.
  • khtml/misc/Request.h: Removed.
  • khtml/misc/loader.cpp: Removed.
  • khtml/misc/loader.h: Removed.
  • khtml/misc/loader_client.h: Removed.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvasimage.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_list.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.h:
  • khtml/xbl/xbl_binding.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQMapImpl.cpp:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQValueListImpl.cpp:
  • kwq/KWQVariant.cpp:
  • loader: Added.
  • loader/Cache.cpp: Added.
  • loader/Cache.h: Added.
  • loader/CachedCSSStyleSheet.cpp: Added.
  • loader/CachedCSSStyleSheet.h: Added.
  • loader/CachedImage.cpp: Added.
  • loader/CachedImage.h: Added.
  • loader/CachedImageCallback.cpp: Added.
  • loader/CachedImageCallback.h: Added.
  • loader/CachedObject.cpp: Added.
  • loader/CachedObject.h: Added.
  • loader/CachedObjectClientWalker.cpp: Added.
  • loader/CachedObjectClientWalker.h: Added.
  • loader/CachedScript.cpp: Added.
  • loader/CachedScript.h: Added.
  • loader/CachedXBLDocument.cpp: Added.
  • loader/CachedXBLDocument.h: Added.
  • loader/CachedXSLStyleSheet.cpp: Added.
  • loader/CachedXSLStyleSheet.h: Added.
  • loader/DocLoader.cpp: Added.
  • loader/DocLoader.h: Added.
  • loader/Request.cpp: Added.
  • loader/Request.h: Added.
  • loader/loader.cpp: Added.
  • loader/loader.h: Added.
  • loader/loader_client.h: Added.
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • page/FrameView.cpp:
5:12 PM Changeset in webkit [12088] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Missed ChangeLog in previous commit.

5:10 PM Changeset in webkit [12087] by eseidel
  • 55 edits
    9 copies
    2 moves
    1 delete in trunk/WebCore

2006-01-14 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

break classes in dom_nodeimpl.* into separate files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6543

  • ForwardingHeaders/kdom/core/NodeImpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/css/css_base.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/remove_node_attribute_command.h:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/set_node_attribute_command.h:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_text.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/khtml_events.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp:
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_object.h:
  • khtml/xml/ChildNodeListImpl.cpp: Added.
  • khtml/xml/ChildNodeListImpl.h: Added.
  • khtml/xml/ContainerNodeImpl.cpp: Added. (DOM::ContainerNodeImpl::removeAllChildren): (DOM::ContainerNodeImpl::checkSameDocument): (DOM::ContainerNodeImpl::getRect): (DOM::ContainerNodeImpl::dispatchChildRemovalEvents):
  • khtml/xml/ContainerNodeImpl.h: Added.
  • khtml/xml/DocumentFragmentImpl.cpp:
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/DocumentImpl.h: (DOM::DocumentImpl::setTextColor):
  • khtml/xml/DocumentTypeImpl.cpp:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/NameNodeListImpl.cpp: Added.
  • khtml/xml/NameNodeListImpl.h: Added.
  • khtml/xml/NamedNodeMapImpl.h: Added. (DOM::NamedNodeMapImpl::NamedNodeMapImpl): (DOM::NamedNodeMapImpl::~NamedNodeMapImpl):
  • khtml/xml/NodeImpl.cpp: Added. (DOM::TagNodeListImpl::TagNodeListImpl): (DOM::TagNodeListImpl::length): (DOM::TagNodeListImpl::item): (DOM::TagNodeListImpl::nodeMatches): (DOM::NodeImpl::getRect):
  • khtml/xml/NodeImpl.h: Added.
  • khtml/xml/NodeListImpl.cpp: Added.
  • khtml/xml/NodeListImpl.h: Added.
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Removed.
  • khtml/xml/dom_nodeimpl.h: Removed.
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • kwq/DOM.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMUtility.mm:
  • kwq/KWQClipboard.h:
  • page/FrameView.cpp:
3:29 PM Changeset in webkit [12086] by hyatt
  • 35 edits
    3 moves
    1 delete in trunk/WebCore

Convert QMemArray to Array. QByteArray becomes ByteArray.
KWQArrayImpl becomes ArrayImpl.

Reviewed by anders

  • ForwardingHeaders/qmemarray.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequest::processSyncLoadResults):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/html/HTMLOptionElementImpl.cpp: (DOM::HTMLOptionElementImpl::index):
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::selectedIndex): (DOM::HTMLSelectElementImpl::setSelectedIndex): (DOM::HTMLSelectElementImpl::length): (DOM::HTMLSelectElementImpl::remove): (DOM::HTMLSelectElementImpl::value): (DOM::HTMLSelectElementImpl::setValue): (DOM::HTMLSelectElementImpl::state): (DOM::HTMLSelectElementImpl::restoreState): (DOM::HTMLSelectElementImpl::appendFormData): (DOM::HTMLSelectElementImpl::optionToListIndex): (DOM::HTMLSelectElementImpl::listToOptionIndex): (DOM::HTMLSelectElementImpl::reset): (DOM::HTMLSelectElementImpl::notifyOptionSelected):
  • khtml/html/HTMLSelectElementImpl.h: (DOM::HTMLSelectElementImpl::listItems):
  • khtml/misc/formdata.cpp: (khtml::FormData::flatten): (khtml::FormData::flattenToString):
  • khtml/misc/formdata.h: (khtml::FormDataElement::FormDataElement):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderSelect::slotSelected): (RenderSelect::slotSelectionChanged): (RenderSelect::updateSelection):
  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): (RenderTableSection::setCellWidths):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):
  • khtml/rendering/table_layout.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQArrayImpl.cpp: Removed.
  • kwq/KWQArrayImpl.h: Removed.
  • kwq/KWQBuffer.cpp: (QBuffer::setBuffer):
  • kwq/KWQBuffer.h: (QBuffer::QBuffer): (QBuffer::buffer):
  • kwq/KWQCString.cpp: (QCString::QCString): (QCString::resize): (QCString::append):
  • kwq/KWQCString.h:
  • kwq/KWQKURL.mm: (findHostnamesInMailToURL): (encodeHostnames):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
  • kwq/KWQMemArray.h: Removed.
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::receivedData):
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (QString::QString):
  • kwq/KWQTextCodec.cpp: (QTextCodec::toUnicode):
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.cpp: (QTextStream::QTextStream):
  • kwq/KWQTextStream.h:
  • page/Frame.h:
  • platform/Array.h: Added. (WebCore::Array::Array): (WebCore::Array::duplicate): (WebCore::Array::assign): (WebCore::Array::operator==): (WebCore::Array::operator!=):
  • platform/ArrayImpl.cpp: Added. (WebCore::ArrayImpl::ArrayPrivate::ArrayPrivate): (WebCore::ArrayImpl::ArrayPrivate::~ArrayPrivate): (WebCore::ArrayImpl::ArrayImpl): (WebCore::ArrayImpl::~ArrayImpl): (WebCore::ArrayImpl::operator=): (WebCore::ArrayImpl::data): (WebCore::ArrayImpl::resize): (WebCore::ArrayImpl::duplicate): (WebCore::ArrayImpl::detach): (WebCore::ArrayImpl::fill): (WebCore::ArrayImpl::operator==):
  • platform/ArrayImpl.h: Added. (WebCore::ArrayImpl::size):
  • platform/IntPointArray.cpp: (IntPointArray::setPoint):
  • platform/IntPointArray.h: (WebCore::IntPointArray::IntPointArray):
2:07 PM Changeset in webkit [12085] by hyatt
  • 124 edits
    4 moves
    2 adds
    1 delete in trunk/WebCore

Convert QRect/QRectF -> IntRect/FloatRect. Same drill as point
and size.

Reviewed by mjs

  • ForwardingHeaders/qrect.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::snapshotDragImage): (MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:withPainter:]): (-[WebCoreFrameBridge firstRectForDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]):
  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::relativeBBox): (KCanvasContainer::getAspectRatio):
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.cpp: (KCanvasFilterEffect::subRegion): (KCanvasFilterEffect::setSubRegion):
  • kcanvas/KCanvasFilters.h: (KCanvasFilter::filterRect): (KCanvasFilter::setFilterRect):
  • kcanvas/KCanvasItem.cpp: (RenderPath::relativeBBox):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (KRenderingPaintServerPattern::setBbox): (KRenderingPaintServerPattern::bbox):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (drawMarkerWithData): (KCanvasItemQuartz::drawMarkersIfNeeded): (KCanvasItemQuartz::bboxForPath):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::layout): (KCanvasContainerQuartz::paint): (KCanvasContainerQuartz::setViewport): (KCanvasContainerQuartz::viewport): (KCanvasContainerQuartz::setViewBox): (KCanvasContainerQuartz::viewBox): (KCanvasContainerQuartz::absoluteTransform): (KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::mapFromVisual): (KRenderingDeviceContextQuartz::mapToVisual):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::caretY): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::caretRepaintRect): (khtml::SelectionController::paintCaret):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::getRect):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isFocusable):
  • khtml/misc/CachedImage.cpp: (khtml::CachedImage::valid_rect): (khtml::CachedImage::do_notify): (khtml::CachedImage::error):
  • khtml/misc/CachedImage.h:
  • khtml/misc/khtmllayout.h: (khtml::GapRects::left): (khtml::GapRects::center): (khtml::GapRects::right): (khtml::GapRects::uniteLeft): (khtml::GapRects::uniteCenter): (khtml::GapRects::uniteRight): (khtml::GapRects::operator IntRect):
  • khtml/misc/loader_client.h: (khtml::CachedObjectClient::setPixmap):
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): (khtml::InlineTextBox::nodeAtPoint):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/RenderText.cpp: (khtml::RenderText::absoluteRects): (khtml::RenderText::caretRect): (khtml::RenderText::getAbsoluteRepaintRect): (khtml::RenderText::selectionRect):
  • khtml/rendering/RenderText.h:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/font.cpp: (khtml::Font::selectionRectForText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::overflowRect): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::getAbsoluteRepaintRectIncludingFloats): (khtml::RenderBlock::paint): (khtml::RenderBlock::fillHorizontalSelectionGap): (khtml::RenderBlock::fillVerticalSelectionGap): (khtml::RenderBlock::fillLeftSelectionGap): (khtml::RenderBlock::fillRightSelectionGap): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_block.h: (khtml::RenderBlock::selectionRect):
  • khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgroundExtended): (RenderBox::getOverflowClipRect): (RenderBox::getClipRect): (RenderBox::getAbsoluteRepaintRect): (RenderBox::computeAbsoluteRepaintRect): (RenderBox::caretRect):
  • khtml/rendering/render_box.h: (khtml::RenderBox::borderBox):
  • khtml/rendering/render_br.cpp: (khtml::RenderBR::caretRect):
  • khtml/rendering/render_br.h: (khtml::RenderBR::selectionRect):
  • khtml/rendering/render_button.cpp: (khtml::RenderButton::paintObject):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::repaintViewRectangle): (RenderCanvas::getAbsoluteRepaintRect): (RenderCanvas::computeAbsoluteRepaintRect): (RenderCanvas::absoluteRects): (RenderCanvas::selectionRect): (RenderCanvas::viewRect):
  • khtml/rendering/render_canvas.h: (khtml::RenderCanvas::printRect): (khtml::RenderCanvas::setPrintRect):
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint): (RenderCanvasImage::layout):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock):
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect): (RenderFlow::caretRect): (RenderFlow::paintOutlines): (RenderFlow::paintOutlineForLine):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
  • khtml/rendering/render_image.cpp: (RenderImage::setImage): (RenderImage::setPixmap): (RenderImage::paint): (RenderImage::layout):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::updateLayerPositions): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::getRectToExpose): (khtml::RenderLayer::positionScrollbars): (khtml::RenderLayer::updateScrollInfoAfterLayout): (khtml::RenderLayer::paintScrollbars): (khtml::RenderLayer::paint): (khtml::setClip): (khtml::restoreClip): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTest): (khtml::RenderLayer::hitTestLayer): (khtml::RenderLayer::calculateClipRects): (khtml::RenderLayer::calculateRects): (khtml::mustExamineRenderer): (khtml::RenderLayer::intersectsDamageRect): (khtml::RenderLayer::containsPoint):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::m_refCnt): (khtml::ClipRects::overflowClipRect): (khtml::ClipRects::fixedClipRect): (khtml::ClipRects::posClipRect): (khtml::RenderLayer::repaintRect):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::canAccommodateEllipsis): (khtml::InlineFlowBox::nodeAtPoint): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder): (khtml::EllipsisBox::nodeAtPoint):
  • khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::setPixmap):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorderImage): (RenderObject::paintBorder): (RenderObject::absoluteRects): (RenderObject::absoluteBoundingBoxRect): (RenderObject::addAbsoluteRectForLayer): (RenderObject::paintingRootRect): (RenderObject::repaintRectangle): (RenderObject::repaintAfterLayoutIfNeeded): (RenderObject::getAbsoluteRepaintRectWithOutline): (RenderObject::getAbsoluteRepaintRect): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::computeAbsoluteRepaintRect): (RenderObject::viewRect): (RenderObject::caretRect): (RenderObject::addDashboardRegions): (RenderObject::setPixmap):
  • khtml/rendering/render_object.h: (khtml::RenderObject::getOverflowClipRect): (khtml::RenderObject::getClipRect): (khtml::RenderObject::relativeBBox): (khtml::RenderObject::PaintInfo::PaintInfo): (khtml::RenderObject::RepaintInfo::m_repaintRect): (khtml::RenderObject::borderBox): (khtml::RenderObject::overflowRect): (khtml::RenderObject::floatRect): (khtml::RenderObject::selectionRect): (khtml::RenderObject::SelectionInfo::rect):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::selectionRect): (RenderWidget::paint): (RenderWidget::updateWidgetPosition):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableRow::getAbsoluteRepaintRect): (RenderTableCell::computeAbsoluteRepaintRect): (RenderTableCell::getAbsoluteRepaintRect): (RenderTableCell::paintBoxDecorations):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint):
  • khtml/rendering/render_theme.h: (khtml::RenderTheme::adjustRepaintRect):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustRepaintRect): (khtml::RenderThemeMac::inflateRect): (khtml::RenderThemeMac::paintCheckbox): (khtml::RenderThemeMac::setCheckboxCellState): (khtml::RenderThemeMac::paintRadio): (khtml::RenderThemeMac::setRadioCellState): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::getRect): (DOM::ContainerNodeImpl::getRect):
  • khtml/xml/dom_nodeimpl.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::createRenderer):
  • kwq/KWQAccObject.mm: (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject doAXBoundsForTextMarkerRange:]):
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): (QDesktopWidget::availableGeometry):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::selectionRectForText): (QFontMetrics::boundingRect):
  • kwq/KWQKWinModule.h:
  • kwq/KWQKWinModule.mm: (KWinModule::workArea):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::xForm): (QPainter::drawPixmap): (QPainter::fillRect): (QPainter::addClip): (QPainter::addRoundedRectClip):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::setAnimationRect): (QPixmap::rect):
  • kwq/KWQRect.h: Removed.
  • kwq/KWQRect.mm: Removed.
  • kwq/KWQRectF.h: Removed.
  • kwq/KWQRectF.mm: Removed.
  • kwq/KWQRegion.cpp: (QRegion::QRegion): (QRegion::boundingRect):
  • kwq/KWQRegion.h:
  • kwq/KWQRenderTreeDebug.cpp: (operator<<): (write): (writeLayers): (externalRepresentation):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::updateContents):
  • kwq/KWQWMatrix.cpp: (QWMatrix::mapRect):
  • kwq/KWQWMatrix.h:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::resize): (QWidget::move): (QWidget::frameGeometry): (QWidget::setFrameGeometry): (QWidget::paint):
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): (KWQWindowWidget::setFrameGeometry):
  • page/Frame.cpp: (Frame::gotoAnchor): (Frame::paintCaret): (Frame::paintDragCaret): (Frame::selectionRect): (Frame::revealSelection): (Frame::paint): (Frame::adjustPageHeight): (Frame::centerSelectionInVisibleArea):
  • page/Frame.h:
  • page/FrameView.cpp: (KHTMLView::addRepaintInfo): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::repaintRectangle):
  • page/FrameView.h:
  • platform/FloatRect.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::isNull): (WebCore::FloatRect::isValid): (WebCore::FloatRect::isEmpty): (WebCore::FloatRect::right): (WebCore::FloatRect::bottom): (WebCore::FloatRect::topLeft): (WebCore::FloatRect::topRight): (WebCore::FloatRect::bottomRight): (WebCore::FloatRect::bottomLeft): (WebCore::FloatRect::size): (WebCore::FloatRect::unite): (WebCore::FloatRect::normalize): (WebCore::FloatRect::intersects): (WebCore::FloatRect::intersect): (WebCore::FloatRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/FloatRect.h: Added. (WebCore::FloatRect::contains): (WebCore::FloatRect::operator&): (WebCore::enclosingIntRect):
  • platform/IntPointArray.cpp: (IntPointArray::IntPointArray): (IntPointArray::boundingRect):
  • platform/IntPointArray.h:
  • platform/IntRect.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::isNull): (WebCore::IntRect::isValid): (WebCore::IntRect::isEmpty): (WebCore::IntRect::right): (WebCore::IntRect::bottom): (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::size): (WebCore::IntRect::unite): (WebCore::IntRect::normalize): (WebCore::IntRect::intersects): (WebCore::IntRect::intersect): (WebCore::IntRect::inflate): (WebCore::operator==): (WebCore::operator!=):
  • platform/IntRect.h: Added. (WebCore::IntRect::contains): (WebCore::IntRect::operator&):
  • platform/mac/FloatRect.mm: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator NSRect): (WebCore::FloatRect::operator CGRect):
  • platform/mac/IntRect.mm: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator NSRect): (WebCore::IntRect::operator CGRect):
Note: See TracTimeline for information about the timeline view.