Timeline



Feb 15, 2006:

10:34 PM Changeset in webkit [12840] by ggaren
  • 18 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • bindings/jni/jni_instance.cpp: Made _instance a RefPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref):
  • bindings/jni/jni_runtime.cpp: Made _array a RefPtr (JavaArray::~JavaArray): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=):
  • bindings/objc/objc_runtime.h:
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject):
  • bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
  • bindings/runtime_object.h:
  • Removed ownsInstance data member because RefPtr takes care of instance lifetime now.
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Eric.

  • Layout test for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()
  • plugins: Added.
  • plugins/undefined-property-crash-expected.txt: Added.
  • plugins/undefined-property-crash.html: Added.

WebCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a RefPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a RefPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made objectInstance a RefPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach):
  • bindings/js/JSDOMCore.cpp:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/html/html_objectimpl.h:

WebKitTools:

Reviewed by Eric.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): Added a dummy method for the sake of LayoutTests/plugins/ undefined-property-crash.html. (It tests a crash due to fallback object use. WebCore won't create a fallback object if the method is not defined.)
10:11 PM Changeset in webkit [12839] by thatcher
  • 47 edits
    31 adds
    10 deletes in trunk/WebKitSite

Reviewed by Tim H.

Updated the site to use the new layout.

  • .htaccess: Added.
  • ChangeLog:
  • blog/wp-content/themes/classic: Removed.
  • blog/wp-content/themes/classic/comments-popup.php: Removed.
  • blog/wp-content/themes/classic/comments.php: Removed.
  • blog/wp-content/themes/classic/footer.php: Removed.
  • blog/wp-content/themes/classic/header.php: Removed.
  • blog/wp-content/themes/classic/index.php: Removed.
  • blog/wp-content/themes/classic/sidebar.php: Removed.
  • blog/wp-content/themes/classic/style.css: Removed.
  • blog/wp-content/themes/default: Removed.
  • blog/wp-content/themes/default/404.php: Removed.
  • blog/wp-content/themes/default/archive.php: Removed.
  • blog/wp-content/themes/default/archives.php: Removed.
  • blog/wp-content/themes/default/comments-popup.php: Removed.
  • blog/wp-content/themes/default/comments.php: Removed.
  • blog/wp-content/themes/default/footer.php: Removed.
  • blog/wp-content/themes/default/header.php: Removed.
  • blog/wp-content/themes/default/images: Removed.
  • blog/wp-content/themes/default/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/default/index.php: Removed.
  • blog/wp-content/themes/default/links.php: Removed.
  • blog/wp-content/themes/default/page.php: Removed.
  • blog/wp-content/themes/default/search.php: Removed.
  • blog/wp-content/themes/default/searchform.php: Removed.
  • blog/wp-content/themes/default/sidebar.php: Removed.
  • blog/wp-content/themes/default/single.php: Removed.
  • blog/wp-content/themes/default/style.css: Removed.
  • blog/wp-content/themes/webkit/404.php:
  • blog/wp-content/themes/webkit/archive.php:
  • blog/wp-content/themes/webkit/archives.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
  • blog/wp-content/themes/webkit/images: Removed.
  • blog/wp-content/themes/webkit/images/bluebanner.png: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/webkit/images/separator.png: Removed.
  • blog/wp-content/themes/webkit/images/webkit-background.png: Removed.
  • blog/wp-content/themes/webkit/index.php:
  • blog/wp-content/themes/webkit/page.php:
  • blog/wp-content/themes/webkit/search.php:
  • blog/wp-content/themes/webkit/sidebar.php:
  • blog/wp-content/themes/webkit/single.php:
  • blog/wp-content/themes/webkit/style.css:
  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • css: Added.
  • css/blue.css: Added.
  • css/gray.css: Added.
  • css/green.css: Added.
  • css/ie.css: Added.
  • css/main.css: Added.
  • css/pink.css: Added.
  • css/purple.css: Added.
  • css/yellow.css: Added.
  • footer.inc: Added.
  • header.inc: Added.
  • images/blue-background.png: Added.
  • images/blue-bullet.png: Added.
  • images/bluebanner.png: Removed.
  • images/download.png: Added.
  • images/end.png: Added.
  • images/gray-background.png: Added.
  • images/green-background.png: Added.
  • images/green-bullet.png: Added.
  • images/icon-gold.png: Added.
  • images/icon.png: Added.
  • images/ie-nav.png: Added.
  • images/middle.png: Added.
  • images/nav.png: Added.
  • images/pink-background.png: Added.
  • images/pink-bullet.png: Added.
  • images/purple-background.png: Added.
  • images/purple-bullet.png: Added.
  • images/separator.png: Removed.
  • images/webkit-background.png: Removed.
  • images/welcomeopen.gif: Removed.
  • images/yellow-background.png: Added.
  • images/yellow-bullet.png: Added.
  • index.html:
  • nav.inc: Added.
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/bugzilla.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • sidebar.css: Removed.
  • sidebar.html: Removed.
  • webkitdev.css: Removed.
8:21 PM Changeset in webkit [12838] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Add files missing from previous commit.


  • svg/custom/feDisplacementMap-01-expected.checksum: Added.
  • svg/custom/feDisplacementMap-01-expected.png: Added.
  • svg/custom/feDisplacementMap-01-expected.txt: Added.
4:19 PM Changeset in webkit [12837] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

No test case because it requires manual mouse wheeling.

  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just leaking the WheelEventImpl.
4:16 PM Changeset in webkit [12836] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by John.

  • Applied the 4330457 change to CClass and ObjcClass as well.

Once plugins work in DumpRenderTree, running run-webkit-tests --leaks
will catch this.

This change isn't as critical because CClass and ObjcClass objects get
cached globally and never deleted, but it's good practice, in case we
ever do decide to delete CClass and ObjcClass objects.

This change requires prohibiting copying, because we don't do any
intelligent ref-counting -- when a Class is destroyed, it destroys its
methods and fields unconditionally. (Java classes already prohibited
copying.)

  • bindings/c/c_class.cpp:
  • Merged _commonInit and _commonDelete into constructor and destructor. (CClass::CClass): (CClass::~CClass): (CClass::methodsNamed): Added delete callbacks (CClass::fieldNamed): Added delete callbacks
  • bindings/c/c_class.h: Prohibited copying
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getClass): Changed to use the preferred class factory method, to take advantage of the global cache.

[ Repeated changes applied to CClass for ObjcClass: ]

  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::ObjcMethod): Initialized uninitialized variable to prevent bad CFRelease. (KJS::Bindings::ObjcMethod::~ObjcMethod): Removed erroneous ';' from if statement to prevent bad CFRelease.
  • bindings/objc/objc_runtime.cpp: Changed to use the preferred ObjectStructPtr, for clarity.
3:50 PM Changeset in webkit [12835] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • Fixed <rdar://problem/4330457> CrashTracer: [REGRESSION] 3763 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance:: getClass const + 56

This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.

The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): Added delete callbacks
  • bindings/runtime.cpp: Added definitions for delete callbacks (KJS::Bindings::deleteMethodList): (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField):
  • bindings/runtime.h: Added declarations for delete callbacks
3:04 PM Changeset in webkit [12834] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

3:02 PM Changeset in webkit [12833] by thatcher
  • 2 edits in tags/WebCore-521.7.2/WebCore

Build fix.

2:58 PM Changeset in webkit [12832] by hyatt
  • 2 edits in trunk/WebCore/platform/image-decoders

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:57 PM Changeset in webkit [12831] by hyatt
  • 12 edits in trunk/WebCore

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:55 PM Changeset in webkit [12830] by thatcher
  • 1 copy in tags/WebCore-521.7.2

New tag.

2:37 PM Changeset in webkit [12829] by hyatt
  • 6 edits
    2 moves
    1 add in trunk/WebCore

Make KWQFontFamily portable. Split it out into a cross-platform core and the Mac-specific version.
Move it to platform and rename it to FontFamily (and FontFamilyMac).

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQFont.h: (QFont::firstFamily):
  • kwq/KWQFont.mm: (QFont::setFirstFamily):
  • kwq/KWQFontFamily.h: Removed.
  • kwq/KWQFontFamily.mm: Removed.
  • platform/FontFamily.cpp: Added. (WebCore::FontFamily::FontFamily): (WebCore::FontFamily::~FontFamily): (WebCore::FontFamily::operator=): (WebCore::FontFamily::setFamily): (WebCore::FontFamily::operator==):
  • platform/FontFamily.h: Added. (WebCore::FontFamily::family): (WebCore::FontFamily::familyIsEmpty): (WebCore::FontFamily::next): (WebCore::FontFamily::appendFamily): (WebCore::FontFamily::operator!=): (WebCore::FontFamily::ref): (WebCore::FontFamily::deref):
  • platform/mac/FontFamilyMac.mm: Added. (WebCore::retainDOMStringImpl): (WebCore::releaseDOMStringImpl): (WebCore::): (WebCore::FontFamily::getNSFamily):
  • rendering/font.h: (khtml::FontDef::firstFamily):
2:30 PM Changeset in webkit [12828] by thatcher
  • 3 edits in tags/WebCore-417.19.1/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
2:26 PM Changeset in webkit [12827] by thatcher
  • 1 copy in tags/WebCore-417.19.1

New tag.

1:54 PM Changeset in webkit [12826] by thatcher
  • 4 copies in tags/WebCore-417.22/WebCore

Correct tag.

1:54 PM Changeset in webkit [12825] by thatcher
  • 1 delete in tags/WebCore-417.22/WebCore

Redoing this tag.

1:48 PM Changeset in webkit [12824] by thatcher
  • 1 copy in tags/WebCore-417.22

New tag.

1:46 PM Changeset in webkit [12823] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

1:44 PM Changeset in webkit [12822] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
8:36 AM Changeset in webkit [12821] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
6:47 AM Changeset in webkit [12820] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Tim H.

Updated page to show 10.4.4 or 10.4.5
Added support for recognizing Shiira.

  • quality/reporting.html:
2:30 AM Changeset in webkit [12819] by eseidel
  • 12 edits
    8 adds in trunk

2006-02-15 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.


Implemented feDisplacementMap.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5862

Test: svg/custom/feDisplacementMap-01.svg

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEDisplacementMap::xChannelSelector): (WebCore::KCanvasFEDisplacementMap::setXChannelSelector): (WebCore::KCanvasFEDisplacementMap::yChannelSelector): (WebCore::KCanvasFEDisplacementMap::setYChannelSelector): (WebCore::KCanvasFEDisplacementMap::scale): (WebCore::KCanvasFEDisplacementMap::setScale):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added. (+[WKDisplacementMapFilter initialize]): (+[WKDisplacementMapFilter filterWithName:]): (-[WKDisplacementMapFilter init]): (-[WKDisplacementMapFilter outputImage]):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added. (SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::in1): (SVGFEDisplacementMapElementImpl::in2): (SVGFEDisplacementMapElementImpl::xChannelSelector): (SVGFEDisplacementMapElementImpl::yChannelSelector): (SVGFEDisplacementMapElementImpl::scale): (SVGFEDisplacementMapElementImpl::stringToChannel): (SVGFEDisplacementMapElementImpl::parseMappedAttribute): (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added.
  • ksvg2/svg/svgtags.in:
1:54 AM Changeset in webkit [12818] by eseidel
  • 2 edits in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Update missing result from last commit.

  • fast/xsl/xslt-recursion-expected.txt:
1:44 AM Changeset in webkit [12817] by mjs
  • 1 edit
    1 delete in trunk/WebKit

Rubber stamped by Anders.

  • WebView/WebControllerPolicyHandlerDelegate.h: Removed.
1:20 AM Changeset in webkit [12816] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • remove some voodoo code
  • WebView/WebDataSource.m: (-[WebDataSource _setLoading:]): Removed useless ref/deref of self and WebView. A WebDataSource cannot be loading unless it is still connected to the WebView that owns it and retained by it, because getting disconnected stops loading.
1:16 AM Changeset in webkit [12815] by eseidel
  • 2 edits in trunk/WebCore

2006-02-15 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Commit change forgotten after editing directory move.

  • editing/markup.cpp: (khtml::startMarkup): add support for serializing DOCTYPEs in xml

Feb 14, 2006:

9:49 PM Changeset in webkit [12814] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Maciej.

Test case: fast/encoding/percent-escaping.html

  • kwq/KWQKURL.mm: (appendEscapingBadChars): Rather than adding support for %u, remove the existing "do what I mean" escaping of percent characters that do not look like a result of prior escaping.
7:30 PM Changeset in webkit [12813] by eseidel
  • 2 edits in trunk/WebCore

2006-02-14 Eric Seidel <​eseidel@apple.com>

Fix build failure from last minute edit.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
7:01 PM Changeset in webkit [12812] by eseidel
  • 19 edits
    3 adds in trunk

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add incremental parsing support to XMLTokenizer.
This patch also does a few other little things:

  • removes (unused) onHold support from Tokenizer
  • adds serialization of DOCTYPEs for xml documents
  • fixes xslt support to no longer depend on synchronous parsing
  • fixes css styling for pages where xsl recursion is blocked ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6057
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::recalcStyleSelector):
  • dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstructionImpl::checkStyleSheet):
  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::error): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::finish): (WebCore::xmlDocPtrForString): (WebCore::parseAttributes):
  • dom/xml_tokenizer.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup): DOCTYPE serialization
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold (WebCore::HTMLTokenizer::reset): removed onHold (WebCore::HTMLTokenizer::begin): removed onHold (WebCore::HTMLTokenizer::write): removed onHold (WebCore::HTMLTokenizer::finish): removed onHold
  • khtml/html/htmltokenizer.h: removed onHold support
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::document): (WebCore::XSLStyleSheetImpl::setDocument): (WebCore::XSLStyleSheetImpl::parseString): (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::compileStyleSheet): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
  • khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file
6:55 PM Changeset in webkit [12811] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Anders.


Improvements to frame loading:


  • remove LayoutAcceptable state entirely
  • fix WebImageView to work right without LayoutAcceptable state
  • move guts of commitIfReady: to WebFrame
  • try to separate page cache loading from normal loading a bit more
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebView/WebDataSource.m: (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _startLoading]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setupForReplaceByMIMEType:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView/WebFramePrivate.h:
  • WebView/WebImageRepresentation.h:
  • WebView/WebImageRepresentation.m:
  • WebView/WebImageView.m: (-[WebImageView dataSourceUpdated:]): (-[WebImageView setNeedsLayout:]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView mouseDragged:]):
  • WebView/WebView.m: (-[WebView _finishedLoadingResourceFromDataSource:]): (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
6:35 PM Changeset in webkit [12810] by adele
  • 9 edits
    8 adds in trunk

LayoutTests:

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

  • fast/forms/input-appearance-width.html: Added.
  • fast/forms/input-appearance-width-expected.txt: Added.
  • fast/forms/input-appearance-width-expected.png: Added.
  • fast/forms/input-appearance-width-expected.checksum: Added.
  • fast/forms/input-appearance-minWidth.html: Added.
  • fast/forms/input-appearance-minWidth-expected.txt: Added.
  • fast/forms/input-appearance-minWidth-expected.png: Added.
  • fast/forms/input-appearance-minWidth-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

Tests:
fast/forms/input-appearance-width.html
fast/forms/input-appearance-minWidth.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Remove fixed width for text field. (WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and then uses the size attribute to determine what the maxWidth should be.
  • rendering/RenderTextField.h: Added calcMinMaxWidth.
  • rendering/render_theme_mac.h: Added adjustTextFieldStyle.
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary. (WebCore::RenderThemeMac::paintTextField): ditto. (WebCore::RenderThemeMac::setTextFieldCellState): change true to YES. (WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the right padding and margins. When we flip the switch, this will go in html4.css.
6:07 PM Changeset in webkit [12809] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: added --results-directory (-o) option
5:36 PM Changeset in webkit [12808] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

removed -[DOMHTMLSelectElement _optionLabels], formerly used only by Safari, now unused.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMPrivate.h:
4:15 PM Changeset in webkit [12807] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • JavaScriptCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""

WebCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • WebCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
2:42 PM Changeset in webkit [12806] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

One more of the same (this one tests list boxes instead of pop-up menus)

  • fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label05-expected.png: Added.
  • fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label05.html: Added.
2:33 PM Changeset in webkit [12805] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Added another option element label test at Dave Hyatt's suggestion

  • fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label04.html: Added.
2:14 PM Changeset in webkit [12804] by adele
  • 1 edit
    12 moves in trunk/LayoutTests

Reviewed by Eric.

Moving these tests to a better location.

  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Removed.
  • fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label01.html: Added.
  • fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label02.html: Added.
  • fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label03.html: Added.
1:40 PM Changeset in webkit [12803] by darin
  • 27 edits
    58 copies
    1 move
    58 deletes in trunk/WebCore

Rubber-stamped by Eric.

  • moved editing sources from khtml/editing to editing, and renamed files with single classes
  • WebCore.xcodeproj/project.pbxproj: Added new, removed old.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/DocumentImpl.cpp:
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_position.cpp:
  • khtml/khtml_events.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQEditCommand.mm:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_br.cpp:
  • rendering/render_inline.cpp:
  • rendering/render_object.cpp:
  • rendering/render_replaced.cpp: Fixed up includes.
  • editing: Added.
  • editing/AppendNodeCommand.cpp: Added.
  • editing/AppendNodeCommand.h: Added.
  • editing/ApplyStyleCommand.cpp: Added.
  • editing/ApplyStyleCommand.h: Added.
  • editing/BreakBlockquoteCommand.cpp: Added.
  • editing/BreakBlockquoteCommand.h: Added.
  • editing/CompositeEditCommand.cpp: Added.
  • editing/CompositeEditCommand.h: Added.
  • editing/DeleteFromTextNodeCommand.cpp: Added.
  • editing/DeleteFromTextNodeCommand.h: Added.
  • editing/DeleteSelectionCommand.cpp: Added.
  • editing/DeleteSelectionCommand.h: Added.
  • editing/EditCommand.cpp: Added.
  • editing/EditCommand.h: Added.
  • editing/InsertIntoTextNodeCommand.cpp: Added.
  • editing/InsertIntoTextNodeCommand.h: Added.
  • editing/InsertLineBreakCommand.cpp: Added.
  • editing/InsertLineBreakCommand.h: Added.
  • editing/InsertNodeBeforeCommand.cpp: Added.
  • editing/InsertNodeBeforeCommand.h: Added.
  • editing/InsertParagraphSeparatorCommand.cpp: Added.
  • editing/InsertParagraphSeparatorCommand.h: Added.
  • editing/InsertTextCommand.cpp: Added.
  • editing/InsertTextCommand.h: Added.
  • editing/JoinTextNodesCommand.cpp: Added.
  • editing/JoinTextNodesCommand.h: Added.
  • editing/MergeIdenticalElementsCommand.cpp: Added.
  • editing/MergeIdenticalElementsCommand.h: Added.
  • editing/MoveSelectionCommand.cpp: Added.
  • editing/MoveSelectionCommand.h: Added.
  • editing/RebalanceWhitespaceCommand.cpp: Added.
  • editing/RebalanceWhitespaceCommand.h: Added.
  • editing/RemoveCSSPropertyCommand.cpp: Added.
  • editing/RemoveCSSPropertyCommand.h: Added.
  • editing/RemoveNodeAttributeCommand.cpp: Added.
  • editing/RemoveNodeAttributeCommand.h: Added.
  • editing/RemoveNodeCommand.cpp: Added.
  • editing/RemoveNodeCommand.h: Added.
  • editing/RemoveNodePreservingChildrenCommand.cpp: Added.
  • editing/RemoveNodePreservingChildrenCommand.h: Added.
  • editing/ReplaceSelectionCommand.cpp: Added.
  • editing/ReplaceSelectionCommand.h: Added.
  • editing/Selection.cpp:
  • editing/SelectionController.cpp:
  • editing/SetNodeAttributeCommand.cpp: Added.
  • editing/SetNodeAttributeCommand.h: Added.
  • editing/SplitElementCommand.cpp: Added.
  • editing/SplitElementCommand.h: Added.
  • editing/SplitTextNodeCommand.cpp: Added.
  • editing/SplitTextNodeCommand.h: Added.
  • editing/SplitTextNodeContainingElementCommand.cpp: Added.
  • editing/SplitTextNodeContainingElementCommand.h: Added.
  • editing/TypingCommand.cpp: Added.
  • editing/TypingCommand.h: Added.
  • editing/VisiblePosition.cpp: Added.
  • editing/VisiblePosition.h: Added.
  • editing/VisibleRange.cpp: Added.
  • editing/VisibleRange.h: Added.
  • editing/WrapContentsInDummySpanCommand.cpp: Added.
  • editing/WrapContentsInDummySpanCommand.h: Added.
  • editing/append_node_command.cpp: Removed.
  • editing/append_node_command.h: Removed.
  • editing/apply_style_command.cpp: Removed.
  • editing/apply_style_command.h: Removed.
  • editing/break_blockquote_command.cpp: Removed.
  • editing/break_blockquote_command.h: Removed.
  • editing/composite_edit_command.cpp: Removed.
  • editing/composite_edit_command.h: Removed.
  • editing/delete_from_text_node_command.cpp: Removed.
  • editing/delete_from_text_node_command.h: Removed.
  • editing/delete_selection_command.cpp: Removed.
  • editing/delete_selection_command.h: Removed.
  • editing/edit_command.cpp: Removed.
  • editing/edit_command.h: Removed.
  • editing/htmlediting.cpp:
  • editing/insert_into_text_node_command.cpp: Removed.
  • editing/insert_into_text_node_command.h: Removed.
  • editing/insert_line_break_command.cpp: Removed.
  • editing/insert_line_break_command.h: Removed.
  • editing/insert_node_before_command.cpp: Removed.
  • editing/insert_node_before_command.h: Removed.
  • editing/insert_paragraph_separator_command.cpp: Removed.
  • editing/insert_paragraph_separator_command.h: Removed.
  • editing/insert_text_command.cpp: Removed.
  • editing/insert_text_command.h: Removed.
  • editing/join_text_nodes_command.cpp: Removed.
  • editing/join_text_nodes_command.h: Removed.
  • editing/jsediting.cpp:
  • editing/markup.cpp:
  • editing/merge_identical_elements_command.cpp: Removed.
  • editing/merge_identical_elements_command.h: Removed.
  • editing/move_selection_command.cpp: Removed.
  • editing/move_selection_command.h: Removed.
  • editing/rebalance_whitespace_command.cpp: Removed.
  • editing/rebalance_whitespace_command.h: Removed.
  • editing/remove_css_property_command.cpp: Removed.
  • editing/remove_css_property_command.h: Removed.
  • editing/remove_node_attribute_command.cpp: Removed.
  • editing/remove_node_attribute_command.h: Removed.
  • editing/remove_node_command.cpp: Removed.
  • editing/remove_node_command.h: Removed.
  • editing/remove_node_preserving_children_command.cpp: Removed.
  • editing/remove_node_preserving_children_command.h: Removed.
  • editing/replace_selection_command.cpp: Removed.
  • editing/replace_selection_command.h: Removed.
  • editing/set_node_attribute_command.cpp: Removed.
  • editing/set_node_attribute_command.h: Removed.
  • editing/split_element_command.cpp: Removed.
  • editing/split_element_command.h: Removed.
  • editing/split_text_node_command.cpp: Removed.
  • editing/split_text_node_command.h: Removed.
  • editing/split_text_node_containing_element.cpp: Removed.
  • editing/split_text_node_containing_element_command.h: Removed.
  • editing/typing_command.cpp: Removed.
  • editing/typing_command.h: Removed.
  • editing/visible_position.cpp: Removed.
  • editing/visible_position.h: Removed.
  • editing/visible_range.cpp: Removed.
  • editing/visible_range.h: Removed.
  • editing/visible_units.cpp:
  • editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • editing/wrap_contents_in_dummy_span_command.h: Removed.
  • khtml/editing: Removed.
  • khtml/editing/Selection.cpp: Removed.
  • khtml/editing/Selection.h: Removed.
  • khtml/editing/SelectionController.cpp: Removed.
  • khtml/editing/SelectionController.h: Removed.
  • khtml/editing/append_node_command.cpp: Removed.
  • khtml/editing/append_node_command.h: Removed.
  • khtml/editing/apply_style_command.cpp: Removed.
  • khtml/editing/apply_style_command.h: Removed.
  • khtml/editing/break_blockquote_command.cpp: Removed.
  • khtml/editing/break_blockquote_command.h: Removed.
  • khtml/editing/composite_edit_command.cpp: Removed.
  • khtml/editing/composite_edit_command.h: Removed.
  • khtml/editing/delete_from_text_node_command.cpp: Removed.
  • khtml/editing/delete_from_text_node_command.h: Removed.
  • khtml/editing/delete_selection_command.cpp: Removed.
  • khtml/editing/delete_selection_command.h: Removed.
  • khtml/editing/edit_actions.h: Removed.
  • khtml/editing/edit_command.cpp: Removed.
  • khtml/editing/edit_command.h: Removed.
  • khtml/editing/html_interchange.cpp: Removed.
  • khtml/editing/html_interchange.h: Removed.
  • khtml/editing/htmlediting.cpp: Removed.
  • khtml/editing/htmlediting.h: Removed.
  • khtml/editing/insert_into_text_node_command.cpp: Removed.
  • khtml/editing/insert_into_text_node_command.h: Removed.
  • khtml/editing/insert_line_break_command.cpp: Removed.
  • khtml/editing/insert_line_break_command.h: Removed.
  • khtml/editing/insert_node_before_command.cpp: Removed.
  • khtml/editing/insert_node_before_command.h: Removed.
  • khtml/editing/insert_paragraph_separator_command.cpp: Removed.
  • khtml/editing/insert_paragraph_separator_command.h: Removed.
  • khtml/editing/insert_text_command.cpp: Removed.
  • khtml/editing/insert_text_command.h: Removed.
  • khtml/editing/join_text_nodes_command.cpp: Removed.
  • khtml/editing/join_text_nodes_command.h: Removed.
  • khtml/editing/jsediting.cpp: Removed.
  • khtml/editing/jsediting.h: Removed.
  • khtml/editing/markup.cpp: Removed.
  • khtml/editing/markup.h: Removed.
  • khtml/editing/merge_identical_elements_command.cpp: Removed.
  • khtml/editing/merge_identical_elements_command.h: Removed.
  • khtml/editing/move_selection_command.cpp: Removed.
  • khtml/editing/move_selection_command.h: Removed.
  • khtml/editing/rebalance_whitespace_command.cpp: Removed.
  • khtml/editing/rebalance_whitespace_command.h: Removed.
  • khtml/editing/remove_css_property_command.cpp: Removed.
  • khtml/editing/remove_css_property_command.h: Removed.
  • khtml/editing/remove_node_attribute_command.cpp: Removed.
  • khtml/editing/remove_node_attribute_command.h: Removed.
  • khtml/editing/remove_node_command.cpp: Removed.
  • khtml/editing/remove_node_command.h: Removed.
  • khtml/editing/remove_node_preserving_children_command.cpp: Removed.
  • khtml/editing/remove_node_preserving_children_command.h: Removed.
  • khtml/editing/replace_selection_command.cpp: Removed.
  • khtml/editing/replace_selection_command.h: Removed.
  • khtml/editing/set_node_attribute_command.cpp: Removed.
  • khtml/editing/set_node_attribute_command.h: Removed.
  • khtml/editing/split_element_command.cpp: Removed.
  • khtml/editing/split_element_command.h: Removed.
  • khtml/editing/split_text_node_command.cpp: Removed.
  • khtml/editing/split_text_node_command.h: Removed.
  • khtml/editing/split_text_node_containing_element.cpp: Removed.
  • khtml/editing/split_text_node_containing_element_command.h: Removed.
  • khtml/editing/text_affinity.h: Removed.
  • khtml/editing/text_granularity.h: Removed.
  • khtml/editing/typing_command.cpp: Removed.
  • khtml/editing/typing_command.h: Removed.
  • khtml/editing/visible_position.cpp: Removed.
  • khtml/editing/visible_position.h: Removed.
  • khtml/editing/visible_range.cpp: Removed.
  • khtml/editing/visible_range.h: Removed.
  • khtml/editing/visible_text.cpp: Removed.
  • khtml/editing/visible_text.h: Removed.
  • khtml/editing/visible_units.cpp: Removed.
  • khtml/editing/visible_units.h: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.h: Removed.
1:40 PM Changeset in webkit [12802] by sullivan
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by Adele Peterson.


  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Added.
1:39 PM Changeset in webkit [12801] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.



Test cases:

  • dom/html/level2/html/HTMLOptionElement_label01.html
  • dom/html/level2/html/HTMLOptionElement_label02.html
  • dom/html/level2/html/HTMLOptionElement_label03.html
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): use label attribute, if present, when setting text on the widget.
1:18 PM Changeset in webkit [12800] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Change formatting in this file to match the style guidelines. No spaces after
opening parentheses or before closing parentheses.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::createDocumentFragment): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::write): (WebCore::DocumentImpl::writeln): (WebCore::DocumentImpl::setUserStyleSheet): (WebCore::DocumentImpl::determineParseMode): (WebCore::DocumentImpl::processHttpEquiv): (WebCore::DocumentImpl::childAllowed): (WebCore::DocumentImpl::childTypeAllowed): (WebCore::DocumentImpl::recalcStyleSelector): (WebCore::DocumentImpl::dispatchImageLoadEventsNow): (WebCore::DocumentImpl::domain): (WebCore::DocumentImpl::setDomain): (WebCore::DocumentImpl::parseQualifiedName): (WebCore::DocumentImpl::addMarker): (WebCore::DocumentImpl::removeMarkers):
11:13 AM Changeset in webkit [12799] by sullivan
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

Some cleanup from the previous checkin, inspired by Darin's comments


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: moved highlightAllMatchesForString out of here


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): now converts NSString to QString here, rather than in Frame/MacFrame


  • dom/DocumentMarker.h: Added. (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator == ): (WebCore::DocumentMarker::operator != ): moved this struct to its own header file


  • dom/DocumentImpl.h: moved DocumentMarker out; now includes DocumentMarker.h


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): moved here from MacFrame.[h,mm]. I thought this used other code from MacFrame.mm but it doesn't.


  • rendering/InlineTextBox.h: removed unnecesssary variable names; use DocumentMarker::MarkerType in signature of paintAllMarkersOfType
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paintTextMatchMarker): better name for a variable, fixed bad indent (khtml::InlineTextBox::paintAllMarkersOfType): rewrote loop to bail out early if past end, for clarity; use DocumentMarker::MarkerType in signature


  • WebCore.xcodeproj/project.pbxproj: updated for new file
10:09 AM Changeset in webkit [12798] by thatcher
  • 5 edits in tags/WebCore-521.7.1/WebCore

Merge the build fixes for case-sensitive drives to the tag. The #include "String.h" does not fail on normal HFS+ drives. Bump version to 521.7.1.

10:04 AM Changeset in webkit [12797] by thatcher
  • 1 copy in tags/WebCore-521.7.1/WebCore

New tag.

10:04 AM Changeset in webkit [12796] by thatcher
  • 1 add in tags/WebCore-521.7.1

New tag.

10:01 AM Changeset in webkit [12795] by thatcher
  • 3 edits in trunk/WebCore

More build fixes for case-sensitive drives. The #include "String.h" does not fail on normal HFS+ drives.

9:55 AM Changeset in webkit [12794] by thatcher
  • 1 edit in trunk/WebCore/loader/DocLoader.h

Build fix for case-sensitive drives.

8:57 AM Changeset in webkit [12793] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView highlightAllMatchesForString:caseSensitive:]): new method, calls through to bridge (-[WebHTMLView clearHighlightedMatches]): ditto
  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView highlightAllMatchesForString:caseSensitive:]): new method, calls through to documentView. For now this is hardwired to only work with WebHTMLViews. (-[WebView clearHighlightedMatches]): ditto
8:57 AM Changeset in webkit [12792] by sullivan
  • 8 edits in trunk/WebCore

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • dom/DocumentImpl.h: (WebCore::DocumentMarker::): Added new marker type TextMatch
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): new method, calls through to MacFrame implementation (-[WebCoreFrameBridge clearHighlightedMatches]): new method, removes all markers of type TextMatch
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::highlightAllMatchesForString): new method, adds a document marker for each range that matches the given string
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): Moved DocumentMarker loop into separate method paintAllMarkersOfType. We now call that method twice, once for spelling markers (after drawing text) and once for text match markers (before drawing text) (khtml::InlineTextBox::paintTextMatchMarker): new method, paints a color behind a text match marker (khtml::InlineTextBox::paintSpellingMarker): renamed from paintMarker (khtml::InlineTextBox::paintAllMarkersOfType): new method, loops through all DocumentMarkers of a particular type and calls the appropriate painting method for each one

Feb 13, 2006:

8:19 PM Changeset in webkit [12791] by darin
  • 23 edits
    1 add in trunk

WebCore:

Reviewed by Maciej.

  • move pointer from frame to page here from WebKit
  • WebCore.xcodeproj/project.pbxproj: Added PageMac.h.
  • bridge/mac/PageMac.h: Added.
  • bridge/mac/MacFrame.h: Added a page parameter to the constructor.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): Pass the page and renderer to the Frame constructor. Moved the call to Cache::init up into Frame, and got rid of the call to Frame::init since that's now handled by the constructor. Also put the code to create the browser extension object here. (WebCore::MacFrame::submitForm): Update for new method name. (WebCore::MacFrame::createFrame): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Update since m_doc is a RefPtr.
  • bridge/mac/WebCoreFrameBridge.h: Changed parameters on init methods. Renamed the part method to impl. Added a page method.
  • bridge/mac/WebCoreFrameBridge.mm: (frameHasSelection): Change use of part method to impl. (-[WebCoreFrameBridge appendChild:]): Use m_frame directly instead of calling part method. (-[WebCoreFrameBridge removeChild:]): Ditto. (-[WebCoreFrameBridge initMainFrameWithPage:]): Added. Now does the first-time initialization only here and create a frame for a main frame. (-[WebCoreFrameBridge initSubframeWithRenderer:]): Added. Doesn't do the first-time initialization and creates a frame for a subframe. (-[WebCoreFrameBridge page]): Added. (-[WebCoreFrameBridge setOpener:]): Change to use impl method instead of part. (-[WebCoreFrameBridge executionContextForView:]): Ditto. (-[WebCoreFrameBridge impl]): Added.
  • bridge/mac/WebCorePageBridge.h: Removed init method and added setMainFrame: method and impl method.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge init]): Changed to create a PageMac. (-[WebCorePageBridge setMainFrame:]): Added. (-[WebCorePageBridge impl]): Added.
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQSlider.mm: (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _isResizableByUser]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): Change methods to get from bridge back to objects to be named "impl". The old one was named "part".
  • page/Frame.h: Added Page and RenderPart parameter to constructor. Added a page function. Removed the createBrowserExtension function.
  • page/Frame.cpp: (WebCore::parentFromOwnerRenderer): Added. Helper for constructor. (WebCore::Frame::Frame): Moved all the code from init into here. Also change to set the parent right from the start. (WebCore::Frame::stopLoading): Change since m_doc is now a RefPtr. (WebCore::Frame::clear): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::setDocument): Ditto. (WebCore::Frame::begin): Ditto. (WebCore::Frame::gotoAnchor): Ditto. (WebCore::Frame::typingStyle): Change since m_typingStyle is now a RefPtr. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::isFrameSet): Change since m_doc is now a RefPtr. (WebCore::Frame::page): Added.
  • page/FramePrivate.h: Changed initialization to use member-initialization syntax. Removed unused m_frames. Changed m_doc and m_typingStyle to use RefPtr. Added an m_frame.
  • page/Page.h: Made destructor virtual so we could have a Mac derived class. Added a setMainFrame function and removed the mainFrame parameter from the constructor.
  • page/Page.cpp: (WebCore::Page::Page): Removed the mainFrame parameter. (WebCore::Page::setMainFrame): Added.

WebKit:

Reviewed by Maciej.

  • move pointer from frame to page over to WebCore
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Call super init to create the page before creating the main frame and calling setMainFrame: with it.
  • WebCoreSupport/WebFrameBridge.h: Remove page pointer, and change init function parameters.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): New function that is used only for the main frame. Passes the page over to the other side of the bridge. (-[WebFrameBridge initSubframeWithRenderer:frameName:view:]): New function that is used only for subframes. Passes the renderer over to the other side of the bridge. (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]): Change all calls to [_page webView] to use [self webView] instead.
8:11 PM Changeset in webkit [12790] by harrison
  • 2 edits in trunk/LayoutTests

Updated test case after improving table deletion.


  • selection/move-between-blocks-no-001-expected.txt: Updated.
7:29 PM Changeset in webkit [12789] by harrison
  • 8 edits in trunk/WebCore

Reviewed by Justin.

  • merge VisiblePosition:isCandidate() into Position::inRenderedContent() These functions were answering the same question in different ways! We only need one implementation.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::deepEquivalent):
  • khtml/editing/visible_position.h:
  • dom/dom_position.cpp: (DOM::hasRenderedChildrenWithHeight): (DOM::Position::inRenderedContent):
  • improved table deletion. Fixes: delete back by word from just after table did not delete the table

delete forward by char or word did not delete the table
deleting back to a table and again did not delete the table

  • khtml/editing/htmlediting.cpp: (WebCore::isFirstVisiblePositionAfterTableElement): simpler implementation (WebCore::positionBeforePrecedingTableElement): simpler implementation (WebCore::isFirstVisiblePositionBeforeTableElement): new (WebCore::positionAfterFollowingTableElement): new
  • khtml/editing/htmlediting.h:
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): select following table if granularity is char or word (WebCore::SelectionController::modifyExtendingLeftBackward): select preceding table if granularity is char or word
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): simpler implementation, and let other deleteKeyPressed do boundary checking (khtml::TypingCommand::forwardDeleteKeyPressed): simpler implementation, and let other forwardDeleteKeyPressed do boundary checking (khtml::TypingCommand::insertText): standard formatting (khtml::TypingCommand::insertLineBreak): standard formatting (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): standard formatting (khtml::TypingCommand::insertParagraphSeparator): standard formatting (khtml::TypingCommand::insertTextRunWithoutNewlines): standard formatting (khtml::TypingCommand::deleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks (khtml::TypingCommand::forwardDeleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks
5:01 PM Changeset in webkit [12788] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 5605, XSLT fails to import to arbitrary depth. Make sure m_embedded is initialized to false
in the XSLTStyleSheetImpl constructor.

Reviewed by timo

Adding xslt-import-depth.xml to fast/xsl

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::XSLStyleSheetImpl):
5:00 PM Changeset in webkit [12787] by hyatt
  • 5 adds in trunk/LayoutTests/fast/xsl

Add layout test for import depth.

3:13 PM Changeset in webkit [12786] by hyatt
  • 5 edits in trunk/WebCore

Fix Win32 WebCore bustage.

3:02 PM Changeset in webkit [12785] by eseidel
  • 2 edits in trunk/WebCore

2006-02-12 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7207.

No testcases as this is not possible to reproduce via anything
other than manual interaction.

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
2:49 PM Changeset in webkit [12784] by hyatt
  • 5 edits in trunk/JavaScriptCore

Fix Win32 JavaScriptCore bustage.

2:08 PM Changeset in webkit [12783] by thatcher
  • 9 copies in tags/Safari-521.7

New Tag

2:02 PM Changeset in webkit [12782] by darin
  • 55 edits
    1 copy
    2 moves
    1 delete in trunk/WebCore

Reviewed by Hyatt.

  • moved QWidget to platform directory, renamed to Widget, split into cross-platform and platform-specific parts, removed some of the unused bits
  • ForwardingHeaders/qwidget.h: Removed.
  • kwq/KWQWidget.h: Removed.
  • kwq/KWQWidget.mm: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Update for file removals and adds.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Widget.h: Moved code here, fixed it up.
  • platform/Widget.cpp: Ditto.
  • platform/mac/WidgetMac.mm: Added.
  • bindings/objc/DOMHTML.mm: (viewForElement):
  • bridge/mac/KWQKHTMLView.cpp: (WebCore::FrameView::topLevelWidget):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createPlugin): (WebCore::MacFrame::nextKeyViewInFrame): (WebCore::MacFrame::nextKeyViewForWidget): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::bridgeForWidget): (WebCore::MacFrame::passMouseDownEventToWidget): (WebCore::MacFrame::passSubframeEventToSubframe): (WebCore::MacFrame::passWheelEventToChildWidget): (WebCore::MacFrame::getAppletInstanceForWidget): (WebCore::MacFrame::getEmbedInstanceForWidget): (WebCore::MacFrame::getObjectInstanceForWidget):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge copyRenderNode:copier:]): (-[WebCoreFrameBridge elementForView:]): (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
  • dom/DocumentImpl.cpp: (WebCore::widgetForNode): (WebCore::DocumentImpl::setFocusNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::WindowFunc::callAsFunction):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): (WebCore::HTMLGenericFormElementImpl::isMouseFocusable):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLObjectElementImpl::getObjectInstance):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject attachmentView]): (-[KWQAccObject doAXTextMarkerForPosition:]):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QComboBox::setFont): (QComboBox::focusPolicy): (-[KWQPopUpButtonCell widget]): (-[KWQPopUpButton widget]): (-[KWQPopUpButton mouseDown:]): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]): (-[KWQPopUpButton nextKeyView]): (-[KWQPopUpButton previousKeyView]):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
  • kwq/KWQFrame.h:
  • kwq/KWQKCursor.h:
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setFont): (QLineEdit::setPalette): (QLineEdit::focusPolicy):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::focusPolicy): (QListBox::setFont): (-[KWQListBoxScrollView widget]): (-[KWQListBoxScrollView becomeFirstResponder]): (-[KWQTableView mouseDown:]): (-[KWQTableView widget]):
  • kwq/KWQPainter.h:
  • kwq/KWQRenderTreeDebug.cpp: (write):
  • kwq/KWQScrollBar.h:
  • kwq/KWQScrollBar.mm: (-[KWQScrollBar widget]): (-[KWQScrollBar mouseDown:]): (QScrollBar::QScrollBar): (QScrollBar::~QScrollBar):
  • kwq/KWQScrollView.h: (QScrollView::QScrollView):
  • kwq/KWQScrollView.mm: (QScrollView::viewport): (QScrollView::childX): (QScrollView::childY): (QScrollView::addChild): (QScrollView::removeChild):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider widget]): (QSlider::setFont): (QSlider::focusPolicy):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView widget]):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setFont): (QTextEdit::focusPolicy): (QTextEdit::setPalette):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController widget]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextField widget]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQSecureTextField widget]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField widget]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]):
  • kwq/KWQView.h:
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::topLevelWidget):
  • page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::frameForWidget): (WebCore::Frame::nodeForWidget): (WebCore::Frame::setDocumentFocus): (WebCore::Frame::clearDocumentFocus): (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::init):
  • page/FrameView.h:
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
  • platform/Screen.h:
  • platform/mac/ScreenMac.mm: (WebCore::screen): (WebCore::screenDepth): (WebCore::screenRect): (WebCore::usableScreenRect):
  • rendering/render_applet.cpp: (WebCore::RenderApplet::layout):
  • rendering/render_form.cpp: (WebCore::ComboBoxWidget::ComboBoxWidget): (WebCore::RenderSelect::createListBox):
  • rendering/render_form.h:
  • rendering/render_frames.cpp: (WebCore::RenderPart::setWidget):
  • rendering/render_frames.h:
  • rendering/render_object.cpp:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::resizeWidget): (WebCore::RenderWidget::setQWidget):
  • rendering/render_replaced.h: (WebCore::RenderWidget::widget): Change name from QWidget to Widget, a few other changes to get compiling.
1:57 PM Changeset in webkit [12781] by thatcher
  • 8 edits in /

Versioning to 521.7

11:34 AM Changeset in webkit [12780] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Replaced the old NS_DURING exception blocking with @try/@catch.

  • JavaScriptCorePrefix.h: undef try and catch to workaround a C++ conflict
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::setValueAt): (ObjcArray::valueAt):
1:34 AM Changeset in webkit [12779] by darin
  • 3 edits in trunk/JavaScriptCore
  • kjs/JSImmediate.h: Change code using non-standard u_int32/64_t types to the standard uint32/64_t. Also removed curious "isIEEE()" function that checked the sizes of some types (and type sizes alone don't tell you if the floating point conforms to the IEEE-standard). Added missing include of <stdint.h>.
  • kjs/property_slot.h: Added missing include of <assert.h>.

Feb 12, 2006:

9:31 PM Changeset in webkit [12778] by darin
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

  • fast/replaced/page-as-image.html: Added.
  • fast/replaced/page-as-image-expected.txt: Added.
  • fast/replaced/page-as-image-expected.png: Added.
  • fast/replaced/page-as-image-expected.checksum: Added.
  • fast/replaced/resources/image.pdf: Added.
9:27 PM Changeset in webkit [12777] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/replaced/page-as-image.html

  • platform/Image.cpp: (WebCore::Image::setNativeData): Return false in the case where the PDF document has not been created yet.
8:11 PM Changeset in webkit [12776] by mjs
  • 15 edits
    14 deletes in trunk/LayoutTests

Rubber stamped by Geoff.


  • comment out remote <base> URLs, these were making the tests hang for a long time

This also made the affected tests start passing.


  • dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement01.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement02-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement02.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement03-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement03.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement04-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement04.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement05-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement05.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBodyElement06-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement06.xhtml:
  • dom/xhtml/level2/html/body01-expected.checksum: Removed.
  • dom/xhtml/level2/html/body01-expected.png: Removed.
  • dom/xhtml/level2/html/body01-expected.txt:
  • dom/xhtml/level2/html/body01.xhtml:
7:06 PM Changeset in webkit [12775] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin.

Cleaned up testkjs, added new "run" functionality to allow scripting
tests from within JS. ("run" is a part of my new super-accurate
JS iBench.)

No regressions in run-javascriptcore-tests.

  • kjs/testkjs.cpp: (GlobalImp::className): (TestFunctionImp::): (TestFunctionImp::callAsFunction): (main): (run):
6:43 PM Changeset in webkit [12774] by darin
  • 4 edits
    1 move
    3 adds
    1 delete in trunk/WebCore

Reviewed by Maciej.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed old files, added new.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Timer.h: Updated for new timer implementation.
  • platform/Timer.cpp: Added. Platform-independent implementation of timers in terms of a single shared timer. Uses a heap to implement a priority queue so we know which timer to fire first.
  • platform/SharedTimer.h: Added.
  • platform/mac/SharedTimerMac.cpp: Added.
  • platform/win/SharedTimerWin.cpp: Added.
  • platform/mac/TimerMac.cpp: Removed.
  • platform/win/TimerWin.cpp: Removed.
4:51 PM Changeset in webkit [12773] by eseidel
  • 2 edits in trunk/WebCore

2006-02-12 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • loader/CachedXSLStyleSheet.cpp: removed duplicate copy of xbl code.
2:07 PM Changeset in webkit [12772] by eseidel
  • 3 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed by eseidel.

Added a little piece of text to the page about reductions, pointing to the bugzilla page.

Changed "Sign up for a" into "Create a" bugzilla account.

  • quality/reduction.html:
  • quality/reporting.html:
8:31 AM Changeset in webkit [12771] by mjs
  • 2 edits in trunk/WebCore

Unreviewed build fix.

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Update for splitting of the dom_textimpl.h header.
2:11 AM Changeset in webkit [12770] by mjs
  • 7 edits
    2 adds in trunk/WebKit

Reviewed by Hyatt.


  • DOM/WebDOMOperations.m: (-[DOMNode webArchive]): (-[DOMRange webArchive]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.h: Added.
  • WebView/WebArchiver.m: Added. (+[WebArchiver _subframeArchivesForFrame:]): (+[WebArchiver archiveFrame:]): (+[WebArchiver _archiveCurrentStateForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveRange:]): (+[WebArchiver archiveNode:]): (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebDataSource.m: (-[WebDataSource webArchive]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): (-[WebHTMLView _writeSelectionToPasteboard:]):
  • WebView/WebHTMLViewPrivate.h:
2:07 AM Changeset in webkit [12769] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Correct tyop in ChangeLog

2:03 AM Changeset in webkit [12768] by mjs
  • 13 edits
    2 moves in trunk/WebCore

Reviewed by Darin.


This may be slightly less accurate, but reads better.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::submitForm): (WebCore::MacFrame::nextKeyViewInFrameHierarchy):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstChild]): (-[WebCoreFrameBridge lastChild]): (-[WebCoreFrameBridge childCount]): (-[WebCoreFrameBridge previousSibling]): (-[WebCoreFrameBridge nextSibling]): (-[WebCoreFrameBridge appendChild:]): (-[WebCoreFrameBridge removeChild:]): (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::findFrame): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::tree): (WebCore::Frame::frameDetached): (WebCore::Frame::updateBaseURLForEmptyDocument):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp: Added. (WebCore::FrameTree::~FrameTree): (WebCore::FrameTree::setName): (WebCore::FrameTree::appendChild): (WebCore::FrameTree::removeChild):
  • page/FrameTree.h: Added. (WebCore::FrameTree::FrameTree):
  • page/FrameTreeNode.cpp: Removed.
  • page/FrameTreeNode.h: Removed.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
12:50 AM Changeset in webkit [12767] by hyatt
  • 4 edits in trunk/WebCore

Fix bug 7182, animated GIFs don't clear previous animation frames.

Feb 11, 2006:

7:10 PM Changeset in webkit [12766] by ggaren
  • 3 edits in trunk/WebCore
  • Fixed bad free resulting from 0 legnth StringImpl

No test case because currently this bug only has the effect of a bad
free on exit().

  • platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Factored varied approaches to initialization into two common routines: initWithChar and initWithQChar. The common rule is: if we're not going to allocate a string, make sure to set s to 0 so fastFree doesn't try to free it later. For speed, initWithQChar uses memcpy() -- that's the only difference between the two. (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar):
  • platform/StringImpl.h:
5:18 PM Changeset in webkit [12765] by mjs
  • 40 edits
    8 copies
    2 moves in trunk/WebCore

Rubber stamped by Eric.

  • split dom_textimpl.{h,cpp} by class.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bridge/mac/MacFrame.mm:
  • dom/CDATASectionImpl.cpp: Added.
  • dom/CDATASectionImpl.h: Added.
  • dom/CharacterDataImpl.cpp: Added.
  • dom/CharacterDataImpl.h: Added.
  • dom/CommentImpl.cpp: Added.
  • dom/CommentImpl.h: Added.
  • dom/DocumentImpl.cpp:
  • dom/EditingTextImpl.cpp: Added.
  • dom/EditingTextImpl.h: Added.
  • dom/NodeImpl.cpp:
  • dom/TextImpl.cpp: Added.
  • dom/TextImpl.h: Added.
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_elementimpl.cpp:
  • dom/dom_textimpl.cpp: Removed.
  • dom/dom_textimpl.h: Removed.
  • dom/xml_tokenizer.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/html/HTMLElementImpl.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • page/Frame.cpp:
  • rendering/RenderText.h:
  • rendering/render_frames.cpp:
4:51 PM Changeset in webkit [12764] by eseidel
  • 15 edits
    4 adds in trunk

2006-02-11 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

  • Layout tests changes:

Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg
New: svg/custom/coords-relative-units-transforms.svg

4:21 PM Changeset in webkit [12763] by darin
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by Darin.

Added a Bugzilla page, which contains information about creating a Bugzilla account, what editbugs and canconfirm
bits are and how to get them.


Changed link in reporting page to link to Bugzilla page.


  • quality/bugzilla.html: Added.
  • quality/reporting.html:
4:09 PM Changeset in webkit [12762] by darin
  • 2 edits
    13 moves in trunk/WebCore

Rubber-stamped by Eric.

  • renamed all the platform/mac files to have a Mac suffix (Hyatt and I discussed this change recently)
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/Color.mm: Removed.
  • platform/mac/ColorMac.mm: Added.
  • platform/mac/FloatPoint.mm: Removed.
  • platform/mac/FloatPointMac.mm: Added.
  • platform/mac/FloatRect.mm: Removed.
  • platform/mac/FloatRectMac.mm: Added.
  • platform/mac/FloatSize.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Added.
  • platform/mac/Image.mm: Removed.
  • platform/mac/ImageMac.mm: Added.
  • platform/mac/ImageSource.cpp: Removed.
  • platform/mac/ImageSourceMac.cpp: Added.
  • platform/mac/IntPoint.mm: Removed.
  • platform/mac/IntPointMac.mm: Added.
  • platform/mac/IntRect.mm: Removed.
  • platform/mac/IntRectMac.mm: Added.
  • platform/mac/IntSize.mm: Removed.
  • platform/mac/IntSizeMac.mm: Added.
  • platform/mac/QString.mm: Removed.
  • platform/mac/QStringMac.mm: Added.
  • platform/mac/Screen.mm: Removed.
  • platform/mac/ScreenMac.mm: Added.
  • platform/mac/SystemTime.cpp: Removed.
  • platform/mac/SystemTimeMac.cpp: Added.
  • platform/mac/Timer.cpp: Removed.
  • platform/mac/TimerMac.cpp: Added.
3:54 PM Changeset in webkit [12761] by eseidel
  • 327 edits in trunk/WebCore

2006-02-11 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Push kcanvas into WebCore namespace.
Fix KSVG2 to use WebCore namespace.

Remove all uses of khtml
and KDOM:: from SVG code. Too many files changed to bother showing here.
3:38 PM Changeset in webkit [12760] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/events/event-targets.html: Fixed a small mistake in this test, noticed while checking that bug 3609 is fixed in tip of tree.
3:19 PM Changeset in webkit [12759] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed by eseidel.

  • Changed 10.2 paragraph to say Mac OS X instead of just OS X
  • Detabified the file.
  • quality/reporting.html:
12:11 PM Changeset in webkit [12758] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.



  • fast/replaced/width100percent-expected.checksum: Updated.
  • fast/replaced/width100percent-expected.png: Updated.
  • fast/replaced/width100percent-expected.txt: Updated.
  • fast/table/edge-offsets-expected.checksum: Added.
  • fast/table/edge-offsets-expected.png: Added.
  • fast/table/edge-offsets-expected.txt: Added.
  • fast/table/edge-offsets.html: Added.

WebCore:

Test: fast/table/edge-offsets.html


Reviewed by Hyatt.



  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): Override the superclass implementation to return the lowest of all the cells' lowest positions and the section's. (WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost. (WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost.
  • rendering/RenderTableSection.h:
11:56 AM Changeset in webkit [12757] by adele
  • 3 edits in trunk/WebCore

No test until we figure out how to make one.

Reviewed by Darin.



  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Removed the call to setParsing(false) from here since it stopped parsing prematurely. Now the frame will call it when the tokenizer is finished.
  • page/Frame.cpp: (WebCore::Frame::clear): Disconnect the finishedParsing signal handler from the document. (WebCore::Frame::setDocument): Disconnect the signal handler from the old document and connect it to the new document.
11:39 AM Changeset in webkit [12756] by adele
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.



  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::hoveredNodeDetached): Added this method. Moved the hover logic from NodeImpl::detach here, modified to use the DOM tree instead of hoverAncestor, to handle the case that the hover node is a text node, and to schedule an update of hover state. (WebCore::DocumentImpl::activeChainNodeDetached): Added this method to trim the active chain above the node being detached.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Moved most of the hover logic out of here into DocumentImpl. Reset m_active and m_inActiveChain and call activeChainNodeDetached when detaching an active node.
  • manual-tests/bugzilla-6821.html: Added.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added hover-state update timer. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::hoverTimerFired): Call DocumentImpl::prepareMouseEvent when the timer fires to cause hover state to update. (WebCore::FrameView::scheduleHoverStateUpdate): Added.
  • page/FrameView.h:
9:58 AM Changeset in webkit [12755] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated paths for recent changes in directory structure.
8:03 AM Changeset in webkit [12754] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

  • English.lproj/Localizable.strings: Added new UI_STRING().
  • Misc/WebKitErrors.m: Added #define for description. (registerErrors): Added dictionary entry.
2:48 AM Changeset in webkit [12753] by ap
  • 4 edits
    12 adds in trunk

Reviewed by Darin.

Test cases:

  • fast/frames/frame-set-same-location.html
  • fast/frames/frame-set-same-src.html
  • fast/frames/iframe-set-same-location.html
  • fast/frames/iframe-set-same-src.html
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::setLocation): Remove the check for the new URL being different from the current one. Moved updateForNewURL() code into setLocation().
  • khtml/html/html_baseimpl.h:
2:34 AM Changeset in webkit [12752] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use kCFStringEncodingISOLatin1 rather than kCFStringEncodingWindowsLatin1, because the latter encoding has holes, and conversion can still fail.
12:34 AM Changeset in webkit [12751] by eseidel
  • 1 edit
    9 adds in trunk/LayoutTests

2006-02-11 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • fast/parser/external-entities-expected.checksum: Added.
  • fast/parser/external-entities-expected.png: Added.
  • fast/parser/external-entities-expected.txt: Added.
  • fast/parser/external-entities-in-xslt-expected.txt: Added.
  • fast/parser/external-entities-in-xslt.xml: Added.
  • fast/parser/external-entities.xml: Added.
  • fast/parser/resources: Added.
  • fast/parser/resources/external-entities.dtd: Added.
  • fast/parser/resources/external-entities.xsl: Added.
12:15 AM Changeset in webkit [12750] by eseidel
  • 5 edits in trunk/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
  • dom/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h:
Note: See TracTimeline for information about the timeline view.