Timeline



Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt
  • 23 edits
    2 adds
    2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQFontMetrics.h: Removed.
  • kwq/KWQFontMetrics.mm: Removed.
  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
  • platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
  • platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/GraphicsContextMac.mm:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
  • rendering/render_object.h:
  • rendering/render_style.h:
4:33 PM Changeset in webkit [13133] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

  • Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):
4:28 PM Changeset in webkit [13132] by eseidel
  • 2 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

  • platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):
3:07 PM Changeset in webkit [13131] by thatcher
  • 2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

  • Scripts/run-webkit-tests:
3:05 PM Changeset in webkit [13129] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • stop background image loads from crashing
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):
  • fix termination condition on file load loop
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):
2:57 PM Changeset in webkit [13128] by thatcher
  • 9 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

12:37 PM Changeset in webkit [13127] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

  • khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
  • khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.
3:02 AM Changeset in webkit [13126] by mjs
  • 3 edits in trunk/WebKitTools

Reviewed by Eric.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.
2:58 AM Changeset in webkit [13125] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):
2:26 AM Changeset in webkit [13124] by mjs
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
  • platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.

Mar 3, 2006:

11:42 PM Changeset in webkit [13123] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
  • rendering/RenderThemeWin.h: Added.
11:29 PM Changeset in webkit [13122] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
  • Scripts/run-webkit-tests:
5:35 PM Changeset in webkit [13121] by eseidel
  • 5 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):
3:33 PM Changeset in webkit [13120] by ggaren
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin.

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

  • kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
​http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

  • manual-tests/property-map-save-crash.html: Added.
2:10 PM Changeset in webkit [13119] by lypanov
  • 2 edits in trunk/LayoutTests

2006-03-03 Alexander Kellett <​lypanov@kde.org>

  • local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
11:43 AM Changeset in webkit [13118] by eseidel
  • 3 edits in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
  • platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):
7:59 AM Changeset in webkit [13117] by darin
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/innerHTML/innerHTML-custom-tag.html: Added.
  • fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.
  • fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.
  • editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

Test: fast/innerHTML/innerHTML-custom-tag.html

  • editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.
1:54 AM Changeset in webkit [13116] by eseidel
  • 5 edits
    2 adds in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

  • Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
  • Spinneret/Spinneret/WebFrame.h: Added.
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
1:44 AM Changeset in webkit [13115] by mjs
  • 3 edits
    1 copy in trunk/WebCore

Rubber stamped by Eric.

  • add new files to build, fix link stubs.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
  • platform/win/TransferJobWin.cpp: Added.
1:31 AM Changeset in webkit [13114] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • add file I forgot in my last commit.
  • platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):
1:30 AM Changeset in webkit [13113] by eseidel
  • 10 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

  • Viewer/ImageDocument.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
  • platform/IntRect.h: (WebCore::IntRect::IntRect):
  • platform/Widget.h:
  • platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
  • platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
  • platform/win/MouseEventWin.cpp:
  • platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
  • platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):
1:19 AM Changeset in webkit [13112] by mjs
  • 11 edits
    1 copy
    3 moves
    2 deletes in trunk/WebCore

Reviewed by Eric.

  • move TransferJob from kwq to platform, separate platform from non-platform bits
  • ForwardingHeaders/kio/job.h: Removed.
  • ForwardingHeaders/kio/jobclasses.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • dom/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/KWQKJobClasses.h: Removed.
  • kwq/KWQKJobClasses.mm: Removed.
  • kwq/KWQLoader.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/TransferJobClient.h: Removed.
  • loader/Cache.cpp:
  • loader/loader.cpp:
  • page/Frame.cpp:
  • platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
  • platform/TransferJob.h: Added.
  • platform/TransferJobClient.h: Added.
  • platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
  • xml/xmlhttprequest.cpp:
1:18 AM Changeset in webkit [13111] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):

Mar 2, 2006:

11:44 PM Changeset in webkit [13110] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric.

  • remove function that is now gone
  • platform/win/TemporaryLinkStubs.cpp:
11:41 PM Changeset in webkit [13109] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Eric.


  • move logic to kick off load from KWQLoader function to a TransferJob method
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJob::start):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
11:16 PM Changeset in webkit [13108] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • remove unused loader parameter to KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
10:58 PM Changeset in webkit [13107] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Eric.

  • remove one of the versions of KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • platform/win/TemporaryLinkStubs.cpp: (Widget::isEnabled): (KWQServeRequest):
10:13 PM Changeset in webkit [13106] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric.

  • win32 build fix.
  • platform/win/MouseEventWin.cpp:
9:37 PM Changeset in webkit [13105] by eseidel
  • 2 edits in trunk/WebKitSite

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • quality/reporting.html: display a nicer message to those using 10.2
6:53 PM Changeset in webkit [13104] by justing
  • 5 edits in trunk/WebCore

Reviewed by eric


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3894>
uses of <cmath> should change to <math>

  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp:
5:52 PM Changeset in webkit [13103] by bdakin
  • 8 edits
    6 adds in trunk/LayoutTests

Reviewed by Darin, landed by Beth.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Update existing tests for new results and add new test

5:46 PM Changeset in webkit [13102] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Darin, landed by Beth

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Does not use UBreakIterator (yet?) for this, but a relatively
simple change that fixes our failure in the CSS1 test suite
(5.4.5).

1:46 PM Changeset in webkit [13101] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
1:45 PM Changeset in webkit [13100] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Patch reviewed by sullivan
Test written by mitz


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • fast/lists/scrolled-marker-paint-expected.checksum: Added.
  • fast/lists/scrolled-marker-paint-expected.png: Added.
  • fast/lists/scrolled-marker-paint-expected.txt: Added.
  • fast/lists/scrolled-marker-paint.html: Added.

WebCore:

Reviewed by sullivan


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
1:41 PM Changeset in webkit [13099] by eseidel
  • 6 edits
    2 adds in trunk/WebCore

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add (partially stubbed out) mouse event handling for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntPoint.h:
  • platform/MouseEvent.h:
  • platform/win/IntPointWin.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINT):
  • platform/win/MouseEventWin.cpp: Added. (WebCore::MouseEvent::MouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setMaxLength): (ScrollView::scrollBy): (WebCore::Widget::setFocus): (FrameWin::respondToChangedSelection): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::registerCommandForUndo): (FrameWin::addMessageToConsole): (FrameWin::mimeTypeForFileName): (FrameWin::shouldChangeSelection): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::personalbarVisible): (FrameWin::objectContentType): (FrameWin::createFrame): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (FrameWin::passSubframeEventToSubframe): (FrameWin::lastEventIsMouseUp): (BrowserExtensionWin::BrowserExtensionWin): (Widget::setCursor): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents): (TransferJob::TransferJob): (TransferJob::addMetaData):
11:40 AM Changeset in webkit [13098] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by mjs


<​http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

  • editing/undo/undo-iframe-location-change-expected.txt: Added.
  • editing/undo/undo-iframe-location-change.html: Added.

WebCore:

Reviewed by mjs


<​http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed


Can't clear undo/redo operations registered by subframes in didOpenURL,
because subframes have already been detached.

  • page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::closeURL):
11:37 AM Changeset in webkit [13097] by thatcher
  • 1 copy in tags/WebCore-417.23/WebCore

New tag part two).

11:37 AM Changeset in webkit [13096] by thatcher
  • 1 add in tags/WebCore-417.23

New tag.

11:35 AM Changeset in webkit [13095] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.23

11:32 AM Changeset in webkit [13094] by thatcher
  • 7 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This also includes the ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 fix
<rdar://problem/4462712> REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

2006-02-17 Vicki Murley <​vicki@apple.com>

Reviewed by Justin.


Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
  • rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
  • rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
  • rendering/render_replaced.h: Remove handleFocusOut().
  • rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.
2:35 AM Changeset in webkit [13093] by mjs
  • 2 edits in trunk/JavaScriptCore
  • now fix mac build again
  • kjs/identifier.cpp:
2:20 AM Changeset in webkit [13092] by mjs
  • 3 edits in trunk/JavaScriptCore

Rubber stamped by Anders and Eric.

  • add fpconst.cpp to win32 build, it is now needed
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/fpconst.cpp:
2:10 AM Changeset in webkit [13091] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • fix windows build, broken by my last patch
  • kjs/JSImmediate.cpp:
  • kjs/identifier.cpp:
  • kxmlcore/FastMalloc.cpp:
  • kxmlcore/Platform.h:
1:21 AM Changeset in webkit [13090] by eseidel
  • 52 edits in trunk

Add svn:eol-style=native, and fix line endings.

1:12 AM Changeset in webkit [13089] by mjs
  • 62 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin.


  • Set up new prototype macros and avoid using #if without defined() in JSC


Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
are defined, and to separate core OS-level dependencies from operating environment
dependencies so you can, e.g., build KDE on Mac or Windows.

  • kxmlcore/Platform.h: Added.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/objc_instance.mm: (ObjcInstance::end):
  • bindings/softlinking.h:
  • bindings/testbindings.mm: (main):
  • kjs/JSLock.cpp:
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively):
  • kjs/config.h:
  • kjs/date_object.cpp: (gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::makeTime):
  • kjs/dtoa.cpp:
  • kjs/fpconst.cpp: (KJS::sizeof): (KJS::):
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): (KJS::Interpreter::createLanguageInstanceForValue):
  • kjs/interpreter.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf):
  • kjs/operations.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h:
  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/Assertions.cpp:
  • kxmlcore/Assertions.h:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::):
  • kxmlcore/FastMalloc.h:
  • kxmlcore/FastMallocInternal.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
  • os-win32/stdint.h:

JavaScriptGlue:

Not reviewed, but I noticed these trivial extra changes were needed to avoid
breaking the build with my reviewed patch for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=7387


Add config.h, includes of it, and Platform.h forwarding header.

  • JSBase.cpp:
  • JSObject.cpp:
  • JSRun.cpp:
  • JSUtils.cpp:
  • JSValueWrapper.cpp:
  • JavaScriptGlue.cpp:
  • UserObjectImp.cpp:
  • config.h: Added.
  • kxmlcore/Platform.h: Added.

WebCore:

Reviewed by Darin.


Add Platform.h

  • ForwardingHeaders/kxmlcore/Platform.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m:
  • bridge/mac/WebCoreViewFactory.m:
  • bridge/mac/WebDashboardRegion.m:
  • config.h:
  • platform/Logging.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
  • platform/mac/WebCoreCookieAdapter.m:
  • platform/mac/WebCoreGraphicsBridge.m:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreImageRendererFactory.m:
  • platform/mac/WebCoreKeyGenerator.m:
  • platform/mac/WebCoreView.m:
12:39 AM Changeset in webkit [13088] by eseidel
  • 2 edits in trunk/WebCore

2006-03-02 Eric Seidel <​eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build
12:21 AM Changeset in webkit [13087] by eseidel
  • 6 edits in trunk/WebKitTools

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

Make spinneret take advantage of the new GraphicsContextCairo.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): updated to match style guidelines.
  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h:
12:20 AM Changeset in webkit [13086] by eseidel
  • 6 edits
    1 move in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add first-stab GraphicsContextCairo.

Shuffle a few more link stubs around, remove uncessary WebCore
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/GraphicsContext.cpp: Added.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::setColor): (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::adjustLineToPixelBounderies): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled):
  • platform/cairo/ImageCairo.cpp:
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (Widget::mapFromGlobal): (QLineEdit::cursorPosition): (QTextEdit::setScrollBarModes): (QTextEdit::selectAll): (QComboBox::focusPolicy): (GraphicsContext::clearShadow): (QTextEdit::setCursorPosition): (GraphicsContext::drawText): (QLineEdit::setLiveSearch): (QComboBox::QComboBox): (Widget::lockDrawingFocus): (QTextEdit::setSelectionRange): (QSlider::QSlider): (ScrollView::scrollYOffset): (QComboBox::sizeHint): (QLineEdit::edited): (QTextEdit::text): (QSlider::value): (WebCore::Widget::setFocus): (WebCore::TransferJob::addMetaData): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::registerCommandForUndo): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::addMessageToConsole): (FrameWin::passWheelEventToChildWidget): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::shouldChangeSelection): (FrameWin::scheduleClose): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::lastEventIsMouseUp): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::userAgent): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::objectContentType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (FrameWin::generateFrameName): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (GraphicsContext::GraphicsContext): (QFontMetrics::isFixedPitch): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::setTitle): (FrameWin::handledOnloadEvents): (FrameWin::markedTextRange): (GraphicsContext::font): (GraphicsContext::setFont):

Mar 1, 2006:

10:24 PM Changeset in webkit [13085] by ap
  • 3 edits in trunk/WebKit

Fixed a typo in the comments added in the previous checkin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
9:58 PM Changeset in webkit [13084] by ap
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET. (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: Ditto. Also removed a stale comment about XMLHTTPRequests. (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
9:55 PM Changeset in webkit [13083] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Changed an Objective-C forward declaration from "class" to "@class".
This doesn't appear to fix any problems, though.

  • platform/StringImpl.h:
9:24 PM Changeset in webkit [13082] by justing
  • 2 edits in trunk/LayoutTests/editing/unsupported-content

harrison forgot to update these pixel results. We should probably move this test out of unsupported-content, since lists are no longer unsupported, but i'll let him do that when he gets back.

9:12 PM Changeset in webkit [13081] by justing
  • 5 edits
    5 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • editing/resources/select-all-iframe-src.html: Added.
  • editing/selection/select-all-iframe-expected.checksum: Added.
  • editing/selection/select-all-iframe-expected.png: Added.
  • editing/selection/select-all-iframe-expected.txt: Added.
  • editing/selection/select-all-iframe.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • page/Frame.cpp: (WebCore::Frame::selectFrameElementInParentIfFullySelected):

WebKitTools:

Reviewed by darin


Give the events that eventSender sends a unique eventNumber

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):
7:33 PM Changeset in webkit [13080] by harrison
  • 3 edits in trunk/WebKit

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".


  • WebView/WebHTMLView.m: (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]):
  • WebView/WebHTMLViewPrivate.h:
7:32 PM Changeset in webkit [13079] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.
(missed these in my earlier commit for <rdar://problem/4359736>)

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
6:43 PM Changeset in webkit [13078] by eseidel
  • 1 edit
    14 adds in trunk/WebKitTools

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Add a stub win32 application to test WebCore drawing on windows.

  • Spinneret: Added.
  • Spinneret/Spinneret: Added.
  • Spinneret/Spinneret.sln: Added.
  • Spinneret/Spinneret/Resource.h: Added.
  • Spinneret/Spinneret/Spinneret.cpp: Added. (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (About):
  • Spinneret/Spinneret/Spinneret.h: Added.
  • Spinneret/Spinneret/Spinneret.ico: Added.
  • Spinneret/Spinneret/Spinneret.rc: Added.
  • Spinneret/Spinneret/Spinneret.vcproj: Added.
  • Spinneret/Spinneret/WebView.cpp: Added. (WebKit::WebView::WebViewPrivate::WebViewPrivate): (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WebView::windowHandle): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h: Added.
  • Spinneret/Spinneret/small.ico: Added.
  • Spinneret/Spinneret/stdafx.cpp: Added.
  • Spinneret/Spinneret/stdafx.h: Added.
6:17 PM Changeset in webkit [13077] by eseidel
  • 6 edits
    2 adds in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build, add IntRectWin and GraphicsContextCairo stub.

  • Viewer/ImageDocument.cpp:
  • Viewer/ImageMainFrame.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntRect.h:
  • platform/cairo/GraphicsContextCairo.cpp: Added.
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForText): (WebCore::GraphicsContext::fillRect): (WebCore::TransferJob::TransferJob): (GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
6:12 PM Changeset in webkit [13076] by harrison
  • 3 edits in trunk/LayoutTests

Updated test case after improving list deletion.

<rdar://problem/4359736> Support outlining ability with lists


  • unsupported-content/list-delete-002-expected.txt: Updated.
  • unsupported-content/list-delete-002.html: Updated.
6:05 PM Changeset in webkit [13075] by harrison
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".
Additional support is to end a list when return is typed on empty list item.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added ModifySelectionListLevelCommand.cpp and ModifySelectionListLevelCommand.h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): Supply list level calls in the bridge.


  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::createListItemElement): New. Creates an li.


(WebCore::InsertParagraphSeparatorCommand::doApply):

  • slight logic cleanup
  • on empty list item, end the list


  • editing/ModifySelectionListLevelCommand.cpp: Added. (WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand): (WebCore::ModifySelectionListLevelCommand::preservesTypingStyle): (WebCore::ModifySelectionListLevelCommand::doApply): (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeAfter): (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
  • editing/ModifySelectionListLevelCommand.h: Added. New editing command for adjusting the list level.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Slight logic cleanup
  • editing/htmlediting.cpp: (WebCore::isListElement): (WebCore::enclosingListChild): New helpers.


(WebCore::isTableElement):
Allow caller to pass 0... return false in that case.


  • editing/htmlediting.h: New helpers.


  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): Allow for list children that are not li nodes. Ignore and continue rather than stopping.


(WebCore::RenderContainer::addChild):
Allow for nil beforeChild, meaning "add at end".

6:00 PM Changeset in webkit [13074] by eseidel
  • 8 edits in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Update ESelectionGranulartiy enum to use newer CamelCase styling.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
  • editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::validate):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/jsediting.cpp:
  • editing/text_granularity.h: (WebCore::):
  • page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventSelection):
12:55 PM Changeset in webkit [13073] by lypanov
  • 7 edits in trunk

2006-03-01 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

Fixes already existing test:

svg/W3C-SVG-1.1/coords-viewattr-02-b.svg

  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGImage.h:

2006-03-01 Alexander Kellett <​lypanov@kde.org>

  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
9:56 AM Changeset in webkit [13072] by thatcher
  • 2 edits in trunk

Forgot to add the radar to my changelog entries.

9:54 AM Changeset in webkit [13071] by ap
  • 16 edits
    5 adds in trunk

Reviewed by Darin.

HEAD is currently unimplemented because of what seems to be a bug in NSURLConnection,
and does a GET instead.

WebCore:

  • kwq/KWQKJobClasses.h: Add a method parameter to TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::method):
  • bridge/mac/WebCoreFrameBridge.h: URL loading functions now take a method parameter.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • page/Frame.cpp: (WebCore::Frame::didOpenURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Honor the method passed in open().
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Don't serialize null as "null".

WebKit:

All WebKit changes are to use the method parameter passed from WebCore.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

LayoutTests:

  • http/tests/xmlhttprequest/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/methods-async.html: Added.
  • http/tests/xmlhttprequest/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/methods.cgi: Added.
  • http/tests/xmlhttprequest/methods.html: Added.
9:49 AM Changeset in webkit [13070] by thatcher
  • 17 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary

Support for WebKit. This removes the old elementAtPoint: on the bridge.
WebKit now uses the bridge method getInnerNonSharedNode:innerNode:URLElement:atPoint:

  • WebCore.exp: removes the WebCore* dictionary keys
  • bindings/objc/DOM.mm: (-[DOMElement image]): new method to get an NSImage if the element has an image renderer
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): new method that returns the title after doing the backslash as currency symbol conversion (-[DOMHTMLInputElement altDisplayString]): ditto for alt (-[DOMHTMLImageElement altDisplayString]): ditto (-[DOMHTMLAppletElement altDisplayString]): ditto (-[DOMHTMLAreaElement altDisplayString]): ditto (-[DOMHTMLAnchorElement absoluteLinkURL]): new method to get the absolute NSURL (-[DOMHTMLAreaElement absoluteLinkURL]): ditto (-[DOMHTMLLinkElement absoluteLinkURL]): ditto (-[DOMHTMLInputElement absoluteImageURL]): new method to get the absolute image location as an NSURL (-[DOMHTMLImageElement absoluteImageURL]): ditto (-[DOMHTMLObjectElement absoluteImageURL]): ditto
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:]): (-[WebCoreFrameBridge isPointInsideSelection:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::backslashAsCurrencySymbol):
  • dom/DocumentImpl.h:
  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTest):
  • rendering/render_object.h: (WebCore::RenderObject::NodeInfo::URLElement): (WebCore::RenderObject::NodeInfo::setURLElement):

WebKit:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary


elementAtPoint for WebHTMLView now returns a WebElementDictionary,
when objectForKey is called it will lookup in the DOM, cache and return the value

  • Misc/WebElementDictionary.h: Added.
  • Misc/WebElementDictionary.m: Added. (addLookupKey): (cacheValueForKey): (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary initWithInnerNonSharedNode:innerNode:URLElement:andPoint:]): (-[WebElementDictionary dealloc]): (-[WebElementDictionary _fillCache]): (-[WebElementDictionary count]): (-[WebElementDictionary keyEnumerator]): (-[WebElementDictionary objectForKey:]): (-[WebElementDictionary _domNode]): (-[WebElementDictionary _webFrame]): (-[WebElementDictionary _targetWebFrame]): (-[WebElementDictionary _title]): (-[WebElementDictionary _imageRect]): (-[WebElementDictionary _isSelected]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:
8:33 AM Changeset in webkit [13069] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/hover-subselector-expected.checksum: Added.
  • fast/css/hover-subselector-expected.png: Added.
  • fast/css/hover-subselector-expected.txt: Added.
  • fast/css/hover-subselector.html: Added.

WebCore:

Test: fast/css/hover-subselector.html

Reviewed by Hyatt.

  • css/cssstyleselector.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Pass flag to indicate sub-selector. (WebCore::CSSStyleSelector::checkOneSelector): Apply the *:hover and *:active quirks only when there are no sub-selectors.
1:12 AM Changeset in webkit [13068] by mjs
  • 3 edits in trunk/WebCore

Rubber stamped by Hyatt.

  • fix win32 build (and make dumprendertree run)
  • kwq/KWQComboBox.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::selectionEnd): (Widget::~Widget): (GraphicsContext::beginTransparencyLayer): (QComboBox::populate): (GraphicsContext::drawConvexPolygon): (QFontMetrics::selectionRectForText): (GraphicsContext::setShadow): (GraphicsContext::clearFocusRing): (GraphicsContext::drawImageInRect): (KWQFileButton::setFilename): (KWQFileButton::focusPolicy): (KWQFileButton::frameGeometry): (QSlider::focusPolicy): (WebCore::GraphicsContext::font): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (QFontMetrics::isFixedPitch): (WebCore::TransferJob::addMetaData):

Feb 28, 2006:

11:49 PM Changeset in webkit [13067] by darin
  • 106 edits
    2 copies
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

  • platform/GraphicsContext.h: Added.
  • platform/TextDirection.h: Added.
  • platform/cg/GraphicsContextCG.cpp: Added.
  • platform/mac/GraphicsContextMac.mm: Added.
  • kwq/KWQPainter.h: Removed.
  • kwq/KWQPainter.mm: Removed.
  • ForwardingHeaders/qpainter.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for moved files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for moved files.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • editing/SelectionController.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty): (KJS::drawPattern):
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight):
  • page/FrameView.h:
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintAllMarkersOfType): (WebCore::InlineTextBox::paintMarkedTextUnderline): (WebCore::InlineTextBox::offsetForPosition):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_button.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::paintObject):
  • rendering/render_button.h: (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintFocusRing): (WebCore::RenderFlow::paintOutlines): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/render_flow.h:
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderTextArea::setStyle):
  • rendering/render_form.h: (WebCore::RenderFieldset::renderName):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintScrollbars): (WebCore::RenderLayer::paint): (WebCore::setClip): (WebCore::restoreClip): (WebCore::RenderLayer::paintLayer): (WebCore::Marquee::direction):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor):
  • rendering/render_object.h: (WebCore::RenderObject::element): (WebCore::RenderObject::document): (WebCore::RenderObject::setNode): (WebCore::RenderObject::node): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::printBoxDecorations):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h: Updated to use GraphicsContext instead of QPainter.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setWritingDirection):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setWritingDirection):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::setWritingDirection):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setWritingDirection):
  • rendering/bidi.cpp: (khtml::bidiNext): (khtml::bidiFirst): Updated to use TextDirection instead of QPainter::TextDirection and EDirection.
  • kcanvas/device/KRenderingDevice.h: Added renderingDevice here to replace QPainter::renderingDevice for now.
  • khtml/ecma/kjs_html.h: Fixed comments to mention GraphicsContext.
  • khtml/html/html_imageimpl.h:
  • page/FrameView.cpp:
  • rendering/RenderBlock.cpp: Added include needed since I reduced includes elsewhere.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Changed QChar* to be const QChar*.
  • platform/FontDescription.h: Added include that was missing.
  • rendering/render_theme.cpp: Ditto.
  • platform/Image.h: Removed unnecessary forward declaration of QPainter.
  • rendering/RenderText.h: Clean up types, use const.
  • rendering/render_style.h: Removed EDirection and replaced it with TextDirection.
  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle): (WebCore::KCanvasCreator::createRectangle): (WebCore::KCanvasCreator::createEllipse): (WebCore::KCanvasCreator::createLine):
  • kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasContainerQuartz::paint): (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::pushContext): (WebCore::KRenderingDeviceQuartz::popContext): (WebCore::renderingDevice):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer):
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource):
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: (WebCore::SVGFEDiffuseLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: (SVGFESpecularLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer):
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::canvasResource):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (WebCore::SVGMarkerElementImpl::canvasResource): (WebCore::SVGMarkerElementImpl::createRenderer):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (WebCore::SVGMaskElementImpl::drawMaskerContent): (WebCore::SVGMaskElementImpl::createRenderer): (WebCore::SVGMaskElementImpl::canvasResource):
  • ksvg2/svg/SVGPathElementImpl.cpp: (WebCore::SVGPathElementImpl::toPathData):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (WebCore::SVGPatternElementImpl::drawPatternContentIntoTile): (WebCore::SVGPatternElementImpl::createRenderer): (WebCore::SVGPatternElementImpl::canvasResource):
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData):
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::createRenderer):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (WebCore::SVGStyledElementImpl::createRenderer):
  • ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): Updated to use renderingDevice instead of QPainter::renderingDevice.
11:19 PM Changeset in webkit [13066] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Fixed <rdar://problem/4448098> Switch PropertyMap deleted entry placeholder to -1 from UString::Rep::null

This turned out to be only a small speedup (.12%). That's within the
margin of error for super accurate JS iBench, but Shark confirms the
same, so I think it's worth landing.

FYI, I also confirmed that the single entry optimization in
PropertyMap is a 3.2% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::deletedSentinel):
10:37 PM Changeset in webkit [13065] by darin
  • 2 edits in trunk/WebCore
  • fixed part of the reason the build is broken
  • WebCore.xcodeproj/project.pbxproj: Updated project file.
10:23 PM Changeset in webkit [13064] by darin
  • 2 edits
    37 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved the WebCoreXXX files from kwq to appropriate directories

No changes to the contents of the files.

  • WebCore.xcodeproj/project.pbxproj: Updated project file.
  • bridge/mac/WebCoreCache.h: Added.
  • bridge/mac/WebCoreCache.mm: Added.
  • bridge/mac/WebCoreEncodings.h: Added.
  • bridge/mac/WebCoreEncodings.mm: Added.
  • bridge/mac/WebCoreFrameNamespaces.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m: Added.
  • bridge/mac/WebCoreFrameView.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Added.
  • bridge/mac/WebCoreJavaScript.mm: Added.
  • bridge/mac/WebCoreKeyboardAccess.h: Added.
  • bridge/mac/WebCoreResourceLoader.h: Added.
  • bridge/mac/WebCoreScriptDebugger.h: Added.
  • bridge/mac/WebCoreScriptDebugger.mm: Added.
  • bridge/mac/WebCoreSettings.h: Added.
  • bridge/mac/WebCoreSettings.mm: Added.
  • bridge/mac/WebCoreTextDecoder.h: Added.
  • bridge/mac/WebCoreTextDecoder.mm: Added.
  • bridge/mac/WebCoreViewFactory.h: Added.
  • bridge/mac/WebCoreViewFactory.m: Added.
  • bridge/mac/WebDashboardRegion.h: Added.
  • bridge/mac/WebDashboardRegion.m: Added.
  • kwq/WebCoreCache.h: Removed.
  • kwq/WebCoreCache.mm: Removed.
  • kwq/WebCoreCookieAdapter.h: Removed.
  • kwq/WebCoreCookieAdapter.m: Removed.
  • kwq/WebCoreEncodings.h: Removed.
  • kwq/WebCoreEncodings.mm: Removed.
  • kwq/WebCoreFrameNamespaces.h: Removed.
  • kwq/WebCoreFrameNamespaces.m: Removed.
  • kwq/WebCoreFrameView.h: Removed.
  • kwq/WebCoreGraphicsBridge.h: Removed.
  • kwq/WebCoreGraphicsBridge.m: Removed.
  • kwq/WebCoreHistory.h: Removed.
  • kwq/WebCoreHistory.m: Removed.
  • kwq/WebCoreImageRenderer.h: Removed.
  • kwq/WebCoreImageRendererFactory.h: Removed.
  • kwq/WebCoreImageRendererFactory.m: Removed.
  • kwq/WebCoreJavaScript.h: Removed.
  • kwq/WebCoreJavaScript.mm: Removed.
  • kwq/WebCoreKeyGenerator.h: Removed.
  • kwq/WebCoreKeyGenerator.m: Removed.
  • kwq/WebCoreKeyboardAccess.h: Removed.
  • kwq/WebCoreResourceLoader.h: Removed.
  • kwq/WebCoreScriptDebugger.h: Removed.
  • kwq/WebCoreScriptDebugger.mm: Removed.
  • kwq/WebCoreSettings.h: Removed.
  • kwq/WebCoreSettings.mm: Removed.
  • kwq/WebCoreTextDecoder.h: Removed.
  • kwq/WebCoreTextDecoder.mm: Removed.
  • kwq/WebCoreTextRenderer.h: Removed.
  • kwq/WebCoreTextRendererFactory.h: Removed.
  • kwq/WebCoreTextRendererFactory.mm: Removed.
  • kwq/WebCoreView.h: Removed.
  • kwq/WebCoreView.m: Removed.
  • kwq/WebCoreViewFactory.h: Removed.
  • kwq/WebCoreViewFactory.m: Removed.
  • kwq/WebDashboardRegion.h: Removed.
  • kwq/WebDashboardRegion.m: Removed.
  • platform/mac/WebCoreCookieAdapter.h: Added.
  • platform/mac/WebCoreCookieAdapter.m: Added.
  • platform/mac/WebCoreGraphicsBridge.h: Added.
  • platform/mac/WebCoreGraphicsBridge.m: Added.
  • platform/mac/WebCoreHistory.h: Added.
  • platform/mac/WebCoreHistory.m: Added.
  • platform/mac/WebCoreImageRenderer.h: Added.
  • platform/mac/WebCoreImageRendererFactory.h: Added.
  • platform/mac/WebCoreImageRendererFactory.m: Added.
  • platform/mac/WebCoreKeyGenerator.h: Added.
  • platform/mac/WebCoreKeyGenerator.m: Added.
  • platform/mac/WebCoreTextRenderer.h: Added.
  • platform/mac/WebCoreTextRendererFactory.h: Added.
  • platform/mac/WebCoreTextRendererFactory.mm: Added.
  • platform/mac/WebCoreView.h: Added.
  • platform/mac/WebCoreView.m: Added.
10:16 PM Changeset in webkit [13063] by hyatt
  • 46 edits
    3 deletes in trunk/WebCore

Fold QFont into Font and eliminate QFont completely.

Reviewed by eric

  • ForwardingHeaders/qfont.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setFont):
  • kwq/KWQFont.h: Removed.
  • kwq/KWQFont.mm: Removed.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetricsPrivate::~QFontMetricsPrivate): (QFontMetricsPrivate::getRenderer): (QFontMetricsPrivate::fontDescription): (QFontMetricsPrivate::setFontDescription): (QFontMetricsPrivate::getWebCoreFont): (QFontMetricsPrivate::isFixedPitch): (QFontMetricsPrivate::determinePitch): (QFontMetrics::QFontMetrics): (QFontMetrics::setFontDescription): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::selectionRectForText): (QFontMetrics::checkSelectionPoint): (QFontMetrics::getWebCoreFont): (QFontMetrics::isFixedPitch):
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (-[NSSearchField _addStringToRecentSearches:]): (QLineEdit::setFont):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): (QListBox::setFont): (-[KWQTableView drawRow:clipRect:]):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::font): (WebCore::QPainter::setFont): (WebCore::QPainter::fontMetrics): (WebCore::QPainter::_updateRenderer): (WebCore::QPainter::drawText): (WebCore::QPainter::drawHighlightForText):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::setFont):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setFont):
  • platform/Font.cpp: (khtml::Font::update):
  • platform/Font.h: (WebCore::): (WebCore::Font::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::operator!=): (WebCore::Font::fontMetrics): (WebCore::Font::pixelSize): (WebCore::Font::size): (WebCore::Font::letterSpacing): (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::isPrinterFont): (WebCore::Font::firstFamily): (WebCore::Font::family): (WebCore::Font::italic): (WebCore::Font::weight): (WebCore::Font::getNSFamily): (WebCore::Font::getNSFont): (WebCore::Font::getWebCoreFont):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription):
  • platform/FontFamily.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::font): (WebCore::Widget::setFont):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::font): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::findNextLineBreak):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::fontSize): (khtml::RenderStyle::fontMetrics): (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
9:31 PM Changeset in webkit [13062] by darin
  • 9 edits
    2 deletes in trunk

WebCore:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebCore.exp: Remove WebCoreScrollView class name.
  • kwq/WebCoreScrollView.h: Removed.
  • kwq/WebCoreScrollView.m: Removed.
  • WebCore.xcodeproj/project.pbxproj: Remove WebCoreScrollView source files.
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView autoforwardsScrollWheelEvents]): Added.
  • kwq/KWQTextArea.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView autoforwardsScrollWheelEvents]): Ditto.

WebKit:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebView/WebDynamicScrollBarsView.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView autoforwardsScrollWheelEvents]): Added.
6:54 PM Changeset in webkit [13061] by justing
  • 1 edit in trunk/LayoutTests/editing/editing.js

Forgot to check in my changes to editing.js

5:14 PM Changeset in webkit [13060] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): add ability to dump render tree and read from a local file.
5:14 PM Changeset in webkit [13059] by eseidel
  • 6 edits in trunk/WebCore

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix spacing/style on several of the stubs.
Reorganize stubs, separating empty stubs.
Remove the abort from certain stubs blocking DRT.
Add a virtual setView call to Frame baseclass.

  • bridge/mac/MacFrame.h: mark setView virtual
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): remove no-renderer hack
  • page/Frame.cpp: (WebCore::Frame::view): fix spacing (WebCore::Frame::setView): added.
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (notImplemented): make break directly into debugger. Moved, modified several other stubs not mentioned here.
1:00 PM Changeset in webkit [13058] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by mjs


Tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/editing.js:
  • editing/execCommand/insertHTML-expected.checksum: Added.
  • editing/execCommand/insertHTML-expected.png: Added.
  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html: Added.

WebCore:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/jsediting.cpp:
11:22 AM Changeset in webkit [13057] by mjs
  • 12 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.h: Added.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Initialize browser extension and settings.
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): Don't create renderers for now.
  • dom/EventNames.cpp: (WebCore::EventNames::init): use placement new even when not avoiding static constructors.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): ditto
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): ditto
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): Added default constructor but only in ifdef.
  • page/Frame.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init): use placement new even when not avoiding static constructors
  • platform/StaticConstructors.h: don't initialize when not avoiding static constructors, just default construct and let initialization happen normally
  • platform/win/TemporaryLinkStubs.cpp: Stub out some more things (Cursor::~Cursor): (QFont::~QFont): (QFontMetrics::~QFontMetrics): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::BrowserExtensionWin::getHistoryLength): (WebCore::BrowserExtensionWin::canRunModal): (WebCore::BrowserExtensionWin::openURLNotify): (WebCore::BrowserExtensionWin::canRunModalNow): (WebCore::BrowserExtensionWin::runModal): (WebCore::BrowserExtensionWin::goBackOrForward):
10:57 AM Changeset in webkit [13056] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Removed WKMouseIsDown()
  • libWebKitSystemInterface.a: ditto
10:48 AM Changeset in webkit [13055] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel


Wean WebKit from one more SPI call. We learned about this new-to-Tiger
API from filing Radar 4433222.

  • WebView/WebHTMLView.m: (-[WebHTMLView _autoscroll]): use public CGEventSourceButtonState() instead of WKMouseIsDown() (which was using SPI internally)
12:30 AM Changeset in webkit [13054] by eseidel
  • 121 edits in trunk

Fix line endings in two files, and apply svn:eol-style=native to all source files w/o it.

12:02 AM Changeset in webkit [13053] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove abort() from constructors to allow DRT to run.

  • platform/win/TemporaryLinkStubs.cpp: (QFont::QFont): (QFontMetrics::QFontMetrics):
Note: See TracTimeline for information about the timeline view.