Timeline



Mar 12, 2006:

2:17 PM Changeset in webkit [13265] by ap
  • 3 edits
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Maciej.

Test: fast/events/drag-outside-window.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::containsPoint): Always return true for the root object to ensure that mouse events occurring outside the window target the document.
2:09 PM Changeset in webkit [13264] by ap
  • 5 edits in trunk/WebCore

No test - only reproducible when Safari imports the bookmarks.

  • dom/EventNames.cpp: (WebCore::EventNames::init): Initialize AtomicString before using it.
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): Ditto.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): Ditto.
  • ksvg2/scripts/make_names.pl: Ditto.
12:30 PM Changeset in webkit [13263] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

Test: plugins/invoke.html

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Return a correct string length.
12:29 AM Changeset in webkit [13262] by ap
  • 3 edits
    16 adds in trunk

Patch by David Kilzer, reviewed by Darin.

WebCore:

  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Refactored code.

LayoutTests:

These tests cover the changed code. No change in behavior.

  • fast/invalid/missing-address-end-tag-expected.checksum: Added.
  • fast/invalid/missing-address-end-tag-expected.png: Added.
  • fast/invalid/missing-address-end-tag-expected.txt: Added.
  • fast/invalid/missing-address-end-tag.html: Added.
  • fast/invalid/missing-dl-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dl-end-tag-expected.png: Added.
  • fast/invalid/missing-dl-end-tag-expected.txt: Added.
  • fast/invalid/missing-dl-end-tag.html: Added.
  • fast/invalid/missing-dt-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dt-end-tag-expected.png: Added.
  • fast/invalid/missing-dt-end-tag-expected.txt: Added.
  • fast/invalid/missing-dt-end-tag.html: Added.
  • fast/invalid/missing-font-end-tag-expected.checksum: Added.
  • fast/invalid/missing-font-end-tag-expected.png: Added.
  • fast/invalid/missing-font-end-tag-expected.txt: Added.
  • fast/invalid/missing-font-end-tag.html: Added.

Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • bridge/win/FrameWin.h: Removed declaration of generateFrameName.
7:30 PM Changeset in webkit [13260] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Adele.

  • removed some unused stuff from Frame and MacFrame
  • page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
  • page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.
  • bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.
  • bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.
7:25 PM Changeset in webkit [13259] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • page/FrameTree.cpp: Add include of <stdarg.h>.
7:21 PM Changeset in webkit [13258] by darin
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

  • change how frame namespacing works to be more completely on the WebCore side
  • WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
  • WebView/WebFrame.m: Ditto.
  • WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].
7:17 PM Changeset in webkit [13257] by darin
  • 23 edits
    1 move
    8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

  • fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
  • fast/dom/Window/open-existing-pop-up-blocking.html: Added.
  • fast/dom/Window/resources/open-sibling-subframe.html: Added.
  • fast/dom/Window/resources/sibling-subframe-content.html: Added.
  • fast/frames/frame-name-reset.html: Added.
  • fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

  • refactor frame-name-related functions into the FrameTree object
  • WebCore.xcodeproj/project.pbxproj: Update for rename.
  • bridge/mac/MacFrame.h: Remove generateFrameName.
  • bridge/mac/MacFrame.mm: Ditto.
  • bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.
  • bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.
  • bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
  • bridge/mac/WebCoreFrameNamespaces.m: Renamed.
  • bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.
  • bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.
  • page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.
  • page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.
  • page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.
5:35 PM Changeset in webkit [13256] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin, harrison


~3x speedup pasting plain text from the console

  • dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):
4:19 PM Changeset in webkit [13255] by hyatt
  • 3 edits
    3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher
  • 5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix win32 networking to properly use async load API
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):
1:15 PM Changeset in webkit [13251] by eseidel
  • 3 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Fix build.

  • platform/win/FontWin.cpp: (WebCore::getFontData):
  • platform/win/TemporaryLinkStubs.cpp:
1:13 PM Changeset in webkit [13250] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute
  • fast/forms/radio-attr-order-expected.checksum: Added.
  • fast/forms/radio-attr-order-expected.png: Added.
  • fast/forms/radio-attr-order-expected.txt: Added.
  • fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

  • fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.
1:05 PM Changeset in webkit [13249] by eseidel
  • 24 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const
11:28 AM Changeset in webkit [13248] by hyatt
  • 6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):
10:58 AM Changeset in webkit [13247] by hyatt
  • 6 edits
    1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h: Added.
  • platform/FontRenderer.h: Removed.
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):
10:40 AM Changeset in webkit [13246] by hyatt
  • 2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Mar 9, 2006:

11:37 PM Changeset in webkit [13245] by justing
  • 2 edits in trunk/WebCore

Reviewed by adele


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7692>
Should use an iterator in CompositeEditCommand::doUnapply()


~30% speedup of a big undo

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): (WebCore::CompositeEditCommand::doReapply):
6:20 PM Changeset in webkit [13244] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Removed unnecessary alerts in TextIterator advance methods.
We want to be able to use advance() even if the iterator is already at the end.

  • editing/visible_text.cpp: (khtml::TextIterator::advance): remove assert since TextIterator will just do nothing if its already at the end. (khtml::CharacterIterator::advance): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): Since the asserts in the iterator are removed, we don't have to check for it.atEnd() before calling advance.
4:13 PM Changeset in webkit [13243] by thatcher
  • 5 copies in tags/JavaScriptCore-417.10/JavaScriptCore

New tag (part two).

4:12 PM Changeset in webkit [13242] by thatcher
  • 1 add in tags/JavaScriptCore-417.10

New tag.

3:39 PM Changeset in webkit [13241] by hyatt
  • 2 edits in trunk/WebCore

Make text paint with the pen color on Win32. Force ClearType quality. Make the face validation case-insensitive.

3:30 PM Changeset in webkit [13240] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-appearance-visibility-expected.checksum: Added.
  • fast/forms/input-appearance-visibility-expected.png: Added.
  • fast/forms/input-appearance-visibility-expected.txt: Added.
  • fast/forms/input-appearance-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/forms/input-appearance-visibility.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setStyle): Sets the style directly on the children of the inner div.
3:27 PM Changeset in webkit [13239] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/Info.plist

Versioning

3:21 PM Changeset in webkit [13238] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

  • bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto
  • bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().
2:48 PM Changeset in webkit [13237] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

SetBkMode to transparent so that TextOut doesn't erase the background when drawing text.

1:24 PM Changeset in webkit [13236] by hyatt
  • 8 edits
    2 adds in trunk/WebCore

Check in basic text rendering on Win32.

12:02 PM Changeset in webkit [13235] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison


Fixed formatting and changed functions to take in
a const Selection& instead of a Selection.

  • editing/ModifySelectionListLevelCommand.cpp: (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
  • editing/ModifySelectionListLevelCommand.h:
11:43 AM Changeset in webkit [13234] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-appearance-selection-expected.checksum: Added.
  • fast/forms/input-appearance-selection-expected.png: Added.
  • fast/forms/input-appearance-selection-expected.txt: Added.
  • fast/forms/input-appearance-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/input-appearance-selection.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): removed extra space. (WebCore::RenderTextField::select): Removed checks for document and m_div since there should always be a document and m_div will be initialized as the renderer gets attached. (WebCore::RenderTextField::selectionStart): Calls indexForVisiblePosition. (WebCore::RenderTextField::selectionEnd): ditto. (WebCore::RenderTextField::setSelectionStart): calls setSelectionRange. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::setSelectionRange): gets VisiblePositions for both indices, and sets the selection. (WebCore::RenderTextField::visiblePositionForIndex): Added helper method. (WebCore::RenderTextField::indexForVisiblePosition): Added helper method.
  • rendering/RenderTextField.h: Added new helper methods for selection.
9:19 AM Changeset in webkit [13233] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by John Sullivan.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Added code to release the plug-in object. This is the leak fix. (NPP_SetWindow): Remove unneeded code to store the window pointer.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Moved the browser global in here since it's declared in this file's header. Changed the code to set up the pluginClass structure to not use function pointer casts. Those are dangerous because they can hide many types of mismatch. And indeed when I did this I discovered that many functions were missing their boolean return values or had parameter declarations with the wrong types. (pluginGetProperty): Use STRINGZ_TO_NPVARIANT macro for greater simplicity and clarity. Added boolean return value: return true when successful and false when not. (pluginSetProperty): Added boolean return value, return false since we have no properties we can set. (pluginInvoke): Added boolean return value. Return true when successful and false when not. Use NPVARIANT macros where appropriate. Added a missing release for the return value from calling the browser. Changed code to put the strings in malloc buffers instead of relying on GCC's extension that allows variable-sized arrays on the stack. (pluginInvokeDefault): Added boolean return value, return false since we have no default function to call. (pluginInvalidate): Added missing parameter. Removed comment. (pluginAllocate): Removed unneeded cast. This is C code, not C++, so you don't have to cast the result of malloc. (pluginDeallocate): Removed uneeded cast.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Removed some unneeded includes. Changed our PluginObject to use NPObject instead of re-declaring fields that match NPObject's fields. Removed unused NPWindow pointer.
8:35 AM Changeset in webkit [13232] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/event-sender-mouse-click-expected.txt: Added.
  • fast/events/event-sender-mouse-click.html: Added.

WebKitTools:

Test: fast/events/event-sender-mouse-click.html

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController mouseClick]): Simulates a click in a native widget by queueing a mouseUp before sending the mouseDown, so that the widget's mouse tracking event loop doesn't hang indefinitely.
8:32 AM Changeset in webkit [13231] by darin
  • 3 edits
    1 copy
    8 moves
    6 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/canvas: Added.
  • fast/canvas/fillrect_gradient-expected.checksum: Added.
  • fast/canvas/fillrect_gradient-expected.png: Added.
  • fast/canvas/fillrect_gradient-expected.txt: Added.
  • fast/canvas/fillrect_gradient.html: Added.
  • moved other canvas tests here
  • fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • fast/canvas/image-object-in-canvas-expected.png: Added.
  • fast/canvas/image-object-in-canvas-expected.txt: Added.
  • fast/canvas/image-object-in-canvas.html: Added.
  • fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • fast/canvas/quadraticCurveTo-expected.png: Added.
  • fast/canvas/quadraticCurveTo-expected.txt: Added.
  • fast/canvas/quadraticCurveTo.xml: Added.
  • fast/canvas/resources: Added.
  • fast/canvas/resources/apple.gif: Added.
  • fast/dom/image-object-in-canvas-expected.checksum: Removed.
  • fast/dom/image-object-in-canvas-expected.png: Removed.
  • fast/dom/image-object-in-canvas-expected.txt: Removed.
  • fast/dom/image-object-in-canvas.html: Removed.
  • fast/dom/quadraticCurveTo-expected.checksum: Removed.
  • fast/dom/quadraticCurveTo-expected.png: Removed.
  • fast/dom/quadraticCurveTo-expected.txt: Removed.
  • fast/dom/quadraticCurveTo.xml: Removed.

WebCore:

Test: fast/canvas/fillrect_gradient.html

Reviewed by Darin.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::callAsFunction): Modified fillrect function to check and use a gradient if set. Builds a path to fill rects with a gradient.
8:10 AM Changeset in webkit [13230] by darin
  • 2 edits in trunk/WebCore

No test because this fixes an existing pixel test (and does not affect
the render tree).

Reviewed by Maciej.

  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Restored AlignRight behavior.
8:05 AM Changeset in webkit [13229] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint): Replaced call to Font::drawText with GraphicsContext::drawText, which checks the paintingDisabled flag.
2:57 AM Changeset in webkit [13228] by mjs
  • 10 edits in trunk

WebCore:

Reviewed by Eric.

  • make link clicks work by propagating them up to a client
  • Viewer/ImageView.cpp:
  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):

WebKitTools:

Reviewed by Eric.

  • make link clicks work by handling link click requests from WebCore
  • Spinneret/Spinneret/Spinneret.cpp: (updateLocationBar):
  • Spinneret/Spinneret/Spinneret.h:
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::openURL): (WebKit::WebFrame::loadURL):
  • Spinneret/Spinneret/WebFrame.h:
1:52 AM Changeset in webkit [13227] by eseidel
  • 4 edits in trunk/WebKitTools

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Focus URL bar on Spinneret launch, remove border from WebView.
Stop WebFrame from deleting the job (prevent crash).

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::receivedAllData): (WebKit::WebFrame::paint):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView):
1:49 AM Changeset in webkit [13226] by eseidel
  • 8 edits in trunk/WebCore

2006-03-09 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add support for Timers under 10ms.
Fix random crashers due to multi-threaded loading.

  • platform/TransferJob.h:
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
  • platform/Widget.h:
  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::initializeOffScreenTimerWindow): (WebCore::setSharedTimerFireTime):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::retrieveCharset):
  • platform/win/TransferJobWin.cpp: (WebCore::addToOutstandingJobs): (WebCore::removeFromOutstandingJobs): (WebCore::lookupTransferJob): (WebCore::TransferJobWndProc): (WebCore::initializeOffScreenTransferJobWindow): (WebCore::TransferJob::~TransferJob): (WebCore::transferJobStatusCallback): (WebCore::TransferJob::start): (WebCore::TransferJob::cancel):
  • platform/win/WidgetWin.cpp:

Mar 8, 2006:

9:49 PM Changeset in webkit [13225] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Darin.

WebKit:

  • Misc/WebNSURLExtras.h: Added _webkit_URLByRemovingResourceSpecifier.
  • Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Call _webkit_URLByRemovingResourceSpecifier to work around CFURL not removing non-path components from base URLs in some cases. (-[NSURL _webkit_URLByRemovingComponent:]): New generic function for removing URL components. (-[NSURL _webkit_URLByRemovingFragment]): Moved implementation to the above method. (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Added.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Added a method to test getURL.

LayoutTests:

  • plugins/geturl-replace-query-expected.txt: Added.
  • plugins/geturl-replace-query.html: Added.
6:28 PM Changeset in webkit [13224] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Added log entry that somehow didn't get checked in last night.

4:20 PM Changeset in webkit [13223] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth.

Clarified that sites on the list aren't necessarily "broken."

  • projects/compat/hitlist.html:
3:53 PM Changeset in webkit [13222] by hyatt
  • 18 edits in trunk/WebCore/platform/cairo

merge cairo to the mozilla trunk.

3:07 PM Changeset in webkit [13221] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)

  • editing/editing.js:
  • editing/execCommand/insertImage-expected.checksum: Added.
  • editing/execCommand/insertImage-expected.png: Added.
  • editing/execCommand/insertImage-expected.txt: Added.
  • editing/execCommand/insertImage.html: Added.
  • editing/pasteboard/3976872-expected.txt:

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)


Implemented InsertImage and also changed paste to use a single
rule for when to remove junk that remains after node removal.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp:
  • editing/jsediting.cpp:
2:51 PM Changeset in webkit [13220] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth.

Updated links to gap and bananarepublic bugs.

  • projects/compat/hitlist.html:
2:39 PM Changeset in webkit [13219] by thatcher
  • 3 copies in tags/WebKit-418/WebKit

New tag (part 2).

2:39 PM Changeset in webkit [13218] by thatcher
  • 1 add in tags/WebKit-418

New tag.

2:36 PM Changeset in webkit [13217] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

<rdar://problem/4464698> 10.4.6 REGRESSION: Safari 417.9 no longer works with gap.com (417.8 did)

  • Info.plist: bump the version to 418 to allow GAP's >= check to work
2:20 PM Changeset in webkit [13216] by eseidel
  • 2 edits in trunk/WebCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build script to properly copy dll files.

  • WebCore.vcproj/WebCore/build-generated-files.sh:
1:32 PM Changeset in webkit [13215] by eseidel
  • 69 edits
    4 adds in trunk

2006-03-08 Rob Buis <​buis@kde.org>

Reviewed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6899
SVG <rect> does not respect display: none

For svg elements that can render, call StyledElementImpl::rendererIsNeeded
to decide whether the element should render. In particular this way
any setting of display="none" is handled.

  • ksvg2/svg/SVGAElementImpl.h: (WebCore::SVGAElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGCircleElementImpl.h: (WebCore::SVGCircleElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGEllipseElementImpl.h: (WebCore::SVGEllipseElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGForeignObjectElementImpl.h: (WebCore::SVGForeignObjectElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGGElementImpl.h: (WebCore::SVGGElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGImageElementImpl.h: (WebCore::SVGImageElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGLineElementImpl.h: (WebCore::SVGLineElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGMarkerElementImpl.h: (WebCore::SVGMarkerElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGMaskElementImpl.h: (WebCore::SVGMaskElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGPathElementImpl.h: (WebCore::SVGPathElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGPatternElementImpl.h: (WebCore::SVGPatternElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGPolyElementImpl.h: (WebCore::SVGPolyElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGRectElementImpl.h: (WebCore::SVGRectElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGSVGElementImpl.h: (WebCore::SVGSVGElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGSwitchElementImpl.h: (WebCore::SVGSwitchElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGTSpanElementImpl.h: (WebCore::SVGTSpanElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGTextElementImpl.h: (WebCore::SVGTextElementImpl::rendererIsNeeded):
  • ksvg2/svg/SVGUseElementImpl.h: (WebCore::SVGUseElementImpl::rendererIsNeeded):
3:59 AM Changeset in webkit [13214] by mjs
  • 6 edits in trunk/WebKitTools

Reviewed by Eric.

  • load URLs, not file paths, in Spinneret
  • Spinneret/Spinneret/Spinneret.cpp: (MyEditProc):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadURL): (WebKit::WebFrame::receivedData): (WebKit::WebFrame::receivedAllData):
  • Spinneret/Spinneret/WebFrame.h:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):
3:56 AM Changeset in webkit [13213] by mjs
  • 4 edits in trunk/WebCore

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
  • platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):
3:40 AM Changeset in webkit [13212] by eseidel
  • 4 edits
    1 add in trunk/WebCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
  • platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):
2:59 AM Changeset in webkit [13211] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Partially fix JS on win32 by fixing hash table generation.

  • kjs/create_hash_table: limit << results to 32 bits.
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):
1:55 AM Changeset in webkit [13210] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fix another instance of the bug I just fixed in the Macintosh-specific code path
  • platform/image-decoders/gif/GIFImageReader.h: Remove not-so-useful 100ms constant.
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read): Use the correct rule for minimum frame durations.
1:43 AM Changeset in webkit [13209] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fix win32 build
  • platform/win/FontWin.cpp: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText):
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::clearFocusRing): (GraphicsContext::selectedTextBackgroundColor): (Font::selectionRectForText):
1:40 AM Changeset in webkit [13208] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

No layout test because I don't know how to test animated GIF speed.

  • platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Use the correct rule for minimum frame durations. It's a bit non-intuitive, so I made the comment more explicit. The old code in WebKit had this rule.
1:26 AM Changeset in webkit [13207] by darin
  • 3 edits in trunk

Reviewed by Eric.

  • fixed AppleScript layout test results to not be endian-dependent (Hyatt complained to me about this one)
  • DumpRenderTree/AppleScriptController.m: (-[AppleScriptController doJavaScript:]): Added specific code for dumping LongDateTime, instead of dumping the raw bytes (which are endian-dependent).
1:12 AM Changeset in webkit [13206] by hyatt
  • 9 edits in trunk/WebCore

Make GraphicsContext call into Font to draw all text and eliminate
all knowledge of WebTextRenderers from it.

Reviewed by darin

  • platform/Font.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspelling): (WebCore::GraphicsContext::misspellingLineThickness):
  • platform/GraphicsContext.h: (WebCore::GraphicsContext::platformContext):
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::platformContext):
  • platform/mac/FontMac.mm: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness):
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/FontWin.cpp: (WebCore::Font::drawText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
1:08 AM Changeset in webkit [13205] by darin
  • 2 edits in trunk/JavaScriptCore
  • kxmlcore/Vector.h: Quick fix to try to get Windows compiling again.
12:59 AM Changeset in webkit [13204] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fixed super-fast animation of many animated GIFs

No layout test because I don't know how to test animated GIF speed.

  • platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Always take the minimum duration into account, even if there's some kind of failure getting the duration from the GIF.
12:30 AM Changeset in webkit [13203] by darin
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Anders.

  • kjs/lexer.cpp: (Lexer::lex): Turn off the "yylex: ERROR" message.
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the code to log errors from PCRE to standard output. I think we should arrange for the error text to be in JavaScript exceptions instead at some point.
  • kxmlcore/Vector.h: Add a check for overflow so that we'll abort if we pass a too-large size rather than allocating a buffer smaller than requested.

WebCore:

Reviewed by Anders.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString): Pass XML_PARSE_NOERROR and XML_PARSE_NOWARNING. We don't want errors and warnings to be logged to stdout or stderr. If we later decide we want the error messages, then we should do the additional work to put them into the web page or the console (along with the JavaScript errors).
  • platform/ArrayImpl.cpp: (WebCore::ArrayImpl::resize): Add a preflight to protect against integer overflow due to large array size. Noticed this while looking into the malloc error message.

WebKit:

Reviewed by Anders.

  • WebView/WebDataSourcePrivate.h:
  • WebView/WebDataSource.m: (-[WebDataSource _setRepresentation:]): Clear the flag that records whether we've sent all the data to the representation or not; need this to prevent telling the same representation both that we've succeeded and then later that we've failed. (-[WebDataSource _setMainDocumentError:]): Don't send an error if representationFinishedLoading is already YES. Set representationFinishedLoading. (-[WebDataSource _finishedLoading]): Set representationFinishedLoading. (-[WebDataSource _setupForReplaceByMIMEType:]): Ditto.

WebKitTools:

Reviewed by Anders.

  • DumpRenderTree/DumpRenderTree.m: (checkedMalloc): Added. (checkedRealloc): Added. (makeLargeMallocFailSilently): Added. (main): Call makeLargeMallocFailSilently.
Note: See TracTimeline for information about the timeline view.