Timeline



Mar 14, 2006:

11:01 PM Changeset in webkit [13301] by justing
  • 9 edits
    6 adds in trunk

LayoutTests:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7578>
TinyMCE: Implement execCommand CreateLink

  • editing/editing.js:
  • editing/execCommand/createLink-expected.checksum: Added.
  • editing/execCommand/createLink-expected.png: Added.
  • editing/execCommand/createLink-expected.txt: Added.
  • editing/execCommand/createLink.html: Added.

WebCore:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7578>
TinyMCE: Implement execCommand CreateLink


Used ApplyStyleCommand so that creating a link from
a selection doesn't change document structure.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::doApply): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle):
  • editing/CreateLinkCommand.cpp: Added. (WebCore::CreateLinkCommand::CreateLinkCommand): (WebCore::CreateLinkCommand::doApply):
  • editing/CreateLinkCommand.h: Added.
  • editing/jsediting.cpp:
  • page/Frame.cpp: (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):
10:40 PM Changeset in webkit [13300] by bdakin
  • 12 edits in trunk

Reviewed by Maciej

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4171
This patch changes the word-break algorithm used to apply text-
transform:capitalize to use a UBreakIterator. This fixes some
existing edge cases we have in our text-transform:capitalize
support and generally makes our results more consistent.

7:41 PM Changeset in webkit [13299] by darin
  • 7 edits in trunk/LayoutTests

Rubber stamped by Hyatt.

  • land new results for two tests affected by Hyatt's layer change
  • fast/encoding/utf-16-big-endian-expected.checksum: Updated.
  • fast/encoding/utf-16-big-endian-expected.png: Ditto.
  • fast/encoding/utf-16-big-endian-expected.txt: Ditto.
  • fast/encoding/utf-16-little-endian-expected.checksum: Ditto.
  • fast/encoding/utf-16-little-endian-expected.png: Ditto.
  • fast/encoding/utf-16-little-endian-expected.txt: Ditto.
7:25 PM Changeset in webkit [13298] by justing
  • 5 edits in trunk/WebCore

Reviewed by adele


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7770>
Should only dispatch the khtmlTextInsertedEvent for high level editing operations

Dispatching this event for low level editing operations
isn't necessary and causes a big performance regression.
Also renamed the event because it's dispatched for changes
other than just text insertion.

  • dom/EventNames.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
  • khtml/html/HTMLTextFieldInnerElementImpl.cpp: (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler):
  • page/Frame.cpp: (WebCore::dispatchKHTMLEditableContentChanged): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):
6:47 PM Changeset in webkit [13297] by darin
  • 3 edits in trunk/LayoutTests
  • land new results for tests affected by my setAttribute change
  • dom/xhtml/level3/core/nodeisequalnode15-expected.txt: Updated to reflect a new kind of failure.
  • dom/xhtml/level3/core/nodeisequalnode16-expected.txt: Updated to reflect success.
6:07 PM Changeset in webkit [13296] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

Oops, forgot to add this file.

  • fast/js/resources/string-sort.js: Added.
5:17 PM Changeset in webkit [13295] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix <rdar://problem/4478121> -[WebCoreFrameBridge finalize] crashes under GC
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge finalize]): Don't call setBridge(nil).
5:09 PM Changeset in webkit [13294] by ggaren
  • 7 edits
    2 adds in trunk

JavaScriptCore:

  • Fixed <rdar://problem/4478239> string sort puts "closed" before "close"

Reviewed by Eric.

  • kjs/ustring.cpp: (KJS::compare): Inverted a < in order to treat the longer string as > the shorter string.

LayoutTests:

Reviewed by Eric.

Layout test for <rdar://problem/4478239> string sort puts "closed"
before "close"

Also changed the engine to report data types when tests fail, so that
you don't get messages like, "should be A, was A."

Updated results for these files:

  • fast/js/kde/Array-expected.txt:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/encode_decode_uri-expected.txt:
  • fast/js/resources/js-test-pre.js:

Added these files:

  • fast/js/string-sort-expected.txt: Added.
  • fast/js/string-sort.html: Added.
3:54 PM Changeset in webkit [13293] by darin
  • 2 edits in trunk/WebCore
  • oops, didn't mean to check this in
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::parseMappedAttribute): Reverted nil-document check that I didn't mean to remove.
3:53 PM Changeset in webkit [13292] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6796

3:50 PM Changeset in webkit [13291] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6796
This fix prevents infinite recursion when a block with overflow:
auto can't decide if it needs scrollbars or not. This fix puts a
guard in place in updateScrollInforAfterLayout that only allows you
to re-layout if you are not currently laying out.

3:01 PM Changeset in webkit [13290] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

The fix occurred somewhere between r9638 (2005-07-09) and the first CVS
nightly build (WebKit-CVS-2005-10-01 03-27-01 GMT.dmg).

  • fast/dom/setAttribute-using-initial-input-value-expected.txt: Added.
  • fast/dom/setAttribute-using-initial-input-value.html: Added.
2:58 PM Changeset in webkit [13289] by darin
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff and Eric.

  • fast/dom/Element/attribute-uppercase.html: Added.
  • fast/dom/Element/attribute-uppercase-expected.txt: Added.

WebCore:

Reviewed by Geoff and Eric.

  • fix <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7765>, <rdar://problem/4474884> hasAttribute always returns false for uppercase attribute names like "STYLE"
  • re-add missing JavaScript binding for getAttributeNS
  • fixed handling of null namespace parameters in getAttributeNS and friends

Test: fast/dom/Element/attribute-uppercase.html

To match Gecko's behavior, the magic "lowercasing" of all attribute names
is only done when calling DOM Level 1 functions that lack an NS suffix.
The functions with an NS suffix are case sensitive, even in HTML documents.

  • dom/NamedNodeMapImpl.h: Changed getNamedItem and removeNamedItem to be pure virtual functions instead of calling through to getNamedItemNS and removeNamedItemNS.
  • dom/dom_elementimpl.h: Eliminated inline versions of non-NS functions that called the NS functions. They can't work that way any more since the lowercasing behavior is different.
  • dom/dom_elementimpl.cpp: (WebCore::ElementImpl::getAttribute): Added. Lowercases the name if the document is an HTML document, and then calls through to the qualified name version. Removed the null check since getDocument is guaranteed to never return 0 now that nodes hold a reference to their document. (WebCore::ElementImpl::getAttributeNS): Removed the lowercasing code. (WebCore::ElementImpl::setAttribute): More of the same. (WebCore::ElementImpl::setAttributeNS): Ditto. (WebCore::ElementImpl::removeAttribute): Ditto. (WebCore::ElementImpl::removeAttributeNS): Ditto. (WebCore::ElementImpl::getAttributeNode): Ditto. (WebCore::ElementImpl::getAttributeNodeNS): Ditto. (WebCore::ElementImpl::hasAttribute): Ditto. (WebCore::ElementImpl::hasAttributeNS): Ditto. (WebCore::NamedAttrMapImpl::getNamedItem): Ditto. (WebCore::NamedAttrMapImpl::getNamedItemNS): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto. (WebCore::StyledElementImpl::parseMappedAttribute): Removed another unneeded null check like the one mentioned above.
  • dom/Element.idl: Set ConvertNullToNullString for all the namespaceURI parameters, since we don't want null to turn into "null". Added a semicolon to the end of the hasAttributeNS line -- was causing the next declaration to be eaten up (so getAttributeNS was completely broken).
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): Call valueToStringWithNullCheck to do the equivalent of ConvertNullToNullString for both getNamedItemNS and removeNamedItemNS.
  • bindings/js/JSDOMCore.cpp: Touched so that the changes above will take effect.
12:11 PM Changeset in webkit [13288] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4476873> Support printing for plugin documents (not embedded plugins)

  • WebView/WebFrameViewPrivate.h:
  • WebView/WebFrameView.m: (-[WebFrameView documentViewShouldHandlePrint]): Called by the host application before it initializes and runs a print operation. If NO is returned, the host application will abort its print operation and call -printDocumentView on the WebFrameView. The document view is then expected to run its own print operation. If YES is returned, the host application's print operation will continue as normal. (-[WebFrameView printDocumentView]): Called by the host application when the WebFrameView returns YES from -documentViewShouldHandlePrint.
  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView documentViewShouldHandlePrint]): Allow the plugin to take over printing if it defines an NPP_Print function (-[WebNetscapePluginDocumentView printDocumentView]): Print the plugin document.
3:21 AM Changeset in webkit [13287] by hyatt
  • 1 edit in trunk/WebCore/rendering/render_layer.cpp

Fix the setpos to move screwup. Didn't realize move was a delta.

3:03 AM Changeset in webkit [13286] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 7259, opacity performs badly.

Reviewed by mjs

Adding some tests in fast/opacity.

  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
  • rendering/render_layer.cpp: (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/render_layer.h: (WebCore::RenderLayer::root):
2:52 AM Changeset in webkit [13285] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make the URL bar relinquish focus on page load.

  • Spinneret/Spinneret/Spinneret.cpp: (MyEditProc):
2:33 AM Changeset in webkit [13284] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix WebView to allow KeyFocus.
Add handling of space and shift-space for scrolling.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::scrollMessageForKey): (WebKit::WebViewWndProc):
1:49 AM Changeset in webkit [13283] by eseidel
  • 2 edits in trunk/WebCore

2006-03-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix Gif crasher.

  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::do_lzw): Initialize array after new.
1:19 AM Changeset in webkit [13282] by eseidel
  • 2 edits in trunk/WebCore

2006-03-14 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make MouseEvents aware of current scroll position.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport):

Mar 13, 2006:

11:40 PM Changeset in webkit [13281] by eseidel
  • 2 edits in trunk/WebCore

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix mouse events to be window-relative.

  • platform/win/MouseEventWin.cpp: (WebCore::positionForEvent): (WebCore::globalPositionForEvent): (WebCore::MouseEvent::MouseEvent):
11:05 PM Changeset in webkit [13280] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Add scrolling support into Spinneret.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView): (WebKit::calculateScrollDelta): (WebKit::scrollMessageForKey): (WebKit::WebViewWndProc):
10:25 PM Changeset in webkit [13279] by eseidel
  • 3 edits in trunk/WebCore

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Close DeviceContext leaks in Font code.
Also add moveCursor stub to make maps.google.com not crash.

  • platform/win/FontWin.cpp: (WebCore::getFontData): (WebCore::Font::floatWidth): (WebCore::Font::drawText):
  • platform/win/TemporaryLinkStubs.cpp: (Cursor::Cursor): (WebCore::moveCursor):
8:50 PM Changeset in webkit [13278] by eseidel
  • 4 edits in trunk/WebKitTools

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix checksum generation on Intel machines.
Also moved to CGImage APIs instead of NSBitmapImageRep, may possibly
give a small speed boost now that it uses a shared buffer.

  • DumpRenderTree/DumpRenderTree.m: (main): (dump): (md5HashStringForBitmap):
  • DumpRenderTree/ImageDiff.m: (computePercentageDifferent):
7:30 PM Changeset in webkit [13277] by eseidel
  • 3 edits
    5 adds in trunk

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):
6:26 PM Changeset in webkit [13276] by eseidel
  • 8 edits
    4 adds in trunk

2006-03-10 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7666:
dasharray on rounded rectangles is broken

Make sure the rounded rectangle is drawn clockwise, as outlined
in the specification.

Test: svg/custom/dashArrayOrigin.svg

  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle):
4:15 PM Changeset in webkit [13275] by thatcher
  • 4 copies in tags/WebCore-417.24/WebCore

New tag (part 2).

4:14 PM Changeset in webkit [13274] by thatcher
  • 1 add in tags/WebCore-417.24

New tag.

4:14 PM Changeset in webkit [13273] by thatcher
  • 5 copies in tags/JavaScriptCore-417.11/JavaScriptCore

New tag (part 2).

4:14 PM Changeset in webkit [13272] by thatcher
  • 1 add in tags/JavaScriptCore-417.11

New tag.

4:12 PM Changeset in webkit [13271] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

4:09 PM Changeset in webkit [13270] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)

Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.


  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::windowScriptNPObject): Removed the check Darin added to return 0 when JavaScript is disabled. This method cannot return 0, because plugins are not guaranteed to check for that. Removed my old fix for Radar 4428609 (7015) in favor of a better solution. Instead of creating a "dummy" JSObject to represent the window script object when JavaScript is disabled, we use the new JavaScriptCore bindings API to create a "no script" NPObject. This solution is better because it does not cause entry into any JavaScript interpreter code.
  • manual-tests/NPN_Invoke: Added.
  • manual-tests/NPN_Invoke/English.lproj: Added.
  • manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
  • manual-tests/NPN_Invoke/Info.plist: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
  • manual-tests/NPN_Invoke/main.c: Added.
  • manual-tests/NPN_Invoke/test.html: Added.
2:16 PM Changeset in webkit [13269] by ggaren
  • 4 edits in trunk/WebKit

Reviewed by timo.

  • Fixed the load progress indicator to give more incremental feedback, and to stop spending so much time near 100%.

I did two things:
(1) Fixed some bugs and a misspelling in the previous heuristic's
implementation
(2) Added two new rules to the heuristic:

(a) Treat the first layout as the half-way point.
(b) Just like we jump the first 10% to indicate that a load has
started, jump the last 10% to indicate that a load has finished.

Rule 2a is good for two reasons. First, it seems unnatural for loading
to be "more than half done" when you can't even see anything. Second,
in the early stages of laading our estimate of how much we'll need to
load is often off by as much as 6000% (e.g., cnn.com). So anything that
makes the progress indicator more conservative in the early stages of
loading is helpful.

Rule 2b is good because it's confusing for loading to be "100% done"
but still ongoing.

FIXME: The indicator still isn't perfect. For example, the old behavior
shows up @ moviefone.com. Two areas for future work:
(1) Estimate number of linked resources. Our code estimates the size
of a single resource, but does nothing to estimate the number of
resources that resource might link to. This is the key to why we're
so wrong at the beginning.
(2) Improve "when to do first layout" heuristic. A JavaScript query
for a style property forces layout, creating a phantom first layout
with no content, essentially nullifying 2a for certain pages.


Filed <rdar://problem/4475834> to track estimating the number of
linked resources. Phantom layouts are already on Hyatt's radar.

  • WebView/WebFrame.m: (-[WebFrame _setState:]): Update firstLayoutDone (-[WebFrame _numPendingOrLoadingRequests:]): Bug fix: In the recurisve case, query 'frame' instead of 'self', so that we actually recurse. (-[WebFrame _firstLayoutDone]): New method (-[WebFrame _didFirstLayout]): Update firstLayoutDone
  • WebView/WebFramePrivate.h: Added firstLayoutDone ivar
  • WebView/WebView.m: (-[WebView _incrementProgressForConnectionDelegate:data:]): (1) Implemented 2a and 2b (2) Bug fix: only update the 'last time I sent a notification' time if we actually send a notification. (3) Don't test for progress < 0 because ensuring progress < max also ensures max - progress > 0. (Do still test for progress > max because rounding errors make that a possibility -- although a very minor one.) (4) Query only the loading frame and its subframes for pending requests instead of defaulting to the main frame. This is a slight optimization in cases where the main frame did not begin the load, and it makes the code more consistent.
12:00 PM Changeset in webkit [13268] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/run-webkit-tests: Fix httpd handling to work on systems that have it named httpd-1.3 instead.
11:55 AM Changeset in webkit [13267] by ap
  • 2 edits in trunk/WebKitTools

Fix proposed by Mitz Pettel, reviewed by Darin.

  • Scripts/run-webkit-tests: Make test paths canonical, to form proper URLs (sequences of slashes are equivalent to a single slash in POSIX paths, but not in URLs).
11:29 AM Changeset in webkit [13266] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4475857> API: Setting a history item limit programmatically doesn't work
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): use [self historyItemLimit], which prefers the explicitly-set value and falls back to the NSUserDefaults value, instead of using the NSUserDefaults value explicitly.

Mar 12, 2006:

2:17 PM Changeset in webkit [13265] by ap
  • 3 edits
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Maciej.

Test: fast/events/drag-outside-window.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::containsPoint): Always return true for the root object to ensure that mouse events occurring outside the window target the document.
2:09 PM Changeset in webkit [13264] by ap
  • 5 edits in trunk/WebCore

No test - only reproducible when Safari imports the bookmarks.

  • dom/EventNames.cpp: (WebCore::EventNames::init): Initialize AtomicString before using it.
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): Ditto.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): Ditto.
  • ksvg2/scripts/make_names.pl: Ditto.
12:30 PM Changeset in webkit [13263] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

Test: plugins/invoke.html

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Return a correct string length.
12:29 AM Changeset in webkit [13262] by ap
  • 3 edits
    16 adds in trunk

Patch by David Kilzer, reviewed by Darin.

WebCore:

  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Refactored code.

LayoutTests:

These tests cover the changed code. No change in behavior.

  • fast/invalid/missing-address-end-tag-expected.checksum: Added.
  • fast/invalid/missing-address-end-tag-expected.png: Added.
  • fast/invalid/missing-address-end-tag-expected.txt: Added.
  • fast/invalid/missing-address-end-tag.html: Added.
  • fast/invalid/missing-dl-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dl-end-tag-expected.png: Added.
  • fast/invalid/missing-dl-end-tag-expected.txt: Added.
  • fast/invalid/missing-dl-end-tag.html: Added.
  • fast/invalid/missing-dt-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dt-end-tag-expected.png: Added.
  • fast/invalid/missing-dt-end-tag-expected.txt: Added.
  • fast/invalid/missing-dt-end-tag.html: Added.
  • fast/invalid/missing-font-end-tag-expected.checksum: Added.
  • fast/invalid/missing-font-end-tag-expected.png: Added.
  • fast/invalid/missing-font-end-tag-expected.txt: Added.
  • fast/invalid/missing-font-end-tag.html: Added.

Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • bridge/win/FrameWin.h: Removed declaration of generateFrameName.
7:30 PM Changeset in webkit [13260] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Adele.

  • removed some unused stuff from Frame and MacFrame
  • page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
  • page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.
  • bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.
  • bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.
7:25 PM Changeset in webkit [13259] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • page/FrameTree.cpp: Add include of <stdarg.h>.
7:21 PM Changeset in webkit [13258] by darin
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

  • change how frame namespacing works to be more completely on the WebCore side
  • WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
  • WebView/WebFrame.m: Ditto.
  • WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].
7:17 PM Changeset in webkit [13257] by darin
  • 23 edits
    1 move
    8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

  • fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
  • fast/dom/Window/open-existing-pop-up-blocking.html: Added.
  • fast/dom/Window/resources/open-sibling-subframe.html: Added.
  • fast/dom/Window/resources/sibling-subframe-content.html: Added.
  • fast/frames/frame-name-reset.html: Added.
  • fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

  • refactor frame-name-related functions into the FrameTree object
  • WebCore.xcodeproj/project.pbxproj: Update for rename.
  • bridge/mac/MacFrame.h: Remove generateFrameName.
  • bridge/mac/MacFrame.mm: Ditto.
  • bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.
  • bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.
  • bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
  • bridge/mac/WebCoreFrameNamespaces.m: Renamed.
  • bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.
  • bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.
  • page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.
  • page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.
  • page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.
5:35 PM Changeset in webkit [13256] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin, harrison


~3x speedup pasting plain text from the console

  • dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):
4:19 PM Changeset in webkit [13255] by hyatt
  • 3 edits
    3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher
  • 5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix win32 networking to properly use async load API
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):
1:15 PM Changeset in webkit [13251] by eseidel
  • 3 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Fix build.

  • platform/win/FontWin.cpp: (WebCore::getFontData):
  • platform/win/TemporaryLinkStubs.cpp:
1:13 PM Changeset in webkit [13250] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute
  • fast/forms/radio-attr-order-expected.checksum: Added.
  • fast/forms/radio-attr-order-expected.png: Added.
  • fast/forms/radio-attr-order-expected.txt: Added.
  • fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

  • fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.
1:05 PM Changeset in webkit [13249] by eseidel
  • 24 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const
11:28 AM Changeset in webkit [13248] by hyatt
  • 6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):
10:58 AM Changeset in webkit [13247] by hyatt
  • 6 edits
    1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h: Added.
  • platform/FontRenderer.h: Removed.
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):
10:40 AM Changeset in webkit [13246] by hyatt
  • 2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Note: See TracTimeline for information about the timeline view.